Re: Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/#review120671
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 25, 2016, 1:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43971/
> ---
> 
> (Updated Feb. 25, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4768
> https://issues.apache.org/jira/browse/MESOS-4768
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The accept/decline of the inverse offers in the test could arrive after the 
> clock is paused and advanced in the test.  This meant that the test would 
> trigger an allocation and then idle (because the clock is paused).  This is 
> the same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 
> .
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43971/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43974: Fixed compilation error in GroupTest.ConnectTimer.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43974/#review120670
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 25, 2016, 2:04 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43974/
> ---
> 
> (Updated Feb. 25, 2016, 2:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp bb548f4681a70717305ccb0ebc4ead643d553e2e 
> 
> Diff: https://reviews.apache.org/r/43974/diff/
> 
> 
> Testing
> ---
> 
> make check (without --disable-java) on Centos 7 & Debian 8 & Ubuntu 14
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43855: Added Appc fetcher support to store.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120561
---



First pass. Will do a second pass once the comments below are addressed. Thanks 
Jojy!


src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 115)


What does 'load' do?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 130)


you can do:
```
uriFetcher->share()
```

Also, this fits in one line?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 197)


First, we rarely use 'shared_ptr' directly. Second, I think we should be 
able to avoid this pointer. What you can do is that:

1) `fetchImage` will return `vector` which means: fetch this image 
and all its dependencies, return me the list of image ids.

2) I think `fetchDependencies` can return `vector` as well, which 
basically says that fetch the dependencies of this image id, and give me the 
list of dependent image ids.

3) Similarly, `fetchDependency` will return `vector` as well.

This recursion patter sounds more clear to me, instead of passing around 
the result pointer.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 199)


This check sounds unnecessary.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 203)


s/rootfsDirs/rootfses/



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 217)


Why return 'Path' here. Isn't returning the image id more clear?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 284)


I would put it under a staging directory, like we did in docker.
```
/staging/
```

Also, s/mkdir/staging/



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 291)


s/tmpFetchDir/staging/


- Jie Yu


On Feb. 23, 2016, 3:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> ---
> 
> (Updated Feb. 23, 2016, 3:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
>   src/tests/fetcher_cache_tests.cpp e10b3f7ebc21c8c1095564fc40f123087dcf320e 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> ---
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43937: Added missing `json` declaration for `ExecutorInfo`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43937/#review120665
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 24, 2016, 9:06 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43937/
> ---
> 
> (Updated Feb. 24, 2016, 9:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4754
> https://issues.apache.org/jira/browse/MESOS-4754
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See JIRA ticket.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp f88590f0a31f5d267e0716dda52a8126cd1ba5cd 
> 
> Diff: https://reviews.apache.org/r/43937/diff/
> 
> 
> Testing
> ---
> 
> Manaully launched master, agent, `long-lived-framework` and queried the 
> `/state` endpoint.
> 
> 
> ## 0.26.0
> 
> ```
> "executors": [
> {
> "command": {
> "argv": [],
> "uris": [],
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": "default",
> "framework_id": 
> "0ea528a9-64ba-417f-98ea-9c4b8d418db6-",
> "name": "Long Lived Executor (C++)",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
> }
> ],```
> 
> ## 0.27.1
> 
> ```
> "executors": [
> {
> "command": {
> "shell": true,
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": {
> "value": "default"
> },
> "framework_id": {
> "value": "368a5a49-480b-41f6-a13b-24a69c92a72e-"
> },
> "name": "Long Lived Executor (C++)",
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0",
> "source": "cpp_long_lived_framework"
> }
> ],
> ```
> 
> ## with this patch
> 
> ```
> "executors": [
> {
> "command": {
> "argv": [],
> "uris": [],
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": "default",
> "framework_id": 
> "c660529a-c5ce-4aa4-8a67-67657b564a4e-",
> "name": "Long Lived Executor (C++)",
> "resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
> }
> ],
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120664
---


Ship it!




Ship It!

- Jian Qiu


On 二月 25, 2016, 5:59 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated 二月 25, 2016, 5:59 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/
---

(Updated Feb. 24, 2016, 9:59 p.m.)


Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
Jian Qiu.


Changes
---

Update a comment that was left behind from a previous review.


Bugs: MESOS-4677
https://issues.apache.org/jira/browse/MESOS-4677


Repository: mesos


Description
---

Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
tasks and the test reading said cgroup tasks.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 

Diff: https://reviews.apache.org/r/43961/diff/


Testing
---

make check

Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
--gtest_repeat=5000 --gtest_break_on_failure

---

CI results:

sudo make check

 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 12 |
 Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |
 :)|
With-SSL |  :) |@_@   | *| &|   :) |:) |
 :)|

 :) = Passed.
X_X = Configuration error with docker.
@_@ = Ran out of disk space in some tests: 
LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem

  * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
issue)
  % = DockerContainerizerTest.ROOT_DOCKER_Logs


Thanks,

Joseph Wu

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/
---

(Updated Feb. 24, 2016, 9:43 p.m.)


Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.


Changes
---

Added JIRA number in a comment.


Bugs: MESOS-4676
https://issues.apache.org/jira/browse/MESOS-4676


Repository: mesos


Description
---

Adds the `unbuffer` utility in front of each `echo` in the test.  Since Docker 
appears to handle simultaneous stdout/stderr in a non-robust fashion, this 
mitigates the amount of overlap the two streams will have in the test.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 

Diff: https://reviews.apache.org/r/43963/diff/


Testing
---

make check

On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
--gtest_repeat=1200 --gtest_break_on_failure

---

CI results: 
sudo make check

 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 12 |
 Non-SSL |  :) |:)| *|:)|   :) |:) |
 :)|
With-SSL |  :) |:)|&*| &|^ |:) |
 :)|

 :) = Passed.

Known flaky tests:
  * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
  & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
  ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids


Thanks,

Joseph Wu

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

> On Feb. 23, 2016, 9:46 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, lines 123-128
> > 
> >
> > Can you use following logic to get docker version here? 
> > 
> > Future version_ = this->version();
> > 
> > if (!version_.await(DOCKER_VERSION_WAIT_TIMEOUT)) {
> > return Error("Timed out getting docker version");
> >   }
> > 
> > if (version_.isFailed()) {
> > return Error("Failed to get docker version: " + version.failure());
> >   }
> > 
> > // Get the docker version.
> > version = version_;
> > 
> > I think that the logic of `validateVersion` may also need some udpate 
> > by removing the logic of getting versions in `validateVersion` but only 
> > left the compare part.
> 
> Abhishek Dasgupta wrote:
> Just to make it clear, so you are advicing to get the current docker 
> version inside Docker::create and use validateVersion only to compare 
> versions? So, return type of validateversion should be reverted back to 
> Try again.
> 
> Guangya Liu wrote:
> Yes, what do you say?

splitting logic of docker version in Docker::create has some impacts like some 
testcases don't start a Docker from Docker::create. So to be aligned with your 
suggestion, I moved some of the logic from validateVersion to Docker::version() 
and updated the docker variable inside Docker::version(). Thank you.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review120283
---


On Feb. 24, 2016, 2:10 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Feb. 24, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 25, 2016, 5:32 a.m.)


Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.


Summary (updated)
-

Updated support/generate-endpoint-help.py to include title.


Repository: mesos


Description
---

support/generate-endpoint-help.py is adding a title to every generated endpoint 
markdown file.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43974: Fixed compilation error in GroupTest.ConnectTimer.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43974/#review120661
---


Ship it!




Ship It!

- Neil Conway


On Feb. 25, 2016, 2:04 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43974/
> ---
> 
> (Updated Feb. 25, 2016, 2:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp bb548f4681a70717305ccb0ebc4ead643d553e2e 
> 
> Diff: https://reviews.apache.org/r/43974/diff/
> 
> 
> Testing
> ---
> 
> make check (without --disable-java) on Centos 7 & Debian 8 & Ubuntu 14
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43932: Added overlayfs provisioning backend.

[Cong Wang]

> On Feb. 25, 2016, 2:52 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 106
> > 
> >
> > just a question, does there are any policy when to use `Failure` and 
> > `Error`

Failure is for Future, Error is for Try/Result.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120649
---


On Feb. 24, 2016, 4:38 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 24, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43461: Used foreach loop to iterate std list/set.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/
---

(Updated Feb. 25, 2016, 4:11 a.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
---

Address review comments


Summary (updated)
-

Used foreach loop to iterate std list/set.


Repository: mesos


Description (updated)
---

Used foreach loop to iterate std list/set.


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 

Diff: https://reviews.apache.org/r/43461/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Cong Wang]

> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 791
> > 
> >
> > * Mesos currently uses `foreach` from stout rather than 
> > range-based`for`.
> > * Mesos generally prefers explicit types than `auto`.
> > 
> > ```
> > foreach (Future future, futures) {
> >   ...
> > }
> > ```
> > 
> > Here and below.
> 
> Cong Wang wrote:
> Is that a strict rule? At least 
> src/tests/hierarchical_allocator_tests.cpp uses for(auto...) too.
> 
> Michael Park wrote:
> Yeah, those shouldn't have made it into the codebase for consistency. The 
> migration strategy is being discussed/tracked here: 
> [MESOS-3214](https://issues.apache.org/jira/browse/MESOS-3214).

OK. I will use foreach before we migrate to C++11 for loop.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
---


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/#review120652
---


Ship it!




Ship It!

- haosdent huang


On Feb. 25, 2016, 1:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43971/
> ---
> 
> (Updated Feb. 25, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4768
> https://issues.apache.org/jira/browse/MESOS-4768
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The accept/decline of the inverse offers in the test could arrive after the 
> clock is paused and advanced in the test.  This meant that the test would 
> trigger an allocation and then idle (because the clock is paused).  This is 
> the same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 
> .
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43971/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43978: Wait until processed offer before advance clock.

[haosdent huang]

> On Feb. 25, 2016, 1:58 a.m., Joseph Wu wrote:
> > I should have noted this: https://reviews.apache.org/r/43971/

Got it, let me discard.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43978/#review120642
---


On Feb. 25, 2016, 1:56 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43978/
> ---
> 
> (Updated Feb. 25, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait until processed offer before advance clock.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43978/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43932: Added overlayfs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120649
---




src/slave/containerizer/mesos/provisioner/backend.cpp (lines 23 - 24)


add a blank line here



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 55)


what about adding user name in the Error message?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 106)


just a question, does there are any policy when to use `Failure` and `Error`



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 115)


return Failure(
"Failed to create container rootfs at '" + rootfs + "': " + 
mkdir.error());


- Guangya Liu


On 二月 24, 2016, 4:38 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated 二月 24, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120648
---




src/tests/containerizer/isolator_tests.cpp (line 819)


LGTM, Could you help changing the comment here?


- Jian Qiu


On 二月 24, 2016, 9:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated 二月 24, 2016, 9:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/#review120650
---


Ship it!




Verify that add unbuffer works!

- haosdent huang


On Feb. 25, 2016, 2 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43963/
> ---
> 
> (Updated Feb. 25, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4676
> https://issues.apache.org/jira/browse/MESOS-4676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the `unbuffer` utility in front of each `echo` in the test.  Since 
> Docker appears to handle simultaneous stdout/stderr in a non-robust fashion, 
> this mitigates the amount of overlap the two streams will have in the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
> 
> Diff: https://reviews.apache.org/r/43963/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
> --gtest_repeat=1200 --gtest_break_on_failure
> 
> ---
> 
> CI results: 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |:)| *|:)|   :) |:) |  
>:)|
> With-SSL |  :) |:)|&*| &|^ |:) |  
>:)|
> 
>  :) = Passed.
> 
> Known flaky tests:
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Guangya Liu]

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote:
> > include/mesos/v1/mesos.proto, lines 1543-1544
> > 
> >
> > We're going to introduce a ContainerInfo.NetworkInfo.name to allow 
> > frameworks to specify the network they want to join. Note that  NetworkInfo 
> > in ContainerInfo is repeated which allows us to express the situation where 
> > a container wants to join multiple networks.
> > 
> > As we did for ContainerInfo.volumes, I think command configurations for 
> > a container should go to top level. This also avoids the confusion that 
> > 'network_name' is set in DockerInfo while there's another NetworkInfo.name.
> > 
> > I think what I am proposing is that: we add a NetworkInfo.name, and if 
> > DOckerInfo.network is not set and NetworkInfo.name is set, the docker 
> > containerizer will do --net=.
> 
> Guangya Liu wrote:
> Does it make sense to use the `repeated string groups` field in 
> NetworkInfo? I think that we can treate the groups as different user defined 
> networks. If we added `repeated string names` field, then what are the 
> difference between those two fields?
> 
> `
> // A group is the name given to a set of logically-related interfaces that
> // are allowed to communicate among themselves. Network traffic is allowed
> // between two container interfaces that share at least one network group.
> // For example, one might want to create separate groups for isolating 
> dev,
> // testing, qa and prod deployment environments.
> repeated string groups = 3;
> `
> 
> Jie Yu wrote:
> What i am suggesting is to add a singular name field:
> ```
> message NetworkInfo {
>   optional string name;
> }
> ```
> 
> NetworkInfo itself is repeated in ContainerInfo
> 
> Guangya Liu wrote:
> Thanks Yu Jie, still a bit confused, can you please explain more? :-)
> 
> What is the advantage of adding the following instead of `optional string 
> network_name = 8;`? 
> 
> message NetworkInfo {
>   optional string name;
> }
> 
> Also once add a singular `NetworkInfo`, do we still need to add the 
> `optional string network_name` field?
> 
> Qian Zhang wrote:
> I think what we are going to do is to add a singular `name` field in the 
> existing `NetworkInfo` message rather than to add a singular `NetworkInfo` 
> message.

@Ezra, FYI, There is a JIRA https://issues.apache.org/jira/browse/MESOS-4758 
trying to add `name` to `NetworkInfo`


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119730
---


On 二月 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated 二月 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/#review120643
---


Fix it, then Ship it!




Ship It!


src/tests/containerizer/docker_containerizer_tests.cpp (line 1841)


Can you add the mesos ticket in the comments as well? it has good 
information about this.


- Timothy Chen


On Feb. 25, 2016, 2 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43963/
> ---
> 
> (Updated Feb. 25, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4676
> https://issues.apache.org/jira/browse/MESOS-4676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the `unbuffer` utility in front of each `echo` in the test.  Since 
> Docker appears to handle simultaneous stdout/stderr in a non-robust fashion, 
> this mitigates the amount of overlap the two streams will have in the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
> 
> Diff: https://reviews.apache.org/r/43963/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
> --gtest_repeat=1200 --gtest_break_on_failure
> 
> ---
> 
> CI results: 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |:)| *|:)|   :) |:) |  
>:)|
> With-SSL |  :) |:)|&*| &|^ |:) |  
>:)|
> 
>  :) = Passed.
> 
> Known flaky tests:
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43974: Fixed compilation error in GroupTest.ConnectTimer.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43974/
---

(Updated Feb. 24, 2016, 6:04 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Neil 
Conway.


Changes
---

Finished testing.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/group_tests.cpp bb548f4681a70717305ccb0ebc4ead643d553e2e 

Diff: https://reviews.apache.org/r/43974/diff/


Testing (updated)
---

make check (without --disable-java) on Centos 7 & Debian 8 & Ubuntu 14


Thanks,

Joseph Wu

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
---

(Updated Feb. 24, 2016, 6:03 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and update conflict in MasterMaintenanceTests.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some 
local variables due to the order of destruction.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43630/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

(Updated Feb. 24, 2016, 6:03 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and update changes in: 

* src/tests/executor_http_api_tests.cpp
* src/tests/master_maintenance_tests.cpp
* src/tests/oversubscription_tests.cpp
* src/tests/scheduler_http_api_tests.cpp
* src/tests/slave_tests.cpp


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try` with `Owned`.  And 
`Try` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
  src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 
  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 
  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
983a6be160aefe5a32acb6111bb3c85230ec 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
2fc0893f5f5e80a783296fb31b30abe86d92df1b 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 88ad7806bf9f3194e434743c35199a896edea92c 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/master_validation_tests.cpp 
ab2df22f73052f6bd77653e56e7b460b17e7b0be 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
32b2af4115211b58a5127a14dd19152c2eca120c 
  src/tests/reservation_tests.cpp b8878d51767ac0d95e346c44c0a4d5c060e565ef 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
428e12646d80b45daec30cfe607b97f36170fdf5 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 
  

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 25, 2016, 2:02 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64:

```
export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
./support/docker_build.sh
```


Thanks,

Shuai Lin

Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/
---

Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.


Bugs: MESOS-4676
https://issues.apache.org/jira/browse/MESOS-4676


Repository: mesos


Description
---

Adds the `unbuffer` utility in front of each `echo` in the test.  Since Docker 
appears to handle simultaneous stdout/stderr in a non-robust fashion, this 
mitigates the amount of overlap the two streams will have in the test.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
a299c9e0744b5657984e5bb0afbe4874a266ddb6 

Diff: https://reviews.apache.org/r/43963/diff/


Testing
---

make check

On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
--gtest_repeat=1200 --gtest_break_on_failure

---

CI results: 
sudo make check

 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 12 |
 Non-SSL |  :) |:)| *|:)|   :) |:) |
 :)|
With-SSL |  :) |:)|&*| &|^ |:) |
 :)|

 :) = Passed.

Known flaky tests:
  * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
  & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
  ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids


Thanks,

Joseph Wu

Re: Review Request 43978: Wait until processed offer before advance clock.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43978/#review120642
---



I should have noted this: https://reviews.apache.org/r/43971/

- Joseph Wu


On Feb. 24, 2016, 5:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43978/
> ---
> 
> (Updated Feb. 24, 2016, 5:56 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait until processed offer before advance clock.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43978/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

> On Feb. 24, 2016, 11 p.m., Joseph Wu wrote:
> > src/tests/master_maintenance_tests.cpp, lines 1213-1218
> > 
> >
> > Sorry!  I didn't catch this during the first review :(
> > 
> > We need to wait until we've processed the ACCEPT/DECLINE event before 
> > advancing the clock.  See:
> > 
> > https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1564-L1568
> 
> haosdent huang wrote:
> Thank you very much, let me submit a hotfix!

Hotfix: https://reviews.apache.org/r/43978/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120598
---


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 43978: Wait until processed offer before advance clock.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43978/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Wait until processed offer before advance clock.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 

Diff: https://reviews.apache.org/r/43978/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43960/#review120638
---




src/tests/containerizer/provisioner_docker_tests.cpp (line 343)


.WillRepeatedly(Return()); // Ignore subsequent offers.



src/tests/containerizer/provisioner_docker_tests.cpp (line 348)


I think here `ASSERT_NE(0u, offers.get().size());` or `ASSERT_EQ(1u, 
offers.get().size());` may be more accurate



src/tests/containerizer/provisioner_docker_tests.cpp (line 359)


Why you are changing back to `busybox` but not `alpine`?


- Guangya Liu


On 二月 24, 2016, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43960/
> ---
> 
> (Updated 二月 24, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an end-to-end test for docker registry puller.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 
> 
> Diff: https://reviews.apache.org/r/43960/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120640
---


Ship it!




Ship It!

- haosdent huang


On Feb. 24, 2016, 9:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated Feb. 24, 2016, 9:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

> On Feb. 24, 2016, 11 p.m., Joseph Wu wrote:
> > src/tests/master_maintenance_tests.cpp, lines 1213-1218
> > 
> >
> > Sorry!  I didn't catch this during the first review :(
> > 
> > We need to wait until we've processed the ACCEPT/DECLINE event before 
> > advancing the clock.  See:
> > 
> > https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1564-L1568

Thank you very much, let me submit a hotfix!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120598
---


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 43974: Fixed compilation error in GroupTest.ConnectTimer.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43974/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Neil 
Conway.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/group_tests.cpp bb548f4681a70717305ccb0ebc4ead643d553e2e 

Diff: https://reviews.apache.org/r/43974/diff/


Testing
---

(In progress...) make check (without --disable-java)


Thanks,

Joseph Wu

Re: Review Request 43959: Fixed the docker registry puller to properly handle duplicated blobsums.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43959/#review120634
---


Ship it!




Tested with library/redis.

- Gilbert Song


On Feb. 24, 2016, 10:50 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43959/
> ---
> 
> (Updated Feb. 24, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the docker registry puller to properly handle duplicated blobsums.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> e08a9597c34fc74b96e7ef35cc1a25429a7f99c7 
> 
> Diff: https://reviews.apache.org/r/43959/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> manually tested with mesos-execute
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120633
---



Patch looks great!

Reviews applied: [43552]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 7:23 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 24, 2016, 7:23 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/
---

(Updated Feb. 24, 2016, 5:01 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-4768
https://issues.apache.org/jira/browse/MESOS-4768


Repository: mesos


Description
---

The accept/decline of the inverse offers in the test could arrive after the 
clock is paused and advanced in the test.  This meant that the test would 
trigger an allocation and then idle (because the clock is paused).  This is the 
same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 .


Diffs
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 

Diff: https://reviews.apache.org/r/43971/diff/


Testing
---

make check (OSX)

bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" 
--gtest_repeat=5000 --gtest_break_on_failure


Thanks,

Joseph Wu

Re: Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/
---

(Updated Feb. 24, 2016, 4:51 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Finished testing the patch.


Bugs: MESOS-4768
https://issues.apache.org/jira/browse/MESOS-4768


Repository: mesos


Description
---

The accept/decline of the inverse offers in the test could arrive after the 
clock is paused and advanced in the test.  This meant that the test would 
trigger an allocation and then idle (because the clock is paused).  This is the 
same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 .


Diffs
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 

Diff: https://reviews.apache.org/r/43971/diff/


Testing (updated)
---

make check (OSX)

bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" 
--gtest_repeat=5000 --gtest_break_on_failure


Thanks,

Joseph Wu

Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-4768
https://issues.apache.org/jira/browse/MESOS-4768


Repository: mesos


Description
---

The accept/decline of the inverse offers in the test could arrive after the 
clock is paused and advanced in the test.  This meant that the test would 
trigger an allocation and then idle (because the clock is paused).  This is the 
same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 .


Diffs
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 

Diff: https://reviews.apache.org/r/43971/diff/


Testing
---

(Not done yet) make check (OSX)


Thanks,

Joseph Wu

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43416/#review120623
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp (line 52)


Why is the cast to `size_t` needed here?


- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43416/
> ---
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed ambiguous call to `::write`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
> 88b355e09f76f0412c74ad69556572f0079deb8f 
> 
> Diff: https://reviews.apache.org/r/43416/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review120621
---


Ship it!




Ship It!

- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> ---
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Marked functions in headers `inline` to avoid linker errors.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> 046388189823c0c41ce6cc135d5d3838e9131087 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5 
> 
> Diff: https://reviews.apache.org/r/43417/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review120619
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 24, 2016, 11:41 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 24, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42877/#review120618
---


Ship it!




rebased.

- Joris Van Remoortere


On Feb. 19, 2016, 7:38 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42877/
> ---
> 
> (Updated Feb. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, we should do `driver.stop(); driver.join();` if a
> `MesosSchedulerDriver` has been started by the unit test. The destructor for
> `MesosSchedulerDriver` will do something _similar_, so the consequence of
> omitting these calls is not dire, but it seems safer to be consistent between
> all the test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/executor_http_api_tests.cpp 
> 36a042ed103271ca873450236f39a8152fbbf07e 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/scheduler_event_call_tests.cpp 
> bd8920fa9d5475e5f6533c8424ebff1588bfe645 
>   src/tests/scheduler_http_api_tests.cpp 
> 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
>   src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 
> 
> Diff: https://reviews.apache.org/r/42877/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Note that adding the `driver.stop(); driver.join();` calls to two of the 
> slave tests requires adding an extra shutdown expectation to avoid a GMock 
> warning.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43411/#review120616
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (line 54)


Let's we pull this string out as `invalid_symbol` and just use 
`"InvalidSymbol"`



3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (lines 69 - 
70)


We're only testing that `loadSymbol` fails if we don't call `open` first, 
not `close`. Right? Seems like this was copy/pasted from above test.



3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (line 92)


Let's also take this out to `invalid_library_path` and call it 
`"InvalidLibraryPath"`


- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43411/
> ---
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4496
> https://issues.apache.org/jira/browse/MESOS-4496
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dynamic library loading tests to build.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
> 27626ae28db090f1a002239ff5c674b82e8fc9a8 
> 
> Diff: https://reviews.apache.org/r/43411/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43868: Add a getter for master::Flags.

[Joseph Wu]

> On Feb. 23, 2016, 5:44 p.m., Qian Zhang wrote:
> > With this patch, do we still need to explicitly call `CreateMasterFlags()` 
> > in the test cases (e.g., 
> > https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235)?
> >  I see `CreateMasterFlags()` will be internally called by `StartMaster()`, 
> > so for all the test cases which calls `CreateMasterFlags()` first and then 
> > `StartMaster()`, should we change them to call `StartMaster()` and then 
> > `getFlags()` that you added in this patch?
> 
> Jay Guo wrote:
> Yes we believe this is exactly the intention of adding getter method. And 
> we have actually experimented modifying original test to use `StartMaster()` 
> and `getFlags()`. **However**, there are approx 50 instances in current code 
> base using `StartMaster(flags)`. We fear *changing all of them is beyond the 
> scope of this task*. Thoughts?
> 
> Qian Zhang wrote:
> Yes, maybe we need to upload a separate commit or create a separate JIRA 
> ticket for it. Since Joris is the shepherd of this ticket, I'd like to leave 
> this to him :-)

I didn't notice this review until just now.  (Can you add me as a reviewer?)

FYI: There's a major rewrite of the test helpers underway right now, so you may 
want to hold off on this patch until we get that finalized.
See: https://issues.apache.org/jira/browse/MESOS-4634


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/#review120432
---


On Feb. 23, 2016, 7:42 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43868/
> ---
> 
> (Updated Feb. 23, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Joris Van Remoortere, and Qian Zhang.
> 
> 
> Bugs: MESOS-3481
> https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
> 
> Diff: https://reviews.apache.org/r/43868/diff/
> 
> 
> Testing
> ---
> 
> Added one new unit test MasterTest::Flags
> 
> `make check` passed
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 43868: Add a getter for master::Flags.

[Qian Zhang]

> On Feb. 24, 2016, 9:44 a.m., Qian Zhang wrote:
> > With this patch, do we still need to explicitly call `CreateMasterFlags()` 
> > in the test cases (e.g., 
> > https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235)?
> >  I see `CreateMasterFlags()` will be internally called by `StartMaster()`, 
> > so for all the test cases which calls `CreateMasterFlags()` first and then 
> > `StartMaster()`, should we change them to call `StartMaster()` and then 
> > `getFlags()` that you added in this patch?
> 
> Jay Guo wrote:
> Yes we believe this is exactly the intention of adding getter method. And 
> we have actually experimented modifying original test to use `StartMaster()` 
> and `getFlags()`. **However**, there are approx 50 instances in current code 
> base using `StartMaster(flags)`. We fear *changing all of them is beyond the 
> scope of this task*. Thoughts?

Yes, maybe we need to upload a separate commit or create a separate JIRA ticket 
for it. Since Joris is the shepherd of this ticket, I'd like to leave this to 
him :-)


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/#review120432
---


On Feb. 24, 2016, 11:42 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43868/
> ---
> 
> (Updated Feb. 24, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Joris Van Remoortere, and Qian Zhang.
> 
> 
> Bugs: MESOS-3481
> https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
> 
> Diff: https://reviews.apache.org/r/43868/diff/
> 
> 
> Testing
> ---
> 
> Added one new unit test MasterTest::Flags
> 
> `make check` passed
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Feb. 24, 2016, 11:41 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Rebase.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway

Re: Review Request 43328: Added a title to all documentation markdown files.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review120603
---



Bad patch!

Reviews applied: [43328, 43715, 43716]

Failed command: ./support/apply-review.sh -n -r 43715

Error:
2016-02-24 23:37:53 URL:https://reviews.apache.org/r/43715/diff/raw/ 
[2453/2453] -> "43715.patch" [1]
No files to lint

Error: Commit message summary (the first line) must not exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/11637/console

- Mesos ReviewBot


On Feb. 24, 2016, 6:50 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All the documentation markdown files are updated with a title so that UI 
> shows the title on browser.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 15f70b51294fa647d653bfe4d641dc032ec91f44 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 2e5b700691744798c9a84874fd5f1d17aa151346 
>   docs/high-availability-framework-guide.md 
> 0d9c483985d61b512339f50f395f9360de034e2d 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 07214b927c112d7a180507ae03245892455fd757 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md 4d24ec680f3245b12b99e4bb6440ae5aab473460 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md a4d6710a8a3a4cde10fdccad332e3d539246ec83 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md f0963e750494fcf1f9d80e87bac8dbd6f76adc9f 
>   docs/replicated-log-internals.md 4f379a3ff4e957a486fa13d721f4b66333aea6b3 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   

Re: Review Request 43850: Added waits in MemoryPressureTests to ensure deterministic behavior.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

(Updated Feb. 25, 2016, 12:33 a.m.)


Review request for mesos, Bernd Mathiske and Joseph Wu.


Summary (updated)
-

Added waits in MemoryPressureTests to ensure deterministic behavior.


Bugs: MESOS-4047
https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
---

Sometimes _MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery_ will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that different test milestones are reached; e.g. slave
is registered, `KILLED_TASK` reached the scheduler, etc; before continuing
with the test.


Diffs
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Alexander Rojas

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review120601
---


Ship it!




Ship It!

- Michael Park


On Feb. 24, 2016, 10:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
> ---
> 
> (Updated Feb. 24, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Force GMock to build and link statically.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
> 
> Diff: https://reviews.apache.org/r/43407/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 43969: Added test for Appc image fetcher.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43969/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4748
https://issues.apache.org/jira/browse/MESOS-4748


Repository: mesos


Description
---

Added simple appc Fetcher test with mock HTTP image server.


Diffs
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
9d9779ac04e32348ce0e28da54fd7aa039a7fbcd 

Diff: https://reviews.apache.org/r/43969/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review120597
---




src/master/allocator/mesos/hierarchical.cpp (line 1204)


Even though I really like the anonymous namespace, we don't use it for some 
reasons (I think the main one is that symbols are still exported, even though 
with mangled names).

All in all, there is only one place in non automatically generated code 
which uses them (and I wonder how it managed).

All this to say, I guess this function should be static.

Moreover, does this need to be a free function? I much rather have a 
private method.



src/tests/hierarchical_allocator_tests.cpp (lines 2506 - 2514)


Could you add a small comment, akin to the one in line 2488 on what is 
happening here?


- Alexander Rojas


On Feb. 24, 2016, 9:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 24, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120598
---




src/tests/master_maintenance_tests.cpp (lines 1213 - 1218)


Sorry!  I didn't catch this during the first review :(

We need to wait until we've processed the ACCEPT/DECLINE event before 
advancing the clock.  See:

https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1564-L1568


- Joseph Wu


On Feb. 18, 2016, 5:46 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 18, 2016, 5:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
---

(Updated Feb. 24, 2016, 10:59 p.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

CMake: Force GMock to build and link statically.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 

Diff: https://reviews.apache.org/r/43407/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43409/#review120596
---


Ship it!




Ship It!

- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43409/
> ---
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `src/resource_estimator.cpp` to build.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
> 
> Diff: https://reviews.apache.org/r/43409/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120594
---


Ship it!




Ship It!

- Joseph Wu


On Feb. 24, 2016, 1:44 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> ---
> 
> (Updated Feb. 24, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Bugs: MESOS-4047
> https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sometimes _MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery_ will fail 
> because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that different test milestones are reached; e.g. slave
> is registered, `KILLED_TASK` reached the scheduler, etc; before continuing
> with the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> ---
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120592
---



Patch looks great!

Reviews applied: [43776, 43777, 43782, 43778, 43779, 43800]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 6:43 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> ---
> 
> (Updated Feb. 24, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization docs for '/reserve' and '/create-volumes'.
> 
> This updates the authorization documentation to include the new `roles` 
> object for the `CreateVolume` and `ReserveResources` ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43964: CMAKE: Add leveldb library (3rdparty project).

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43964/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
---

CMAKE: Add leveldb library (3rdparty project).


Diffs
-

  3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 

Diff: https://reviews.apache.org/r/43964/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

(Updated Feb. 24, 2016, 10:44 p.m.)


Review request for mesos, Bernd Mathiske and Joseph Wu.


Changes
---

Remove typo.


Summary (updated)
-

Added waits at different points in the test to ensure milestones.


Bugs: MESOS-4047
https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description (updated)
---

Sometimes _MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery_ will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that different test milestones are reached; e.g. slave
is registered, `KILLED_TASK` reached the scheduler, etc; before continuing
with the test.


Diffs
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Alexander Rojas

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43799/
---

(Updated Feb. 24, 2016, 10:30 p.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Summary (updated)
-

Removed race condition from libevent based poll implementation.


Bugs: MESOS-3271 and MESOS-4711
https://issues.apache.org/jira/browse/MESOS-3271
https://issues.apache.org/jira/browse/MESOS-4711


Repository: mesos


Description (updated)
---

Under certains circumstances, the future returned by poll is discarded right
after the event is triggered, this causes the event callback to be called
before the discard callback which results in an abort signal being raised
by the libevent library.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent_poll.cpp 
461624ca003e97be5ea9cf956d86fc294e6f1bc1 

Diff: https://reviews.apache.org/r/43799/diff/


Testing
---

```bash
# On CentOS 6.7 running in virtualbox
../configure --enable-ssl --enable-libevent
make -j4 check
sudo ./bin/mesos-tests.sh 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000
```


Thanks,

Alexander Rojas

Re: Review Request 43850: Added watis at different points in the test to ensure milestones.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

(Updated Feb. 24, 2016, 10:30 p.m.)


Review request for mesos, Bernd Mathiske and Joseph Wu.


Summary (updated)
-

Added watis at different points in the test to ensure milestones.


Bugs: MESOS-4047
https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
---

Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that different test milestones are reached; e.g. slave
is registered, KILLED_TASK reached the scheduler, etc; before continuing
with the test.


Diffs (updated)
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Alexander Rojas

Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/
---

Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
Jian Qiu.


Bugs: MESOS-4677
https://issues.apache.org/jira/browse/MESOS-4677


Repository: mesos


Description
---

Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
tasks and the test reading said cgroup tasks.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 

Diff: https://reviews.apache.org/r/43961/diff/


Testing
---

make check

Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
--gtest_repeat=5000 --gtest_break_on_failure

---

CI results:

sudo make check

 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 12 |
 Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |
 :)|
With-SSL |  :) |@_@   | *| &|   :) |:) |
 :)|

 :) = Passed.
X_X = Configuration error with docker.
@_@ = Ran out of disk space in some tests: 
LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem

  * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
issue)
  % = DockerContainerizerTest.ROOT_DOCKER_Logs


Thanks,

Joseph Wu

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/#review120578
---



Patch looks great!

Reviews applied: [43914, 43915, 43916]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 4:54 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43916/
> ---
> 
> (Updated Feb. 24, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43916/diff/
> 
> 
> Testing
> ---
> 
> make check and sudo make check (for NetClsIsolator)
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43879: Added allocator metrics for number of allocations made.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/
---

(Updated Feb. 24, 2016, 9:42 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Renamed variable.


Bugs: MESOS-4718
https://issues.apache.org/jira/browse/MESOS-4718


Repository: mesos


Description
---

Added allocator metrics for number of allocations made.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43879/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

[Benjamin Bannier]

> On Feb. 24, 2016, 9:17 p.m., Alexander Rojas wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2395-2398
> > 
> >
> > Why isn't it an `AWAIT_READY` macro? you still use an `AWAIT_*` 
> > afterwards, so I doubt is the result value.

I want to *return* a `None` here if the response does not become ready while 
the macros you suggest do not return the correct type (`void` instead of 
`Option`).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/#review120570
---


On Feb. 24, 2016, 9:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43879/
> ---
> 
> (Updated Feb. 24, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4718
> https://issues.apache.org/jira/browse/MESOS-4718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for number of allocations made.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43879/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/
---

(Updated Feb. 24, 2016, 9:37 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Renamed variable.


Bugs: MESOS-4719
https://issues.apache.org/jira/browse/MESOS-4719


Repository: mesos


Description
---

Added allocator metric for the number of allocations to a framework.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43881/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/
---

(Updated Feb. 24, 2016, 9:37 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Renamed variable.


Bugs: MESOS-4722
https://issues.apache.org/jira/browse/MESOS-4722


Repository: mesos


Description
---

Added allocator metrics for number of filters per framework.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43883/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review120572
---



Have you tested this change? Please explain in the "Testing done" section.


support/docker_build.sh (line 125)


lets just call this function cleanup().


- Vinod Kone


On Jan. 17, 2016, 6:49 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 17, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43879: Added allocator metrics for number of allocations made.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/#review120570
---




src/tests/hierarchical_allocator_tests.cpp (lines 2395 - 2398)


Why isn't it an `AWAIT_READY` macro? you still use an `AWAIT_*` afterwards, 
so I doubt is the result value.



src/tests/hierarchical_allocator_tests.cpp (line 2425)


from the C++ styleguide:

> Prefer trailing underscores for use as member fields (but not required). 
Some trailing underscores are used to distinguish between similar variables in 
the same scope (think prime symbols), but this should be avoided as much as 
possible, including removing existing instances in the code base.

I'd rather have the test's fixture `flags` being changed to `flags_`, but 
I'm oke with renaming this to `localFlags` or something along those lines.



src/tests/hierarchical_allocator_tests.cpp (line 2435)


Not an issue here, but equality comparison with doubles are a scary thing.


- Alexander Rojas


On Feb. 24, 2016, 8:25 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43879/
> ---
> 
> (Updated Feb. 24, 2016, 8:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4718
> https://issues.apache.org/jira/browse/MESOS-4718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for number of allocations made.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43879/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43587/#review120571
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 15, 2016, 9:19 p.m., Michael Browning wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43587/
> ---
> 
> (Updated Feb. 15, 2016, 9:19 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Neil Conway.
> 
> 
> Bugs: MESOS-3486
> https://issues.apache.org/jira/browse/MESOS-3486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
> 
> Some usages of the DROP_MESSAGE, DROP_MESSAGES, and FUTURE_MESSAGE macros 
> from the libprocess tests perform logic already implemented in the 
> DROP_PROTOBUF, DROP_PROTOBUFS, and FUTURE_PROTOBUF macros defined in 
> tests/mesos.hpp. This diff moves those tests to use the latter versions where 
> appropriate.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
>   src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
>   src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 
> 
> Diff: https://reviews.apache.org/r/43587/diff/
> 
> 
> Testing
> ---
> 
> This change involves changing existing macro invocations in testing code, so 
> no additional testing was performed.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review120567
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120568
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43958: Added a verbose logging in docker registry puller.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43958/#review120566
---


Ship it!




Ship It!

- Jojy Varghese


On Feb. 24, 2016, 6:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43958/
> ---
> 
> (Updated Feb. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a verbose logging in docker registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> e08a9597c34fc74b96e7ef35cc1a25429a7f99c7 
> 
> Diff: https://reviews.apache.org/r/43958/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43960/#review120565
---




src/tests/containerizer/provisioner_docker_tests.cpp (line 360)


Would it add value if we assert that the store does not currently have the 
image?

Also, have assertions around the image being placed in the right dircetory?



src/tests/containerizer/provisioner_docker_tests.cpp (line 365)


Would it make sense to name these as per their semantics? `status1` does 
not say a lot about them.


- Jojy Varghese


On Feb. 24, 2016, 6:51 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43960/
> ---
> 
> (Updated Feb. 24, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an end-to-end test for docker registry puller.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 
> 
> Diff: https://reviews.apache.org/r/43960/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Michael Park]

> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 791
> > 
> >
> > * Mesos currently uses `foreach` from stout rather than 
> > range-based`for`.
> > * Mesos generally prefers explicit types than `auto`.
> > 
> > ```
> > foreach (Future future, futures) {
> >   ...
> > }
> > ```
> > 
> > Here and below.
> 
> Cong Wang wrote:
> Is that a strict rule? At least 
> src/tests/hierarchical_allocator_tests.cpp uses for(auto...) too.

Yeah, those shouldn't have made it into the codebase for consistency. The 
migration strategy is being discussed/tracked here: 
[MESOS-3214](https://issues.apache.org/jira/browse/MESOS-3214).


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
---


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120564
---




3rdparty/libprocess/include/process/future.hpp (line 791)


Why do we need to create a copy here now?


- Benjamin Bannier


On Feb. 24, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43855: Added Appc fetcher support to store.

[Jojy Varghese]

> On Feb. 23, 2016, 5:21 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 334
> > 
> >
> > s/Fetches/Fetch

Since i am describing what the function does, I believe the function "fetches" 
the image descibes what it does the best. Having said that, I am not a grammer 
expert  and my arms could be twisted :)


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120260
---


On Feb. 23, 2016, 3:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> ---
> 
> (Updated Feb. 23, 2016, 3:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
>   src/tests/fetcher_cache_tests.cpp e10b3f7ebc21c8c1095564fc40f123087dcf320e 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> ---
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Michael Park]

> On Feb. 24, 2016, 7:30 p.m., Vinod Kone wrote:
> > LGTM. Though I'm not sure why we used iterators instead of foreach in the 
> > first place. cc @mcypark

Because it was written before `foreach` was introduced to stout. The last of 
the `for` loops here was authored 2011-10-31 and `foreach` was introduced 
2012-07-11.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120552
---


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Cong Wang]

> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 791
> > 
> >
> > * Mesos currently uses `foreach` from stout rather than 
> > range-based`for`.
> > * Mesos generally prefers explicit types than `auto`.
> > 
> > ```
> > foreach (Future future, futures) {
> >   ...
> > }
> > ```
> > 
> > Here and below.

Is that a strict rule? At least src/tests/hierarchical_allocator_tests.cpp uses 
for(auto...) too.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
---


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120552
---


Ship it!




LGTM. Though I'm not sure why we used iterators instead of foreach in the first 
place. cc @mcypark

- Vinod Kone


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
---



Thanks for the cleanup!


3rdparty/libprocess/include/process/future.hpp (line 791)


* Mesos currently uses `foreach` from stout rather than range-based`for`.
* Mesos generally prefers explicit types than `auto`.

```
foreach (Future future, futures) {
  ...
}
```

Here and below.


- Michael Park


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> ---
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 
> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43462: Used list::splice() for clock::tick().

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43462/#review120551
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 24, 2016, 7:20 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43462/
> ---
> 
> (Updated Feb. 24, 2016, 7:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used list::splice() for clock::tick().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/clock.cpp 6c32792aa2c00a4ff672c5aa0f784304b64d43bf 
> 
> Diff: https://reviews.apache.org/r/43462/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43879: Added allocator metrics for number of allocations made.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/
---

(Updated Feb. 24, 2016, 8:25 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Addressed klaus1982's comments.


Bugs: MESOS-4718
https://issues.apache.org/jira/browse/MESOS-4718


Repository: mesos


Description
---

Added allocator metrics for number of allocations made.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43879/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/
---

(Updated Feb. 24, 2016, 8:24 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Addressed klaus1982's comments.


Bugs: MESOS-4720
https://issues.apache.org/jira/browse/MESOS-4720


Repository: mesos


Description
---

Added allocator metrics for total and allocated scalar resources.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43880/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

[Benjamin Bannier]

> On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2385
> > 
> >
> > Why a anonymous namespace? `static` should be fine.

In C `static` has more usages than just denoting internal linkage and the 
meaning needs to be inferred from the context, while C++ has anonymous 
namespaces just for that; so I would say it is rather "just anonymous namespace 
should be fine" than the other way around. Switched to `static` here anyway.


> On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2395
> > 
> >
> > What are you going to do for this comments? or just a notes?

Converted to `NOTE`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/#review120507
---


On Feb. 24, 2016, 2:25 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43879/
> ---
> 
> (Updated Feb. 24, 2016, 2:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4718
> https://issues.apache.org/jira/browse/MESOS-4718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for number of allocations made.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43879/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

[Benjamin Bannier]

> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 428
> > 
> >
> > Not yours, but I think we need to update roleSorter when slave 
> > active/deactive.
> > 
> > Filed https://issues.apache.org/jira/browse/MESOS-4755 to trace this.

Dropping this as it is already tracked separately.


> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 416
> > 
> >
> > I think we also need to update it in `updateSlave`; if normal resources 
> > of agent is "cpus:16" and Estimator report "mem:10", we'll miss mem in 
> > total metrics.

Good catch, the interface certainly allows new resource kinds appearing via 
`updateSlave`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/#review120511
---


On Feb. 24, 2016, 11:58 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43880/
> ---
> 
> (Updated Feb. 24, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4720
> https://issues.apache.org/jira/browse/MESOS-4720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for total and allocated scalar resources.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43880/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Vinod Kone]

> On Feb. 24, 2016, 5:16 a.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 123-125
> > 
> >
> > Ah, I see it now. There is another call to `if not options['dry_run']` 
> > inside the `close_reviews()` call which protects it from actually closing 
> > it on rb. Seems like this could be consolidated somehow, since it's a 
> > little confusing at first glance, but may not be worth the effort.

I've removed the "if reviews:" to avoid confusion.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120452
---


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/
---

(Updated Feb. 24, 2016, 7:23 p.m.)


Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.


Changes
---

kevin's.


Bugs: MESOS-3929
https://issues.apache.org/jira/browse/MESOS-3929


Repository: mesos


Description
---

This script allows committers to push locally applied review chain to the ASF
git repo and mark the reviews as submitted.


Diffs (updated)
-

  support/push-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/43552/diff/


Testing
---

Tested locally.


Thanks,

Vinod Kone

Re: Review Request 43958: Added a verbose logging in docker registry puller.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43958/#review120548
---


Ship it!




The size should be appropriate for VLOG(1).

- Gilbert Song


On Feb. 24, 2016, 10:50 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43958/
> ---
> 
> (Updated Feb. 24, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a verbose logging in docker registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> e08a9597c34fc74b96e7ef35cc1a25429a7f99c7 
> 
> Diff: https://reviews.apache.org/r/43958/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43462: Used list::splice() for clock::tick().

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43462/
---

(Updated Feb. 24, 2016, 7:20 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
---

rebase


Repository: mesos


Description
---

Used list::splice() for clock::tick().


Diffs (updated)
-

  3rdparty/libprocess/src/clock.cpp 6c32792aa2c00a4ff672c5aa0f784304b64d43bf 

Diff: https://reviews.apache.org/r/43462/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/
---

(Updated Feb. 24, 2016, 7:19 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
---

rebase


Repository: mesos


Description
---

Used C++11 for loop to iterate std list/set.


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 

Diff: https://reviews.apache.org/r/43461/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 43932: Added overlayfs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120540
---



Patch looks great!

Reviews applied: [43718, 43932]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 4:38 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 24, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43716: Added title to every endpoint markdown file.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review120538
---


Ship it!




Ship It!

- Kevin Klues


On Feb. 24, 2016, 6:51 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 24, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch includes all the endpoint documents with title generated from 
> generated-endpoint-help.py file.
> Tested on live site using "rake"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43716: Added title to every endpoint markdown file.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/
---

(Updated Feb. 24, 2016, 6:51 p.m.)


Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.


Summary (updated)
-

Added title to every endpoint markdown file.


Bugs: MESOS-4588
https://issues.apache.org/jira/browse/MESOS-4588


Repository: mesos


Description
---

Endpoint documents with title.


Diffs
-

  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 
77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 
6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md 
1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
  docs/endpoints/master/destroy-volumes.md 
7209a7cf788116a29eb6235d3a8a0225253c04f7 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 
82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md 
e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 
17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md 
a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586 
  docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 
5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md 
e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
  docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 

Diff: https://reviews.apache.org/r/43716/diff/


Testing
---

This patch includes all the endpoint documents with title generated from 
generated-endpoint-help.py file.
Tested on live site using "rake"


Thanks,

Abhishek Dasgupta

Review Request 43960: Added an end-to-end test for docker registry puller.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43960/
---

Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Added an end-to-end test for docker registry puller.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 

Diff: https://reviews.apache.org/r/43960/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review120536
---


Ship it!




Ship It!

- Kevin Klues


On Feb. 24, 2016, 6:49 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> ---
> 
> (Updated Feb. 24, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> support/generate-endpoint-help.py is adding a title to every generated 
> endpoint markdown file.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> ---
> 
> This is the patch for support/generate-endpoint-help.py to include the 
> generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 43959: Fixed the docker registry puller to properly handle duplicated blobsums.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43959/
---

Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed the docker registry puller to properly handle duplicated blobsums.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
e08a9597c34fc74b96e7ef35cc1a25429a7f99c7 

Diff: https://reviews.apache.org/r/43959/diff/


Testing
---

make check

manually tested with mesos-execute


Thanks,

Jie Yu

Review Request 43958: Added a verbose logging in docker registry puller.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43958/
---

Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Added a verbose logging in docker registry puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
e08a9597c34fc74b96e7ef35cc1a25429a7f99c7 

Diff: https://reviews.apache.org/r/43958/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 24, 2016, 6:49 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Summary (updated)
-

Updated support/generate-endpoint-help.py to include title in generated 
markdown files.


Repository: mesos


Description (updated)
---

support/generate-endpoint-help.py is adding a title to every generated endpoint 
markdown file.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43715: Title for endpoint documentation.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 24, 2016, 6:44 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Summary (updated)
-

Title for endpoint documentation.


Repository: mesos


Description (updated)
---

Title for endpoint documentation.


Diffs (updated)
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43779/
---

(Updated Feb. 24, 2016, 6:42 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Added '/reserve' tests with multiple roles.

Operators may reserve resources for multiple roles in the same operation; this 
patch adds tests to confirm correct behavior of authorization in this case. The 
tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and 
`ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.


Diffs (updated)
-

  src/tests/reservation_endpoints_tests.cpp 
32b2af4115211b58a5127a14dd19152c2eca120c 

Diff: https://reviews.apache.org/r/43779/diff/


Testing
---

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/
---

(Updated Feb. 24, 2016, 6:43 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Updated authorization docs for '/reserve' and '/create-volumes'.

This updates the authorization documentation to include the new `roles` object 
for the `CreateVolume` and `ReserveResources` ACLs.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 

Diff: https://reviews.apache.org/r/43800/diff/


Testing
---


Thanks,

Greg Mann