Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/#review134106
---



Patch looks great!

Reviews applied: [47123]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 2:40 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47123/
> ---
> 
> (Updated May 20, 2016, 2:40 a.m.)
> 
> 
> Review request for mesos, Cody Maloney and Till Toenshoff.
> 
> 
> Bugs: MESOS-5173
> https://issues.apache.org/jira/browse/MESOS-5173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the operator to use separate manifest JSON files for each
> module.  Previously, one had to merge all module manifest files into a
> single JSON file before passing on to the master/agent.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 
>   src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c 
>   src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
>   src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
>   src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 
>   src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
>   src/sched/sched.cpp 9e55885704d5c4a8bc0e25e324b9c65e7bc34798 
>   src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
>   src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
>   src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 
>   src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 
>   src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 
> 
> Diff: https://reviews.apache.org/r/47123/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with:
> 1. --module_dir
> 2. --modules
> 3. --module_dir in conjunction with --modules
> 
> The first two succeeded while the third failed as expected.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134094
---


Fix it, then Ship it!




Thank you for your patch. For summary and description, it should be limited in 
72 characters, otherwise could not pass jenkins build.


src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 3926)


I suggest to change comment like
```
  // Disable IPv6 when IPv6 module was loaded as IPv6 packets won't be 
forwarded
  // anyway.
```


- haosdent huang


On May 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated May 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134101
---




src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 3927)


You need to move this check into the script rather than in the C++ code. 
Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && echo 1 > 
/proc/sys/net/ipv6/conf/all/disable_ipv6".


- Cong Wang


On May 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated May 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47442/#review134098
---



Patch looks great!

Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 1:48 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47442/
> ---
> 
> (Updated May 20, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3639
> https://issues.apache.org/jira/browse/MESOS-3639
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> e8ef4acaa7413cf56372e899a9bc2d4514faeff4 
> 
> Diff: https://reviews.apache.org/r/47442/diff/
> 
> 
> Testing
> ---
> 
> Windows build/test
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/
---

(Updated May 20, 2016, 4:21 a.m.)


Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
Anderegg, and Vinod Kone.


Changes
---

Attach screenshots.


Bugs: MESOS-1495
https://issues.apache.org/jira/browse/MESOS-1495


Repository: mesos


Description
---

Created separate local data file to manage releases information.


Diffs
-

  site/data/releases.yml PRE-CREATION 
  site/source/downloads.html.erb PRE-CREATION 
  site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
  site/source/index.html.erb PRE-CREATION 
  site/source/index.html.md d5c0e339b77590d373d424ce1f87bffa398d5cdc 

Diff: https://reviews.apache.org/r/47587/diff/


Testing (updated)
---

Test by re-generate the website in my local machine.

![website_mobile](https://issues.apache.org/jira/secure/attachment/12805129/website_mobile.gif)
![website_pc](https://issues.apache.org/jira/secure/attachment/12805130/website_pc.gif)


Thanks,

haosdent huang

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

> On May 20, 2016, 3:27 a.m., Vinod Kone wrote:
> > Looks like you need to rebase, so I made my comments anyway :)
> > 
> > I'm assuming the workflow for generating the website hasn't changed with 
> > the introduction of erb files?

Thank you very much for your view.
>I'm assuming the workflow for generating the website hasn't changed with the 
>introduction of erb files?

Yes, not need change. Could continue to follow the instructions writed by 
@klueska in `support/site-docker/README.md`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134089
---


On May 19, 2016, 10:32 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/
---

(Updated May 20, 2016, 3:55 a.m.)


Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
Anderegg, and Vinod Kone.


Changes
---

Address @vinodkone's comment.


Bugs: MESOS-1495
https://issues.apache.org/jira/browse/MESOS-1495


Repository: mesos


Description
---

Created separate local data file to manage releases information.


Diffs (updated)
-

  site/data/releases.yml PRE-CREATION 
  site/source/downloads.html.erb PRE-CREATION 
  site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
  site/source/index.html.erb PRE-CREATION 
  site/source/index.html.md d5c0e339b77590d373d424ce1f87bffa398d5cdc 

Diff: https://reviews.apache.org/r/47587/diff/


Testing
---

Test by re-generate the website in my local machine.


Thanks,

haosdent huang

Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[Zhengju Sha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/
---

Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.


Bugs: MESOS-5381
https://issues.apache.org/jira/browse/MESOS-5381


Repository: mesos


Description
---

Isolation/networking: check if IPv6 is loaded before trying to disable it


Diffs
-

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
ad792def2bb3a1614d21ca28d858e400d2e3ede1 

Diff: https://reviews.apache.org/r/47633/diff/


Testing
---

Enniornment and steps:
1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with kernel 
version: 3.10.0-327.10.1.el7.x86_64
2. Create application on marathon framework with commands such as "echo hello" 
using MesosContainerizer
3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
/etc/default/grub
4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
/etc/default/grub

Now mesos can run both of the testcases successfully.


Thanks,

Zhengju Sha

Re: Review Request 47587: Created separate local data file to manage releases information.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134090
---



Patch looks great!

Reviews applied: [47587]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 10:32 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134089
---



Looks like you need to rebase, so I made my comments anyway :)

I'm assuming the workflow for generating the website hasn't changed with the 
introduction of erb files?


site/data/releases.yml (line 2)


s/release/releasing/

s/a item/an item/



site/data/releases.yml (line 4)


s/publish/publishing/

s/a item/an item/



site/data/releases.yml (line 74)


not sure why you called this "items" instead of "versions" ?


- Vinod Kone


On May 19, 2016, 10:32 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134088
---


Ship it!




This is great thank you!

I'll make some minor grammar corrections while I commit.

- Vinod Kone


On May 19, 2016, 10:32 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47581: Delete the /observe HTTP endpoint.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47581/#review134087
---


Ship it!




Ship It!

- Vinod Kone


On May 19, 2016, 7:19 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47581/
> ---
> 
> (Updated May 19, 2016, 7:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5408
> https://issues.apache.org/jira/browse/MESOS-5408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Delete the /observe HTTP endpoint.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 31ca5e5e37b1369fa8b74a649432fbc9b5addbe6 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 
>   src/local/local.cpp 4b054a4d39e4fee10c93afc197dd33bc7fa27ae3 
>   src/master/http.cpp 5d73a1dde24cc2231fd8054cbc715d2618134f02 
>   src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
>   src/master/master.hpp 647b43c8c6f1d53baeb2f795ef7d45b07a779ace 
>   src/master/master.cpp b8c732a6178777544f0d09708177d9c68ab0532b 
>   src/master/repairer.hpp 04594e200d3f09ba38a600b72038cfd88a596662 
>   src/master/repairer.cpp bee6b48f76cd5d009d0aaea667be2ddda1c905be 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp ef9c95e378c3d65458e9e1bef78724e4e79c5af6 
>   src/tests/repair_tests.cpp f213ec94f4a3ecc5499983b1b36756f580b0543d 
> 
> Diff: https://reviews.apache.org/r/47581/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46613: Introduced filtering relevant actions and acls.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review132116
---




src/authorizer/local/authorizer.cpp (line 216)


Please update to use `foreach`. I've updated the other instances.



src/authorizer/local/authorizer.cpp (line 229)


Please update to use `foreach`. I've updated the other instances.


- Michael Park


On May 18, 2016, 10:16 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> ---
> 
> (Updated May 18, 2016, 10:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to allow for framework and task level filtering we introduce
> the following authorizer actions:
> * FILTER_FRAMEWORK_WITH_INFO
> * FILTER_TASK_WITH_EXECUTOR_INFO = 13;
> * FILTER_TASK_WITH_COMMAND_INFO = 14;
> * FILTER_TASK_WITH_TASK = 15;
> 
> Note that we need different actions for authorizing a tasks
> based on the object being authorized.
> 
> We also introduce the following acls for the local authorizer:
> * ViewFrameworks  (giving access to frameworks running  
>under a specific OS user
> * ViewTasks view_tasks (giving access to Tasks run under a
> specific OS user)
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   include/mesos/authorizer/acls.proto 
> 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 
> 32492a59ad95df3bb673ec42321518f86c11af59 
>   src/authorizer/local/authorizer.cpp 
> aa1a9d8e5c7fb86b6310015d93aeacb466a307ef 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47490: Moved `Task` to public protobufs.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47490/#review134083
---


Ship it!




Ship It!

- Michael Park


On May 17, 2016, 9:26 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47490/
> ---
> 
> (Updated May 17, 2016, 9:26 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5404
> https://issues.apache.org/jira/browse/MESOS-5404
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As we need to authorize Tasks we need to include `Task` in
> the public protobufs. This move also requires a the json logic to
> adapt.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   include/mesos/type_utils.hpp 27fa8c9256c24b5ec6f5d259305ea66b5f556673 
>   src/common/http.hpp 00294655ec63a91e67ce3de5e8fb15a836ee1a9c 
>   src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
>   src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
>   src/messages/messages.cpp 41dcdb3996ce173fb0a56704053e4b4e03f6dd63 
>   src/messages/messages.proto 5593881229f57a11634357f1f85d697f11f4c827 
> 
> Diff: https://reviews.apache.org/r/47490/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/
---

(Updated May 19, 2016, 10:40 p.m.)


Review request for mesos, Cody Maloney and Till Toenshoff.


Changes
---

Fixed compilation error.


Bugs: MESOS-5173
https://issues.apache.org/jira/browse/MESOS-5173


Repository: mesos


Description
---

This allows the operator to use separate manifest JSON files for each
module.  Previously, one had to merge all module manifest files into a
single JSON file before passing on to the master/agent.


Diffs (updated)
-

  src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 
  src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c 
  src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
  src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
  src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 
  src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
  src/sched/sched.cpp 9e55885704d5c4a8bc0e25e324b9c65e7bc34798 
  src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
  src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
  src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 
  src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 
  src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 

Diff: https://reviews.apache.org/r/47123/diff/


Testing
---

Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules

The first two succeeded while the third failed as expected.


Thanks,

Kapil Arya

Re: Review Request 47453: Corrected order of forwards declarations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47453/#review134080
---


Ship it!




Ship It!

- Michael Park


On May 17, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47453/
> ---
> 
> (Updated May 17, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5404
> https://issues.apache.org/jira/browse/MESOS-5404
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Forwards declarations should be ordered alphabetically.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 00294655ec63a91e67ce3de5e8fb15a836ee1a9c 
> 
> Diff: https://reviews.apache.org/r/47453/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47442/
---

(Updated May 20, 2016, 1:48 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-3639
https://issues.apache.org/jira/browse/MESOS-3639


Repository: mesos


Description
---

Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows/os.hpp 
e8ef4acaa7413cf56372e899a9bc2d4514faeff4 

Diff: https://reviews.apache.org/r/47442/diff/


Testing
---

Windows build/test


Thanks,

Daniel Pravat

Re: Review Request 47489: Windows: Symplified `os::exists`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47489/
---

(Updated May 20, 2016, 1:47 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-5420
https://issues.apache.org/jira/browse/MESOS-5420


Repository: mesos


Description
---

Windows: Symplified `os::exists`.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/exists.hpp 
423e4a81b4d34460f7f9f073577e11dfa2d2a520 

Diff: https://reviews.apache.org/r/47489/diff/


Testing
---

Windows build/run


Thanks,

Daniel Pravat

Re: Review Request 46904: Fixed a typo in libprocess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/#review134077
---



Patch looks great!

Reviews applied: [46904]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 9:44 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46904/
> ---
> 
> (Updated May 19, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected a misspelled word in 'future.hpp'.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 011fea8cedc75ac06599602252974f4ce662c893 
> 
> Diff: https://reviews.apache.org/r/46904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47625: Fixed incorrect use of unique_ptr for array storage.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47625/#review134075
---


Ship it!




Ship It!

- Kevin Klues


On May 20, 2016, 12:55 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47625/
> ---
> 
> (Updated May 20, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Kevin Klues, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See: https://reviews.apache.org/r/46191/
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> e8ef4acaa7413cf56372e899a9bc2d4514faeff4 
> 
> Diff: https://reviews.apache.org/r/47625/diff/
> 
> 
> Testing
> ---
> 
> I do not have a windows machine to compile on.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47610/
---

(Updated May 20, 2016, 12:56 a.m.)


Review request for mesos.


Bugs: MESOS-5414
https://issues.apache.org/jira/browse/MESOS-5414


Repository: mesos


Description
---

The libelf library is not a standard library installed on all Linux
systems, and it is not a library required to build stout in
general. It is only required for subsystems that happen to use the
 header. As such, we should only require this
dependency for those specific subsystems. If we ever decide to build
something into stout that depends on libelf by default, we can
revisit this issue then.


Diffs
-

  3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 

Diff: https://reviews.apache.org/r/47610/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 47625: Fixed incorrect use of unique_ptr for array storage.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47625/
---

Review request for mesos, Joris Van Remoortere, Kevin Klues, and Michael Park.


Repository: mesos


Description
---

See: https://reviews.apache.org/r/46191/


Diffs
-

  3rdparty/stout/include/stout/windows/os.hpp 
e8ef4acaa7413cf56372e899a9bc2d4514faeff4 

Diff: https://reviews.apache.org/r/47625/diff/


Testing
---

I do not have a windows machine to compile on.


Thanks,

Benjamin Mahler

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46428/
---

(Updated 五月 20, 2016, 12:20 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5351
https://issues.apache.org/jira/browse/MESOS-5351


Repository: mesos


Description
---

Fixed the broken Docker Volume Rootfs Test on Centos7.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 

Diff: https://reviews.apache.org/r/46428/diff/


Testing
---

make
make check

[==] Running 2 tests from 1 test case.
[--] Global test environment set-up.
[--] 2 tests from DockerVolumeIsolatorTest
[ RUN  ] 
DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithAbsolutePathVolume
[   OK ] 
DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithAbsolutePathVolume
 (1732 ms)
[ RUN  ] 
DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithRelativeVolume
[   OK ] 
DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithRelativeVolume 
(1708 ms)
[--] 2 tests from DockerVolumeIsolatorTest (3451 ms total)
 
[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (3460 ms total)
[  PASSED  ] 2 tests.
[root@mesos-24 build]# cat /etc/*release
CentOS Linux release 7.2.1511 (Core) 
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/;
BUG_REPORT_URL="https://bugs.centos.org/;
 
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
 
CentOS Linux release 7.2.1511 (Core) 
CentOS Linux release 7.2.1511 (Core) 
[root@mesos-24 build]#


Thanks,

Guangya Liu

Re: Review Request 47489: Windows: Symplified `os::exists`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47489/
---

(Updated May 20, 2016, 12:17 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-5420
https://issues.apache.org/jira/browse/MESOS-5420


Repository: mesos


Description
---

Windows: Symplified `os::exists`.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/exists.hpp 
423e4a81b4d34460f7f9f073577e11dfa2d2a520 

Diff: https://reviews.apache.org/r/47489/diff/


Testing (updated)
---

Windows build/run


Thanks,

Daniel Pravat

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review134073
---



Patch looks great!

Reviews applied: [47463]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 8:05 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> ---
> 
> (Updated May 19, 2016, 8:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
> https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> ---
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/
---

(Updated May 20, 2016, 12:04 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, 
and Michael Park.


Repository: mesos


Description
---

Windows: Disabled signal handlers in logging.cpp.


Diffs (updated)
-

  src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 

Diff: https://reviews.apache.org/r/47474/diff/


Testing
---

Windows: build/run
OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47608/#review134070
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 19, 2016, 6:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47608/
> ---
> 
> (Updated May 19, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Add Labels from TaskInfo into TaskStatus message.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 
>   src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 
>   src/tests/slave_tests.cpp e1f5bfe074c357f46403887365b3f9ae554000b4 
> 
> Diff: https://reviews.apache.org/r/47608/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 47486: Windows: Escaped command line arguments.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47486/
---

(Updated May 19, 2016, 11:07 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Repository: mesos


Description
---

The command line for the containerizer has the command encoded
as JSON. Non escaped quotes are removed during the containerizer
startup and the JSON processed is invalid.


Diffs (updated)
-

  3rdparty/libprocess/include/process/windows/subprocess.hpp 
551770b9ec24b880c13441f413c5d1871fbf5c3a 

Diff: https://reviews.apache.org/r/47486/diff/


Testing
---

Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47610/#review134064
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 19, 2016, 6:08 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47610/
> ---
> 
> (Updated May 19, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The libelf library is not a standard library installed on all Linux
> systems, and it is not a library required to build stout in
> general. It is only required for subsystems that happen to use the
>  header. As such, we should only require this
> dependency for those specific subsystems. If we ever decide to build
> something into stout that depends on libelf by default, we can
> revisit this issue then.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 
> 
> Diff: https://reviews.apache.org/r/47610/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review134063
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Maj 19, 2016, 10:32 po południu, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated Maj 19, 2016, 10:32 po południu)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/
---

(Updated May 19, 2016, 10:32 p.m.)


Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
Anderegg, and Vinod Kone.


Changes
---

Address @janisz's comments.


Bugs: MESOS-1495
https://issues.apache.org/jira/browse/MESOS-1495


Repository: mesos


Description
---

Created separate local data file to manage releases information.


Diffs (updated)
-

  site/data/releases.yml PRE-CREATION 
  site/source/downloads.html.erb PRE-CREATION 
  site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
  site/source/index.html.erb PRE-CREATION 
  site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 

Diff: https://reviews.apache.org/r/47587/diff/


Testing
---

Test by re-generate the website in my local machine.


Thanks,

haosdent huang

Re: Review Request 47492: Windows: Updated the containerizer name to `mesos-containerizer.exe`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47492/
---

(Updated May 19, 2016, 10:26 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, 
and Michael Park.


Repository: mesos


Description
---

Windows: Updated the containerizer name to `mesos-containerizer.exe`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 

Diff: https://reviews.apache.org/r/47492/diff/


Testing
---

Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 47473: Windows: Added logging for `WSTRINGIFY` calls.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47473/
---

(Updated May 19, 2016, 10:19 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, 
and Michael Park.


Bugs: MESOS-5417
https://issues.apache.org/jira/browse/MESOS-5417


Repository: mesos


Description
---

The return codes in Windows are not standardized. The function returns
an empty string and logs a warning.


Diffs
-

  src/common/status_utils.hpp fa8dbf1958efa13cfd10712a3215dbca693bcff9 

Diff: https://reviews.apache.org/r/47473/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47603/#review134053
---




src/launcher/windows/executor.hpp (line 107)


I've made a change to start the process in a job object. The patch is 
commited in your branch.


- Daniel Pravat


On May 19, 2016, 4:08 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47603/
> ---
> 
> (Updated May 19, 2016, 4:08 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent:[2/2] Added Windows support for folder `launcher/`.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/launcher/executor.hpp PRE-CREATION 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/posix/executor.hpp PRE-CREATION 
>   src/launcher/windows/executor.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

[Kapil Arya]

> On May 10, 2016, 1:27 a.m., Cody Maloney wrote:
> > src/module/manager.cpp, line 377
> > 
> >
> > Is there a semantic difference between loading modules one at a time 
> > vs. just passing them all at once to loadManifest?
> > 
> > I'm worried that the behavior here could differ slightly from the 
> > --modules flag which calls loadManifest with all the modules at once.

There is no semantic difference as of now. Even with the `--modules` flag, the 
modules are loaded one at a time, without any notion of interdependency. In 
future, if and when we add some other checks, say to find mutually exclusive 
modules, or interdependent modules, we might want to process the module 
manifests first (without actually loading the modules) and then load the 
modules at a later time. In that case, the change will be local to 
module/manager.cpp and so I wouldn't worry about it for now.


> On May 10, 2016, 1:27 a.m., Cody Maloney wrote:
> > src/module/manager.cpp, line 358
> > 
> >
> > Should document the sort order / load order based on filenames inside 
> > the doc changes to accompany this (I don't see it anywhere currently)

Added to the help message.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/#review132372
---


On May 19, 2016, 5:51 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47123/
> ---
> 
> (Updated May 19, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Till Toenshoff.
> 
> 
> Bugs: MESOS-5173
> https://issues.apache.org/jira/browse/MESOS-5173
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows the operator to use separate manifest JSON files for each
> module.  Previously, one had to merge all module manifest files into a
> single JSON file before passing on to the master/agent.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 
>   src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c 
>   src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
>   src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
>   src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 
>   src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
>   src/sched/sched.cpp 9e55885704d5c4a8bc0e25e324b9c65e7bc34798 
>   src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
>   src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
>   src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 
>   src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 
>   src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 
> 
> Diff: https://reviews.apache.org/r/47123/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with:
> 1. --module_dir
> 2. --modules
> 3. --module_dir in conjunction with --modules
> 
> The first two succeeded while the third failed as expected.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46904: Fixed a typo in libprocess.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/
---

(Updated May 19, 2016, 9:44 p.m.)


Review request for mesos and Adam B.


Repository: mesos


Description
---

Corrected a misspelled word in 'future.hpp'.


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
011fea8cedc75ac06599602252974f4ce662c893 

Diff: https://reviews.apache.org/r/46904/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 46901: Regenerated HTTP endpoint docs.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46901/#review134047
---


Ship it!




Ship It!

- Kapil Arya


On May 2, 2016, 2:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46901/
> ---
> 
> (Updated May 2, 2016, 2:34 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Regenerated HTTP endpoint docs.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/logging/toggle.md f76accd1e2e0208cd991e4fb6e54f0ff0bf0d8b0 
>   docs/endpoints/metrics/snapshot.md 7d3a7ef810a6f28f9101b35241737bac59fed965 
>   docs/endpoints/profiler/start.md 36bd0b6d661692db930723e8385a9da593e98c53 
>   docs/endpoints/profiler/stop.md 085b8523e3ccc03cae971d9ce1d8e2ef6a47a411 
> 
> Diff: https://reviews.apache.org/r/46901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46904: Fixed a typo in libprocess.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/#review134044
---


Ship it!




Ship It!

- Kapil Arya


On May 2, 2016, 3:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46904/
> ---
> 
> (Updated May 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected a misspelled word in 'future.hpp'.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 011fea8cedc75ac06599602252974f4ce662c893 
> 
> Diff: https://reviews.apache.org/r/46904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47603/#review134039
---



Bad patch!

Reviews applied: [47603, 47602, 47576, 47536, 47472, 47471, 47470, 47469, 
47468, 47412, 47411, 47410, 47409, 47404, 47403, 47391, 47390, 47389, 47388, 
47387, 47386, 47169, 47168, 41632, 47054, 47221, 47053, 47052]

Failed command: ./support/apply-review.sh -n -r 47471

Error:
2016-05-19 21:25:51 URL:https://reviews.apache.org/r/47471/diff/raw/ 
[5804/5804] -> "47471.patch" [1]
error: patch failed: src/exec/exec.cpp:595
error: src/exec/exec.cpp: patch does not apply
error: patch failed: src/executor/executor.cpp:154
error: src/executor/executor.cpp: patch does not apply
error: patch failed: src/launcher/fetcher.cpp:443
error: src/launcher/fetcher.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13186/console

- Mesos ReviewBot


On May 19, 2016, 4:08 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47603/
> ---
> 
> (Updated May 19, 2016, 4:08 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent:[2/2] Added Windows support for folder `launcher/`.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/launcher/executor.hpp PRE-CREATION 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/posix/executor.hpp PRE-CREATION 
>   src/launcher/windows/executor.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47594: Skipped the bind mount of CNI net info root dir if possible.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47594/#review134030
---



Patch looks great!

Reviews applied: [47594]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 2:31 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47594/
> ---
> 
> (Updated May 19, 2016, 2:31 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5413
> https://issues.apache.org/jira/browse/MESOS-5413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Skipped the bind mount of CNI net info root dir if possible.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> dae369aadb940150aa806b28d9269e3d88cf57ed 
> 
> Diff: https://reviews.apache.org/r/47594/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Avinash sridharan]

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote:
> > docs/cni.md, line 247
> > 
> >
> > and vice versa unless the executor uses HTTP API?
> 
> Avinash sridharan wrote:
> Even with the HTTP API the requirement of routeability (in both 
> directions) would still hold right?
> 
> Vinod Kone wrote:
> With HTTP API, agent doesn't directly make connections to the executor. 
> It just sends messages on the connection opened by the executor.

Well .. TCP is bi-directional so you will still need routeability in both 
directions at the IP layer?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133782
---


On May 19, 2016, 8:05 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> ---
> 
> (Updated May 19, 2016, 8:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
> https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> ---
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Vinod Kone]

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote:
> > docs/cni.md, line 247
> > 
> >
> > and vice versa unless the executor uses HTTP API?
> 
> Avinash sridharan wrote:
> Even with the HTTP API the requirement of routeability (in both 
> directions) would still hold right?

With HTTP API, agent doesn't directly make connections to the executor. It just 
sends messages on the connection opened by the executor.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133782
---


On May 19, 2016, 8:05 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> ---
> 
> (Updated May 19, 2016, 8:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
> https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> ---
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 47581: Delete the /observe HTTP endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47581/#review134011
---



Patch looks great!

Reviews applied: [47581]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 19, 2016, 7:19 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47581/
> ---
> 
> (Updated May 19, 2016, 7:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5408
> https://issues.apache.org/jira/browse/MESOS-5408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Delete the /observe HTTP endpoint.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 31ca5e5e37b1369fa8b74a649432fbc9b5addbe6 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 
>   src/local/local.cpp 4b054a4d39e4fee10c93afc197dd33bc7fa27ae3 
>   src/master/http.cpp 5d73a1dde24cc2231fd8054cbc715d2618134f02 
>   src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
>   src/master/master.hpp 647b43c8c6f1d53baeb2f795ef7d45b07a779ace 
>   src/master/master.cpp b8c732a6178777544f0d09708177d9c68ab0532b 
>   src/master/repairer.hpp 04594e200d3f09ba38a600b72038cfd88a596662 
>   src/master/repairer.cpp bee6b48f76cd5d009d0aaea667be2ddda1c905be 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp ef9c95e378c3d65458e9e1bef78724e4e79c5af6 
>   src/tests/repair_tests.cpp f213ec94f4a3ecc5499983b1b36756f580b0543d 
> 
> Diff: https://reviews.apache.org/r/47581/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/
---

(Updated May 19, 2016, 6:38 p.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
Qian Zhang, and Vinod Kone.


Bugs: MESOS-4771
https://issues.apache.org/jira/browse/MESOS-4771


Repository: mesos


Description
---

Added documentation for `network/cni` isolator.


Diffs (updated)
-

  docs/cni.md PRE-CREATION 

Diff: https://reviews.apache.org/r/47463/diff/


Testing
---

Build the documentation website and verified the rendering.

You can review a rendering of the markdown on my github:
https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md


Thanks,

Avinash sridharan

Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47608/
---

Review request for mesos.


Repository: mesos


Description
---

WIP: Add Labels from TaskInfo into TaskStatus message.


Diffs
-

  src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 
  src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 
  src/tests/slave_tests.cpp e1f5bfe074c357f46403887365b3f9ae554000b4 

Diff: https://reviews.apache.org/r/47608/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47610/
---

Review request for mesos.


Repository: mesos


Description
---

The libelf library is not a standard library installed on all Linux
systems, and it is not a library required to build stout in
general. It is only required for subsystems that happen to use the
 header. As such, we should only require this
dependency for those specific subsystems. If we ever decide to build
something into stout that depends on libelf by default, we can
revisit this issue then.


Diffs
-

  3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 

Diff: https://reviews.apache.org/r/47610/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 47609: Reverted adding libelf as a default dynamic library in libprocess.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47609/
---

Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-5414
https://issues.apache.org/jira/browse/MESOS-5414


Repository: mesos


Description
---

The libelf library is not a standard library installed on all Linux
systems, and it is not a library required to build libprocess in
general. It is only required for subsystems that happen to use the
 header. As such, we should only require this
dependency for those specific subsystems. If we ever decide to build
something into libprocess that depends on libelf by default, we can
revisit this issue then.


Diffs
-

  3rdparty/libprocess/configure.ac 2daded51122ab97d71ec57109b85c2473460eeda 

Diff: https://reviews.apache.org/r/47609/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 47587: Created separate local data file to manage releases information.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133989
---




site/source/index.html.erb (line 57)


Could be splitted 

```
https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=<%=
 item.target_version %>">
  CHANGELOG

```


- Tomasz Janiszewski


On May 19, 2016, 4:16 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Kevin Klues]

> On May 19, 2016, 8:48 a.m., Michael Park wrote:
> > 3rdparty/stout/include/stout/os/read.hpp, line 118
> > 
> >
> > Let's just wrap this in a `std::unique_ptr` instead!
> 
> Benjamin Bannier wrote:
> +1, or just a `std::string` since most probably the reflex might be to 
> *always* use `Owned` instead of `std::unique_ptr`, but that one cannot be 
> used to manage dynamic arrays.
> 
> Jan Schlicht wrote:
> We could also use a `std::vector` or instead, like
> ```
> std::vector buffer;
> buffer.reserve(BUFSIZ);
> ```
> 
> Jan Schlicht wrote:
> Please see the discussion at https://reviews.apache.org/r/47481/ on why 
> this isn't any of the suggested types.
> 
> Kevin Klues wrote:
> Copying here for reference (from https://reviews.apache.org/r/47481/):
> 
> I agree that this needs to be delete[]. Thanks for that.
> 
> I can see why this bug was introduced over time though. If you look back 
> at revision 1 of this patch, I wasn't using temporary storage at all, which 
> would have avoided this bug altogether. Unfortunately, this approach was 
> vetoed by the reviewer, leading to revision 2, which used a stack allocated 
> array. This also didn't have the bug, but introduced other "stylistic" 
> problems that the reviewers weren't happy with. In revision 3, I used a 
> std::vector as you suggest, but it never made it back to reviewboard 
> because it was vetoed in external feedback. As a compromise, I started using 
> a unique_ptr<> in revision 4, but this was vetoed as well. Looks like I 
> overlooked the proper delete to use after 5 revisions through a very simple 
> patch.
> 
> I would personally do away with the temporary storage and go with the 
> approach I have in revision 1 on review board. If we are going the temporary 
> storage route, I  would prefer the std::vector approach as you suggest. 
> 
> Need to convince a shepherd though.

The decision to use new -> delete semantics instead of unique_ptr<> or 
vector was for consistency with other code in stout.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133900
---


On May 19, 2016, 2:49 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Benjamin 
> Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote:
> > site/source/index.html.erb, line 15
> > 
> >
> > Do we have line length policy for site files?
> 
> haosdent huang wrote:
> Thank you very much for your reviews, let me fix it.

For some url like
```
https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=<%=
 item.target_version %>">CHANGELOG
```
I keep them because they could not be break.

For the script copy from twitter embed guide, I keep them as well.

```
!function(d,s,id){var 
js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document,
 'script', 'twitter-wjs');
```

For other cases, I adjusted them to match 80 characters limit. May you help to 
review this patch again? Thank you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133949
---


On May 19, 2016, 4:16 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47603/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Agent:[2/2] Added Windows support for folder `launcher/`.


Diffs
-

  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/launcher/executor.hpp PRE-CREATION 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/posix/executor.hpp PRE-CREATION 
  src/launcher/windows/executor.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47603/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs
-

  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote:
> > site/source/index.html.erb, line 15
> > 
> >
> > Do we have line length policy for site files?

Thank you very much for your reviews, let me fix it.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133949
---


On May 19, 2016, 10:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

> On May 19, 2016, 3 p.m., Tomasz Janiszewski wrote:
> > After switching to `.erb` we lost `` and breadcrumbs

Good catch! Let me fix.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133952
---


On May 19, 2016, 10:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47601: Fixed broken libelf dependency.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47601/
---

Review request for mesos.


Repository: mesos


Description
---

Unfortunately, we recently introduced a global dependency on libelf,
which broke the mesos build. The only subsystem that actually depends
on libelf is the Nvidia GPU isolator, so we should really have only
been adding the dependency in cases where ENABLE_NVIDIA_GPU_SUPPORT
was set. This patch moves the logic to require the dependency only
when this flag is set.


Diffs
-

  configure.ac f61ff77e81f0612f0a4454f1d28572f7b06e8233 
  src/Makefile.am 705f132de31ccd2e0180079124ff20b37208356a 

Diff: https://reviews.apache.org/r/47601/diff/


Testing
---

`make -j check`

`OS=ubuntu:14.04 COMPILER=gcc CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1 
MESOS_VERBOSE=1" ./support/docker_build.sh`


Thanks,

Kevin Klues

Re: Review Request 47601: Fixed broken libelf dependency.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47601/#review133956
---


Ship it!




Ship It!

- Till Toenshoff


On May 19, 2016, 3:54 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47601/
> ---
> 
> (Updated May 19, 2016, 3:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-5414
> https://issues.apache.org/jira/browse/MESOS-5414
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unfortunately, we recently introduced a global dependency on libelf,
> which broke the mesos build. The only subsystem that actually depends
> on libelf is the Nvidia GPU isolator, so we should really have only
> been adding the dependency in cases where ENABLE_NVIDIA_GPU_SUPPORT
> was set. This patch moves the logic to require the dependency only
> when this flag is set.
> 
> 
> Diffs
> -
> 
>   configure.ac f61ff77e81f0612f0a4454f1d28572f7b06e8233 
>   src/Makefile.am 705f132de31ccd2e0180079124ff20b37208356a 
> 
> Diff: https://reviews.apache.org/r/47601/diff/
> 
> 
> Testing
> ---
> 
> `make -j check`
> 
> `OS=ubuntu:14.04 COMPILER=gcc CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1 
> MESOS_VERBOSE=1" ./support/docker_build.sh`
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47601: Fixed broken libelf dependency.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47601/
---

(Updated May 19, 2016, 3:54 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-5414
https://issues.apache.org/jira/browse/MESOS-5414


Repository: mesos


Description
---

Unfortunately, we recently introduced a global dependency on libelf,
which broke the mesos build. The only subsystem that actually depends
on libelf is the Nvidia GPU isolator, so we should really have only
been adding the dependency in cases where ENABLE_NVIDIA_GPU_SUPPORT
was set. This patch moves the logic to require the dependency only
when this flag is set.


Diffs
-

  configure.ac f61ff77e81f0612f0a4454f1d28572f7b06e8233 
  src/Makefile.am 705f132de31ccd2e0180079124ff20b37208356a 

Diff: https://reviews.apache.org/r/47601/diff/


Testing
---

`make -j check`

`OS=ubuntu:14.04 COMPILER=gcc CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1 
MESOS_VERBOSE=1" ./support/docker_build.sh`


Thanks,

Kevin Klues

Re: Review Request 47587: Created separate local data file to manage releases information.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133952
---



After switching to `.erb` we lost `` and breadcrumbs

- Tomasz Janiszewski


On May 19, 2016, 10:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133937
---




docs/cni.md (line 3)


Phrasing is awkward: who is "we", and when "have we introduced" the CNI 
isolator? Better would be: "The Mesos `network/cni` isolator allows containers 
launched using the `MesosContainerizer` to be attached to several different 
types of IP networks."



docs/cni.md (line 40)


Saying "network namespace" three times in one sentence seems regrettable.



docs/cni.md (line 57)


"and" twice.


- Neil Conway


On May 18, 2016, 1:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> ---
> 
> (Updated May 18, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
> https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> ---
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133949
---




site/source/index.html.erb (line 15)


Do we have line length policy for site files?


- Tomasz Janiszewski


On May 19, 2016, 10:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> ---
> 
> (Updated May 19, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
> https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> ---
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Jan Schlicht]

> On May 19, 2016, 10:48 a.m., Michael Park wrote:
> > 3rdparty/stout/include/stout/os/read.hpp, line 118
> > 
> >
> > Let's just wrap this in a `std::unique_ptr` instead!
> 
> Benjamin Bannier wrote:
> +1, or just a `std::string` since most probably the reflex might be to 
> *always* use `Owned` instead of `std::unique_ptr`, but that one cannot be 
> used to manage dynamic arrays.
> 
> Jan Schlicht wrote:
> We could also use a `std::vector` or instead, like
> ```
> std::vector buffer;
> buffer.reserve(BUFSIZ);
> ```

Please see the discussion at https://reviews.apache.org/r/47481/ on why this 
isn't any of the suggested types.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133900
---


On May 19, 2016, 10:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 47594: Skipped the bind mount of CNI net info root dir if possible.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47594/
---

Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5413
https://issues.apache.org/jira/browse/MESOS-5413


Repository: mesos


Description
---

Skipped the bind mount of CNI net info root dir if possible.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dae369aadb940150aa806b28d9269e3d88cf57ed 

Diff: https://reviews.apache.org/r/47594/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

[Kevin Klues]

> On May 19, 2016, 9:12 a.m., Jan Schlicht wrote:
> > 3rdparty/stout/include/stout/os/read.hpp, line 136
> > 
> >
> > s/delete/delete[]
> > 
> > Why not use a `std::vector` for `buffer`?
> > 
> > I've opened https://reviews.apache.org/r/47585/ to fix this.

I agree that this needs to be `delete[]`. Thanks for that.

I can see why this bug was introduced over time though. If you look back at 
revision 1 of this patch, I wasn't using temporary storage at all, which would 
have avoided this bug altogether. Unfortunately, this approach was vetoed by 
the reviewer, leading to revision 2, which used a stack allocated array. This 
also didn't have the bug, but introduced other "stylistic" problems that the 
reviewers weren't happy with. In revision 3, I used a `std::vector` as 
you suggest, but it never made it back to reviewboard because it was vetoed in 
external feedback. As a compromise, I started using a `unique_ptr<>` in 
revision 4, but this was vetoed as well. Looks like I overlooked the proper 
delete to use after 5 revisions through a very simple patch.

I would personally do away with the temporary storage and go with the approach 
I have in revision 1 on review board. If we are going the temporary storage 
route, I  would prefer the `std::vector` approach as you suggest. 

Need to convince a shepherd though.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/#review133904
---


On May 18, 2016, 3:25 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47481/
> ---
> 
> (Updated May 18, 2016, 3:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched 
> to 'mcypark'.
> 
> 
> Bugs: MESOS-5398
> https://issues.apache.org/jira/browse/MESOS-5398
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous read() implementation was based on calling getline() to
> read in chunks of data from a file. This is fine for text-based files,
> but is a little strange for binary files.
> 
> The new implementation reads in chunks of raw bytes into a stack
> allocated buffer before copying them into their final location. I
> usually don't like stack allocated buffers because of their potential
> security implications when it comes to stack buffer overflows, but I
> took extra care here to make sure there won't be any.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> e1e97c1bcb7493a734fc77721a83c230b1a23724 
> 
> Diff: https://reviews.apache.org/r/47481/diff/
> 
> 
> Testing
> ---
> 
> make check -j
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47484: Added -lelf to default dynamic libraries on Linux.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47484/#review133926
---



Can someone revert this commit? This commit caused I can't find libz on both 
Ubuntu and CentOS.

- Zhiwei Chen


On May 18, 2016, 3:17 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47484/
> ---
> 
> (Updated May 18, 2016, 3:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5400
> https://issues.apache.org/jira/browse/MESOS-5400
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added -lelf to default dynamic libraries on Linux.
> 
> 
> Diffs
> -
> 
>   configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 
> 
> Diff: https://reviews.apache.org/r/47484/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/
---

(Updated May 19, 2016, 10:29 a.m.)


Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
Anderegg, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-1495
https://issues.apache.org/jira/browse/MESOS-1495


Repository: mesos


Description
---

Created separate local data file to manage releases information.


Diffs (updated)
-

  site/data/releases.yml PRE-CREATION 
  site/source/downloads.html.erb PRE-CREATION 
  site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
  site/source/index.html.erb PRE-CREATION 
  site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 

Diff: https://reviews.apache.org/r/47587/diff/


Testing
---

Test by re-generate the website in my local machine.


Thanks,

haosdent huang

Review Request 47587: Created separate local data file to manage releases information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/
---

Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
Anderegg, and Vinod Kone.


Bugs: MESOS-1495
https://issues.apache.org/jira/browse/MESOS-1495


Repository: mesos


Description
---

Created separate local data file to manage releases information.


Diffs
-

  site/data/releases.yml PRE-CREATION 
  site/source/downloads.html.erb PRE-CREATION 
  site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
  site/source/index.html.erb PRE-CREATION 
  site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 

Diff: https://reviews.apache.org/r/47587/diff/


Testing
---

Test by re-generate the website in my local machine.


Thanks,

haosdent huang

Re: Review Request 46501: Updated authorization.md to reflect current changes.

[Alexander Rukletsov]

> On May 18, 2016, 10:17 a.m., Alexander Rukletsov wrote:
> > docs/authorization.md, lines 566-580
> > 
> >
> > It's hard to remember that this doc should be updated if changes to the 
> > proto are made. Can we reference the code instead? Could you please follow 
> > up with a fix?
> 
> Alexander Rojas wrote:
> If you look at the history, other reviewers were against linking to the 
> code here.

If I look at https://reviews.apache.org/r/47505/ I see how easy is to forget to 
update this code. I leave this decision to you.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review133711
---


On May 17, 2016, 1:11 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> ---
> 
> (Updated May 17, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4785
> https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 46501: Updated authorization.md to reflect current changes.

[Alexander Rojas]

> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, lines 566-580
> > 
> >
> > It's hard to remember that this doc should be updated if changes to the 
> > proto are made. Can we reference the code instead? Could you please follow 
> > up with a fix?

If you look at the history, other reviewers were against linking to the code 
here.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review133711
---


On May 17, 2016, 3:11 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> ---
> 
> (Updated May 17, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4785
> https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/#review133904
---




3rdparty/stout/include/stout/os/read.hpp (lines 90 - 103)


`getline` is no longer used in the code below. Can this be removed then?



3rdparty/stout/include/stout/os/read.hpp (line 129)


s/delete/delete[]

Why not use a `std::vector` for `buffer`?

I've opened https://reviews.apache.org/r/47585/ to fix this.



3rdparty/stout/include/stout/os/read.hpp (line 142)


s/delete/delete[]


- Jan Schlicht


On May 18, 2016, 5:25 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47481/
> ---
> 
> (Updated May 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched 
> to 'mcypark'.
> 
> 
> Bugs: MESOS-5398
> https://issues.apache.org/jira/browse/MESOS-5398
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous read() implementation was based on calling getline() to
> read in chunks of data from a file. This is fine for text-based files,
> but is a little strange for binary files.
> 
> The new implementation reads in chunks of raw bytes into a stack
> allocated buffer before copying them into their final location. I
> usually don't like stack allocated buffers because of their potential
> security implications when it comes to stack buffer overflows, but I
> took extra care here to make sure there won't be any.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> e1e97c1bcb7493a734fc77721a83c230b1a23724 
> 
> Diff: https://reviews.apache.org/r/47481/diff/
> 
> 
> Testing
> ---
> 
> make check -j
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Jan Schlicht]

> On May 19, 2016, 10:48 a.m., Michael Park wrote:
> > 3rdparty/stout/include/stout/os/read.hpp, line 118
> > 
> >
> > Let's just wrap this in a `std::unique_ptr` instead!
> 
> Benjamin Bannier wrote:
> +1, or just a `std::string` since most probably the reflex might be to 
> *always* use `Owned` instead of `std::unique_ptr`, but that one cannot be 
> used to manage dynamic arrays.

We could also use a `std::vector` or instead, like
```
std::vector buffer;
buffer.reserve(BUFSIZ);
```


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133900
---


On May 19, 2016, 10:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Benjamin Bannier]

> On May 19, 2016, 10:48 a.m., Michael Park wrote:
> > 3rdparty/stout/include/stout/os/read.hpp, line 118
> > 
> >
> > Let's just wrap this in a `std::unique_ptr` instead!

+1, or just a `std::string` since most probably the reflex might be to *always* 
use `Owned` instead of `std::unique_ptr`, but that one cannot be used to manage 
dynamic arrays.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133900
---


On May 19, 2016, 10:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133903
---



Since this was easy to pin down could you mention the commit which introduced 
this (`d9d65089134c0849b362a78e7cb071c0b26dd616`) in the description?

- Benjamin Bannier


On May 19, 2016, 10:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 47585: Fixed a mismatched 'delete'.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/#review133900
---




3rdparty/stout/include/stout/os/read.hpp (line 118)


Let's just wrap this in a `std::unique_ptr` instead!


- Michael Park


On May 19, 2016, 8:42 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47585/
> ---
> 
> (Updated May 19, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/read.hpp 
> c39140fc17c5b4869c3a90c187ebcb9c284397f4 
> 
> Diff: https://reviews.apache.org/r/47585/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 47585: Fixed a mismatched 'delete'.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47585/
---

Review request for mesos, Benjamin Bannier and Bernd Mathiske.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/stout/include/stout/os/read.hpp 
c39140fc17c5b4869c3a90c187ebcb9c284397f4 

Diff: https://reviews.apache.org/r/47585/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47530/#review133897
---


Fix it, then Ship it!




I'll take care of the outstanding issues and commit this for you in a jiffy.


src/slave/http.cpp (line 769)


This looks fishy. I understand why you do this, but we should resolve 
https://issues.apache.org/jira/browse/MESOS-5293 ASAP



src/slave/http.cpp (lines 781 - 785)


Why do you need to move `.repair` here?



src/slave/slave.hpp (line 23)


We don't need it here any more. Move it back to cpp.


- Alexander Rukletsov


On May 18, 2016, 8 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47530/
> ---
> 
> (Updated May 18, 2016, 8 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5317
> https://issues.apache.org/jira/browse/MESOS-5317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used GET_ENDPOINT_WITH_PATH coarse-grained authz on agent's 
> '/containers' endpoint to enable authorization on this endpoint.
> Updated docs and testcases as well.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md 959f40b9db4de4b6cea456ecf7bcb402f7a94f05 
>   src/slave/http.cpp fb48ec61e2fe0c83f80d3b8aa4c2ef5a96b748ae 
>   src/slave/slave.hpp 209f071448e3c52d16d3366d564003ee36b1d2e0 
>   src/tests/slave_authorization_tests.cpp 
> 843cf1c631e0a25125ca1c0c0028ad1a920c2c2f 
> 
> Diff: https://reviews.apache.org/r/47530/diff/
> 
> 
> Testing
> ---
> 
> ## Unit tests.
> 
> On ubuntu 16.04:
> `sudo GTEST_FILTER="*SlaveEndpointTest*.*" make -j2 check`
> 
> ## Manual testing.
> 
> 1. Ran master with:
> ```
> sudo  ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> ```
> 
> 2. ACL File: 
> ```
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "NONE" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   } 
> ```
> 
> 3. Ran slave with: 
> ```
> sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 
> --acls=file:///home/abhishek/testAcl
> ```
> 
> 4. Ran toy-framework with: 
> ```
> sudo ./no-executor-framework --master=master@127.0.0.1:5050 --command="echo 
> hello"
> ```
> 
> 5. Output while hitting "http://127.0.0.1:5051/slave(1)/containers" - HTTP 
> error 403: Forbidden
> 
> 6. Changed ACL to: 
> ```
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "ANY" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   }
> ```
> 
> 7. Ran slave and framework again.
> 
> 8. Output:
> ```
> 
> [{"container_id":"9b8a6a51-68be-4763-9c7d-b67e85fccb4a","executor_id":"42","executor_name":"Command
>  Executor (Task: 42) (Command: sh -c 'echo hello')","framework_id":"52...
> ```
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 47463: Added documentation for `network/cni` isolator.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133899
---




docs/cni.md (line 5)


Add link to [Mesos Containerizer](mesos-containerizer.md) or References 
section with links to other docs


- Tomasz Janiszewski


On May 18, 2016, 1:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> ---
> 
> (Updated May 18, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
> https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> ---
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47530/#review133898
---


Fix it, then Ship it!





src/slave/http.cpp 


The `#include ` will need to be re-added when you remove the one in 
`slave/slave.hpp` (see issue below)



src/slave/http.cpp (lines 781 - 786)


This `repair` is probaly in a better place if it's moved to the end of 
`_containers`, similar to how it was before, so it'll stay
```
return process::http::OK(result, request.url.query.get("jsonp"));
  })
  .repair([](const Future& future) {
LOG(WARNING) << "Could not collect container status and statistics: 
"
 << (future.isFailed() ? future.failure() : 
"discarded");

return process::http::InternalServerError();
  });
}
```



src/slave/slave.hpp (line 23)


I think this can be removed.


- Jan Schlicht


On May 18, 2016, 10 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47530/
> ---
> 
> (Updated May 18, 2016, 10 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5317
> https://issues.apache.org/jira/browse/MESOS-5317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used GET_ENDPOINT_WITH_PATH coarse-grained authz on agent's 
> '/containers' endpoint to enable authorization on this endpoint.
> Updated docs and testcases as well.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md 959f40b9db4de4b6cea456ecf7bcb402f7a94f05 
>   src/slave/http.cpp fb48ec61e2fe0c83f80d3b8aa4c2ef5a96b748ae 
>   src/slave/slave.hpp 209f071448e3c52d16d3366d564003ee36b1d2e0 
>   src/tests/slave_authorization_tests.cpp 
> 843cf1c631e0a25125ca1c0c0028ad1a920c2c2f 
> 
> Diff: https://reviews.apache.org/r/47530/diff/
> 
> 
> Testing
> ---
> 
> ## Unit tests.
> 
> On ubuntu 16.04:
> `sudo GTEST_FILTER="*SlaveEndpointTest*.*" make -j2 check`
> 
> ## Manual testing.
> 
> 1. Ran master with:
> ```
> sudo  ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> ```
> 
> 2. ACL File: 
> ```
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "NONE" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   } 
> ```
> 
> 3. Ran slave with: 
> ```
> sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 
> --acls=file:///home/abhishek/testAcl
> ```
> 
> 4. Ran toy-framework with: 
> ```
> sudo ./no-executor-framework --master=master@127.0.0.1:5050 --command="echo 
> hello"
> ```
> 
> 5. Output while hitting "http://127.0.0.1:5051/slave(1)/containers" - HTTP 
> error 403: Forbidden
> 
> 6. Changed ACL to: 
> ```
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "ANY" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   }
> ```
> 
> 7. Ran slave and framework again.
> 
> 8. Output:
> ```
> 
> [{"container_id":"9b8a6a51-68be-4763-9c7d-b67e85fccb4a","executor_id":"42","executor_name":"Command
>  Executor (Task: 42) (Command: sh -c 'echo hello')","framework_id":"52...
> ```
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133891
---


Fix it, then Ship it!




Thanks a lot, Zhitao! I'll push it shortly.


CHANGELOG (line 59)


Strictly speaking, ACLs are only for local authorizer, hence it's more 
inportant to say we deprecate actions. I'll rephrase.



CHANGELOG (line 60)


Please wrap.



docs/authorization.md (line 129)


"Updating" is a bit misleading. We want to reference all three actions: 
set, remove, and update. Let's say "Modifying".



docs/authorization.md (line 130)


Not yours, but let's s/Roles/Resource roles/ for consistency.



docs/authorization.md (line 525)


s/retrive/query.



docs/authorization.md (line 555)


s/principals/principal. Here and above



docs/quota.md (line 159)


s/retrieve/query



docs/quota.md (line 189)


s/information/information

We wrap at 80 chars for readability and diff'ability



docs/upgrades.md (line 169)


I'll do minor tweaks here.


- Alexander Rukletsov


On May 19, 2016, 4:34 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 19, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Freddy Ayuso-Henson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133895
---


Ship it!




Ship It!

- Freddy Ayuso-Henson


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Freddy Ayuso-Henson]

> On May 19, 2016, 7:12 a.m., Freddy Ayuso-Henson wrote:
> > Here are some screenshots of what the original PR aimed to achieve. It's a 
> > bit different from what's being reviewed, I think (moving the ASF 
> > links/breadcrumbs to the footer, vertically centering the menu on the 
> > desktop, alignment of the menu on mobile, etc.)
> > 
> > Should we add these changes to the what's being reviewed?
> > 
> > ![Desktop](https://issues.apache.org/jira/secure/attachment/12804884/mesos-screenshot.png)
> > ![Mobile without 
> > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile.png)
> > ![Mobile with 
> > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile1.png)
> 
> haosdent huang wrote:
> >moving the ASF links/breadcrumbs to the footer, vertically centering the 
> menu on the desktop, alignment of the menu on mobile, etc
> @fayusohenson I think it is better to keep the breadcrumb on the head 
> currently without broken current PC style.
> After new design out, we could discuss if move it to the footer. For 
> short term, I suggest to keep it so I remove that in your patch.
> Do you think this is make sense?

Yes, that sounds good.


- Freddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133892
---


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[haosdent huang]

> On May 19, 2016, 7:12 a.m., Freddy Ayuso-Henson wrote:
> > Here are some screenshots of what the original PR aimed to achieve. It's a 
> > bit different from what's being reviewed, I think (moving the ASF 
> > links/breadcrumbs to the footer, vertically centering the menu on the 
> > desktop, alignment of the menu on mobile, etc.)
> > 
> > Should we add these changes to the what's being reviewed?
> > 
> > ![Desktop](https://issues.apache.org/jira/secure/attachment/12804884/mesos-screenshot.png)
> > ![Mobile without 
> > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile.png)
> > ![Mobile with 
> > menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile1.png)

>moving the ASF links/breadcrumbs to the footer, vertically centering the menu 
>on the desktop, alignment of the menu on mobile, etc
@fayusohenson I think it is better to keep the breadcrumb on the head currently 
without broken current PC style.
After new design out, we could discuss if move it to the footer. For short 
term, I suggest to keep it so I remove that in your patch.
Do you think this is make sense?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133892
---


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47581: Delete the /observe HTTP endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47581/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5408
https://issues.apache.org/jira/browse/MESOS-5408


Repository: mesos


Description
---

Delete the /observe HTTP endpoint.


Diffs
-

  CHANGELOG 31ca5e5e37b1369fa8b74a649432fbc9b5addbe6 
  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 
  src/local/local.cpp 4b054a4d39e4fee10c93afc197dd33bc7fa27ae3 
  src/master/http.cpp 5d73a1dde24cc2231fd8054cbc715d2618134f02 
  src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
  src/master/master.hpp 647b43c8c6f1d53baeb2f795ef7d45b07a779ace 
  src/master/master.cpp b8c732a6178777544f0d09708177d9c68ab0532b 
  src/master/repairer.hpp 04594e200d3f09ba38a600b72038cfd88a596662 
  src/master/repairer.cpp bee6b48f76cd5d009d0aaea667be2ddda1c905be 
  src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
  src/tests/cluster.cpp ef9c95e378c3d65458e9e1bef78724e4e79c5af6 
  src/tests/repair_tests.cpp f213ec94f4a3ecc5499983b1b36756f580b0543d 

Diff: https://reviews.apache.org/r/47581/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Freddy Ayuso-Henson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133892
---



Here are some screenshots of what the original PR aimed to achieve. It's a bit 
different from what's being reviewed, I think (moving the ASF links/breadcrumbs 
to the footer, vertically centering the menu on the desktop, alignment of the 
menu on mobile, etc.)

Should we add these changes to the what's being reviewed?

![Desktop](https://issues.apache.org/jira/secure/attachment/12804884/mesos-screenshot.png)
![Mobile without 
menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile.png)
![Mobile with 
menu](https://issues.apache.org/jira/secure/attachment/12804886/mesos-screenshot-mobile1.png)

- Freddy Ayuso-Henson


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47582: Include v1 Executor Protos in maven jar.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47582/
---

(Updated 五月 19, 2016, 6:54 a.m.)


Review request for mesos and Vinod Kone.


Bugs: mesos-5390
https://issues.apache.org/jira/browse/mesos-5390


Repository: mesos


Description
---

Update the Makefile to include v1 executor protos classes files
in the generated mesos maven jar.


Diffs
-

  src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 

Diff: https://reviews.apache.org/r/47582/diff/


Testing (updated)
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos

make
make check

cd src/java/target

check the output of the following command, a positive number should returned 
which indicates there are executor classes inside:

unzip -lf mesos-0.29.0.jar | grep "v1\/executor" | wc -l


Thanks,

zhou xing

Review Request 47582: Include v1 Executor Protos in maven jar.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47582/
---

Review request for mesos and Vinod Kone.


Bugs: mesos-5390
https://issues.apache.org/jira/browse/mesos-5390


Repository: mesos


Description
---

Update the Makefile to include v1 executor protos classes files
in the generated mesos maven jar.


Diffs
-

  src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 

Diff: https://reviews.apache.org/r/47582/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos

make
make check

cd src/java/target

check the output of the following command, a positive number should returned 
which indicates there are executor classes inside:

unzip -lf mesos-0.29.0-sources.jar | grep "v1\/executor" | wc -l


Thanks,

zhou xing

Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47485/#review133888
---


Ship it!




Kevin and I went over this and made some adjustments, mostly related to 
variable naming, some comment changes, a few changes to the code style.

- Benjamin Mahler


On May 19, 2016, 5:38 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47485/
> ---
> 
> (Updated May 19, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5398
> https://issues.apache.org/jira/browse/MESOS-5398
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added utility for parsing ld.so.cache on linux.
> 
> 
> Diffs
> -
> 
>   configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 
>   src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 
>   src/linux/ldcache.hpp PRE-CREATION 
>   src/linux/ldcache.cpp PRE-CREATION 
>   src/tests/ldcache_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47485/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="LdcacheTest.Parse" make check -j
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>