Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/#review175065
---



Patch looks great!

Reviews applied: [59293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 15, 2017, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59293/
> ---
> 
> (Updated May 15, 2017, 8:45 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Write using 'wb' instead of 'w' for binary mode. This writes the
> downloaded patch file exactly as it came, instead of treating as text
> and changing line endings. This resolves a bug where `git apply` doesn't
> always work with CRLF endings in patch files.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850 
> 
> 
> Diff: https://reviews.apache.org/r/59293/diff/1/
> 
> 
> Testing
> ---
> 
> Applied patch 59177 successfully after failing to apply it without change due 
> to:
> 
> ```
> 59177.patch:9: trailing whitespace.
> 
> 59177.patch:18: trailing whitespace.
> def autocomplete(cmds, plugins, config, argv):
> 59177.patch:26: trailing whitespace.
> current_word = argv[0]
> 59177.patch:27: trailing whitespace.
> argv = argv[1:]
> 59177.patch:36: trailing whitespace.
> return plugin_class(settings, config).__autocomplete_base__(
> error: git apply: bad git-diff - expected /dev/null on line 167
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 53842: Add role specific metrics for sorting runs.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
---

(Updated May 16, 2017, 6:24 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description
---

Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role//sort_runs: Number of framework
   level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role//sort_run: Latency in framework
   level sorts (based on role) in DRF Sorter.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp 
b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 


Diff: https://reviews.apache.org/r/53842/diff/4/

Changes: https://reviews.apache.org/r/53842/diff/3-4/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

[Anindya Sinha]

> On April 20, 2017, 9:15 p.m., James Peach wrote:
> > src/master/allocator/sorter/drf/metrics.hpp
> > Lines 59 (patched)
> > 
> >
> > Why is this necessary? Is there a reason that publishing the dominant 
> > resources and shares for quotas doesn't make sense?

The reason publishing the dominant resources and shares for quotas is disabled 
because that is what was originally. The flag `includeClientMetrics` is most 
useful for framework sorters since we keep it disabled because of the 
possibility of high number of framework sorters 
(https://reviews.apache.org/r/53842/). However, I think it makes sense to 
enable this for quotas though.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/#review172540
---


On May 16, 2017, 6:24 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53841/
> ---
> 
> (Updated May 16, 2017, 6:24 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Following metrics have been added:
> a) allocator/mesos/roles/sort_runs: Number of role level sorts.
> b) allocator/mesos/roles/sort_run: Latency in role level sorts.
> c) allocator/mesos/quotas/sort_runs: Number of quota level sorts.
> d) allocator/mesos/quotas/sort_run: Latency in quota level sorts.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 123f97cf495bff0f822838e09df0d88818f04da6 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
>   src/master/allocator/sorter/drf/sorter.hpp 
> fee58d6d1f08163e2a06a4a20c891fe535c3dcff 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 26b77f578f3235a8792c72d4575d607cdb2c7de7 
>   src/tests/hierarchical_allocator_tests.cpp 
> 08180b9975869de328f0c095dd3cddf0c84fbecf 
> 
> 
> Diff: https://reviews.apache.org/r/53841/diff/4/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/
---

(Updated May 16, 2017, 6:24 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Rebased and minor edits.


Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description
---

Following metrics have been added:
a) allocator/mesos/roles/sort_runs: Number of role level sorts.
b) allocator/mesos/roles/sort_run: Latency in role level sorts.
c) allocator/mesos/quotas/sort_runs: Number of quota level sorts.
d) allocator/mesos/quotas/sort_run: Latency in quota level sorts.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
  src/master/allocator/sorter/drf/sorter.hpp 
fee58d6d1f08163e2a06a4a20c891fe535c3dcff 
  src/master/allocator/sorter/drf/sorter.cpp 
26b77f578f3235a8792c72d4575d607cdb2c7de7 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 


Diff: https://reviews.apache.org/r/53841/diff/4/

Changes: https://reviews.apache.org/r/53841/diff/3-4/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/
---

(Updated May 16, 2017, 6:23 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Addressed review comments.


Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description
---

Added a metric 'allocator/mesos/allocation_run_interval_ms' which
tracks the latency between scheduling an allocation to an actual
allocation run.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
  src/master/allocator/mesos/metrics.hpp 
ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
  src/master/allocator/mesos/metrics.cpp 
ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 


Diff: https://reviews.apache.org/r/53840/diff/5/

Changes: https://reviews.apache.org/r/53840/diff/4-5/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

[Anindya Sinha]

> On May 15, 2017, 5:25 a.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 3459-3463 (original), 3459-3462 (patched)
> > 
> >
> > Why this change? Seems like the two ways of expressing the expectation 
> > are equivalent.

Reinstated the original.


> On May 15, 2017, 5:25 a.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 3537 (patched)
> > 
> >
> > Seems inelegant to reuse the test for `allocation_run`, for 
> > `allocation_run` we are storing a full list of statistics in `statistics` 
> > but we are not doing the same for the new metric. Can we create an 
> > independent test?

Created a separate test for `allocation_run_latency`.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review174871
---


On May 16, 2017, 6:23 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53840/
> ---
> 
> (Updated May 16, 2017, 6:23 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a metric 'allocator/mesos/allocation_run_interval_ms' which
> tracks the latency between scheduling an allocation to an actual
> allocation run.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
>   src/master/allocator/mesos/metrics.hpp 
> ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
>   src/master/allocator/mesos/metrics.cpp 
> ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
>   src/tests/hierarchical_allocator_tests.cpp 
> 08180b9975869de328f0c095dd3cddf0c84fbecf 
> 
> 
> Diff: https://reviews.apache.org/r/53840/diff/5/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

[Anindya Sinha]

> On April 25, 2017, 4:41 p.m., James Peach wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1427 (original), 1428 (patched)
> > 
> >
> > You also need to stop the latency metric here, otherwise you will 
> > capture multiple allocator dispatches.

As Yan mentioned, I stop the `allocation_run_latency` as the first thing done 
in this function.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review172945
---


On May 16, 2017, 6:23 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53840/
> ---
> 
> (Updated May 16, 2017, 6:23 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a metric 'allocator/mesos/allocation_run_interval_ms' which
> tracks the latency between scheduling an allocation to an actual
> allocation run.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
>   src/master/allocator/mesos/metrics.hpp 
> ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
>   src/master/allocator/mesos/metrics.cpp 
> ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
>   src/tests/hierarchical_allocator_tests.cpp 
> 08180b9975869de328f0c095dd3cddf0c84fbecf 
> 
> 
> Diff: https://reviews.apache.org/r/53840/diff/5/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 58778: Supported GCE container registry.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175061
---


Ship it!




LGTM! Ship it!

- Gilbert Song


On May 15, 2017, 5:50 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> ---
> 
> (Updated May 15, 2017, 5:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
> https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58778: Supported GCE container registry.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175060
---




src/uri/fetchers/docker.cpp
Line 660 (original), 715 (patched)


I like the `__fetchBlob()` change. More readable in code.


- Gilbert Song


On May 15, 2017, 5:50 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> ---
> 
> (Updated May 15, 2017, 5:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
> https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 59286: Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59286/#review175059
---



Patch looks great!

Reviews applied: [59285, 59286]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 15, 2017, 7:13 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59286/
> ---
> 
> (Updated May 15, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.
> 
> 
> Diffs
> -
> 
>   CHANGELOG d95a5ceb817ff42c57f2b1978c39d6d03fe2f35c 
> 
> 
> Diff: https://reviews.apache.org/r/59286/diff/1/
> 
> 
> Testing
> ---
> 
> Visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 58486: Update the allocator on a per offer operation.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review175055
---



Patch looks great!

Reviews applied: [59194, 59195, 58486]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 15, 2017, 6:01 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> ---
> 
> (Updated May 15, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
> 
> 1) Launch or Launch Group: We launch the tasks or task group on the
>agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
>the `CheckPointResourcesMessage` to the agent.
> 
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/58486/diff/6/
> 
> 
> Testing
> ---
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.

[Joseph Wu]

> On May 11, 2017, 6:29 a.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp
> > Line 285 (original)
> > 
> >
> > Hum, can you point to me where do we mkdir for the sandbox?

The callstack is roughly:

* slave::paths::createExecutorDirectory: 
https://github.com/apache/mesos/blob/1.3.x/src/slave/paths.cpp#L543
* Slave::Framework::addExecutor: 
https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L6907-L6913
* `Slave::__run`: 
https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L2231

Which is right before the call to `containerizer->launch` in 
`Slave::launchExecutor`: 
https://github.com/apache/mesos/blob/1.3.x/src/slave/slave.cpp#L2233-L2248


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58906/#review174643
---


On May 1, 2017, 7:06 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58906/
> ---
> 
> (Updated May 1, 2017, 7:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Docker containerizer will create a stdout/stderr file as well
> `chown` the sandbox directory to the user specified at container
> creation time.  This logic is already performed elsewhere.
> 
> The stdout/stderr files will either be created prior to the container
> launch via the mesos-fetcher, or during launch via the ContainerLogger.
> 
> The sandbox directory will be `chown`d by the Agent when it
> starts to launch the executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58906/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 58778: Supported GCE container registry.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/
---

(Updated May 16, 2017, 12:50 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-7431
https://issues.apache.org/jira/browse/MESOS-7431


Repository: mesos


Description
---

Certain registries, such as GCE registry, reply 403 instead of 401 for
unauthorized requests. When fetching image manifests and blobs, instead
of sending out unauthorized requests first and waiting for a possible
401, we should always look up the docker config and send requests with
basic authorization when possible.


Diffs (updated)
-

  src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 


Diff: https://reviews.apache.org/r/58778/diff/5/

Changes: https://reviews.apache.org/r/58778/diff/4-5/


Testing
---

sudo make check (covers all supported public registries)
Manually tested on the following private registries:
1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
2. Amazon ECR
3. Google GCR
4. JFrog SaaS
5. Local Nexus registry 3.3.1


Thanks,

Chun-Hung Hsiao

Re: Review Request 58778: Supported GCE container registry.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175043
---


Fix it, then Ship it!





src/uri/fetchers/docker.cpp
Lines 449 (patched)


We have getAuthHeaderBasic and now we have getBasicAuthHeader. This is 
really confusing.

Let's use the same name `getAuthHeaderBasic` here (just different overload).



src/uri/fetchers/docker.cpp
Lines 693 (patched)


This is pretty confusing. Can we rename this parameter `basicAuthHeaders`?


- Jie Yu


On May 15, 2017, 5:39 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> ---
> 
> (Updated May 15, 2017, 5:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
> https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 59302: Simplified master logic for agent re-registration.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59302/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Now that 0.x agents are not supported, the master logic can be
simplified somewhat.


Diffs
-

  src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 


Diff: https://reviews.apache.org/r/59302/diff/1/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 59107: [WIP] Added extra debugging statements.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59107/
---

(Updated May 15, 2017, 11:27 p.m.)


Review request for mesos, Alexander Rukletsov and Gastón Kleiman.


Changes
---

Rebased, trying to trigger a CI build.


Repository: mesos


Description
---

Added extra debugging statements.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
97837c83cc223950750e4cd088f4da067023c96c 
  src/slave/containerizer/mesos/io/switchboard.cpp 
64180944f8680828781168faa67417489abf1bc8 
  src/slave/http.cpp 5beaf91de1ba948658fa7fa299a364432afcf50b 


Diff: https://reviews.apache.org/r/59107/diff/2/

Changes: https://reviews.apache.org/r/59107/diff/1-2/


Testing
---

Publishing this RR only to make the patch go through the Apache CI.


Thanks,

Gastón Kleiman

Re: Review Request 59216: Fixed some inaccurate comments.

[Neil Conway]

> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote:
> > include/mesos/master/master.proto
> > Lines 380-381 (original), 380-381 (patched)
> > 
> >
> > Just to clarify the intent of this comment, our deprecation cycle 
> > technically means that we can't remove this until 2.0, right?

Clarified these comments.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/#review174852
---


On May 15, 2017, 11:16 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59216/
> ---
> 
> (Updated May 15, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
> possible with Mesos 1.2.1 or Mesos >= 1.3.0.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 
> 
> 
> Diff: https://reviews.apache.org/r/59216/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 59216: Fixed some inaccurate comments.

[Neil Conway]

> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote:
> > include/mesos/master/master.proto
> > Line 382 (original), 382 (patched)
> > 
> >
> > Why not add the deprecation tag here and for tasks?
> > 
> > ```
> > repeated Task orphan_executors = 4 [deprecated = true];
> > ```

I did this in a separate review: https://reviews.apache.org/r/59301/


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/#review174852
---


On May 15, 2017, 11:16 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59216/
> ---
> 
> (Updated May 15, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
> possible with Mesos 1.2.1 or Mesos >= 1.3.0.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 
> 
> 
> Diff: https://reviews.apache.org/r/59216/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 59301: Marked a few deprecated proto fields with the "deprecated" option.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59301/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Marked a few deprecated proto fields with the "deprecated" option.


Diffs
-

  include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 


Diff: https://reviews.apache.org/r/59301/diff/1/


Testing
---

`make check`


Thanks,

Neil Conway

Review Request 59259: Cleaned up master code to check for PARTITION_AWARE capability.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59259/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Cleaned up master code to check for PARTITION_AWARE capability.


Diffs
-

  src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 


Diff: https://reviews.apache.org/r/59259/diff/1/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 59216: Fixed some inaccurate comments.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59216/
---

(Updated May 15, 2017, 11:16 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Clarified comments.


Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977


Repository: mesos


Description
---

Orphan tasks/executors are still possible in Mesos 1.2.0; they are not
possible with Mesos 1.2.1 or Mesos >= 1.3.0.


Diffs (updated)
-

  include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 


Diff: https://reviews.apache.org/r/59216/diff/2/

Changes: https://reviews.apache.org/r/59216/diff/1-2/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 59214: Removed code for handling missing FrameworkInfo of a running task.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59214/
---

(Updated May 15, 2017, 11:13 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Clarify code for writing empty JSON arrays.


Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977


Repository: mesos


Description
---

In previous versions of Mesos, the master might know about a task
running on an agent, but might not have a `FrameworkInfo` for that
task's framework. This might occur if the master fails over, the agent
re-registers, but the framework has not (yet) re-registered.

In Mesos 1.0, the agent will now supply the FrameworkInfo for all tasks
it is running when it re-registers with the master. Since we no longer
support 0.x agents, we can remove the old backward compatibility code
for handling a running task with unknown FrameworkInfo.

Note that this means that "orphan tasks", "orphan executors", and
"unregistered frameworks" are no longer possible.


Diffs (updated)
-

  src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da 
  src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 


Diff: https://reviews.apache.org/r/59214/diff/2/

Changes: https://reviews.apache.org/r/59214/diff/1-2/


Testing
---

`make check`


Thanks,

Neil Conway

Review Request 59300: Updated documentation for `registrar/log/network_size`.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59300/
---

Review request for mesos, Anindya Sinha and Benjamin Mahler.


Repository: mesos


Description
---

Updated documentation for `registrar/log/network_size`.


Diffs
-

  docs/monitoring.md c42afce0a26dc15e033ee1375b7cb23d55be40ab 


Diff: https://reviews.apache.org/r/59300/diff/1/


Testing
---

Markdown viewer.


Thanks,

Jiang Yan Xu

Review Request 59290: Added '/log/network_size' metric.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59290/
---

Review request for mesos, Anindya Sinha and Benjamin Mahler.


Bugs: MESOS-7507
https://issues.apache.org/jira/browse/MESOS-7507


Repository: mesos


Description
---

Added '/log/network_size' metric.

Will update monitoring.md next.


Diffs
-

  src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
  src/log/metrics.hpp PRE-CREATION 
  src/log/metrics.cpp PRE-CREATION 
  src/tests/log_tests.cpp 52b1bfedd8d3f8f2ab3308c4be9f167126ee694b 


Diff: https://reviews.apache.org/r/59290/diff/1/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Review Request 59289: Refactored log Metrics into separate files.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59289/
---

Review request for mesos, Anindya Sinha and Jie Yu.


Bugs: MESOS-7507
https://issues.apache.org/jira/browse/MESOS-7507


Repository: mesos


Description
---

A separate cpp file is more appropriate as we add more metrics and 
make the struct more complex.

No functional change.


Diffs
-

  src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
  src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
  src/log/metrics.hpp PRE-CREATION 
  src/log/metrics.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59289/diff/1/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in stout/{posix|windows}.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/
---

(Updated May 15, 2017, 10:43 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Changes
---

Update bug number, reviewers


Bugs: MESOS-5938
https://issues.apache.org/jira/browse/MESOS-5938


Repository: mesos


Description
---

Required since autotools includes .hpp files.


Diffs
-

  3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217 


Diff: https://reviews.apache.org/r/59297/diff/1/


Testing
---

This was an autotools-specific problem, I didn't catch this right away since my 
tests didn't build with autotools.

Now they do:

1. Autotools built successfully (cmake -j6 distcheck), and
2. Cmake built successfully (cmake -j6 check).

I'll be careful to check autotools in the future, particularly when adding 
files.

Note that a few lines had line continution not lining up. I resolved those for 
consistency with the rest of the file.


Thanks,

Jeff Coffler

Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in stout/{posix|windows}.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/
---

Review request for mesos.


Repository: mesos


Description
---

Required since autotools includes .hpp files.


Diffs
-

  3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217 


Diff: https://reviews.apache.org/r/59297/diff/1/


Testing
---

This was an autotools-specific problem, I didn't catch this right away since my 
tests didn't build with autotools.

Now they do:

1. Autotools built successfully (cmake -j6 distcheck), and
2. Cmake built successfully (cmake -j6 check).

I'll be careful to check autotools in the future, particularly when adding 
files.

Note that a few lines had line continution not lining up. I resolved those for 
consistency with the rest of the file.


Thanks,

Jeff Coffler

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59194/#review175033
---


Ship it!




Ship It!

- Jiang Yan Xu


On May 15, 2017, 11:01 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59194/
> ---
> 
> (Updated May 15, 2017, 11:01 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7403
> https://issues.apache.org/jira/browse/MESOS-7403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensure that applying `DESTROY` operation removes this volume. This is
> needed to handle `DESTROY` of shared volumes to ensure that the
> resultant `Resources` object has this `Resource` removed (i.e. we
> allow this operation to succeed if the original `Resources` object
> only had a single copy of the shared resource).
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 
>   src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be 
>   src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 
> 
> 
> Diff: https://reviews.apache.org/r/59194/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 59279: Uses temp dir for docker and appc stores in test.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/#review175025
---


Fix it, then Ship it!





src/tests/mesos.cpp
Lines 180 (patched)


no need for `mesos` here in the middle.


- Jie Yu


On May 15, 2017, 6:02 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59279/
> ---
> 
> (Updated May 15, 2017, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7381
> https://issues.apache.org/jira/browse/MESOS-7381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain tests which relies on docker/appc stores to store images could be 
> flaky when certain changes to the store code is chaging.
> 
> This patch moves the usage of these flags to the temporary directory created 
> for each test case, so they do not affect each other.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6 
> 
> 
> Diff: https://reviews.apache.org/r/59279/diff/1/
> 
> 
> Testing
> ---
> 
> Ran through all tests.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 59294: Optionally scale egress bandwidth with CPU.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/
---

Review request for mesos, Dmitry Zhuk, Ilya Pronin, Jie Yu, and Santhosh Kumar 
Shanmugham.


Bugs: MESOS-7508
https://issues.apache.org/jira/browse/MESOS-7508


Repository: mesos


Description
---

Add support to isolators/port_mapping for optionally scaling egress bandwidth 
with CPU and with minimum and maximum limits.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
9d38289c7161d5e931053b587d115684ccc44c94 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
cd008aaebcd42554a9a81d2b059269546f59c966 
  src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd 
  src/slave/flags.cpp bc63a6a4cb6115b4b4d592e67e34045f52b50d4c 
  src/tests/containerizer/port_mapping_tests.cpp 
a528382e8b4831b9c7e8dcc877a5e242909f0cd5 


Diff: https://reviews.apache.org/r/59294/diff/1/


Testing
---

# added a new test 
$ make check


Thanks,

Ian Downes

Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/
---

Review request for mesos and Joseph Wu.


Repository: mesos


Description
---

Write using 'wb' instead of 'w' for binary mode. This writes the
downloaded patch file exactly as it came, instead of treating as text
and changing line endings. This resolves a bug where `git apply` doesn't
always work with CRLF endings in patch files.


Diffs
-

  support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850 


Diff: https://reviews.apache.org/r/59293/diff/1/


Testing
---

Applied patch 59177 successfully after failing to apply it without change due 
to:

```
59177.patch:9: trailing whitespace.

59177.patch:18: trailing whitespace.
def autocomplete(cmds, plugins, config, argv):
59177.patch:26: trailing whitespace.
current_word = argv[0]
59177.patch:27: trailing whitespace.
argv = argv[1:]
59177.patch:36: trailing whitespace.
return plugin_class(settings, config).__autocomplete_base__(
error: git apply: bad git-diff - expected /dev/null on line 167
```


Thanks,

Andrew Schwartzmeyer

Re: Review Request 58778: Supported GCE container registry.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175018
---



Patch looks great!

Reviews applied: [58778]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 15, 2017, 5:39 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> ---
> 
> (Updated May 15, 2017, 5:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
> https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 59286: Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59286/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.


Diffs
-

  CHANGELOG d95a5ceb817ff42c57f2b1978c39d6d03fe2f35c 


Diff: https://reviews.apache.org/r/59286/diff/1/


Testing
---

Visual inspection.


Thanks,

Neil Conway

Review Request 59285: Disabled support for hierarchical roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59285/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

The previous plan was to include support for hierarchical roles in Mesos
1.3.0 but to mark it as experimental. Upon reflection, it seems safer to
disable hierarchical roles in Mesos 1.3.0, and address the open issues
during the 1.4 development process.


Diffs
-

  src/common/roles.cpp 123e99073f8acbf4eb50e257e349e5485fba1cc6 
  src/tests/master_allocator_tests.cpp 3b072b251275e0cdfee3c40feebf78c6ad3a79d7 
  src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5 


Diff: https://reviews.apache.org/r/59285/diff/1/


Testing
---

`make check`


Thanks,

Neil Conway

Review Request 59279: Uses temp dir for docker and appc stores in test.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59279/
---

Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.


Bugs: MESOS-7381
https://issues.apache.org/jira/browse/MESOS-7381


Repository: mesos


Description
---

Certain tests which relies on docker/appc stores to store images could be flaky 
when certain changes to the store code is chaging.

This patch moves the usage of these flags to the temporary directory created 
for each test case, so they do not affect each other.


Diffs
-

  src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6 


Diff: https://reviews.apache.org/r/59279/diff/1/


Testing
---

Ran through all tests.


Thanks,

Zhitao Li

Re: Review Request 59195: Ensure that allocator can be updated before committing changes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59195/
---

(Updated May 15, 2017, 6:01 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
---

In addition to `apply()` on `offeredResources`, we ensure this operation
can be applied on `slave.allocated`. It is is so because certain
operations require that they are applicable to the agent's allocated
resources as a whole.
Note that we return a failed future on the first error (and there may
be other operations which might have failed). However, we do not
modify the state of the allocator if any of the operations fail.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7 
  src/master/allocator/mesos/allocator.hpp 
119b461136123229f85ed3c3cfd41137974a6b9b 
  src/master/allocator/mesos/hierarchical.hpp 
123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp 
b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
  src/tests/allocator.hpp 4ea722491f63f5ceda5a47228aafddc020f643b0 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 


Diff: https://reviews.apache.org/r/59195/diff/3/

Changes: https://reviews.apache.org/r/59195/diff/2-3/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

[Anindya Sinha]

> On May 15, 2017, 5:41 a.m., Jiang Yan Xu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2577 (patched)
> > 
> >
> > `__total`?

That is a left over from the original version. Fixed it.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59194/#review174924
---


On May 15, 2017, 6:01 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59194/
> ---
> 
> (Updated May 15, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7403
> https://issues.apache.org/jira/browse/MESOS-7403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensure that applying `DESTROY` operation removes this volume. This is
> needed to handle `DESTROY` of shared volumes to ensure that the
> resultant `Resources` object has this `Resource` removed (i.e. we
> allow this operation to succeed if the original `Resources` object
> only had a single copy of the shared resource).
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 
>   src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be 
>   src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 
> 
> 
> Diff: https://reviews.apache.org/r/59194/diff/3/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 58486: Update the allocator on a per offer operation.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
---

(Updated May 15, 2017, 6:01 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
---

The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:

1) Launch or Launch Group: We launch the tasks or task group on the
   agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
   the `CheckPointResourcesMessage` to the agent.

If allocation for any of the operations fail, those resources are not
recovered from the allocator.


Diffs (updated)
-

  src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
  src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 


Diff: https://reviews.apache.org/r/58486/diff/6/

Changes: https://reviews.apache.org/r/58486/diff/5-6/


Testing
---

Tests passed.


Thanks,

Anindya Sinha

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59194/
---

(Updated May 15, 2017, 6:01 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Addressed review comments.


Bugs: MESOS-7403
https://issues.apache.org/jira/browse/MESOS-7403


Repository: mesos


Description (updated)
---

Ensure that applying `DESTROY` operation removes this volume. This is
needed to handle `DESTROY` of shared volumes to ensure that the
resultant `Resources` object has this `Resource` removed (i.e. we
allow this operation to succeed if the original `Resources` object
only had a single copy of the shared resource).


Diffs (updated)
-

  src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 
  src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be 
  src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 


Diff: https://reviews.apache.org/r/59194/diff/3/

Changes: https://reviews.apache.org/r/59194/diff/2-3/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 58778: Supported GCE container registry.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/
---

(Updated May 15, 2017, 5:39 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Gilbert's comments.


Bugs: MESOS-7431
https://issues.apache.org/jira/browse/MESOS-7431


Repository: mesos


Description
---

Certain registries, such as GCE registry, reply 403 instead of 401 for
unauthorized requests. When fetching image manifests and blobs, instead
of sending out unauthorized requests first and waiting for a possible
401, we should always look up the docker config and send requests with
basic authorization when possible.


Diffs (updated)
-

  src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 


Diff: https://reviews.apache.org/r/58778/diff/4/

Changes: https://reviews.apache.org/r/58778/diff/3-4/


Testing
---

sudo make check (covers all supported public registries)
Manually tested on the following private registries:
1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
2. Amazon ECR
3. Google GCR
4. JFrog SaaS
5. Local Nexus registry 3.3.1


Thanks,

Chun-Hung Hsiao

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58673/#review174988
---


Fix it, then Ship it!




I can fix this up before committing.


3rdparty/stout/include/stout/flags/parse.hpp
Line 96 (original), 96 (patched)


Presumably a commit splitting mistake.



3rdparty/stout/tests/flags_tests.cpp
Line 983 (original), 983 (patched)


Presumably a commit splitting mistake.


- Joseph Wu


On May 2, 2017, 2:46 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58673/
> ---
> 
> (Updated May 2, 2017, 2:46 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 3rdparty/stout/tests/path_tests.cpp tests to Windows platform,
> but disabled tests that did not pass. Enabled absolute path tests,
> adding tests that were appropriate for the Windows platform.
> 
> Note that, for Windows, absolute paths may not be valid. For example,
> a path like "\\?\abc:file.txt" is not valid. In this case, the
> path::absolute method is undefined; the expectation is that it is
> called with valid paths (absolute or relative, but valid).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> 65edd86372596c2107e9f29cf27301e025e6620e 
>   3rdparty/stout/include/stout/path.hpp 
> 2d2088aadfa1ea82c59424242671c4fb655dede1 
>   3rdparty/stout/tests/CMakeLists.txt 
> 4bbe713f259e7858d423dcb33956d41e62a915eb 
>   3rdparty/stout/tests/flags_tests.cpp 
> e2681f8f68f6478d4c8a20c1e75ddb050d16b56d 
>   3rdparty/stout/tests/path_tests.cpp 
> 0490d93908566c46a10d91b05790e5a7f2f289bc 
> 
> 
> Diff: https://reviews.apache.org/r/58673/diff/5/
> 
> 
> Testing
> ---
> 
> Passes `make check` on the Linux platform.
> 
> On Windows, the FlagsFileTest.JSONFile now passes, along with new 
> PathTest.Absolute tests that I added due to new path::absolute handling on 
> the Windows platform.
> 
> PS C:\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe 
> --gtest_filter="*FlagsFileTest*"
> Note: Google Test filter = *FlagsFileTest*-
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from FlagsFileTest
> [ RUN  ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0425 10:05:20.959357 1060440 parse.hpp:97] Specifying an absolute filename 
> to read a command line option out of without using 'file:// is deprecated and 
> will be removed in a future release. Simply adding 'file://' to the beginning 
> of the path should eliminate this warning.
> [   OK ] FlagsFileTest.JSONFile (9 ms)
> [ RUN  ] FlagsFileTest.FilePrefix
> [   OK ] FlagsFileTest.FilePrefix (6 ms)
> [--] 2 tests from FlagsFileTest (18 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (23 ms total)
> [  PASSED  ] 2 tests.
> PS C:\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe 
> --gtest_filter="*PathTest*"
> Note: Google Test filter = *PathTest*-
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from PathTest
> [ RUN  ] PathTest.Absolute
> [   OK ] PathTest.Absolute (1 ms)
> [ RUN  ] PathTest.Comparison
> [   OK ] PathTest.Comparison (0 ms)
> [--] 2 tests from PathTest (2 ms total)
> 
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (6 ms total)
> [  PASSED  ] 2 tests.
> 
>   YOU HAVE 4 DISABLED TESTS
> 
> PS C:\mesos>
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/#review174990
---


Fix it, then Ship it!




I can fix this up before committing.


3rdparty/stout/include/stout/flags/parse.hpp
Lines 116-134 (original), 122-140 (patched)


This part for JSON::Arrays needs the same treatment.



3rdparty/stout/tests/flags_tests.cpp
Lines 1022 (patched)


`// __WINDOWS__`


- Joseph Wu


On May 2, 2017, noon, Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58889/
> ---
> 
> (Updated May 2, 2017, noon)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This code was deprecated for Linux, and thus makes no sense
> to port to Windows. This patch removes test from the Windows
> platform completely.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> 65edd86372596c2107e9f29cf27301e025e6620e 
>   3rdparty/stout/tests/flags_tests.cpp 
> e2681f8f68f6478d4c8a20c1e75ddb050d16b56d 
> 
> 
> Diff: https://reviews.apache.org/r/58889/diff/2/
> 
> 
> Testing
> ---
> 
> For Linux, all tests pass. In particular, with FlagsFileTest:
> 
> [--] 2 tests from FlagsFileTest
> [ RUN  ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to 
> read a command line option out of without using 'file:// is deprecated and 
> will be removed in a future release. Simply adding 'file://' to the beginning 
> of the path should eliminate this warning.
> [   OK ] FlagsFileTest.JSONFile (0 ms)
> [ RUN  ] FlagsFileTest.FilePrefix
> [   OK ] FlagsFileTest.FilePrefix (0 ms)
> [--] 2 tests from FlagsFileTest (0 ms total)
> 
> For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, 
> it's only appropriate for Linux. Thus, it's not run.
> 
> PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe 
> --gtest_filter="FlagsFile*"
> Note: Google Test filter = FlagsFile*-
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from FlagsFileTest
> [ RUN  ] FlagsFileTest.FilePrefix
> [   OK ] FlagsFileTest.FilePrefix (3 ms)
> [--] 1 test from FlagsFileTest (3 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (7 ms total)
> [  PASSED  ] 1 test.
> PS C:\mesos\mesos>
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174987
---


Ship it!




I can fixup the few comments before committing.


support/windows-build.bat
Line 21 (original), 21 (patched)


Not sure why, but MSVC 15 changed the path to this script.

It is now:
```
/path/to/Microsoft Visual 
Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat
```



support/windows-build.bat
Line 52 (original), 52 (patched)


As discussed offline, we'll make this default to MSVC 15 (2017).  Both the 
CIs have made the switch already.



support/windows-build.bat
Lines 87-89 (patched)


This part is not needed, as (currently) the `mesos-tests` target depends on 
all other targets being built first.


- Joseph Wu


On May 10, 2017, 1:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> ---
> 
> (Updated May 10, 2017, 1:40 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
> 
> Direct usage of `msbuild` was replaced with `cmake --build`.
> 
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
> 
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
> 
> 
> Diffs
> -
> 
>   support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7 
> 
> 
> Diff: https://reviews.apache.org/r/59116/diff/1/
> 
> 
> Testing
> ---
> 
> Built and tested script with clean build on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59157: Windows: Fixed toolset handling.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59157/#review174557
---


Fix it, then Ship it!




I'll delete the below before committing.


src/slave/cmake/AgentConfigure.cmake
Lines 48-50 (original), 48-50 (patched)


This block can simply be removed.


- Joseph Wu


On May 10, 2017, 1:37 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59157/
> ---
> 
> (Updated May 10, 2017, 1:37 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7498
> https://issues.apache.org/jira/browse/MESOS-7498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos must be built with the 64-bit tools. Previously, we added a
> dependency which checked if a certain environment variable was set. When
> it failed, the message would be a cryptic message:
> 
> error MSB6006: "cmd.exe" exited with code 255.
> 
> As the environment variable had to be picked up by every toolchain
> (Visual Studio Code, CMake, MSBuild, Visual Studio), it was a frequent
> cause of build frustrations.
> 
> This patch removes the `ENSURE_TOOL_ARCH` custom command, and instead
> asserts at configuration time that the toolset matches `host=x64`. With
> this toolset, CMake embeds the preferred tool architecture in the
> generated solutions, eliminating the need for an environment variable to
> be set, or for `/p:PreferredToolArchitecture=x64` to be passed to the
> build tool directly.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/slave/cmake/AgentConfigure.cmake 
> 2e7ae6eaf4212b728eccf0bee957bbf88ff8f3e3 
> 
> 
> Diff: https://reviews.apache.org/r/59157/diff/1/
> 
> 
> Testing
> ---
> 
> Clean build on Windows, with environment variable explicitly unset. Tested 
> with VS Code CMake extension, and with `cmake --build .` manually, and with 
> `msbuild` manually, and with Visual Studio manually.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59156/#review174986
---


Ship it!




Ship It!

- Joseph Wu


On May 10, 2017, 1:34 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59156/
> ---
> 
> (Updated May 10, 2017, 1:34 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7497
> https://issues.apache.org/jira/browse/MESOS-7497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This removes a CMake anti-pattern where `set` was used to append to a
> variable, instead of the more explicit `list(APPEND)` or
> `string(APPEND)` alternatives.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a 
> 
> 
> Diff: https://reviews.apache.org/r/59156/diff/1/
> 
> 
> Testing
> ---
> 
> Re-configured and built on Windows.
> 
> NOTE: This syntax should be preferred going forward. There are more instances 
> of the anti-pattern the setting of source files, but we'll take care of it in 
> a later patch to avoid too much churn.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59155/#review174985
---


Ship it!




Ship It!

- Joseph Wu


On May 10, 2017, 1:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59155/
> ---
> 
> (Updated May 10, 2017, 1:59 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7496
> https://issues.apache.org/jira/browse/MESOS-7496
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A previous commit attempted to enable this option, but it was not
> actually being used by the linker. This patch correctly adds the option
> to each linker flag variable for shared libraries, modules, and
> executables, and only for the debug configuration. This results in much
> faster link times.
> 
> Also, the `/zc:inline` option was removed, as it is only relevant in
> optimized builds (i.e. release configurations).
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a 
> 
> 
> Diff: https://reviews.apache.org/r/59155/diff/2/
> 
> 
> Testing
> ---
> 
> Built and tested on Windows with VS Code.
> 
> NOTE: With `/debug:fastlink` properly enabled, the current VS Code C++ 
> debugger does not work without a manual update. See [this 
> thread](https://github.com/Microsoft/vscode-cpptools/issues/695#issuecomment-299554289)
>  for the work-around.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 58778: Supported GCE container registry.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review174975
---



This patch looks good. Need to take aother look at the `fetchBlob()` logic once 
I wake up. Will make another pass. Thanks!


src/uri/fetchers/docker.cpp
Lines 653 (patched)


s/furute/futrue/g



src/uri/fetchers/docker.cpp
Lines 748 (patched)


Seems like a pre-request of calling `getAuthHeader()` is calling 
`getAuthHeaderBasic()` first. I am fine with this change (a hard dependency), 
but should we rename this variable (as well as the one in `_fetch()` to be 
`basicAuthHeaders`?

It might be less confusing since we have another `getAuthHeaders()` helper.


- Gilbert Song


On May 12, 2017, 5:45 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58778/
> ---
> 
> (Updated May 12, 2017, 5:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7431
> https://issues.apache.org/jira/browse/MESOS-7431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Certain registries, such as GCE registry, reply 403 instead of 401 for
> unauthorized requests. When fetching image manifests and blobs, instead
> of sending out unauthorized requests first and waiting for a possible
> 401, we should always look up the docker config and send requests with
> basic authorization when possible.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 
> 
> 
> Diff: https://reviews.apache.org/r/58778/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check (covers all supported public registries)
> Manually tested on the following private registries:
> 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1)
> 2. Amazon ECR
> 3. Google GCR
> 4. JFrog SaaS
> 5. Local Nexus registry 3.3.1
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 59001: Added volume secret isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59001/#review174945
---




src/slave/containerizer/mesos/isolators/volume/secret.hpp
Lines 50-52 (patched)


Ditto.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 101-106 (patched)


Ditto.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 126 (patched)


Should we return a `None()` here? Otherwise, a debug container may always 
get a failure from isolator::prepare since the `environment_secret` isolator is 
always enabled.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 289 (patched)


two more space.



src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 298 (patched)


Use `collect`?


- Gilbert Song


On May 12, 2017, 10:53 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59001/
> ---
> 
> (Updated May 12, 2017, 10:53 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added volume secret isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 97837c83cc223950750e4cd088f4da067023c96c 
>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 
>   src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59001/diff/8/
> 
> 
> Testing
> ---
> 
> Added new tests an ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 59000: Added environment secret isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/#review174942
---




src/slave/containerizer/mesos/isolators/environment_secret.hpp
Lines 43-45 (patched)


No need recover().



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 77-82 (patched)


Ditto.



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 98-101 (patched)


I would move this part above `secretResolver->resolve()`.



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 99-100 (patched)


Let's log the `Environment::Variable::name`.



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 103 (patched)


this is a bug? should check `variable.has_secret()` first?



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 137-138 (patched)


How about custom executor/default executor? `task_environment` is for 
command task specific.



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 50 (patched)


s/FetchSecret/ResolveSecret/g ?



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 86-91 (patched)


use the helper from test/mesos.hpp `createTask()`.



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 95-97 (patched)


Could we use of `strings::format()` to make this part more readable?



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 100-107 (patched)


Let's add a `TODO` here to refactor the helper  `createEnvironment()` to 
support value based/secret based env var respectively.


- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59000/
> ---
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added environment secret isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 97837c83cc223950750e4cd088f4da067023c96c 
>   src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59000/diff/6/
> 
> 
> Testing
> ---
> 
> Added a new test and ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59088/#review174943
---




src/master/quota.hpp
Lines 56 (patched)


So after looking more closely I realized that in no small part this is a 
copy paste of the other `QuotaTree`, is there a reason for that?

Likewise, I am not a big fan of using the word `Tree` in the name since it 
mixes intend with implementation details. If you really want to create a quota 
validator, then called that: `QuotaValidator` or `QuotaRegistry` or 
`QuotaBookeeper` all which reflect intent without telling you unecesary details 
about how the implementation works.


- Alexander Rojas


On May 9, 2017, 11:49 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59088/
> ---
> 
> (Updated May 9, 2017, 11:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-7402
> https://issues.apache.org/jira/browse/MESOS-7402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented QuotaTree structure to be used by allocator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/master/quota.hpp 479112d1a94ede34e2d46a27ff03999fc1634b8c 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/tests/quota_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59088/diff/1/
> 
> 
> Testing
> ---
> 
> see end of chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59088/#review174941
---




src/master/quota.hpp
Lines 56 (patched)


why do we need a new class called `QuotaTree` when we have already one in 
`quota_handler.cpp`?

Why not fixing stuff there instead than here?


- Alexander Rojas


On May 9, 2017, 11:49 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59088/
> ---
> 
> (Updated May 9, 2017, 11:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-7402
> https://issues.apache.org/jira/browse/MESOS-7402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented QuotaTree structure to be used by allocator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/master/quota.hpp 479112d1a94ede34e2d46a27ff03999fc1634b8c 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/tests/quota_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59088/diff/1/
> 
> 
> Testing
> ---
> 
> see end of chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
---

(Updated May 15, 2017, 2:05 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
---

Fixed CMake.


Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
---

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs (updated)
-

  3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483 
  3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e 
  3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e 
  3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 
  3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION 
  3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd 
  configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/tests/cmake/MesosTestsConfigure.cmake 
62e274114e7ab062e037ef194781828146e15fed 
  src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 
  src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db 
  src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11 


Diff: https://reviews.apache.org/r/58349/diff/4/

Changes: https://reviews.apache.org/r/58349/diff/3-4/


Testing
---

Tested in https://reviews.apache.org/r/58351/

Don't commit without 58350 and 58351.


Thanks,

Jan Schlicht

Re: Review Request 58999: Added --secret_resolver flag to agent.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/#review174918
---




src/slave/flags.cpp
Lines 961-964 (patched)


Should we consider make the `default secret resolver` as the default value 
for this flag? So that we can get rid of the logic in 
`SecretResolver::create()`.



src/slave/flags.cpp
Lines 963 (patched)


s/secret resolve module/secret resolver module/g ?


- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58999/
> ---
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Containerizer to accept SecretResolver.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 
>   src/slave/containerizer/containerizer.hpp 
> 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
>   src/slave/containerizer/containerizer.cpp 
> 9024371b6c4228f0903cfeef3bbec736e1a425f8 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 04ab997454534b8e5e821b53b83e166e5018e11c 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 97837c83cc223950750e4cd088f4da067023c96c 
>   src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd 
>   src/slave/flags.cpp bc63a6a4cb6115b4b4d592e67e34045f52b50d4c 
>   src/slave/main.cpp 507d59996a90f51c7cd1e0f836a34c2e9c484791 
> 
> 
> Diff: https://reviews.apache.org/r/58999/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58350: Updated GMock/GTest in stout.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58350/
---

(Updated May 15, 2017, 12:28 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
---

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs (updated)
-

  3rdparty/stout/3rdparty/Makefile.am 73f6e058eff6ed8b08d119fcb61bc28c8d30c346 
  3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da 
  3rdparty/stout/cmake/StoutTestsConfigure.cmake 
685f1c840e1bdad0dcc4c6b0629a944cffbb309f 
  3rdparty/stout/configure.ac 50c1f6f0b1935a3770724c10f651190dcf002633 


Diff: https://reviews.apache.org/r/58350/diff/2/

Changes: https://reviews.apache.org/r/58350/diff/1-2/


Testing (updated)
---

Tested in https://reviews.apache.org/r/58351/

Don't commit without 58351.


Thanks,

Jan Schlicht

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
---

(Updated May 15, 2017, 12:28 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
---

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs
-

  3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483 
  3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e 
  3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e 
  3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 
  3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION 
  3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd 
  configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/tests/cmake/MesosTestsConfigure.cmake 
62e274114e7ab062e037ef194781828146e15fed 
  src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 
  src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db 
  src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11 


Diff: https://reviews.apache.org/r/58349/diff/3/


Testing (updated)
---

Tested in https://reviews.apache.org/r/58351/

Don't commit without 58350 and 58351.


Thanks,

Jan Schlicht

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
---

(Updated May 15, 2017, 12:27 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
---

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs (updated)
-

  3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483 
  3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e 
  3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e 
  3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 
  3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION 
  3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd 
  configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/tests/cmake/MesosTestsConfigure.cmake 
62e274114e7ab062e037ef194781828146e15fed 
  src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
  src/tests/hierarchical_allocator_tests.cpp 
08180b9975869de328f0c095dd3cddf0c84fbecf 
  src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db 
  src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11 


Diff: https://reviews.apache.org/r/58349/diff/3/

Changes: https://reviews.apache.org/r/58349/diff/2-3/


Testing (updated)
---

make check (on macOS, Linux, Windows)

Don't commit without 58350 and 58351.


Thanks,

Jan Schlicht

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
---

(Updated May 15, 2017, 12:25 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
---

Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.


Diffs
-

  3rdparty/libprocess/src/tests/future_tests.cpp 
f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 
302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 
b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/main.cpp 
23eead809d1f0ddc9a28f492005ff325701bac59 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp 
bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 
30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/3/


Testing (updated)
---

tested in https://reviews.apache.org/r/58348/, don't commit without commiting 
58348.


Thanks,

Jan Schlicht

Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/
---

(Updated May 15, 2017, 12:24 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
---

Rebased.


Summary (updated)
-

Fixed use of 'GTEST_IS_THREADSAFE'.


Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description (updated)
---

Fixed use of 'GTEST_IS_THREADSAFE'.


Diffs (updated)
-

  src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d 
  src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 


Diff: https://reviews.apache.org/r/58348/diff/3/

Changes: https://reviews.apache.org/r/58348/diff/2-3/


Testing (updated)
---

make check (using automake and CMake with macOS, Linux and Windows)


Thanks,

Jan Schlicht

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
---

(Updated May 15, 2017, 12:24 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
---

Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/future_tests.cpp 
f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 
302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 
b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/main.cpp 
23eead809d1f0ddc9a28f492005ff325701bac59 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp 
bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 
30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/3/

Changes: https://reviews.apache.org/r/58347/diff/2-3/


Testing (updated)
---

tested in https://reviews.apache.org/r/58348/


Thanks,

Jan Schlicht