Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 八月 11, 2016, 9:58 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

address greg's comments


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up SlaveRecoveryTest.*, and leave a comment on test cases that relies on 
MESOS-4111 to speed up.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 59859f5bc249fbef916d6dfeafdc396a4c037117 

Diff: https://reviews.apache.org/r/41787/diff/


Testing (updated)
---

Previous
SlaveRecoveryTest/0.RecoverStatusUpdateManager (2237 ms)
SlaveRecoveryTest/0.ReconnectExecutor (2244 ms)
SlaveRecoveryTest/0.ReconcileKillTask (3067 ms)
SlaveRecoveryTest/0.ReconcileShutdownFramework (3287 ms)

Current
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms)
SlaveRecoveryTest/0.ReconnectExecutor (308 ms)
SlaveRecoveryTest/0.ReconcileKillTask (374 ms)
SlaveRecoveryTest/0.ReconcileShutdownFramework (244 ms)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 11, 2016, 1:33 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock,
while some relies on the fix of MESOS-4111 and a comment is put.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 9, 2016, 3:42 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Summary (updated)
-

Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 四月 9, 2016, 3:39 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

rebase


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up Speed up SlaveRecoveryTest.*.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 396
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line396>
> >
> > Is there a need to explicitly invoke `Clock::resume()` here? If not, 
> > kill it.
> 
> Alexander Rukletsov wrote:
> Let's leave the test with resumed clock for consistency.
> 
> Anand Mazumdar wrote:
> Alex, what consistency are you referring to here? Does this file follow 
> the pattern of explicitly doing so?
> 
> Alexander Rukletsov wrote:
> We've discussed it with BenM here recently: 
> https://reviews.apache.org/r/44994/#comment186808
> 
> Anand Mazumdar wrote:
> Don't we explicitly resume the clock at the end of the test if an 
> assertion fails making the `resume` call redundant? 
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/gtest.hpp#L47
> 
> Looks like I am missing something here.

Change the test here to explicitly destroy container instead of waiting for 
timeout.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---


On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 四月 9, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 四月 8, 2016, 2:52 p.m., Alexander Rukletsov wrote:
> > src/tests/hook_tests.cpp, line 392
> > <https://reviews.apache.org/r/42241/diff/5/?file=1258988#file1258988line392>
> >
> > we don't need `settle` here because AWAIT_READY does it for us. 
> > However, we should resume the clock since in the future we may have a check 
> > that the clock is unpaused when test finishes.

Since we explicitly destroy the container, there is no need to pause/resume 
clock here.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review127792
-------


On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 四月 9, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 四月 9, 2016, 2:45 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

Address alex's comments.


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 四月 9, 2016, 7:14 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

rebase


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 28, 2016, 1:11 p.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 28, 2016, 1:30 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

Fix michale's comment


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

> On 三月 24, 2016, 7:57 p.m., Greg Mann wrote:
> > src/cli/execute.cpp, line 215
> > <https://reviews.apache.org/r/43935/diff/3/?file=1309822#file1309822line215>
> >
> > s/sepcified/specified/

Sorry for the typo... please review again.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review125329
---


On 三月 25, 2016, 1:54 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> ---
> 
> (Updated 三月 25, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
> 
> 
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow setting role in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/43935/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
> 
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
> --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
> 
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --resources="cpus:1;mem:512"
> 
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test" --resources="cpus:2;mem:512"
> 
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test1" --resources="cpus:2;mem:512"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 25, 2016, 1:54 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

Fix a typo in the comment.


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 22, 2016, 2:57 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

address greg's comment


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 17, 2016, 1:39 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing (updated)
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 44421: Added support for "overlay" keyword.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review124140
---




src/linux/fs.cpp (line 74)
<https://reviews.apache.org/r/44421/#comment186528>

This line seems redundant.


- Jian Qiu


On 三月 11, 2016, 11:58 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> ---
> 
> (Updated 三月 11, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
> https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh 
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 15, 2016, 2:07 p.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

> On 三月 15, 2016, 12:26 p.m., Guangya Liu wrote:
> > src/cli/execute.cpp, lines 216-222
> > <https://reviews.apache.org/r/43935/diff/1/?file=1299410#file1299410line216>
> >
> > Do you mean that here the framework task can only use reserved 
> > resources if the framework has a role? What about regular resources?
> > 
> > What about adding some logic as this:
> > 1) First use reserved resources for a role
> > 2) If no reserved resources, use regular resources?

resources.find() actually find the resources in the target role, then 
unreserved resources.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/#review123644
-------


On 三月 15, 2016, 2:07 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43935/
> ---
> 
> (Updated 三月 15, 2016, 2:07 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.
> 
> 
> Bugs: MESOS-4744
> https://issues.apache.org/jira/browse/MESOS-4744
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow setting role in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/43935/diff/
> 
> 
> Testing
> ---
> 
> start master.
> ./bin/mesos-master.sh --work_dir=/tmp/mesos
> 
> start slave.
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
> --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"
> 
> running mesos-execute without specifying role succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --resources="cpus:1;mem:512"
> 
> running mesos-execute with role test succeeds.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test" --resources="cpus:2;mem:512"
> 
> running mesos-execute with role test1 fails.
> ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
> 10" --role="test1" --resources="cpus:2;mem:512"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120664
---


Ship it!




Ship It!

- Jian Qiu


On 二月 25, 2016, 5:59 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated 二月 25, 2016, 5:59 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120648
---




src/tests/containerizer/isolator_tests.cpp (line 819)
<https://reviews.apache.org/r/43961/#comment182108>

LGTM, Could you help changing the comment here?


- Jian Qiu


On 二月 24, 2016, 9:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated 二月 24, 2016, 9:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 390
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line390>
> >
> > hmm ... Can't we just do:
> > 
> > ```
> > Clock::pause();
> > Clock::advance(...);
> > Clock::settle();
> > ```
> 
> Jian Qiu wrote:
> Thanks for reviewing! This settle() is necessary to trigger the 
> shutdownExecutor timer.
> 
> Anand Mazumdar wrote:
> Ahh, I see. It's not immediatly obvious to to why we need the first 
> `Clock::settle`. As a suggestion, can we add a comment like this:
> 
> ```
> Clock::settle(); // Wait for `Slave::shutdownExecutor` to complete.
> ```

Done :)


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---


On 二月 19, 2016, 4:36 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 二月 19, 2016, 4:36 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 390
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line390>
> >
> > hmm ... Can't we just do:
> > 
> > ```
> > Clock::pause();
> > Clock::advance(...);
> > Clock::settle();
> > ```

Thanks for reviewing! This settle() is necessary to trigger the 
shutdownExecutor timer.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
-------


On 二月 19, 2016, 3:29 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 二月 19, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 二月 19, 2016, 3:29 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

address @anandmazumdar comments


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119584
---




src/launcher/http_executor.cpp (line 118)
<https://reviews.apache.org/r/43701/#comment180939>

this method and other methods not implementation of the virtual method 
should be private



src/launcher/http_executor.cpp (line 202)
<https://reviews.apache.org/r/43701/#comment180940>

should this block be put in a separate function?


- Jian Qiu


On 二月 18, 2016, 1:09 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated 二月 18, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119276
---




src/docker/executor.cpp (line 203)
<https://reviews.apache.org/r/43489/#comment180588>

the state should be TASK_KILLING?


- Jian Qiu


On 二月 16, 2016, 8:28 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated 二月 16, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/#review119273
---




src/master/master.cpp (line 5281)
<https://reviews.apache.org/r/43041/#comment180585>

How about

if (revocableResource != offered) {
  Offer offer = createOffer(framework, slave, offered - revocableResource)
  ...
}

if (!revocableResource.empty()) {
  Offer offer = createOffer(framework, slave, revocableResource)
}


- Jian Qiu


On 二月 16, 2016, 8:21 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43041/
> ---
> 
> (Updated 二月 16, 2016, 8:21 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
> https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Master to send revocable resources in separate offers.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43041/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check
>  
> Test: https://reviews.apache.org/r/43593/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 二月 4, 2016, 6:32 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Summary (updated)
-

Speed up Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up Speed up SlaveRecoveryTest.*.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 二月 4, 2016, 6:32 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review117766
---


Ship it!




Ship It!

- Jian Qiu


On 一月 22, 2016, 4:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> ---
> 
> (Updated 一月 22, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Create a test macro to advance `Clock` for `Future`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 049152c0535c78e6986346610735d301fb6876bc 
> 
> Diff: https://reviews.apache.org/r/42440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 42792: Fix compile error in container logger tests.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/
---

Review request for mesos and Joseph Wu.


Bugs: MESOS-4508
https://issues.apache.org/jira/browse/MESOS-4508


Repository: mesos


Description
---

Use unsigned value when comparing with kilobytes.


Diffs
-

  src/tests/container_logger_tests.cpp ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 

Diff: https://reviews.apache.org/r/42792/diff/


Testing
---

make check on OSX and Ubuntu 15.04


Thanks,

Jian Qiu

Re: Review Request 42792: Fix compile error in container logger tests.

[Jian Qiu]

> On 一月 26, 2016, 7:33 p.m., Joseph Wu wrote:
> > Sorry about that.  Till already committed an identical patch.  
> > https://reviews.apache.org/r/42803/

Thanks for doing this. There is also a race in DefaultToSandbox when it runs on 
ubuntu. Sometimes it cannot read string from stdout. We may need to wait until 
task finished. Mind taking a look at it?


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116427
---


On 一月 26, 2016, 8:12 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated 一月 26, 2016, 8:12 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review115842
---



3rdparty/libprocess/include/process/gtest.hpp (line 63)
<https://reviews.apache.org/r/42440/#comment176906>

Maybe change this to advanceInterval?



3rdparty/libprocess/include/process/gtest.hpp (line 65)
<https://reviews.apache.org/r/42440/#comment176905>

If the clock is paused outside, there is no need to pause here


- Jian Qiu


On 一月 17, 2016, 4:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> ---
> 
> (Updated 一月 17, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Create a test macro to advance `Clock` for `Future`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 049152c0535c78e6986346610735d301fb6876bc 
> 
> Diff: https://reviews.apache.org/r/42440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 一月 18, 2016, 4:03 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 一月 18, 2016, 11:49 a.m., Alexander Rukletsov wrote:
> > src/tests/hook_tests.cpp, lines 396-399
> > <https://reviews.apache.org/r/42241/diff/2/?file=1199560#file1199560line396>
> >
> > Why do you need a loop here? Isn't it enought to advance once and then 
> > settle?

Right...there is no need to loop. Thanks for reminding!


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review114994
-------


On 一月 18, 2016, 4:03 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 一月 18, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote:
> > src/tests/hook_tests.cpp, line 389
> > <https://reviews.apache.org/r/42241/diff/1/?file=1195246#file1195246line389>
> >
> > If hookFuture never becomes ready that this blocks forever right?
> > AWAIT_READY has a timeout built in, and we will want to also make sure 
> > we don't hang forever.
> > Also do we have a logically expected time the hook future should be 
> > ready? Can we just advance once and then AWAIT?
> 
> Jian Qiu wrote:
> Thanks, @tnachen. the while loop here is to wait for the executor being 
> terminated. Instead of checking hookFuture in while loop, how about exepect a 
> call to executorTerminated, and check whether it is called in while loop?

After rechecking the test case, you are right that we should not use a loop 
here.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review114762
-------


On 一月 18, 2016, 4:03 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 一月 18, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote:
> > src/tests/hook_tests.cpp, line 389
> > <https://reviews.apache.org/r/42241/diff/1/?file=1195246#file1195246line389>
> >
> > If hookFuture never becomes ready that this blocks forever right?
> > AWAIT_READY has a timeout built in, and we will want to also make sure 
> > we don't hang forever.
> > Also do we have a logically expected time the hook future should be 
> > ready? Can we just advance once and then AWAIT?

Thanks, @tnachen. the while loop here is to wait for the executor being 
terminated. Instead of checking hookFuture in while loop, how about exepect a 
call to executorTerminated, and check whether it is called in while loop?


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review114762
-------


On 一月 18, 2016, 2:28 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 一月 18, 2016, 2:28 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 一月 18, 2016, 2:28 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description (updated)
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated Jan. 15, 2016, 6:20 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

Looks like this review depends on an unpublished review. Fixed it to unblock 
the Review Bot. -- @vinodkone


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Add Clock::advance to fasten the speed of executor to be shutdown.


Diffs
-

  src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Add Clock::advance to fasten the speed of executor to be shutdown.


Diffs
-

  src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/#review113709
---



src/tests/oversubscription_tests.cpp (line 1301)
<https://reviews.apache.org/r/42130/#comment174515>

Is this necessary?



src/tests/oversubscription_tests.cpp (line 1365)
<https://reviews.apache.org/r/42130/#comment174516>

sleep 1000 shoule be enough?



src/tests/oversubscription_tests.cpp (line 1374)
<https://reviews.apache.org/r/42130/#comment174519>

Do you need this? it needs an estimator, but it seems that you have not 
started slave with an estimator. And I don't think estimator is necessary in 
this test?


- Jian Qiu


On 一月 11, 2016, 7:52 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42130/
> ---
> 
> (Updated 一月 11, 2016, 7:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jian Qiu.
> 
> 
> Bugs: MESOS-3897
> https://issues.apache.org/jira/browse/MESOS-3897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `ALLOCATION_SLACK` helper functions.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
> 
> Diff: https://reviews.apache.org/r/42130/diff/
> 
> 
> Testing
> ---
> 
> make
> make check GTEST_FILTER="OversubscriptionTest.GetAllocationSlackHelpers"
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41857: Got evictable executors.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review113430
---



src/slave/slave.cpp (line 3963)
<https://reviews.apache.org/r/41857/#comment174066>

s/pinding/pending



src/slave/slave.cpp (line 3967)
<https://reviews.apache.org/r/41857/#comment174067>

this check may not be necessary because resources cannot be negative?



src/slave/slave.cpp (line 3985)
<https://reviews.apache.org/r/41857/#comment174079>

I am not sure whether this situation will happen, because it means a task 
using allocation slack and is waiting for evicting executor. Master should not 
allowed such task to be launched beacause there not enough available allocation 
slack resources for this task


- Jian Qiu


On 一月 8, 2016, 6:54 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> ---
> 
> (Updated 一月 8, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris 
> Van Remoortere, Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> get evictable executors
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/41857/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41859: Launch tasks after evicting executors.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/#review113440
---



src/slave/slave.cpp (line 1449)
<https://reviews.apache.org/r/41859/#comment174089>

If an evictable executor is in terminating state because of task finished, 
it cannot be moved out of evictableExecutors here.


- Jian Qiu


On 一月 8, 2016, 6:55 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41859/
> ---
> 
> (Updated 一月 8, 2016, 6:55 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris 
> Van Remoortere, Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> launch tasks after evicting executors
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/41859/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

(Updated 一月 7, 2016, 1:41 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

Since the reason for the test case being slow is MESOS-4111, we will add 
comment in the test case, and remove it when MESOS-4111 is fixed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---


Thanks,

Jian Qiu

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

(Updated 一月 8, 2016, 2:13 a.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Speed up SlaveTest.CommandExecutorWithOverride.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

Since the reason for the test case being slow is MESOS-4111, we will add 
comment in the test case, and remove it when MESOS-4111 is fixed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---


Thanks,

Jian Qiu

Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review113387
---



src/slave/slave.cpp (line 3872)
<https://reviews.apache.org/r/41856/#comment173994>

s/staeless/stateless


- Jian Qiu


On 一月 7, 2016, 1:09 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41856/
> ---
> 
> (Updated 一月 7, 2016, 1:09 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Helper functions to get allocation slack
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/41856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41848: Do not enable task and executor run on different resources.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113389
---


maybe should also add a test case with mix of usage slack and allocation slack?

- Jian Qiu


On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> ---
> 
> (Updated 一月 7, 2016, 11:26 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3931
> https://issues.apache.org/jira/browse/MESOS-3931
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
>   src/tests/master_validation_tests.cpp 
> fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/41848/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41858: Added helper functions to kill executor.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
---



src/slave/slave.cpp (line 4886)
<https://reviews.apache.org/r/41858/#comment174062>

Should this be used also by qos_correction?


- Jian Qiu


On 一月 8, 2016, 7:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> ---
> 
> (Updated 一月 8, 2016, 7:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris 
> Van Remoortere, Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> kill executors helper
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/41858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 7:43 a.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 1:44 a.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Speed up Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs (updated)
-

  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/home.md bc22d3126f49e0213e6bb3a0e23e156cd2b247f1 
  docs/mesos-provisioner.md 06094f572a7917ddd1f7d73a6d855a9c9932cbab 
  include/mesos/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d 
  include/mesos/docker/v1.proto  
  include/mesos/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f 
  include/mesos/docker/v2.proto e2c0a131b8429ca086bc5cd09dccfe3e8d2e50ac 
  include/mesos/executor/executor.proto 
cc6b4f67da62dacf2fc649f00ba15a3fba98910b 
  include/mesos/v1/executor/executor.proto 
4ecdaa0a468da1b271aa382a945d7e2a59c32449 
  include/mesos/v1/scheduler.hpp fc8ae50fa1a27ce1c52b2b51de54d2c54551f85e 
  src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d 
  src/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f 
  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/scheduler/scheduler.cpp a17872b46ec600e0fae6c43247ccb63f5ee55ac0 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
7f441de097719114f81716caade44388720273f6 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
6ae920a820a7604c97debf9fd21de24dda8e4d36 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
5650f2f51c0ea31527c6c51eb498d87ddf2a4fec 
  src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
  src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d6a06057c7600aeb1aca76d4dfadc45b6eae99d 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/master_maintenance_tests.cpp 
2da6a2d4b786d9c5f64be8b5ab95f70ef3d98f92 
  src/tests/mesos.hpp 49a4c48e6887e6f0921d96c359746e39be10e222 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/persistent_volume_endpoints_tests.cpp 
f0cce190abc90f0fae84d6c3db20e8215c2d8132 
  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
  src/webui/master/static/framework.html 
9b28820dc93de1f66942b9b1f62a3288ee7609ac 
  src/webui/master/static/frameworks.html 
15ff1e9cb6c70df8df47a1b939681abde591e010 
  src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1 
  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 
  src/webui/master/static/js/dashboard.js 
d6cbb3cc5aa92249c4b17c6d77260b215203d008 
  src/webui/master/static/js/services.js 
fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
  src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9 
  src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 
  src/webui/master/static/slave_executor.html 
9d582d54ce97f1b395f60acb28df95e4f9a48b3b 
  src/webui/master/static/slave_framework.html 
96d788f04235b8e3881308818acba8f22d08e2ec 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 1:48 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Review Request 41787: Speed up Speed up SlaveRecoveryTest.*

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review112368
---



src/master/master.cpp (line 1445)
<https://reviews.apache.org/r/41681/#comment172839>

one line?



src/master/master.cpp (line 1467)
<https://reviews.apache.org/r/41681/#comment172852>

If there is a weight from --weight, and it is also in registry, the 
updateWeightinfos will have two weighinfo for the same role.



src/master/weights_handler.cpp (line 92)
<https://reviews.apache.org/r/41681/#comment172858>

<= 0



src/master/weights_handler.cpp (line 101)
<https://reviews.apache.org/r/41681/#comment172864>

    s/existed/exist


- Jian Qiu


On 十二月 30, 2015, 11:54 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated 十二月 30, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
>   include/mesos/authorizer/authorizer.proto 
> 7b729e19484d92be48bbde4dff2c833a4109936e 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/authorizer/local/authorizer.hpp 
> 1563c11709c2612350354690b50ceb33d2720f98 
>   src/authorizer/local/authorizer.cpp 
> 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
> >> /tmp/mesos-master.log 2>&1 &)
> $ curl -d 
> weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
>  -X PUT http://localhost:5050/weights
> $ curl http://localhost:5050/roles
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 8
> }
> ]
> }
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41789: Add put method for http PUT request.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112293
---


May need to refer to https://issues.apache.org/jira/browse/MESOS-3763

- Jian Qiu


On 十二月 30, 2015, 8:08 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated 十二月 30, 2015, 8:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

(Updated 十二月 30, 2015, 2:02 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

rebase


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

Since the reason for the test case being slow is MESOS-4111, we will add 
comment in the test case, and remove it when MESOS-4111 is fixed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 68d75176ce7cccafdf870fff48ac6a11089311ef 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---


Thanks,

Jian Qiu

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

[Jian Qiu]

> On 十二月 28, 2015, 11:15 a.m., Alexander Rukletsov wrote:
> > src/tests/slave_tests.cpp, line 435
> > <https://reviews.apache.org/r/41600/diff/1/?file=1175197#file1175197line435>
> >
> > Mind explaining why do you think explicitly killing the executor is the 
> > right solution here? I would even propose to do it in MESOS-4161 directly 
> > for posterity.
> > 
> > To clarify some approaches here for posterity (I will be glad to 
> > continue the conversation in the JIRA ticket once you post your explanation 
> > there). There are two separate techniques used in this review request: 
> > explicit process kill and `Clock::advance()`. Though the latter may indeed 
> > slightly speed up the test, it's not longer necessary since 
> > `process::reap()` has been accelerated (see MESOS-1199). I would let @Jian 
> > Qiu comment on the former approach.

Let's add a comment instead of explicitly killing the executor


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/#review111967
-------


On 十二月 30, 2015, 2:02 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41600/
> ---
> 
> (Updated 十二月 30, 2015, 2:02 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4161
> https://issues.apache.org/jira/browse/MESOS-4161
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the reason for the test case being slow is MESOS-4111, we will add 
> comment in the test case, and remove it when MESOS-4111 is fixed.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 68d75176ce7cccafdf870fff48ac6a11089311ef 
> 
> Diff: https://reviews.apache.org/r/41600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41675/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4163
https://issues.apache.org/jira/browse/MESOS-4163


Repository: mesos


Description
---

We should advance a reregister timeout to speed up the slave registration.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41675/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.HTTPSchedulerSlaveRestart

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.HTTPSchedulerSlaveRestart
I1229 09:38:10.183754 2138071808 exec.cpp:134] Version: 0.27.0
I1229 09:38:10.188813 328146944 exec.cpp:208] Executor registered on slave 
97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
Registered executor on 9.110.49.60
Starting task 4f4f7ebe-625c-42eb-aaa8-d569333751e8
sh -c 'sleep 1000'
Forked command at 31243
I1229 09:38:10.212271 329220096 exec.cpp:254] Received reconnect request from 
slave 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
I1229 09:38:10.212829 327610368 exec.cpp:231] Executor re-registered on slave 
97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
Re-registered executor on 9.110.49.60
[   OK ] SlaveTest.HTTPSchedulerSlaveRestart (417 ms)
[--] 1 test from SlaveTest (417 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (426 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu

Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

To speed up SlaveTest.CommandExecutorWithOverride, we need to explicitly kill 
the executor process and advance reap interval.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.CommandExecutorWithOverride takes 415ms

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.CommandExecutorWithOverride
[   OK ] SlaveTest.CommandExecutorWithOverride (405 ms)
[--] 1 test from SlaveTest (405 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (415 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

(Updated 十二月 23, 2015, 6:43 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

To speed up SlaveTest.CommandExecutorWithOverride, we need to explicitly kill 
the executor process and advance reap interval.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.CommandExecutorWithOverride takes 415ms

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.CommandExecutorWithOverride
[   OK ] SlaveTest.CommandExecutorWithOverride (405 ms)
[--] 1 test from SlaveTest (405 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (415 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41337/#review110878
---



src/slave/slave.hpp (line 593)
<https://reviews.apache.org/r/41337/#comment170895>

How about using tuple queue<std::tuple<TaskInfo, FrameworkInfo>> 
pendingTasks?


- Jian Qiu


On 十二月 17, 2015, 2:49 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41337/
> ---
> 
> (Updated 十二月 17, 2015, 2:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4148
> https://issues.apache.org/jira/browse/MESOS-4148
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set task as TASK_LOST if not enough allocation slack resources.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41337/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

[Jian Qiu]

> On Dec. 14, 2015, 2:14 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 431
> > 
> >
> > Honestly, I'd like to separate optimistic resources into other counter 
> > in allocator; it's a litte different with oversubscription: here, one 
> > reserved resources are counting twice in total.
> 
> Guangya Liu wrote:
> The allocation slack was decreased in 1304-1329

Just wondering the reason to set resources in allocaction slack when add/update 
slave. It seems to me that you just need to calculate available resources in 
allocate() and add allocation slack to the available there?


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/#review110154
---


On Dec. 13, 2015, 11:35 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40632/
> ---
> 
> (Updated Dec. 13, 2015, 11:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Enabled oversubscribed resources for reservations in allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
> 
> Diff: https://reviews.apache.org/r/40632/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41333: Added helper functions to filter usage slack resources.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/#review110171
---



src/v1/resources.cpp (line 696)
<https://reviews.apache.org/r/41333/#comment169943>

two lines


- Jian Qiu


On Dec. 14, 2015, 5:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41333/
> ---
> 
> (Updated Dec. 14, 2015, 5:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to filter usage slack resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 
>   src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399 
>   src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717 
> 
> Diff: https://reviews.apache.org/r/41333/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic weight

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109938
---



include/mesos/role/role.hpp (line 24)
<https://reviews.apache.org/r/40469/#comment169655>

namespace mesos?


- Jian Qiu


On Dec. 11, 2015, 9 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Dec. 11, 2015, 9 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Neil Conway, Qian Zhang, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, RoleInfo protobuf never be used for serialization, so I think we 
> can remove it from allocator.proto, and define a struct to communicate 
> between the allocator and master. But for role information display, then 
> current serialization way(call modle(role*) in http.cpp) is not better, and 
> we should define another RoleInfo protobuf for serialization. Refer to other 
> components(such as quota), I propose to define role protobuf in a separated 
> package rather than define it in mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   include/mesos/master/allocator.proto 
> 702f56f56c3b1331613cecf26522986f6b572f8c 
>   include/mesos/role/role.hpp PRE-CREATION 
>   include/mesos/role/role.proto PRE-CREATION 
>   src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/master/allocator/mesos/allocator.hpp 
> 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 
> 99c742906874c30c39c159e58a65277ade3c07fd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 
> 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
>   src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
>   src/tests/hierarchical_allocator_tests.cpp 
> e239b4746494fcc2b362a83afb634a2ce5e25f9b 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make successfully.
> Make check successfully.
> Run test framework successfully
> 
> TODO: will add a test for role update.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

[Jian Qiu]

> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote:
> > src/master/http.cpp, line 331
> > <https://reviews.apache.org/r/40224/diff/1/?file=1123992#file1123992line331>
> >
> > Seems miss credentials, whitelist

These two flags returns as Path instead of protobuf.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/#review107604
---


On Nov. 23, 2015, 5:56 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40224/
> ---
> 
> (Updated Nov. 23, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-3792
> https://issues.apache.org/jira/browse/MESOS-3792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix wrong flags infos in /state and /flags. We should convert protobuf type 
> flag to JSON object explicitly instead of relying on stringify
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
> 
> Diff: https://reviews.apache.org/r/40224/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> ./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
> [{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
> [{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
> }}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
> },"framework_principals": { "values": ["c"] }}]}'
> 
> curl http://master:5050/state
> curl http://master:5050/flag
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/
---

(Updated Dec. 9, 2015, 2:20 a.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Bugs: MESOS-3792
https://issues.apache.org/jira/browse/MESOS-3792


Repository: mesos


Description
---

Fix wrong flags infos in /state and /flags. We should convert protobuf type 
flag to JSON object explicitly instead of relying on stringify


Diffs (updated)
-

  src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 
  src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 

Diff: https://reviews.apache.org/r/40224/diff/


Testing
---

make & make check

./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
[{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
[{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
}}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
},"framework_principals": { "values": ["c"] }}]}'

curl http://master:5050/state
curl http://master:5050/flag


Thanks,

Jian Qiu

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

[Jian Qiu]

> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote:
> > I think keep the sync of these files when flags add or delete Protobuf 
> > fields a bit hard. Is it possible to change flags stringify protobuf 
> > objects as json string

Thanks hasdent. I do not think we can overload or have a specialized stringify 
for google::protobuf::Message since it is an abstract class. How about 
rewriting the operator<< overload for each protobuf flag? We can change 
https://github.com/apache/mesos/blob/master/include/mesos/authorizer/authorizer.hpp#L138
 to "return stream << JSON::protobuf(acls)". However, it still needs change for 
each protobuf flag. Any thought?


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/#review107604
-------


On Nov. 23, 2015, 5:56 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40224/
> ---
> 
> (Updated Nov. 23, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-3792
> https://issues.apache.org/jira/browse/MESOS-3792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix wrong flags infos in /state and /flags. We should convert protobuf type 
> flag to JSON object explicitly instead of relying on stringify
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
> 
> Diff: https://reviews.apache.org/r/40224/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> ./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
> [{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
> [{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
> }}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
> },"framework_principals": { "values": ["c"] }}]}'
> 
> curl http://master:5050/state
> curl http://master:5050/flag
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Review Request 40224: Fix wrong flags infos in /state and /flags

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/
---

Review request for mesos, Ben Mahler and haosdent huang.


Bugs: MESOS-3792
https://issues.apache.org/jira/browse/MESOS-3792


Repository: mesos


Description
---

Fix wrong flags infos in /state and /flags. We should convert protobuf type 
flag to JSON object explicitly instead of relying on stringify


Diffs
-

  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 

Diff: https://reviews.apache.org/r/40224/diff/


Testing
---

make & make check

./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
[{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
[{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
}}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
},"framework_principals": { "values": ["c"] }}]}'

curl http://master:5050/state
curl http://master:5050/flag


Thanks,

Jian Qiu

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/
---

(Updated Nov. 23, 2015, 5:37 a.m.)


Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.


Changes
---

rebase


Bugs: MESOS-3272
https://issues.apache.org/jira/browse/MESOS-3272


Repository: mesos


Description
---

In CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer, the 
freezer process is terminated in it initilize method, which causes the core 
dump when cgroups::freezer::freeze() calls dispatch(freezer, 
::Freezer::freeze). 

This check is added in cgroups::freezer::freeze() to avoid calling dispatch if 
the freezer process is terminated.


Diffs (updated)
-

  src/linux/cgroups.cpp f67633e31884b21e943a06100191d2228a637b1a 

Diff: https://reviews.apache.org/r/38287/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
 --gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Jian Qiu

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review103402
---



src/master/master.cpp (line 510)
<https://reviews.apache.org/r/39043/#comment161461>

may need a rephrase here


- Jian Qiu


On Oct. 21, 2015, 1:20 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Oct. 21, 2015, 1:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39368: Updated /state.json to show revocable resources.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/#review102858
---

Ship it!


Ship It!

- Jian Qiu


On Oct. 16, 2015, 12:48 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39368/
> ---
> 
> (Updated Oct. 16, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3563
> https://issues.apache.org/jira/browse/MESOS-3563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Revocable resources now show up in the state.json endpoint with "_revocable" 
> suffix.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
>   src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 
> 
> Diff: https://reviews.apache.org/r/39368/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 39216: Rename http_api_tests.cpp to scheduler_http_api_tests.cpp

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/#review102210
---

Ship it!


Ship It!

- Jian Qiu


On Oct. 12, 2015, 5:10 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39216/
> ---
> 
> (Updated Oct. 12, 2015, 5:10 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3594
> https://issues.apache.org/jira/browse/MESOS-3594
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5 
> 
> Diff: https://reviews.apache.org/r/39216/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/
---

(Updated Sept. 24, 2015, 3:15 a.m.)


Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.


Bugs: MESOS-3272
https://issues.apache.org/jira/browse/MESOS-3272


Repository: mesos


Description (updated)
---

In CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer, the 
freezer process is terminated in it initilize method, which causes the core 
dump when cgroups::freezer::freeze() calls dispatch(freezer, 
::Freezer::freeze). 

This check is added in cgroups::freezer::freeze() to avoid calling dispatch if 
the freezer process is terminated.


Diffs (updated)
-

  src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 

Diff: https://reviews.apache.org/r/38287/diff/


Testing (updated)
---

./mesos-tests.sh 
--gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
 --gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/
---

(Updated Sept. 24, 2015, 1:52 a.m.)


Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3293
https://issues.apache.org/jira/browse/MESOS-3293


Repository: mesos


Description (updated)
---

This test is to isolate one single process with one thread in cgroup, and 
checks the number of processes and threads in the cgroup before/after 
isolation. The previous test case uses "sh -c "while true; do sleep 1; done;"" 
as the process, however, it periodically forks a child process "sleep 1" in 
cgroup causing the test failure (expected number of process/thread should be 1, 
but here is 2). This patch is to issue a "cat" command, so there will be only 
one process in cgroup.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
a25ae97a519feb8ead6177da160df8a276ca15bf 

Diff: https://reviews.apache.org/r/38454/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
--gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Jian Qiu

Re: Review Request 38602: Fixed minor typo in Executor API protobuf

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review99952
---

Ship it!


Ship It!

- Jian Qiu


On Sept. 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> ---
> 
> (Updated Sept. 22, 2015, 3:07 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 
> 34bddc4ae7898a32233dc1bbef9d8453705346b6 
>   include/mesos/v1/executor/executor.proto 
> 3f63d30687c8fe71a870eb62cb97f2c538c66ab1 
> 
> Diff: https://reviews.apache.org/r/38602/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37993: Add explanatory comments for Allocator interface

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review99732
---



include/mesos/master/allocator.hpp (line 80)
<https://reviews.apache.org/r/37993/#comment156712>

needs adding explanation for @param inverseOfferCallback


- Jian Qiu


On Sept. 21, 2015, 7:28 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> ---
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 3fea47ffcc69531308068e2701502e481605b912 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99358
---

Ship it!


Ship It!

- Jian Qiu


On Sept. 16, 2015, 6:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> ---
> 
> (Updated Sept. 16, 2015, 6:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/scheduler/scheduler.proto 
> 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/
---

(Updated Sept. 17, 2015, 9:55 a.m.)


Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3293
https://issues.apache.org/jira/browse/MESOS-3293


Repository: mesos


Description
---

Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
a25ae97a519feb8ead6177da160df8a276ca15bf 

Diff: https://reviews.apache.org/r/38454/diff/


Testing (updated)
---

./mesos-tests.sh 
--gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
--gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Jian Qiu

Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/
---

Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3293
https://issues.apache.org/jira/browse/MESOS-3293


Repository: mesos


Description
---

Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
a25ae97a519feb8ead6177da160df8a276ca15bf 

Diff: https://reviews.apache.org/r/38454/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids"


Thanks,

Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

> On Sept. 17, 2015, 8:48 a.m., haosdent huang wrote:
> > Could you use 
> > 
> > ```
> > sudo ./mesos-tests.sh 
> > --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
> > --gtest_repeat=1000 --gtest_break_on_failure
> > ```
> > 
> > to test it?

Done, thanks for reminding!


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/#review99361
-------


On Sept. 17, 2015, 8:28 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38454/
> ---
> 
> (Updated Sept. 17, 2015, 8:28 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3293
> https://issues.apache.org/jira/browse/MESOS-3293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> a25ae97a519feb8ead6177da160df8a276ca15bf 
> 
> Diff: https://reviews.apache.org/r/38454/diff/
> 
> 
> Testing
> ---
> 
> ./mesos-tests.sh 
> --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids"
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote:
> > Thanks for fixing this, but I'm wondering how this fixes the issue.
> > (in fact, not even what is it testing).
> > 
> > If you invoke `cat` without input, it will just hang there waiting on 
> > STDIN, how does this make the test work?
> > (sorry for all the questions, but unfortunately I'm not familiar w/ this 
> > particular test)
> > 
> > Can you please add more information in the Description field?
> > It's pretty obvious (or it should be :) ) that a patch fixes the bug it's 
> > related to, but what folks need to understand is: (a) what the problem was; 
> > (b) how it affected the test and (c) what you did to fix it.
> > 
> > Also, how does this preserve the spirit of the test? I can fix any test by 
> > just having ASSERT(true) :)
> > 
> > BTW - it's fantastic this fixed the issue and you did the repeat-cycle test!
> 
> haosdent huang wrote:
> Hi @marco. "cat" is equals to "sleep forever" command(we conld not 
> execute sleep forver only could sleep xxx). I think this patch should fix the 
> problem according I repeat test this patch tonight. And the cause of this 
> issue has beed documented in jira by @qiujian. The old command sometimes have 
> two processes when running so this test case is flaky.
> 
> haosdent huang wrote:
> Ref: Bash: infinite sleep (infinite blocking) 
> http://stackoverflow.com/questions/2935183/bash-infinite-sleep-infinite-blocking

Thanks for comments, I have udpated the description accordingly.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/#review99400
---


On Sept. 18, 2015, 2:51 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38454/
> ---
> 
> (Updated Sept. 18, 2015, 2:51 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3293
> https://issues.apache.org/jira/browse/MESOS-3293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is to isolate one single process with on thread in cgroup, and 
> checks the number of processes and threads in the cgroup before/after 
> isolation. The previous test case uses "sh -c "while true; do sleep 1; 
> done;"" as the process, however, it periodically forks a child process "sleep 
> 1" in cgroup causing the test failure (expected number of process/thread 
> should be 1, but here is 2). This patch is to issue a "cat" command, so there 
> will be only one process in cgroup.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> a25ae97a519feb8ead6177da160df8a276ca15bf 
> 
> Diff: https://reviews.apache.org/r/38454/diff/
> 
> 
> Testing
> ---
> 
> ./mesos-tests.sh 
> --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/
---

(Updated Sept. 18, 2015, 2:51 a.m.)


Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.


Bugs: MESOS-3293
https://issues.apache.org/jira/browse/MESOS-3293


Repository: mesos


Description (updated)
---

This test is to isolate one single process with on thread in cgroup, and checks 
the number of processes and threads in the cgroup before/after isolation. The 
previous test case uses "sh -c "while true; do sleep 1; done;"" as the process, 
however, it periodically forks a child process "sleep 1" in cgroup causing the 
test failure (expected number of process/thread should be 1, but here is 2). 
This patch is to issue a "cat" command, so there will be only one process in 
cgroup.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
a25ae97a519feb8ead6177da160df8a276ca15bf 

Diff: https://reviews.apache.org/r/38454/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
--gtest_repeat=1000 --gtest_break_on_failure


Thanks,

Jian Qiu

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/
---

(Updated 九月 14, 2015, 7:28 a.m.)


Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.


Bugs: MESOS-3272
https://issues.apache.org/jira/browse/MESOS-3272


Repository: mesos


Description
---

This check in cgroups::freezer::freeze() is necessary
since the freezer process can be terminated in its
initialize method


Diffs (updated)
-

  src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 

Diff: https://reviews.apache.org/r/38287/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
 --verbose


Thanks,

Jian Qiu

Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/
---

Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.


Bugs: MESOS-3272
https://issues.apache.org/jira/browse/MESOS-3272


Repository: mesos


Description
---

This check in cgroups::freezer::freeze() is necessary
since the freezer process can be terminated in its
initialize method


Diffs
-

  src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 

Diff: https://reviews.apache.org/r/38287/diff/


Testing
---

./mesos-tests.sh 
--gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
 --verbose


Thanks,

Jian Qiu

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

> On 九月 11, 2015, 3:09 a.m., haosdent huang wrote:
> > src/linux/cgroups.cpp, line 2440
> > <https://reviews.apache.org/r/38287/diff/1/?file=1067958#file1067958line2440>
> >
> > Does this fall into a loop?

Does not quite catch your point :) if you mean the loop in 
internal::Freezer::freeze, I think it does not.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/#review98540
---


On 九月 11, 2015, 3:05 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38287/
> ---
> 
> (Updated 九月 11, 2015, 3:05 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.
> 
> 
> Bugs: MESOS-3272
> https://issues.apache.org/jira/browse/MESOS-3272
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This check in cgroups::freezer::freeze() is necessary
> since the freezer process can be terminated in its
> initialize method
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/38287/diff/
> 
> 
> Testing
> ---
> 
> ./mesos-tests.sh 
> --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
>  --verbose
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

[Jian Qiu]

> On 九月 11, 2015, 3:09 a.m., haosdent huang wrote:
> > src/linux/cgroups.cpp, line 2440
> > <https://reviews.apache.org/r/38287/diff/1/?file=1067958#file1067958line2440>
> >
> > Does this fall into a loop?
> 
> Jian Qiu wrote:
> Does not quite catch your point :) if you mean the loop in 
> internal::Freezer::freeze, I think it does not.
> 
> haosdent huang wrote:
> Oh, I mean if future keep failed, does this fall into a infinite loop?

OK, I think it will not fall into a loop. Based on the test case

TEST_F(CgroupsAnyHierarchyWithCpuMemoryTest, ROOT_CGROUPS_FreezeNonFreezer)
{
  string hierarchy = path::join(baseHierarchy, "cpu");
  ASSERT_SOME(cgroups::create(hierarchy, TEST_CGROUPS_ROOT));

  AWAIT_EXPECT_FAILED(cgroups::freezer::freeze(hierarchy, TEST_CGROUPS_ROOT));
  AWAIT_EXPECT_FAILED(cgroups::freezer::thaw(hierarchy, TEST_CGROUPS_ROOT));

  // The cgroup is empty so we should still be able to destroy it.
  AWAIT_READY(cgroups::destroy(hierarchy, TEST_CGROUPS_ROOT));
}

This function will just return failed future.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/#review98540
-------


On 九月 11, 2015, 3:05 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38287/
> ---
> 
> (Updated 九月 11, 2015, 3:05 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.
> 
> 
> Bugs: MESOS-3272
> https://issues.apache.org/jira/browse/MESOS-3272
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This check in cgroups::freezer::freeze() is necessary
> since the freezer process can be terminated in its
> initialize method
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/38287/diff/
> 
> 
> Testing
> ---
> 
> ./mesos-tests.sh 
> --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
>  --verbose
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Review Request 37955: Remove hashmap::existsValue since it is never called

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37955/
---

Review request for mesos.


Bugs: MESOS-3329
https://issues.apache.org/jira/browse/MESOS-3329


Repository: mesos


Description
---

Remove hashmap::existsValue since it is never called


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
f09bea125035aa3621402b83608b233e42877559 

Diff: https://reviews.apache.org/r/37955/diff/


Testing
---

make check


Thanks,

Jian Qiu

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/#review97064
---



src/master/master.cpp (line 4904)
<https://reviews.apache.org/r/37180/#comment152785>

If the allocator calls inverse callback followed by an offer callback, will 
the two messages be handled in two separate threads of the framework? I think 
it will be framework's responsibility to ensure data synchronization between 
the two threads?


- Jian Qiu


On 八月 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37180/
> ---
> 
> (Updated 八月 26, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37180/diff/
> 
> 
> Testing
> ---
> 
> The tests break as expected.
> With the scheduler API change there are CHECKs that fail.
> Once we update the API these will be resolved.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/#review96836
---

Ship it!


Ship It!

- Jian Qiu


On 八月 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37280/
 ---
 
 (Updated 八月 26, 2015, 2:13 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
 
 
 Bugs: MESOS-1474
 https://issues.apache.org/jira/browse/MESOS-1474
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
   src/master/allocator/mesos/allocator.hpp 
 aa55755a9c3250579e9366bdbc17a2449e95d659 
   src/master/allocator/mesos/hierarchical.hpp 
 38f8fd2c84314bb3731684d0e9795cb4f50a227e 
   src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb 
 
 Diff: https://reviews.apache.org/r/37280/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joris Van Remoortere