Re: Review Request 40553: Enable mesos tests installation.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118233
---


Fix it, then Ship it!




Thanks a bunch James, this looks great considering the complexity ;). Just some 
(debatable) nits I will fix while landing this.


Makefile.am (lines 98 - 100)


Backslash alignment.



src/Makefile.am (lines 1883 - 1884)


Let's make the backslashes align.



src/Makefile.am (lines 1986 - 1994)


Backslash alignment.



src/tests/containerizer/memory_test_helper.cpp 


This should remain.



src/tests/utils.hpp (line 65)


For consistency, let's add a short comment here as well.


- Till Toenshoff


On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Feb. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fd6f063bc5dc3761368742851e6853547c602e3b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43220/#review118212
---


Ship it!




Thanks! I made some minor comments but took care of those for you prior to 
committing.


support/generate-endpoint-help.py (lines 35 - 37)


I noticed mixed use of single quotes and double quotes, any method to the 
madness?



support/generate-endpoint-help.py (lines 46 - 47)


Seems simpler to just append \n here and use a regular string literal?



support/generate-endpoint-help.py (lines 77 - 93)


Could we make the line wrapping formatting consistent here?


- Ben Mahler


On Feb. 8, 2016, 7:06 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43220/
> ---
> 
> (Updated Feb. 8, 2016, 7:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Invoke this script from anywhere within the mesos source tree
> (including in the build directory) to autogenerate documentation for
> all endpoint strings and install them into the docs/endpoint folder.
> In a subsequent commit we commit all of these autogenerated files back
> to the source repo and add a link in home.md to find them.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43220/diff/
> 
> 
> Testing
> ---
> 
> Ran and generated files from it.  Then rebuilt the website and verified that 
> everything looked as it should.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 43328: Title for documentation webpages.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118243
---



We recently added a script to generate markdown files for all http endpoints in 
the master and agent. We then commit these back to the repo.  We probably need 
to modify this script to insert this header as well as update the files that 
have been committed back.  The script is atsupport/generate-endpoints-help.py 
and the generated files are under docs/endpoints

- Kevin Klues


On Feb. 8, 2016, 3:28 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 8, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review118210
---



Patch looks great!

Reviews applied: [42947]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 6:44 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> ---
> 
> (Updated Feb. 8, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
> https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> 3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43328: Title for documentation webpages.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118237
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 8, 2016, 11:28 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 8, 2016, 11:28 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
>   docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>   docs/upgrades.md 0f05c7ccdf6453f16fe137cb68b74688679a8f0b 
>   docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 
> 
> Diff: https://reviews.apache.org/r/43328/diff/
> 
> 
> Testing
> 

Re: Review Request 43324: Updated endpoints/index.md.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43324/#review118209
---


Ship it!





docs/endpoints/index.md (lines 12 - 13)


A pointer to support/generate-endpoint-help.py might help contributors 
figure out how this works. I'll make this change in the script in the previous 
review.


- Ben Mahler


On Feb. 8, 2016, 7:07 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43324/
> ---
> 
> (Updated Feb. 8, 2016, 7:07 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The index was updated to reflect updates to the
> generate-endpoints-help.py script used to generate it.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 43318: Updated release guide to include doxygen site generation.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43318/#review118241
---


Ship it!




Ship It!

- Ben Mahler


On Feb. 8, 2016, 12:41 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43318/
> ---
> 
> (Updated Feb. 8, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 
> 
> Diff: https://reviews.apache.org/r/43318/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[haosdent huang]

> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > 
> >
> > Why we not use `const` instead of `constexpr` here?
> 
> Joris Van Remoortere wrote:
> Because a parameter to a template specialization must be a `constexpr`.

got it, thank you very much for your explanation.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 41760: Add initialization method to Anonymous module

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41760/#review118242
---



I am little concerned about `Flags` being passed to the module. Since there is 
no visibility about the allowed master/agent flags from the module's 
perspective, how does it cope with the changes to master/slave flags? Would we 
want to expose available master/slave flags as well in include/mesos? It's not 
quite clear what the correct representation would be.


include/mesos/module/anonymous.hpp (line 59)


I am wondering if we should allow the module to indicate an error during 
initialization. Should the return type be `Try` instead?



src/examples/test_anonymous_module.hpp (lines 25 - 48)


Let's move this to the cpp file as with the other modules.



src/examples/test_anonymous_module.cpp (lines 54 - 58)


Do we also need a destructor just like in TestAnonymous?



src/examples/test_anonymous_module.cpp (line 82)


Update description?



src/slave/main.cpp (lines 275 - 278)


Just add a CHECK here and remove the if-else. The module manager returns 
`Error` for NULL.



src/tests/anonymous_tests.cpp (lines 95 - 102)


Please do an explicit initialization:

Try module = 
ModuleManager::create("org_apache_mesos_TestIni...");



src/tests/anonymous_tests.cpp (line 106)


Is there a way to validate this typecast?



src/tests/anonymous_tests.cpp (lines 106 - 107)


Can we just modify the module to fail during initialization if the required 
flags are not present and not do this check here?


- Kapil Arya


On Jan. 4, 2016, 3:16 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41760/
> ---
> 
> (Updated Jan. 4, 2016, 3:16 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
> https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: [MESOS-4253](https://issues.apache.org/jira/browse/MESOS-4253)
> 
> To provide a basic "context" to Anonymous modules, we pass in the `BaseFlags`.
> 
> This tries to be backward compatible with existing modules, so a no-op 
> (`virtual`) implementation of the method is provided in the base class.
> Currently the code is only implemented in the Agent's `main()` method, but if 
> deemed correct, adding it to Master is trivial.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/anonymous.hpp 629eb123b9d5fa9e07ddb1c704ee72e96e8fec5b 
>   src/examples/test_anonymous_module.hpp 
> 3da33a42f04b7421cee8fbb85e29b66e352f5894 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
>   src/tests/anonymous_tests.cpp bc29ff8be94af82dd97f43db4f9594036705e835 
>   src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
>   src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 
> 
> Diff: https://reviews.apache.org/r/41760/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass.
> 
> Also implemented in the 
> [execute-module](http://github.com/massenz/execute-module) - and it works 
> there too:
> ```
> I0102 17:38:26.180788 19971 main.cpp:272] Initializing anonymous module 
> 'com_alertavert_mesos_RemoteExecution'
> I0102 17:38:26.180800 19971 main.cpp:278] Sending flags to module 
> 'com_alertavert_mesos_RemoteExecution'
> I0102 17:38:26.180810 19971 execute_module.hpp:129] Executing initialize() 
> for module; parsing runtime flags
> I0102 17:38:26.181658 19971 execute_module.hpp:139] Configured work dir to 
> [/tmp/agent] and Sandbox dir to [/mnt/mesos/sandbox]
> ```
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[Joris Van Remoortere]

> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > 
> >
> > Why we not use `const` instead of `constexpr` here?

Because a parameter to a template specialization must be a `constexpr`.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---




3rdparty/libprocess/include/process/subprocess.hpp (line 160)


Why we not use `const` instead of `constexpr` here?


- haosdent huang


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43305: Moved systemd executor slice initialization logic.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43305/#review118217
---




src/linux/systemd.cpp (line 150)


indent is incorrect here?


- haosdent huang


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43305/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.hpp dc8605b323cafdc0dde00d36a2cc5cf2c241e51c 
>   src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> b061981b063a67d837fe8e291921ca9c44d3ac40 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> c2e252ec6ed0d6d4c47e244f700315bd340cee5f 
>   src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 
> 
> Diff: https://reviews.apache.org/r/43305/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43319: Remove md files from doxygen.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43319/#review118214
---


Ship it!




Ship It!

- haosdent huang


On Feb. 8, 2016, 12:40 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43319/
> ---
> 
> (Updated Feb. 8, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4619
> https://issues.apache.org/jira/browse/MESOS-4619
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The doxygen html pages corresponding to `doc/*` markdown files are redundant 
> and have broken links. As such, they don't serve any reasonable purpose in 
> doxygen site.
> 
> 
> Diffs
> -
> 
>   Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 
> 
> Diff: https://reviews.apache.org/r/43319/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43258: Modified agent to get container status from containerizer.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/
---

(Updated Feb. 9, 2016, 4:16 a.m.)


Review request for mesos, Jie Yu and Kapil Arya.


Bugs: MESOS-4490
https://issues.apache.org/jira/browse/MESOS-4490


Repository: mesos


Description
---

Modified agent to get container status from containerizer.


Diffs (updated)
-

  src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
  src/slave/slave.cpp 9dda3a2c4dc4c355488d34dc8d0606330a756f2a 

Diff: https://reviews.apache.org/r/43258/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Re: Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43353/#review118359
---



Patch looks great!

Reviews applied: [43353]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 2:41 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43353/
> ---
> 
> (Updated Feb. 9, 2016, 2:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4571
> https://issues.apache.org/jira/browse/MESOS-4571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
> 
> Diff: https://reviews.apache.org/r/43353/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check -j4 
> GTEST_FILTER='SlaveRecoveryTest*.RecoverStatusUpdateManager'` on ubuntu 14.04
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review118362
---



I like the reworking of the recover logic, but I'm still unclear about why you 
have to tell the allocator to update some weights to 1.0.


src/master/master.hpp (line 1560)


Nit: Could you swap the order here, so that it matches the check above in 
`if (weight->info().role() != weightInfo.role()) {`? I think it'll read a bit 
cleaner, and even align with the line following: 
`weight->mutable_info()->CopyFrom(weightInfo);`



src/master/master.cpp (line 1548)


s/alloctor/allocator/



src/master/master.cpp (lines 1548 - 1549)


Can you explain more clearly why this needs to be done? Is it because we 
already initialized the allocator with the weights from --weights?


- Adam B


On Jan. 25, 2016, 7:36 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated Jan. 25, 2016, 7:36 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 5ee3c7afadd131802c93febbb6b4dbad069c2d81 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/authorizer/local/authorizer.hpp 
> c7321c276d566eca6a91f45c546468bea1b0da15 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 5a737a6490060b0194db097990b327c9921221f4 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --weights="role1=4.2,role2=3.1" --authenticate_http 
> --credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 4.2
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 3.1
> }
> ]
> }
> 
> Test update:
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  -X PUT http://127.0.0.1:5050/weights
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [],
> "name": "*",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.0
> },
> {
> "frameworks": [],
> "name": "role1",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.8
> },
> {
> "frameworks": [],
> "name": "role2",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.0
> },
> {
> "frameworks": [],
> "name": "role3",
> "resources": {
> "cpus": 0,
> "disk": 0,
>   

Re: Review Request 42705: Update docs for --weights flag and authorization.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/#review118365
---


Fix it, then Ship it!




Looks great!


docs/configuration.md (line 685)


s/if it is not specified,/and instead,/



docs/configuration.md (line 686)


s/operator/an operator/


- Adam B


On Jan. 24, 2016, 9:54 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42705/
> ---
> 
> (Updated Jan. 24, 2016, 9:54 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs for --weights flag and authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
---

(Updated Feb. 9, 2016, 1:49 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments on r41288


Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
---

This change modifies the existing scheduler tests to use the new executor HTTP 
library instead of the old driver based interface.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 

Diff: https://reviews.apache.org/r/41291/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/
---

(Updated Feb. 9, 2016, 1:49 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comment


Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433


Repository: mesos


Description
---

This change introduces a versioned callback interface for testing HTTP based 
executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
for Schedulers.


Diffs (updated)
-

  src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 

Diff: https://reviews.apache.org/r/41288/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

> On Feb. 9, 2016, 1:10 a.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, line 948
> > 
> >
> > looks like you forgot to pass "this" to this callback?

Good catch. Fixed


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/#review118340
---


On Feb. 9, 2016, 1:49 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41288/
> ---
> 
> (Updated Feb. 9, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a versioned callback interface for testing HTTP based 
> executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
> for Schedulers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 
> 
> Diff: https://reviews.apache.org/r/41288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/
---

(Updated Feb. 9, 2016, 2:32 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3413
https://issues.apache.org/jira/browse/MESOS-3413


Repository: mesos


Description
---

Fixed persistent volumes with docker tasks.


Diffs
-

  src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
  src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 

Diff: https://reviews.apache.org/r/43015/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118354
---



Patch looks great!

Reviews applied: [41288, 43225, 41290, 41291]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 1:49 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> ---
> 
> (Updated Feb. 9, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing scheduler tests to use the new executor 
> HTTP library instead of the old driver based interface.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/41291/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43258: Modified agent to get container status from containerizer.

[Avinash sridharan]

> On Feb. 8, 2016, 8:04 p.m., Avinash sridharan wrote:
> > src/slave/slave.cpp, line 3178
> > 
> >
> > Should we be destroying the container on failure of the `Future`? This 
> > is what we are doing in `_statusupdate`

The `LOG(WARNING)` in `_statusUpdate` suggests that its an implicit assumption 
in `_statusupdate` that it will be called from `containerizer->update`. Since 
the current changes are maintaining that assumption, we can drop this defect.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/#review118280
---


On Feb. 9, 2016, 4:16 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43258/
> ---
> 
> (Updated Feb. 9, 2016, 4:16 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-4490
> https://issues.apache.org/jira/browse/MESOS-4490
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified agent to get container status from containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
>   src/slave/slave.cpp 9dda3a2c4dc4c355488d34dc8d0606330a756f2a 
> 
> Diff: https://reviews.apache.org/r/43258/diff/
> 
> 
> Testing
> ---
> 
> make and make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review118349
---




src/docker/docker.cpp (line 525)


Can you put a more elaborate message here?
i.e: "User network mode requires Docker version higher than 1.9.0."


- Timothy Chen


On Feb. 4, 2016, 10:04 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Feb. 4, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
>   src/docker/docker.cpp a83172674b385a59cfd6f344836740a5719f954e 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 43201: Updated reservation documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118352
---



Patch looks great!

Reviews applied: [43201]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 4, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43353/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4571
https://issues.apache.org/jira/browse/MESOS-4571


Repository: mesos


Description
---

Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.


Diffs
-

  src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 

Diff: https://reviews.apache.org/r/43353/diff/


Testing
---

`sudo make check -j4 
GTEST_FILTER='SlaveRecoveryTest*.RecoverStatusUpdateManager'` on ubuntu 14.04


Thanks,

Shuai Lin

Re: Review Request 42689: Clarified a comment that occurs in several test cases.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42689/#review118360
---



Looks good, but the patch doesn't apply cleanly anymore with 
`apply-reviews.py`. If you rebase it, I'll commit it.

- Adam B


On Jan. 23, 2016, 3:05 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42689/
> ---
> 
> (Updated Jan. 23, 2016, 3:05 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified a comment that occurs in several test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 7acf7ab29d64d891f3288f8042d267dcc82a32e9 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
> 
> Diff: https://reviews.apache.org/r/42689/diff/
> 
> 
> Testing
> ---
> 
> Seems like these snuck in due to copy-and-pastes that were concurrent with 
> the patch to fixup the rest of the instances of this comment.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43328: Title for documentation webpages.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/
---

Review request for mesos and Neil Conway.


Bugs: MESOS-4588
https://issues.apache.org/jira/browse/MESOS-4588


Repository: mesos


Description
---

Title for documentation webpages.


Diffs
-

  docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
  docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
  docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
  docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
  docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
  docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
  docs/committer-candidate-checklist.md 
fd55a398c836a30ba80203a64ba10fefe2cb9108 
  docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
  docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
  docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
  docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
  docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
  docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
  docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
  docs/engineering-principles-and-practices.md 
6babb929ead758ee5187d5fc5760d084876c3298 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
  docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
  docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
  docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
  docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
  docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
  docs/high-availability-framework-guide.md 
2576fa2a6e3021c34d643d3da7585fc6d95913c7 
  docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
  docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
  docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
  docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
  docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
  docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
  docs/networking-for-mesos-managed-containers.md 
f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
  docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
  docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
  docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
  docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
  docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
  docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
  docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
  docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
  docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
  docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
  docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
  docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
  docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
  docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
  docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
  docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
  docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
  docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
  docs/upgrades.md 0f05c7ccdf6453f16fe137cb68b74688679a8f0b 
  docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 

Diff: https://reviews.apache.org/r/43328/diff/


Testing
---

Tested with rake dev to see if the effects are coming in the live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43328: Title for documentation webpages.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118236
---


Ship it!




Ship It!

- haosdent huang


On 二月 8, 2016, 3:28 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated 二月 8, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
>   docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>   docs/upgrades.md 0f05c7ccdf6453f16fe137cb68b74688679a8f0b 
>   docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 
> 
> Diff: https://reviews.apache.org/r/43328/diff/
> 
> 
> Testing
> 

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review118227
---


Ship it!




Ship It!

- Bernd Mathiske


On Feb. 7, 2016, 10:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 7, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/#review118262
---




src/slave/containerizer/mesos/containerizer.cpp (line 1317)


s/aggregate/result/



src/slave/containerizer/mesos/containerizer.cpp (line 1330)


Please remove this. we need to be very careful of adding INFO level logging.



src/slave/containerizer/mesos/containerizer.cpp (line 1341)


s/Unable to get status for//



src/slave/containerizer/mesos/containerizer.cpp (lines 1352 - 1355)


```
return await(futures).then(
lambda::bind(_status, containerId, lambda::_1));
```


- Jie Yu


On Feb. 8, 2016, 6:43 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42983/
> ---
> 
> (Updated Feb. 8, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `status` method in `MesosContainerizer`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1e362d2756690368fde46a3a516c258d9ead2154 
> 
> Diff: https://reviews.apache.org/r/42983/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 40553: Enable mesos tests installation.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118249
---




src/tests/script.cpp (line 112)


Whoops, this one was not supposed to get removed.


- Till Toenshoff


On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Feb. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fd6f063bc5dc3761368742851e6853547c602e3b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43328: Title for documentation webpages.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118250
---



Patch looks great!

Reviews applied: [43328]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 3:28 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 8, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
>   docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>   

Re: Review Request 43199: Updated authorization documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43199/
---

(Updated Feb. 8, 2016, 6:40 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Added more ACL examples, and altered the existing ACL examples to be more 
practical.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated authorization documentation.

Added information about the distinction between roles and principals, as well 
as a real-world authorization example.


Diffs (updated)
-

  docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 

Diff: https://reviews.apache.org/r/43199/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review118269
---



Patch looks great!

Reviews applied: [43329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 5:09 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated Feb. 8, 2016, 5:09 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43292/#review118257
---


Ship it!




Ship It!

- Jie Yu


On Feb. 7, 2016, 1:09 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43292/
> ---
> 
> (Updated Feb. 7, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should be responsible for freeing a handle only if the handle
> manager is set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/43292/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118256
---




src/tests/containerizer/isolator_tests.cpp (line 917)


s/uint32_t/uint16_t/



src/tests/containerizer/isolator_tests.cpp (line 998)


I would just check if the primiary is the one we set. For secondary, I 
would just check that it's not 0.


- Jie Yu


On Feb. 8, 2016, 6:43 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Feb. 8, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls major handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 84fe4fb61ac032e68d2ab22e85f6b41481c04644 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-3775
https://issues.apache.org/jira/browse/MESOS-3775


Repository: mesos


Description
---

Speeded up MasterAllocatorTest.SlaveLost test.


Diffs
-

  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 

Diff: https://reviews.apache.org/r/43329/diff/


Testing
---

```
[--] 1 test from MasterAllocatorTest/0, where TypeParam = 
mesos::internal::master::allocator::MesosAllocator >
[ RUN  ] MasterAllocatorTest/0.SlaveLost
[   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
[--] 1 test from MasterAllocatorTest/0 (369 ms total)

[--] 1 test from MasterAllocatorTest/1, where TypeParam = 
mesos::internal::tests::Module
[ RUN  ] MasterAllocatorTest/1.SlaveLost
[   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
[--] 1 test from MasterAllocatorTest/1 (120 ms total)
```


Thanks,

Shuai Lin

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/
---

(Updated Feb. 8, 2016, 9:29 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.


Bugs: MESOS-4615
https://issues.apache.org/jira/browse/MESOS-4615


Repository: mesos


Description
---

The test needs to wait for the task to finish before examining the resulting 
files.


Diffs
-

  src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 

Diff: https://reviews.apache.org/r/42842/diff/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 43199: Updated authorization documentation.

[Greg Mann]

> On Feb. 6, 2016, 8:02 a.m., Guangya Liu wrote:
> > docs/authorization.md, line 50
> > 
> >
> > Do u want to add an example for quota_principals?

Good idea! I added examples for quota. Also, after reading through the existing 
examples, I edited some of them to be a bit more practical; there were a couple 
that I didn't think made much sense in practice.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43199/#review118140
---


On Feb. 8, 2016, 6:40 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43199/
> ---
> 
> (Updated Feb. 8, 2016, 6:40 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization documentation.
> 
> Added information about the distinction between roles and principals, as well 
> as a real-world authorization example.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
> 
> Diff: https://reviews.apache.org/r/43199/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

> On Feb. 6, 2016, 4:14 a.m., Guangya Liu wrote:
> > docs/roles.md, line 132
> > 
> >
> > I think that the principals does not related to the operator of http 
> > endpoint?

The principals specified in the ACLs are used to authorize both framework 
operations, as well as operations through the operator HTTP endpoints.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118136
---


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 8, 2016, 6:56 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Added reference to multi-role work.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43322/
---

(Updated Feb. 8, 2016, 8:33 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4358
https://issues.apache.org/jira/browse/MESOS-4358


Repository: mesos


Description
---

Exposed `ContainerStatus` in `state.json`.


Diffs (updated)
-

  src/common/http.cpp a56c3f1fdc1beec0bf842eba826279e82d4648ec 

Diff: https://reviews.apache.org/r/43322/diff/


Testing (updated)
---

make and 'make check'


Thanks,

Avinash sridharan

Re: Review Request 43335: Fixed flaky segfault in DockerFetcherPluginTest.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43335/#review118289
---


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2016, 8:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43335/
> ---
> 
> (Updated Feb. 8, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4570
> https://issues.apache.org/jira/browse/MESOS-4570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed flaky segfault in DockerFetcherPluginTest.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp 6ffe3f424f5b37982c4ef807597466622cc3a645 
> 
> Diff: https://reviews.apache.org/r/43335/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> ./bin/mesos-tests.sh --gtest_filter="*DockerFetcherPluginTest*" 
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> Tested repeatly with more than 900 iterations.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review118285
---



I realized a tricky part in the recovery path while dealing with potential 
conflicts with MesosContainerizer (LinuxFilesystemIsolator). For instance, will 
the LinuxFilesystemIsolator try to umount some persistent volume mounts that 
belongs to docker containerizer because it'll treat them as orphans. After 
checking the code, we're lucky here because of the way LinxuFilesystemIsolator 
detects orphans in LinuxFilesystemIsolator. There will be a mount from 
'directory' (e.g., /var/lib/mesos/...) -> 'sandbox' (e.g., 
rootfs/mnt/mesos/sandbox). If we cannot find such a mount in 
LinuxFilesystemIsolator, it'll not try to umount volumes under 'directory'.

However, I don't see any cleanup code during recovery in this patch. Do we need 
to cleanup volume mounts for orphan docker containers?

- Jie Yu


On Jan. 30, 2016, 10:43 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Jan. 30, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43336: Introduced Appc image fetcher.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/#review118288
---



Patch looks great!

Reviews applied: [41958, 41959, 42156, 42157, 43127, 43198, 43336]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 8:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43336/
> ---
> 
> (Updated Feb. 8, 2016, 8:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for simple image discovery for Appc images.
> 
> TODO: Add tests.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
>   src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
>   src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
>   src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
> 
> Diff: https://reviews.apache.org/r/43336/diff/
> 
> 
> Testing
> ---
> 
> Tested with local http(s) server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/#review118293
---


Fix it, then Ship it!





src/examples/event_call_framework.cpp (line 195)


ditto. add a comment please.


- Vinod Kone


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43286/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. The root cause is similar to r43285.
> 
> 
> Diffs
> -
> 
>   src/examples/event_call_framework.cpp 
> 8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
> 
> Diff: https://reviews.apache.org/r/43286/diff/
> 
> 
> Testing
> ---
> 
> make check + testing steps done in r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
---

(Updated Feb. 8, 2016, 7:13 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Added a unit-test to test net_cls primary handles set from command line.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description (updated)
---

Added a unit-test to test net_cls primary handles set from command line.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
84fe4fb61ac032e68d2ab22e85f6b41481c04644 

Diff: https://reviews.apache.org/r/42782/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/
---

(Updated Feb. 8, 2016, 7:54 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4489
https://issues.apache.org/jira/browse/MESOS-4489


Repository: mesos


Description
---

Implemented the `status` method in `CgroupNetClsIsolatorProcess`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
fd674090d4b7f22b98571b693d71493d71b8e05e 

Diff: https://reviews.apache.org/r/42947/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Review Request 43336: Introduced Appc image fetcher.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added implementation for simple image discovery for Appc images.

TODO: Add tests.


Diffs
-

  src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
  src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/43336/diff/


Testing
---

Tested with local http(s) server.


Thanks,

Jojy Varghese

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43285/#review118290
---


Fix it, then Ship it!




Great catch! Mystery solved!


src/examples/test_http_executor.cpp (line 198)


Can you add a comment here for posterity?


- Vinod Kone


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43285/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4614
> https://issues.apache.org/jira/browse/MESOS-4614
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change fixes the flakiness in this test. The issue was a race between 
> the `connected` callback being called before we did `process::spawn` to start 
> the process.
> 
> The details of the race that lead to the failure are as follows:
> - We started the executor library inside the constructor of `TestExecutor`. 
> The callback function did `process::defer(self(), ::connected)`
> - The `connected` callback can be invoked by the Executor library before we 
> got a chance to actually invoke `process::spawn` on the `TestExecutor` 
> process itself. This in can turn lead to the `dispatch` being silently 
> dropped.
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L2456
> 
> This change now starts the library inside the `initialize` function that is 
> gurranteed to be called after `process::spawn` is invoked.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_executor.cpp 
> 4916e0ebb7215d911556561a8560d78a1192001c 
> 
> Diff: https://reviews.apache.org/r/43285/diff/
> 
> 
> Testing
> ---
> 
> make check + The flakiness is really easy to reproduce under load:
> 
> - Run the tests with `stress --cpu 4 --timeout 120` running in the background.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118292
---


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Feb. 8, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls primary handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 84fe4fb61ac032e68d2ab22e85f6b41481c04644 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118291
---




src/tests/containerizer/isolator_tests.cpp (line 1000)


I would use EXPECT_NE(0, classid.get() & 0x);


- Jie Yu


On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Feb. 8, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls primary handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 84fe4fb61ac032e68d2ab22e85f6b41481c04644 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43288/#review118295
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43288/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
> 
> Diff: https://reviews.apache.org/r/43288/diff/
> 
> 
> Testing
> ---
> 
> make check + testing done using steps on r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43287: Replaced naked pointer with Owned.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43287/#review118294
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43287/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change replaces the old C style pointer with `process::Owned`.
> 
> 
> Diffs
> -
> 
>   src/examples/event_call_framework.cpp 
> 8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
> 
> Diff: https://reviews.apache.org/r/43287/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/#review118261
---


Fix it, then Ship it!





src/slave/containerizer/containerizer.hpp (line 118)


Put '{' in the next line.


- Jie Yu


On Feb. 5, 2016, 3:35 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42982/
> ---
> 
> (Updated Feb. 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defined a virtual `status` method for Containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> 08d1ed3cf50f50b5b6e71df60bffbd141490ad32 
> 
> Diff: https://reviews.apache.org/r/42982/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review118260
---




src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 401)


Indentation.



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 412)


s/CgroupInfo_NetCls/CgroupInfo::NetCls/



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 413)


why the extra '(' and ')'?



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 416 - 417)


This is not needed. Please kill it.


- Jie Yu


On Feb. 8, 2016, 6:44 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> ---
> 
> (Updated Feb. 8, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
> https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> 3f8d07cad363c62e31adc1a756ebc7ff94b76db3 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118278
---


Ship it!




LGTM!

- Joseph Wu


On Feb. 7, 2016, 5:57 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> ---
> 
> (Updated Feb. 7, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 01a3ff031b70366443214e2895803cd4b2606ad8 
> 
> Diff: https://reviews.apache.org/r/43308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

(Updated Feb. 8, 2016, 7:19 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43328: Title for documentation webpages.

[Abhishek Dasgupta]

> On Feb. 8, 2016, 4:47 p.m., Kevin Klues wrote:
> > We recently added a script to generate markdown files for all http 
> > endpoints in the master and agent. We then commit these back to the repo.  
> > We probably need to modify this script to insert this header as well as 
> > update the files that have been committed back.  The script is 
> > atsupport/generate-endpoints-help.py and the generated files are under 
> > docs/endpoints

Yes, that was I thinking after seeing your commit. May be, we can right an 
automation script that would insert these header whenever there is any new md 
file in docs folder. Can you tell me if there is any such script or else I 
would raise an issue regarding this.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review118243
---


On Feb. 8, 2016, 3:28 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 8, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 8, 2016, 8:17 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
1e362d2756690368fde46a3a516c258d9ead2154 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43198: Added common appc spec utilities.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43198/
---

(Updated Feb. 8, 2016, 8:27 p.m.)


Review request for mesos and Jie Yu.


Changes
---

changed getDependencies API.


Bugs: MESOS-4596
https://issues.apache.org/jira/browse/MESOS-4596


Repository: mesos


Description
---

This change adds common utility functions such as :
  - validating image information against actual data in the image directory.
  - getting list of dependencies at depth 1 for an image.
  - getting image path simple image discovery.


Diffs (updated)
-

  include/mesos/appc/spec.hpp 462159daeb5c5a75dd5c2c340d797d3cfd4d7e11 
  src/appc/spec.cpp fc36a0b5bc36c236cc4f49210d0058b34d0ffc40 

Diff: https://reviews.apache.org/r/43198/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43200: Updated role documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118282
---



Patch looks great!

Reviews applied: [43199, 43200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/#review118274
---



Bad patch!

Reviews applied: [42842]

Failed command: ./support/apply-review.sh -n -r 42842

Error:
2016-02-08 19:14:42 URL:https://reviews.apache.org/r/42842/diff/raw/ 
[1788/1788] -> "42842.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/11326/console

- Mesos ReviewBot


On Feb. 8, 2016, 5:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42842/
> ---
> 
> (Updated Feb. 8, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian 
> Qiu.
> 
> 
> Bugs: MESOS-4615
> https://issues.apache.org/jira/browse/MESOS-4615
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test needs to wait for the task to finish before examining the resulting 
> files.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 
> 
> Diff: https://reviews.apache.org/r/42842/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/
---

(Updated Feb. 8, 2016, 7:16 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added helper function in cgroup for supporting net_cls subsystem.


Diffs
-

  src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
  src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 

Diff: https://reviews.apache.org/r/43096/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/
---

(Updated Feb. 8, 2016, 10:05 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

See summary. The root cause is similar to r43285.


Diffs (updated)
-

  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 

Diff: https://reviews.apache.org/r/43286/diff/


Testing
---

make check + testing steps done in r43285


Thanks,

Anand Mazumdar

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/
---

(Updated Feb. 8, 2016, 10:15 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433


Repository: mesos


Description
---

This change introduces a versioned callback interface for testing HTTP based 
executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
for Schedulers.


Diffs (updated)
-

  src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 

Diff: https://reviews.apache.org/r/41288/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

> On Feb. 8, 2016, 10 p.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, line 960
> > 
> >
> > s/executor_/executor/
> > 
> > we typically don't use underscores for member variables.

Our style guide does recommend to prefer trailing underscores for member 
variables. From the style guide:

```
Prefer trailing underscores for use as member fields (but not required).
```

I removed the trailing underscores for now since all the other classes/structs 
in this file do not use it.


> On Feb. 8, 2016, 10 p.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, line 965
> > 
> >
> > do you need executor::TestMesos even though you are in executor 
> > namespace?

Yep, right. My bad, fixed. :-)


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/#review118299
---


On Feb. 8, 2016, 10:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41288/
> ---
> 
> (Updated Feb. 8, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a versioned callback interface for testing HTTP based 
> executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
> for Schedulers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 
> 
> Diff: https://reviews.apache.org/r/41288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43284: Wait for perf statistics processes exit.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/#review118312
---




src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp (lines 132 - 134)


I think you should discard the future and let it do the correct thing -- 
kill and reap the perf process -- rather than do a blocking await. The perf 
sample interval is configurable and typical values are 10's of seconds.

Note: I'm not sure if the correct behavior is implemented...


- Ian Downes


On Feb. 7, 2016, 12:19 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43284/
> ---
> 
> (Updated Feb. 7, 2016, 12:19 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait for perf statistics processes exit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 65e731886b9e5cac07ae3ad6398faf8f50de5650 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 5ef4ae5c468580352cd16e7716b9ca4c0acde659 
> 
> Diff: https://reviews.apache.org/r/43284/diff/
> 
> 
> Testing
> ---
> 
> Without this patch, when running 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
> ```
> , would got this error
> ```
> [--] Global test environment tear-down
> ../../src/tests/environment.cpp:732: Failure
> Failed
> Tests completed with child processes remaining:
> -+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event 
> cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock 
> --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
>  |   --- 16584 sleep 0.25
>  --- 16581 ()
> [==] 1 test from 1 test case ran. (4095 ms total)
> ```
> 
> This also fix similar error in 
> `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43284: Wait for perf statistics processes exit.

[Ian Downes]

> On Feb. 8, 2016, 2:47 p.m., Ian Downes wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines 
> > 132-134
> > 
> >
> > I think you should discard the future and let it do the correct thing 
> > -- kill and reap the perf process -- rather than do a blocking await. The 
> > perf sample interval is configurable and typical values are 10's of seconds.
> > 
> > Note: I'm not sure if the correct behavior is implemented...

Actually, it looks like it might:

```
virtual void initialize()
{
  // Stop when no one cares.
  promise.future().onDiscard(lambda::bind(
  static_cast(terminate), self(), true));

  execute();
}

virtual void finalize()
{
  // Kill the perf process (if it's still running) by sending
  // SIGTERM to the signal handler which will then SIGKILL the
  // perf process group created by setupChild.
  if (perf.isSome() && perf->status().isPending()) {
kill(perf->pid(), SIGTERM);
  }

  promise.discard();
}
```


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/#review118312
---


On Feb. 7, 2016, 12:19 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43284/
> ---
> 
> (Updated Feb. 7, 2016, 12:19 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait for perf statistics processes exit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 65e731886b9e5cac07ae3ad6398faf8f50de5650 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 5ef4ae5c468580352cd16e7716b9ca4c0acde659 
> 
> Diff: https://reviews.apache.org/r/43284/diff/
> 
> 
> Testing
> ---
> 
> Without this patch, when running 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
> ```
> , would got this error
> ```
> [--] Global test environment tear-down
> ../../src/tests/environment.cpp:732: Failure
> Failed
> Tests completed with child processes remaining:
> -+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event 
> cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock 
> --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
>  |   --- 16584 sleep 0.25
>  --- 16581 ()
> [==] 1 test from 1 test case ran. (4095 ms total)
> ```
> 
> This also fix similar error in 
> `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---




src/linux/perf.cpp (lines 423 - 426)


Hmmm, I'm not satisfied with this. I thought the new output format was 
introduced at a specific kernel version (3.13.0 might not be correct). Could 
you please confirm that the 3.10 on CentOS7.1 has the new unit field but other 
3.10 kernels don't.


- Ian Downes


On Feb. 7, 2016, 12:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 7, 2016, 12:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42757: Split os::memory() out into platform specific files.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42757/#review118301
---


Ship it!




Ship It!

- Ian Downes


On Feb. 5, 2016, 9:35 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42757/
> ---
> 
> (Updated Feb. 5, 2016, 9:35 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-4504
> https://issues.apache.org/jira/browse/MESOS-4504
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Split os::memory() out into platform specific files.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> 10346dea8d658ea0a9b658a1d72eee8cc3056da8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> cc9bfe8942db7e62f5d415fc500b78adf2ac9759 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 
> 0e897ea15d6b3ed76a8a264726db70980bb9517a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b47187870d6d8d21425253dac481e28102e8dcc9 
> 
> Diff: https://reviews.apache.org/r/42757/diff/
> 
> 
> Testing
> ---
> 
> gmake check on FreeBSD and Ubuntu.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118309
---




src/tests/scheduler_tests.cpp (lines 252 - 258)


reorder?



src/tests/scheduler_tests.cpp (lines 376 - 382)


reorder.



src/tests/scheduler_tests.cpp (lines 645 - 651)


reorder?



src/tests/scheduler_tests.cpp (lines 771 - 777)


reorder.



src/tests/scheduler_tests.cpp (lines 1177 - 1183)


reorder



src/tests/scheduler_tests.cpp (line 1212)


s/data/message/


- Vinod Kone


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> ---
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing scheduler tests to use the new executor 
> HTTP library instead of the old driver based interface.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/41291/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/#review118304
---




src/tests/mesos.hpp (lines 964 - 1021)


put these (using statement and actions) in v1 namespace?


- Vinod Kone


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43225/
> ---
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds some gtest actions that can be used to subscribe/send status 
> updates using the executor library. These are in similar vein to the existing 
> actions like `SendStatusUpdateFromTask`.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
> 
> Diff: https://reviews.apache.org/r/43225/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42735: Make bash scripts portable.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review118297
---


Ship it!




Ship It!

- Ian Downes


On Feb. 5, 2016, 8:51 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42735/
> ---
> 
> (Updated Feb. 5, 2016, 8:51 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Ian Downes.
> 
> 
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make bash scripts portable.
> 
> 
> Diffs
> -
> 
>   support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c 
>   support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a 
>   support/docker_build.sh 55d402e35d6d391fd483c47b69b64c1ff99569d3 
>   support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
>   support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 
>   support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 
>   support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee 
> 
> Diff: https://reviews.apache.org/r/42735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 42156: Refactored up the common image creation in appc tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42156/#review118296
---


Ship it!




Ship It!

- Jie Yu


On Feb. 6, 2016, 1:35 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42156/
> ---
> 
> (Updated Feb. 6, 2016, 1:35 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change will enable other tests to reuse the common test image creation
> logic.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 012dba4e24b9a94dc8da0d329baf4bec2d33ffca 
> 
> Diff: https://reviews.apache.org/r/42156/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/#review118299
---




src/tests/mesos.hpp (line 937)


s/executor/_executor/



src/tests/mesos.hpp (line 943)


put the second argument on next line for consistency.

also pass "this" as the 3rd argument for consistency with connected 
callback.



src/tests/mesos.hpp (line 960)


s/executor_/executor/

we typically don't use underscores for member variables.



src/tests/mesos.hpp (line 965)


do you need executor::TestMesos even though you are in executor namespace?


- Vinod Kone


On Feb. 4, 2016, 11:11 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41288/
> ---
> 
> (Updated Feb. 4, 2016, 11:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a versioned callback interface for testing HTTP based 
> executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
> for Schedulers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
> 
> Diff: https://reviews.apache.org/r/41288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43285/
---

(Updated Feb. 8, 2016, 10:04 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4614
https://issues.apache.org/jira/browse/MESOS-4614


Repository: mesos


Description
---

This change fixes the flakiness in this test. The issue was a race between the 
`connected` callback being called before we did `process::spawn` to start the 
process.

The details of the race that lead to the failure are as follows:
- We started the executor library inside the constructor of `TestExecutor`. The 
callback function did `process::defer(self(), ::connected)`
- The `connected` callback can be invoked by the Executor library before we got 
a chance to actually invoke `process::spawn` on the `TestExecutor` process 
itself. This in can turn lead to the `dispatch` being silently dropped.
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L2456

This change now starts the library inside the `initialize` function that is 
gurranteed to be called after `process::spawn` is invoked.


Diffs (updated)
-

  src/examples/test_http_executor.cpp 4916e0ebb7215d911556561a8560d78a1192001c 

Diff: https://reviews.apache.org/r/43285/diff/


Testing
---

make check + The flakiness is really easy to reproduce under load:

- Run the tests with `stress --cpu 4 --timeout 120` running in the background.


Thanks,

Anand Mazumdar

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review118306
---




src/tests/containerizer.hpp (line 140)


s/v1Mesos/v1Libraries/ ?



src/tests/containerizer.cpp (line 117)


kill this.



src/tests/containerizer.cpp (line 164)


```
if (executors.contains(...)) {
  Executor* executor = executors[executorInfo.executor_id()];
  ...
  ...
} else {
  ...
  ...
}
```


- Vinod Kone


On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> ---
> 
> (Updated Feb. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the `TestContainerizer` class to handle HTTP based 
> executors. Previously, the containerizer test class only used to handle the 
> driver interface.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/
---

(Updated Feb. 9, 2016, 12:12 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433


Repository: mesos


Description
---

This change introduces a versioned callback interface for testing HTTP based 
executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
for Schedulers.


Diffs (updated)
-

  src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 

Diff: https://reviews.apache.org/r/41288/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/
---

(Updated Feb. 9, 2016, 12:12 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433


Repository: mesos


Description
---

This change adds some gtest actions that can be used to subscribe/send status 
updates using the executor library. These are in similar vein to the existing 
actions like `SendStatusUpdateFromTask`.


Diffs (updated)
-

  src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 

Diff: https://reviews.apache.org/r/43225/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
---

(Updated Feb. 9, 2016, 12:14 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
---

This change modifies the existing scheduler tests to use the new executor HTTP 
library instead of the old driver based interface.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 

Diff: https://reviews.apache.org/r/41291/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/
---

(Updated Feb. 9, 2016, 12:13 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457


Repository: mesos


Description
---

This change modifies the `TestContainerizer` class to handle HTTP based 
executors. Previously, the containerizer test class only used to handle the 
driver interface.


Diffs (updated)
-

  src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
  src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 

Diff: https://reviews.apache.org/r/41290/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118335
---


Ship it!




Ship It!

- Guangya Liu


On 二月 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

[Vinod Kone]

> On Feb. 6, 2016, 2:26 p.m., Klaus Ma wrote:
> > src/slave/http.cpp, line 402
> > 
> >
> > For GUI developer, it's better to export more info when it's 
> > recovering, e.g. build_time, build_date. So I'd like to export agent state 
> > in `/state`.

I would rather we tease out static information into separate endpoints. For 
example, version info (including build_time, build_date, git_sha etc) is 
already exposed in /version endpoint. Having partial information in an endpoint 
is more confusing.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118143
---


On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> ---
> 
> (Updated Feb. 5, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> ---
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/
---

(Updated Feb. 9, 2016, 12:40 a.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Changes
---

addressed comments.


Bugs: MESOS-4066
https://issues.apache.org/jira/browse/MESOS-4066


Repository: mesos


Description
---

This will help operators hitting the /state endpoint by not returning incomplete
data when slave is still recoverying.


Diffs (updated)
-

  src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
  src/tests/slave_tests.cpp 2a34d541eb8e2fc4802cacf38195460fe6094abc 

Diff: https://reviews.apache.org/r/43267/diff/


Testing
---

make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"

./bin/mesos-tests.sh --gtest_filter="*StateEndpointUnavailableDuringRecovery*" 
--gtest_repeat=1000 --gtest_break_on_failure

./bin/mesos-tests.sh


Thanks,

Vinod Kone

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118339
---


Ship it!




LGTM

- Anand Mazumdar


On Feb. 9, 2016, 12:40 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> ---
> 
> (Updated Feb. 9, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp 2a34d541eb8e2fc4802cacf38195460fe6094abc 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> ---
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43344/
---

Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4622
https://issues.apache.org/jira/browse/MESOS-4622


Repository: mesos


Description
---

Added flag `--cgroups_net_cls_primary_handle`.


Diffs
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 

Diff: https://reviews.apache.org/r/43344/diff/


Testing
---

Checked the rendering of configuration.md on locally generated docker-site.


Thanks,

Avinash sridharan

Re: Review Request 43200: Updated role documentation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118327
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43199: Updated authorization documentation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43199/#review118325
---




docs/authorization.md (lines 98 - 101)


don't need this. permissive bit above takes care of this.



docs/authorization.md (line 143)


s/register/register framework/
s/register/register framework/



docs/authorization.md (line 166)


s/register/register framework/
s/register/register framework/



docs/authorization.md (line 189)


s/register/register framework/
s/register/register framework/


- Vinod Kone


On Feb. 8, 2016, 6:40 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43199/
> ---
> 
> (Updated Feb. 8, 2016, 6:40 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization documentation.
> 
> Added information about the distinction between roles and principals, as well 
> as a real-world authorization example.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
> 
> Diff: https://reviews.apache.org/r/43199/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118328
---


Fix it, then Ship it!





docs/reservation.md (line 44)


not yours but can you s/This/That/ ?


- Vinod Kone


On Feb. 4, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 4, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/#review118340
---


Fix it, then Ship it!





src/tests/mesos.hpp (line 948)


looks like you forgot to pass "this" to this callback?


- Vinod Kone


On Feb. 9, 2016, 12:12 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41288/
> ---
> 
> (Updated Feb. 9, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a versioned callback interface for testing HTTP based 
> executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
> for Schedulers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 
> 
> Diff: https://reviews.apache.org/r/41288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/#review118341
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 9, 2016, 12:12 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43225/
> ---
> 
> (Updated Feb. 9, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds some gtest actions that can be used to subscribe/send status 
> updates using the executor library. These are in similar vein to the existing 
> actions like `SendStatusUpdateFromTask`.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 
> 
> Diff: https://reviews.apache.org/r/43225/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118343
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 9, 2016, 12:14 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> ---
> 
> (Updated Feb. 9, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing scheduler tests to use the new executor 
> HTTP library instead of the old driver based interface.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/41291/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review118342
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 9, 2016, 12:13 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> ---
> 
> (Updated Feb. 9, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the `TestContainerizer` class to handle HTTP based 
> executors. Previously, the containerizer test class only used to handle the 
> driver interface.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43344/#review118344
---



Patch looks great!

Reviews applied: [43344]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 11:43 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43344/
> ---
> 
> (Updated Feb. 8, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4622
> https://issues.apache.org/jira/browse/MESOS-4622
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added flag `--cgroups_net_cls_primary_handle`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43344/diff/
> 
> 
> Testing
> ---
> 
> Checked the rendering of configuration.md on locally generated docker-site.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>