date:20160218

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-18 Thread Timothy Chen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/
---

(Updated Feb. 18, 2016, 9:12 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3413
https://issues.apache.org/jira/browse/MESOS-3413


Repository: mesos


Description
---

Fixed persistent volumes with docker tasks.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
  src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 

Diff: https://reviews.apache.org/r/43015/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/
---

(Updated Feb. 18, 2016, 11:49 a.m.)


Review request for mesos and Neil Conway.


Changes
---

Added a new patch for support/generate-endpoint-help.py


Bugs: MESOS-4588
https://issues.apache.org/jira/browse/MESOS-4588


Repository: mesos


Description
---

Title for documentation webpages.


Diffs
-

  docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
  docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
  docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
  docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
  docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
  docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
  docs/committer-candidate-checklist.md 
fd55a398c836a30ba80203a64ba10fefe2cb9108 
  docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
  docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
  docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
  docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
  docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
  docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
  docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
  docs/engineering-principles-and-practices.md 
6babb929ead758ee5187d5fc5760d084876c3298 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
  docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
  docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
  docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
  docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
  docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
  docs/high-availability-framework-guide.md 
2576fa2a6e3021c34d643d3da7585fc6d95913c7 
  docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
  docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
  docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
  docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
  docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
  docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
  docs/networking-for-mesos-managed-containers.md 
f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
  docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
  docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
  docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
  docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
  docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
  docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
  docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
  docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
  docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
  docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
  docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
  docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
  docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
  docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
  docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
  docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
  docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
  docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
  docs/upgrades.md 0f05c7ccdf6453f16fe137cb68b74688679a8f0b 
  docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 

Diff: https://reviews.apache.org/r/43328/diff/


Testing
---

Tested with rake dev to see if the effects are coming in the live site.


Thanks,

Abhishek Dasgupta

Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Title for endpoint documentation.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/
---

Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Endpoint documents with title.


Diffs
-

  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 
77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 
6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md 
1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
  docs/endpoints/master/destroy-volumes.md 
7209a7cf788116a29eb6235d3a8a0225253c04f7 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 
82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md 
e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 
17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md 
a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586 
  docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 
5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md 
e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
  docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 

Diff: https://reviews.apache.org/r/43716/diff/


Testing
---

This patch includes all the endpoint documents with title generated from 
generated-endpoint-help.py file.
Tested on live site using "rake"


Thanks,

Abhishek Dasgupta

Re: Review Request 41865: Use full width for mesos div.container

2016-02-18 Thread Bernd Mathiske


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/#review119612
---



@mlunoe Is this change still needed, since the ticket has been closed given 
your patch?

- Bernd Mathiske


On Jan. 3, 2016, 7:08 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41865/
> ---
> 
> (Updated Jan. 3, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Michael Lunøe.
> 
> 
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use full width for mesos div.container
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-18 Thread Bernd Mathiske


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119615
---


Fix it, then Ship it!





src/tests/fetcher_cache_tests.cpp (line 190)


s/taks works, settling/tasks works and settling/


- Bernd Mathiske


On Feb. 17, 2016, 8:55 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 17, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36071: Add flow diagram for docker containerizer.

2016-02-18 Thread Bernd Mathiske



> On July 7, 2015, 4:51 a.m., Bernd Mathiske wrote:
> > 1. Inconsistent capitalization in box labels.
> > 2. You explain different paths to obtain an "executor pid" and then you 
> > checkpoint a "container pid". You lost me there.
> > 3. What happens to the tasks? Is this diagram for the executor only? If so, 
> > it is incomplete.
> 
> Bernd Mathiske wrote:
> Is this still being worked on?

@tnachen: Is this still being worked on?


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/#review90685
---


On July 6, 2015, 2:37 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36071/
> ---
> 
> (Updated July 6, 2015, 2:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add flow diagram for docker containerizer.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 
>   docs/images/docker_containerizer_flow.jpg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36071/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> File Attachments
> 
> 
> docker_containerizer_flow.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/07/06/d888a674-17d8-4faf-ab03-f1892537a6e5__docker_containerizer_flow.png
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41865: Use full width for mesos div.container

2016-02-18 Thread haosdent huang



> On 二月 18, 2016, 1:32 p.m., Bernd Mathiske wrote:
> > @mlunoe Is this change still needed, since the ticket has been closed given 
> > your patch?

don't need any more. Let me discard


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/#review119612
---


On 一月 3, 2016, 3:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41865/
> ---
> 
> (Updated 一月 3, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Michael Lunøe.
> 
> 
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use full width for mesos div.container
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-18 Thread Bernd Mathiske


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43271/#review119619
---




3rdparty/libprocess/src/subprocess.cpp (line 303)


I know which vars you mean here, but other readers won't know. I suggest to 
name them explicitly.



3rdparty/libprocess/src/subprocess.cpp (line 382)


Breaking out subprocess_environment but not the code below as a subroutine 
looks unbalanced. Why not factor the whole affair into a common subroutine 
together?

This routine may look like a filter function: env -> env.


- Bernd Mathiske


On Feb. 5, 2016, 3:25 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43271/
> ---
> 
> (Updated Feb. 5, 2016, 3:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Adds a helper method for getting the current environment plus 
> considerations for libprocess.
> * Changes the default behavior of `process::subprocess` to use the above 
> helper when given `environment = None()`.
> * Adds a warning inside `process::subprocess` if `LIBPROCESS_PORT` conflicts 
> with the current process's `LIBPROCESS_PORT`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43271/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> Tests are run in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 18, 2016, 2:52 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @tnachen's review.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 18, 2016, 2:54 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @bernd's comment.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

2016-02-18 Thread Abhishek Dasgupta



> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote:
> > I see you send TASK_KILLING once the killTask() is invoked. However, 
> > according to the description of MESOS-4140, we may need to send such status 
> > update after SIGTERM is sent to the task and before SIGKILL is sent. So 
> > maybe you should send TASK_KILLING in shutdown() instead?
> 
> Abhishek Dasgupta wrote:
> Okay, i see. but in the case of docker executor, TASK_KILLING should come 
> after docker stop. Does it sound good??

Actually, to set the status, we need to send the task_id also. Task_id is not 
available inside shutdown. Moreover, I don't think it will make any difference 
if it is called inside shutdown instead of killTask. It makes sense to change 
the status a TASK_KILLING as soon as killTask is issued.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
---


On Feb. 16, 2016, 10:23 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review119621
---



Patch looks great!

Reviews applied: [43715, 43328]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 11:49 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 18, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
>   docs/high-availability-framework-guide.md 
> 2576fa2a6e3021c34d643d3da7585fc6d95913c7 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/network-monitoring.md 08fcaa8ebc7313a4cf9a719ff1a9b11fcd926c7f 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 3a3e370695f6e5c0cb5be24d64eb885050296c0b 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md 2ce4b12b2a1eceb927206d7e7828bb3bbee49b52 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
>   docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>

Re: Review Request 41865: Use full width for mesos div.container

2016-02-18 Thread Michael Lunøe



> On Feb. 18, 2016, 1:32 p.m., Bernd Mathiske wrote:
> > @mlunoe Is this change still needed, since the ticket has been closed given 
> > your patch?
> 
> haosdent huang wrote:
> don't need any more. Let me discard

Nope, should be ok to discard (which I see is already done :) )


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/#review119612
---


On Jan. 3, 2016, 3:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41865/
> ---
> 
> (Updated Jan. 3, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Michael Lunøe.
> 
> 
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use full width for mesos div.container
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 18, 2016, 4:01 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119627
---



Patch looks great!

Reviews applied: [43715, 43716]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 11:56 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 11:56 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch includes all the endpoint documents with title generated from 
> generated-endpoint-help.py file.
>

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-18 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119623
---




src/slave/flags.cpp (line 693)


One space before `\n`, otherwise the word would be mixed with the first 
word of the next line.



src/slave/flags.cpp (line 694)


ditto



src/slave/slave.cpp (line 3709)


Instead of repeating the `if (flags.http_command_executor)...` logic 
multiple times, I would prefer use a temp variable to store either 
`mesos-executor` or `mesos-http-executor`.


- Shuai Lin


On Feb. 18, 2016, 1:09 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 18, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/
---

(Updated Feb. 18, 2016, 4:43 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4588
https://issues.apache.org/jira/browse/MESOS-4588


Repository: mesos


Description
---

Title for documentation webpages.


Diffs (updated)
-

  docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
  docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
  docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
  docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
  docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
  docs/committer-candidate-checklist.md 
fd55a398c836a30ba80203a64ba10fefe2cb9108 
  docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
  docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
  docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
  docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
  docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
  docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
  docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
  docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
  docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
  docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
  docs/engineering-principles-and-practices.md 
6babb929ead758ee5187d5fc5760d084876c3298 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
  docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
  docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
  docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
  docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
  docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
  docs/high-availability-framework-guide.md 
f21f95f24c0e9f3c4376b64e6a5776aafec39172 
  docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
  docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
  docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
  docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
  docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
  docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
  docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
  docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
  docs/networking-for-mesos-managed-containers.md 
f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
  docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
  docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
  docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
  docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
  docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
  docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
  docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
  docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
  docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
  docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
  docs/roles.md 84e5b7eaa4cf5cd3e7ebd6151928210be93d1d56 
  docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
  docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa 
  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
  docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
  docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
  docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
  docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 

Diff: https://reviews.apache.org/r/43328/diff/


Testing
---

Tested with rake dev to see if the effects are coming in the live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/
---

(Updated Feb. 18, 2016, 4:47 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4588
https://issues.apache.org/jira/browse/MESOS-4588


Repository: mesos


Description
---

Title for documentation webpages.


Diffs
-

  docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
  docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
  docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
  docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
  docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
  docs/committer-candidate-checklist.md 
fd55a398c836a30ba80203a64ba10fefe2cb9108 
  docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
  docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
  docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
  docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
  docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
  docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
  docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
  docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
  docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
  docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
  docs/engineering-principles-and-practices.md 
6babb929ead758ee5187d5fc5760d084876c3298 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
  docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
  docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
  docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
  docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
  docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
  docs/high-availability-framework-guide.md 
f21f95f24c0e9f3c4376b64e6a5776aafec39172 
  docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
  docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
  docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
  docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
  docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
  docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
  docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
  docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
  docs/networking-for-mesos-managed-containers.md 
f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
  docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
  docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
  docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
  docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
  docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
  docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
  docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
  docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
  docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
  docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
  docs/roles.md 84e5b7eaa4cf5cd3e7ebd6151928210be93d1d56 
  docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
  docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa 
  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
  docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
  docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
  docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
  docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 

Diff: https://reviews.apache.org/r/43328/diff/


Testing
---

Tested with rake dev to see if the effects are coming in the live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 18, 2016, 4:49 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Title for endpoint documentation.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119635
---



Patch looks great!

Reviews applied: [43608, 42696, 43367]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 2:54 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 18, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Neil Conway


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119637
---



Seems like this patch doesn't update a lot of the endpoint documentation files 
-- `slave/state.md`, `registrar/registry.md`, and others.


docs/endpoints/index.md (line 2)


Can we remove the space before the colon here, for consistency?

i.e.,

```
---
title: XYZ
layout: documentation
---
```


- Neil Conway


On Feb. 18, 2016, 11:56 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 11:56 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff:

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Cong Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119641
---




src/linux/fs.cpp (line 411)


Use os::read() which handles error nicely.



src/linux/fs.cpp (line 413)


Use tokenize("\n")


- Cong Wang


On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 18, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 38117: Added per container SNMP statistics.

2016-02-18 Thread Neil Conway


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review119643
---



Seems like this commit should have updated the `v1` version of `mesos.proto`.

- Neil Conway


On Feb. 11, 2016, 12:48 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> ---
> 
> (Updated Feb. 11, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per container SNMP statistics.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b26a058001dd8419b701a3cbea063a9d58b9 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> ebf820a2813eef32416f1465eff3f6eea153492f 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 1c2fbe934baabd1d816018de0c077bc9f63e9d33 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7 
>   src/tests/containerizer/port_mapping_tests.cpp 
> aa9846097feda1a82131b67aa4c782ec3625d049 
> 
> Diff: https://reviews.apache.org/r/38117/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics 
> --pid=
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review119645
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:31 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43700/
> ---
> 
> (Updated Feb. 18, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Fixed Find* scripts to not explode if invoked twice.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 
> 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 
> c975a16975e76b38f028d7575775abd31c9090f5 
> 
> Diff: https://reviews.apache.org/r/43700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43418/#review119648
---




src/CMakeLists.txt (line 219)


Is it intentional to drop slave/resource_estimator.cpp?


- Yi Sun


On Feb. 18, 2016, 1:01 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43418/
> ---
> 
> (Updated Feb. 18, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added slave/status_update_manager.cpp and other files.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
> 
> Diff: https://reviews.apache.org/r/43418/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43691/#review119650
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:24 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43691/
> ---
> 
> (Updated Feb. 18, 2016, 2:24 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[2/2] Fixed http-parser library directory for Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
> 
> Diff: https://reviews.apache.org/r/43691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-18 Thread Timothy Chen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/
---

(Updated Feb. 18, 2016, 6:16 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3413
https://issues.apache.org/jira/browse/MESOS-3413


Repository: mesos


Description
---

Fixed persistent volumes with docker tasks.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
  src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 

Diff: https://reviews.apache.org/r/43015/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43689/#review119653
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:29 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43689/
> ---
> 
> (Updated Feb. 18, 2016, 2:29 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3525
> https://issues.apache.org/jira/browse/MESOS-3525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Candidate compilation configuration finalization.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b 
> 
> Diff: https://reviews.apache.org/r/43689/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119656
---




3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake (line 105)


This seems like new. I suppose this is now needed.


- Yi Sun


On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> ---
> 
> (Updated Feb. 18, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/3] Move Stout configuration to its own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> a27cb98fa45cbd135ebfeca65e215fb3ff054739 
> 
> Diff: https://reviews.apache.org/r/43697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119657
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> ---
> 
> (Updated Feb. 18, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/3] Move Stout configuration to its own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> a27cb98fa45cbd135ebfeca65e215fb3ff054739 
> 
> Diff: https://reviews.apache.org/r/43697/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/#review119659
---




3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 53)


Does STOUT_DEPENDENCIES already contain PICOJSON_TARGET?



3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 70)


Already included in STOUT_INCLUDE_DIRS?


- Yi Sun


On Feb. 18, 2016, 4:34 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43698/
> ---
> 
> (Updated Feb. 18, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
> 
> Diff: https://reviews.apache.org/r/43698/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 18, 2016, 6:35 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Title for endpoint documentation.


Diffs (updated)
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 18, 2016, 6:36 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Title for endpoint documentation.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43699/#review119661
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 4:35 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43699/
> ---
> 
> (Updated Feb. 18, 2016, 4:35 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[3/3] Used Stout config script in agent build.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 
>   src/slave/cmake/SlaveConfigure.cmake 
> a8270a9ac6ceee4f370e185bee82126c309ec134 
> 
> Diff: https://reviews.apache.org/r/43699/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Abhishek Dasgupta



> On Feb. 18, 2016, 5:30 p.m., Neil Conway wrote:
> > Seems like this patch doesn't update a lot of the endpoint documentation 
> > files -- `slave/state.md`, `registrar/registry.md`, and others.

I don't quite understand this comment. As I see, those files are updated also! 
Can you mark the lines??


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119637
---


On Feb. 18, 2016, 11:56 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 11:56 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-18 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119636
---


Fix it, then Ship it!





src/slave/containerizer/docker.cpp (line 1746)


Fix the indentation here.



src/slave/containerizer/docker.cpp (lines 1856 - 1861)


Can you move that to `___destroy`?



src/tests/containerizer/docker_containerizer_tests.cpp (line 1447)


Kill this line here.


- Jie Yu


On Feb. 18, 2016, 6:16 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 18, 2016, 6:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/
---

(Updated Feb. 18, 2016, 6:38 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
---

Endpoint documents with title.


Diffs (updated)
-

  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 
77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 
6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md 
1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
  docs/endpoints/master/destroy-volumes.md 
7209a7cf788116a29eb6235d3a8a0225253c04f7 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 
82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md 
e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 
17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md 
a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586 
  docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 
5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md 
e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
  docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 

Diff: https://reviews.apache.org/r/43716/diff/


Testing
---

This patch includes all the endpoint documents with title generated from 
generated-endpoint-help.py file.
Tested on live site using "rake"


Thanks,

Abhishek Dasgupta

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43692/#review119665
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:26 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43692/
> ---
> 
> (Updated Feb. 18, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3525
> https://issues.apache.org/jira/browse/MESOS-3525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/zookeeper-06d3f3f.patch 8f8f72cb712c4bca328bf865ab082926106fbd94 
>   cmake/MesosConfigure.cmake 9a4fdb57e1281d9ec421e639819de5786c11744a 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
> 
> Diff: https://reviews.apache.org/r/43692/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43693/#review119666
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:27 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43693/
> ---
> 
> (Updated Feb. 18, 2016, 2:27 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3525
> https://issues.apache.org/jira/browse/MESOS-3525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[2/4] Transitioned ZK build to be 64-bit and static.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat 
> 8da05bcf8e6b2335770cff7c43218b823721d50c 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake 
> 632696e883e8ccb9bfa82288f62e7ad3771b043e 
> 
> Diff: https://reviews.apache.org/r/43693/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Neil Conway



> On Feb. 18, 2016, 5:30 p.m., Neil Conway wrote:
> > Seems like this patch doesn't update a lot of the endpoint documentation 
> > files -- `slave/state.md`, `registrar/registry.md`, and others.
> 
> Abhishek Dasgupta wrote:
> I don't quite understand this comment. As I see, those files are updated 
> also! Can you mark the lines??

My mistake! I misread the RR.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119637
---


On Feb. 18, 2016, 6:38 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff:

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119669
---




src/linux/fs.hpp (lines 350 - 351)


Can you move this to the top?



src/linux/fs.cpp (line 409)


Ditto on moving this to the top of this file.



src/linux/fs.cpp (lines 411 - 412)


Ditto on using os::read here.


- Jie Yu


On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 18, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review119667
---



The description of your commit whould not be identical to the summary.  If you 
don't have any additional information to add in the description, then just 
leave it blank.

Also, the summary should be worded as an action taken in the past tense. For 
example, the summary for this review could be changed to:

```Added a title to all documentation markdown files.```


docs/documentation-guide.md (line 2)


Remove the extra space between the words "Documentation" and "Guide"


- Kevin Klues


On Feb. 18, 2016, 4:48 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 18, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43694/#review119673
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43694/
> ---
> 
> (Updated Feb. 18, 2016, 2:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3525
> https://issues.apache.org/jira/browse/MESOS-3525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows:[3/4] Transitioned to static-everything builds on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
> 
> Diff: https://reviews.apache.org/r/43694/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

2016-02-18 Thread Yi Sun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43695/#review119674
---


Ship it!




Ship It!

- Yi Sun


On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43695/
> ---
> 
> (Updated Feb. 18, 2016, 2:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3525
> https://issues.apache.org/jira/browse/MESOS-3525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows:[4/4] Included Socket library for 64-bit builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> a27cb98fa45cbd135ebfeca65e215fb3ff054739 
> 
> Diff: https://reviews.apache.org/r/43695/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43712: Documented how the replicated log works.

2016-02-18 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43712/#review119679
---


Ship it!




Ship It!

- Jie Yu


On Feb. 18, 2016, 6:19 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43712/
> ---
> 
> (Updated Feb. 18, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-1471
> https://issues.apache.org/jira/browse/MESOS-1471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is closely based on an (unpublished) blog post by Jie Yu.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/images/log-architecture.png PRE-CREATION 
>   docs/images/log-cluster.png PRE-CREATION 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/replicated-log-internals.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43712/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Cong Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/
---

Review request for mesos, Ian Downes, Jie Yu, and Neil Conway.


Repository: mesos


Description
---

As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto 
too.


Diffs
-

  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/43730/diff/


Testing
---

make


Thanks,

Cong Wang

Re: Review Request 38117: Added per container SNMP statistics.

2016-02-18 Thread Cong Wang



> On Feb. 18, 2016, 5:49 p.m., Neil Conway wrote:
> > Seems like this commit should have updated the `v1` version of 
> > `mesos.proto`.
> 
> Ian Downes wrote:
> Ahh, you're probably right. @cwang could you please submit a fix.

Sure. https://reviews.apache.org/r/43730/


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review119643
---


On Feb. 11, 2016, 12:48 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> ---
> 
> (Updated Feb. 11, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per container SNMP statistics.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b26a058001dd8419b701a3cbea063a9d58b9 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> ebf820a2813eef32416f1465eff3f6eea153492f 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 1c2fbe934baabd1d816018de0c077bc9f63e9d33 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7 
>   src/tests/containerizer/port_mapping_tests.cpp 
> aa9846097feda1a82131b67aa4c782ec3625d049 
> 
> Diff: https://reviews.apache.org/r/38117/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics 
> --pid=
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Ian Downes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/#review119687
---


Ship it!




Ship It!

- Ian Downes


On Feb. 18, 2016, 11:15 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43730/
> ---
> 
> (Updated Feb. 18, 2016, 11:15 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto 
> too.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43730/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/
---

(Updated Feb. 18, 2016, 11:22 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

Rebase and address conflict with Subprocess Hooks/Options.


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

Delegates some of the environment logic in the containerizer and fetcher to the 
`subprocess_environment` helper.
Changes the logrotate container logger to use the default `environment` for 
`subprocess`.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.cpp 
cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0 
  src/slave/containerizer/containerizer.cpp 
59904684cdeb17ef2b42092a3558802c42bfb6bd 
  src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 

Diff: https://reviews.apache.org/r/43272/diff/


Testing
---

make check (OSX)


Thanks,

Joseph Wu

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43271/
---

(Updated Feb. 18, 2016, 11:22 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

Moved remaining environment processing from `subprocess` into 
`subprocess_environment`.  Expanded some comments.


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

* Adds a helper method for getting the current environment plus considerations 
for libprocess.
* Changes the default behavior of `process::subprocess` to use the above helper 
when given `environment = None()`.
* Adds a warning inside `process::subprocess` if `LIBPROCESS_PORT` conflicts 
with the current process's `LIBPROCESS_PORT`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 

Diff: https://reviews.apache.org/r/43271/diff/


Testing
---

make

Tests are run in the next review.


Thanks,

Joseph Wu

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119689
---




src/linux/fs.hpp (line 351)


Not sure how exactly this will be used later, but I would much prefer a 
less stringly-typed and more type-safe variant.

What about something like this?

enum class FileSystem { ext2, ext3, ext4 };

bool supported(FileSystem fileSystem);

This would minimize weird usage like the `notexistingfs` you have in your 
test.


- Benjamin Bannier


On Feb. 18, 2016, 5:01 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 18, 2016, 5:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Jie Yu



> On Feb. 18, 2016, 7:23 p.m., Benjamin Bannier wrote:
> > src/linux/fs.hpp, line 351
> > 
> >
> > Not sure how exactly this will be used later, but I would much prefer a 
> > less stringly-typed and more type-safe variant.
> > 
> > What about something like this?
> > 
> > enum class FileSystem { ext2, ext3, ext4 };
> > 
> > bool supported(FileSystem fileSystem);
> > 
> > This would minimize weird usage like the `notexistingfs` you have in 
> > your test.

One use case for that is: for overlayfs backend, we need to check if overlayfs 
is supported or not on the box.

in fact, i'm ok with the string type so that we don't have to list all 
potential fs type that we want to support. It's a simple utility function to 
see if an entry exists in /proc/filesystem. I would rather keeping it simple 
and not introducing the enum here.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119689
---


On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 18, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-18 Thread Ian Downes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/#review119701
---




src/slave/containerizer/docker.cpp (line 812)


Why not call update() here, rather than _update()? It will determine the 
correct pid, just launched in launchExecutorContainer().


- Ian Downes


On Dec. 15, 2015, 12:14 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33174/
> ---
> 
> (Updated Dec. 15, 2015, 12:14 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2617
> https://issues.apache.org/jira/browse/MESOS-2617
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for docker containerizer not configuring CFS quotas correctly.
> 
> It would be nice to refactor all this isolation code in a way that can be 
> shared between all containerizers, as this is basically just copied from the 
> CgroupsCpushareIsolator, but that's a much bigger undertaking.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/33174/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

2016-02-18 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
---

Fix it, then Ship it!

Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).

src/tests/master_maintenance_tests.cpp (lines 61 - 66)

Instead of importing these default constants, use 
`SlaveFlags::executor_shutdown_grace_period` and 
`MasterFlags::allocation_interval`.

You'll need to slightly modify the `StartMaster` and `StartSlave` calls.

i.e.
```
  // NOTE: We don't use `StartMaster()` because we need to access these 
flags.
  master::Flags flags = CreateMasterFlags();
```

src/tests/master_maintenance_tests.cpp (line 693)

Once you change the above, this will look like 
`Clock::advance(slaveFlags.executor_shutdown_grace_period);`.

- Joseph Wu

On Feb. 11, 2016, 10:41 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> ---
> 
> (Updated Feb. 11, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review119700
---


Fix it, then Ship it!




Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).


src/tests/master_maintenance_tests.cpp (line 1218)


Use the `MasterFlags::allocation_interval` here instead of a default 
constant.  (See comment in previous review.)



src/tests/master_maintenance_tests.cpp (line 1273)


Ditto here.


- Joseph Wu


On Feb. 11, 2016, 10:41 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 11, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119703
---



Patch looks great!

Reviews applied: [43718]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 18, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-18 Thread Ian Downes



> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote:
> > src/slave/containerizer/docker.cpp, line 838
> > 
> >
> > Docker supports specifying the CFS period and quota to run a container 
> > with these flags {{--cpu-period=0}} and {{--cpu-quota=0}}. The correct 
> > solution is to set these using Docker itself when it runs the container. 
> > Subsequent updates will be done by Mesos in the update() call, as below in 
> > this review.

Please add a TODO for this.


> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote:
> > src/slave/containerizer/docker.cpp, line 976
> > 
> >
> > To reiterate my earlier comment: 
> > 1) We don't support changing the cfs period so it only needs to be set 
> > once, additional writes are unnecessary but aren't a problem. The 
> > MesosContainerizer isolator just writes it on every update rather than 
> > determining if it has already written it before. 
> > 2) The cfs quota changes depending on the CPU resource value so it 
> > definitely does need to be re-written at every update. Again, this is a 
> > straight copy-and-paste from the MC cpu isolator.
> > 
> > This part of the code looks fine to me. @Tim, do you concur?

@tnachen?


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/#review110547
---


On Dec. 15, 2015, 12:14 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33174/
> ---
> 
> (Updated Dec. 15, 2015, 12:14 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2617
> https://issues.apache.org/jira/browse/MESOS-2617
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for docker containerizer not configuring CFS quotas correctly.
> 
> It would be nice to refactor all this isolation code in a way that can be 
> shared between all containerizers, as this is basically just copied from the 
> CgroupsCpushareIsolator, but that's a much bigger undertaking.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/33174/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119678
---



A commit addressing all my comments can be seen here:

https://github.com/klueska-mesosphere/mesos/commit/23f571376ff6dfffaf1a09a0d8081da1d323a2f3

Feel free to simply apply it and push it out for review again if you agree with 
everything.


support/generate-endpoint-help.py (lines 47 - 53)


I would rewrite this as:

```
MARKDOWN_HEADER = (
"""

---
title: %s
layout: documentation
---
"""
)
```

(Notice the %s in there...)

Then modify how this is used down below (as demonstrated in a follow up 
comment)



support/generate-endpoint-help.py (line 56)


We should add a new global here:

```
MARKDOWN_TITLE = "Mesos - HTTP Endpoints%s"
```

where we can fill in the %s on a per call-site basis.



support/generate-endpoint-help.py (line 178)


I would rename this field from `name` to `title` and then use it as 
described in a comment below.

It should also not take a default value of "".



support/generate-endpoint-help.py (lines 187 - 190)


This should no longer be necessary, given the previous comments and the 
ones to follow.



support/generate-endpoint-help.py (lines 194 - 199)


This should be simplified to:

```
output = (MARKDOWN_HEADER % title) + '\n' + output.rstrip()
```



support/generate-endpoint-help.py (lines 217 - 218)


While we are fixing things, we should remove this extra newline here at the 
beginning:

"""
# HTTP Endpoints #

should become:

"""# HTTP Endpoints #



support/generate-endpoint-help.py (line 283)


Here we should change this to:

```
write_markdown(path, output, MARKDOWN_TITLE % "")
```



support/generate-endpoint-help.py (lines 296 - 300)


here we should add an extra variable title as:
```
title = get_endpoint_path(id, name)
```

And then change the `write_markdown()` line to:

```
write_markdown(path, text, MARKDOWN_TITLE_TEMPLATE % (" - " + title))
```


- Kevin Klues


On Feb. 18, 2016, 6:36 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> ---
> 
> (Updated Feb. 18, 2016, 6:36 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> ---
> 
> This is the patch for support/generate-endpoint-help.py to include the 
> generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119708
---



See my comments on https://reviews.apache.org/r/43715

These files hould all be autogenerated from the updates to these scripts.

The biggest change being the change in the title to the endpoint pages.
i.e. for example
from: "Mesos - HTTP Endpoints - state.md"
to: "Mesos - HTTP Endpoints - /master/state"

The documentation is about the endpoint, not the md file.

- Kevin Klues


On Feb. 18, 2016, 6:38 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff:

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-18 Thread Mark Cavage


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/
---

(Updated Feb. 18, 2016, 7:51 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Apparently patch needed to be rebased, again, as reviewbot didn't like it. This 
all builds fine locally.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

MasterContender/MasterDetector loadable as modules.


Diffs (updated)
-

  include/mesos/master/contender.hpp PRE-CREATION 
  include/mesos/master/detector.hpp PRE-CREATION 
  include/mesos/module/contender.hpp PRE-CREATION 
  include/mesos/module/detector.hpp PRE-CREATION 
  include/mesos/scheduler.hpp 14c7ff9 
  src/Makefile.am 54ebe91 
  src/cli/resolve.cpp 257e290 
  src/examples/test_contender_module.cpp PRE-CREATION 
  src/examples/test_detector_module.cpp PRE-CREATION 
  src/local/local.cpp 359fc54 
  src/master/contender.hpp 3fd20f8 
  src/master/contender.cpp 9ad49ce 
  src/master/detector.hpp eb5d2a9 
  src/master/detector.cpp 9274435 
  src/master/main.cpp 4263110 
  src/master/master.hpp 2f2ad2a 
  src/master/master.cpp e1ca81d 
  src/module/manager.cpp 6ae9950 
  src/sched/sched.cpp 525255e 
  src/scheduler/scheduler.cpp 99a7d0d 
  src/slave/main.cpp e3a4d13 
  src/slave/slave.hpp ced835d 
  src/tests/authentication_tests.cpp 85f14c3 
  src/tests/cluster.hpp 99a785a 
  src/tests/cluster.cpp 084fb1c 
  src/tests/fault_tolerance_tests.cpp 982468f 
  src/tests/master_allocator_tests.cpp cba7c36 
  src/tests/master_authorization_tests.cpp 29c89fb 
  src/tests/master_contender_detector_tests.cpp 255ab81 
  src/tests/master_slave_reconciliation_tests.cpp d41178e 
  src/tests/master_tests.cpp 393a6f5f 
  src/tests/module.hpp 4b32f29 
  src/tests/module.cpp 8cc305c 
  src/tests/oversubscription_tests.cpp d4ae819 
  src/tests/partition_tests.cpp c5badbe 
  src/tests/persistent_volume_tests.cpp e169e1b 
  src/tests/reconciliation_tests.cpp 97112c4 
  src/tests/reservation_tests.cpp d2ef159 
  src/tests/scheduler_event_call_tests.cpp bd8920f 
  src/tests/scheduler_http_api_tests.cpp 9eb1de7 
  src/tests/slave_recovery_tests.cpp e2a78a0 
  src/tests/slave_tests.cpp c7f5a70 

Diff: https://reviews.apache.org/r/43269/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Mark Cavage

Re: Review Request 43384: Improved error handling in generate-endpoint-help script.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review119710
---




support/generate-endpoint-help.py (lines 295 - 299)


I would exclude this.

The stack trace should be more informative about what actually went wrong.



support/generate-endpoint-help.py (lines 313 - 317)


I would exclude this.

The stack trace should be more informative about what actually went wrong.



support/generate-endpoint-help.py (lines 324 - 332)


This is clearly a bug and should be fixed as you have done.


- Kevin Klues


On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> ---
> 
> (Updated Feb. 9, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Two problems:
> 
>   (1) If the script exited when `current_subprocess` is None, it
>   would print an ugly exception stack trace.
> 
>   (2) If starting the Mesos master or agent failed, it would print
>   an ugly exception stack trace.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43384/diff/
> 
> 
> Testing
> ---
> 
> Ran the script in error and non-error cases with the changes applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43715: Title for endpoint documentation.

2016-02-18 Thread Abhishek Dasgupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
---

(Updated Feb. 18, 2016, 8:32 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Changes
---

Please stop making a cyclical dependency.


Repository: mesos


Description
---

Title for endpoint documentation.


Diffs
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
---

This is the patch for support/generate-endpoint-help.py to include the 
generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-18 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/#review119715
---

Can you split up this patch into the following groups?  (Its ok to run the 
tests at the end of a review chain, just add a note in the "Testing Done" 
section.)

* Interfaces for the new module.
* Modularization boilerplate (i.e. include/mesos/module/*, makefile changes, 
test modules, src/module/manager.cpp)
* The refactoring changes (i.e. src/master/contender.* src/master/detector.*)
* All the trivial header/namespace changes.

---

A general question:

* Does it make sense to have a separate `Contender` and `Detector` module?  Or 
just one `LeaderElection` module?  (One argument for separate modules is that 
the Mesos Agent only uses the `Detector`.)

include/mesos/master/contender.hpp (lines 41 - 47)

For a module, specifying the "mechanism" here doesn't make much sense.  It 
should expect the type of module (i.e. `"org_apache_mesos_TestContender"`).

Same for the Detector.

---

To retain backwards compatibility with the master flag `--zk` and agent 
flag `--master`, it may be appropriate to pass both the module type and the 
mechanism as arguments.

include/mesos/master/contender.hpp (line 69)

Nit: s/> >/>>/

include/mesos/master/detector.hpp (line 60)

Nit: s/> >/>>/

src/master/detector.cpp (lines 204 - 205)

Consider breaking apart the logic here into separate modules.

* The default behavior (no module specified, no ZK string) is to create a 
`StandaloneMasterDetector`.
* When the ZK string is specified, you should create a 
`ZooKeeperMasterDetector` with that ZK string.
* Otherwise, load the module.

---

You may even want to consider breaking the Zookeeper logic into an actual 
module (which would be loaded by default when required).  This would serve as 
the "example" module that we usually provide when modularizing anything.

- Joseph Wu

On Feb. 18, 2016, 11:51 a.m., Mark Cavage wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43269/
> ---
> 
> (Updated Feb. 18, 2016, 11:51 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender/MasterDetector loadable as modules.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
>   include/mesos/module/contender.hpp PRE-CREATION 
>   include/mesos/module/detector.hpp PRE-CREATION 
>   include/mesos/scheduler.hpp 14c7ff9 
>   src/Makefile.am 54ebe91 
>   src/cli/resolve.cpp 257e290 
>   src/examples/test_contender_module.cpp PRE-CREATION 
>   src/examples/test_detector_module.cpp PRE-CREATION 
>   src/local/local.cpp 359fc54 
>   src/master/contender.hpp 3fd20f8 
>   src/master/contender.cpp 9ad49ce 
>   src/master/detector.hpp eb5d2a9 
>   src/master/detector.cpp 9274435 
>   src/master/main.cpp 4263110 
>   src/master/master.hpp 2f2ad2a 
>   src/master/master.cpp e1ca81d 
>   src/module/manager.cpp 6ae9950 
>   src/sched/sched.cpp 525255e 
>   src/scheduler/scheduler.cpp 99a7d0d 
>   src/slave/main.cpp e3a4d13 
>   src/slave/slave.hpp ced835d 
>   src/tests/authentication_tests.cpp 85f14c3 
>   src/tests/cluster.hpp 99a785a 
>   src/tests/cluster.cpp 084fb1c 
>   src/tests/fault_tolerance_tests.cpp 982468f 
>   src/tests/master_allocator_tests.cpp cba7c36 
>   src/tests/master_authorization_tests.cpp 29c89fb 
>   src/tests/master_contender_detector_tests.cpp 255ab81 
>   src/tests/master_slave_reconciliation_tests.cpp d41178e 
>   src/tests/master_tests.cpp 393a6f5f 
>   src/tests/module.hpp 4b32f29 
>   src/tests/module.cpp 8cc305c 
>   src/tests/oversubscription_tests.cpp d4ae819 
>   src/tests/partition_tests.cpp c5badbe 
>   src/tests/persistent_volume_tests.cpp e169e1b 
>   src/tests/reconciliation_tests.cpp 97112c4 
>   src/tests/reservation_tests.cpp d2ef159 
>   src/tests/scheduler_event_call_tests.cpp bd8920f 
>   src/tests/scheduler_http_api_tests.cpp 9eb1de7 
>   src/tests/slave_recovery_tests.cpp e2a78a0 
>   src/tests/slave_tests.cpp c7f5a70 
> 
> Diff: https://reviews.apache.org/r/43269/diff/
> 
> 
> Testing
> ---
> 
> In addition to all unit tests passing, we are currently using this 
> functionality in our environment with a custom consensus stack. In our world, 
> we have a C++ plugin that calls out to an HTTP REST

Review Request 43737: Fixed typo in fetcher docs.

2016-02-18 Thread Neil Conway


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43737/
---

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
---

Fixed typo in fetcher docs.


Diffs
-

  docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 

Diff: https://reviews.apache.org/r/43737/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 43328: Title for documentation webpages.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review119721
---



Patch looks great!

Reviews applied: [43715, 43328]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 4:48 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 18, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 84e5b7eaa4cf5cd3e7ebd6151928210be93d1d56 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa 
>   docs/slave-recovery.md

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/#review119731
---



Patch looks great!

Reviews applied: [38117, 43730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 7:15 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43730/
> ---
> 
> (Updated Feb. 18, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto 
> too.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43730/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 42516: Add support for user-defined networks.

2016-02-18 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119730
---

include/mesos/v1/mesos.proto (lines 1543 - 1544)

We're going to introduce a ContainerInfo.NetworkInfo.name to allow 
frameworks to specify the network they want to join. Note that  NetworkInfo in 
ContainerInfo is repeated which allows us to express the situation where a 
container wants to join multiple networks.

As we did for ContainerInfo.volumes, I think command configurations for a 
container should go to top level. This also avoids the confusion that 
'network_name' is set in DockerInfo while there's another NetworkInfo.name.

I think what I am proposing is that: we add a NetworkInfo.name, and if 
DOckerInfo.network is not set and NetworkInfo.name is set, the docker 
containerizer will do --net=.

- Jie Yu

On Feb. 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/
---

Review request for mesos and James Peach.


Bugs: MESOS-4714
https://issues.apache.org/jira/browse/MESOS-4714


Repository: mesos


Description
---

The install-data-hook was missing the '$(DESTDIR)' prefix.


Diffs
-

  src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 

Diff: https://reviews.apache.org/r/43741/diff/


Testing
---

Ran `make install DESTDIR=/tmp` with and without the patch.


Thanks,

Kapil Arya

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119732
---


Ship it!




Good catch.

- James Peach


On Feb. 18, 2016, 10:48 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> ---
> 
> (Updated Feb. 18, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The install-data-hook was missing the '$(DESTDIR)' prefix.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
> 
> Diff: https://reviews.apache.org/r/43741/diff/
> 
> 
> Testing
> ---
> 
> Ran `make install DESTDIR=/tmp` with and without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/
---

(Updated Feb. 18, 2016, 5:49 p.m.)


Review request for mesos and James Peach.


Bugs: MESOS-4714
https://issues.apache.org/jira/browse/MESOS-4714


Repository: mesos


Description
---

The install-data-hook was missing the '$(DESTDIR)' prefix.


Diffs (updated)
-

  src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 

Diff: https://reviews.apache.org/r/43741/diff/


Testing
---

Ran `make install DESTDIR=/tmp` with and without the patch.


Thanks,

Kapil Arya

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119734
---


Ship it!




Ship It!

- Anand Mazumdar


On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> ---
> 
> (Updated Feb. 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The install-data-hook was missing the '$(DESTDIR)' prefix.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
> 
> Diff: https://reviews.apache.org/r/43741/diff/
> 
> 
> Testing
> ---
> 
> Ran `make install DESTDIR=/tmp` with and without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Joris Van Remoortere


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119736
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> ---
> 
> (Updated Feb. 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The install-data-hook was missing the '$(DESTDIR)' prefix.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
> 
> Diff: https://reviews.apache.org/r/43741/diff/
> 
> 
> Testing
> ---
> 
> Ran `make install DESTDIR=/tmp` with and without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43741: Fixed symlink generation for DESTDIR installs.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119737
---


Ship it!




Ship It!

- Kevin Klues


On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> ---
> 
> (Updated Feb. 18, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The install-data-hook was missing the '$(DESTDIR)' prefix.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
> 
> Diff: https://reviews.apache.org/r/43741/diff/
> 
> 
> Testing
> ---
> 
> Ran `make install DESTDIR=/tmp` with and without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43260/
---

(Updated Feb. 18, 2016, 10:58 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

Temporrarily setting "depends_on" field for testing reviewbot. -- @vinodkone.


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

This will allow us to add flags of type `net::IP`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
295eac77d5aba4084bbc044d94f45d660410d725 

Diff: https://reviews.apache.org/r/43260/diff/


Testing
---

make

Tests are run in the next review.


Thanks,

Joseph Wu

Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43260/
---

(Updated Feb. 18, 2016, 11:07 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

fix depends on field. -- @vinodkone


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

This will allow us to add flags of type `net::IP`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
295eac77d5aba4084bbc044d94f45d660410d725 

Diff: https://reviews.apache.org/r/43260/diff/


Testing
---

make

Tests are run in the next review.


Thanks,

Joseph Wu

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
---

(Updated Feb. 18, 2016, 11:08 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

testing depends on. -- @vinodkone


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, 
`ADVERTISE_PORT`) into a Flags object along with the validation logic for 
ports.  Help strings of the flags are synced with the docs in configuration.md.


Diffs
-

  3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7 

Diff: https://reviews.apache.org/r/43261/diff/


Testing
---

make check (OSX)


Thanks,

Joseph Wu

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
---

(Updated Feb. 18, 2016, 11:08 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, 
`ADVERTISE_PORT`) into a Flags object along with the validation logic for 
ports.  Help strings of the flags are synced with the docs in configuration.md.


Diffs
-

  3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7 

Diff: https://reviews.apache.org/r/43261/diff/


Testing
---

make check (OSX)


Thanks,

Joseph Wu

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

2016-02-18 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43261/
---

(Updated Feb. 18, 2016, 11:09 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
---

Moves the environment variables `LIBPROCESS_` + (`IP`, `ADVERTISE_IP`, `PORT`, 
`ADVERTISE_PORT`) into a Flags object along with the validation logic for 
ports.  Help strings of the flags are synced with the docs in configuration.md.


Diffs
-

  3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7 

Diff: https://reviews.apache.org/r/43261/diff/


Testing
---

make check (OSX)


Thanks,

Joseph Wu

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-18 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/#review119738
---




src/slave/containerizer/docker.cpp (line 785)


Do you need to call update for this case (command task but agent is not 
running in a docker container)?



src/slave/containerizer/docker.cpp (lines 811 - 815)


This is done after the container has been launched. We should definitely 
call out the fact that there's a short window after the container has been 
launched before the container's cfs quota is updated. During that window, it's 
not subject to cfs throttling.

Alternatively, we could set `--cpu-period` and `--cpu-quota` during launch 
so that we don't have to worry about that window.



src/slave/containerizer/docker.cpp (line 812)


Ditto on using 'update()' here.



src/slave/containerizer/docker.cpp (lines 1131 - 1133)


Nits on style:
```
write = cgroups::cpu::cfs_period_us(
cpuHierarchy.get(),
cpuCgroup.get(),
CPU_CFS_PERIOD);

  
```



src/slave/containerizer/docker.cpp (lines 1142 - 1144)


Ditto on style:

```
write = cgroups::cpu::cfs_quota_us(
cpuHierarchy.get(),
cpuCgroup.get(),
quota);
```


- Jie Yu


On Dec. 15, 2015, 8:14 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33174/
> ---
> 
> (Updated Dec. 15, 2015, 8:14 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2617
> https://issues.apache.org/jira/browse/MESOS-2617
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix for docker containerizer not configuring CFS quotas correctly.
> 
> It would be nice to refactor all this isolation code in a way that can be 
> shared between all containerizers, as this is basically just copied from the 
> CgroupsCpushareIsolator, but that's a much bigger undertaking.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/33174/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

2016-02-18 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43746/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Ensure the test does not finish before offer rescinds have been
processed by the scheduler.


Diffs
-

  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 

Diff: https://reviews.apache.org/r/43746/diff/


Testing
---

On Mac OS 10.10.4:
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh 
--gtest_repeat=1000 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov

Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

2016-02-18 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43747/
---

Review request for mesos, Joris Van Remoortere and Kevin Klues.


Bugs: MESOS-4713
https://issues.apache.org/jira/browse/MESOS-4713


Repository: mesos


Description
---

Fixed ReviewBot to catch circular dependencies in review requests.


Diffs
-

  support/verify_reviews.py f0b9996b04e29e5d70ff57784c46d00e5ec4e45c 

Diff: https://reviews.apache.org/r/43747/diff/


Testing
---

Tested locally with a circular dep.

?  mesos git:(vinod/reviewbot_recursive) BUILD_URL=foo 
./support/verify_reviews.py kone vinod 1 
"?to-groups=mesos=pending=2"
git rev-parse HEAD
Checking if review: 43418 needs verification
Skipping blocking review 43418
Checking if review: 43691 needs verification
Skipping blocking review 43691
Checking if review: 43689 needs verification
Skipping blocking review 43689
Checking if review: 43697 needs verification
Skipping blocking review 43697
Checking if review: 43698 needs verification
Skipping blocking review 43698
Checking if review: 43699 needs verification
Skipping blocking review 43699
Checking if review: 43692 needs verification
Skipping blocking review 43692
Checking if review: 43693 needs verification
Skipping blocking review 43693
Checking if review: 43694 needs verification
Skipping blocking review 43694
Checking if review: 43695 needs verification
Skipping blocking review 43695
Checking if review: 43271 needs verification
Skipping blocking review 43271
Checking if review: 43272 needs verification
Latest diff timestamp: 2016-02-18 19:19:48
Verifying review 43272
Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
Dependent review: https://reviews.apache.org/api/review-requests/43261/ 
Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
Posting review: Bad review!

Reviews applied: [43272, 43271, 43261]

Error:
Circular dependency detected for review 43271.Please fix the 'depends_on' field.
Error handling URL 
https://reviews.apache.org/api/review-requests/43272/reviews/: UNAUTHORIZED 
({"stat": "fail", "err": {"msg": "The username or password was not correct", 
"code": 104}})
git clean -fd
git reset --hard fb779576521abc35d99f2b8834684f3a8f020895


Thanks,

Vinod Kone

Re: Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

2016-02-18 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43747/#review119759
---


Fix it, then Ship it!




If we wren't using reviewboard (which I find overly cumbersome sometimes), I 
would probably have split this into two commits.  One for the logic change 
(throwing an error), and one for the variable name change (applied->reviews). 
It's probably a little much for something this small though.


support/verify_reviews.py (lines 83 - 94)


I would move the error check for the reviewers first, so that the circular 
dependency check can be grouped with adding the current request to the reviews 
list. I would even put an else to make it more clear what's going on (even 
though it's technically not necessary). i.e.:

```
# If there is a circular dependency throw an error.`
if review_request["id"] in reviews:
raise ReviewError("Circular dependency detected for review %s."
  "Please fix the 'depends_on' field."
  % review_request["id"])
else:
reviews.append(review_request["id"])
```



support/verify_reviews.py (lines 89 - 91)


I would move this as the first error case. I would also add a comment for 
consistency.


- Kevin Klues


On Feb. 19, 2016, 12:38 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43747/
> ---
> 
> (Updated Feb. 19, 2016, 12:38 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kevin Klues.
> 
> 
> Bugs: MESOS-4713
> https://issues.apache.org/jira/browse/MESOS-4713
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed ReviewBot to catch circular dependencies in review requests.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py f0b9996b04e29e5d70ff57784c46d00e5ec4e45c 
> 
> Diff: https://reviews.apache.org/r/43747/diff/
> 
> 
> Testing
> ---
> 
> Tested locally with a circular dep.
> 
> ?  mesos git:(vinod/reviewbot_recursive) BUILD_URL=foo 
> ./support/verify_reviews.py kone vinod 1 
> "?to-groups=mesos=pending=2"
> git rev-parse HEAD
> Checking if review: 43418 needs verification
> Skipping blocking review 43418
> Checking if review: 43691 needs verification
> Skipping blocking review 43691
> Checking if review: 43689 needs verification
> Skipping blocking review 43689
> Checking if review: 43697 needs verification
> Skipping blocking review 43697
> Checking if review: 43698 needs verification
> Skipping blocking review 43698
> Checking if review: 43699 needs verification
> Skipping blocking review 43699
> Checking if review: 43692 needs verification
> Skipping blocking review 43692
> Checking if review: 43693 needs verification
> Skipping blocking review 43693
> Checking if review: 43694 needs verification
> Skipping blocking review 43694
> Checking if review: 43695 needs verification
> Skipping blocking review 43695
> Checking if review: 43271 needs verification
> Skipping blocking review 43271
> Checking if review: 43272 needs verification
> Latest diff timestamp: 2016-02-18 19:19:48
> Verifying review 43272
> Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
> Dependent review: https://reviews.apache.org/api/review-requests/43261/ 
> Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
> Posting review: Bad review!
> 
> Reviews applied: [43272, 43271, 43261]
> 
> Error:
> Circular dependency detected for review 43271.Please fix the 'depends_on' 
> field.
> Error handling URL 
> https://reviews.apache.org/api/review-requests/43272/reviews/: UNAUTHORIZED 
> ({"stat": "fail", "err": {"msg": "The username or password was not correct", 
> "code": 104}})
> git clean -fd
> git reset --hard fb779576521abc35d99f2b8834684f3a8f020895
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43747: Fixed ReviewBot to catch circular dependencies in review requests.

2016-02-18 Thread Kevin Klues



> On Feb. 19, 2016, 1:16 a.m., Kevin Klues wrote:
> > If we wren't using reviewboard (which I find overly cumbersome sometimes), 
> > I would probably have split this into two commits.  One for the logic 
> > change (throwing an error), and one for the variable name change 
> > (applied->reviews). It's probably a little much for something this small 
> > though.

Diff here of applied changes from the review:
https://github.com/klueska-mesosphere/mesos/commit/ca1ca4a53bbd311d2a73a7ccdcca21f03147bbc5


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43747/#review119759
---


On Feb. 19, 2016, 12:38 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43747/
> ---
> 
> (Updated Feb. 19, 2016, 12:38 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kevin Klues.
> 
> 
> Bugs: MESOS-4713
> https://issues.apache.org/jira/browse/MESOS-4713
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed ReviewBot to catch circular dependencies in review requests.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py f0b9996b04e29e5d70ff57784c46d00e5ec4e45c 
> 
> Diff: https://reviews.apache.org/r/43747/diff/
> 
> 
> Testing
> ---
> 
> Tested locally with a circular dep.
> 
> ?  mesos git:(vinod/reviewbot_recursive) BUILD_URL=foo 
> ./support/verify_reviews.py kone vinod 1 
> "?to-groups=mesos=pending=2"
> git rev-parse HEAD
> Checking if review: 43418 needs verification
> Skipping blocking review 43418
> Checking if review: 43691 needs verification
> Skipping blocking review 43691
> Checking if review: 43689 needs verification
> Skipping blocking review 43689
> Checking if review: 43697 needs verification
> Skipping blocking review 43697
> Checking if review: 43698 needs verification
> Skipping blocking review 43698
> Checking if review: 43699 needs verification
> Skipping blocking review 43699
> Checking if review: 43692 needs verification
> Skipping blocking review 43692
> Checking if review: 43693 needs verification
> Skipping blocking review 43693
> Checking if review: 43694 needs verification
> Skipping blocking review 43694
> Checking if review: 43695 needs verification
> Skipping blocking review 43695
> Checking if review: 43271 needs verification
> Skipping blocking review 43271
> Checking if review: 43272 needs verification
> Latest diff timestamp: 2016-02-18 19:19:48
> Verifying review 43272
> Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
> Dependent review: https://reviews.apache.org/api/review-requests/43261/ 
> Dependent review: https://reviews.apache.org/api/review-requests/43271/ 
> Posting review: Bad review!
> 
> Reviews applied: [43272, 43271, 43261]
> 
> Error:
> Circular dependency detected for review 43271.Please fix the 'depends_on' 
> field.
> Error handling URL 
> https://reviews.apache.org/api/review-requests/43272/reviews/: UNAUTHORIZED 
> ({"stat": "fail", "err": {"msg": "The username or password was not correct", 
> "code": 104}})
> git clean -fd
> git reset --hard fb779576521abc35d99f2b8834684f3a8f020895
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43716: Endpoint documents with title.

2016-02-18 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review119763
---



Patch looks great!

Reviews applied: [43715, 43716]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 6:38 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 18, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch includes all the endpoint documents with title generated from 
> generated-endpoint-help.py file.
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/
---

(Updated Feb. 19, 2016, 1:45 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Address @kaysoky's comments.


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.InverseOffers.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43519/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
---

(Updated Feb. 19, 2016, 1:44 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Address @kaysoky's comments.


Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.EnterMaintenanceMode.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 
7eed0f3d08cd52a07c46b6ad194496186ac205b7 
  3rdparty/libprocess/include/process/gmock.hpp 
15b982f101994ce717ceeb29a1bd0028bd2ba940 
  3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
  3rdparty/libprocess/src/tests/http_tests.cpp 
4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a 
  CHANGELOG 004978fffe221e2f430f3f5517dc31d692ad23a5 
  configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
  docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
  docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
  docs/endpoints/master/create-volumes.md 
1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
  docs/endpoints/master/destroy-volumes.md 
7209a7cf788116a29eb6235d3a8a0225253c04f7 
  docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
  docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586 
  docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
  docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
  docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
  docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
  docs/high-availability-framework-guide.md 
0d9c483985d61b512339f50f395f9360de034e2d 
  docs/home.md 07214b927c112d7a180507ae03245892455fd757 
  docs/images/log-architecture.png 34c57f19387868486882e6fa8bd5d2362113c952 
  docs/images/log-cluster.png 62042d2811dd21bd7b7301f140a9d474c4e8fd07 
  docs/maintenance.md 4d24ec680f3245b12b99e4bb6440ae5aab473460 
  docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
  docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
  docs/operational-guide.md a4d6710a8a3a4cde10fdccad332e3d539246ec83 
  docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
  docs/replicated-log-internals.md 4f379a3ff4e957a486fa13d721f4b66333aea6b3 
  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7 
  include/mesos/mesos.proto 804794642d7d8a7df2ce3829f2f9b332a080a9ce 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
  src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
  src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
  src/common/command_utils.cpp 3f1d7f3694a1688ec7c035234e99f2f823bddaee 
  src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
  src/linux/systemd.hpp 6b240b9cc2fe559d111a4235e70f00e07f3d4495 
  src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 
  src/master/http.cpp 248e3d432a756c767fc00ee224101d82c417068c 
  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/slave/containerizer/mesos/containerizer.hpp 
3ef6a6752a6656e97be9f48bd4d2d060d1f9cb46 
  src/slave/containerizer/mesos/containerizer.cpp 
129406abdff715e321f683911e404c46676b6daf 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
134b6c759b769cf335539e49eff817973c7f96a4 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp 
373c7d4c0c7c4e35ca568f37e52915549798ee32 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 
e12a6f27866b6362191ea4dafe8bf818b33cd9e3 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
811c24b43f7aec9db406dd521770c6cd82097c92 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
c980e445742d7e219ca7436b179af9d1ac93fff9 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 
f57f42f1a223f3125b5f0da6bad3effa182dba9e 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 
c93c7a92ec152bd9747a70392adfe6a0e863e839

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/
---

(Updated Feb. 19, 2016, 1:46 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Rebase


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.InverseOffers.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43519/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

2016-02-18 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
---

(Updated Feb. 19, 2016, 1:46 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Rebase


Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.EnterMaintenanceMode.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43518/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

2016-02-18 Thread haosdent huang



> On Feb. 18, 2016, 7:34 p.m., Joseph Wu wrote:
> > Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).

Thank you very much for you review, could you help check it again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
---


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43569: Updated log message if container not found.

2016-02-18 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43569/
---

(Updated 二月 19, 2016, 1:52 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated log message if container not found.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
  src/slave/containerizer/mesos/containerizer.cpp 
129406abdff715e321f683911e404c46676b6daf 

Diff: https://reviews.apache.org/r/43569/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 19, 2016, 2:02 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Address review comments


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

2016-02-18 Thread Shuai Lin



> On Feb. 18, 2016, 7:23 p.m., Benjamin Bannier wrote:
> > src/linux/fs.hpp, line 351
> > 
> >
> > Not sure how exactly this will be used later, but I would much prefer a 
> > less stringly-typed and more type-safe variant.
> > 
> > What about something like this?
> > 
> > enum class FileSystem { ext2, ext3, ext4 };
> > 
> > bool supported(FileSystem fileSystem);
> > 
> > This would minimize weird usage like the `notexistingfs` you have in 
> > your test.
> 
> Jie Yu wrote:
> One use case for that is: for overlayfs backend, we need to check if 
> overlayfs is supported or not on the box.
> 
> in fact, i'm ok with the string type so that we don't have to list all 
> potential fs type that we want to support. It's a simple utility function to 
> see if an entry exists in /proc/filesystem. I would rather keeping it simple 
> and not introducing the enum here.

I agree with Jie on this, let's keep it simple here.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119689
---


On Feb. 19, 2016, 2:02 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 19, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

2016-02-18 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43746/#review119782
---


Ship it!




Ship It!

- Guangya Liu


On 二月 19, 2016, 12:26 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43746/
> ---
> 
> (Updated 二月 19, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensure the test does not finish before offer rescinds have been
> processed by the scheduler.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
> 
> Diff: https://reviews.apache.org/r/43746/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh 
> --gtest_repeat=1000 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---



LGTM, some minor comments around avoiding redundant use of `Clock` functions 
that can be avoided.


src/tests/hook_tests.cpp (line 390)


hmm ... Can't we just do:

```
Clock::pause();
Clock::advance(...);
Clock::settle();
```



src/tests/hook_tests.cpp (line 392)


Missing period at the end.



src/tests/hook_tests.cpp (line 396)


Is there a need to explicitly invoke `Clock::resume()` here? If not, kill 
it.


- Anand Mazumdar


On Jan. 18, 2016, 4:03 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated Jan. 18, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Jian Qiu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/
---

(Updated 二月 19, 2016, 3:29 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Changes
---

address @anandmazumdar comments


Bugs: MESOS-4174
https://issues.apache.org/jira/browse/MESOS-4174


Repository: mesos


Description
---

Speed up HookTest.VerifySlaveLaunchExecutorHook.


Diffs (updated)
-

  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 

Diff: https://reviews.apache.org/r/42241/diff/


Testing
---

Before
HookTest.VerifySlaveLaunchExecutorHook (5061 ms)

After
HookTest.VerifySlaveLaunchExecutorHook (132 ms)


Thanks,

Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Jian Qiu



> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 390
> > 
> >
> > hmm ... Can't we just do:
> > 
> > ```
> > Clock::pause();
> > Clock::advance(...);
> > Clock::settle();
> > ```

Thanks for reviewing! This settle() is necessary to trigger the 
shutdownExecutor timer.


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---


On 二月 19, 2016, 3:29 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated 二月 19, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Anand Mazumdar



> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 390
> > 
> >
> > hmm ... Can't we just do:
> > 
> > ```
> > Clock::pause();
> > Clock::advance(...);
> > Clock::settle();
> > ```
> 
> Jian Qiu wrote:
> Thanks for reviewing! This settle() is necessary to trigger the 
> shutdownExecutor timer.

Ahh, I see. It's not immediatly obvious to to why we need the first 
`Clock::settle`. As a suggestion, can we add a comment like this:

```
Clock::settle(); // Wait for `Slave::shutdownExecutor` to complete.
```


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
---


On Feb. 19, 2016, 3:29 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> ---
> 
> (Updated Feb. 19, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> ---
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Review Request 43754: WIP: Enhance allocator performance.

2016-02-18 Thread Klaus Ma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43754/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3283
https://issues.apache.org/jira/browse/MESOS-3283


Repository: mesos


Description
---

Enhance allocator performance.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/master/allocator/sorter/drf/sorter.hpp 
4669149b81de39b4bb921ef7cd6787aa583f6e40 
  src/master/allocator/sorter/drf/sorter.cpp 
18797e42a9c2bd20392020237cfae600a5ffe12c 
  src/master/allocator/sorter/sorter.hpp 
a0a779b81f6d048271f15256b38ff907ae144b83 

Diff: https://reviews.apache.org/r/43754/diff/


Testing
---

./src/mesos-tests --benchmark 
--gtest_filter=SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14

**Before this patches:**

```
[ RUN  ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
Using 1 slaves and 100 frameworks
Added 100 frameworks in 1203us
Added 1 slaves in 25.604792secs
Updated 1 slaves in 27.777452secs
[   OK ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
 (54386 ms)
```

**After this patches:**

```
[ RUN  ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
Using 1 slaves and 100 frameworks
Added 100 frameworks in 1846us
Added 1 slaves in 4.953045secs
Updated 1 slaves in 4.338845secs
[   OK ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14
 (10309 ms)
```


Thanks,

Klaus Ma

1 2 >

1 - 100 of 120 matches

Mail list logo