Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs
-

  include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
  include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
  src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
  src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
  src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
  src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

> On 六月 9, 2016, 6:12 p.m., haosdent huang wrote:
> > Looks great to me. XD

Thanks hasdent for the review! hope some day can meet you in person:)

I will update the patch later


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/#review136864
---


On 六月 8, 2016, 6:37 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48438/
> ---
> 
> (Updated 六月 8, 2016, 6:37 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: mesos-5491
> https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement the basic getAgents method for v1 operator master API.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48438/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 10, 2016, 1:16 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

rebase the code to use http response for operator apis


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
  include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
  src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
  src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
  src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
  src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

[zhou xing]

> On 五月 29, 2016, 1:36 a.m., Vinod Kone wrote:
> > src/files/files.cpp, line 374
> > <https://reviews.apache.org/r/46373/diff/8/?file=1386402#file1386402line374>
> >
> > Can we fix the pailer to not send -1 length in a follow up patch?

yes, will submit a patch then


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review135408
---


On 五月 18, 2016, 4:13 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> ---
> 
> (Updated 五月 18, 2016, 4:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
> https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

> On May 27, 2016, 9:39 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 88
> > <https://reviews.apache.org/r/47805/diff/2/?file=1396132#file1396132line88>
> >
> > Neat trick, but I think we're better off just specifying 
> > DEFAULT_CREDENTIAL at those call sites

Adam, not very clear on your suggestions, do you mean that we just put 
credential = DEFAULT_CREDENTIAL here? but as a macro, it is not allowed to put 
an expression in this file scope, thanks for your time on looking this.


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review135190
-------


On May 27, 2016, 5:45 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> ---
> 
> (Updated May 27, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
> https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

> On May 27, 2016, 9:39 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 85
> > <https://reviews.apache.org/r/47805/diff/2/?file=1396131#file1396131line85>
> >
> > Technically, this lambda should be indented to align with its fellow 
> > defer() parameter `master->self()`, or (since that looks too jagged) just 
> > indented 4 spaces in from the `.then`.
> > Looks like our convention for the `-> Future` after is 2 spaces in from 
> > the `[=]` like you have.

Thanks for the comments! The indention is a little confusion to me, as 
somewhere in the code is 4 spaces indention while other places are 2 spaces, do 
we have any regulation on the indention?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review135190
-------


On May 27, 2016, 5:45 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> ---
> 
> (Updated May 27, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
> https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

> On 五月 27, 2016, 9:39 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 88
> > <https://reviews.apache.org/r/47805/diff/2/?file=1396132#file1396132line88>
> >
> > Neat trick, but I think we're better off just specifying 
> > DEFAULT_CREDENTIAL at those call sites
> 
> zhou xing wrote:
> Adam, not very clear on your suggestions, do you mean that we just put 
> credential = DEFAULT_CREDENTIAL here? but as a macro, it is not allowed to 
> put an expression in this file scope, thanks for your time on looking this.

or do you mean change all the caller side to add the credential param and 
remove the param default value here?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review135190
-------


On 五月 27, 2016, 5:45 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> ---
> 
> (Updated 五月 27, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
> https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/
---

(Updated 五月 30, 2016, 2:05 p.m.)


Review request for mesos and Adam B.


Changes
---

change code per Adam's comments


Bugs: mesos-5335
https://issues.apache.org/jira/browse/mesos-5335


Repository: mesos


Description
---

Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.


Diffs (updated)
-

  docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
  include/mesos/authorizer/acls.proto db55ee5be444aee8fc8871aa6cfdefc03a270401 
  include/mesos/authorizer/authorizer.proto 
4478bbd3c8f5c1fb862c2c6bd450689d870f7059 
  src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
  src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
  src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
  src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
  src/tests/dynamic_weights_tests.cpp 235495867f9da5ccddce496cd610a7d649e8a092 

Diff: https://reviews.apache.org/r/47805/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 85
> > <https://reviews.apache.org/r/47805/diff/1/?file=1392984#file1392984line85>
> >
> > s/=/request, weightInfos/
> > s/list/list&/

Adam, this function also requires to capture 'this', which will be used in the 
invocation of '_get()', can we keep using '=' here?


> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, lines 492-494
> > <https://reviews.apache.org/r/47805/diff/1/?file=1392985#file1392985line492>
> >
> > Seems like `checkWithGetRequest` should take the credential as a 
> > parameter, rather than hiding that credential-selection logic inside the 
> > check method.

as in checkWithGetRequest, we are using the constant strings to identify the 
result of get weights, so for 'get weights' specific test cases, I suggest keep 
these two new constant strings. I will add a new credential parameter to 
checkWithGetRequest method and remove the credential-selection logic in it.


> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 512
> > <https://reviews.apache.org/r/47805/diff/1/?file=1392985#file1392985line512>
> >
> > Since this test already uses a principal, why not only allow that 
> > principal to get the weights?
> > Then you can also test that a get request without a principal (or with 
> > CREDENTIAL_2) will see no roles.

Adam, yes, I will only allow DEFAULT_CREDENTIAL in these test cases, but for 
the get check, as I already added a new test case to test "get weights with 
role" only, I suggest not to add a new get request test in this test case. Or 
we can merge the get weights test and update weights test together into one, 
please let me know your comments, thanks.


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review134954
---


On 五月 27, 2016, 5:45 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> ---
> 
> (Updated 五月 27, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
> https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/
---

(Updated 五月 27, 2016, 5:45 a.m.)


Review request for mesos and Adam B.


Changes
---

update code per Adam's comments


Bugs: mesos-5335
https://issues.apache.org/jira/browse/mesos-5335


Repository: mesos


Description
---

Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.


Diffs (updated)
-

  docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
  include/mesos/authorizer/acls.proto ace9b698f46e143795c82324a87a0d7827fb 
  include/mesos/authorizer/authorizer.proto 
02d1a01d57cf34b38524f4368187878b03343537 
  src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
  src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 

Diff: https://reviews.apache.org/r/47805/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47909/#review135125
---


Ship it!




ok to me

- zhou xing


On 五月 26, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47909/
> ---
> 
> (Updated 五月 26, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Bugs: MESOS-5397
> https://issues.apache.org/jira/browse/MESOS-5397
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave/Agent Rename Phase I - Updated terms in the website.
> 
> 
> Diffs
> -
> 
>   site/source/index.html.erb 67f38ac29904bb4853c7fbae51ef9d82396c170e 
> 
> Diff: https://reviews.apache.org/r/47909/diff/
> 
> 
> Testing
> ---
> 
> Because we updated site/README.md before, only need to update 
> `site/source/index.html.erb` here.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47944: Set timestamp when updating task status from long lived framework.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47944/
---

Review request for mesos and Vinod Kone.


Bugs: mesos-5290
https://issues.apache.org/jira/browse/mesos-5290


Repository: mesos


Description
---

Add the step of setting the status update timestamp for long
lived framework executor.


Diffs
-

  src/examples/long_lived_executor.cpp 770aae2fcc7a11db9abab31262cf81967796bb23 

Diff: https://reviews.apache.org/r/47944/diff/


Testing
---

make
make check

Launch a master and an agent
Run long lived framework against master

Open browser, goto 127.0.0.1:5050 and switch to frameworks tab -> long lived 
framework
the page shall show the active and finished tasks of long lived framework, 
instead of showing "46 years ago", it should show "just now" or the current 
timestamp


Thanks,

zhou xing

Review Request 48940: Extract public logic of updating weights into _updateWeights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48940/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

This patch refined the logic of updating weights in WeightsHandler.
Extracted the public code into new _updateWeights method so that
the new operator API can reuse this method to update weights.


Diffs
-

  src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 

Diff: https://reviews.apache.org/r/48940/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 49064: Implement v1 operator update weights API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49064/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

Implemented updateWeights method in WeightsHandler.


Diffs
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
  src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 
  src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 
  src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 

Diff: https://reviews.apache.org/r/49064/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48841: Add Agent protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/
---

(Updated 六月 22, 2016, 1:50 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update according to Vinod's comments


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description (updated)
---

This patch added Agent protobuf message to:
1. v1 message: v1/master/master.proto
2. unversioned message: master/master.proto


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/48841/diff/


Testing
---

make 
make check


Thanks,

zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 22, 2016, 1:53 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update message type according to the protobuf changes


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e 
  src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 
  src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

[zhou xing]

> On 六月 21, 2016, 1:40 a.m., Vinod Kone wrote:
> > src/master/master.hpp, line 1065
> > <https://reviews.apache.org/r/48925/diff/2/?file=1423780#file1423780line1065>
> >
> > move this handler to the outer Master class for consistency with other 
> > v1 API handlers.

Vinod, this method depends on a private _getWeights method in WeightsHandler, 
if we move this method to Master, will need to turn _getWeights as a public 
method, do I understand correctly?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48925/#review138732
---


On 六月 20, 2016, 3:35 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48925/
> ---
> 
> (Updated 六月 20, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5495
> https://issues.apache.org/jira/browse/mesos-5495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add getWeights method in weights_handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
>   src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 
>   src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 
> 
> Diff: https://reviews.apache.org/r/48925/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 48841: Add Agent protobuf message.

[zhou xing]

> On 六月 17, 2016, 6:47 a.m., haosdent huang wrote:
> > include/mesos/mesos.proto, line 2034
> > <https://reviews.apache.org/r/48841/diff/1/?file=1422091#file1422091line2034>
> >
> > Do we need
> > ```
> > reserved_resources_full
> > used_resources_full 
> > offered_resources_full
> > ```
> > which contains persistent volumes?

haosdent, I'm not very clear that if the fields like "reserved_resources" or 
"used_resoruces" can cover the xx_full fields?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/#review138173
---


On 六月 17, 2016, 6:37 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48841/
> ---
> 
> (Updated 六月 17, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
> https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added Agent protobuf message to:
> 1. v1 message: v1/mesos.proto & v1/master/master.proto
> 2. unversioned message: mesos.proto & master/master.proto
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
>   include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
>   include/mesos/v1/master/master.proto 
> 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
>   include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 
> 
> Diff: https://reviews.apache.org/r/48841/diff/
> 
> 
> Testing
> ---
> 
> make 
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 20, 2016, 2:47 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

rebase and change var name


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
  src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48924/
---

(Updated 六月 20, 2016, 3:33 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5495
https://issues.apache.org/jira/browse/mesos-5495


Repository: mesos


Description
---

This patch refined the logic of collecting weights info in
WeightsHandler. Extracted the public code into new _getWeights
method so that the new operator API can reuse this method to
collect weight info.


Diffs (updated)
-

  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
  src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 

Diff: https://reviews.apache.org/r/48924/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48925/
---

(Updated 六月 20, 2016, 3:35 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

modify code indent


Bugs: mesos-5495
https://issues.apache.org/jira/browse/mesos-5495


Repository: mesos


Description
---

Add getWeights method in weights_handler.


Diffs (updated)
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
  src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 
  src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 

Diff: https://reviews.apache.org/r/48925/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 48924: Extract public logic of collecting weights info into _getWeights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48924/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5495
https://issues.apache.org/jira/browse/mesos-5495


Repository: mesos


Description
---

This patch refined the logic of collecting weights info in
WeightsHandler. Extracted the public code into new _getWeights
method so that the new operator API can reuse this method to
collect weight info.


Diffs
-

  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
  src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 

Diff: https://reviews.apache.org/r/48924/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48925/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5495
https://issues.apache.org/jira/browse/mesos-5495


Repository: mesos


Description
---

Add getWeights method in weights_handler.


Diffs
-

  src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
  src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
  src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 
  src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 

Diff: https://reviews.apache.org/r/48925/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48841: Add Agent protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/
---

(Updated 六月 18, 2016, 1:59 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

change the code according to Vinod's comments


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

This patch added Agent protobuf message to:
1. v1 message: v1/mesos.proto & v1/master/master.proto
2. unversioned message: mesos.proto & master/master.proto


Diffs (updated)
-

  include/mesos/master/master.proto fa92240e9d16fdde3d98314f9efbc1c70f9ddb88 
  include/mesos/mesos.proto e4c5bd31cf035707036eb509336fe051119b4e78 
  include/mesos/v1/master/master.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 
  include/mesos/v1/mesos.proto 9be22f02861f1eb89ab547d88530faf90ebee7ab 

Diff: https://reviews.apache.org/r/48841/diff/


Testing
---

make 
make check


Thanks,

zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 18, 2016, 2:02 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

change the code according to haosdent's comments


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 
  src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 
  src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49064/
---

(Updated 六月 23, 2016, 6:05 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

address haosdent's comments


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

Implemented updateWeights method in WeightsHandler.


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
  src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/master/validation.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49064/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48940/
---

(Updated 六月 23, 2016, 6:04 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

address haosdent comments


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

This patch refined the logic of updating weights in WeightsHandler.
Extracted the public code into new _updateWeights method so that
the new operator API can reuse this method to update weights.


Diffs (updated)
-

  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 

Diff: https://reviews.apache.org/r/48940/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48841: Add Agent protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/
---

(Updated 六月 23, 2016, 5:13 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

address Vinod's comments


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

This patch added Agent protobuf message to:
1. v1 message: v1/master/master.proto
2. unversioned message: master/master.proto


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/48841/diff/


Testing
---

make 
make check


Thanks,

zhou xing

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48596/#review137901
---




src/master/http.cpp (line 1371)
<https://reviews.apache.org/r/48596/#comment203125>

for some of the set_xxx or update_xxx method, we do not need contentType, 
we keep this param only for consistency?


- zhou xing


On 六月 15, 2016, 5:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48596/
> ---
> 
> (Updated 六月 15, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
> https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::master::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48596/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

[zhou xing]

> On 六月 16, 2016, 1:11 a.m., zhou xing wrote:
> > src/master/http.cpp, line 1371
> > <https://reviews.apache.org/r/48596/diff/4/?file=1420195#file1420195line1371>
> >
> > for some of the set_xxx or update_xxx method, we do not need 
> > contentType, we keep this param only for consistency?
> 
> haosdent huang wrote:
> Yes, I think we could add `/* */` to contentType which similiar to
> ```
> Future Master::Http::frameworks(
> const Request& request,
> const Option& /*principal*/) const
> ```

yeap, that's better I think


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48596/#review137901
---


On 六月 15, 2016, 5:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48596/
> ---
> 
> (Updated 六月 15, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
> https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::master::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48596/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 48835: Remove duplicate return in getHealth method.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48835/
---

Review request for mesos, haosdent huang and Vinod Kone.


Repository: mesos


Description
---

removed the duplicate return clause.


Diffs
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 

Diff: https://reviews.apache.org/r/48835/diff/


Testing
---

make


Thanks,

zhou xing

Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Implemented getFrameworks method in http.cpp.


Diffs
-

  src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49137/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49157: Added missing comments for operator API protos.

[zhou xing]

> On 六月 24, 2016, 12:27 a.m., Vinod Kone wrote:
> > include/mesos/master/master.proto, line 319
> > <https://reviews.apache.org/r/49157/diff/1/?file=1428649#file1428649line319>
> >
> > can you include informaation about which roles weights are listed here? 
> > for every role listed above?
> 
> haosdent huang wrote:
> Yes, I think this call is duplicated with `GET_ROLES`.
> 
> ```
>   // TODO(Yongqiao Wang): `/roles` endpoint also shows the weights 
> information,
>   // consider erasing the duplicated information later.
>   if (request.method == "GET") {
> return weightsHandler.get(request, principal);
>   }
> ```
> 
> Should we double check with @adam and @yongqiao and remove it if it 
> duplicated?

Yes, in fact, the getWeights call will check all the roles and only show the 
weights of the roles that are granted access to the user. 
please goto @adam to confirm we can remove it now.


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49157/#review139312
---


On 六月 23, 2016, 3:47 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49157/
> ---
> 
> (Updated 六月 23, 2016, 3:47 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, Shuai Lin, and Vinod Kone.
> 
> 
> Bugs: MESOS-5695
> https://issues.apache.org/jira/browse/MESOS-5695
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`,
> `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API
> protos.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 
> 11dfab318eb073908a9e302afa33b274fec63a16 
> 
> Diff: https://reviews.apache.org/r/49157/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139350
---




src/master/http.cpp (line 1290)
<https://reviews.apache.org/r/49137/#comment204518>

Need to update the method according to GetFrameworks message change


- zhou xing


On 六月 24, 2016, 1:42 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> ---
> 
> (Updated 六月 24, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
> https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

(Updated 六月 24, 2016, 7:05 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update GetFrameworks message


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

[zhou xing]

> On 六月 24, 2016, 12:51 a.m., Anand Mazumdar wrote:
> > src/slave/http.cpp, lines 666-714
> > 
> >
> > We can use the `FilesError` type's to construct the response here and 
> > just have one public `browse` that does both `resolve()`/`authorize()`.

Hi All,

I'm thinking whether it is possible that we add a new method named browseFiles 
in FilesProcess like:

  Future browseFiles(
  const mesos::master::Call& call,
  const Option& principal,
  ContentType contentType);

This method has similar function as:

  Future browse(
  const Request& request,
  const Option& principal);
 
 The only difference between them is where and how to extract the params. If 
this is possible, that would be easier for coding and sharing public logic code?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48705/#review139317
---


On 六月 19, 2016, 8:38 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48705/
> ---
> 
> (Updated 六月 19, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
> https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented LIST_FILES Call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/agent/agent.proto 5ac6d4c93a826f0e7a3654d7dcc02b16424f90ce 
>   src/slave/http.cpp 77834111bf51b58ba5e12f262b725202f7d3a7bf 
>   src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
> 
> Diff: https://reviews.apache.org/r/48705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

(Updated 六月 24, 2016, 7:21 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

fix one name typo


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/
---

(Updated 六月 24, 2016, 8:11 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update patch according to framework message change


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Implemented getFrameworks method in http.cpp.


Diffs (updated)
-

  src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49137/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 28, 2016, 1:07 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Addressed Vinod's comments


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48841: Add Agent protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/
---

(Updated 六月 28, 2016, 12:59 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

add comments to field agents


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

This patch added Agent protobuf message to:
1. v1 message: v1/master/master.proto
2. unversioned message: master/master.proto


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 

Diff: https://reviews.apache.org/r/48841/diff/


Testing
---

make 
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

> On 六月 27, 2016, 8:34 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 1261
> > <https://reviews.apache.org/r/49137/diff/4/?file=1430595#file1430595line1261>
> >
> > @anand: i remember us discussing about evolving large responses like 
> > these? was the idea to directly construct a v1 response instead of 
> > constructiong un-versioned response and evolving it?
> 
> Anand Mazumdar wrote:
> +1, yes. Should we be doing it now or do an audit later? I am fine with 
> either of the approaches.
> 
> Vinod Kone wrote:
> later sgtm. i'll file a ticket.

Vinod and Anand, is this because of a performance concern?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139643
-------


On 六月 27, 2016, 7:48 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> ---
> 
> (Updated 六月 27, 2016, 7:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
> https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 
>   src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

> On 六月 27, 2016, 2:04 p.m., haosdent huang wrote:
> > src/master/http.cpp, line 1283
> > <https://reviews.apache.org/r/49137/diff/4/?file=1430595#file1430595line1283>
> >
> > The style here looks incorrect

haosdent, any suggestions here?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139571
---


On 六月 27, 2016, 7:48 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> ---
> 
> (Updated 六月 27, 2016, 7:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
> https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 
>   src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/
---

(Updated 六月 28, 2016, 3:11 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Address Vinod's comments


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Implemented getFrameworks method in http.cpp.


Diffs (updated)
-

  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/49137/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48940/
---

(Updated 六月 28, 2016, 5:21 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Fix issues according to Vinod's comments


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

This patch refined the logic of updating weights in WeightsHandler.
Extracted the public code into new _updateWeights method so that
the new operator API can reuse this method to update weights.


Diffs (updated)
-

  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 

Diff: https://reviews.apache.org/r/48940/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

[zhou xing]

> On 六月 24, 2016, 9:57 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 1103
> > <https://reviews.apache.org/r/48940/diff/2/?file=1428297#file1428297line1103>
> >
> > I think I missed this in the previous review, but lets call this `get` 
> > as well. Do this in a different review.

The review patch is at: https://reviews.apache.org/r/49293/


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48940/#review139409
---


On 六月 28, 2016, 5:21 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48940/
> ---
> 
> (Updated 六月 28, 2016, 5:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5496
> https://issues.apache.org/jira/browse/mesos-5496
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch refined the logic of updating weights in WeightsHandler.
> Extracted the public code into new _updateWeights method so that
> the new operator API can reuse this method to update weights.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
>   src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 
> 
> Diff: https://reviews.apache.org/r/48940/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 49293: Rename method 'getWeights' to 'get' in WeightsHandler.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49293/
---

Review request for mesos and Vinod Kone.


Bugs: mesos-5495
https://issues.apache.org/jira/browse/mesos-5495


Repository: mesos


Description
---

Rename method 'getWeights' to 'get' in WeightsHandler.


Diffs
-

  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 

Diff: https://reviews.apache.org/r/49293/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49064/
---

(Updated 六月 28, 2016, 5:23 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Rename updateWeights to update


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

Implemented updateWeights method in WeightsHandler.


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 
  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/validation.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5 
  src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/49064/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

> On 六月 28, 2016, 6:14 a.m., Vinod Kone wrote:
> > src/master/http.cpp, line 1358
> > <https://reviews.apache.org/r/49137/diff/5/?file=1431412#file1431412line1358>
> >
> > don't use `auto` here because the type is not clear from this 
> > expression.

If I reaplace auto with hashmap<ExecutorID, ExecutorInfo>, I got the following 
compile error:

'''
../../src/master/http.cpp:1274:16: error: too many arguments provided to
  function-like macro invocation
   framework.executors) {
   ^
../../3rdparty/stout/include/stout/foreach.hpp:51:9: note: macro 'foreachpair'
  defined here
#define foreachpair(KEY, VALUE, ELEMS)
'''

I checked the code of foreachpair, seems it does not accept more than 1 
template params?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139729
---


On 六月 28, 2016, 3:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> ---
> 
> (Updated 六月 28, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
> https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
>   src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
>   src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

(Updated 六月 28, 2016, 2:54 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

reabse code


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

> On 六月 28, 2016, 6:14 a.m., Vinod Kone wrote:
> > src/master/http.cpp, line 1358
> > <https://reviews.apache.org/r/49137/diff/5/?file=1431412#file1431412line1358>
> >
> > don't use `auto` here because the type is not clear from this 
> > expression.
> 
> zhou xing wrote:
> If I reaplace auto with hashmap<ExecutorID, ExecutorInfo>, I got the 
> following compile error:
> 
> '''
> ../../src/master/http.cpp:1274:16: error: too many arguments provided to
>   function-like macro invocation
>framework.executors) {
>^
> ../../3rdparty/stout/include/stout/foreach.hpp:51:9: note: macro 
> 'foreachpair'
>   defined here
> #define foreachpair(KEY, VALUE, ELEMS)
> '''
> 
> I checked the code of foreachpair, seems it does not accept more than 1 
> template params?

another solution I can see is to use the following code to go through all the 
executors:

```
  const hashset& slaveIds = framework.executors.keys();
  foreach (const SlaveID& slaveId, slaveIds) {
const hashmap<ExecutorID, ExecutorInfo>& executorsMap =
framework.executors.get(slaveId).get();

foreachvalue (const ExecutorInfo& info, executorsMap) {
  // Skip unauthorized executors.
  if (!approveViewExecutorInfo(executorsApprover,
   info,
   framework.info)) {
continue;
  }

  mesos::master::Response::GetFrameworks::Executor executor;
  executor.mutable_info()->CopyFrom(executor);
  executor.mutable_agent_id()->set_value(slaveId.value());

  _framework.mutable_executors()->Add()->CopyFrom(executor);
}
  }
  ```
  I prefer to keep 'auto', as it is not that complex.   What do you think?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139729
---


On 六月 28, 2016, 3:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> ---
> 
> (Updated 六月 28, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
> https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
>   src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
>   src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

(Updated 六月 28, 2016, 8:09 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

change executor info to required


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs (updated)
-

  include/mesos/master/master.proto f63cc5a9dc379e4e264fe1f08fdc06d8c16d7384 
  include/mesos/v1/master/master.proto d98281d58daa461ce622af49adff9f748b920b7f 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49064/
---

(Updated 六月 28, 2016, 9:15 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Address Vinode's comments


Bugs: mesos-5496
https://issues.apache.org/jira/browse/mesos-5496


Repository: mesos


Description
---

Implemented updateWeights method in WeightsHandler.


Diffs (updated)
-

  include/mesos/master/master.proto f63cc5a9dc379e4e264fe1f08fdc06d8c16d7384 
  include/mesos/v1/master/master.proto d98281d58daa461ce622af49adff9f748b920b7f 
  src/master/http.cpp d583bbeb186974135999eaddbab96e69635dcc7c 
  src/master/master.hpp ba271e7a175529c59abd8bb92536eb5bf0136a40 
  src/master/validation.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5 
  src/master/weights_handler.cpp 0332d86570724e841f97348087808081b2b890af 
  src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 

Diff: https://reviews.apache.org/r/49064/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/
---

(Updated 六月 28, 2016, 8:11 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

addressed Vinod's comments


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Implemented getFrameworks method in http.cpp.


Diffs (updated)
-

  src/master/http.cpp d583bbeb186974135999eaddbab96e69635dcc7c 
  src/master/master.hpp ba271e7a175529c59abd8bb92536eb5bf0136a40 
  src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 

Diff: https://reviews.apache.org/r/49137/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49244: Implement READ_FILE for master operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49244/
---

(Updated 六月 28, 2016, 11:14 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for master operator API.


Diffs (updated)
-

  src/master/http.cpp d583bbeb186974135999eaddbab96e69635dcc7c 
  src/master/master.hpp ba271e7a175529c59abd8bb92536eb5bf0136a40 
  src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 

Diff: https://reviews.apache.org/r/49244/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 49301: Added FilesError class.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49301/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Added FilesError class to identify the errors happened during
the handling of files relevant requests. FilesError is a type
deriving from Error that the master/agent can use to construct
the response.


Diffs
-

  src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 

Diff: https://reviews.apache.org/r/49301/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/
---

(Updated 六月 28, 2016, 11:13 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

This method helps to readFiles based on offset, length
and path, which can be used for implementing master/agent's
READ_FILE operator v1 API.


Diffs (updated)
-

  src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
  src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 

Diff: https://reviews.apache.org/r/49243/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

[zhou xing]

> On 六月 27, 2016, 2:43 p.m., haosdent huang wrote:
> > src/files/files.hpp, lines 70-73
> > <https://reviews.apache.org/r/49243/diff/1/?file=1430573#file1430573line70>
> >
> > Refert to
> > ```
> > class ErrnoError : public Error
> > {
> > public:
> >   ErrnoError() : Error(os::strerror(errno)), code(errno) {}
> > 
> >   ErrnoError(const std::string& message)
> > : Error(message + ": " + os::strerror(errno)), code(errno) {}
> > 
> >   const int code;
> > };
> > ```
> > 
> > Maybe we coud use `FilesError(Type _type)` and `FilesError(Type _type, 
> > std::string _message)`?

please refer to https://reviews.apache.org/r/49301/


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review139575
---


On 六月 28, 2016, 11:13 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49243/
> ---
> 
> (Updated 六月 28, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method helps to readFiles based on offset, length
> and path, which can be used for implementing master/agent's
> READ_FILE operator v1 API.
> 
> 
> Diffs
> -
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
> 
> Diff: https://reviews.apache.org/r/49243/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49243: Create readFile method in FilesProcess.

[zhou xing]

> On 六月 27, 2016, 2:43 p.m., haosdent huang wrote:
> > src/files/files.cpp, lines 85-87
> > <https://reviews.apache.org/r/49243/diff/1/?file=1430574#file1430574line85>
> >
> > Why move these lines?

in files.hpp, I included  '#include "mesos/mesos.hpp"' to use 
mesos::FileContent object, this include will lead to some compile error like:
''' 
../../src/files/files.cpp:343:33: error: no member named 'url' in
  'mesos::Request'
''
So I moved this to using clause inside the namespace declaration.


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review139575
-------


On 六月 28, 2016, 11:13 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49243/
> ---
> 
> (Updated 六月 28, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method helps to readFiles based on offset, length
> and path, which can be used for implementing master/agent's
> READ_FILE operator v1 API.
> 
> 
> Diffs
> -
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
> 
> Diff: https://reviews.apache.org/r/49243/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 六月 28, 2016, 11:15 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp f325bc6b7c92adfb47c1a636b7d385a00e461afb 
  src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
  src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49242: Add ReadFile protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49242/
---

(Updated 六月 28, 2016, 11:12 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Rename GetFileContents to ReadFile


Summary (updated)
-

Add ReadFile protobuf message.


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description (updated)
---

Add ReadFile message in the Response message of master.proto
, v1/master.proto, agent.proto, v1/agent.proto, mesos.proto
and v1/mesos.proto.


Diffs (updated)
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/master/master.proto f63cc5a9dc379e4e264fe1f08fdc06d8c16d7384 
  include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  include/mesos/v1/master/master.proto d98281d58daa461ce622af49adff9f748b920b7f 
  include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 

Diff: https://reviews.apache.org/r/49242/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/
---

(Updated June 26, 2016, 1:56 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code per GetFrameworks message changes


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Implemented getFrameworks method in http.cpp.


Diffs (updated)
-

  src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49137/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49136: Add Framework protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49136/
---

(Updated June 26, 2016, 1:53 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update GetFrameworks message


Bugs: mesos-5492
https://issues.apache.org/jira/browse/mesos-5492


Repository: mesos


Description
---

Add 'Framework' protobuf message to master/master.proto &
v1/master/master.proto.


Diffs (updated)
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 

Diff: https://reviews.apache.org/r/49136/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49214/#review139511
---


Ship it!




Ship it, I'm adding similar GetFileContents into mesos.proto, will submit today

- zhou xing


On 六月 24, 2016, 9:13 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49214/
> ---
> 
> (Updated 六月 24, 2016, 9:13 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
> https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change would be needed later for implementing the `LIST_FILES`
> call for the Master/Agent v1 API.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8a417f91ca6771b971cf5ee50351171412163f7a 
>   include/mesos/v1/mesos.proto 3bc65e7fb1b34651bf025711023f9e219928040a 
> 
> Diff: https://reviews.apache.org/r/49214/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 48841: Add Agent protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

This patch added Agent protobuf message to:
1. v1 message: v1/mesos.proto & v1/master/master.proto
2. unversioned message: mesos.proto & master/master.proto


Diffs
-

  include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
  include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
  include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
  include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 

Diff: https://reviews.apache.org/r/48841/diff/


Testing
---

make 
make check


Thanks,

zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/
---

(Updated 六月 17, 2016, 6:37 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

rebase to use unversioned protobuf message


Bugs: mesos-5491
https://issues.apache.org/jira/browse/mesos-5491


Repository: mesos


Description
---

Implement the basic getAgents method for v1 operator master API.


Diffs (updated)
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48438/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]

Signed-off-by: Guo Jiannan <guojian...@cn.ibm.com>


Diffs
-

  src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated 三月 10, 2016, 7:11 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]

Signed-off-by: Guo Jiannan <guojian...@cn.ibm.com>


Diffs (updated)
-

  docs/endpoints/master/create-volumes.md 
542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
  docs/endpoints/master/destroy-volumes.md 
d5d98198e70fae4f6ea6791511f3b26e792f66d1 
  docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
  docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
  src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

> On 三月 10, 2016, 5:21 a.m., Neil Conway wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, line 60
> > <https://reviews.apache.org/r/44606/diff/1/?file=1293905#file1293905line60>
> >
> > "using" directives should be sorted alphabetically.

Thanks for the review, has updated the patch


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122879
---


On 三月 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 三月 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan <guojian...@cn.ibm.com>
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 45806: Replace Master/Slave Terminology Phase I - Add duplicate binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782] Duplicate the following binaries:
1. executable files
2. shell scripts under mesos/bin folder
3. shell scripts under mesos/src/deploy folder


Diffs
-

  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac c693b825294f82ace8a14563cf2229820e159e3c 
  src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 7, 2016, 7:10 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

change the code according to kevin's comments, also, added the uninstall hook


Summary (updated)
-

Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description (updated)
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.


Diffs (updated)
-

  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac c693b825294f82ace8a14563cf2229820e159e3c 
  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

/mesos/slave/qos_controller.hpp  \
> >   $(top_srcdir)/include/mesos/slave/resource_estimator.hpp
> > 
> > nodist_agent_HEADERS =  \
> >   ../include/mesos/slave/isolator.pb.h  \
> >   ../include/mesos/slave/oversubscription.pb.h
> > ```
> > 
> > and then add another command to your install/uninstall-hooks to create a 
> > symlink from `agent->slave`. Possibly renaming `copy-agent-env-template` to 
> > something more meaningful to cover both the existing stuff, plus setting up 
> > this symlink.
> > 
> > Finally, the CHANGELOG should be updated as part of this patch to point out 
> > all of the changes that have been made.
> > 
> > Thanks!

Kevin, thanks for your comments!

We have updated the code, please take a look. for the CMake part, as we are not 
quite familiar with it, just paste your suggestions in the code, if anything is 
wrong, please let us know so that we can update the patch.

for slave folder rename part, we will create another ticket and track the 
changes there, thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/#review127688
---


On 四月 13, 2016, 2:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45806/
> ---
> 
> (Updated 四月 13, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-3782
> https://issues.apache.org/jira/browse/MESOS-3782
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [#mesos-3782]
> In this patch, we did the following changes:
> 1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
> 2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
> to use term 'agent' instead of term 'slave'
> 3. Change the content of ths scripts to use term 'agent' instead
> of term 'slave'
> 4. Duplicate the renamed scripts renamed in #2 during the configure
> and make process, the duplicated scripts still use term 'slave'
> in their names.
> 
> Please note that afull bootstrap is required once this patch has
> been applied. Otherwise, configure will break because of the
> missing mesos-slave-*.sh scripts. Please follow the steps to
> re-build the project:
> 
> ```
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> ```
> 
> 
> Diffs
> -
> 
>   CHANGELOG 02b6094a6d4c096d7bee3bae294469fd8942998f 
>   bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
>   bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
>   bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
>   bin/mesos-slave-flags.sh.in  
>   bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
>   bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
>   configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
>   src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
>   src/deploy/mesos-deploy-env.sh.template 
> bea5584fbcc68825b1c35b370aed17b0e432edd5 
>   src/deploy/mesos-slave-env.sh.template 
> 31567d6a47e19385aed56edfc7e67457c8cdde3e 
>   src/deploy/mesos-start-cluster.sh.in 
> f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
>   src/deploy/mesos-start-slaves.sh.in 
> 50860f40e33fcbb1787be6c035873de4bcc83de5 
>   src/deploy/mesos-stop-cluster.sh.in 
> e5f8c1fb400c56715774889632aa74d9eac33645 
>   src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
>   src/slave/containerizer/mesos/launch.cpp 
> 54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
>   src/tests/balloon_framework_test.sh 
> ae32753e8942f77f94752543c384d218d6e4d48d 
>   support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
>   support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 
> 
> Diff: https://reviews.apache.org/r/45806/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 13, 2016, 2:52 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  CHANGELOG 02b6094a6d4c096d7bee3bae294469fd8942998f 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/
---

Review request for mesos.


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following change:
1. Change the libprocess cmake target to use 'mesos-agent'
instead of 'mesos-slave'


Diffs
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 

Diff: https://reviews.apache.org/r/46134/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 13, 2016, 2:57 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  CHANGELOG 02b6094a6d4c096d7bee3bae294469fd8942998f 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated 四月 12, 2016, 5:20 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
---

rebase and update the code per Neil's comments


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-

  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  docs/endpoints/master/create-volumes.md 
52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md 
a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp 626c88f85910c4e476194f203341c4db7053e0f0 
  src/tests/persistent_volume_endpoints_tests.cpp 
9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 
2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 12, 2016, 6:34 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

rebase and update code per Kevin's comments


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description (updated)
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing (updated)
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/persistent-volume.md, line 296
> > <https://reviews.apache.org/r/44606/diff/3/?file=1329462#file1329462line296>
> >
> > Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the 
> > `202 ACCEPTED` HTTP status code, which " -- here and below.

Thanks Neil for your review


> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 167
> > <https://reviews.apache.org/r/44606/diff/3/?file=1329464#file1329464line167>
> >
> > Replace "return code" with "HTTP status code"
> > 
> > I think you can just remove "which may introduce backwards 
> > incompatibility issue" (if we're keeping it, the grammar isn't quite right).

Thanks Neil for your review


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
---


On 四月 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 四月 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
---

(Updated April 7, 2016, 8:56 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
---

rebased code and add CHANGELOG


Bugs: mesos-4580
https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description (updated)
---

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-

  CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
  docs/endpoints/master/create-volumes.md 
52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md 
a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
  src/tests/persistent_volume_endpoints_tests.cpp 
9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 
2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
---


Thanks,

zhou xing

Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/
---

Review request for mesos and Vinod Kone.


Bugs: mesos-3780
https://issues.apache.org/jira/browse/mesos-3780


Repository: mesos


Description
---

This is the first patch to solve [MESOS-3780]


Diffs
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
  src/examples/balloon_framework.cpp 16eea37ee327c6da1db96a6f4e3e596be5a7a6ad 
  src/examples/no_executor_framework.cpp 
9223d954197ebd097f57efea5299c917b24fe41e 
  src/examples/persistent_volume_framework.cpp 
3848e247994b511fb2b1dcde337f8f37bb7472da 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
  src/master/allocator/mesos/hierarchical.cpp 
39a290d0db2c22e179a8f933b1a78e3a2dcefdc3 
  src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
  src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
  src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
134b6c759b769cf335539e49eff817973c7f96a4 
  src/slave/containerizer/mesos/launch.cpp 
dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
  src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
  src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a 
  src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
  src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
  src/tests/hierarchical_allocator_tests.cpp 
e9cfcfc0ad8b0b89bbac459b7db39183f6c189be 
  src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
  src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd 
  src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 

Diff: https://reviews.apache.org/r/45213/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

> On 三月 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx
> 
> Kevin Klues wrote:
> I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
> chance to address Neil's comments about updating the documentation? I think 
> that would need to be included as part of this work, though I'd probably 
> submit it as a separate patch that "Depends On" this one.

Kevin, we haven't got any response for this issue from the community yet. So 
I'm thinking whether we can just merge this patch in release 0.29? if so, I can 
update the change log and submit another patch, thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On 三月 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 三月 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan <guojian...@cn.ibm.com>
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote:
> > Can you call this out specifically in the CHANGELOG (under "Binary API 
> > Changes) section.

Vinod?thanks for the review. I just resubmit the patch to rebase to the latest 
code, please take a look.
Besides, do I need to submit another patch for the CHANGELOG chagnes or I can 
inlude the CHANGELOG changes in this patch?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126429
---


On 四月 1, 2016, 5:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated 四月 1, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-3780
> https://issues.apache.org/jira/browse/mesos-3780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
>   src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
>   src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
>   src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
>   src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
>   src/tests/hierarchical_allocator_tests.cpp 
> 8f78a204d296f94f515f21511710a35c33e27255 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/
---

(Updated 四月 1, 2016, 5:57 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

rebase to the latest code


Bugs: mesos-3780
https://issues.apache.org/jira/browse/mesos-3780


Repository: mesos


Description
---

This is the first patch to solve [MESOS-3780]


Diffs (updated)
-

  src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
  src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
  src/examples/no_executor_framework.cpp 
9223d954197ebd097f57efea5299c917b24fe41e 
  src/examples/persistent_volume_framework.cpp 
9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
  src/master/allocator/mesos/hierarchical.cpp 
5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
  src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
  src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
  src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 
  src/slave/containerizer/mesos/launch.cpp 
dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
  src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
  src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
  src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
  src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
  src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
  src/tests/hierarchical_allocator_tests.cpp 
8f78a204d296f94f515f21511710a35c33e27255 
  src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
  src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
  src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 

Diff: https://reviews.apache.org/r/45213/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/
---

(Updated 四月 1, 2016, 6:23 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Add CHANGELOG


Bugs: mesos-5055
https://issues.apache.org/jira/browse/mesos-5055


Repository: mesos


Description
---

This is the first patch to solve [MESOS-3780]


Diffs (updated)
-

  CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
  src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
  src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
  src/examples/no_executor_framework.cpp 
9223d954197ebd097f57efea5299c917b24fe41e 
  src/examples/persistent_volume_framework.cpp 
9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
  src/master/allocator/mesos/hierarchical.cpp 
5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
  src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
  src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
  src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 
  src/slave/containerizer/mesos/launch.cpp 
dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
  src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
  src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
  src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
  src/slave/status_update_manager.cpp f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
  src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
  src/tests/hierarchical_allocator_tests.cpp 
8f78a204d296f94f515f21511710a35c33e27255 
  src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
  src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
  src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 

Diff: https://reviews.apache.org/r/45213/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

[zhou xing]

> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote:
> > Can you call this out specifically in the CHANGELOG (under "Binary API 
> > Changes) section.
> 
> zhou xing wrote:
> Vinod?thanks for the review. I just resubmit the patch to rebase to the 
> latest code, please take a look.
> Besides, do I need to submit another patch for the CHANGELOG chagnes or I 
> can inlude the CHANGELOG changes in this patch?
> 
> Vinod Kone wrote:
> You can include them here.

Done, please take a look


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45213/#review126429
---


On 四月 1, 2016, 6:23 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45213/
> ---
> 
> (Updated 四月 1, 2016, 6:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-5055
> https://issues.apache.org/jira/browse/mesos-5055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first patch to solve [MESOS-3780]
> 
> 
> Diffs
> -
> 
>   CHANGELOG b90078d41357c29c9102df00a735bde460e797bb 
>   src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 
>   src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f 
>   src/examples/no_executor_framework.cpp 
> 9223d954197ebd097f57efea5299c917b24fe41e 
>   src/examples/persistent_volume_framework.cpp 
> 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
>   src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
>   src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
>   src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/slave/containerizer/mesos/launch.cpp 
> dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c 
>   src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
>   src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
>   src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d 
>   src/slave/status_update_manager.cpp 
> f6a9b3b6616abee9c55bf731855ee9b3b98606ac 
>   src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 
>   src/tests/hierarchical_allocator_tests.cpp 
> 8f78a204d296f94f515f21511710a35c33e27255 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
>   src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 
> 
> Diff: https://reviews.apache.org/r/45213/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

[zhou xing]

> On 四月 13, 2016, 11:25 p.m., Vinod Kone wrote:
> > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise 
> > LGTM.
> 
> Kevin Klues wrote:
> It looks like it's failing on this step:
> ```
> make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src'
> cp /mesos/mesos-0.29.0/_inst/etc/mesos/mesos-agent-env.sh.template \
> /mesos/mesos-0.29.0/_inst/etc/mesos/mesos-slave-env.sh.template
> cp: cannot stat 
> '/mesos/mesos-0.29.0/_inst/etc/mesos/mesos-agent-env.sh.template': No such 
> file or directory
> make[5]: *** [copy-agent-env-template] Error 1
> ```
> 
> which is something added in https://reviews.apache.org/r/45806/
> 
> The rule is written as:
> ```
> copy-agent-env-template:
>   cp $(pkgsysconfdir)/mesos-agent-env.sh.template \
> $(pkgsysconfdir)/mesos-slave-env.sh.template
> ```
> 
> so somehow during this installation, `mesos-agent-env.sh.template` didn't 
> get installed correctly before this rule ran. Looking a few lines above this 
> error, we see that it actually got installed to 
> `'/tmp/am-dc-13087//mesos/mesos-0.29.0/_inst/etc/mesos`:
> ```
> /usr/bin/install -c -m 644 ../../src/deploy/mesos-agent-env.sh.template 
> ../../src/deploy/mesos-deploy-env.sh.template 
> ../../src/deploy/mesos-master-env.sh.template 
> '/tmp/am-dc-13087//mesos/mesos-0.29.0/_inst/etc/mesos'.
> ```
> 
> Which I'm guessing is `$(DESTDIR)/$(pkgsysconfdir)`.  Looks like we need 
> to update the rule for `copy-agent-env-template` accordingly.

Kevin, you are correct, I added $(DESTDIR) in Makefile.am and tried locally, it 
worked. have submitted the updated patch to see if this can make CI happy, 
thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/#review128798
---


On 四月 14, 2016, 3:24 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46134/
> ---
> 
> (Updated 四月 14, 2016, 3:24 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [#mesos-3782]
> In this patch, we did the following change:
> 1. Change the libprocess cmake target to use 'mesos-agent'
> instead of 'mesos-slave'
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 
> 
> Diff: https://reviews.apache.org/r/46134/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/
---

(Updated 四月 14, 2016, 5 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

just try to re-kick review bot


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following change:
1. Change the libprocess cmake target to use 'mesos-agent'
instead of 'mesos-slave'


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 

Diff: https://reviews.apache.org/r/46134/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/
---

(Updated 四月 14, 2016, 4:24 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following change:
1. Change the libprocess cmake target to use 'mesos-agent'
instead of 'mesos-slave'


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 

Diff: https://reviews.apache.org/r/46134/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 14, 2016, 4:23 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

add $(DESTDIR) to uninstall hook


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 14, 2016, 3:23 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/
---

(Updated 四月 14, 2016, 5:01 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

just try to re-kick review bot


Bugs: MESOS-3782
https://issues.apache.org/jira/browse/MESOS-3782


Repository: mesos


Description
---

[#mesos-3782]
In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Please note that afull bootstrap is required once this patch has
been applied. Otherwise, configure will break because of the
missing mesos-slave-*.sh scripts. Please follow the steps to
re-build the project:

```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```


Diffs (updated)
-

  CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9 
  bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/mesos-slave-flags.sh.in  
  bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
  configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
  src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
  src/deploy/mesos-deploy-env.sh.template 
bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/mesos-slave-env.sh.template 
31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/mesos-start-cluster.sh.in f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/mesos-start-slaves.sh.in 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/mesos-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
  src/slave/containerizer/mesos/launch.cpp 
54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
  support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
  support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 

Diff: https://reviews.apache.org/r/45806/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check


Thanks,

zhou xing

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131058
---



This target will not be removed until the term 'slave' is completely removed in 
the code, I'm ok to the change

- zhou xing


On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> ---
> 
> (Updated 四月 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> ---
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, 
> should use relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of 
> not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily 
> build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/
---

(Updated 四月 28, 2016, 2:15 a.m.)


Review request for mesos, Ben Mahler and Greg Mann.


Changes
---

update the code according to Greg's comments


Bugs: mesos-5060
https://issues.apache.org/jira/browse/mesos-5060


Repository: mesos


Description
---

[MESOS-5060]
The patch did the following changes:
1. Fix the length logic in files.cpp.
2. Add some tests to test the /files/read.json endponit with
negative length.


Diffs (updated)
-

  src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
  src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 

Diff: https://reviews.apache.org/r/46373/diff/


Testing
---

make
make check

request 'files/read.json' endpoint with negative offset or length argument


Thanks,

zhou xing

Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46761/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: mesos-3779
https://issues.apache.org/jira/browse/mesos-3779


Repository: mesos


Description
---

This patch did the following changes in WebUI:
1. Slave/Agent Rename on web page
2. Slave/Agent Rename in web url
3. Slave/Agent Rename in JS class/method/attribute
4. Slave/Agent Rename in comments

For the JSON data returned from server that contains
term 'slave', the change is not included.


Diffs
-

  CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb 
  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
  src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d 
  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
  src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
  src/webui/master/static/js/controllers.js 
8d9021cc89e54ae3a4151ff7f399733f5a7376dd 
  src/webui/master/static/js/services.js 
fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46761/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check
make install

start mesos master/agent and run a sample framework, then open browser and goto 
: to check all the strings on web page and url


Thanks,

zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/
---

(Updated 四月 27, 2016, 1:57 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

Rebase code, change the commit description and update the makefile target 
comments


Bugs: mesos-5230
https://issues.apache.org/jira/browse/mesos-5230


Repository: mesos


Description (updated)
---

This patch did the following changes:

1. Change the 'make install' headers installation location from
'$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'

2. As we do not change the folder name from 'include/mesos/slave'
to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
'$(DESTDIR)/include/mesos'


Diffs (updated)
-

  CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
  src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 

Diff: https://reviews.apache.org/r/46676/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check
make install


Thanks,

zhou xing

Review Request 46720: Fix the titles of 'Slave/Agent Rename' series tickets in CHANGELOG.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46720/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: mesos-5230
https://issues.apache.org/jira/browse/mesos-5230


Repository: mesos


Description
---

Fix the following tickets' title in CHANGELOG to use 'Slave/Agent':

* [MESOS-5055] - Slave/Agent Rename Phase I - Update strings in the
  log message and standard output.
* [MESOS-3782] - Slave/Agent Rename Phase I - Duplicate/Rename
  binaries.
* [MESOS-5057] - Slave/Agent Rename Phase I - Update strings in
  error messages and other strings.


Diffs
-

  CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 

Diff: https://reviews.apache.org/r/46720/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[zhou xing]

> On 四月 26, 2016, 7:08 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 2151-2152
> > <https://reviews.apache.org/r/46676/diff/1/?file=1361012#file1361012line2151>
> >
> > IIUC, when someone does a  `make install` there will be 2 directories 
> > in the installation directory.
> > 
> > ./mesos/agent
> > ./mesos/slave  (this is a symlink to ../agent)
> > 
> > In the git repo itself we will still have `include/mesos/slave` 
> > directory? I guess renaming this directory to `incluee/mesos/agent`? is too 
> > much work?
> 
> Kevin Klues wrote:
> The `include/mesos/slave` directory is decoupled from the actually 
> install directory specified by `agentdir`.  We can decide to change 
> `include/mesos/slave` to `include/mesos/agent` in the future, but it has 
> nothing to do with this installation directory.

If we want to change include/mesos/slave to include/mesos/agent in the future, 
for the files that depend on the headers in include/mesos/slave, we need to 
keep the path, is that ok?


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review130664
---


On 四月 26, 2016, 6:06 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated 四月 26, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [#MESOS-5230]
> Change the 'make install' includedir name from slave to agent.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

[zhou xing]

> On 四月 28, 2016, 5:18 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/app.js, lines 15-35
> > <https://reviews.apache.org/r/46761/diff/1/?file=1364299#file1364299line15>
> >
> > Hmm. Not sure if this is safe. We are renaming the URL paths.
> > 
> > I think frameworks like marathon and aurora (and platforms like DC/OS) 
> > might be dependin on this path to expose sanboxes to users.
> > 
> > cc @bmahler.
> 
> Vinod Kone wrote:
> Chatted with Ben Mahler. I think the right thing to do here is support 
> both the old routes (/slaves/...) and the new routes (/agents/...) and have 
> the old routes redirect to the new routes. See example here: 
> https://thinkster.io/a-better-way-to-learn-angularjs/redirect-to

sure, will keep the old ones and update the patch then


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46761/#review130946
---


On 四月 28, 2016, 5:20 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46761/
> ---
> 
> (Updated 四月 28, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, Maxim Khutornenko, and 
> Vinod Kone.
> 
> 
> Bugs: mesos-3779
> https://issues.apache.org/jira/browse/mesos-3779
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes in WebUI:
> 1. Slave/Agent Rename on web page
> 2. Slave/Agent Rename in web url
> 3. Slave/Agent Rename in JS class/method/attribute
> 4. Slave/Agent Rename in comments
> 
> For the JSON data returned from server that contains
> term 'slave', the change is not included.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/webui/master/static/browse.html 
> 04a4600f0c762a2412ddee078ba2c173d595aa8d 
>   src/webui/master/static/framework.html 
> 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
>   src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
>   src/webui/master/static/js/controllers.js 
> 8d9021cc89e54ae3a4151ff7f399733f5a7376dd 
>   src/webui/master/static/js/services.js 
> fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
>   src/webui/master/static/offers.html 
> ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 
> 99b23ed9e85011a66bad780fb2d3076e946821a6 
>   src/webui/master/static/slave_framework.html 
> 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
>   src/webui/master/static/slaves.html 
> 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/46761/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> start mesos master/agent and run a sample framework, then open browser and 
> goto : to check all the strings on web page and url
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/
---

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: mesos-5230
https://issues.apache.org/jira/browse/mesos-5230


Repository: mesos


Description
---

[#MESOS-5230]
Change the 'make install' includedir name from slave to agent.


Diffs
-

  CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
  src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 

Diff: https://reviews.apache.org/r/46676/diff/


Testing
---

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check
make install


Thanks,

zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/
---

(Updated 四月 26, 2016, 8:15 a.m.)


Review request for mesos, Ben Mahler and Greg Mann.


Changes
---

rebase and update code according to Greg's comments


Bugs: mesos-5060
https://issues.apache.org/jira/browse/mesos-5060


Repository: mesos


Description
---

[MESOS-5060]
The patch did the following changes:
1. Fix the length logic in files.cpp.
2. Add some tests to test the /files/read.json endponit with
negative length.


Diffs (updated)
-

  src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
  src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 

Diff: https://reviews.apache.org/r/46373/diff/


Testing
---

make
make check

request 'files/read.json' endpoint with negative offset or length argument


Thanks,

zhou xing