[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 True. That is why I do not know which is the best way for us to show the argument/parameter names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 These function docs are printed onto the console. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Normally, most RDBMS docs are using _Italic fonts_ for the parameter/argument names. Linux man is using `underscore` to highlight argument names in descriptions. I also saw another way ``` ``expr1'' ``` I do not know which ways are better in our function descriptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Some of them already had backricks in the description and others did not. Matching it up with backticks was initially suggested by https://github.com/apache/spark/pull/15513#discussion_r84820066. I could not find the concrete reason to not follow. I can remove all of them if you confirm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 @HyukjinKwon why did we add backticks to surround all parameters? It looks pretty weird actually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Merging to master and 2.1! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 (https://github.com/apache/spark/pull/15677#issuecomment-258050659 was on the past commit. I resolved the conflicts twice.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68027/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68027/consoleFull)** for PR 15677 at commit [`cd0c810`](https://github.com/apache/spark/commit/cd0c810351254d8fa8e950a30c4b38d7d810a16c). * This patch passes all tests. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68033/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68033/consoleFull)** for PR 15677 at commit [`6ad2068`](https://github.com/apache/spark/commit/6ad2068bae420ab8f61b20cb165038d841352436). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68031/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68031/consoleFull)** for PR 15677 at commit [`4ed9d03`](https://github.com/apache/spark/commit/4ed9d03aaee2d66f43e3a463ca83a14a5a9119ee). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 LGTM pending test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68033/consoleFull)** for PR 15677 at commit [`6ad2068`](https://github.com/apache/spark/commit/6ad2068bae420ab8f61b20cb165038d841352436). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Thanks @gatorsmile and @srowen. It seems ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68031/consoleFull)** for PR 15677 at commit [`4ed9d03`](https://github.com/apache/spark/commit/4ed9d03aaee2d66f43e3a463ca83a14a5a9119ee). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #68027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68027/consoleFull)** for PR 15677 at commit [`cd0c810`](https://github.com/apache/spark/commit/cd0c810351254d8fa8e950a30c4b38d7d810a16c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 LGTM except one minor [comment](https://github.com/apache/spark/pull/15677#discussion_r86185412). Thanks for your work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Thanks for asking. I think yes it is ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile @HyukjinKwon do you both feel like this is ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67964/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67964/consoleFull)** for PR 15677 at commit [`d25abca`](https://github.com/apache/spark/commit/d25abca456590e324290a1236610f69c5958e145). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67964/consoleFull)** for PR 15677 at commit [`d25abca`](https://github.com/apache/spark/commit/d25abca456590e324290a1236610f69c5958e145). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67962/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67962/consoleFull)** for PR 15677 at commit [`b2fb5e6`](https://github.com/apache/spark/commit/b2fb5e6436342203c14f78c75a818d4ef1285d72). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67962/consoleFull)** for PR 15677 at commit [`b2fb5e6`](https://github.com/apache/spark/commit/b2fb5e6436342203c14f78c75a818d4ef1285d72). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67946/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67946/consoleFull)** for PR 15677 at commit [`a6b50eb`](https://github.com/apache/spark/commit/a6b50ebafb01edceca1fc8a729177cdb87da5e20). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67946/consoleFull)** for PR 15677 at commit [`a6b50eb`](https://github.com/apache/spark/commit/a6b50ebafb01edceca1fc8a729177cdb87da5e20). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 I finished the last pass. Thanks for your work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67900/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67900/consoleFull)** for PR 15677 at commit [`0bfbaee`](https://github.com/apache/spark/commit/0bfbaee13173a62ddc4ff4d4165f1de6cf2c6fb9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67892/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67892/consoleFull)** for PR 15677 at commit [`57153d6`](https://github.com/apache/spark/commit/57153d62c5961c4f07e7a521b5c187571f5a35c4). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class Skewness(child: Expression) extends CentralMomentAgg(child) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67900/consoleFull)** for PR 15677 at commit [`0bfbaee`](https://github.com/apache/spark/commit/0bfbaee13173a62ddc4ff4d4165f1de6cf2c6fb9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67891/consoleFull)** for PR 15677 at commit [`7c2959d`](https://github.com/apache/spark/commit/7c2959d5cdbd146294c6a38443cdc8be10408ec1). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67891/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 (PR description is updated too.) Thank you @srowen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67892/consoleFull)** for PR 15677 at commit [`57153d6`](https://github.com/apache/spark/commit/57153d62c5961c4f07e7a521b5c187571f5a35c4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Alright, then will try to get rid of the arguments part. Thank you all very much sincerely and I apologise the noise I caused. @gatorsmile I will keep in mind you comments too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 @HyukjinKwon Sure, I can try it. Actually, we might need to find multiple typical function APIs as examples to discuss what are the best way to document/specify the argument/parameter types. If all the people agree on it, we can continue to enhance the remaining APIs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Okay, @gatorsmile could you maybe submit a small one first please? Will refer yours and then I can work together (we can divide the files or packages to deal with I guess). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 BTW this is a cool change. We should try to get it in for 2.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 To be honest I myself would never submit such a large pr without strong likelihood of it just getting committed in one or two shots; otherwise it is just impossible to get it merged with conflicts piling up everyday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 @srowen @HyukjinKwon I can submit PRs to add the argument sections and cc you to review. However, I might not submit a huge PR for adding all of them in the same one. Like what I said before, I would like to add the arguments with the corresponding test cases, which can help reviewers understand whether the argument types are right. In addition, it can also capture the potential changes that could affect the external users. Of course, if @HyukjinKwon wants to do it, I also can review it at my best. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 I am fine and willing to follow the majority. We have anyway the same goal. I hope the followup is open as soon as possible after this one though if we decide to remove argument parts here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile Taking your example, before, the user gets no information at all about the type, except that it looks maybe string-like. Now at least we say it's a 'string expression' which suggests, correctly, that you can't send it a number. I understand that 'string expression' isn't tightly defined. But it wasn't defined at all before; it's 'incorrect' now, if you like, and less so after. Are you essentially saying remove all of the "Arguments" sections? If that would unblock the discussion, OK, that's an option. @HyukjinKwon how do you feel about that. @gatorsmile would you be willing to follow this up then with a PR to restore Arguments sections with whatever you believe should be said about them? It's a big change, it's an important change, I am looking forward to getting these updates in place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 I did not say the other changes are wrong. The only concern is argument types. Like what I said above, if we remove the newly added argument types, I am fine to merge this as a document improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 My answer to that is https://github.com/apache/spark/pull/15677#issuecomment-257137604. It seems the discussion goes in a loop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Sorry, I am confusing the merging standards. Why can we accept merging something incorrect? Just like `reverse`, to the external users, the argument type of `str` is not `a string expression`. How can our users know some types are implicitly casted but some other types are not able to cast? This is not the only example. We have many cases like this. Anyway, if this PR is merged, I hope we keep the same standard in the other PRs. Based on my observations, we reversed multiple PRs that improved the codes but did not perfectly resolved the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 I guess we can improve them in followups if a change does not make something worse. This introduces a general format to follow too. Can I just follow the majority if this can't be unanimous - @rxin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 > However, the complex type we should block. We also need to fix it in the code. It does not support complex types already but only `AtomicType`[1]. ``` spark-sql> SELECT reverse(array(1)); Error in query: cannot resolve 'reverse(array(1))' due to data type mismatch: argument 1 requires string type, however, 'array(1)' is of array type.; line 1 pos 7; 'Project [unresolvedalias(reverse(array(1)), None)] +- OneRowRelation$ spark-sql> SELECT reverse(map(1, 1)); Error in query: cannot resolve 'reverse(map(1, 1))' due to data type mismatch: argument 1 requires string type, however, 'map(1, 1)' is of map type.; line 1 pos 7; 'Project [unresolvedalias(reverse(map(1, 1)), None)] +- OneRowRelation$ spark-sql> SELECT reverse(struct(1, 1)); Error in query: cannot resolve 'reverse(struct(1, 1))' due to data type mismatch: argument 1 requires string type, however, 'struct(1, 1)' is of struct type.; line 1 pos 7; 'Project [unresolvedalias(reverse(struct(1, 1)), None)] +- OneRowRelation$ spark-sql> SELECT reverse(1); 1 Time taken: 0.049 seconds, Fetched 1 row(s) spark-sql> SELECT reverse(12); 21 Time taken: 0.053 seconds, Fetched 1 row(s) spark-sql> SELECT reverse(12.0D); 0.21 Time taken: 0.046 seconds, Fetched 1 row(s) spark-sql> SELECT reverse(12BD); 21 Time taken: 0.035 seconds, Fetched 1 row(s) spark-sql> SELECT reverse(12L); 21 Time taken: 0.034 seconds, Fetched 1 row(s) spark-sql> ``` [1]https://github.com/apache/spark/blob/39e2bad6a866d27c3ca594d15e574a1da3ee84cc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L685-L720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 https://github.com/apache/spark/pull/15690 is to resolve the behaviors of a few string-to-string expressions, including `reverse`. After rethinking about it, I think we should not support implicit casting for these expressions. Thus, we need to fix the source codes. Before documenting the argument types, we really need to check the behaviors. If anything is inappropriate, we should correct it. Please remember to deliver the document changes with the corresponding test cases. Generally, discipline is needed for document changes, if we really want to attract more enterprise customers to use Spark in their production systems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 IMO, when we add the argument types in the function descriptions, we should deliver the corresponding test cases in the same PRs. Otherwise, I do not think how we can know the argument types are right or wrong, especially when we have to consider the implicit type conversion. Strictly speaking, the newly added argument types are wrong. I think we just need to remove the argument types from this PR. That is just part of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 The argument would be: because it's not less-right? (I'm not even judging whether your points are right but I presume they are.) I think we did originally not have nearly this much change regarding types and I wanted to merge the last PR, so yes I had the same question before. But we're here now, so what's the simplest path forward? The review has been dragging on, which is OK if it's converging, but now you're suggesting you want to abandon this change. I don't think that's the right outcome. I'd rather resolve the stall by breaking down the change instead. I don't hear that you're arguing that the docs are wrong, just as incomplete in some ways as they were before. More practically, it's hard for you to ask for a hundred changes in comments. It's hard for me to track whether the changes affect what I've previously reviewed. I think we have to draw this to a checkpoint and so I'm asking the narrower question, whether this is actually making anything worse? it makes a number of different things better, according to its original purpose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 If the existing way to document argument types is not right, why we still want to merge it into the master branch? Why not removing them from this PR, if we care the PR grows too big? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 That's fine, they can be changed soon after. Put it this way: do you feel the same argument applies separately to the existing documentation? if it wasn't a 'regression' in this PR i think it's separable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 I am still uncomfortable about the newly added contents regarding the argument types, if we do not resolve the above three general issues. If this were merged, basically, in the follow-up PR, we need to rewrite almost all the argument types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile I suggest we handle all of that as a follow-on PR, because this has already become a series of good related changes that has nevertheless become a very big change. Each of those were existing issues in the docs so I don't think this makes it worse. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Based on my review in this PR, I think we need to resolve the following three major issues when we document the argument type: - First, implicit type casting should be clearly explained when we document the argument types. I am not comfortable if we just let external users figure it out by themselves. They do not know the rules. - Second, null handling of function arguments should also be documented. For most function arguments, it is null intolerant. However, we still have a few exceptions. For example, `sentences`. - Third, the arguments also need to use different terms for `literal`/`constant`, `foldable expressions` and `non-foldable expressions`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15677
```Scala
val df2 = Seq((2.0f, 345)).toDF("a", "b")
checkAnswer(
df2.select(reverse($"a"), reverse($"b")),
Row("0.2", "543"))
```
The argument of `reverse` is not limited to `String`. Thus, `str - a string
expression.` is not right.
However, the complex type we should block. We also need to fix it in the
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67779/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67779/consoleFull)** for PR 15677 at commit [`b46404b`](https://github.com/apache/spark/commit/b46404b763e400f8bfe3c67fed2a0c47764d0d09). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67779/consoleFull)** for PR 15677 at commit [`b46404b`](https://github.com/apache/spark/commit/b46404b763e400f8bfe3c67fed2a0c47764d0d09). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Could I please ask your opinion @rxin ? I would rather simply follow the majority. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15677
@gatorsmile, I guess the changes here are roughly correct and accurate and
make sense. This does not mean "not right" or "wrong".
For example, if users run `describe function extended reverse;` (the one
you pointed out right above)
**Before**
```
Function: reverse
Class: org.apache.spark.sql.catalyst.expressions.StringReverse
Usage: reverse(str) - Returns the reversed given string.
Extended Usage:
> SELECT reverse('Spark SQL');
'LQS krapS'
```
**After**
```
Function: reverse
Class: org.apache.spark.sql.catalyst.expressions.StringReverse
Usage: reverse(str) - Returns the reversed given string.
Extended Usage:
Arguments:
str - a string expression.
Examples:
> SELECT reverse('Spark SQL');
LQS krapS
```
Do you think this is completely incorrect and what users might easily lose
patience at? I guess this is an improvement. Sure, we can improve them more and
make them more correct but I guess this might not be the reason to block this
change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 How about splitting this PR to two parts? One is the document improvement (fixing typos and adding examples). Another is to add argument descriptions (many parts are not clearly defined. More discussions are needed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 @srowen If the newly added contents are not right, should we commit them and fix them later? If this PR does not add argument descriptions, I am fine to merge it (after one more pass) because this is an incremental improvement, as what you said. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile yes, this is why I suggested earlier that we stop and commit the changes we had in the last PR. We have to break this up to make it manageable in this case, because of the size. There are important doc fixes here that we do need to commit. You have indeed asked for a different additional set of logical changes, and now we're mostly down that path, which has led to one big bang PR. I don't think it's useful to question now whether it should be committed! We can commit a change that is a coherent improvement, which does not make the docs worse. We do not have to commit a change that improves or even fixes everything in the existing docs. Some of the problems you're highlighting were there already. Some are improvements to new docs, where there was simply no information before. Re-skimming this large change, it seems like it makes a coherent improvement to the docs (modulo a few more fixes you suggested). If the issue is down to type info, do you believe anything here is actually wrong-er than it was before? If so, let's zero in on those essential changes and make them, and merge this. If not let's merge this. If there is more to discuss, it will be much easier to address in a second pass, I think. We won't have a release in between the two PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Not sure whether the other reviewers have the same feeling like me. 2000+ LOC is too big, imo. The focus of this PR should be on the newly added argument types, descriptions and examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile OK, so, your concern is about potentially inaccurate types and typos. If you are really worried, maybe I can split this PR into several ones. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 I am feeling sorry, but I have to say I will not merge the PR if the quality is not good enough. Maybe my standard is too high. If the other Committers have different opinions, they can merge it without considering my comments. I do not think the changes are minor. Without `except map`, the argument descriptions are incorrect. When we writing the document like this, we should be more careful. Writing the documents are the same as writing the source codes. Sometimes, documents might be more important, because users might read it. If the documents do not match the behaviors, users normally first doubt the quality. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Hey @gatorsmile, I am not rushing to review and also I didn't mean to find every one. I meant I can wait for all the reviews and then sweep it if they are only minors and each does not block each other. As I said, for testing, I have tested one by one when I was in doubt. I have tested most of them (I admit it wasn't all for every type). So, I guess mostly the argument types were correct. The recent changes include minor changes such as `except map`. In the case of this PR, basically, it introduces new sections in documentation. I guess fixing the same instances in single PR is reasonable. At least, I asked @rxin and @srowen first before/after making this PR. I also said several times this would be big and I guess I got approved. There are always rooms for improvements for changes. We can't make something perfect at once. Also, I guess we have still a lot time to fix them more. For example, we can add all the test cases in a folllowup. This would even not be released right after this PR. Other guys still can take a look for this and submit another PR. Please let us just focus on this topic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Since this PR is 2000+ line changes, I am unable to quickly go over all of them. Normally, creating such a big PR is not welcomed, because it is hard for reviewers to read throught all the changes. I hope my comments can trigger you to think more and fix all the related issues, instead of pointing them out by me one by one. For example, my most recent comment is about the complex type support. Have you tried the nested types? BTW, when my teammates do anything like this PR, I always tell them to write test cases if they are not 100% sure. Do not submit a PR without verification. I hope we can do the document changes more carefully, because the external users will not read the source codes. They might easily lose patience. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67733/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67733/consoleFull)** for PR 15677 at commit [`2b437fe`](https://github.com/apache/spark/commit/2b437fe169080b53215f280c8987ff1d8e779df8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 BTW, I hope we can fix up all the minor comments together once as a final look if each does not block each other. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 @gatorsmile I double-checked the type ones again and tried to describe the types more specifically. Could you please take another look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 cc @srowen, @rxin, @jodersky, @gatorsmile . I closed the previous one and reopened it here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67733/consoleFull)** for PR 15677 at commit [`2b437fe`](https://github.com/apache/spark/commit/2b437fe169080b53215f280c8987ff1d8e779df8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
