Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 3: Verified+1

Func tests passed and checked by QE

-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api: allow to return prebuilt responses

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
..


Patch Set 17: Code-Review+1

(1 comment)

Please remove the whitespace change and verify.

https://gerrit.ovirt.org/#/c/61474/17/lib/vdsm/common/api.py
File lib/vdsm/common/api.py:

Line 54
Line 55
Line 56
Line 57
Line 58
Is this related?


-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: response: helper to detect valid responses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: response: helper to detect valid responses
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: response: helper to detect valid responses

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: lib: response: helper to detect valid responses
..


lib: response: helper to detect valid responses

We should build responses in the API layer, and the responses
should be built from what the application layer gives back,
be that return values, or exceptions

We need a gradual upgrade path due to huge amount of legacy code,
so we need to handle the response objects built in the
application layer. For the short/mid-term, the API layer
needs to cope with both flows, modern and old.

So we need an utility to detect which kind the response
the application layer returns to the API layer.

This patch adds this utility, which will be erased once
the transition is complete, with the other scaffolding.

Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63760
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/common/response.py
M tests/responseTests.py
2 files changed, 46 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 7:

See my comments in version 6

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 6:

(4 comments)

https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 308: if rc != 0:
Line 309: raise QImgError(rc, out, err)
Line 310: 
Line 311: 
Line 312: def _qcow2_def_compat():
> @Nir, Eventually we will probably pass the qcow2_compat at every call for t
It returns the default compat, which depend on the configuration since 4.0. We 
want to keep this behavior.
Line 313: value = config.get('irs', 'qcow2_compat')
Line 314: if value not in _QCOW2_COMPAT_SUPPORTED:
Line 315: raise exception.InvalidConfiguration(
Line 316: "Unsupported value for irs:qcow2_compat: %r" % value)


https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 108: 
Line 109: if format:
Line 110: cmd.extend(("-f", format))
Line 111: if format == FORMAT.QCOW2:
Line 112: v_compat = qcow2_compat if qcow2_compat else 
qcow2_def_compat()
> The default is None so in that case you will be creating an invalid command
We need to support the qcow configuration introduced in 4.0.

if qcow2_compat is None:
qcow2_compat = default_qcow2_compat()

I agree with Adam that we should raise if the provided value is not supported.

Please add tests for this option. The current tests are good enough for the 
default value - nothing should change, but when using the option, the test 
should verify that we create the command properly, regardless of the current 
config.
Line 113: cmd.extend(('-o', 'compat=' + v_compat))
Line 114: 
Line 115: if backing:
Line 116: if not os.path.isabs(backing):


Line 166: cmd.append(srcImage)
Line 167: 
Line 168: if dstFormat:
Line 169: cmd.extend(("-O", dstFormat))
Line 170: if dstFormat == FORMAT.QCOW2:
Same as create.
Line 171: v_compat = qcow2_compat if qcow2_compat else 
qcow2_def_compat()
Line 172: options.append('compat=' + v_compat)
Line 173: 
Line 174: if backing:


Line 306: ioclass=utils.IOCLASS.IDLE)
Line 307: 
Line 308: if rc != 0:
Line 309: raise QImgError(rc, out, err)
Line 310: 
Please rename to default_qcow2_compat
Line 311: 
Line 312: def _qcow2_def_compat():
Line 313: value = config.get('irs', 'qcow2_compat')
Line 314: if value not in _QCOW2_COMPAT_SUPPORTED:


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 5:

* #1377069::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 8:

ping

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has abandoned this change.

Change subject: vdsClient: Configure logging before imports
..


Abandoned

Not needed now.

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 197: # If base volume is not provided, qemuimg commit will empty 
the top
Line 198: # volume after the operation has succeeded. Providing '-d' 
option
Line 199: # will cause qemuimg commit not to empty the top volume. Note 
that
Line 200: # if a backing chain is provided, i.e. a base volume is 
provided,
Line 201: # '-d' is always implied.
This comment is repeating what we can read in the manual twice. What is missing 
here and is more important, is why we don't want to empty the image - we may 
need to wipe the top volume before deleting it, and emptying it may leave the 
data on the the underlying storage (qemu probably mark sectors as zero instead 
of wiping the data).
Line 202: cmd.append("-d")
Line 203: 
Line 204: if topFormat:
Line 205: cmd.extend(("-f", str(topFormat)))


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: vm: Remove unneeded fallback to blockRebase
..


vm: Remove unneeded fallback to blockRebase

If blockCopy was not supported, we fallback to blockRebase. This was
required when we supported libvirt < 1.2.9, but now we require 1.2.17
and we can remove this legacy code.

See https://libvirt.org/hvsupport.html for more info.

Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64111
Reviewed-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Freddy Rolland 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 20 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 332: self.assertEquals(p.finished, True)
Line 333: 
Line 334: 
Line 335: @expandPermutations
Line 336: class TestCommit(TestCaseBase):
Add test for progress - testing chain with two empty images without writing any 
pattern, and check that op.progress is 100.0 when operation is completed.
Line 337: 
Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339: def test_write_and_verify(self):
Line 340: with namedTemporaryDir() as tmpdir:


Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Line 372: 
Line 373: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 374: def test_commit_backing_chain(self):
Maybe test_commit_internal?
Line 375: with namedTemporaryDir() as tmpdir:
Line 376: base = os.path.join(tmpdir, 'base.img')
Line 377: internal = os.path.join(tmpdir, 'internal.img')
Line 378: top = os.path.join(tmpdir, 'top.img')


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 363: op = qemuimg.commit(top)
Line 364: op.wait_for_completion()
Line 365: 
Line 366: # top should not change after commit
Line 367: qemu_pattern_verify(top, qemuimg.FORMAT.RAW, '0', 0xf1)
> Issues:
This actually tests nothing, since top will show the data from base even if it 
was empty.

We can verify that top size did not change after the operation.
Line 368: 
Line 369: # base now should include original data and top's data
Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 347: 
Line 348: 
Line 349: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 350: @permutations(((qemuimg.FORMAT.RAW,), (qemuimg.FORMAT.QCOW2,)))
Line 351: def test_commit(self, baseFormat):
Use only lower_case names - in the module api we want to be consistent with the 
old apis, but in the tests we are free to use new vdsm style.
Line 352: with namedTemporaryDir() as tmpdir:
Line 353: base = os.path.join(tmpdir, 'base.img')
Line 354: top = os.path.join(tmpdir, 'top.img')
Line 355: size = 1048576


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 334: 
Line 335: @expandPermutations
Line 336: class TestCommit(TestCaseBase):
Line 337: 
Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
This class does not care about the qcow_compat, so we don't need to monkeypatch 
the config.
Line 339: def test_write_and_verify(self):
Line 340: with namedTemporaryDir() as tmpdir:
Line 341: base = os.path.join(tmpdir, 'base.img')
Line 342: size = 1048576


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 380: 
Line 381: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
Line 382: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0', 0xf0)
Line 383: 
Line 384: qemuimg.create(internal, size=size, 
format=qemuimg.FORMAT.QCOW2,
size is not needed when creating image with backing chain.
Line 385:backing=base)
Line 386: qemu_pattern_write(internal, qemuimg.FORMAT.QCOW2, '512', 
0xf1)
Line 387: 
Line 388: qemuimg.create(top, format=qemuimg.FORMAT.QCOW2, 
backing=internal)


Line 385:backing=base)
Line 386: qemu_pattern_write(internal, qemuimg.FORMAT.QCOW2, '512', 
0xf1)
Line 387: 
Line 388: qemuimg.create(top, format=qemuimg.FORMAT.QCOW2, 
backing=internal)
Line 389: qemu_pattern_write(top, qemuimg.FORMAT.QCOW2, '800', 0xf2)
Use same offsets and patterns as in the previous test :

- base: 0-1k, 0xf0
- internal: 1k-2k, 0xf1
- top: 2k-3k, 0xf2
Line 390: 
Line 391: op = qemuimg.commit(top, base=base)
Line 392: op.wait_for_completion()
Line 393: 


Line 396: 
Line 397: # base now should include original data and top's data
Line 398: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 399: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Line 400: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '800', 0xf2)
Use kwargs and same offsets.


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 363: op = qemuimg.commit(top)
Line 364: op.wait_for_completion()
Line 365: 
Line 366: # top should not change after commit
Line 367: qemu_pattern_verify(top, qemuimg.FORMAT.RAW, '0', 0xf1)
Issues:
- Top always use qemuimg.FORMAT.QCOW2
- Use kwargs
- 0xf1 is the length in this call, so the verification is incorrect
Line 368: 
Line 369: # base now should include original data and top's data
Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)


Line 367: qemu_pattern_verify(top, qemuimg.FORMAT.RAW, '0', 0xf1)
Line 368: 
Line 369: # base now should include original data and top's data
Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Issues:
- Both call must use baseFormat
- Use offset and len in 1k units
- The pattern should be 0xf0 for the first 1k and 0xf1 for the second 1k.
Line 372: 
Line 373: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 374: def test_commit_backing_chain(self):
Line 375: with namedTemporaryDir() as tmpdir:


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339: def test_write_and_verify(self):
Line 340: with namedTemporaryDir() as tmpdir:
Line 341: base = os.path.join(tmpdir, 'base.img')
Line 342: size = 1048576
We don't need this variable, just inline the value bellow.
Line 343: 
Line 344: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
Line 345: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0')
Line 346: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf1)


Line 340: with namedTemporaryDir() as tmpdir:
Line 341: base = os.path.join(tmpdir, 'base.img')
Line 342: size = 1048576
Line 343: 
Line 344: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
size=10485576 is fine.
Line 345: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0')
Line 346: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf1)
Line 347: 
Line 348: 


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 369: # base now should include original data and top's data
Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Line 372: 
Line 373: @MonkeyPatch(qemuimg, 'config', CONFIG)
Running this with both raw and qcow base can be useful to detect qemu-img 
regression, and cost almost nothing.
Line 374: def test_commit_backing_chain(self):
Line 375: with namedTemporaryDir() as tmpdir:
Line 376: base = os.path.join(tmpdir, 'base.img')
Line 377: internal = os.path.join(tmpdir, 'internal.img')


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Document the secret TRACE log level

[automation]

gerrit-hooks has posted comments on this change.

Change subject: logging: Document the secret TRACE log level
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Document the secret TRACE log level

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: logging: Document the secret TRACE log level
..


logging: Document the secret TRACE log level

This may be useful to for developers to understand complicated flows.

Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64218
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Milan Zamazal 
---
M README.logging
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Document the secret TRACE log level

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: Document the secret TRACE log level
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 184: 
Line 185: return QemuImgOperation(cmd, cwd=cwdPath)
Line 186: 
Line 187: 
Line 188: def commit(top, topFormat=None, base=None):
> We should require topFormat, more secure to never let qemu detect the forma
I think topFormat should be baseFormat. qemu-img does not specify what is the 
-f fmt argument, but it cannot be the top format since the top must be qcow 
image to be a "top" image.

Since qemu allow fmt as optional parameter, lest keep it as optional. This is 
also more consistent with other functions in this module.
Line 189: cmd = [_qemuimg.cmd, "commit", "-p"]
Line 190: cwdir = None
Line 191: 
Line 192: if base:


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Refactor workarounds.detect_format
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[alitke]

Adam Litke has abandoned this change.

Change subject: storage: Refactor workarounds.detect_format
..


Abandoned

Not needed.

-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Pass only srcVol to workarounds.detect_format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Pass only srcVol to workarounds.detect_format
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3be993a1326ec2b4e85d93602e8afed39561a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Move detect_format to new workarounds module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move detect_format to new workarounds module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64229
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename qemuimgTests.py to new Vdsm convention

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Pass only srcVol to workarounds.detect_format

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Pass only srcVol to workarounds.detect_format
..

storage: Pass only srcVol to workarounds.detect_format

When copying an image we do not change the format of the volumes on the
fly.  Therefore the destination volume format will always be the same as
that of the source volume.  Given this we can simplify the function so
that it only receives the source volume and only returns one format
which should be used for the source and destination volumes.

Change-Id: I6c3be993a1326ec2b4e85d93602e8afed39561a1
Signed-off-by: Adam Litke 
---
M tests/storage_workarounds_test.py
M vdsm/storage/image.py
M vdsm/storage/workarounds.py
3 files changed, 15 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/64261/1

diff --git a/tests/storage_workarounds_test.py 
b/tests/storage_workarounds_test.py
index afd646e..09d7ce4 100644
--- a/tests/storage_workarounds_test.py
+++ b/tests/storage_workarounds_test.py
@@ -53,10 +53,9 @@
 expect the workaround to report both volumes as RAW.
 """
 with fake_file_env() as env:
-src = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='raw')
-dst = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='raw')
-self.assertEqual((qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW),
- workarounds.detect_format(src, dst))
+vol = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='raw')
+self.assertEqual(qemuimg.FORMAT.RAW,
+ workarounds.detect_format(vol))
 
 def test_bad_format_other_size(self):
 """
@@ -65,17 +64,15 @@
 """
 size = 2 * VM_CONF_SIZE
 with fake_file_env() as env:
-src = make_volume(env, size, md_fmt='cow', real_fmt='raw')
-dst = make_volume(env, size, md_fmt='cow', real_fmt='raw')
-self.assertEqual((qemuimg.FORMAT.QCOW2, qemuimg.FORMAT.QCOW2),
- workarounds.detect_format(src, dst))
+vol = make_volume(env, size, md_fmt='cow', real_fmt='raw')
+self.assertEqual(qemuimg.FORMAT.QCOW2,
+ workarounds.detect_format(vol))
 
 def test_cow_vm_conf_disk(self):
 """
 When a VM configuration disk is actually COW format report it correctly
 """
 with fake_file_env() as env:
-src = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='cow')
-dst = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='cow')
-self.assertEqual((qemuimg.FORMAT.QCOW2, qemuimg.FORMAT.QCOW2),
- workarounds.detect_format(src, dst))
+vol = make_volume(env, VM_CONF_SIZE, md_fmt='cow', real_fmt='cow')
+self.assertEqual(qemuimg.FORMAT.QCOW2,
+ workarounds.detect_format(vol))
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 4833931..ca5d783 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -455,8 +455,7 @@
 try:
 dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
-srcFormat, dstFormat = workarounds.detect_format(srcVol,
- dstVol)
+volFormat = workarounds.detect_format(srcVol)
 
 parentVol = dstVol.getParentVolume()
 
@@ -471,8 +470,8 @@
 operation = qemuimg.convert(
 srcVol.getVolumePath(),
 dstVol.getVolumePath(),
-srcFormat=srcFormat,
-dstFormat=dstFormat,
+srcFormat=volFormat,
+dstFormat=volFormat,
 backing=backing,
 backingFormat=backingFormat)
 with utils.stopwatch("Copy volume %s" % srcVol.volUUID):
diff --git a/vdsm/storage/workarounds.py b/vdsm/storage/workarounds.py
index 7cea63d..8b40277 100644
--- a/vdsm/storage/workarounds.py
+++ b/vdsm/storage/workarounds.py
@@ -29,7 +29,7 @@
 VM_CONF_SIZE_BLK = 20
 
 
-def detect_format(srcVol, dstVol):
+def detect_format(srcVol):
 """
 set VM metadata images format to RAW
 
@@ -58,6 +58,6 @@
 qemuimg.FORMAT.QCOW2,
 srcVol.volUUID,
 qemuimg.FORMAT.RAW)
-return qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW
+return qemuimg.FORMAT.RAW
 
-return sc.fmt2str(src_format), sc.fmt2str(dstVol.getFormat())
+return sc.fmt2str(src_format)


-- 
To view, visit https://gerrit.ovirt.org/64261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Rename qemuimgTests.py to new Vdsm convention

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..


tests: Rename qemuimgTests.py to new Vdsm convention

Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/64203
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/Makefile.am
R tests/qemuimg_test.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 342: size = 1048576
Line 343: 
Line 344: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
Line 345: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0')
Line 346: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf1)
This is broken because 0xf1 is not the pattern but the length.

Please use call kwargs using key=value - for example:

qemu_pattern_write(base, qemuimg.FORMAT.RAW, offset='0', len='1k', 
pattern=0xf0)
Line 347: 
Line 348: 
Line 349: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 350: @permutations(((qemuimg.FORMAT.RAW,), (qemuimg.FORMAT.QCOW2,)))


Line 349: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 350: @permutations(((qemuimg.FORMAT.RAW,), (qemuimg.FORMAT.QCOW2,)))
Line 351: def test_commit(self, baseFormat):
Line 352: with namedTemporaryDir() as tmpdir:
Line 353: base = os.path.join(tmpdir, 'base.img')
Lets move all the operations together for each volume:

base = ...
qemuimg.create(base, ...)
qemu_pattern_write(base, ...)

Then we probably can move this into a little helper:

def make_image(path, size, format, index, backing=None):
qemuimg.create(path, size=size, format=format, backing=backing)
qemu_pattern_write(path, format, offset="%dk" % index, len='1k', 0xf0 + 
index)

This will make the test much easier to get wrong, image always have data at the 
correct offset with the correct pattern.
Line 354: top = os.path.join(tmpdir, 'top.img')
Line 355: size = 1048576
Line 356: 
Line 357: qemuimg.create(base, size=size, format=baseFormat)


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

* #1377069::Update tracker: OK
* Set MODIFIED::bug 1377069#1377069OK

-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdsm: Do not modify warnings filter in a library
..


vdsm: Do not modify warnings filter in a library

vdsm.vdscli was modifying warnings filter, taking control from the
application importing it. With the old code, there is no way to disable
the warnings - if the application sets a warnings filter, importing
vdscli will override the application filter.

This warnings is highly unwanted, causing user facing warnings each time
you run a vdsClient or hosted-engine command.

This patch removes the wrong filter, returning control to the application
using vdscli. Since warnings are hidden by default, this removes the
unwanted warnings from vdsClient and hosted-engine command line tools.

Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64100
Continuous-Integration: Jenkins CI
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/64258
---
M lib/vdsm/vdscli.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Refactor workarounds.detect_format
..


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/64230/1/tests/storage_workarounds_test.py
File tests/storage_workarounds_test.py:

Line 28
Line 29
Line 30
Line 31
Line 32
> Lets add a constants in the module for this, repeating this line in all the
Done


Line 31: 
Line 32: 
Line 33: class DetectFormatTest(VdsmTestCase):
Line 34: 
Line 35: def make_volume(self, env, size, src_md_fmt, src_qemu_fmt):
> There is no src anymore, so we can use now:
Done
Line 36: img_id = str(uuid.uuid4())
Line 37: vol_id = str(uuid.uuid4())
Line 38: env.make_volume(size, img_id, vol_id, vol_format=src_md_fmt)
Line 39: vol = env.sd_manifest.produceVolume(img_id, vol_id)


Line 48: """
Line 49: size = workarounds.VM_CONF_SIZE_BLK * sc.BLOCK_SIZE
Line 50: with fake_file_env() as env:
Line 51: vol = self.make_volume(env, size, sc.COW_FORMAT,
Line 52:qemuimg.FORMAT.RAW)
> To make it more clear:
Done
Line 53: self.assertTrue(workarounds.mismatched_vm_conf_disk(vol))
Line 54: 
Line 55: def test_bad_format_other_size(self):
Line 56: """


https://gerrit.ovirt.org/#/c/64230/1/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 455: try:
Line 456: dstVol = destDom.produceVolume(imgUUID=imgUUID,
Line 457:
volUUID=srcVol.volUUID)
Line 458: 
Line 459: if workarounds.mismatched_vm_conf_disk(srcVol):
> Only this line is tested now.
I've gone back to returning the modified format like the original code did.
Line 460: srcFormat = dstFormat = qemuimg.FORMAT.RAW
Line 461: else:
Line 462: srcFormat = sc.fmt2str(srcVol.getFormat())
Line 463: dstFormat = sc.fmt2str(dstVol.getFormat())


Line 459: if workarounds.mismatched_vm_conf_disk(srcVol):
Line 460: srcFormat = dstFormat = qemuimg.FORMAT.RAW
Line 461: else:
Line 462: srcFormat = sc.fmt2str(srcVol.getFormat())
Line 463: dstFormat = sc.fmt2str(dstVol.getFormat())
> One issue with this approach, this code is not tested now, but there is no 
see above.
Line 464: 
Line 465: parentVol = dstVol.getParentVolume()
Line 466: 
Line 467: if parentVol is not None:


https://gerrit.ovirt.org/#/c/64230/1/vdsm/storage/workarounds.py
File vdsm/storage/workarounds.py:

Line 30
Line 31
Line 32
Line 33
Line 34
> This is not correct now, this patch code only detect invalid vm conf disk.
Not relevant anymore.


Line 28: # Size in blocks of the conf file generated during RAM snapshot 
operation.
Line 29: VM_CONF_SIZE_BLK = 20
Line 30: 
Line 31: 
Line 32: def mismatched_vm_conf_disk(vol):
> is_invalid_vm_conf_disk?
Back to original behavior so keeping original name.
Line 33: """
Line 34: set VM metadata images format to RAW
Line 35: 
Line 36: Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of 
internal raw


-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use mismatched_vm_conf_disk workaround in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/64231/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 62
Line 63
Line 64
Line 65
Line 66
> If we add a is_bad_vm_conf() method to DivEndpoint:
I am not splitting the test from the fix in workaround.detect_format anymore.  
Therefore, I'll go back to putting this inside CopyDataDIVEndpoint.qemu_format.


Line 119: if workarounds.mismatched_vm_conf_disk(self._vol):
Line 120: self._qemu_format = qemuimg.FORMAT.RAW
Line 121: else:
Line 122: self._qemu_format = sc.fmt2str(self._vol.getFormat())
Line 123: return self._qemu_format
> We need this check only for the source image, and then we want to apply the
I agreed with you earlier but in reality I think it needs to be here.  
workarounds.detect_format takes volume object but even if we changed it to 
accept the three scalar values needed to make the decision (vdsm md format, 
path, and size) this logic is not endpoint agnostic.  The only object which 
should supply a vdsm volume metadata value is a DIVEndpoint.  For this reason, 
I want to keep it here in the property since it is relevant only for vdsm 
volume source endpoints.  If we make the assumption that we are not changing 
the format on the fly when we copy then we will just use this value for the 
source and destination format value when calling qemuimg.convert.
Line 124: 
Line 125: @property
Line 126: def backing_path(self):
Line 127: parent_vol = self._vol.getParentVolume()


-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Verified+1

[root@rhevh-25 sos]# ll 
sosreport-rhevh-25.gsslab.rdu2.redhat.com-20160921153154/sos_commands/vdsm/
total 84
-rw-r--r--. 1 root root 2610 Sep 21 15:31 fdisk_-l
-rw-r--r--. 1 root root   27 Sep 21 15:31 iscsiadm_-m_node
-rw-r--r--. 1 root root   30 Sep 21 15:31 iscsiadm_-m_session
-rw-r--r--. 1 root root   65 Sep 21 15:31 ls_-ldZ_.etc.vdsm
-rw-r--r--. 1 root root8 Sep 21 15:31 ls_-l_.var.log.core
-rw-r--r--. 1 root root 1971 Sep 21 15:31 lvm_lvs_-v_-o_tags
-rw-r--r--. 1 root root 1322 Sep 21 15:31 lvm_pvs_-v_-o_all
-rw-r--r--. 1 root root  526 Sep 21 15:31 lvm_vgs_-v_-o_tags
-rw-r--r--. 1 root root 1162 Sep 21 15:31 nodectl_info
-rw-r--r--. 1 root root 1207 Sep 21 15:31 service_vdsmd_status
-rw-r--r--. 1 root root   27 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.bin.ls_-lR_.rhev.data-center
-rw-r--r--. 1 root root   42 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.usr.bin.tree_-l_.rhev.data-center
-rw-r--r--. 1 root root  537 Sep 21 15:31 
su_vdsm_-s_.usr.bin.python_.usr.share.vdsm.dumpStorageTable.pyc
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksInfo
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksStatuses
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllVmStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getDeviceList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsCapabilities
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVGList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_list

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

(5 comments)

https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 184: 
Line 185: return QemuImgOperation(cmd, cwd=cwdPath)
Line 186: 
Line 187: 
Line 188: def commit(top, topFormat=None, base=None):
We should require topFormat, more secure to never let qemu detect the format.
Line 189: cmd = [_qemuimg.cmd, "commit", "-p"]
Line 190: cwdir = None
Line 191: 
Line 192: if base:


Line 185: return QemuImgOperation(cmd, cwd=cwdPath)
Line 186: 
Line 187: 
Line 188: def commit(top, topFormat=None, base=None):
Line 189: cmd = [_qemuimg.cmd, "commit", "-p"]
Add -t none.
Line 190: cwdir = None
Line 191: 
Line 192: if base:
Line 193: cmd.extend(("-b", base))


Line 186: 
Line 187: 
Line 188: def commit(top, topFormat=None, base=None):
Line 189: cmd = [_qemuimg.cmd, "commit", "-p"]
Line 190: cwdir = None
workdir?
Line 191: 
Line 192: if base:
Line 193: cmd.extend(("-b", base))
Line 194: if not os.path.isabs(base):


Line 191: 
Line 192: if base:
Line 193: cmd.extend(("-b", base))
Line 194: if not os.path.isabs(base):
Line 195: cwdir = cwdPath = os.path.dirname(base)
Lets always use workdir, to simplify the code.
Line 196: else:
Line 197: # If base volume is not provided, qemuimg commit will empty 
the top
Line 198: # volume after the operation has succeeded. Providing '-d' 
option
Line 199: # will cause qemuimg commit not to empty the top volume. Note 
that


Line 201: # '-d' is always implied.
Line 202: cmd.append("-d")
Line 203: 
Line 204: if topFormat:
Line 205: cmd.extend(("-f", str(topFormat)))
str not needed
Line 206: 
Line 207: cmd.append(top)
Line 208: 
Line 209: return QemuImgOperation(cmd, cwd=cwdir)


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Move detect_format to new workarounds module

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Move detect_format to new workarounds module
..


Patch Set 1:

(5 comments)

https://gerrit.ovirt.org/#/c/64229/1/tests/storage_workarounds_test.py
File tests/storage_workarounds_test.py:

Line 31: 
Line 32: 
Line 33: class DetectFormatTest(VdsmTestCase):
Line 34: 
Line 35: def make_volumes(self, env, size, src_md_fmt, src_qemu_fmt, 
dst_md_fmt):
> Are you sure we need both src and dst format? We use this workaround when w
Done
Line 36: src_img_id = str(uuid.uuid4())
Line 37: src_vol_id = str(uuid.uuid4())
Line 38: dst_img_id = str(uuid.uuid4())
Line 39: dst_vol_id = str(uuid.uuid4())


Line 31: 
Line 32: 
Line 33: class DetectFormatTest(VdsmTestCase):
Line 34: 
Line 35: def make_volumes(self, env, size, src_md_fmt, src_qemu_fmt, 
dst_md_fmt):
> Looking at the next version, we should just have make_volume() here, and cr
Done
Line 36: src_img_id = str(uuid.uuid4())
Line 37: src_vol_id = str(uuid.uuid4())
Line 38: dst_img_id = str(uuid.uuid4())
Line 39: dst_vol_id = str(uuid.uuid4())


Line 49: When the volume size matches the VM configuration disk size 
and the
Line 50: source volume reports COW even though qemuimg reports RAW then 
we
Line 51: expect the workaround to report both volumes as RAW.
Line 52: """
Line 53: size = workarounds.VM_CONF_SIZE_BLK * sc.BLOCK_SIZE
> Having VM_CONF_SIZE (in bytes) would be much nicer, at leat for the tests.
Solved by just using a constant at the top of the file.
Line 54: with fake_file_env() as env:
Line 55: src, dst = self.make_volumes(env, size, sc.COW_FORMAT,
Line 56:  qemuimg.FORMAT.RAW, 
sc.RAW_FORMAT)
Line 57: self.assertEqual((qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW),


Line 52: """
Line 53: size = workarounds.VM_CONF_SIZE_BLK * sc.BLOCK_SIZE
Line 54: with fake_file_env() as env:
Line 55: src, dst = self.make_volumes(env, size, sc.COW_FORMAT,
Line 56:  qemuimg.FORMAT.RAW, 
sc.RAW_FORMAT)
> This is not clear.
Applied the suggestions about using friendly format strings.
Line 57: self.assertEqual((qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW),
Line 58:  workarounds.detect_format(src, dst))
Line 59: 
Line 60: def test_bad_format_other_size(self):


Line 52: """
Line 53: size = workarounds.VM_CONF_SIZE_BLK * sc.BLOCK_SIZE
Line 54: with fake_file_env() as env:
Line 55: src, dst = self.make_volumes(env, size, sc.COW_FORMAT,
Line 56:  qemuimg.FORMAT.RAW, 
sc.RAW_FORMAT)
> Looking in the next version, I don't know if it worth to add permutations h
ok.
Line 57: self.assertEqual((qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW),
Line 58:  workarounds.detect_format(src, dst))
Line 59: 
Line 60: def test_bad_format_other_size(self):


-- 
To view, visit https://gerrit.ovirt.org/64229
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename qemuimgTests.py to new Vdsm convention

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdm: Introduce new SDM.merge verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP] core: Expose API for qemuimg commit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: [WIP] core: Expose API for qemuimg commit
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Verified+1

Trivial change, verified on master.

-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::#1377069::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Hello Piotr Kliczewski, Yaniv Bronhaim, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64258

to review the following change.

Change subject: vdsm: Do not modify warnings filter in a library
..

vdsm: Do not modify warnings filter in a library

vdsm.vdscli was modifying warnings filter, taking control from the
application importing it. With the old code, there is no way to disable
the warnings - if the application sets a warnings filter, importing
vdscli will override the application filter.

This warnings is highly unwanted, causing user facing warnings each time
you run a vdsClient or hosted-engine command.

This patch removes the wrong filter, returning control to the application
using vdscli. Since warnings are hidden by default, this removes the
unwanted warnings from vdsClient and hosted-engine command line tools.

Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64100
Continuous-Integration: Jenkins CI
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/vdscli.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/64258/1

diff --git a/lib/vdsm/vdscli.py b/lib/vdsm/vdscli.py
index 22e7bc8..552330c 100644
--- a/lib/vdsm/vdscli.py
+++ b/lib/vdsm/vdscli.py
@@ -136,7 +136,6 @@
 server = xmlrpclib.Server('http://%s' % hostPort, transport)
 return server
 
-warnings.simplefilter("always", category=DeprecationWarning)
 warnings.warn(
 "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use "
 "vdsm.jsonrpcvdscli", DeprecationWarning, stacklevel=2)


-- 
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: TestCopyDataDIV needs to initialize the jobs module

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64228/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 64: 
Line 65: def setUp(self):
Line 66: self.scheduler = schedule.Scheduler()
Line 67: self.scheduler.start()
Line 68: jobs.start(self.scheduler)
> Why do we need a real scheduler? a fake scheduler should be good enough, we
That should be fine actually.  I'll just have to move FakeScheduler to a module 
where it can be shared.
Line 69: 
Line 70: def tearDown(self):
Line 71: jobs._clear()
Line 72: 


-- 
To view, visit https://gerrit.ovirt.org/64228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Delete an OVS bridge when the last SB is detached.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Delete an OVS bridge when the last SB is detached.
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c3ba116be59e3e8716bfc949e2c7ee5b9990f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 4: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[alitke]

Adam Litke has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 108: 
Line 109: if format:
Line 110: cmd.extend(("-f", format))
Line 111: if format == FORMAT.QCOW2:
Line 112: cmd.extend(('-o', 'compat=' + qcow2_compat))
The default is None so in that case you will be creating an invalid command 
line.  I think we need to set a default using a constant at the module level.  
I think that default should be "0.10".  If you want to require a value be 
passed then I think we should raise ValueError whenever the value is not in the 
list of supported qcow2_compat values.
Line 113: 
Line 114: if backing:
Line 115: if not os.path.isabs(backing):
Line 116: cwdPath = os.path.dirname(image)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 1: Code-Review-1

(3 comments)

test names

https://gerrit.ovirt.org/#/c/64206/1/tests/network/func_net_bond_test.py
File tests/network/func_net_bond_test.py:

PS1, Line 60: test_add_the_same_nic_to_net_and_bond
test_add_the_same_nic_to_net_and_bond_in_one_step


PS1, Line 69: test_attach_nic_attached_to_a_network_to_a_bond
test_add_bond_with_nic_that_is_already_used_by_network


PS1, Line 79: test_attach_nic_attached_to_a_bond_to_a_network
test_add_network_with_nic_that_is_already_used_by_bond


-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Delete an OVS bridge when the last SB is detached.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Delete an OVS bridge when the last SB is detached.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c3ba116be59e3e8716bfc949e2c7ee5b9990f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 202: 
Line 203: def _add_networks(nets2add, ovs_info, config, acq):
Line 204: net_add_setup = ovs_switch.create_network_addition_setup(ovs_info)
Line 205: net_add_setup.add(nets2add)
Line 206: acq.acquire(net_add_setup.acquired_ifaces)
> before we gathered ifaces to be acquired, acquired them and then transactio
OK, now I understand... You are right.
Line 207: for net, attrs in six.iteritems(nets2add):
Line 208: config.setNetwork(net, attrs)
Line 209: 
Line 210: 


-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split bond setup handler for future validation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split bond setup handler for future validation
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/64241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb346d2231285148b84329b8fa83b4db45285c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split bond setup handler for future validation

[edwardh]

Edward Haas has abandoned this change.

Change subject: net: Split bond setup handler for future validation
..


Abandoned

Squashed into https://gerrit.ovirt.org/#/c/64118

-- 
To view, visit https://gerrit.ovirt.org/64241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idbb346d2231285148b84329b8fa83b4db45285c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Delete an OVS bridge when the last SB is detached.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Delete an OVS bridge when the last SB is detached.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c3ba116be59e3e8716bfc949e2c7ee5b9990f8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Add method to return compat by sd version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Add method to return compat by sd version.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 3:

* #1374988::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374988::OK, public bug
* Check Product::#1374988::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[jtokar]

Jenny Tokar has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 7626: object
> working on that :-)
Done


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.movePV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.movePV
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 308: if rc != 0:
Line 309: raise QImgError(rc, out, err)
Line 310: 
Line 311: 
Line 312: def _qcow2_def_compat():
@Nir, Eventually we will probably pass the qcow2_compat at every call for the 
create and convert calls.
So what will be the use of this method? can we just remove it eventually?
Line 313: value = config.get('irs', 'qcow2_compat')
Line 314: if value not in _QCOW2_COMPAT_SUPPORTED:
Line 315: raise exception.InvalidConfiguration(
Line 316: "Unsupported value for irs:qcow2_compat: %r" % value)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: **WIP** tool: reconfigure containers networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: **WIP** tool: reconfigure containers networks
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 50:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 30:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: config: add tunables for container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: config: add tunables for container support
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30e4372fc88ebb7e68cc3b982af3c2eefacef7ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: filter out 'veth' devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: filter out 'veth' devices
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 34:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Add method to return compat by sd version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Add method to return compat by sd version.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: containers: add the container support module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: containers: add the container support module
..


Patch Set 32:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.movePV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.movePV
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.reduce

[laravot]

Liron Aravot has posted comments on this change.

Change subject: implementing StorageDomain.reduce
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 567: self._validateNotMetadataPV(guid)
Line 568: with self._extendlock:
Line 569: lvm.reduceVG(self.sdUUID, guid)
Line 570: self.updateMapping()
Line 571: lvm.removePV(guid)
> Why separate patch to remove the pv?
Right, fixed.
Line 572: 
Line 573: def _validateNotMetadataPV(self, guid):
Line 574: lvm_metadata_pv, _ = lvm.getFirstExt(self.sdUUID, sd.METADATA)
Line 575: if lvm.isSamePV(lvm_metadata_pv, guid):


https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 754: :type sdUUID: UUID
Line 755: :param guid: A block device GUID
Line 756: :type guid: str
Line 757: """
Line 758: job = sdm.api.reduce_sd_device.Job(jobUUID, 1, sdUUID, guid)
> Document why host_id=1 is correct, see also comment in movePV patch.
Done
Line 759: self.sdm_schedule(job)
Line 760: 
Line 761: @public
Line 762: def resizePV(self, sdUUID, spUUID, guid, options=None):


-- 
To view, visit https://gerrit.ovirt.org/63269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c68f64b6c90f0af4d3fa4da94d5747b4ad9cfd6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.reduce

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.reduce
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c68f64b6c90f0af4d3fa4da94d5747b4ad9cfd6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 43:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 43
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: export container metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: export container metadata
..


Patch Set 22:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: containers: add testsuite

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: containers: add testsuite
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: config: add tunables for container support

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: config: add tunables for container support
..

config: add tunables for container support

Add the config items we'll need later on

Change-Id: I30e4372fc88ebb7e68cc3b982af3c2eefacef7ce
Signed-off-by: Francesco Romani 
---
M lib/vdsm/config.py.in
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/64243/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 695e790..c63eb41 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -522,6 +522,26 @@
 'development only. Value is comma delimeted.'),
 ]),
 
+# Section: [containers]
+('containers', [
+
+('cgroup_slice', 'machine',
+'Run the containers in this cgroup slice.'),
+
+('network_name', 'ovirt',
+'human-friendly name for the configuration of the container '
+'runtime network. Used only for identification.'),
+
+('network_bridge', 'ovirtmgmt',
+'network bridge to use for the containers networking'),
+
+('network_subnet', '10.1.0.0',
+'private subnet address for the containers'),
+
+('network_mask', '20',
+'network mask for the network_subnet'),
+]),
+
 # Section: [tests]
 ('tests', [
 


-- 
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e4372fc88ebb7e68cc3b982af3c2eefacef7ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

[laravot]

Liron Aravot has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py
File vdsm/API.py:

Line 1078: def extend(self, storagepoolID, devlist, force=False):
Line 1079: return self._irs.extendStorageDomain(self._UUID, 
storagepoolID,
Line 1080:  devlist, force)
Line 1081: 
Line 1082: def reduce(self, jobID, guid):
> Please use the same name in all layers (jobID or jobUUID or job_id).
the names are different across the layers for all the verbs as it seems - i 
added this one to match the current pattern.
Line 1083: return self._irs.reduceStorageDomain(jobID, self._UUID, guid)
Line 1084: 
Line 1085: def resizePV(self, storagepoolID, guid):
Line 1086: return self._irs.resizePV(self._UUID, storagepoolID, guid)


https://gerrit.ovirt.org/#/c/62853/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 747: """
Line 748: Reduce a block-based Storage Domain by removing a device from 
it.
Line 749: 
Line 750: :param UUID: The UUID of the job.
Line 751: :type UUID: UUID
> UUID -> jobUUID
Done
Line 752: :param sdUUID: The UUID of the storage domain that owns the 
PV.
Line 753: :type sdUUID: UUID
Line 754: :param guid: A block device GUID
Line 755: :type guid: str


-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split bond setup handler for future validation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Split bond setup handler for future validation
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64241
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb346d2231285148b84329b8fa83b4db45285c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Delete an OVS bridge when the last SB is detached.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Delete an OVS bridge when the last SB is detached.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c3ba116be59e3e8716bfc949e2c7ee5b9990f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org