[webkit-changes] [188751] trunk

[gyuyoung . kim]

Title: [188751] trunk








Revision 188751
Author gyuyoung@webkit.org
Date 2015-08-20 21:30:47 -0700 (Thu, 20 Aug 2015)


Log Message
[EFL] Revise PlatformWebView ctor according to r188718
https://bugs.webkit.org/show_bug.cgi?id=148282

Source/WebKit2:

Patch by Joonghun Park  on 2015-08-20
Reviewed by Gyuyoung Kim.

* PlatformEfl.cmake:

Tools:

This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
instead of WKContextRef and WKPageGroupRef respectively.

Patch by Joonghun Park  on 2015-08-20
Reviewed by Gyuyoung Kim.

* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188750 => 188751)

--- trunk/Source/WebKit2/ChangeLog	2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-21 04:30:47 UTC (rev 188751)
@@ -1,3 +1,12 @@
+2015-08-20  Joonghun Park  
+
+[EFL] Revise PlatformWebView ctor according to r188718
+https://bugs.webkit.org/show_bug.cgi?id=148282
+
+Reviewed by Gyuyoung Kim.
+
+* PlatformEfl.cmake:
+
 2015-08-20  Alex Christensen  
 
 GTK build fix after r188693.


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (188750 => 188751)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-21 04:30:47 UTC (rev 188751)
@@ -65,6 +65,8 @@
 UIProcess/BackingStore.cpp
 UIProcess/DefaultUndoController.cpp
 
+UIProcess/API/C/WKPageConfigurationRef.cpp
+
 UIProcess/API/C/CoordinatedGraphics/WKView.cpp
 
 UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp


Modified: trunk/Tools/ChangeLog (188750 => 188751)

--- trunk/Tools/ChangeLog	2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Tools/ChangeLog	2015-08-21 04:30:47 UTC (rev 188751)
@@ -1,3 +1,16 @@
+2015-08-20  Joonghun Park  
+
+[EFL] Revise PlatformWebView ctor according to r188718
+https://bugs.webkit.org/show_bug.cgi?id=148282
+
+This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
+instead of WKContextRef and WKPageGroupRef respectively.
+
+Reviewed by Gyuyoung Kim.
+
+* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+(WTR::PlatformWebView::PlatformWebView):
+
 2015-08-20  Devin Rousso  
 
 Unreviewed, changed Devin Rousso's email.


Modified: trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp (188750 => 188751)

--- trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp	2015-08-21 04:22:32 UTC (rev 188750)
+++ trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp	2015-08-21 04:30:47 UTC (rev 188751)
@@ -53,7 +53,7 @@
 return ecoreEvas;
 }
 
-PlatformWebView::PlatformWebView(WKContextRef context, WKPageGroupRef pageGroup, WKPageRef /* relatedPage */, const ViewOptions& options)
+PlatformWebView::PlatformWebView(WKPageConfigurationRef configuration, const ViewOptions& options)
 : m_options(options)
 {
 WKRetainPtr useFixedLayoutKey(AdoptWK, WKStringCreateWithUTF8CString("UseFixedLayout"));
@@ -61,6 +61,8 @@
 
 m_window = initEcoreEvas();
 
+WKContextRef context = WKPageConfigurationGetContext(configuration);
+WKPageGroupRef pageGroup = WKPageConfigurationGetPageGroup(configuration);
 m_view = EWKViewCreate(context, pageGroup, ecore_evas_get(m_window), /* smart */ 0);
 
 WKPageSetUseFixedLayout(WKViewGetPage(EWKViewGetWKView(m_view)), m_usingFixedLayout);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188750] trunk/Source/WebInspectorUI

[commit-queue]

Title: [188750] trunk/Source/WebInspectorUI








Revision 188750
Author commit-qu...@webkit.org
Date 2015-08-20 21:22:32 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Better Remember open tab types and order if using JSContext inspector
https://bugs.webkit.org/show_bug.cgi?id=148285

Patch by Joseph Pecoraro  on 2015-08-20
Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector.activateExtraDomains):
Save and restore extra domain related tabs at the expected saved index.

(WebInspector._rememberOpenTabs):
Keep unsupported tab types in the setting so when they are supported they open.

* UserInterface/Base/Utilities.js:
Add a helper for inserting a single object into an array.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188749 => 188750)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 04:19:53 UTC (rev 188749)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 04:22:32 UTC (rev 188750)
@@ -1,3 +1,21 @@
+2015-08-20  Joseph Pecoraro  
+
+Web Inspector: Better Remember open tab types and order if using JSContext inspector
+https://bugs.webkit.org/show_bug.cgi?id=148285
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+(WebInspector.activateExtraDomains):
+Save and restore extra domain related tabs at the expected saved index.
+
+(WebInspector._rememberOpenTabs):
+Keep unsupported tab types in the setting so when they are supported they open.
+
+* UserInterface/Base/Utilities.js:
+Add a helper for inserting a single object into an array.
+
 2015-08-20  Nikita Vasilyev  
 
 Web Inspector: inline errors/warnings are taller than the line height


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (188749 => 188750)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-08-21 04:19:53 UTC (rev 188749)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-08-21 04:22:32 UTC (rev 188750)
@@ -341,15 +341,18 @@
 this._updateDockNavigationItems();
 this._updateToolbarHeight();
 
-this._pendingOpenTabTypes = [];
+this._pendingOpenTabs = [];
 
-for (var tabType of this._openTabsSetting.value) {
+let openTabTypes = this._openTabsSetting.value;
+
+for (let i = 0; i < openTabTypes.length; ++i) {
+let tabType = openTabTypes[i];
 if (!this.isTabTypeAllowed(tabType)) {
-this._pendingOpenTabTypes.push(tabType);
+this._pendingOpenTabs.push({tabType, index: i});
 continue;
 }
 
-var tabContentView = this._tabContentViewForType(tabType);
+let tabContentView = this._tabContentViewForType(tabType);
 if (!tabContentView)
 continue;
 this.tabBrowser.addTabForContentView(tabContentView, true);
@@ -442,6 +445,10 @@
 openTabs.push(tabContentView.type);
 }
 
+// Keep currently unsupported tabs in the setting at their previous index.
+for (let {tabType, index} of this._pendingOpenTabs)
+openTabs.insertAtIndex(tabType, index);
+
 this._openTabsSetting.value = openTabs;
 };
 
@@ -512,23 +519,23 @@
 this._updateReloadToolbarButton();
 this._updateDownloadToolbarButton();
 
-var stillPendingOpenTabTypes = [];
-for (var tabType of this._pendingOpenTabTypes) {
+let stillPendingOpenTabs = [];
+for (let {tabType, index} of this._pendingOpenTabs) {
 if (!this.isTabTypeAllowed(tabType)) {
-stillPendingOpenTabTypes.push(tabType);
+stillPendingOpenTabs.push({tabType, index});
 continue;
 }
 
-var tabContentView = this._tabContentViewForType(tabType);
+let tabContentView = this._tabContentViewForType(tabType);
 if (!tabContentView)
 continue;
 
-this.tabBrowser.addTabForContentView(tabContentView, true);
+this.tabBrowser.addTabForContentView(tabContentView, true, index);
 
 tabContentView.restoreStateFromCookie(WebInspector.StateRestorationType.Load);
 }
 
-this._pendingOpenTabTypes = stillPendingOpenTabTypes;
+this._pendingOpenTabs = stillPendingOpenTabs;
 
 this._updateNewTabButtonState();
 };


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (188749 => 188750)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js	2015-08-21 04:19:53 UTC (rev 188749)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js	2015-08-21 04:22:32 UTC (rev 188750)
@@ -433,6 +433,14 @@
 }
 });
 
+Object.defineProperty(Array.prototype, "insertAtIndex",
+{
+value: function(value, index)
+{
+this.splice(index, 0, value);
+}
+});
+
 Object.defineProperty(Array.prototype, "keySet",
 {

[webkit-changes] [188749] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [188749] trunk/Source/WebInspectorUI








Revision 188749
Author nvasil...@apple.com
Date 2015-08-20 21:19:53 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: inline errors/warnings are taller than the line height
https://bugs.webkit.org/show_bug.cgi?id=148232

Reviewed by Timothy Hatcher.

* UserInterface/Views/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .issue-widget.inline):
(.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188748 => 188749)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 04:18:43 UTC (rev 188748)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 04:19:53 UTC (rev 188749)
@@ -1,3 +1,14 @@
+2015-08-20  Nikita Vasilyev  
+
+Web Inspector: inline errors/warnings are taller than the line height
+https://bugs.webkit.org/show_bug.cgi?id=148232
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/SourceCodeTextEditor.css:
+(.source-code.text-editor > .CodeMirror .issue-widget.inline):
+(.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):
+
 2015-08-20  Joseph Pecoraro  
 
 JSContext Inspector: Uncaught Exception opening Search Tab


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css (188748 => 188749)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2015-08-21 04:18:43 UTC (rev 188748)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2015-08-21 04:19:53 UTC (rev 188749)
@@ -46,7 +46,7 @@
 .source-code.text-editor > .CodeMirror .issue-widget.inline {
 position: relative;
 top: -13px;
-
+height: 13px;
 padding: 0px 5px 0 3px;
 border-bottom-left-radius: 0;
 }
@@ -117,14 +117,10 @@
 
 .source-code.text-editor > .CodeMirror .issue-widget.inline > .text {
 display: inline-block;
-
 max-width: 300px;
-height: 12px;
-padding-top: 1px;
-
+vertical-align: baseline;
 text-overflow: ellipsis;
 white-space: nowrap;
-overflow: hidden;
 }
 
 .popover .debugger-popover-content {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188748] trunk/Source/WebInspectorUI

[commit-queue]

Title: [188748] trunk/Source/WebInspectorUI








Revision 188748
Author commit-qu...@webkit.org
Date 2015-08-20 21:18:43 -0700 (Thu, 20 Aug 2015)


Log Message
JSContext Inspector: Uncaught Exception opening Search Tab
https://bugs.webkit.org/show_bug.cgi?id=148284

Patch by Joseph Pecoraro  on 2015-08-20
Reviewed by Timothy Hatcher.

* UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel):
This is copied / pasted code that shouldn't apply to the Search tab.
We want to show results under Resources in the Search tab.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188747 => 188748)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 03:59:33 UTC (rev 188747)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 04:18:43 UTC (rev 188748)
@@ -1,3 +1,15 @@
+2015-08-20  Joseph Pecoraro  
+
+JSContext Inspector: Uncaught Exception opening Search Tab
+https://bugs.webkit.org/show_bug.cgi?id=148284
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/SearchSidebarPanel.js:
+(WebInspector.SearchSidebarPanel):
+This is copied / pasted code that shouldn't apply to the Search tab.
+We want to show results under Resources in the Search tab.
+
 2015-08-20  Nikita Vasilyev  
 
 Web Inspector: Truncate data URIs


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (188747 => 188748)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2015-08-21 03:59:33 UTC (rev 188747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2015-08-21 04:18:43 UTC (rev 188748)
@@ -55,9 +55,6 @@
 WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
 
 this.contentTreeOutline._onselect_ = this._treeElementSelected.bind(this);
-
-if (WebInspector.debuggableType === WebInspector.DebuggableType._javascript_)
-this._resourcesContentTreeOutline.element.classList.add(WebInspector.NavigationSidebarPanel.HideDisclosureButtonsStyleClassName);
 }
 
 // Public






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188747] trunk/Source/JavaScriptCore

[fpizlo]

Title: [188747] trunk/Source/_javascript_Core








Revision 188747
Author fpi...@apple.com
Date 2015-08-20 20:59:33 -0700 (Thu, 20 Aug 2015)


Log Message
DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate
https://bugs.webkit.org/show_bug.cgi?id=148286

Reviewed by Benjamin Poulain.

This enables us to ensure that the Branch or LogicalNot after an effectful CompareXYZ can
be marked as !mayExit(). I need that for https://bugs.webkit.org/show_bug.cgi?id=145204.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGUseKind.cpp:
(WTF::printInternal):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::shouldNotHaveTypeCheck):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::boolify):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBoolean):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/dfg/DFGUseKind.cpp
trunk/Source/_javascript_Core/dfg/DFGUseKind.h
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188746 => 188747)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-21 03:12:25 UTC (rev 188746)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-21 03:59:33 UTC (rev 188747)
@@ -1,5 +1,43 @@
 2015-08-20  Filip Pizlo  
 
+DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate
+https://bugs.webkit.org/show_bug.cgi?id=148286
+
+Reviewed by Benjamin Poulain.
+
+This enables us to ensure that the Branch or LogicalNot after an effectful CompareXYZ can
+be marked as !mayExit(). I need that for https://bugs.webkit.org/show_bug.cgi?id=145204.
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+(JSC::DFG::FixupPhase::observeUseKindOnNode):
+* dfg/DFGSafeToExecute.h:
+(JSC::DFG::SafeToExecuteEdge::operator()):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::speculate):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
+(JSC::DFG::SpeculativeJIT::compileLogicalNot):
+(JSC::DFG::SpeculativeJIT::emitBranch):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
+(JSC::DFG::SpeculativeJIT::compileLogicalNot):
+(JSC::DFG::SpeculativeJIT::emitBranch):
+* dfg/DFGUseKind.cpp:
+(WTF::printInternal):
+* dfg/DFGUseKind.h:
+(JSC::DFG::typeFilterFor):
+(JSC::DFG::shouldNotHaveTypeCheck):
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::boolify):
+(JSC::FTL::DFG::LowerDFGToLLVM::lowBoolean):
+
+2015-08-20  Filip Pizlo  
+
 Overflow check elimination fails for a simple test case
 https://bugs.webkit.org/show_bug.cgi?id=147387
 


Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (188746 => 188747)

--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2015-08-21 03:12:25 UTC (rev 188746)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2015-08-21 03:59:33 UTC (rev 188747)
@@ -356,9 +356,19 @@
 }
 
 case LogicalNot: {
-if (node->child1()->shouldSpeculateBoolean())
-fixEdge(node->child1());
-else if (node->child1()->shouldSpeculateObjectOrOther())
+if (node->child1()->shouldSpeculateBoolean()) {
+if (node->child1()->result() == NodeResultBoolean) {
+// This is necessary in case we have a bytecode instruction implemented by:
+//
+// a: Compare

[webkit-changes] [188746] trunk/LayoutTests

[commit-queue]

Title: [188746] trunk/LayoutTests








Revision 188746
Author commit-qu...@webkit.org
Date 2015-08-20 20:12:25 -0700 (Thu, 20 Aug 2015)


Log Message
AX: fix accessibility/loading-iframe-updates-axtree.html test for mac
https://bugs.webkit.org/show_bug.cgi?id=148251

Patch by Nan Wang  on 2015-08-20
Reviewed by Chris Fleizach.

Added a container in order to make the frame accessible. Also, added expected results for
both WK1 and WK2.

* accessibility/loading-iframe-updates-axtree-expected.txt:
* accessibility/loading-iframe-updates-axtree.html:
* platform/mac-wk1/accessibility: Added.
* platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt: Added.
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt
trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/platform/mac-wk1/accessibility/
trunk/LayoutTests/platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (188745 => 188746)

--- trunk/LayoutTests/ChangeLog	2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/ChangeLog	2015-08-21 03:12:25 UTC (rev 188746)
@@ -1,3 +1,19 @@
+2015-08-20  Nan Wang  
+
+AX: fix accessibility/loading-iframe-updates-axtree.html test for mac
+https://bugs.webkit.org/show_bug.cgi?id=148251
+
+Reviewed by Chris Fleizach.
+
+Added a container in order to make the frame accessible. Also, added expected results for
+both WK1 and WK2.
+
+* accessibility/loading-iframe-updates-axtree-expected.txt:
+* accessibility/loading-iframe-updates-axtree.html:
+* platform/mac-wk1/accessibility: Added.
+* platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt: Added.
+* platform/mac/TestExpectations:
+
 2015-08-20  Chris Dumez  
 
 Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker()


Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt (188745 => 188746)

--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt	2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt	2015-08-21 03:12:25 UTC (rev 188746)
@@ -10,9 +10,9 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS iframe.isEqual(newIframe) is true
-PASS scrollarea.isEqual(newScrollarea) is false
-PASS subwebarea.isEqual(newSubwebarea) is false
+iframe.isEqual(newIframe): true
+scrollarea.isEqual(newScrollarea): false
+subwebarea.isEqual(newSubwebarea): false
 PASS newSubwebarea.childrenCount > 0 is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html (188745 => 188746)

--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html	2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html	2015-08-21 03:12:25 UTC (rev 188746)
@@ -11,7 +11,7 @@
 description("This tests that if an iframe loads new content after its accessibility object has already been accessed, the iframe accessibility object's descendants are the new scroll area and web area, not the old deleted ones.");
 
 if (window.accessibilityController) {
-window.iframe = accessibilityController.accessibleElementById('iframe');
+window.iframe = accessibilityController.accessibleElementById('iframeContainer');
 window.scrollarea = iframe.childAtIndex(0);
 window.subwebarea = scrollarea.childAtIndex(0);
 }
@@ -19,13 +19,17 @@
 window.iframeElement = document.getElementById("iframe");
 iframeElement.addEventListener("load", function() {
 if (window.accessibilityController) {
-window.newIframe = accessibilityController.accessibleElementById('iframe');
+window.newIframe = accessibilityController.accessibleElementById('iframeContainer');
 window.newScrollarea = newIframe.childAtIndex(0);
 window.newSubwebarea = newScrollarea.childAtIndex(0);
 
-shouldBeTrue("iframe.isEqual(newIframe)");
-shouldBeFalse("scrollarea.isEqual(newScrollarea)");
-shouldBeFalse("subwebarea.isEqual(newSubwebarea)");
+// for WK1, the scroll area does not change
+var iframeEqual = iframe.isEqual(newIframe);
+var scrollareaEqual = scrollarea.isEqual(newScrollarea);
+var subwebareaEqual = subwebarea.isEqual(newSubwebarea);
+debug("iframe.isEqual(newIframe): " + iframeEqual);
+debug("scrollarea.isEqual(newScrollarea): " + scrollareaEqual);
+debug("subwebarea.isEqu

[webkit-changes] [188745] trunk

[cdumez]

Title: [188745] trunk








Revision 188745
Author cdu...@apple.com
Date 2015-08-20 20:05:02 -0700 (Thu, 20 Aug 2015)


Log Message
Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker()
https://bugs.webkit.org/show_bug.cgi?id=148257

Reviewed by Darin Adler.

Source/WebCore:

Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker().
It is supposed to be translated into a *null* NodeFilter. However, WebKit was constructing a
NodeFilter in this case.

Chrome and Firefox do not create a NodeFilter in this case.

No new tests, already covered by:
fast/dom/createNodeIterator-parameters.html
fast/dom/createTreeWalker-parameters.html

* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::toWrapped):

LayoutTests:

Rebaseline tests. We are now passing more of the checks.

* fast/dom/createNodeIterator-parameters-expected.txt:
* fast/dom/createTreeWalker-parameters-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt
trunk/LayoutTests/fast/dom/createTreeWalker-parameters-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSNodeFilterCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (188744 => 188745)

--- trunk/LayoutTests/ChangeLog	2015-08-21 02:57:32 UTC (rev 188744)
+++ trunk/LayoutTests/ChangeLog	2015-08-21 03:05:02 UTC (rev 188745)
@@ -1,3 +1,15 @@
+2015-08-20  Chris Dumez  
+
+Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker()
+https://bugs.webkit.org/show_bug.cgi?id=148257
+
+Reviewed by Darin Adler.
+
+Rebaseline tests. We are now passing more of the checks.
+
+* fast/dom/createNodeIterator-parameters-expected.txt:
+* fast/dom/createTreeWalker-parameters-expected.txt:
+
 2015-08-20  Myles C. Maxfield  
 
 [iOS] Adopt OS X's emoji behavior


Modified: trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt (188744 => 188745)

--- trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt	2015-08-21 02:57:32 UTC (rev 188744)
+++ trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt	2015-08-21 03:05:02 UTC (rev 188745)
@@ -19,7 +19,7 @@
 PASS iterator.root is document
 PASS iterator.referenceNode is document
 PASS iterator.whatToShow is 0
-FAIL iterator.filter should be null. Was [object NodeFilter].
+PASS iterator.filter is null
 PASS iterator.pointerBeforeReferenceNode is true
 
 Passing undefined for optional parameters
@@ -27,7 +27,7 @@
 PASS iterator.root is document
 PASS iterator.referenceNode is document
 FAIL iterator.whatToShow should be 4294967295. Was 0.
-FAIL iterator.filter should be null. Was [object NodeFilter].
+PASS iterator.filter is null
 PASS iterator.pointerBeforeReferenceNode is true
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/dom/createTreeWalker-parameters-expected.txt (188744 => 188745)

--- trunk/LayoutTests/fast/dom/createTreeWalker-parameters-expected.txt	2015-08-21 02:57:32 UTC (rev 188744)
+++ trunk/LayoutTests/fast/dom/createTreeWalker-parameters-expected.txt	2015-08-21 03:05:02 UTC (rev 188745)
@@ -18,14 +18,14 @@
 PASS walker.root is document
 PASS walker.currentNode is document
 PASS walker.whatToShow is 0
-FAIL walker.filter should be null. Was [object NodeFilter].
+PASS walker.filter is null
 
 Passing undefined for optional parameters
 walker = document.createTreeWalker(document, undefined, undefined)
 PASS walker.root is document
 PASS walker.currentNode is document
 FAIL walker.whatToShow should be 4294967295. Was 0.
-FAIL walker.filter should be null. Was [object NodeFilter].
+PASS walker.filter is null
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/Source/WebCore/ChangeLog (188744 => 188745)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 02:57:32 UTC (rev 188744)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 03:05:02 UTC (rev 188745)
@@ -1,3 +1,23 @@
+2015-08-20  Chris Dumez  
+
+Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker()
+https://bugs.webkit.org/show_bug.cgi?id=148257
+
+Reviewed by Darin Adler.
+
+Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker().
+It is supposed to be translated into a *null* NodeFilter. However, WebKit was constructing a
+NodeFilter in this case.
+
+Chrome and Firefox do not create a NodeFilter in this case.
+
+No new tests, already covered by:
+fast/dom/createNodeIterator-parameters.html
+fast/dom/createTreeWalker-parameters.html
+
+* bindings/js/JSNodeFilterCustom.cpp:
+(WebCore::JSNodeFilter::toWrapped):
+
 2015-08-20  Zalan Bujtas  
 
 Make outline: auto repaint rect inflate more explicit.


Modified: trunk/Source/WebCore/bindings/js/JSNodeFilterC

[webkit-changes] [188744] trunk/Source/WebCore

[zalan]

Title: [188744] trunk/Source/WebCore








Revision 188744
Author za...@apple.com
Date 2015-08-20 19:57:32 -0700 (Thu, 20 Aug 2015)


Log Message
Make outline: auto repaint rect inflate more explicit.
https://bugs.webkit.org/show_bug.cgi?id=148263

Reviewed by Simon Fraser.

Use RenderObject::adjustRectWithMaximumOutline() when inflating is conditional and call
RenderView::maximalOutlineSize() when it is not.
After this changeset, we can clearly tell calls when inflating is unconditional (adjusting the size of the compositing layer) apart from
calls when we just simply inflate the repaint rect during outline painting phase.

No change in behaviour.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::computeMaxOutlineSize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLineBoxList.cpp:
(WebCore::isOutlinePhase):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustRectWithMaximumOutline):
(WebCore::RenderObject::maximalOutlineSize): Deleted.
* rendering/RenderObject.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
* rendering/RenderView.cpp:
(WebCore::RenderView::setMaximalOutlineSize):
(WebCore::RenderView::RenderView): Deleted.
* rendering/RenderView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineFlowBox.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLineBoxList.cpp
trunk/Source/WebCore/rendering/RenderListMarker.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderReplaced.cpp
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188743 => 188744)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 02:54:27 UTC (rev 188743)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 02:57:32 UTC (rev 188744)
@@ -1,3 +1,54 @@
+2015-08-20  Zalan Bujtas  
+
+Make outline: auto repaint rect inflate more explicit.
+https://bugs.webkit.org/show_bug.cgi?id=148263
+
+Reviewed by Simon Fraser.
+
+Use RenderObject::adjustRectWithMaximumOutline() when inflating is conditional and call
+RenderView::maximalOutlineSize() when it is not.
+After this changeset, we can clearly tell calls when inflating is unconditional (adjusting the size of the compositing layer) apart from
+calls when we just simply inflate the repaint rect during outline painting phase.
+
+No change in behaviour.
+
+* rendering/InlineFlowBox.cpp:
+(WebCore::InlineFlowBox::paint):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paint):
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::layoutBlock):
+* rendering/RenderDetailsMarker.cpp:
+(WebCore::RenderDetailsMarker::paint):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::computeMaxOutlineSize):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::calculateClipRects):
+* rendering/RenderLineBoxList.cpp:
+(WebCore::isOutlinePhase):
+(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
+(WebCore::RenderLineBoxList::paint):
+* rendering/RenderListMarker.cpp:
+(WebCore::RenderListMarker::paint):
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::adjustRectWithMaximumOutline):
+(WebCore::RenderObject::maximalOutlineSize): Deleted.
+* rendering/RenderObject.h:
+* rendering/RenderRegion.cpp:
+(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
+* rendering/RenderReplaced.cpp:
+(WebCore::RenderReplaced::shouldPaint):
+* rendering/RenderTable.cpp:
+ 

[webkit-changes] [188743] trunk/Source/WebCore

[mmaxfield]

Title: [188743] trunk/Source/WebCore








Revision 188743
Author mmaxfi...@apple.com
Date 2015-08-20 19:54:27 -0700 (Thu, 20 Aug 2015)


Log Message
[OS X] Cleaup after r188591
https://bugs.webkit.org/show_bug.cgi?id=148219

Unreviewed.

Forgot to update a call site of FontPlatformData().

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::systemFallbackForCharacters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188742 => 188743)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 02:51:33 UTC (rev 188742)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 02:54:27 UTC (rev 188743)
@@ -1,3 +1,15 @@
+2015-08-20  Myles C. Maxfield  
+
+[OS X] Cleaup after r188591
+https://bugs.webkit.org/show_bug.cgi?id=148219
+
+Unreviewed.
+
+Forgot to update a call site of FontPlatformData().
+
+* platform/graphics/mac/FontCacheMac.mm:
+(WebCore::FontCache::systemFallbackForCharacters):
+
 2015-08-20  Alex Christensen  
 
 Build fix after r188716.


Modified: trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm (188742 => 188743)

--- trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm	2015-08-21 02:51:33 UTC (rev 188742)
+++ trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm	2015-08-21 02:54:27 UTC (rev 188743)
@@ -579,7 +579,7 @@
 FontPlatformData alternateFont(toCTFont(substituteFont), platformData.size(),
 !isPlatformFont && isAppKitFontWeightBold(weight) && !isAppKitFontWeightBold(substituteFontWeight),
 !isPlatformFont && (traits & NSFontItalicTrait) && !(substituteFontTraits & NSFontItalicTrait),
-platformData.m_orientation);
+platformData.m_orientation, platformData.m_widthVariant, platformData.m_textRenderingMode);
 
 return fontForPlatformData(alternateFont);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188742] trunk/Source/WebCore

[achristensen]

Title: [188742] trunk/Source/WebCore








Revision 188742
Author achristen...@apple.com
Date 2015-08-20 19:51:33 -0700 (Thu, 20 Aug 2015)


Log Message
Build fix after r188716.

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
Add some scope so we can declare a variable (weakPtr) inside a switch statement.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188741 => 188742)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 02:41:52 UTC (rev 188741)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 02:51:33 UTC (rev 188742)
@@ -3,6 +3,14 @@
 Build fix after r188716.
 
 * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
+Add some scope so we can declare a variable (weakPtr) inside a switch statement.
+
+2015-08-20  Alex Christensen  
+
+Build fix after r188716.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
 (WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
 (WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
 Replace m_weakFactory with m_weakPtrFactory which actually exists.


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (188741 => 188742)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-21 02:41:52 UTC (rev 188741)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-21 02:51:33 UTC (rev 188742)
@@ -364,7 +364,7 @@
 return false;
 
 switch (mediaEventType) {
-case MESessionTopologySet:
+case MESessionTopologySet: {
 auto weakPtr = m_weakPtrFactory.createWeakPtr();
 callOnMainThread([weakPtr] {
 if (!weakPtr)
@@ -372,6 +372,7 @@
 weakPtr->onTopologySet();
 });
 break;
+}
 
 case MESessionClosed:
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188741] trunk/Source/WebCore

[achristensen]

Title: [188741] trunk/Source/WebCore








Revision 188741
Author achristen...@apple.com
Date 2015-08-20 19:41:52 -0700 (Thu, 20 Aug 2015)


Log Message
Build fix after r188716.

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
Replace m_weakFactory with m_weakPtrFactory which actually exists.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188740 => 188741)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 02:35:35 UTC (rev 188740)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 02:41:52 UTC (rev 188741)
@@ -1,3 +1,12 @@
+2015-08-20  Alex Christensen  
+
+Build fix after r188716.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
+(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
+Replace m_weakFactory with m_weakPtrFactory which actually exists.
+
 2015-08-20  Myles C. Maxfield  
 
 [iOS] Adopt OS X's emoji behavior.


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (188740 => 188741)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-21 02:35:35 UTC (rev 188740)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-21 02:41:52 UTC (rev 188741)
@@ -335,7 +335,7 @@
 hr = asyncResult->GetStatus();
 m_loadingProgress = SUCCEEDED(hr);
 
-auto weakPtr = m_weakFactory.createWeakPtr();
+auto weakPtr = m_weakPtrFactory.createWeakPtr();
 callOnMainThread([weakPtr] {
 if (!weakPtr)
 return;
@@ -365,7 +365,7 @@
 
 switch (mediaEventType) {
 case MESessionTopologySet:
-auto weakPtr = m_weakFactory.createWeakPtr();
+auto weakPtr = m_weakPtrFactory.createWeakPtr();
 callOnMainThread([weakPtr] {
 if (!weakPtr)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188740] trunk/Source/WebKit2

[achristensen]

Title: [188740] trunk/Source/WebKit2








Revision 188740
Author achristen...@apple.com
Date 2015-08-20 19:35:35 -0700 (Thu, 20 Aug 2015)


Log Message
GTK build fix after r188693.

* UIProcess/API/gtk/PageClientImpl.h:
Delete mediaDocumentNaturalSizeChanged which could be renamed to imageOrMediaDocumentSizeChanged, 
but there's no reason to have an empty function overriding another virtual function that is also empty.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188739 => 188740)

--- trunk/Source/WebKit2/ChangeLog	2015-08-21 02:34:34 UTC (rev 188739)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-21 02:35:35 UTC (rev 188740)
@@ -1,3 +1,11 @@
+2015-08-20  Alex Christensen  
+
+GTK build fix after r188693.
+
+* UIProcess/API/gtk/PageClientImpl.h:
+Delete mediaDocumentNaturalSizeChanged which could be renamed to imageOrMediaDocumentSizeChanged, 
+but there's no reason to have an empty function overriding another virtual function that is also empty.
+
 2015-08-20  Joonghun Park  
 
 [EFL] Fix build error since r188693


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (188739 => 188740)

--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h	2015-08-21 02:34:34 UTC (rev 188739)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h	2015-08-21 02:35:35 UTC (rev 188740)
@@ -132,10 +132,6 @@
 
 virtual void didChangeBackgroundColor() override;
 
-#if ENABLE(VIDEO)
-virtual void mediaDocumentNaturalSizeChanged(const WebCore::IntSize&) override { }
-#endif
-
 virtual void refView() override;
 virtual void derefView() override;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188739] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [188739] trunk/Source/WebInspectorUI








Revision 188739
Author nvasil...@apple.com
Date 2015-08-20 19:34:34 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Truncate data URIs
https://bugs.webkit.org/show_bug.cgi?id=148212

Reviewed by Timothy Hatcher.

* UserInterface/Base/URLUtilities.js:
(parseURL):
Exit early to avoid an expensive RegExp match on a potentially very large data URI.

(parseQueryString):
Fix typo.

(WebInspector.displayNameForURL):
(WebInspector.truncateURL):
By default, only show first and last 3 characters of data URIs.

* UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.get displayURL):
For tooltips, show first and last 32 characters of data URIs.

* UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype._locationString):
* UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype._updateToolTip):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js
trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js
trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188738 => 188739)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 02:30:06 UTC (rev 188738)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 02:34:34 UTC (rev 188739)
@@ -1,3 +1,30 @@
+2015-08-20  Nikita Vasilyev  
+
+Web Inspector: Truncate data URIs
+https://bugs.webkit.org/show_bug.cgi?id=148212
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/URLUtilities.js:
+(parseURL):
+Exit early to avoid an expensive RegExp match on a potentially very large data URI.
+
+(parseQueryString):
+Fix typo.
+
+(WebInspector.displayNameForURL):
+(WebInspector.truncateURL):
+By default, only show first and last 3 characters of data URIs.
+
+* UserInterface/Models/Resource.js:
+(WebInspector.Resource.prototype.get displayURL):
+For tooltips, show first and last 32 characters of data URIs.
+
+* UserInterface/Models/SourceCodeLocation.js:
+(WebInspector.SourceCodeLocation.prototype._locationString):
+* UserInterface/Views/ResourceTreeElement.js:
+(WebInspector.ResourceTreeElement.prototype._updateToolTip):
+
 2015-08-20  Devin Rousso  
 
 Web Inspector: Add flex alignment section to Visual sidebar


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js (188738 => 188739)

--- trunk/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js	2015-08-21 02:30:06 UTC (rev 188738)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js	2015-08-21 02:34:34 UTC (rev 188739)
@@ -74,6 +74,9 @@
 {
 url = "" ? url.trim() : "";
 
+if (url.startsWith("data:"))
+return {scheme: "data", host: null, port: null, path: null, queryString: null, fragment: null, lastPathComponent: null};
+
 var match = url.match(/^([^:]+):\/\/([^\/:]*)(?::([\d]+))?(?:(\/[^#]*)(?:#(.*))?)?$/i);
 if (!match)
 return {scheme: null, host: null, port: null, path: null, queryString: null, fragment: null, lastPathComponent: null};
@@ -169,7 +172,7 @@
 function decode(string)
 {
 try {
-// Replace "+" with " " then decode precent encoded values.
+// Replace "+" with " " then decode percent encoded values.
 return decodeURIComponent(string.replace(/\+/g, " "));
 } catch (e) {
 return string;
@@ -191,6 +194,9 @@
 
 WebInspector.displayNameForURL = function(url, urlComponents)
 {
+if (url.startsWith("data:"))
+return WebInspector.truncateURL(url);
+
 if (!urlComponents)
 urlComponents = parseURL(url);
 
@@ -204,6 +210,27 @@
 return displayName || WebInspector.displayNameForHost(urlComponents.host) || url;
 };
 
+WebInspector.truncateURL = function(url, multiline = false, dataURIMaxSize = 6)
+{
+if (!url.startsWith("data:"))
+return url;
+
+const dataIndex = url.indexOf(",") + 1;
+let header = url.slice(0, dataIndex);
+if (multiline)
+header += "\n";
+
+const data = ""
+if (data.length < dataURIMaxSize)
+return header + data;
+
+const firstChunk = data.slice(0, Math.ceil(dataURIMaxSize / 2));
+const ellipsis = "\u2026";
+const middleChunk = multiline ? `\n${ellipsis}\n` : ellipsis;
+const lastChunk = data.slice(-Math.floor(dataURIMaxSize / 2));
+return header + firstChunk + middleChunk + lastChunk;
+};
+
 WebInspector.displayNameForHost = function(host)
 {
 // FIXME : This should decode punycode hostnames.


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (188738 => 188739)

--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2015-08-21 02:30:06 UTC (rev 188738)
++

[webkit-changes] [188738] trunk/Source/WebKit2

[commit-queue]

Title: [188738] trunk/Source/WebKit2








Revision 188738
Author commit-qu...@webkit.org
Date 2015-08-20 19:30:06 -0700 (Thu, 20 Aug 2015)


Log Message
[EFL] Fix build error since r188693
https://bugs.webkit.org/show_bug.cgi?id=148279

Patch by Joonghun Park  on 2015-08-20
Reviewed by Gyuyoung Kim.

* UIProcess/efl/WebViewEfl.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188737 => 188738)

--- trunk/Source/WebKit2/ChangeLog	2015-08-21 02:12:01 UTC (rev 188737)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-21 02:30:06 UTC (rev 188738)
@@ -1,3 +1,12 @@
+2015-08-20  Joonghun Park  
+
+[EFL] Fix build error since r188693
+https://bugs.webkit.org/show_bug.cgi?id=148279
+
+Reviewed by Gyuyoung Kim.
+
+* UIProcess/efl/WebViewEfl.h:
+
 2015-08-20  Anders Carlsson  
 
 Use WKPageConfigurationRef in WebKitTestRunner


Modified: trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.h (188737 => 188738)

--- trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.h	2015-08-21 02:12:01 UTC (rev 188737)
+++ trunk/Source/WebKit2/UIProcess/efl/WebViewEfl.h	2015-08-21 02:30:06 UTC (rev 188738)
@@ -90,10 +90,6 @@
 virtual void didFinishLoadForMainFrame() override final { }
 virtual void didSameDocumentNavigationForMainFrame(SameDocumentNavigationType) override final { }
 
-#if ENABLE(VIDEO)
-virtual void mediaDocumentNaturalSizeChanged(const WebCore::IntSize&) override final { }
-#endif
-
 virtual void refView() override final { }
 virtual void derefView() override final { }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188737] trunk

[mmaxfield]

Title: [188737] trunk








Revision 188737
Author mmaxfi...@apple.com
Date 2015-08-20 19:12:01 -0700 (Thu, 20 Aug 2015)


Log Message
Source/WebCore:
[iOS] Adopt OS X's emoji behavior.
https://bugs.webkit.org/show_bug.cgi?id=148265

Reviewed by Simon Fraser.

Remove our hardcoded hacks which limit the sizes of emoji. This is how
OS X behaves with emoji.

Test: fast/text/emoji.html

* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isEmoji): Deleted.
(WebCore::FontPlatformData::setIsEmoji): Deleted.
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::drawGlyphs):
(WebCore::isOnOrAfterIOS6): Deleted.
(WebCore::pointAdjustedForEmoji): Deleted.
* platform/graphics/cocoa/FontCocoa.mm:
(WebCore::canUseFastGlyphAdvanceGetter):
(WebCore::Font::platformInit): Deleted.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::platformDataInit): Deleted.
(WebCore::FontPlatformData::platformDataAssign): Deleted.
(WebCore::FontPlatformData::platformIsEqual): Deleted.
(WebCore::FontPlatformData::ctFontSize): Deleted.
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::getSystemFontFallbackForCharacters): Deleted.
(WebCore::FontCache::createFontPlatformData): Deleted.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Deleted.

LayoutTests:
[iOS] Adopt OS X's emoji behavior
https://bugs.webkit.org/show_bug.cgi?id=148265

Reviewed by Simon Fraser.

* platform/ios-simulator/fast/text/emoji-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/fast/text/emoji-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (188736 => 188737)

--- trunk/LayoutTests/ChangeLog	2015-08-21 02:10:46 UTC (rev 188736)
+++ trunk/LayoutTests/ChangeLog	2015-08-21 02:12:01 UTC (rev 188737)
@@ -1,3 +1,12 @@
+2015-08-20  Myles C. Maxfield  
+
+[iOS] Adopt OS X's emoji behavior
+https://bugs.webkit.org/show_bug.cgi?id=148265
+
+Reviewed by Simon Fraser.
+
+* platform/ios-simulator/fast/text/emoji-expected.txt:
+
 2015-08-20  Chris Dumez  
 
 getElementsByClassName() should return an HTMLCollection


Modified: trunk/LayoutTests/platform/ios-simulator/fast/text/emoji-expected.txt (188736 => 188737)

--- trunk/LayoutTests/platform/ios-simulator/fast/text/emoji-expected.txt	2015-08-21 02:10:46 UTC (rev 188736)
+++ trunk/LayoutTests/platform/ios-simulator/fast/text/emoji-expected.txt	2015-08-21 02:12:01 UTC (rev 188737)
@@ -7,20 +7,20 @@
 RenderText {#text} at (0,0) size 471x19
   text run at (0,0) width 471: "This test validate rendering of emoji sequences and emoji with modifiers."
   RenderBlock {DIV} at (0,20) size 784x27
-RenderText {#text} at (0,8) size 21x10
-  text run at (0,8) width 21: "\x{D83D}\x{DE01}"
-  RenderBlock {DIV} at (0,47) size 784x295
-RenderText {#text} at (0,1) size 105x41
-  text run at (0,1) width 105: "\x{D83D}\x{DC66}\x{D83C}\x{DFFB}\x{D83D}\x{DC69}\x{D83C}\x{DFFC}\x{D83D}\x{DC66}\x{D83C}\x{DFFE}\x{2764}\x{FE0F}\x{D83D}\x{DC8B}"
-RenderBR {BR} at (105,34) size 0x0
-RenderText {#text} at (0,60) size 153x41
-  text run at (0,60) width 153: "\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC67} \x{D83D}\x{DC6A} \x{D83D}\x{DC66}\x{D83C}\x{DFFB}\x{D83D}\x{DC69}\x{D83C}\x{DFFC}\x{D83D}\x{DC66}\x{D83C}\x{DFFE}"
-RenderBR {BR} at (153,93) size 0x0
-RenderText {#text} at (0,119) size 141x41
-  text run at (0,119) width 141: "\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC67} \x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC67}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC66}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC69}\x{200D}\x{D83D}\x{DC67}\x{200D}\x{D83D}\x{DC67}"
-RenderBR {BR} at (141,152) size 0x0
-RenderText {#text} at (0,178) size 141x41
-  text run at (0,178) width 141: "\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC67} \x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC67}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC68}\x{200D}\x{D83D}\x{DC66}\x{200D}\x{D83D}\x{DC66} \x{D83D}\x{DC

[webkit-changes] [188735] trunk

[cdumez]

Title: [188735] trunk








Revision 188735
Author cdu...@apple.com
Date 2015-08-20 19:10:29 -0700 (Thu, 20 Aug 2015)


Log Message
getElementsByClassName() should return an HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=147980

Reviewed by Darin Adler.

Source/WebCore:

Update Document.getElementsByClassName() and Element.getElementsByClassName()
to return an HTMLCollection instead of a NodeList, as per the specification:
- https://dom.spec.whatwg.org/#interface-document
- https://dom.spec.whatwg.org/#interface-element

This behavior is also consistent with other major browsers. Due to this and
the fact that NodeList / HTMLCollection pretty much the same API, the
compatibility risk should be fairly low.

I also verified that the performance is the same according to the following
performance test:
PerformanceTests/DOM/get-elements-by-class-name-traversal-uncached.html

Tests: fast/dom/getElementsByClassName/dumpHTMLCollection.html
   fast/dom/getElementsByClassName/return-type.html

* CMakeLists.txt:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
Rename ClassNodeList.cpp file.

* bindings/scripts/CodeGeneratorObjC.pm:
(GetImplClassName):
Indicate that NodeList is implemented as NodeListBase. This is
needed so that DOMNodeList can have either an HTMLCollection or
a NodeList as internal representation. NodeListBase is a new
common base class for HTMLCollection and NodeList.

* dom/ClassCollection.cpp: Renamed from Source/WebCore/dom/ClassNodeList.cpp.
(WebCore::ClassCollection::create):
(WebCore::ClassCollection::~ClassCollection):
* dom/ClassCollection.h: Renamed from Source/WebCore/dom/ClassNodeList.h.
(WebCore::ClassCollection::ClassCollection):
(WebCore::ClassCollection::elementMatches):
Rename ClassNodeList to ClassCollection and have it subclass
CachedHTMLCollection instead of ClassNodeList.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByClassName):
Have getElementsByClassName return an HTMLCollection instead of a
NodeList.

(WebCore::ContainerNode::getElementsByClassNameForObjC):
New method returns a NodeListBase for ObjC bindings, so they can
convert the return value into a DOMNodeList. We need this to not
break ObjC API compatibility.

* dom/Document.idl:
* dom/Element.idl:
Have getElementsByClassName return an HTMLCollection instead of a
NodeList, except for ObjC bindings.

* dom/NodeList.h:
Have NodeList subclass NodeListBase.

* dom/NodeListBase.h: Added.
New common base interface for HTMLCollection and NodeList. This is
so that the internal representation for ObjC's DOMNodeList can be
a NodeListBase instead of a NodeList. This way, the ObjC API can
keep returning a DOMNodeList, even though our implementation now
returns an HTMLCollection instead of a NodeList.

* dom/NodeRareData.h:
(WebCore::NodeListTypeIdentifier::value):
(WebCore::NodeListTypeIdentifier::value):
(WebCore::NodeListTypeIdentifier::value):
(WebCore::NodeListTypeIdentifier::value):
(WebCore::NodeListTypeIdentifier::value):
Drop ClassNodeList from the NodeListTypeIndentifiers.

* html/CollectionType.h:
Add new ByClass CollectionType for ClassCollection.

* html/GenericCachedHTMLCollection.cpp:
(WebCore::GenericCachedHTMLCollection::elementMatches):
Handle new ByClass CollectionType in the switch statement.

* html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::~HTMLCollection):
Add support for new ByClass Collection type.

* html/HTMLCollection.h:
Have HTMLCollection subclass the NodeListBase interface.

LayoutTests:

* fast/dom/getElementsByClassName/dumpHTMLCollection-expected.txt: Renamed from LayoutTests/fast/dom/getElementsByClassName/dumpNodeList-expected.txt.
* fast/dom/getElementsByClassName/dumpHTMLCollection.html: Renamed from LayoutTests/fast/dom/getElementsByClassName/dumpNodeList.html.
Rename test now that getElementsByClassName returns an HTMLCollection
and update the test to update the HTMLCollection prototype instead
of the NodeList one.

* fast/dom/getElementsByClassName/return-type-expected.txt: Added.
* fast/dom/getElementsByClassName/return-type.html: Added.
New test that checks that getElementsByClassName() returns an
HTMLCollection.

* inspector/model/remote-object-expected.txt:
Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/remote-object-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/DOMAllInOne.cpp
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/LiveNodeList.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeList.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/Collec

[webkit-changes] [188736] trunk/WebKitLibraries

[lforschler]

Title: [188736] trunk/WebKitLibraries








Revision 188736
Author lforsch...@apple.com
Date 2015-08-20 19:10:46 -0700 (Thu, 20 Aug 2015)


Log Message
Check in Mavericks LLVM drops built from the LLVM 3.6.2 open source release.

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/LLVMIncludesMavericks.tar.bz2
trunk/WebKitLibraries/LLVMLibrariesMavericks.tar.bz2




Diff

Modified: trunk/WebKitLibraries/ChangeLog (188735 => 188736)

--- trunk/WebKitLibraries/ChangeLog	2015-08-21 02:10:29 UTC (rev 188735)
+++ trunk/WebKitLibraries/ChangeLog	2015-08-21 02:10:46 UTC (rev 188736)
@@ -1,3 +1,11 @@
+2015-08-20  Lucas Forschler  
+
+Check in LLVM 3.6.2 binary drops for OS X Mavericks.
+Check in drops built from the LLVM 3.6.2 open source release. 
+
+* LLVMIncludesMavericks.tar.bz2:
+* LLVMLibrariesMavericks.tar.bz2:
+
 2015-08-12  Lucas Forschler  
 
 Check in LLVM 3.6.2 binary drops for OS X Yosemite


Modified: trunk/WebKitLibraries/LLVMIncludesMavericks.tar.bz2

(Binary files differ)


Modified: trunk/WebKitLibraries/LLVMLibrariesMavericks.tar.bz2

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188734] trunk/Source/WebCore

[mmaxfield]

Title: [188734] trunk/Source/WebCore








Revision 188734
Author mmaxfi...@apple.com
Date 2015-08-20 18:46:36 -0700 (Thu, 20 Aug 2015)


Log Message
Fix the iOS build after r188726
https://bugs.webkit.org/show_bug.cgi?id=148278

Unreviewed.

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::systemFallbackForCharacters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188733 => 188734)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 01:42:21 UTC (rev 188733)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 01:46:36 UTC (rev 188734)
@@ -1,6 +1,17 @@
 2015-08-20  Myles C. Maxfield  
 
+Fix the iOS build after r188726
+https://bugs.webkit.org/show_bug.cgi?id=148278
+
+Unreviewed.
+
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::FontCache::systemFallbackForCharacters):
+
+2015-08-20  Myles C. Maxfield  
+
 Cleanup after r188726
+https://bugs.webkit.org/show_bug.cgi?id=148278
 
 Unreviewed.
 


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (188733 => 188734)

--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-21 01:42:21 UTC (rev 188733)
+++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-21 01:46:36 UTC (rev 188734)
@@ -108,7 +108,12 @@
 return getSystemFontFallbackForCharacters(description, originalFontData, characters, length);
 }
 
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 9
 RetainPtr fallbackFontDescriptor = adoptCF(CTFontCreatePhysicalFontDescriptorForCharactersWithLanguage(originalFontData->getCTFont(), characters, length, nullptr, nullptr));
+#else
+RetainPtr fallbackFont = adoptCF(CTFontCreateForCharactersWithLanguage(originalFontData->getCTFont(), characters, length, nullptr, nullptr));
+RetainPtr fallbackFontDescriptor = adoptCF(CTFontCopyFontDescriptor(fallbackFont.get()));
+#endif
 if (auto foundFontName = adoptCF(static_cast(CTFontDescriptorCopyAttribute(fallbackFontDescriptor.get(), kCTFontNameAttribute {
 if (c >= 0x0600 && c <= 0x06ff) { // Arabic
 auto familyName = adoptCF(static_cast(CTFontDescriptorCopyAttribute(fallbackFontDescriptor.get(), kCTFontFamilyNameAttribute)));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188733] trunk/Source/WebInspectorUI

[drousso]

Title: [188733] trunk/Source/WebInspectorUI








Revision 188733
Author drou...@apple.com
Date 2015-08-20 18:42:21 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Add flex alignment section to Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=148243

Reviewed by Timothy Hatcher.

Uses select keyword pickers to contain the list of possible values.  Also supports
the upcoming Grid layout keywords in the advanced keyword list.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188732 => 188733)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:40:56 UTC (rev 188732)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:42:21 UTC (rev 188733)
@@ -1,5 +1,21 @@
 2015-08-20  Devin Rousso  
 
+Web Inspector: Add flex alignment section to Visual sidebar
+https://bugs.webkit.org/show_bug.cgi?id=148243
+
+Reviewed by Timothy Hatcher.
+
+Uses select keyword pickers to contain the list of possible values.  Also supports
+the upcoming Grid layout keywords in the advanced keyword list.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Views/VisualStyleDetailsPanel.js:
+(WebInspector.VisualStyleDetailsPanel):
+(WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
+(WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
+
+2015-08-20  Devin Rousso  
+
 Web Inspector: Labels in the computed panel are shifted when a filter is applieds
 https://bugs.webkit.org/show_bug.cgi?id=148250
 


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (188732 => 188733)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-08-21 01:40:56 UTC (rev 188732)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-08-21 01:42:21 UTC (rev 188733)
@@ -52,6 +52,7 @@
 localizedStrings["Add new breakpoint action after this action"] = "Add new breakpoint action after this action";
 localizedStrings["Additions"] = "Additions";
 localizedStrings["Align"] = "Align";
+localizedStrings["Alignment"] = "Alignment";
 localizedStrings["All"] = "All";
 localizedStrings["All Changes"] = "All Changes";
 localizedStrings["All Exceptions"] = "All Exceptions";
@@ -507,6 +508,7 @@
 localizedStrings["Selected Items"] = "Selected Items";
 localizedStrings["Selected Symbol"] = "Selected Symbol";
 localizedStrings["Selected Value"] = "Selected Value";
+localizedStrings["Self"] = "Self";
 localizedStrings["Self Time"] = "Self Time";
 localizedStrings["Semantic Issue"] = "Semantic Issue";
 localizedStrings["Session"] = "Session";


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (188732 => 188733)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2015-08-21 01:40:56 UTC (rev 188732)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2015-08-21 01:42:21 UTC (rev 188733)
@@ -70,8 +70,9 @@
 this._generateSection("margin", WebInspector.UIString("Margin"));
 this._generateSection("padding", WebInspector.UIString("Padding"));
 this._generateSection("flexbox", WebInspector.UIString("Flexbox"));
+this._generateSection("alignment", WebInspector.UIString("Alignment"));
 
-this._sections.layout = new WebInspector.DetailsSection("layout", WebInspector.UIString("Layout"), [this._groups.display.section, this._groups.position.section, this._groups.float.section, this._groups.dimensions.section, this._groups.margin.section, this._groups.padding.section, this._groups.flexbox.section]);
+this._sections.layout = new WebInspector.DetailsSection("layout", WebInspector.UIString("Layout"), [this._groups.display.section, this._groups.position.section, this._groups.float.section, this._groups.dimensions.section, this._groups.margin.section, this._groups.padding.section, this._groups.flexbox.section, this._groups.alignment.section]);
 this._element.appendChild(this._sections.layout.element);
 
 // Text Section
@@ -558,8 +559,8 @@
 
 let flexSizeRow = new WebInspector.DetailsSectionRow;
 
-properties.flexGrow = new WebInspector.VisualStyleNumberInputBox("flex-grow", WebInspector.UIString("Grow"), this._keywords.defaults, null);
-properties.flexShrink = new WebInspector.VisualStyleNumberInputBox("flex-shrink", WebInspector.UIString("Shrink"), this._keywords.defaults, null);
+

[webkit-changes] [188732] trunk/Source/WebInspectorUI

[drousso]

Title: [188732] trunk/Source/WebInspectorUI








Revision 188732
Author drou...@apple.com
Date 2015-08-20 18:40:56 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Labels in the computed panel are shifted when a filter is applieds
https://bugs.webkit.org/show_bug.cgi?id=148250

Reviewed by Timothy Hatcher.

Added to the selectors for filtering to ensure they only apply to the rules panel.

* UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
(@media (-webkit-min-device-pixel-ratio: 2)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188731 => 188732)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:38:56 UTC (rev 188731)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:40:56 UTC (rev 188732)
@@ -1,5 +1,29 @@
 2015-08-20  Devin Rousso  
 
+Web Inspector: Labels in the computed panel are shifted when a filter is applieds
+https://bugs.webkit.org/show_bug.cgi?id=148250
+
+Reviewed by Timothy Hatcher.
+
+Added to the selectors for filtering to ensure they only apply to the rules panel.
+
+* UserInterface/Views/RulesStyleDetailsPanel.css:
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
+(@media (-webkit-min-device-pixel-ratio: 2)):
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
+(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.
+
+2015-08-20  Devin Rousso  
+
 Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
 https://bugs.webkit.org/show_bug.cgi?id=148264
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css (188731 => 188732)

--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css	2015-08-21 01:38:56 UTC (rev 188731)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css	20

[webkit-changes] [188731] trunk/Source/WebInspectorUI

[drousso]

Title: [188731] trunk/Source/WebInspectorUI








Revision 188731
Author drou...@apple.com
Date 2015-08-20 18:38:56 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
https://bugs.webkit.org/show_bug.cgi?id=148264

Reviewed by Timothy Hatcher.

* UserInterface/Views/VisualStylePropertyEditorLink.js:
(WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
No longer attempts to set the "hidden" attribute of the link icons before they exist.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188730 => 188731)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:37:40 UTC (rev 188730)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:38:56 UTC (rev 188731)
@@ -1,5 +1,16 @@
 2015-08-20  Devin Rousso  
 
+Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
+https://bugs.webkit.org/show_bug.cgi?id=148264
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/VisualStylePropertyEditorLink.js:
+(WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
+No longer attempts to set the "hidden" attribute of the link icons before they exist.
+
+2015-08-20  Devin Rousso  
+
 Web Inspector: Visual editor adds extra spaces to styles with no properties
 https://bugs.webkit.org/show_bug.cgi?id=148242
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js (188730 => 188731)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js	2015-08-21 01:37:40 UTC (rev 188730)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js	2015-08-21 01:38:56 UTC (rev 188731)
@@ -82,8 +82,13 @@
 {
 this._linked = flag;
 this._element.classList.toggle("linked", this._linked);
-this._linkedIcon.hidden = !this._linked;
-this._unlinkedIcon.hidden = this._linked;
+
+if (this._linkedIcon)
+this._linkedIcon.hidden = !this._linked;
+
+if (this._unlinkedIcon)
+this._unlinkedIcon.hidden = this._linked;
+
 this._iconElement.title = this._linked ? WebInspector.UIString("Click to remove link") : WebInspector.UIString("Click to link property values");
 
 for (let linkToHide of this._linksToHideWhenLinked)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188730] trunk/Source/WebInspectorUI

[drousso]

Title: [188730] trunk/Source/WebInspectorUI








Revision 188730
Author drou...@apple.com
Date 2015-08-20 18:37:40 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Visual editor adds extra spaces to styles with no properties
https://bugs.webkit.org/show_bug.cgi?id=148242

Reviewed by Timothy Hatcher.

* UserInterface/Models/CSSStyleDeclaration.js:
(WebInspector.CSSStyleDeclaration.prototype.set text):
Now trims the text and, if the resulting string has no length or the style is inline,
replaces the text to be set with the trimmed text.

* UserInterface/Views/VisualStylePropertyCombiner.js:
(WebInspector.VisualStylePropertyCombiner.prototype.modifyPropertyText):
Removed unnecessary trim.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188729 => 188730)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:36:18 UTC (rev 188729)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:37:40 UTC (rev 188730)
@@ -1,5 +1,21 @@
 2015-08-20  Devin Rousso  
 
+Web Inspector: Visual editor adds extra spaces to styles with no properties
+https://bugs.webkit.org/show_bug.cgi?id=148242
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Models/CSSStyleDeclaration.js:
+(WebInspector.CSSStyleDeclaration.prototype.set text):
+Now trims the text and, if the resulting string has no length or the style is inline,
+replaces the text to be set with the trimmed text.
+
+* UserInterface/Views/VisualStylePropertyCombiner.js:
+(WebInspector.VisualStylePropertyCombiner.prototype.modifyPropertyText):
+Removed unnecessary trim.
+
+2015-08-20  Devin Rousso  
+
 Web Inspector: Font size between computed and set value is off in visual styles popups
 https://bugs.webkit.org/show_bug.cgi?id=148226
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js (188729 => 188730)

--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js	2015-08-21 01:36:18 UTC (rev 188729)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js	2015-08-21 01:37:40 UTC (rev 188730)
@@ -186,7 +186,14 @@
 if (this._text === text)
 return;
 
-var modified = text !== this._initialText;
+let trimmedText = text.trim();
+if (this._text === trimmedText)
+return;
+
+if (!trimmedText.length || this._type === WebInspector.CSSStyleDeclaration.Type.Inline)
+text = trimmedText;
+
+let modified = text !== this._initialText;
 if (modified !== this._hasModifiedInitialText) {
 this._hasModifiedInitialText = modified;
 this.dispatchEventToListeners(WebInspector.CSSStyleDeclaration.Event.InitialTextModified);


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js (188729 => 188730)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js	2015-08-21 01:36:18 UTC (rev 188729)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js	2015-08-21 01:37:40 UTC (rev 188730)
@@ -77,7 +77,6 @@
 
 modifyPropertyText(text, value)
 {
-let trimmedText = text.trimRight();
 if (this._textContainsNameRegExp.test(text))
 text = text.replace(this._replacementRegExp, value !== null ? "$1$2: " + value + ";" : "$1");
 else if (value !== null)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188729] trunk/Source/WebCore

[mmaxfield]

Title: [188729] trunk/Source/WebCore








Revision 188729
Author mmaxfi...@apple.com
Date 2015-08-20 18:36:18 -0700 (Thu, 20 Aug 2015)


Log Message
Cleanup after r188726

Unreviewed.

No new tests because there is no behavior change.

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::systemFallbackForCharacters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188728 => 188729)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 01:35:32 UTC (rev 188728)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 01:36:18 UTC (rev 188729)
@@ -1,5 +1,16 @@
 2015-08-20  Myles C. Maxfield  
 
+Cleanup after r188726
+
+Unreviewed.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::FontCache::systemFallbackForCharacters):
+
+2015-08-20  Myles C. Maxfield  
+
 [iOS] Delete dead code
 https://bugs.webkit.org/show_bug.cgi?id=148278
 


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (188728 => 188729)

--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-21 01:35:32 UTC (rev 188728)
+++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-21 01:36:18 UTC (rev 188729)
@@ -108,8 +108,6 @@
 return getSystemFontFallbackForCharacters(description, originalFontData, characters, length);
 }
 
-RefPtr font;
-
 RetainPtr fallbackFontDescriptor = adoptCF(CTFontCreatePhysicalFontDescriptorForCharactersWithLanguage(originalFontData->getCTFont(), characters, length, nullptr, nullptr));
 if (auto foundFontName = adoptCF(static_cast(CTFontDescriptorCopyAttribute(fallbackFontDescriptor.get(), kCTFontNameAttribute {
 if (c >= 0x0600 && c <= 0x06ff) { // Arabic
@@ -117,12 +115,10 @@
 if (fontFamilyShouldNotBeUsedForArabic(familyName.get()))
 foundFontName = isFontWeightBold(description.weight()) ? CFSTR("GeezaPro-Bold") : CFSTR("GeezaPro");
 }
-font = fontForFamily(description, foundFontName.get(), false);
+if (RefPtr font = fontForFamily(description, foundFontName.get(), false))
+return font;
 }
 
-if (font)
-return font.release();
-
 return lastResortFallbackFont(description);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188728] trunk/Source/WebInspectorUI

[drousso]

Title: [188728] trunk/Source/WebInspectorUI








Revision 188728
Author drou...@apple.com
Date 2015-08-20 18:35:32 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Font size between computed and set value is off in visual styles popups
https://bugs.webkit.org/show_bug.cgi?id=148226

Reviewed by Timothy Hatcher.

* UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder):
Increased font-size to match the font-size of the overlaid select element.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188727 => 188728)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:33:58 UTC (rev 188727)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:35:32 UTC (rev 188728)
@@ -1,3 +1,14 @@
+2015-08-20  Devin Rousso  
+
+Web Inspector: Font size between computed and set value is off in visual styles popups
+https://bugs.webkit.org/show_bug.cgi?id=148226
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/VisualStylePropertyEditor.css:
+(.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder):
+Increased font-size to match the font-size of the overlaid select element.
+
 2015-08-20  Matt Baker  
 
 Web Inspector: Filtered frames shouldn't be selectable in the Rendering Frames overview graph


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css (188727 => 188728)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css	2015-08-21 01:33:58 UTC (rev 188727)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css	2015-08-21 01:35:32 UTC (rev 188728)
@@ -82,6 +82,7 @@
 border-radius: 4px;
 background-color: white;
 color: hsl(0, 0%, 50%);
+font-size: 11px;
 pointer-events: none;
 overflow: hidden;
 white-space: nowrap;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188726] trunk/Source/WebCore

[mmaxfield]

Title: [188726] trunk/Source/WebCore








Revision 188726
Author mmaxfi...@apple.com
Date 2015-08-20 18:33:37 -0700 (Thu, 20 Aug 2015)


Log Message
[iOS] Delete dead code
https://bugs.webkit.org/show_bug.cgi?id=148278

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

* platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit):
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::copyFontCharacterSet): Deleted.
(WebCore::appleColorEmojiCharacterSet): Deleted.
(WebCore::phoneFallbackCharacterSet): Deleted.
(WebCore::languageSpecificFallbackFont): Deleted.
(WebCore::FontCache::systemFallbackForCharacters): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188725 => 188726)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 01:31:51 UTC (rev 188725)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 01:33:37 UTC (rev 188726)
@@ -1,3 +1,21 @@
+2015-08-20  Myles C. Maxfield  
+
+[iOS] Delete dead code
+https://bugs.webkit.org/show_bug.cgi?id=148278
+
+Reviewed by Dean Jackson.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/cocoa/FontCocoa.mm:
+(WebCore::Font::platformInit):
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::copyFontCharacterSet): Deleted.
+(WebCore::appleColorEmojiCharacterSet): Deleted.
+(WebCore::phoneFallbackCharacterSet): Deleted.
+(WebCore::languageSpecificFallbackFont): Deleted.
+(WebCore::FontCache::systemFallbackForCharacters): Deleted.
+
 2015-08-20  Tim Horton  
 
 Unreviewed, rolling out r188712.


Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm (188725 => 188726)

--- trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm	2015-08-21 01:31:51 UTC (rev 188725)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm	2015-08-21 01:33:37 UTC (rev 188726)
@@ -225,50 +225,18 @@
 m_syntheticBoldOffset = m_platformData.m_syntheticBold ? ceilf(m_platformData.size()  / 24.0f) : 0.f;
 m_spaceGlyph = 0;
 m_spaceWidth = 0;
-unsigned unitsPerEm;
-float ascent;
-float descent;
-float capHeight;
-float lineGap;
-float lineSpacing;
-float xHeight;
-RetainPtr familyName;
-if (CTFontRef ctFont = m_platformData.font()) {
-FontServicesIOS fontService(ctFont);
-ascent = ceilf(fontService.ascent());
-descent = ceilf(fontService.descent());
-lineSpacing = fontService.lineSpacing();
-lineGap = fontService.lineGap();
-xHeight = fontService.xHeight();
-capHeight = fontService.capHeight();
-unitsPerEm = fontService.unitsPerEm();
-familyName = adoptCF(CTFontCopyFamilyName(ctFont));
-} else {
-// FIXME: This else block is dead code. Remove it.
-CGFontRef cgFont = m_platformData.cgFont();
 
-unitsPerEm = CGFontGetUnitsPerEm(cgFont);
+CTFontRef ctFont = m_platformData.font();
+FontServicesIOS fontService(ctFont);
+m_fontMetrics.setUnitsPerEm(fontService.unitsPerEm());
+m_fontMetrics.setAscent(ceilf(fontService.ascent()));
+m_fontMetrics.setDescent(ceilf(fontService.descent()));
+m_fontMetrics.setLineGap(fontService.lineGap());
+m_fontMetrics.setLineSpacing(fontService.lineSpacing());
+m_fontMetrics.setXHeight(fontService.xHeight());
+m_fontMetrics.setCapHeight(fontService.capHeight());
+m_shouldNotBeUsedForArabic = fontFamilyShouldNotBeUsedForArabic(adoptCF(CTFontCopyFamilyName(ctFont)).get());
 
-float pointSize = m_platformData.size();
-ascent = lroundf(scaleEmToUnits(CGFontGetAscent(cgFont), unitsPerEm) * pointSize);
-descent = lroundf(-scaleEmToUnits(-abs(CGFontGetDescent(cgFont)), unitsPerEm) * pointSize);
-lineGap = lroundf(scaleEmToUnits(CGFontGetLeading(cgFont), unitsPerEm) * pointSize);
-xHeight = scaleEmToUnits(CGFontGetXHeight(cgFont), unitsPerEm) * pointSize;
-capHeight = scaleEmToUnits(CGFontGetCapHeight(cgFont), unitsPerEm) * pointSize;
-
-lineSpacing = ascent + descent + lineGap;
-familyName = adoptCF(CGFontCopyFamilyName(cgFont));
-}
-
-m_fontMetrics.setUnitsPerEm(unitsPerEm);
-m_fontMetrics.setAscent(ascent);
-m_fontMetrics.setDescent(descent);
-m_fontMetrics.setLineGap(lineGap);
-m_fontMetrics.setLineSpacing(lineSpacing);
-m_fontMetrics.setXHeight(xHeight);
-m_fontMetrics.setCapHeight(capHeight);
-m_shouldNotBeUsedForArabic = fontFamilyShouldNotBeUsedForArabic(familyName.get());
-
 if (platformData().orientation() == Vertical && !isTextOrientationFallback())
 m_hasVerticalGlyphs = fontHasVerticalGlyphs(m_platformData.ctFont());
 


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (188725 => 188726)

--- trunk/Source/Web

[webkit-changes] [188727] trunk/Source/WebInspectorUI

[mattbaker]

Title: [188727] trunk/Source/WebInspectorUI








Revision 188727
Author mattba...@apple.com
Date 2015-08-20 18:33:58 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Filtered frames shouldn't be selectable in the Rendering Frames overview graph
https://bugs.webkit.org/show_bug.cgi?id=148253

Reviewed by Timothy Hatcher.

* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
Check record's filtered state before setting new frame selection.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188726 => 188727)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:33:37 UTC (rev 188726)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:33:58 UTC (rev 188727)
@@ -1,3 +1,13 @@
+2015-08-20  Matt Baker  
+
+Web Inspector: Filtered frames shouldn't be selectable in the Rendering Frames overview graph
+https://bugs.webkit.org/show_bug.cgi?id=148253
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
+Check record's filtered state before setting new frame selection.
+
 2015-08-20  Devin Rousso  
 
 Web Inspector: visual style number inputs don't style the units correctly


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js (188726 => 188727)

--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js	2015-08-21 01:33:37 UTC (rev 188726)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js	2015-08-21 01:33:58 UTC (rev 188727)
@@ -250,6 +250,9 @@
 return;
 
 var newSelectedRecord = this._renderingFrameTimeline.records[frameIndex];
+if (newSelectedRecord[WebInspector.RenderingFrameTimelineOverviewGraph.RecordWasFilteredSymbol])
+return;
+
 // Clicking the selected frame causes it to be deselected.
 if (this.selectedRecord === newSelectedRecord)
 newSelectedRecord = null;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188725] trunk/Source/WebInspectorUI

[drousso]

Title: [188725] trunk/Source/WebInspectorUI








Revision 188725
Author drou...@apple.com
Date 2015-08-20 18:31:51 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: visual style number inputs don't style the units correctly
https://bugs.webkit.org/show_bug.cgi?id=148222

Reviewed by Timothy Hatcher.

* UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set value):
Added extra checks to see if the number input has a value when setting the value on the editor.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188724 => 188725)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:04:51 UTC (rev 188724)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-21 01:31:51 UTC (rev 188725)
@@ -1,3 +1,14 @@
+2015-08-20  Devin Rousso  
+
+Web Inspector: visual style number inputs don't style the units correctly
+https://bugs.webkit.org/show_bug.cgi?id=148222
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/VisualStyleNumberInputBox.js:
+(WebInspector.VisualStyleNumberInputBox.prototype.set value):
+Added extra checks to see if the number input has a value when setting the value on the editor.
+
 2015-08-20  Matt Baker  
 
 Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js (188724 => 188725)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js	2015-08-21 01:04:51 UTC (rev 188724)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js	2015-08-21 01:31:51 UTC (rev 188725)
@@ -120,18 +120,20 @@
 
 this.specialPropertyPlaceholderElement.hidden = true;
 
+if (!value) {
+this._valueNumberInputElement.value = null;
+this._markUnitsContainerIfInputHasValue();
+return;
+}
+
 if (!isNaN(value)) {
 this._numberInputIsEditable = true;
 this.contentElement.classList.add("number-input-editable");
 this._valueNumberInputElement.value = Math.round(value * 100) / 100;
+this._markUnitsContainerIfInputHasValue();
 return;
 }
 
-if (!value) {
-this._valueNumberInputElement.value = null;
-return;
-}
-
 if (this.valueIsSupportedKeyword(value)) {
 this._numberInputIsEditable = false;
 this.contentElement.classList.remove("number-input-editable");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188723] trunk/Source/WebCore

[timothy_horton]

Title: [188723] trunk/Source/WebCore








Revision 188723
Author timothy_hor...@apple.com
Date 2015-08-20 18:03:23 -0700 (Thu, 20 Aug 2015)


Log Message
Unreviewed, rolling out r188712.
https://bugs.webkit.org/show_bug.cgi?id=148274

broke all the tests (Requested by thorton on #webkit).

Reverted changeset:

"WK1 can re-enter layout during FrameView destruction and
crash"
https://bugs.webkit.org/show_bug.cgi?id=148237
http://trac.webkit.org/changeset/188712

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188722 => 188723)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 00:47:16 UTC (rev 188722)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 01:03:23 UTC (rev 188723)
@@ -1,3 +1,17 @@
+2015-08-20  Tim Horton  
+
+Unreviewed, rolling out r188712.
+https://bugs.webkit.org/show_bug.cgi?id=148274
+
+broke all the tests (Requested by thorton on #webkit).
+
+Reverted changeset:
+
+"WK1 can re-enter layout during FrameView destruction and
+crash"
+https://bugs.webkit.org/show_bug.cgi?id=148237
+http://trac.webkit.org/changeset/188712
+
 2015-08-20  Commit Queue  
 
 Unreviewed, rolling out r188717 and r188719.


Modified: trunk/Source/WebCore/page/FrameView.cpp (188722 => 188723)

--- trunk/Source/WebCore/page/FrameView.cpp	2015-08-21 00:47:16 UTC (rev 188722)
+++ trunk/Source/WebCore/page/FrameView.cpp	2015-08-21 01:03:23 UTC (rev 188723)
@@ -267,14 +267,8 @@
 m_postLayoutTasksTimer.stop();
 
 removeFromAXObjectCache();
+resetScrollbars();
 
-// FIXME: This is a safe fix for rdar://problem/22356782. We won't resetScrollbars() for a FrameView that is in
-// the PageCache because resetting scrollbars can re-enter layout for the Frame's new FrameView, which leads to
-// updating pages in the page cache, which leads to a crash because we're in the process of destroying something
-// in the page cache. We should not be able to get into this mess at all.
-if (frame().view() == this)
-resetScrollbars();
-
 // Custom scrollbars should already be destroyed at this point
 ASSERT(!horizontalScrollbar() || !horizontalScrollbar()->isCustomScrollbar());
 ASSERT(!verticalScrollbar() || !verticalScrollbar()->isCustomScrollbar());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188722] trunk/Source

[commit-queue]

Title: [188722] trunk/Source








Revision 188722
Author commit-qu...@webkit.org
Date 2015-08-20 17:47:16 -0700 (Thu, 20 Aug 2015)


Log Message
Unreviewed, rolling out r188717 and r188719.
https://bugs.webkit.org/show_bug.cgi?id=148272

Broke the Mavericks build (Requested by andersca on #webkit).

Reverted changesets:

"Merge Lock and LockBase"
https://bugs.webkit.org/show_bug.cgi?id=148266
http://trac.webkit.org/changeset/188717

"Merge ConditionBase and Condition"
https://bugs.webkit.org/show_bug.cgi?id=148270
http://trac.webkit.org/changeset/188719

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
trunk/Source/WTF/wtf/Condition.h
trunk/Source/WTF/wtf/Lock.cpp
trunk/Source/WTF/wtf/Lock.h
trunk/Source/WTF/wtf/WordLock.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (188721 => 188722)

--- trunk/Source/WTF/ChangeLog	2015-08-21 00:26:46 UTC (rev 188721)
+++ trunk/Source/WTF/ChangeLog	2015-08-21 00:47:16 UTC (rev 188722)
@@ -1,3 +1,20 @@
+2015-08-20  Commit Queue  
+
+Unreviewed, rolling out r188717 and r188719.
+https://bugs.webkit.org/show_bug.cgi?id=148272
+
+Broke the Mavericks build (Requested by andersca on #webkit).
+
+Reverted changesets:
+
+"Merge Lock and LockBase"
+https://bugs.webkit.org/show_bug.cgi?id=148266
+http://trac.webkit.org/changeset/188717
+
+"Merge ConditionBase and Condition"
+https://bugs.webkit.org/show_bug.cgi?id=148270
+http://trac.webkit.org/changeset/188719
+
 2015-08-20  Anders Carlsson  
 
 Merge ConditionBase and Condition


Modified: trunk/Source/WTF/wtf/Atomics.h (188721 => 188722)

--- trunk/Source/WTF/wtf/Atomics.h	2015-08-21 00:26:46 UTC (rev 188721)
+++ trunk/Source/WTF/wtf/Atomics.h	2015-08-21 00:47:16 UTC (rev 188722)
@@ -81,12 +81,6 @@
 
 template
 struct Atomic {
-Atomic() = default;
-CONSTEXPR Atomic(T value)
-: value(value)
-{
-}
-
 // Don't pass a non-default value for the order parameter unless you really know
 // what you are doing and have thought about it very hard. The cost of seq_cst
 // is usually not high enough to justify the risk.


Modified: trunk/Source/WTF/wtf/Condition.h (188721 => 188722)

--- trunk/Source/WTF/wtf/Condition.h	2015-08-21 00:26:46 UTC (rev 188721)
+++ trunk/Source/WTF/wtf/Condition.h	2015-08-21 00:47:16 UTC (rev 188722)
@@ -43,7 +43,9 @@
 // case where no thread is waiting. This condition variable, when used with WTF::Lock, can
 // outperform a system condition variable and lock by up to 58x.
 
-struct Condition {
+// This is a struct without a constructor or destructor so that it can be statically initialized.
+// Use Lock in instance variables.
+struct ConditionBase {
 typedef ParkingLot::Clock Clock;
 
 // Wait on a parking queue while releasing the given lock. It will unlock the lock just before
@@ -226,12 +228,24 @@
 return Clock::now() + myRelativeTimeout;
 }
 
-Atomic m_hasWaiters { false };
+Atomic m_hasWaiters;
 };
 
+class Condition : public ConditionBase {
+WTF_MAKE_NONCOPYABLE(Condition);
+public:
+Condition()
+{
+m_hasWaiters.store(false);
+}
+};
+
+typedef ConditionBase StaticCondition;
+
 } // namespace WTF
 
 using WTF::Condition;
+using WTF::StaticCondition;
 
 #endif // WTF_Condition_h
 


Modified: trunk/Source/WTF/wtf/Lock.cpp (188721 => 188722)

--- trunk/Source/WTF/wtf/Lock.cpp	2015-08-21 00:26:46 UTC (rev 188721)
+++ trunk/Source/WTF/wtf/Lock.cpp	2015-08-21 00:47:16 UTC (rev 188722)
@@ -36,7 +36,7 @@
 
 static const bool verbose = false;
 
-void Lock::lockSlow()
+void LockBase::lockSlow()
 {
 unsigned spinCount = 0;
 
@@ -74,7 +74,7 @@
 }
 }
 
-void Lock::unlockSlow()
+void LockBase::unlockSlow()
 {
 // We could get here because the weak CAS in unlock() failed spuriously, or because there is
 // someone parked. So, we need a CAS loop: even if right now the lock is just held, it could


Modified: trunk/Source/WTF/wtf/Lock.h (188721 => 188722)

--- trunk/Source/WTF/wtf/Lock.h	2015-08-21 00:26:46 UTC (rev 188721)
+++ trunk/Source/WTF/wtf/Lock.h	2015-08-21 00:47:16 UTC (rev 188722)
@@ -43,7 +43,9 @@
 // cannot be acquired in a short period of time, the thread is put to sleep until the lock is available
 // again). It uses less memory than a std::mutex.
 
-struct Lock {
+// This is a struct without a constructor or destructor so that it can be statically initialized.
+// Use Lock in instance variables.
+struct LockBase {
 void lock()
 {
 if (LIKELY(m_byte.compareExchangeWeak(0, isHeldBit, std::memory_order_acquire))) {
@@ -106,13 +108,20 @@
 return !m_byte.load();
 }
 
-Atomic m_byte { 0 };
+Atomic m_byte;
 };
 
-typedef Locker LockHolder;
+class Lock : public LockBase {
+WTF_MAKE_NONCOPYABLE(Lock);
+public:
+Lock()
+{
+m_byte.store(0, std::me

[webkit-changes] [188720] trunk

[fpizlo]

Title: [188720] trunk








Revision 188720
Author fpi...@apple.com
Date 2015-08-20 17:26:41 -0700 (Thu, 20 Aug 2015)


Log Message
Overflow check elimination fails for a simple test case
https://bugs.webkit.org/show_bug.cgi?id=147387

Reviewed by Benjamin Poulain.

Source/_javascript_Core:

Overflow check elimination was having issues when things got constant-folded, because whereas an
Add or LessThan operation teaches us about relationships between the things being added or
compared, we don't do that when we see a JSConstant. We don't create a relationship between every
JSConstant and every other JSConstant. So, if we constant-fold an Add, we forget the relationships
that it would have had with its inputs.

One solution would be to have every JSConstant create a relationship with every other JSConstant.
This is dangerous, since it would create O(n^2) explosion of relationships.

Instead, this patch teaches filtration and merging how to behave "as if" there were inter-constant
relationships. Normally those operations only work on two relationships involving the same node
pair. But now, if we have @x op @c and @x op @d, where @c and @d are different nodes but both are
constants, we will do merging or filtering by grokking the constant values.

This speeds up lots of tests in JSRegress, because it enables overflow check elimination on things
like:

for (var i = 0; i < 100; ++i)

Previously, the fact that this was all constants would throw off the analysis because the analysis
wouldn't "know" that 0 < 100.

* dfg/DFGIntegerRangeOptimizationPhase.cpp:

LayoutTests:

Added two test cases that previously would have an unnecessary overflow check on an induction
variable. These tests speed up by 10-15% thanks to this change.

Also added .html/expected files for some regress test that didn't have them.

* js/regress/function-call-expected.txt: Added.
* js/regress/function-call.html: Added.
* js/regress/hard-overflow-check-equal-expected.txt: Added.
* js/regress/hard-overflow-check-equal.html: Added.
* js/regress/hard-overflow-check-expected.txt: Added.
* js/regress/hard-overflow-check.html: Added.
* js/regress/script-tests/hard-overflow-check-equal.js: Added.
(foo):
* js/regress/script-tests/hard-overflow-check.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp


Added Paths

trunk/LayoutTests/js/regress/function-call-expected.txt
trunk/LayoutTests/js/regress/function-call.html
trunk/LayoutTests/js/regress/hard-overflow-check-equal-expected.txt
trunk/LayoutTests/js/regress/hard-overflow-check-equal.html
trunk/LayoutTests/js/regress/hard-overflow-check-expected.txt
trunk/LayoutTests/js/regress/hard-overflow-check.html
trunk/LayoutTests/js/regress/script-tests/hard-overflow-check-equal.js
trunk/LayoutTests/js/regress/script-tests/hard-overflow-check.js




Diff

Modified: trunk/LayoutTests/ChangeLog (188719 => 188720)

--- trunk/LayoutTests/ChangeLog	2015-08-21 00:11:10 UTC (rev 188719)
+++ trunk/LayoutTests/ChangeLog	2015-08-21 00:26:41 UTC (rev 188720)
@@ -1,3 +1,26 @@
+2015-08-20  Filip Pizlo  
+
+Overflow check elimination fails for a simple test case
+https://bugs.webkit.org/show_bug.cgi?id=147387
+
+Reviewed by Benjamin Poulain.
+
+Added two test cases that previously would have an unnecessary overflow check on an induction
+variable. These tests speed up by 10-15% thanks to this change.
+
+Also added .html/expected files for some regress test that didn't have them.
+
+* js/regress/function-call-expected.txt: Added.
+* js/regress/function-call.html: Added.
+* js/regress/hard-overflow-check-equal-expected.txt: Added.
+* js/regress/hard-overflow-check-equal.html: Added.
+* js/regress/hard-overflow-check-expected.txt: Added.
+* js/regress/hard-overflow-check.html: Added.
+* js/regress/script-tests/hard-overflow-check-equal.js: Added.
+(foo):
+* js/regress/script-tests/hard-overflow-check.js: Added.
+(foo):
+
 2015-08-20  Nan Wang  
 
 AX: Fix accessibility/mac/selection-value-changes-for-aria-textbox.html test


Added: trunk/LayoutTests/js/regress/function-call-expected.txt (0 => 188720)

--- trunk/LayoutTests/js/regress/function-call-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/regress/function-call-expected.txt	2015-08-21 00:26:41 UTC (rev 188720)
@@ -0,0 +1,10 @@
+JSRegress/function-call
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/regress/function-call.html (0 => 188720)

--- trunk/LayoutTests/js/regress/function-call.html	(rev 0)
+++ trunk/LayoutTests/js/regress/function-call.html	2015-08-21 00:26:41 UTC (rev 188720)
@@ -0,0 +1,12 @@
+
+
+
+

[webkit-changes] [188721] trunk/Tools

[drousso]

Title: [188721] trunk/Tools








Revision 188721
Author drou...@apple.com
Date 2015-08-20 17:26:46 -0700 (Thu, 20 Aug 2015)


Log Message
Unreviewed, changed Devin Rousso's email.

Patch by Devin Rousso  on 2015-08-20

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (188720 => 188721)

--- trunk/Tools/ChangeLog	2015-08-21 00:26:41 UTC (rev 188720)
+++ trunk/Tools/ChangeLog	2015-08-21 00:26:46 UTC (rev 188721)
@@ -1,3 +1,9 @@
+2015-08-20  Devin Rousso  
+
+Unreviewed, changed Devin Rousso's email.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2015-08-20  Anders Carlsson  
 
 Use WKPageConfigurationRef in WebKitTestRunner


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (188720 => 188721)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-08-21 00:26:41 UTC (rev 188720)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-08-21 00:26:46 UTC (rev 188721)
@@ -720,7 +720,7 @@
   },
   "Devin Rousso" : {
  "emails" : [
-"drou...@apple.com"
+"dcrousso+web...@gmail.com"
  ],
  "nicks" : [
 "drousso"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188719] trunk/Source

[andersca]

Title: [188719] trunk/Source








Revision 188719
Author ander...@apple.com
Date 2015-08-20 17:11:10 -0700 (Thu, 20 Aug 2015)


Log Message
Merge ConditionBase and Condition
https://bugs.webkit.org/show_bug.cgi?id=148270

Reviewed by Filip Pizlo.

Source/WebCore:

Change StaticCondition to Condition.

* platform/network/cf/LoaderRunLoopCF.cpp:

Source/WTF:

* wtf/Condition.h:
Direct initialize m_hasWaiters so Condition gets a constexpr constructor.

* wtf/Lock.h:
Remove a now outdated comment.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Condition.h
trunk/Source/WTF/wtf/Lock.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (188718 => 188719)

--- trunk/Source/WTF/ChangeLog	2015-08-21 00:01:11 UTC (rev 188718)
+++ trunk/Source/WTF/ChangeLog	2015-08-21 00:11:10 UTC (rev 188719)
@@ -1,5 +1,18 @@
 2015-08-20  Anders Carlsson  
 
+Merge ConditionBase and Condition
+https://bugs.webkit.org/show_bug.cgi?id=148270
+
+Reviewed by Filip Pizlo.
+
+* wtf/Condition.h:
+Direct initialize m_hasWaiters so Condition gets a constexpr constructor.
+
+* wtf/Lock.h:
+Remove a now outdated comment.
+
+2015-08-20  Anders Carlsson  
+
 Merge Lock and LockBase
 https://bugs.webkit.org/show_bug.cgi?id=148266
 


Modified: trunk/Source/WTF/wtf/Condition.h (188718 => 188719)

--- trunk/Source/WTF/wtf/Condition.h	2015-08-21 00:01:11 UTC (rev 188718)
+++ trunk/Source/WTF/wtf/Condition.h	2015-08-21 00:11:10 UTC (rev 188719)
@@ -43,9 +43,7 @@
 // case where no thread is waiting. This condition variable, when used with WTF::Lock, can
 // outperform a system condition variable and lock by up to 58x.
 
-// This is a struct without a constructor or destructor so that it can be statically initialized.
-// Use Lock in instance variables.
-struct ConditionBase {
+struct Condition {
 typedef ParkingLot::Clock Clock;
 
 // Wait on a parking queue while releasing the given lock. It will unlock the lock just before
@@ -228,24 +226,12 @@
 return Clock::now() + myRelativeTimeout;
 }
 
-Atomic m_hasWaiters;
+Atomic m_hasWaiters { false };
 };
 
-class Condition : public ConditionBase {
-WTF_MAKE_NONCOPYABLE(Condition);
-public:
-Condition()
-{
-m_hasWaiters.store(false);
-}
-};
-
-typedef ConditionBase StaticCondition;
-
 } // namespace WTF
 
 using WTF::Condition;
-using WTF::StaticCondition;
 
 #endif // WTF_Condition_h
 


Modified: trunk/Source/WTF/wtf/Lock.h (188718 => 188719)

--- trunk/Source/WTF/wtf/Lock.h	2015-08-21 00:01:11 UTC (rev 188718)
+++ trunk/Source/WTF/wtf/Lock.h	2015-08-21 00:11:10 UTC (rev 188719)
@@ -43,8 +43,6 @@
 // cannot be acquired in a short period of time, the thread is put to sleep until the lock is available
 // again). It uses less memory than a std::mutex.
 
-// This is a struct without a constructor or destructor so that it can be statically initialized.
-// Use Lock in instance variables.
 struct Lock {
 void lock()
 {


Modified: trunk/Source/WebCore/ChangeLog (188718 => 188719)

--- trunk/Source/WebCore/ChangeLog	2015-08-21 00:01:11 UTC (rev 188718)
+++ trunk/Source/WebCore/ChangeLog	2015-08-21 00:11:10 UTC (rev 188719)
@@ -1,5 +1,16 @@
 2015-08-20  Anders Carlsson  
 
+Merge ConditionBase and Condition
+https://bugs.webkit.org/show_bug.cgi?id=148270
+
+Reviewed by Filip Pizlo.
+
+Change StaticCondition to Condition.
+
+* platform/network/cf/LoaderRunLoopCF.cpp:
+
+2015-08-20  Anders Carlsson  
+
 Stop using cancelCallOnMainThread in MediaPlayerPrivateMediaFoundation
 https://bugs.webkit.org/show_bug.cgi?id=148252
 


Modified: trunk/Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp (188718 => 188719)

--- trunk/Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp	2015-08-21 00:01:11 UTC (rev 188718)
+++ trunk/Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp	2015-08-21 00:11:10 UTC (rev 188719)
@@ -43,7 +43,7 @@
 static CFRunLoopRef loaderRunLoopObject = 0;
 
 static StaticLock loaderRunLoopMutex;
-static StaticCondition loaderRunLoopConditionVariable;
+static Condition loaderRunLoopConditionVariable;
 
 static void emptyPerform(void*) 
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188718] trunk

[timothy_horton]

Title: [188718] trunk








Revision 188718
Author timothy_hor...@apple.com
Date 2015-08-20 17:01:11 -0700 (Thu, 20 Aug 2015)


Log Message
Use WKPageConfigurationRef in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=147996

Reviewed by Tim Horton.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::createWebViewWithOptions):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
(WTR::PlatformWebView::PlatformWebView):
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.

* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _commonInitializationWithConfigurationRef:]):
(-[WKView initWithFrame:configurationRef:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:configurationRef:]):
Make sure to copy the configuration, matching what we do in the modern API.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/PlatformWebView.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188717 => 188718)

--- trunk/Source/WebKit2/ChangeLog	2015-08-21 00:00:29 UTC (rev 188717)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-21 00:01:11 UTC (rev 188718)
@@ -1,3 +1,17 @@
+2015-08-20  Anders Carlsson  
+
+Use WKPageConfigurationRef in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=147996
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/ios/WKViewIOS.mm:
+(-[WKView _commonInitializationWithConfigurationRef:]):
+(-[WKView initWithFrame:configurationRef:]):
+* UIProcess/API/mac/WKView.mm:
+(-[WKView initWithFrame:configurationRef:]):
+Make sure to copy the configuration, matching what we do in the modern API.
+
 2015-08-20  Beth Dakin  
 
 Standalone image documents should send their size to the UIClient just like 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (188717 => 188718)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2015-08-21 00:00:29 UTC (rev 188717)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2015-08-21 00:01:11 UTC (rev 188718)
@@ -38,6 +38,7 @@
 #if TARGET_OS_IPHONE
 - (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef;
 - (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage;
+- (id)initWithFrame:(CGRect)frame configurationRef:(WKPageConfigurationRef)configuration;
 #else
 - (id)initWithFrame:(NSRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef;
 - (id)initWithFrame:(NSRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage;


Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm (188717 => 188718)

--- trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm	2015-08-21 00:00:29 UTC (rev 188717)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm	2015-08-21 00:01:11 UTC (rev 188718)
@@ -35,6 +35,7 @@
 #import "WKAPICast.h"
 #import "WKBrowsingContextGroupPrivate.h"
 #import "WKContentView.h"
+#import "WKPageConfigurationRef.h"
 #import "WKProcessGroupPrivate.h"
 #import "WKScrollView.h"
 #import "WebPageGroup.h"
@@ -86,7 +87,12 @@
 if (!(self = [super initWithFrame:frame]))
 return nil;
 
-[self _commonInitializationWithContextRef:processGroup._contextRef pageGroupRef:browsingContextGroup._pageGroupRef relatedToPage:relatedView ? [relatedView pageRef] : nullptr];
+auto configuration = API::PageConfiguration::create();
+configuration->setProcessPool(toImpl(processGroup._contextRef));
+configuration->setPageGroup(toImpl(browsingContextGroup._pageGroupRef));
+configuration->setRelatedPage(relatedView ? toImpl([relatedView pageRef]) : nullptr);
+
+[self _commonInitializationWithConfigurationRef:toAPI(configuration.ptr())];
 return self;
 }
 
@@ -214,7 +220,7 @@
 
 #pragma mark Internal
 
-- (void)_commonInitializationWithContextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage
+- (void)_commonInitializationWithConfigurationRef:(WKPageConfigurationRef)configurationRef
 {
 ASSERT(!_scrollView);
 ASSERT(!_contentView);
@@ -226,12 +232,9 @@
 
 [self addSubview:_scrollView.get()];
 
-auto configuration = API::PageConfiguration::create();
-configuration->setProcessPool(toImpl(contextRe

[webkit-changes] [188717] trunk/Source/WTF

[andersca]

Title: [188717] trunk/Source/WTF








Revision 188717
Author ander...@apple.com
Date 2015-08-20 17:00:29 -0700 (Thu, 20 Aug 2015)


Log Message
Merge Lock and LockBase
https://bugs.webkit.org/show_bug.cgi?id=148266

Reviewed by Filip Pizlo.

* wtf/Atomics.h:
(WTF::Atomic::Atomic):
Add a default constructor as well as a constexpr constructor that takes a value.

* wtf/Lock.cpp:
(WTF::Lock::lockSlow):
(WTF::Lock::unlockSlow):
Rename LockBase to Lock.

* wtf/Lock.h:
Rename LockBase to Lock and direct-initialize Atomic to 0. Since the Atomic constructor is constexpr,
Lock also gets a constexpr constructor. Change the LockBase -> StaticLock typedef and add a fixme.

* wtf/WordLock.h:
Direct initialize m_word to 0.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
trunk/Source/WTF/wtf/Lock.cpp
trunk/Source/WTF/wtf/Lock.h
trunk/Source/WTF/wtf/WordLock.h




Diff

Modified: trunk/Source/WTF/ChangeLog (188716 => 188717)

--- trunk/Source/WTF/ChangeLog	2015-08-20 23:06:13 UTC (rev 188716)
+++ trunk/Source/WTF/ChangeLog	2015-08-21 00:00:29 UTC (rev 188717)
@@ -1,3 +1,26 @@
+2015-08-20  Anders Carlsson  
+
+Merge Lock and LockBase
+https://bugs.webkit.org/show_bug.cgi?id=148266
+
+Reviewed by Filip Pizlo.
+
+* wtf/Atomics.h:
+(WTF::Atomic::Atomic):
+Add a default constructor as well as a constexpr constructor that takes a value.
+
+* wtf/Lock.cpp:
+(WTF::Lock::lockSlow):
+(WTF::Lock::unlockSlow):
+Rename LockBase to Lock.
+
+* wtf/Lock.h:
+Rename LockBase to Lock and direct-initialize Atomic to 0. Since the Atomic constructor is constexpr,
+Lock also gets a constexpr constructor. Change the LockBase -> StaticLock typedef and add a fixme.
+
+* wtf/WordLock.h:
+Direct initialize m_word to 0.
+
 2015-08-19  Filip Pizlo  
 
 Remove WTF::SpinLock


Modified: trunk/Source/WTF/wtf/Atomics.h (188716 => 188717)

--- trunk/Source/WTF/wtf/Atomics.h	2015-08-20 23:06:13 UTC (rev 188716)
+++ trunk/Source/WTF/wtf/Atomics.h	2015-08-21 00:00:29 UTC (rev 188717)
@@ -81,6 +81,12 @@
 
 template
 struct Atomic {
+Atomic() = default;
+CONSTEXPR Atomic(T value)
+: value(value)
+{
+}
+
 // Don't pass a non-default value for the order parameter unless you really know
 // what you are doing and have thought about it very hard. The cost of seq_cst
 // is usually not high enough to justify the risk.


Modified: trunk/Source/WTF/wtf/Lock.cpp (188716 => 188717)

--- trunk/Source/WTF/wtf/Lock.cpp	2015-08-20 23:06:13 UTC (rev 188716)
+++ trunk/Source/WTF/wtf/Lock.cpp	2015-08-21 00:00:29 UTC (rev 188717)
@@ -36,7 +36,7 @@
 
 static const bool verbose = false;
 
-void LockBase::lockSlow()
+void Lock::lockSlow()
 {
 unsigned spinCount = 0;
 
@@ -74,7 +74,7 @@
 }
 }
 
-void LockBase::unlockSlow()
+void Lock::unlockSlow()
 {
 // We could get here because the weak CAS in unlock() failed spuriously, or because there is
 // someone parked. So, we need a CAS loop: even if right now the lock is just held, it could


Modified: trunk/Source/WTF/wtf/Lock.h (188716 => 188717)

--- trunk/Source/WTF/wtf/Lock.h	2015-08-20 23:06:13 UTC (rev 188716)
+++ trunk/Source/WTF/wtf/Lock.h	2015-08-21 00:00:29 UTC (rev 188717)
@@ -45,7 +45,7 @@
 
 // This is a struct without a constructor or destructor so that it can be statically initialized.
 // Use Lock in instance variables.
-struct LockBase {
+struct Lock {
 void lock()
 {
 if (LIKELY(m_byte.compareExchangeWeak(0, isHeldBit, std::memory_order_acquire))) {
@@ -108,20 +108,13 @@
 return !m_byte.load();
 }
 
-Atomic m_byte;
+Atomic m_byte { 0 };
 };
 
-class Lock : public LockBase {
-WTF_MAKE_NONCOPYABLE(Lock);
-public:
-Lock()
-{
-m_byte.store(0, std::memory_order_relaxed);
-}
-};
+typedef Locker LockHolder;
 
-typedef LockBase StaticLock;
-typedef Locker LockHolder;
+// FIXME: Once all clients have been moved from StaticLock to Lock we can get rid of this typedef.
+typedef Lock StaticLock;
 
 } // namespace WTF
 


Modified: trunk/Source/WTF/wtf/WordLock.h (188716 => 188717)

--- trunk/Source/WTF/wtf/WordLock.h	2015-08-20 23:06:13 UTC (rev 188716)
+++ trunk/Source/WTF/wtf/WordLock.h	2015-08-21 00:00:29 UTC (rev 188717)
@@ -45,10 +45,7 @@
 class WordLock {
 WTF_MAKE_NONCOPYABLE(WordLock);
 public:
-WordLock()
-{
-m_word.store(0, std::memory_order_relaxed);
-}
+CONSTEXPR WordLock() = default;
 
 void lock()
 {
@@ -96,7 +93,7 @@
 return !m_word.load();
 }
 
-Atomic m_word;
+Atomic m_word { 0 };
 };
 
 typedef Locker WordLockHolder;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188716] trunk/Source/WebCore

[andersca]

Title: [188716] trunk/Source/WebCore








Revision 188716
Author ander...@apple.com
Date 2015-08-20 16:06:13 -0700 (Thu, 20 Aug 2015)


Log Message
Stop using cancelCallOnMainThread in MediaPlayerPrivateMediaFoundation
https://bugs.webkit.org/show_bug.cgi?id=148252

Reviewed by Tim Horton.

Replace cancelCallOnMainThread with WeakPtrs.

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSourceCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySetCallback):
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188715 => 188716)

--- trunk/Source/WebCore/ChangeLog	2015-08-20 22:57:57 UTC (rev 188715)
+++ trunk/Source/WebCore/ChangeLog	2015-08-20 23:06:13 UTC (rev 188716)
@@ -1,3 +1,21 @@
+2015-08-20  Anders Carlsson  
+
+Stop using cancelCallOnMainThread in MediaPlayerPrivateMediaFoundation
+https://bugs.webkit.org/show_bug.cgi?id=148252
+
+Reviewed by Tim Horton.
+
+Replace cancelCallOnMainThread with WeakPtrs.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation):
+(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
+(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
+(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
+(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSourceCallback):
+(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySetCallback):
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+
 2015-08-20  Beth Dakin  
 
 WK1 can re-enter layout during FrameView destruction and crash


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (188715 => 188716)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-20 22:57:57 UTC (rev 188715)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp	2015-08-20 23:06:13 UTC (rev 188716)
@@ -62,12 +62,7 @@
 , m_hasVideo(false)
 , m_hwndVideo(nullptr)
 , m_readyState(MediaPlayer::HaveNothing)
-, m_mediaSession(nullptr)
-, m_sourceResolver(nullptr)
-, m_mediaSource(nullptr)
-, m_topology(nullptr)
-, m_sourcePD(nullptr)
-, m_videoDisplay(nullptr)
+, m_weakPtrFactory(this)
 {
 createSession();
 createVideoWindow();
@@ -78,8 +73,6 @@
 notifyDeleted();
 destroyVideoWindow();
 endSession();
-cancelCallOnMainThread(onTopologySetCallback, this);
-cancelCallOnMainThread(onCreatedMediaSourceCallback, this);
 }
 
 void MediaPlayerPrivateMediaFoundation::registerMediaEngine(MediaEngineRegistrar registrar)
@@ -342,7 +335,12 @@
 hr = asyncResult->GetStatus();
 m_loadingProgress = SUCCEEDED(hr);
 
-callOnMainThread(onCreatedMediaSourceCallback, this);
+auto weakPtr = m_weakFactory.createWeakPtr();
+callOnMainThread([weakPtr] {
+if (!weakPtr)
+return;
+weakPtr->onCreatedMediaSource();
+});
 
 return true;
 }
@@ -367,7 +365,12 @@
 
 switch (mediaEventType) {
 case MESessionTopologySet:
-callOnMainThread(onTopologySetCallback, this);
+auto weakPtr = m_weakFactory.createWeakPtr();
+callOnMainThread([weakPtr] {
+if (!weakPtr)
+return;
+weakPtr->onTopologySet();
+});
 break;
 
 case MESessionClosed:
@@ -643,18 +646,6 @@
 m_player->playbackStateChanged();
 }
 
-void MediaPlayerPrivateMediaFoundation::onCreatedMediaSourceCallback(void* context)
-{
-MediaPlayerPrivateMediaFoundation* mediaPlayer = static_cast(context);
-mediaPlayer->onCreatedMediaSource();
-}
-
-void MediaPlayerPrivateMediaFoundation::onTopologySetCallback(void* context)
-{
-MediaPlayerPrivateMediaFoundation* mediaPlayer = static_cast(context);
-mediaPlayer->onTopologySet();
-}
-
 MediaPlayerPrivateMediaFoundation::AsyncCallback::AsyncCallback(MediaPlayerPrivateMediaFoundation* mediaPlayer, bool event)
 : m_refCount(0)
 , m_mediaPlayer(mediaPlayer)


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (188715 => 188716)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h	2015-08-20 22:57:57 UTC (r

[webkit-changes] [188715] trunk/Source/JavaScriptCore

[ggaren]

Title: [188715] trunk/Source/_javascript_Core








Revision 188715
Author gga...@apple.com
Date 2015-08-20 15:57:57 -0700 (Thu, 20 Aug 2015)


Log Message
2015-08-20  Geoffrey Garen  

forEachCodeBlock should wait for all CodeBlocks automatically
https://bugs.webkit.org/show_bug.cgi?id=148255

Add back a line of code I deleted by accident in my last patch due to
incorrect merge.

Unreviewed.

* runtime/VM.cpp:
(JSC::VM::deleteAllCode):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188714 => 188715)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-20 22:53:24 UTC (rev 188714)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-20 22:57:57 UTC (rev 188715)
@@ -3,6 +3,19 @@
 forEachCodeBlock should wait for all CodeBlocks automatically
 https://bugs.webkit.org/show_bug.cgi?id=148255
 
+Add back a line of code I deleted by accident in my last patch due to
+incorrect merge.
+
+Unreviewed.
+
+* runtime/VM.cpp:
+(JSC::VM::deleteAllCode):
+
+2015-08-20  Geoffrey Garen  
+
+forEachCodeBlock should wait for all CodeBlocks automatically
+https://bugs.webkit.org/show_bug.cgi?id=148255
+
 Reviewed by Saam Barati.
 
 Previously, all clients needed to wait manually before calling


Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (188714 => 188715)

--- trunk/Source/_javascript_Core/runtime/VM.cpp	2015-08-20 22:53:24 UTC (rev 188714)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2015-08-20 22:57:57 UTC (rev 188715)
@@ -479,6 +479,7 @@
 DFG::completeAllPlansForVM(*this);
 #endif
 heap.deleteAllCompiledCode();
+heap.deleteAllUnlinkedFunctionCode();
 heap.reportAbandonedObjectGraph();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188714] trunk/Source/JavaScriptCore

[ggaren]

Title: [188714] trunk/Source/_javascript_Core








Revision 188714
Author gga...@apple.com
Date 2015-08-20 15:53:24 -0700 (Thu, 20 Aug 2015)


Log Message
forEachCodeBlock should wait for all CodeBlocks automatically
https://bugs.webkit.org/show_bug.cgi?id=148255

Reviewed by Saam Barati.

Previously, all clients needed to wait manually before calling
forEachCodeBlock. That's easy to get wrong, and at least one place
got it wrong. Let's do this automatically instead.

* debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
(JSC::Debugger::setSteppingMode):
(JSC::Debugger::toggleBreakpoint): No need to wait manually;
forEachCodeBlock will do it automatically now.

(JSC::Debugger::recompileAllJSFunctions): We still need to wait manually
here because this is an iteration of the heap, which does not wait
automatically. Use the new helper function for waiting.

(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::clearDebuggerRequests):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::forEachCodeBlock): Deleted. No need to wait manually.

* debugger/Debugger.h:

* dfg/DFGWorklist.cpp:
(JSC::DFG::completeAllPlansForVM):
* dfg/DFGWorklist.h:
(JSC::DFG::completeAllPlansForVM): Added a helper function that replaces
vm.prepareToDeleteCode. This new function is clearer because we need
to call it sometimes even if we are not going to delete code.

* heap/HeapInlines.h:
(JSC::Heap::forEachCodeBlock): Moved.

* inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::recompileAllJSFunctionsForTypeProfiling): Use the new helper
function.

* runtime/JSCInlines.h:
(JSC::Heap::forEachCodeBlock): Do the waiting automatically.

* runtime/VM.cpp:
(JSC::VM::stopSampling):
(JSC::VM::deleteAllCode):
(JSC::VM::setEnabledProfiler):
(JSC::VM::prepareToDeleteCode): Deleted.
* runtime/VM.h: No need to wait manually.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/debugger/Debugger.cpp
trunk/Source/_javascript_Core/debugger/Debugger.h
trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp
trunk/Source/_javascript_Core/dfg/DFGWorklist.h
trunk/Source/_javascript_Core/heap/HeapInlines.h
trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp
trunk/Source/_javascript_Core/runtime/JSCInlines.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188713 => 188714)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-20 22:51:21 UTC (rev 188713)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-20 22:53:24 UTC (rev 188714)
@@ -1,3 +1,55 @@
+2015-08-20  Geoffrey Garen  
+
+forEachCodeBlock should wait for all CodeBlocks automatically
+https://bugs.webkit.org/show_bug.cgi?id=148255
+
+Reviewed by Saam Barati.
+
+Previously, all clients needed to wait manually before calling
+forEachCodeBlock. That's easy to get wrong, and at least one place
+got it wrong. Let's do this automatically instead.
+
+* debugger/Debugger.cpp:
+(JSC::Debugger::Debugger):
+(JSC::Debugger::setSteppingMode):
+(JSC::Debugger::toggleBreakpoint): No need to wait manually;
+forEachCodeBlock will do it automatically now.
+
+(JSC::Debugger::recompileAllJSFunctions): We still need to wait manually
+here because this is an iteration of the heap, which does not wait
+automatically. Use the new helper function for waiting.
+
+(JSC::Debugger::clearBreakpoints):
+(JSC::Debugger::clearDebuggerRequests):
+(JSC::Debugger::setBreakpointsActivated):
+(JSC::Debugger::forEachCodeBlock): Deleted. No need to wait manually.
+
+* debugger/Debugger.h:
+
+* dfg/DFGWorklist.cpp:
+(JSC::DFG::completeAllPlansForVM):
+* dfg/DFGWorklist.h:
+(JSC::DFG::completeAllPlansForVM): Added a helper function that replaces
+vm.prepareToDeleteCode. This new function is clearer because we need
+to call it sometimes even if we are not going to delete code.
+
+* heap/HeapInlines.h:
+(JSC::Heap::forEachCodeBlock): Moved.
+
+* inspector/agents/InspectorRuntimeAgent.cpp:
+(Inspector::recompileAllJSFunctionsForTypeProfiling): Use the new helper
+function.
+
+* runtime/JSCInlines.h:
+(JSC::Heap::forEachCodeBlock): Do the waiting automatically.
+
+* runtime/VM.cpp:
+(JSC::VM::stopSampling):
+(JSC::VM::deleteAllCode):
+(JSC::VM::setEnabledProfiler):
+(JSC::VM::prepareToDeleteCode): Deleted.
+* runtime/VM.h: No need to wait manually.
+
 2015-08-20  Commit Queue  
 
 Unreviewed, rolling out r188675.


Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (188713 => 188714)

--- trunk/Source/_javascript_Core/debugger/Debugger.cpp	2015-08-20 22:51:21 UTC (rev 188713)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp	2015-08-20 22:53:24 UTC (rev 188714)
@@ 

[webkit-changes] [188713] trunk/LayoutTests

[commit-queue]

Title: [188713] trunk/LayoutTests








Revision 188713
Author commit-qu...@webkit.org
Date 2015-08-20 15:51:21 -0700 (Thu, 20 Aug 2015)


Log Message
AX: Fix accessibility/mac/selection-value-changes-for-aria-textbox.html test
https://bugs.webkit.org/show_bug.cgi?id=148247

Patch by Nan Wang  on 2015-08-20
Reviewed by Chris Fleizach.

Fixed the test by adding the notification listener before executing the commands.

* accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt:
* accessibility/mac/selection-value-changes-for-aria-textbox.html:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt
trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (188712 => 188713)

--- trunk/LayoutTests/ChangeLog	2015-08-20 22:37:22 UTC (rev 188712)
+++ trunk/LayoutTests/ChangeLog	2015-08-20 22:51:21 UTC (rev 188713)
@@ -1,3 +1,16 @@
+2015-08-20  Nan Wang  
+
+AX: Fix accessibility/mac/selection-value-changes-for-aria-textbox.html test
+https://bugs.webkit.org/show_bug.cgi?id=148247
+
+Reviewed by Chris Fleizach.
+
+Fixed the test by adding the notification listener before executing the commands.
+
+* accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt:
+* accessibility/mac/selection-value-changes-for-aria-textbox.html:
+* platform/mac/TestExpectations:
+
 2015-08-20  Chris Dumez  
 
 Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0x


Modified: trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt (188712 => 188713)

--- trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt	2015-08-20 22:37:22 UTC (rev 188712)
+++ trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt	2015-08-20 22:51:21 UTC (rev 188713)
@@ -11,6 +11,5 @@
 Successfully received AXSelectedTextChanged
 Successfully received AXSelectedTextChanged
 Successfully received AXSelectedTextChanged
-Successfully received AXSelectedTextChanged
 Successfully received AXValueChanged
 


Modified: trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html (188712 => 188713)

--- trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html	2015-08-20 22:37:22 UTC (rev 188712)
+++ trunk/LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html	2015-08-20 22:51:21 UTC (rev 188713)
@@ -36,6 +36,9 @@
 textbox.focus();
 
 var axTextbox = accessibilityController.focusedElement;
+
+var addedNotification = axTextbox.addNotificationListener(notificationCallback);
+shouldBe("addedNotification", "true");
 
 // Trigger selection changes.
 var s = window.getSelection();
@@ -46,9 +49,6 @@
 
 // Trigger value change.
 document.execCommand("InsertText", false, "hello ");
-
-var addedNotification = axTextbox.addNotificationListener(notificationCallback);
-shouldBe("addedNotification", "true");
 }
 
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (188712 => 188713)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-08-20 22:37:22 UTC (rev 188712)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-08-20 22:51:21 UTC (rev 188713)
@@ -490,7 +490,6 @@
 
 http/tests/misc/willCacheResponse-delegate-callback.html [ Failure ]
 http/tests/xmlhttprequest/basic-auth-nopassword.html [ Failure ]
-accessibility/mac/selection-value-changes-for-aria-textbox.html [ Failure ]
 
 accessibility/mac/search-with-frames.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188712] trunk/Source/WebCore

[bdakin]

Title: [188712] trunk/Source/WebCore








Revision 188712
Author bda...@apple.com
Date 2015-08-20 15:37:22 -0700 (Thu, 20 Aug 2015)


Log Message
WK1 can re-enter layout during FrameView destruction and crash
https://bugs.webkit.org/show_bug.cgi?id=148237
-and corresponding-
rdar://problem/22356782

Reviewed by Zalan Bujtas.

This is a safe fix for the time being. We won't resetScrollbars() for a FrameView 
that is in the PageCache because resetting scrollbars can re-enter layout for the 
Frame's new FrameView, which leads to updating pages in the page cache, which 
leads to a crash because we're in the process of destroying something
in the page cache. We should not be able to get into this mess at all.
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188711 => 188712)

--- trunk/Source/WebCore/ChangeLog	2015-08-20 22:32:10 UTC (rev 188711)
+++ trunk/Source/WebCore/ChangeLog	2015-08-20 22:37:22 UTC (rev 188712)
@@ -1,3 +1,20 @@
+2015-08-20  Beth Dakin  
+
+WK1 can re-enter layout during FrameView destruction and crash
+https://bugs.webkit.org/show_bug.cgi?id=148237
+-and corresponding-
+rdar://problem/22356782
+
+Reviewed by Zalan Bujtas.
+
+This is a safe fix for the time being. We won't resetScrollbars() for a FrameView 
+that is in the PageCache because resetting scrollbars can re-enter layout for the 
+Frame's new FrameView, which leads to updating pages in the page cache, which 
+leads to a crash because we're in the process of destroying something
+in the page cache. We should not be able to get into this mess at all.
+* page/FrameView.cpp:
+(WebCore::FrameView::~FrameView):
+
 2015-08-20  Chris Dumez  
 
 Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0x


Modified: trunk/Source/WebCore/page/FrameView.cpp (188711 => 188712)

--- trunk/Source/WebCore/page/FrameView.cpp	2015-08-20 22:32:10 UTC (rev 188711)
+++ trunk/Source/WebCore/page/FrameView.cpp	2015-08-20 22:37:22 UTC (rev 188712)
@@ -267,8 +267,14 @@
 m_postLayoutTasksTimer.stop();
 
 removeFromAXObjectCache();
-resetScrollbars();
 
+// FIXME: This is a safe fix for rdar://problem/22356782. We won't resetScrollbars() for a FrameView that is in
+// the PageCache because resetting scrollbars can re-enter layout for the Frame's new FrameView, which leads to
+// updating pages in the page cache, which leads to a crash because we're in the process of destroying something
+// in the page cache. We should not be able to get into this mess at all.
+if (frame().view() == this)
+resetScrollbars();
+
 // Custom scrollbars should already be destroyed at this point
 ASSERT(!horizontalScrollbar() || !horizontalScrollbar()->isCustomScrollbar());
 ASSERT(!verticalScrollbar() || !verticalScrollbar()->isCustomScrollbar());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188711] trunk

[cdumez]

Title: [188711] trunk








Revision 188711
Author cdu...@apple.com
Date 2015-08-20 15:32:10 -0700 (Thu, 20 Aug 2015)


Log Message
Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0x
https://bugs.webkit.org/show_bug.cgi?id=148238

Reviewed by Ryosuke Niwa.

Source/WebCore:

Default value for createNodeIterator() / createTreeWalker()'s whatToShow
parameter should be 0x as per the specification:
- http://w3c-test.org/dom/traversal/NodeIterator.html
- http://w3c-test.org/dom/traversal/TreeWalker.html

Firefox and Chrome conform to the specification. However, WebKit was
using 0 as default value.

We still don't behave as expected in some cases, as visible from
the checks that are still failing in the new layout tests. Those
will be addressed separately.

Tests: fast/dom/createNodeIterator-parameters.html
   fast/dom/createTreeWalker-parameters.html

* dom/Document.cpp:
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
* dom/Document.h:
* dom/Document.idl:
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodeIterator):
* dom/NodeIterator.h:
(WebCore::NodeIterator::create):
* dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
* dom/Traversal.h:
(WebCore::NodeIteratorBase::whatToShow):
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::TreeWalker):
* dom/TreeWalker.h:
(WebCore::TreeWalker::create):

LayoutTests:

Add tests for createNodeIterator() / createTreeWalker() parameters.
Some of the checks are still failing.

* fast/dom/createNodeIterator-parameters-expected.txt: Added.
* fast/dom/createNodeIterator-parameters.html: Added.
* fast/dom/createTreeWalker-parameters-expected.txt: Added.
* fast/dom/createTreeWalker-parameters.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/NodeIterator.cpp
trunk/Source/WebCore/dom/NodeIterator.h
trunk/Source/WebCore/dom/Traversal.cpp
trunk/Source/WebCore/dom/Traversal.h
trunk/Source/WebCore/dom/TreeWalker.cpp
trunk/Source/WebCore/dom/TreeWalker.h


Added Paths

trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt
trunk/LayoutTests/fast/dom/createNodeIterator-parameters.html
trunk/LayoutTests/fast/dom/createTreeWalker-parameters-expected.txt
trunk/LayoutTests/fast/dom/createTreeWalker-parameters.html




Diff

Modified: trunk/LayoutTests/ChangeLog (188710 => 188711)

--- trunk/LayoutTests/ChangeLog	2015-08-20 22:15:00 UTC (rev 188710)
+++ trunk/LayoutTests/ChangeLog	2015-08-20 22:32:10 UTC (rev 188711)
@@ -1,3 +1,18 @@
+2015-08-20  Chris Dumez  
+
+Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0x
+https://bugs.webkit.org/show_bug.cgi?id=148238
+
+Reviewed by Ryosuke Niwa.
+
+Add tests for createNodeIterator() / createTreeWalker() parameters.
+Some of the checks are still failing.
+
+* fast/dom/createNodeIterator-parameters-expected.txt: Added.
+* fast/dom/createNodeIterator-parameters.html: Added.
+* fast/dom/createTreeWalker-parameters-expected.txt: Added.
+* fast/dom/createTreeWalker-parameters.html: Added.
+
 2015-08-20  Nan Wang  
 
 AX: Re-enable aria-checked-mixed-value.html test for mac


Added: trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt (0 => 188711)

--- trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/createNodeIterator-parameters-expected.txt	2015-08-20 22:32:10 UTC (rev 188711)
@@ -0,0 +1,35 @@
+Tests parameters of document.createNodeIterator() API.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* No parameters
+PASS document.createNodeIterator() threw exception TypeError: Not enough arguments.
+
+Default parameters
+iterator = document.createNodeIterator(document)
+PASS iterator.root is document
+PASS iterator.referenceNode is document
+PASS iterator.whatToShow is 0x
+PASS iterator.filter is null
+PASS iterator.pointerBeforeReferenceNode is true
+
+Passing null for optional parameters
+iterator = document.createNodeIterator(document, null, null)
+PASS iterator.root is document
+PASS iterator.referenceNode is document
+PASS iterator.whatToShow is 0
+FAIL iterator.filter should be null. Was [object NodeFilter].
+PASS iterator.pointerBeforeReferenceNode is true
+
+Passing undefined for optional parameters
+iterator = document.createNodeIterator(document, undefined, undefined)
+PASS iterator.root is document
+PASS iterator.referenceNode is document
+FAIL iterator.whatToShow should be 4294967295. Was 0.
+FAIL iterator.filter should be null. Was [object NodeFilter].
+PASS iterato

[webkit-changes] [188710] trunk/LayoutTests

[commit-queue]

Title: [188710] trunk/LayoutTests








Revision 188710
Author commit-qu...@webkit.org
Date 2015-08-20 15:15:00 -0700 (Thu, 20 Aug 2015)


Log Message
AX: Re-enable aria-checked-mixed-value.html test for mac
https://bugs.webkit.org/show_bug.cgi?id=148235

Patch by Nan Wang  on 2015-08-20
Reviewed by Chris Fleizach.

isIndeterminate is already implemented in mac, re-enable the test.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (188709 => 188710)

--- trunk/LayoutTests/ChangeLog	2015-08-20 22:11:17 UTC (rev 188709)
+++ trunk/LayoutTests/ChangeLog	2015-08-20 22:15:00 UTC (rev 188710)
@@ -1,5 +1,16 @@
 2015-08-20  Nan Wang  
 
+AX: Re-enable aria-checked-mixed-value.html test for mac
+https://bugs.webkit.org/show_bug.cgi?id=148235
+
+Reviewed by Chris Fleizach.
+
+isIndeterminate is already implemented in mac, re-enable the test.
+
+* platform/mac/TestExpectations:
+
+2015-08-20  Nan Wang  
+
 AX: Mac doesn't have expectation for LayoutTests/accessibility/table-cells-roles.html test
 https://bugs.webkit.org/show_bug.cgi?id=148236
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (188709 => 188710)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-08-20 22:11:17 UTC (rev 188709)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-08-20 22:15:00 UTC (rev 188710)
@@ -51,8 +51,6 @@
 accessibility/menu-list-sends-change-notification.html
 accessibility/multiselect-list-reports-active-option.html
 
-# isIndeterminate is not implemented in mac
-webkit.org/b/125855 accessibility/aria-checked-mixed-value.html [ Skip ]
 # Missing implementation of some functions in mac.
 webkit.org/b/129039 accessibility/select-element-at-index.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188708] trunk/Source/WebInspectorUI

[mattbaker]

Title: [188708] trunk/Source/WebInspectorUI








Revision 188708
Author mattba...@apple.com
Date 2015-08-20 15:07:59 -0700 (Thu, 20 Aug 2015)


Log Message
Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph
https://bugs.webkit.org/show_bug.cgi?id=147421

Reviewed by Timothy Hatcher.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
Inform derived sidebar of tree element filter state changes.

* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.recordWasFiltered):
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout):
Update filtered frame style when a record's state changes, and during layout.

* UserInterface/Views/TimelineOverview.js:
* UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.recordWasFiltered):
Allow setting a record's filtered state for a given timeline in the overview.

* UserInterface/Views/TimelineRecordFrame.css:
(.timeline-record-frame.filtered > .frame):
New filtered frame style.

* UserInterface/Views/TimelineRecordFrame.js:
(WebInspector.TimelineRecordFrame.prototype.get filtered):
(WebInspector.TimelineRecordFrame.prototype.set filtered):

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.representedObjectWasFiltered):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Apply task filters to RenderingFrameTimelineRecords and their immediate children.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.css
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188707 => 188708)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-20 21:55:23 UTC (rev 188707)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-20 22:07:59 UTC (rev 188708)
@@ -1,3 +1,41 @@
+2015-08-20  Matt Baker  
+
+Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph
+https://bugs.webkit.org/show_bug.cgi?id=147421
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/NavigationSidebarPanel.js:
+(WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered):
+(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
+Inform derived sidebar of tree element filter state changes.
+
+* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
+(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.recordWasFiltered):
+(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout):
+Update filtered frame style when a record's state changes, and during layout.
+
+* UserInterface/Views/TimelineOverview.js:
+* UserInterface/Views/TimelineOverviewGraph.js:
+(WebInspector.TimelineOverviewGraph.prototype.recordWasFiltered):
+Allow setting a record's filtered state for a given timeline in the overview.
+
+* UserInterface/Views/TimelineRecordFrame.css:
+(.timeline-record-frame.filtered > .frame):
+New filtered frame style.
+
+* UserInterface/Views/TimelineRecordFrame.js:
+(WebInspector.TimelineRecordFrame.prototype.get filtered):
+(WebInspector.TimelineRecordFrame.prototype.set filtered):
+
+* UserInterface/Views/TimelineRecordingContentView.js:
+(WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):
+
+* UserInterface/Views/TimelineSidebarPanel.js:
+(WebInspector.TimelineSidebarPanel.prototype.representedObjectWasFiltered):
+(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
+Apply task filters to RenderingFrameTimelineRecords and their immediate children.
+
 2015-08-20  Brian Burg  
 
 Web Inspector: console assertion when hitting breakpoint after auto-recording ends


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (188707 => 188708)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js	2015-08-20 21:55:23 UTC (r

[webkit-changes] [188707] branches/safari-601.1-branch/Source

[matthew_hanson]

Title: [188707] branches/safari-601.1-branch/Source








Revision 188707
Author matthew_han...@apple.com
Date 2015-08-20 14:55:23 -0700 (Thu, 20 Aug 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188706 => 188707)

--- branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-20 21:55:10 UTC (rev 188706)
+++ branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-20 21:55:23 UTC (rev 188707)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 54;
+TINY_VERSION = 55;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig (188706 => 188707)

--- branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-20 21:55:10 UTC (rev 188706)
+++ branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-20 21:55:23 UTC (rev 188707)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 54;
+TINY_VERSION = 55;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188706 => 188707)

--- branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-20 21:55:10 UTC (rev 188706)
+++ branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-20 21:55:23 UTC (rev 188707)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 54;
+TINY_VERSION = 55;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188706 => 188707)

--- branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-20 21:55:10 UTC (rev 188706)
+++ branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-20 21:55:23 UTC (rev 188707)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 54;
+TINY_VERSION = 55;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig (188706 => 188707)

--- branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-20 21:55:10 UTC (rev 188706)
+++ branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-20 21:55:23 UTC (rev 188707)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 54;
+TINY_VERSION = 55;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188706] branches/jsc-tailcall/Source/JavaScriptCore

[msaboff]

Title: [188706] branches/jsc-tailcall/Source/_javascript_Core








Revision 188706
Author msab...@apple.com
Date 2015-08-20 14:55:10 -0700 (Thu, 20 Aug 2015)


Log Message
jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
https://bugs.webkit.org/show_bug.cgi?id=148246

Reviewed by Basile Clement.

Changed preserveCalleeSavesUsedByLLInt() macro to move the stack pointer before saving
any registers.

* llint/LowLevelInterpreter.asm:

Modified Paths

branches/jsc-tailcall/Source/_javascript_Core/ChangeLog
branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm




Diff

Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (188705 => 188706)

--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-20 21:54:03 UTC (rev 188705)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-20 21:55:10 UTC (rev 188706)
@@ -1,3 +1,15 @@
+2015-08-20  Michael Saboff  
+
+jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
+https://bugs.webkit.org/show_bug.cgi?id=148246
+
+Reviewed by Basile Clement.
+
+Changed preserveCalleeSavesUsedByLLInt() macro to move the stack pointer before saving
+any registers.
+
+* llint/LowLevelInterpreter.asm:
+
 2015-08-19  Michael Saboff  
 
 jsc-tailcall: Unify Register Offset classes


Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm (188705 => 188706)

--- branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-20 21:54:03 UTC (rev 188705)
+++ branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-20 21:55:10 UTC (rev 188706)
@@ -504,6 +504,7 @@
 end
 
 macro preserveCalleeSavesUsedByLLInt()
+subp CalleeSaveSpaceStackAligned, sp
 if C_LOOP
 elsif ARM or ARMv7_TRADITIONAL
 elsif ARMv7
@@ -875,7 +876,7 @@
 
 # Stack height check failed - need to call a slow_path.
 # Set up temporary stack pointer for call including callee saves
-subp maxFrameExtentForSlowPathCall + CalleeSaveSpaceStackAligned, sp
+subp maxFrameExtentForSlowPathCall, sp
 callSlowPath(_llint_stack_check)
 bpeq r1, 0, .stackHeightOKGetCodeBlock
 move r1, cfr






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188705] tags/Safari-601.1.54/

[matthew_hanson]

Title: [188705] tags/Safari-601.1.54/








Revision 188705
Author matthew_han...@apple.com
Date 2015-08-20 14:54:03 -0700 (Thu, 20 Aug 2015)


Log Message
New Tag.

Added Paths

tags/Safari-601.1.54/




Diff

Property changes: tags/Safari-601.1.54



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188704] trunk/LayoutTests

[commit-queue]

Title: [188704] trunk/LayoutTests








Revision 188704
Author commit-qu...@webkit.org
Date 2015-08-20 14:42:02 -0700 (Thu, 20 Aug 2015)


Log Message
AX: Mac doesn't have expectation for LayoutTests/accessibility/table-cells-roles.html test
https://bugs.webkit.org/show_bug.cgi?id=148236

Patch by Nan Wang  on 2015-08-20
Reviewed by Chris Fleizach.

* accessibility/table-cells-roles-expected.txt:
* accessibility/table-cells-roles.html:
* platform/mac/TestExpectations:
* platform/mac/accessibility/table-cells-roles-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/table-cells-roles-expected.txt
trunk/LayoutTests/accessibility/table-cells-roles.html
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/platform/mac/accessibility/table-cells-roles-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (188703 => 188704)

--- trunk/LayoutTests/ChangeLog	2015-08-20 21:36:57 UTC (rev 188703)
+++ trunk/LayoutTests/ChangeLog	2015-08-20 21:42:02 UTC (rev 188704)
@@ -1,3 +1,15 @@
+2015-08-20  Nan Wang  
+
+AX: Mac doesn't have expectation for LayoutTests/accessibility/table-cells-roles.html test
+https://bugs.webkit.org/show_bug.cgi?id=148236
+
+Reviewed by Chris Fleizach.
+
+* accessibility/table-cells-roles-expected.txt:
+* accessibility/table-cells-roles.html:
+* platform/mac/TestExpectations:
+* platform/mac/accessibility/table-cells-roles-expected.txt: Added.
+
 2015-08-20  Chris Dumez  
 
 REGRESSION: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky


Modified: trunk/LayoutTests/accessibility/table-cells-roles-expected.txt (188703 => 188704)

--- trunk/LayoutTests/accessibility/table-cells-roles-expected.txt	2015-08-20 21:36:57 UTC (rev 188703)
+++ trunk/LayoutTests/accessibility/table-cells-roles-expected.txt	2015-08-20 21:42:02 UTC (rev 188704)
@@ -14,15 +14,15 @@
 
 This test checks the correctness of roles for different cases of table cells.
 
-The table cell at (2,0) should have a role AXRole: AXColumnHeader , currently it has AXRole: AXColumnHeader .
-The table cell at (1,2) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
-The table cell at (2,3) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
-The table cell at (1,4) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
-The table cell at (0,2) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
-The table cell at (0,4) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
+The table cell at (2,0) currently has role  AXRole: AXColumnHeader .
+The table cell at (1,2) currently has role  AXRole: AXCell .
+The table cell at (2,3) currently has role  AXRole: AXCell .
+The table cell at (1,4) currently has role  AXRole: AXCell .
+The table cell at (0,2) currently has role  AXRole: AXRowHeader .
+The table cell at (0,4) currently has role  AXRole: AXRowHeader .
 
-The table2 cell at (2,0) should have a role AXRole: AXColumnHeader , currently it has AXRole: AXColumnHeader .
-The table2 cell at (1,2) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
-The table2 cell at (2,3) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
-The table2 cell at (0,2) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
+The table2 cell at (2,0) currently has role  AXRole: AXColumnHeader .
+The table2 cell at (1,2) currently has role  AXRole: AXCell .
+The table2 cell at (2,3) currently has role  AXRole: AXCell .
+The table2 cell at (0,2) currently has role  AXRole: AXRowHeader .
 


Modified: trunk/LayoutTests/accessibility/table-cells-roles.html (188703 => 188704)

--- trunk/LayoutTests/accessibility/table-cells-roles.html	2015-08-20 21:36:57 UTC (rev 188703)
+++ trunk/LayoutTests/accessibility/table-cells-roles.html	2015-08-20 21:42:02 UTC (rev 188704)
@@ -1,4 +1,5 @@
 
+