date:20190701

[webkit-changes] [247037] branches/safari-607-branch/Source

2019-07-01 Thread bshafiei

Title: [247037] branches/safari-607-branch/Source








Revision 247037
Author bshaf...@apple.com
Date 2019-07-01 22:55:03 -0700 (Mon, 01 Jul 2019)


Log Message
Versioning.

Modified Paths

branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (247036 => 247037)

--- branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-07-02 05:14:17 UTC (rev 247036)
+++ branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-07-02 05:55:03 UTC (rev 247037)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 3;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247036] trunk

2019-07-01 Thread justin_michaud

Title: [247036] trunk








Revision 247036
Author justin_mich...@apple.com
Date 2019-07-01 22:14:17 -0700 (Mon, 01 Jul 2019)


Log Message
[Wasm-References] Disable references by default
https://bugs.webkit.org/show_bug.cgi?id=199390

Reviewed by Saam Barati.

JSTests:

* wasm/references-spec-tests/ref_is_null.js:
* wasm/references-spec-tests/ref_null.js:
* wasm/references/anyref_globals.js:
* wasm/references/anyref_modules.js:
* wasm/references/anyref_table.js:
* wasm/references/anyref_table_import.js:
* wasm/references/element_parsing.js:
* wasm/references/func_ref.js:
* wasm/references/is_null.js:
* wasm/references/multitable.js:
* wasm/references/table_misc.js:
* wasm/references/validation.js:

Source/_javascript_Core:

* runtime/Options.h:

Tools:

* Scripts/run-jsc-stress-tests:

LayoutTests:

* workers/wasm-references.html:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/references/anyref_globals.js
trunk/JSTests/wasm/references/anyref_modules.js
trunk/JSTests/wasm/references/anyref_table.js
trunk/JSTests/wasm/references/anyref_table_import.js
trunk/JSTests/wasm/references/element_parsing.js
trunk/JSTests/wasm/references/func_ref.js
trunk/JSTests/wasm/references/is_null.js
trunk/JSTests/wasm/references/multitable.js
trunk/JSTests/wasm/references/table_misc.js
trunk/JSTests/wasm/references/validation.js
trunk/JSTests/wasm/references-spec-tests/ref_is_null.js
trunk/JSTests/wasm/references-spec-tests/ref_null.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/workers/wasm-references.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/JSTests/ChangeLog (247035 => 247036)

--- trunk/JSTests/ChangeLog	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/ChangeLog	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,23 @@
+2019-07-01  Justin Michaud  
+
+[Wasm-References] Disable references by default
+https://bugs.webkit.org/show_bug.cgi?id=199390
+
+Reviewed by Saam Barati.
+
+* wasm/references-spec-tests/ref_is_null.js:
+* wasm/references-spec-tests/ref_null.js:
+* wasm/references/anyref_globals.js:
+* wasm/references/anyref_modules.js:
+* wasm/references/anyref_table.js:
+* wasm/references/anyref_table_import.js:
+* wasm/references/element_parsing.js:
+* wasm/references/func_ref.js:
+* wasm/references/is_null.js:
+* wasm/references/multitable.js:
+* wasm/references/table_misc.js:
+* wasm/references/validation.js:
+
 2019-07-01  Ryan Haddad  
 
 Unreviewed, rolling out r246946.


Modified: trunk/JSTests/wasm/references/anyref_globals.js (247035 => 247036)

--- trunk/JSTests/wasm/references/anyref_globals.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_globals.js	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
 import * as assert from '../assert.js';
 import Builder from '../Builder.js';
 


Modified: trunk/JSTests/wasm/references/anyref_modules.js (247035 => 247036)

--- trunk/JSTests/wasm/references/anyref_modules.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_modules.js	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
 import * as assert from '../assert.js';
 import Builder from '../Builder.js';
 


Modified: trunk/JSTests/wasm/references/anyref_table.js (247035 => 247036)

--- trunk/JSTests/wasm/references/anyref_table.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_table.js	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
 import * as assert from '../assert.js';
 import Builder from '../Builder.js';
 


Modified: trunk/JSTests/wasm/references/anyref_table_import.js (247035 => 247036)

--- trunk/JSTests/wasm/references/anyref_table_import.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_table_import.js	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
 import * as assert from '../assert.js';
 import Builder from '../Builder.js';
 


Modified: trunk/JSTests/wasm/references/element_parsing.js (247035 => 247036)

--- trunk/JSTests/wasm/references/element_parsing.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/element_parsing.js	2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
 import * as assert from '../assert.js';
 
 function module(bytes, valid = true) {


Modified: trunk/JSTests/wasm/references/func_ref.js (247035 => 247036)

--- trunk/JSTests/wasm/references/func_ref.js	2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/func_ref.js	2019-07-02

[webkit-changes] [247035] trunk/Source/WebCore

2019-07-01 Thread zalan

Title: [247035] trunk/Source/WebCore








Revision 247035
Author za...@apple.com
Date 2019-07-01 22:10:54 -0700 (Mon, 01 Jul 2019)


Log Message
[Text autosizing] [iPadOS] AutosizeStatus::idempotentTextSize returns the computed font size in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=199382


Reviewed by Wenson Hsieh.

Adjust the font size on the style only when the autosized value is different from the computed value.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyleForTextAutosizing):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (247034 => 247035)

--- trunk/Source/WebCore/ChangeLog	2019-07-02 04:34:59 UTC (rev 247034)
+++ trunk/Source/WebCore/ChangeLog	2019-07-02 05:10:54 UTC (rev 247035)
@@ -1,3 +1,16 @@
+2019-07-01  Zalan Bujtas  
+
+[Text autosizing] [iPadOS] AutosizeStatus::idempotentTextSize returns the computed font size in certain cases.
+https://bugs.webkit.org/show_bug.cgi?id=199382
+
+
+Reviewed by Wenson Hsieh.
+
+Adjust the font size on the style only when the autosized value is different from the computed value. 
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::adjustRenderStyleForTextAutosizing):
+
 2019-07-01  Chris Dumez  
 
 It should not be possible to trigger a load while in the middle of restoring a page in PageCache


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (247034 => 247035)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2019-07-02 04:34:59 UTC (rev 247034)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2019-07-02 05:10:54 UTC (rev 247035)
@@ -913,11 +913,13 @@
 auto fontDescription = style.fontDescription();
 auto initialComputedFontSize = fontDescription.computedSize(); 
 auto adjustedFontSize = AutosizeStatus::idempotentTextSize(fontDescription.specifiedSize(), initialScale);
+if (initialComputedFontSize == adjustedFontSize)
+return;
+
 fontDescription.setComputedSize(adjustedFontSize);
 style.setFontDescription(WTFMove(fontDescription));
 style.fontCascade().update(().fontSelector());
-if (initialComputedFontSize != adjustedFontSize)
-adjustLineHeightIfNeeded(adjustedFontSize);
+adjustLineHeightIfNeeded(adjustedFontSize);
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247033] trunk

2019-07-01 Thread drousso

Title: [247033] trunk








Revision 247033
Author drou...@apple.com
Date 2019-07-01 18:17:50 -0700 (Mon, 01 Jul 2019)


Log Message
Web Inspector: REGRESSION(r245498): Timelines: CPU: discontinuities are filled in by the next record
https://bugs.webkit.org/show_bug.cgi?id=198927

Reviewed by Matt Baker.

Source/WebInspectorUI:

* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype.capturingStarted):
(WI.TimelineManager.prototype.capturingStopped):
* UserInterface/Models/TimelineRecording.js:
(WI.TimelineRecording):
(WI.TimelineRecording.prototype.start):
(WI.TimelineRecording.prototype.capturingStarted): Added.
(WI.TimelineRecording.prototype.capturingStopped): Added.
(WI.TimelineRecording.prototype.reset):
(WI.TimelineRecording.prototype.addRecord):
(WI.TimelineRecording.prototype.discontinuitiesInTimeRange):
(WI.TimelineRecording.prototype.addDiscontinuity): Deleted.
Notify the `TimelineRecording` when capturing has started/stopped.
Adjust the first record after a discontinuity to have it's `startTime` match the `endTime`
of the most recent discontinuity.

* UserInterface/Models/Timeline.js:
(WI.Timeline.prototype.addRecord):
* UserInterface/Models/CPUTimeline.js:
(WI.CPUTimeline.prototype.addRecord):
* UserInterface/Models/CPUTimelineRecord.js:
(WI.CPUTimelineRecord.prototype.adjustStartTime): Added.
(WI.CPUTimelineRecord.prototype.adjustStartTimeToLastRecord): Deleted.
* UserInterface/Models/MemoryTimeline.js:
(WI.MemoryTimeline.prototype.addRecord):
* UserInterface/Models/MemoryTimelineRecord.js:
(WI.MemoryTimelineRecord.prototype.adjustStartTime): Added.
(WI.MemoryTimelineRecord.prototype.adjustStartTimeToLastRecord): Deleted.
* UserInterface/Models/NetworkTimeline.js:
(WI.NetworkTimeline.prototype.addRecord):

* UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.prototype.layout):
* UserInterface/Views/MemoryTimelineOverviewGraph.js:
(WI.MemoryTimelineOverviewGraph.prototype.layout):
* UserInterface/Views/MemoryTimelineView.js:
(WI.MemoryTimelineView.prototype.layout):
Include discontinuities that exactly match the start/end time of the record immediately
before/after the discontinuity.

* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._handleTimelineCapturingStateChanged):
(WI.TimelineRecordingContentView.prototype._recordingReset):
Move the logic for handling discontinuity start/end times to the `TimelineRecording`.

* UserInterface/Base/Utilities.js:

LayoutTests:

* inspector/unit-tests/set-utilities.html:
* inspector/unit-tests/set-utilities-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/unit-tests/set-utilities-expected.txt
trunk/LayoutTests/inspector/unit-tests/set-utilities.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/CPUTimeline.js
trunk/Source/WebInspectorUI/UserInterface/Models/CPUTimelineRecord.js
trunk/Source/WebInspectorUI/UserInterface/Models/MemoryTimeline.js
trunk/Source/WebInspectorUI/UserInterface/Models/MemoryTimelineRecord.js
trunk/Source/WebInspectorUI/UserInterface/Models/NetworkTimeline.js
trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js
trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js
trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js
trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js
trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js




Diff

Modified: trunk/LayoutTests/ChangeLog (247032 => 247033)

--- trunk/LayoutTests/ChangeLog	2019-07-02 00:23:43 UTC (rev 247032)
+++ trunk/LayoutTests/ChangeLog	2019-07-02 01:17:50 UTC (rev 247033)
@@ -1,3 +1,13 @@
+2019-07-01  Devin Rousso  
+
+Web Inspector: REGRESSION(r245498): Timelines: CPU: discontinuities are filled in by the next record
+https://bugs.webkit.org/show_bug.cgi?id=198927
+
+Reviewed by Matt Baker.
+
+* inspector/unit-tests/set-utilities.html:
+* inspector/unit-tests/set-utilities-expected.txt:
+
 2019-07-01  Russell Epstein  
 
 Layout Test imported/blink/fast/multicol/span/overflow-on-viewport.html is flaky.


Modified: trunk/LayoutTests/inspector/unit-tests/set-utilities-expected.txt (247032 => 247033)

--- trunk/LayoutTests/inspector/unit-tests/set-utilities-expected.txt	2019-07-02 00:23:43 UTC (rev 247032)
+++ trunk/LayoutTests/inspector/unit-tests/set-utilities-expected.txt	2019-07-02 01:17:50 UTC (rev 247033)
@@ -1,5 +1,11 @@
 
 == Running test suite: Set
+-- Running test case: Set.prototype.take
+PASS: Set can take `key`.
+PASS: Set no longer has `key`.
+PASS: Set can NOT take `key`.
+PASS: Set can NOT take `DNE`, as it does NOT exist.
+
 -- Running test

[webkit-changes] [247031] trunk/LayoutTests

2019-07-01 Thread tsavell

Title: [247031] trunk/LayoutTests








Revision 247031
Author tsav...@apple.com
Date 2019-07-01 16:45:01 -0700 (Mon, 01 Jul 2019)


Log Message
Layout Test imported/blink/fast/multicol/span/overflow-on-viewport.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=199387

Unreviewed Test Gardening.

Patch by Russell Epstein  on 2019-07-01

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (247030 => 247031)

--- trunk/LayoutTests/ChangeLog	2019-07-01 22:32:15 UTC (rev 247030)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 23:45:01 UTC (rev 247031)
@@ -1,3 +1,12 @@
+2019-07-01  Russell Epstein  
+
+Layout Test imported/blink/fast/multicol/span/overflow-on-viewport.html is flaky.
+https://bugs.webkit.org/show_bug.cgi?id=199387
+
+Unreviewed Test Gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2019-07-01  Wenson Hsieh  
 
 [iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (247030 => 247031)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-07-01 22:32:15 UTC (rev 247030)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-07-01 23:45:01 UTC (rev 247031)
@@ -1347,3 +1347,6 @@
 webkit.org/b/199213 [ Release ] imported/blink/editing/selection/deleteFromDocument-crash.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/199370 [ Release ] imported/mozilla/svg/text/selectSubString.svg [ Pass ImageOnlyFailure ]
+
+webkit.org/b/199387 imported/blink/fast/multicol/span/overflow-on-viewport.html [ Pass ImageOnlyFailure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247030] trunk/LayoutTests

2019-07-01 Thread wenson_hsieh

Title: [247030] trunk/LayoutTests








Revision 247030
Author wenson_hs...@apple.com
Date 2019-07-01 15:32:15 -0700 (Mon, 01 Jul 2019)


Log Message
[iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk
https://bugs.webkit.org/show_bug.cgi?id=199384

Reviewed by Tim Horton.

Adjust this test to show the callout menu by tapping on the caret rect, rather than the center of the editable
area. Currently, tapping the center of the editable area twice results in a double tap, which fails to trigger
the callout bar.

* editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html




Diff

Modified: trunk/LayoutTests/ChangeLog (247029 => 247030)

--- trunk/LayoutTests/ChangeLog	2019-07-01 22:27:07 UTC (rev 247029)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 22:32:15 UTC (rev 247030)
@@ -1,3 +1,16 @@
+2019-07-01  Wenson Hsieh  
+
+[iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk
+https://bugs.webkit.org/show_bug.cgi?id=199384
+
+Reviewed by Tim Horton.
+
+Adjust this test to show the callout menu by tapping on the caret rect, rather than the center of the editable
+area. Currently, tapping the center of the editable area twice results in a double tap, which fails to trigger
+the callout bar.
+
+* editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html:
+
 2019-07-01  Chris Dumez  
 
 It should not be possible to trigger a load while in the middle of restoring a page in PageCache


Modified: trunk/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html (247029 => 247030)

--- trunk/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html	2019-07-01 22:27:07 UTC (rev 247029)
+++ trunk/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html	2019-07-01 22:32:15 UTC (rev 247030)
@@ -41,6 +41,15 @@
 addEventListener("mousemove", recordEvent);
 addEventListener("mouseup", recordEvent);
 
+async function waitForCaretToAppear()
+{
+while (true) {
+const rect = await UIHelper.getUICaretViewRect();
+if (rect && rect.top && rect.left && rect.width > 0 && rect.height > 0)
+return rect;
+}
+}
+
 async function waitForSelectionToAppear()
 {
 while (true) {
@@ -63,7 +72,8 @@
 debug("\nAttempting to show the callout bar.");
 const editor = document.querySelector(".editor");
 await UIHelper.activateElementAndWaitForInputSession(editor);
-await UIHelper.activateElement(editor);
+const [caretX, caretY] = midPointOfRect(await waitForCaretToAppear());
+await UIHelper.activateAt(caretX, caretY);
 await UIHelper.waitForMenuToShow();
 testPassed("Displayed the callout bar.");
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247029] trunk/Source/WebKit

2019-07-01 Thread cdumez

Title: [247029] trunk/Source/WebKit








Revision 247029
Author cdu...@apple.com
Date 2019-07-01 15:27:07 -0700 (Mon, 01 Jul 2019)


Log Message
Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540
https://bugs.webkit.org/show_bug.cgi?id=199383

Reviewed by Alex Christensen.

* UIProcess/WebProcessLifetimeObserver.h:
(WebKit::WebProcessLifetimeObserver::webProcessDidCloseConnection):
* UIProcess/WebProcessLifetimeTracker.cpp:
(WebKit::WebProcessLifetimeTracker::addObserver):
(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h
trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (247028 => 247029)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 22:27:07 UTC (rev 247029)
@@ -1,5 +1,18 @@
 2019-07-01  Chris Dumez  
 
+Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540
+https://bugs.webkit.org/show_bug.cgi?id=199383
+
+Reviewed by Alex Christensen.
+
+* UIProcess/WebProcessLifetimeObserver.h:
+(WebKit::WebProcessLifetimeObserver::webProcessDidCloseConnection):
+* UIProcess/WebProcessLifetimeTracker.cpp:
+(WebKit::WebProcessLifetimeTracker::addObserver):
+(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
+
+2019-07-01  Chris Dumez  
+
 StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
 https://bugs.webkit.org/show_bug.cgi?id=199379
 


Modified: trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h (247028 => 247029)

--- trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h	2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h	2019-07-01 22:27:07 UTC (rev 247029)
@@ -53,12 +53,10 @@
 private:
 friend class WebProcessLifetimeTracker;
 
-virtual void webPageWasAdded(WebPageProxy&) { }
 virtual void webProcessWillOpenConnection(WebProcessProxy&, IPC::Connection&) { }
 virtual void webPageWillOpenConnection(WebPageProxy&, IPC::Connection&) { }
 virtual void webPageDidCloseConnection(WebPageProxy&, IPC::Connection&) { }
 virtual void webProcessDidCloseConnection(WebProcessProxy&, IPC::Connection&) { }
-virtual void webPageWasInvalidated(WebPageProxy&) { }
 
 HashCountedSet m_processes;
 };


Modified: trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp (247028 => 247029)

--- trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp	2019-07-01 22:16:11 UTC (rev 247028)
+++ trunk/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp	2019-07-01 22:27:07 UTC (rev 247029)
@@ -47,8 +47,6 @@
 
 m_observers.add();
 
-observer.webPageWasAdded(m_webPageProxy);
-
 if (processIsRunning(m_webPageProxy.process()))
 observer.addWebPage(m_webPageProxy, m_webPageProxy.process());
 }
@@ -74,11 +72,8 @@
 if (!processIsRunning(m_webPageProxy.process()))
 return;
 
-for (auto& observer : m_observers) {
+for (auto& observer : m_observers)
 observer->removeWebPage(m_webPageProxy, m_webPageProxy.process());
-
-observer->webPageWasInvalidated(m_webPageProxy);
-}
 }
 
 bool WebProcessLifetimeTracker::processIsRunning(WebProcessProxy& process)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247028] trunk/Source/WebKit

2019-07-01 Thread cdumez

Title: [247028] trunk/Source/WebKit








Revision 247028
Author cdu...@apple.com
Date 2019-07-01 15:16:11 -0700 (Mon, 01 Jul 2019)


Log Message
StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
https://bugs.webkit.org/show_bug.cgi?id=199379

Reviewed by Alex Christensen.

This was pretty inefficient.

* NetworkProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (247027 => 247028)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 22:10:44 UTC (rev 247027)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 22:16:11 UTC (rev 247028)
@@ -1,3 +1,15 @@
+2019-07-01  Chris Dumez  
+
+StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
+https://bugs.webkit.org/show_bug.cgi?id=199379
+
+Reviewed by Alex Christensen.
+
+This was pretty inefficient.
+
+* NetworkProcess/WebStorage/StorageManager.cpp:
+(WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):
+
 2019-07-01  Wenson Hsieh  
 
 [iOS] REGRESSION (r246757): Unable to select non-editable text in subframes


Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp (247027 => 247028)

--- trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp	2019-07-01 22:10:44 UTC (rev 247027)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp	2019-07-01 22:16:11 UTC (rev 247028)
@@ -399,7 +399,7 @@
 
 bool isEmpty() const { return m_storageAreaMap.isEmpty(); }
 
-HashSet allowedConnections() const { return m_allowedConnections; }
+const HashSet& allowedConnections() const { return m_allowedConnections; }
 void addAllowedConnection(IPC::Connection::UniqueID);
 void removeAllowedConnection(IPC::Connection::UniqueID);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247027] trunk/Source/WebKit

2019-07-01 Thread wenson_hsieh

Title: [247027] trunk/Source/WebKit








Revision 247027
Author wenson_hs...@apple.com
Date 2019-07-01 15:10:44 -0700 (Mon, 01 Jul 2019)


Log Message
[iOS] REGRESSION (r246757): Unable to select non-editable text in subframes
https://bugs.webkit.org/show_bug.cgi?id=199366


Reviewed by Tim Horton.

r246757 removed logic in selectionPositionInformation responsible for setting the focused frame when handling a
position information request. As the FIXME formerly in InteractionInformationRequest.h alluded to, text
selection gestures on iOS were dependent on this behavior when selecting text in subframes, since text selection
helpers in WebPageIOS.mm assume that the focused frame already contains the selection being set.

Rather than calling setFocusedFrame when requesting position information, we can fix this by making
WebPage::selectWithGesture and WebPage::selectTextWithGranularityAtPoint both set the focused frame if needed
before extending or moving text selections.

Covered by layout tests that began to fail after r246757:
- editing/selection/ios/selection-handles-in-iframe.html
- editing/selection/ios/selection-handle-clamping-in-iframe.html

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):

Only call the new helper method, setFocusedFrameBeforeSelectingTextAtLocation, at the start of the gesture.

(WebKit::WebPage::setFocusedFrameBeforeSelectingTextAtLocation):
(WebKit::WebPage::selectTextWithGranularityAtPoint):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (247026 => 247027)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 22:07:09 UTC (rev 247026)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 22:10:44 UTC (rev 247027)
@@ -1,3 +1,33 @@
+2019-07-01  Wenson Hsieh  
+
+[iOS] REGRESSION (r246757): Unable to select non-editable text in subframes
+https://bugs.webkit.org/show_bug.cgi?id=199366
+
+
+Reviewed by Tim Horton.
+
+r246757 removed logic in selectionPositionInformation responsible for setting the focused frame when handling a
+position information request. As the FIXME formerly in InteractionInformationRequest.h alluded to, text
+selection gestures on iOS were dependent on this behavior when selecting text in subframes, since text selection
+helpers in WebPageIOS.mm assume that the focused frame already contains the selection being set.
+
+Rather than calling setFocusedFrame when requesting position information, we can fix this by making
+WebPage::selectWithGesture and WebPage::selectTextWithGranularityAtPoint both set the focused frame if needed
+before extending or moving text selections.
+
+Covered by layout tests that began to fail after r246757:
+- editing/selection/ios/selection-handles-in-iframe.html
+- editing/selection/ios/selection-handle-clamping-in-iframe.html
+
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::selectWithGesture):
+
+Only call the new helper method, setFocusedFrameBeforeSelectingTextAtLocation, at the start of the gesture.
+
+(WebKit::WebPage::setFocusedFrameBeforeSelectingTextAtLocation):
+(WebKit::WebPage::selectTextWithGranularityAtPoint):
+
 2019-07-01  Alex Christensen  
 
 Add new decidePolicyForNavigationAction SPI with preferences and userInfo


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (247026 => 247027)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h	2019-07-01 22:07:09 UTC (rev 247026)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h	2019-07-01 22:10:44 UTC (rev 247027)
@@ -1245,6 +1245,7 @@
 void resetIdempotentTextAutosizingIfNeeded(double previousInitialScale);
 WebCore::VisiblePosition visiblePositionInFocusedNodeForPoint(const WebCore::Frame&, const WebCore::IntPoint&, bool isInteractingWithFocusedElement);
 RefPtr rangeForGranularityAtPoint(WebCore::Frame&, const WebCore::IntPoint&, uint32_t granularity, bool isInteractingWithFocusedElement);
+void setFocusedFrameBeforeSelectingTextAtLocation(const WebCore::IntPoint&);
 void dispatchSyntheticMouseEventsForSelectionGesture(SelectionTouch, const WebCore::IntPoint&);
 
 void sendPositionInformation(InteractionInformationAtPosition&&);


Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (247026 => 247027)

--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-07-01 22:07:09 UTC (rev 247026)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-07-01 22:10:44 UTC (rev 247027)
@@ -1308,6 +1308,9 @@
 
 void WebPage::selectWithGesture(const IntPoint& point, uint32_t granularity, uint32_t gestureType, uint32_t gestureState, bool isInteractingWithFocusedElement, CallbackID callbackID)
 {
+if

[webkit-changes] [247026] trunk

2019-07-01 Thread commit-queue

Title: [247026] trunk








Revision 247026
Author commit-qu...@webkit.org
Date 2019-07-01 15:07:09 -0700 (Mon, 01 Jul 2019)


Log Message
Add new decidePolicyForNavigationAction SPI with preferences and userInfo
https://bugs.webkit.org/show_bug.cgi?id=199371


Patch by Alex Christensen  on 2019-07-01
Reviewed by Tim Horton.

Source/WebKit:

Also deprecate some older SPI so we may someday clean up this mess.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::shouldBypassContentModeSafeguards const):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
(-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[NavigationActionSPIDelegate spiCalled]):
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (247025 => 247026)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 21:55:03 UTC (rev 247025)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 22:07:09 UTC (rev 247026)
@@ -1,5 +1,22 @@
 2019-07-01  Alex Christensen  
 
+Add new decidePolicyForNavigationAction SPI with preferences and userInfo
+https://bugs.webkit.org/show_bug.cgi?id=199371
+
+
+Reviewed by Tim Horton.
+
+Also deprecate some older SPI so we may someday clean up this mess.
+
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+* UIProcess/Cocoa/NavigationState.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
+(WebKit::NavigationState::NavigationClient::shouldBypassContentModeSafeguards const):
+
+2019-07-01  Alex Christensen  
+
 Deprecate but still call _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
 https://bugs.webkit.org/show_bug.cgi?id=199296
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (247025 => 247026)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2019-07-01 21:55:03 UTC (rev 247025)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2019-07-01 22:07:09 UTC (rev 247026)
@@ -93,8 +93,9 @@
 - (void)_webViewWillEndNavigationGesture:(WKWebView *)webView withNavigationToBackForwardListItem:(WKBackForwardListItem *)item;
 - (void)_webView:(WKWebView *)webView willSnapshotBackForwardListItem:(WKBackForwardListItem *)item;
 - (void)_webViewDidRemoveNavigationGestureSnapshot:(WKWebView *)webView WK_API_AVAILABLE(macos(10.12), ios(10.0));
-- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler WK_API_DEPRECATED_WITH_REPLACEMENT("_webView:decidePolicyForNavigationAction:userInfo:decisionHandler:", macos(10.12.3, 10.14.4), ios(10.3, 12.2));
-- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction userInfo:(id )userInfo decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler WK_API_AVAILABLE(macos(10.13.4), ios(11.3));
+- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler WK_API_DEPRECATED_WITH_REPLACEMENT("_webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:", macos(10.12.3, 10.14.4), ios(10.3, 12.2));
+- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction userInfo:(id )userInfo decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler WK_API_DEPRECATED_WITH_REPLACEMENT("_webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA));
+-(void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction preferences:(WKWebpagePreferences *)preferences userInfo:(id )userInfo decisionHandler:(void (^)(WKNavigationActionPolicy, WKWebpagePreferences *))decisionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 - (void)_webView:(WKWebView *)webView

[webkit-changes] [247025] trunk

2019-07-01 Thread cdumez

Title: [247025] trunk








Revision 247025
Author cdu...@apple.com
Date 2019-07-01 14:55:03 -0700 (Mon, 01 Jul 2019)


Log Message
It should not be possible to trigger a load while in the middle of restoring a page in PageCache
https://bugs.webkit.org/show_bug.cgi?id=199190


Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/security/navigate-when-restoring-cached-page.html

* history/CachedFrame.cpp:
(WebCore::CachedFrame::open):
Stop attaching the cached document before calling FrameLoader::open() given that the previous document
is still attached to the frame at this point. This avoids having 2 documents attached to the same frame
during a short period of time.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
We now attach the cached document to the frame *after* calling FrameLoader::clear(), which means that
the previous document now has been detached from this frame.

(WebCore::FrameLoader::detachChildren):
As per the HTML specification [1], an attempt to navigate should fail if the prompt to unload algorithm
is being run for the active document of browsingContext. Note that the "prompt to unload" algorithm [2]
includes firing the 'unload' event in the current document and in all the documents in the subframes.
As a result, FrameLoader::detachChildren() is the right prevent such navigations. We were actually trying
to do this via the SubframeLoadingDisabler stack variable inside detachChildren(). The issue is that this
only prevents navigation in the subframes (i.e.  elements), not the main frame. As a result,
script would be able to navigate the top-frame even though detachChildren() is being called on the top
frame. To address the issue, I now create a NavigationDisabler variable in the scope of detachChildren()
when detachChildren() is called on the top frame. NavigationDisabler prevents all navigations within the
page, including navigations on the main/top frame.

[1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate
[2] https://html.spec.whatwg.org/multipage/browsing-the-web.html#prompt-to-unload-a-document

LayoutTests:

Add layout test coverage.

* http/tests/security/navigate-when-restoring-cached-page-expected.txt: Added.
* http/tests/security/navigate-when-restoring-cached-page.html: Added.
* http/tests/security/resources/navigate-when-restoring-cached-page-frame.html: Added.
* http/tests/security/resources/navigate-when-restoring-cached-page-victim.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/CachedFrame.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp


Added Paths

trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt
trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page.html
trunk/LayoutTests/http/tests/security/resources/navigate-when-restoring-cached-page-frame.html
trunk/LayoutTests/http/tests/security/resources/navigate-when-restoring-cached-page-victim.html




Diff

Modified: trunk/LayoutTests/ChangeLog (247024 => 247025)

--- trunk/LayoutTests/ChangeLog	2019-07-01 21:25:57 UTC (rev 247024)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 21:55:03 UTC (rev 247025)
@@ -1,3 +1,18 @@
+2019-07-01  Chris Dumez  
+
+It should not be possible to trigger a load while in the middle of restoring a page in PageCache
+https://bugs.webkit.org/show_bug.cgi?id=199190
+
+
+Reviewed by Brady Eidson.
+
+Add layout test coverage.
+
+* http/tests/security/navigate-when-restoring-cached-page-expected.txt: Added.
+* http/tests/security/navigate-when-restoring-cached-page.html: Added.
+* http/tests/security/resources/navigate-when-restoring-cached-page-frame.html: Added.
+* http/tests/security/resources/navigate-when-restoring-cached-page-victim.html: Added.
+
 2019-07-01  Truitt Savell  
 
 Unreviewed, rolling out r246844.


Added: trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt (0 => 247025)

--- trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt	2019-07-01 21:55:03 UTC (rev 247025)
@@ -0,0 +1 @@
+This test passes if it does not print an ALERT with "secret data".


Added: trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page.html (0 => 247025)

--- trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page.html	2019-07-01 21:55:03 UTC (rev 247025)
@@ -0,0 +1,99 @@
+
+
+
+This test passes if it does not print an ALERT with "secret data".
+
+if (window.testRunner) {
+  testRunner.dumpAsText();
+  testRunner.waitUntilDone();
+  testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
+

[webkit-changes] [247024] trunk

2019-07-01 Thread tsavell

Title: [247024] trunk








Revision 247024
Author tsav...@apple.com
Date 2019-07-01 14:25:57 -0700 (Mon, 01 Jul 2019)


Log Message
Unreviewed, rolling out r246844.

Broke 12 tests in imported/w3c/web-platform-
tests/pointerevents/

Reverted changeset:

"[Pointer Events] Respect pointer capture when dispatching
mouse boundary events and updating :hover"
https://bugs.webkit.org/show_bug.cgi?id=198999
https://trac.webkit.org/changeset/246844

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/PointerEvent.h
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/page/PointerCaptureController.cpp
trunk/Source/WebCore/page/PointerCaptureController.h




Diff

Modified: trunk/LayoutTests/ChangeLog (247023 => 247024)

--- trunk/LayoutTests/ChangeLog	2019-07-01 21:23:44 UTC (rev 247023)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 21:25:57 UTC (rev 247024)
@@ -1,5 +1,19 @@
 2019-07-01  Truitt Savell  
 
+Unreviewed, rolling out r246844.
+
+Broke 12 tests in imported/w3c/web-platform-
+tests/pointerevents/
+
+Reverted changeset:
+
+"[Pointer Events] Respect pointer capture when dispatching
+mouse boundary events and updating :hover"
+https://bugs.webkit.org/show_bug.cgi?id=198999
+https://trac.webkit.org/changeset/246844
+
+2019-07-01  Truitt Savell  
+
 Unreviewed, rolling out r246958.
 
 Broke inspector/dom/getAccessibilityPropertiesForNode.html


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (247023 => 247024)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-07-01 21:23:44 UTC (rev 247023)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-07-01 21:25:57 UTC (rev 247024)
@@ -1,3 +1,17 @@
+2019-07-01  Truitt Savell  
+
+Unreviewed, rolling out r246844.
+
+Broke 12 tests in imported/w3c/web-platform-
+tests/pointerevents/
+
+Reverted changeset:
+
+"[Pointer Events] Respect pointer capture when dispatching
+mouse boundary events and updating :hover"
+https://bugs.webkit.org/show_bug.cgi?id=198999
+https://trac.webkit.org/changeset/246844
+
 2019-06-26  Antoine Quint  
 
 [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt (247023 => 247024)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt	2019-07-01 21:23:44 UTC (rev 247023)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt	2019-07-01 21:25:57 UTC (rev 247024)
@@ -1,8 +1,10 @@
 Pointer Event: Boundary event sequence at implicit capture release
 
+Follow the test instructions with mouse. If you don't have the device skip it.
+
 When a captured pointer is implicitly released after a click, the boundary events should follow the lostpointercapture event.
 
 Click on the black box with mouse and do not move the mouse after or during the click.
 
-PASS mouse Event sequence at implicit release on click 
+FAIL mouse Event sequence at implicit release on click assert_equals: expected "pointerout@target, pointerleave@target, pointerover@capture-target, pointerenter@capture-target, gotpointercapture@capture-target, pointerup@capture-target, lostpointercapture@capture-target, pointerout@capture-target, pointerleave@capture-target, pointerover@target, pointerenter@target" but got "gotpointercapture@capture-target, pointerup@capture-target, lostpointercapture@capture-target"
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt (247023 => 247024)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt	2019-07-01 21:23:44 UTC (rev 247023)
+++

[webkit-changes] [247023] trunk/Source/WebCore

2019-07-01 Thread tsavell

Title: [247023] trunk/Source/WebCore








Revision 247023
Author tsav...@apple.com
Date 2019-07-01 14:23:44 -0700 (Mon, 01 Jul 2019)


Log Message
Unreviewed, rolling out r246849.

12 tests broken in r246844 require this to be rolled out.

Reverted changeset:

"[Pointer Events] Respect pointer capture when dispatching
mouse boundary events and updating :hover"
https://bugs.webkit.org/show_bug.cgi?id=198999
https://trac.webkit.org/changeset/246849

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PointerCaptureController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (247022 => 247023)

--- trunk/Source/WebCore/ChangeLog	2019-07-01 21:17:00 UTC (rev 247022)
+++ trunk/Source/WebCore/ChangeLog	2019-07-01 21:23:44 UTC (rev 247023)
@@ -1,3 +1,16 @@
+2019-07-01  Truitt Savell  
+
+Unreviewed, rolling out r246849.
+
+12 tests broken in r246844 require this to be rolled out.
+
+Reverted changeset:
+
+"[Pointer Events] Respect pointer capture when dispatching
+mouse boundary events and updating :hover"
+https://bugs.webkit.org/show_bug.cgi?id=198999
+https://trac.webkit.org/changeset/246849
+
 2019-07-01  Alex Christensen  
 
 Null check provisionalItem in FrameLoader::continueLoadAfterNavigationPolicy


Modified: trunk/Source/WebCore/page/PointerCaptureController.cpp (247022 => 247023)

--- trunk/Source/WebCore/page/PointerCaptureController.cpp	2019-07-01 21:17:00 UTC (rev 247022)
+++ trunk/Source/WebCore/page/PointerCaptureController.cpp	2019-07-01 21:23:44 UTC (rev 247023)
@@ -409,15 +409,15 @@
 
 void PointerCaptureController::processPendingPointerCapture(PointerID pointerId)
 {
-auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
-if (iterator == m_activePointerIdsToCapturingData.end())
-return;
-
 if (m_processingPendingPointerCapture)
 return;
 
 m_processingPendingPointerCapture = true;
 
+auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
+if (iterator == m_activePointerIdsToCapturingData.end())
+return;
+
 auto& capturingData = iterator->value;
 
 // Cache the pending target override since it could be modified during the dispatch of events in this function.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247022] trunk

2019-07-01 Thread commit-queue

Title: [247022] trunk








Revision 247022
Author commit-qu...@webkit.org
Date 2019-07-01 14:17:00 -0700 (Mon, 01 Jul 2019)


Log Message
Source/WebKit:
Deprecate but still call _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
https://bugs.webkit.org/show_bug.cgi?id=199296


Patch by Alex Christensen  on 2019-07-01
Reviewed by Darin Adler.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showAttachmentSheet]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
(-[WKContentView continueContextMenuInteraction:]):

Tools:
Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
https://bugs.webkit.org/show_bug.cgi?id=199296


Patch by Alex Christensen  on 2019-07-01
Reviewed by Darin Adler.

* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator _webView:showCustomSheetForElement:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (247021 => 247022)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 21:11:36 UTC (rev 247021)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 21:17:00 UTC (rev 247022)
@@ -1,5 +1,19 @@
 2019-07-01  Alex Christensen  
 
+Deprecate but still call _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
+https://bugs.webkit.org/show_bug.cgi?id=199296
+
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _showAttachmentSheet]):
+(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
+(-[WKContentView continueContextMenuInteraction:]):
+
+2019-07-01  Alex Christensen  
+
 Add main thread assertions in sendWithAsyncReply code
 https://bugs.webkit.org/show_bug.cgi?id=199324
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (247021 => 247022)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2019-07-01 21:11:36 UTC (rev 247021)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2019-07-01 21:17:00 UTC (rev 247022)
@@ -156,18 +156,18 @@
 - (void)_webView:(WKWebView *)webView contextMenuDidEndForElement:(WKContextMenuElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA));
 #endif
 
-- (BOOL)_webView:(WKWebView *)webView showCustomSheetForElement:(_WKActivatedElementInfo *)element WK_API_AVAILABLE(ios(10.0));
+- (BOOL)_webView:(WKWebView *)webView showCustomSheetForElement:(_WKActivatedElementInfo *)element WK_API_DEPRECATED_WITH_REPLACEMENT("_webView:contextMenuConfigurationForElement:completionHandler:", ios(10.0, WK_IOS_TBA));
 - (void)_webView:(WKWebView *)webView alternateActionForURL:(NSURL *)url WK_API_AVAILABLE(ios(10.0));
 - (NSArray *)_attachmentListForWebView:(WKWebView *)webView WK_API_AVAILABLE(ios(10.0));
 - (NSArray *)_attachmentListForWebView:(WKWebView *)webView sourceIsManaged:(BOOL*)sourceIsManaged WK_API_AVAILABLE(ios(10.3));
 - (NSUInteger)_webView:(WKWebView *)webView indexIntoAttachmentListForElement:(_WKActivatedElementInfo *)element WK_API_AVAILABLE(ios(10.3));
 - (UIEdgeInsets)_webView:(WKWebView *)webView finalObscuredInsetsForScrollView:(UIScrollView *)scrollView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset WK_API_AVAILABLE(ios(9.0));
-- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForURL:(NSURL *)url defaultActions:(NSArray<_WKElementAction *> *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:", ios(9.0, WK_IOS_TBA));
-- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray<_WKElementAction *> *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:", ios(9.0, WK_IOS_TBA));
+- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForURL:(NSURL *)url defaultActions:(NSArray<_WKElementAction *> *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(9.0, WK_IOS_TBA));
+- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray<_WKElementAction *> *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(9.0, WK_IOS_TBA));
 -

[webkit-changes] [247021] trunk/Source/WebCore

2019-07-01 Thread commit-queue

Title: [247021] trunk/Source/WebCore








Revision 247021
Author commit-qu...@webkit.org
Date 2019-07-01 14:11:36 -0700 (Mon, 01 Jul 2019)


Log Message
Null check provisionalItem in FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=199327


Patch by Alex Christensen  on 2019-07-01
Reviewed by Darin Adler.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
Sometimes provisionalItem is null.  Let's not crash.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (247020 => 247021)

--- trunk/Source/WebCore/ChangeLog	2019-07-01 21:11:29 UTC (rev 247020)
+++ trunk/Source/WebCore/ChangeLog	2019-07-01 21:11:36 UTC (rev 247021)
@@ -1,3 +1,15 @@
+2019-07-01  Alex Christensen  
+
+Null check provisionalItem in FrameLoader::continueLoadAfterNavigationPolicy
+https://bugs.webkit.org/show_bug.cgi?id=199327
+
+
+Reviewed by Darin Adler.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
+Sometimes provisionalItem is null.  Let's not crash.
+
 2019-07-01  Truitt Savell  
 
 Unreviewed, rolling out r246958.


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (247020 => 247021)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2019-07-01 21:11:29 UTC (rev 247020)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2019-07-01 21:11:36 UTC (rev 247021)
@@ -3473,7 +3473,7 @@
 
 if (isBackForwardLoadType(type)) {
 auto& diagnosticLoggingClient = m_frame.page()->diagnosticLoggingClient();
-if (history().provisionalItem()->isInPageCache()) {
+if (history().provisionalItem() && history().provisionalItem()->isInPageCache()) {
 diagnosticLoggingClient.logDiagnosticMessageWithResult(DiagnosticLoggingKeys::pageCacheKey(), DiagnosticLoggingKeys::retrievalKey(), DiagnosticLoggingResultPass, ShouldSample::Yes);
 loadProvisionalItemFromCachedPage();
 RELEASE_LOG_IF_ALLOWED("continueLoadAfterNavigationPolicy: can't continue loading frame because it will be loaded from cache (frame = %p, main = %d)", _frame, m_frame.isMainFrame());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247020] trunk/Source/WebKit

2019-07-01 Thread commit-queue

Title: [247020] trunk/Source/WebKit








Revision 247020
Author commit-qu...@webkit.org
Date 2019-07-01 14:11:29 -0700 (Mon, 01 Jul 2019)


Log Message
Add main thread assertions in sendWithAsyncReply code
https://bugs.webkit.org/show_bug.cgi?id=199324

Patch by Alex Christensen  on 2019-07-01
Reviewed by Sam Weinig.

sendWithAsyncReply can only be used on the main thread because
the CompletionHandler will be called on the main thread, and if it's
called from a background thread, then HashMap corruption will likely happen.
Add assertions to alert developers that they should only call sendWithAsyncReply
from the main thread.

This is responding to good feedback from r237294

* Platform/IPC/Connection.cpp:
(IPC::asyncReplyHandlerMap):
(IPC::nextAsyncReplyHandlerID):
(IPC::addAsyncReplyHandler):
(IPC::clearAsyncReplyHandlers):
(IPC::CompletionHandler

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (247019 => 247020)

--- trunk/Source/WebKit/ChangeLog	2019-07-01 21:07:31 UTC (rev 247019)
+++ trunk/Source/WebKit/ChangeLog	2019-07-01 21:11:29 UTC (rev 247020)
@@ -1,3 +1,25 @@
+2019-07-01  Alex Christensen  
+
+Add main thread assertions in sendWithAsyncReply code
+https://bugs.webkit.org/show_bug.cgi?id=199324
+
+Reviewed by Sam Weinig.
+
+sendWithAsyncReply can only be used on the main thread because
+the CompletionHandler will be called on the main thread, and if it's
+called from a background thread, then HashMap corruption will likely happen.
+Add assertions to alert developers that they should only call sendWithAsyncReply
+from the main thread.
+
+This is responding to good feedback from r237294
+
+* Platform/IPC/Connection.cpp:
+(IPC::asyncReplyHandlerMap):
+(IPC::nextAsyncReplyHandlerID):
+(IPC::addAsyncReplyHandler):
+(IPC::clearAsyncReplyHandlers):
+(IPC::CompletionHandler 2019-07-01  Eric Carlson  
 
 [iOS] Exiting from fullscreen scrolls to top of page


Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (247019 => 247020)

--- trunk/Source/WebKit/Platform/IPC/Connection.cpp	2019-07-01 21:07:31 UTC (rev 247019)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp	2019-07-01 21:11:29 UTC (rev 247020)
@@ -239,6 +239,7 @@
 
 static HashMap>>& asyncReplyHandlerMap()
 {
+ASSERT(RunLoop::isMain());
 static NeverDestroyed>>> map;
 return map.get();
 }
@@ -1127,6 +1128,7 @@
 
 uint64_t nextAsyncReplyHandlerID()
 {
+ASSERT(RunLoop::isMain());
 static uint64_t identifier { 0 };
 return ++identifier;
 }
@@ -1133,6 +1135,7 @@
 
 void addAsyncReplyHandler(Connection& connection, uint64_t identifier, CompletionHandler&& completionHandler)
 {
+ASSERT(RunLoop::isMain());
 auto result = asyncReplyHandlerMap().ensure(reinterpret_cast(), [] {
 return HashMap>();
 }).iterator->value.add(identifier, WTFMove(completionHandler));
@@ -1141,6 +1144,7 @@
 
 void clearAsyncReplyHandlers(const Connection& connection)
 {
+ASSERT(RunLoop::isMain());
 auto map = asyncReplyHandlerMap().take(reinterpret_cast());
 for (auto& handler : map.values()) {
 if (handler)
@@ -1150,6 +1154,7 @@
 
 CompletionHandler takeAsyncReplyHandler(Connection& connection, uint64_t identifier)
 {
+ASSERT(RunLoop::isMain());
 auto iterator = asyncReplyHandlerMap().find(reinterpret_cast());
 if (iterator != asyncReplyHandlerMap().end()) {
 if (!iterator->value.isValidKey(identifier)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247019] trunk

2019-07-01 Thread tsavell

Title: [247019] trunk








Revision 247019
Author tsav...@apple.com
Date 2019-07-01 14:07:31 -0700 (Mon, 01 Jul 2019)


Log Message
Unreviewed, rolling out r246958.

Broke inspector/dom/getAccessibilityPropertiesForNode.html

Reverted changeset:

"Enhance support of aria-haspopup per ARIA 1.1 specification."
https://bugs.webkit.org/show_bug.cgi?id=199216
https://trac.webkit.org/changeset/246958

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/button-with-aria-haspopup-role-expected.txt
trunk/LayoutTests/accessibility/button-with-aria-haspopup-role.html
trunk/LayoutTests/accessibility/ios-simulator/button-with-aria-haspopup-role-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/button-with-aria-haspopup-role.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessible.cpp
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/AccessibilityUIElement.h
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
trunk/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (247018 => 247019)

--- trunk/LayoutTests/ChangeLog	2019-07-01 20:52:58 UTC (rev 247018)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 21:07:31 UTC (rev 247019)
@@ -1,3 +1,15 @@
+2019-07-01  Truitt Savell  
+
+Unreviewed, rolling out r246958.
+
+Broke inspector/dom/getAccessibilityPropertiesForNode.html
+
+Reverted changeset:
+
+"Enhance support of aria-haspopup per ARIA 1.1 specification."
+https://bugs.webkit.org/show_bug.cgi?id=199216
+https://trac.webkit.org/changeset/246958
+
 2019-07-01  Eric Carlson  
 
 [iOS] Exiting from fullscreen scrolls to top of page


Modified: trunk/LayoutTests/accessibility/button-with-aria-haspopup-role-expected.txt (247018 => 247019)

--- trunk/LayoutTests/accessibility/button-with-aria-haspopup-role-expected.txt	2019-07-01 20:52:58 UTC (rev 247018)
+++ trunk/LayoutTests/accessibility/button-with-aria-haspopup-role-expected.txt	2019-07-01 21:07:31 UTC (rev 247019)
@@ -3,26 +3,16 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-test1 AXRole: AXButton for aria-haspopup = (null)
-AX popupValue = 'false'
-test2 AXRole: AXPopUpButton for aria-haspopup = 'true'
-AX popupValue = 'menu'
-test3 AXRole: AXButton for aria-haspopup = 'false'
-AX popupValue = 'false'
-test4 AXRole: AXPopUpButton for aria-haspopup = 'dialog'
-AX popupValue = 'dialog'
-test5 AXRole: AXPopUpButton for aria-haspopup = 'grid'
-AX popupValue = 'grid'
-test6 AXRole: AXPopUpButton for aria-haspopup = 'listbox'
-AX popupValue = 'listbox'
-test7 AXRole: AXPopUpButton for aria-haspopup = 'menu'
-AX popupValue = 'menu'
-test8 AXRole: AXPopUpButton for aria-haspopup = 'tree'
-AX popupValue = 'tree'
-test9 AXRole: AXButton for aria-haspopup = 'foo'
-AX popupValue = 'false'
-test10 AXRole: AXButton for aria-haspopup = ''
-AX popupValue = 'false'
+test1 AXRole: AXButton for aria-haspopup=(null)
+test2 AXRole: AXPopUpButton for aria-haspopup='true'
+test3 AXRole: AXButton for aria-haspopup='false'
+test4 AXRole: AXPopUpButton for aria-haspopup='dialog'
+test5 AXRole: AXPopUpButton for aria-haspopup='grid'
+test6 AXRole: AXPopUpButton for aria-haspopup='listbox'
+test7 AXRole: AXPopUpButton for aria-haspopup='menu'
+test8 AXRole: AXPopUpButton for aria-haspopup='tree'
+test9 AXRole: AXButton for aria-haspopup='foo'
+test10 AXRole: AXButton for aria-haspopup=''
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/accessibility/button-with-aria-haspopup-role.html (247018 => 247019)

--- trunk/LayoutTests/accessibility/button-with-aria-haspopup-role.html	2019-07-01 20:52:58 UTC (rev 247018)
+++ trunk/LayoutTests/accessibility/button-with-aria-haspopup-role.html	2019-07-01 21:07:31 UTC (rev 247019)
@@ -22,12 +22,10 @@
 description("This tests the platform role exposed for buttons with aria-haspopup");
 if (window.accessibilityController) {
 for (var i = 1; i <= 10; i++) {
-var element = document.getElementById("test" + i)
+	var element = document.getElementById("test" + i)

[webkit-changes] [247018] trunk

2019-07-01 Thread eric . carlson

Title: [247018] trunk








Revision 247018
Author eric.carl...@apple.com
Date 2019-07-01 13:52:58 -0700 (Mon, 01 Jul 2019)


Log Message
[iOS] Exiting from fullscreen scrolls to top of page
https://bugs.webkit.org/show_bug.cgi?id=199338


Reviewed by Jer Noble.

Source/WebKit:

* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _completedExitFullScreen]): Restore scroll position.
Hide window after restoring scroll position.
(-[WKFullScreenWindowController _exitFullscreenImmediately]): Drive-by fix: remove code
already also done in _completedExitFullScreen.

LayoutTests:

* fullscreen/fullscreen-restore-scroll-position-expected.txt: Added.
* fullscreen/fullscreen-restore-scroll-position.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm


Added Paths

trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position-expected.txt
trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position.html




Diff

Modified: trunk/LayoutTests/ChangeLog (247017 => 247018)

--- trunk/LayoutTests/ChangeLog	2019-07-01 20:29:20 UTC (rev 247017)
+++ trunk/LayoutTests/ChangeLog	2019-07-01 20:52:58 UTC (rev 247018)
@@ -1,3 +1,14 @@
+2019-07-01  Eric Carlson  
+
+[iOS] Exiting from fullscreen scrolls to top of page
+https://bugs.webkit.org/show_bug.cgi?id=199338
+
+
+Reviewed by Jer Noble.
+
+* fullscreen/fullscreen-restore-scroll-position-expected.txt: Added.
+* fullscreen/fullscreen-restore-scroll-position.html: Added.
+
 2019-07-01  Russell Epstein  
 
 Layout Test imported/mozilla/svg/text/selectSubString.svg is flaky.


Added: trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position-expected.txt (0 => 247018)

--- trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position-expected.txt	(rev 0)
+++ trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position-expected.txt	2019-07-01 20:52:58 UTC (rev 247018)
@@ -0,0 +1,6 @@
+This tests that page scroll is restored after fullscreen. Press any key to start the test.
+
+
+EVENT(load)
+EXPECTED ((document.scrollingElement.scrollTop === originalScroll) == 'true') OK
+


Added: trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position.html (0 => 247018)

--- trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position.html	(rev 0)
+++ trunk/LayoutTests/fullscreen/fullscreen-restore-scroll-position.html	2019-07-01 20:52:58 UTC (rev 247018)
@@ -0,0 +1,61 @@
+
+
+
+fullscreen-restore-scroll-position
+
+html, body, #spacer {
+height: 100%;
+}
+video {
+width: 600px;
+height: 400px;
+}
+
+