[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #47 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 restored by Legoktm:
Merge Poem extension into core

Reason:
I think this is a valuable changeset that should be pursued.

https://gerrit.wikimedia.org/r/106861

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 CC||legoktm.wikipe...@gmail.com

--- Comment #48 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to Tpt from comment #45)
 Yes, you have right with mw-lines.
 
 I understand your concern with differing functionality that would require
 two buttons in the editing interface (it's the major concern I see). I think
 we should have feedback from the VisualEditor team.

James, do you/your team have an opinion?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #49 from James Forrester jforres...@wikimedia.org ---
(In reply to Kunal Mehta (Legoktm) from comment #48)
 (In reply to Tpt from comment #45)
  Yes, you have right with mw-lines.
  
  I understand your concern with differing functionality that would require
  two buttons in the editing interface (it's the major concern I see). I think
  we should have feedback from the VisualEditor team.
 
 James, do you/your team have an opinion?

I don't particularly mind it being merged into core from an editing POV, but
it is yet another feature in MediaWiki core which we're meant to be making
leaner, faster and more flexible, which this roughly feels like it goes
against.

The Parsoid-land changes aren't too hard to handle, I believe, so that
shouldn't block this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Nathan Larson nathanlarson3...@gmail.com changed:

   What|Removed |Added

 CC||nathanlarson3...@gmail.com

--- Comment #50 from Nathan Larson nathanlarson3...@gmail.com ---
(In reply to James Forrester from comment #49)
 I don't particularly mind it being merged into core from an editing POV,
 but it is yet another feature in MediaWiki core which we're meant to be
 making leaner, faster and more flexible, which this roughly feels like it
 goes against.
 
 The Parsoid-land changes aren't too hard to handle, I believe, so that
 shouldn't block this.

It's also another one of those features that will come in at least slightly
handy on almost every wiki, though. It's deployed on a significant percentage
of wikis, and on those on which it isn't deployed, the users probably wish it
were deployed when they run into situations that call for its use.
https://wikiapiary.com/wiki/Extension:Poem

Admittedly, it's not as important as, say, ParserFunctions or Cite (both of
which should probably be merged to the core, by the way). But it's not very
harmful, either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #51 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #42)
 (In reply to comment #38)
 A Global Message Delivery to all Wikisource Scriptoriums/Village pump is
 higly recommended
 
 MZMcBride, could you advise how feasible this would be?

I think a mention in [[m:Tech/News]] is sufficient here. Nothing is breaking,
as I understand it, so this news is purely informational: In addition to
poem, you can also now use some other tag name.

If you really want to send a global message, you can use [[m:MassMessage]].

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW
 CC||krinklem...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-07-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #46 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 abandoned by Krinkle:
Merge Poem extension into core

Reason:
Closing for now to clear pending review dashboard. Feel free to re-open when
you can work on it.

https://gerrit.wikimedia.org/r/106861

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Tpt thoma...@hotmail.fr changed:

   What|Removed |Added

 CC||thoma...@hotmail.fr

--- Comment #43 from Tpt thoma...@hotmail.fr ---
As I believe that poem tag will be kept as an alias forever, it may be
interesting to make poem and lines semantic a little bit different:
- lines would be presentational only and the output will have the lines
class as in pre class=lines
- poem has the same presentational effect as lines but use the poem class
to specify that the content is a poem as in pre class=lines poem

It won't break sites CSS because the current pages only use the poem tags. If
wikis wants to use their custom CSS for poem tag with all lines tags, they
will only have to change poem by lines in their rules.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #44 from This, that and the other at.li...@live.com.au ---
That's a very good suggestion, Tpt. I would be inclined to call the CSS class
something more like mw-lines or similar, to comply with modern class naming
standards.

However I wonder if it is really a good idea to provide differing
functionality, however minor, between poem and lines?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #45 from Tpt thoma...@hotmail.fr ---
Yes, you have right with mw-lines.

I understand your concern with differing functionality that would require two
buttons in the editing interface (it's the major concern I see). I think we
should have feedback from the VisualEditor team.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #42 from This, that and the other at.li...@live.com.au ---
(In reply to comment #37)
 (In reply to comment #31)
  1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
  publicize the new lines name before it gets committed.  
  A mailing list thread might be a good way to
  kick off this discussion.
 
 I'll post one.

http://lists.wikimedia.org/pipermail/wikitech-l/2014-February/074337.html

No replies, so I assume no-one is concerned.

(In reply to comment #38)
 A Global Message Delivery to all Wikisource Scriptoriums/Village pump is
 higly recommended

MZMcBride, could you advise how feasible this would be?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

555 lugu...@gmail.com changed:

   What|Removed |Added

 Depends on||6810

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

555 lugu...@gmail.com changed:

   What|Removed |Added

 CC||lugu...@gmail.com

--- Comment #38 from 555 lugu...@gmail.com ---
A Global Message Delivery to all Wikisource Scriptoriums/Village pump is higly
recommended, since this extension was firtly developed to Wikisource wikis and
latter enabled on all Wikimedia wikis [1] [2].

In the time that poem/ tag arised on Wikisources, we have also asked for a
prose/ tag (See bug 6810).

Unfortunately at that time the developers picked what was most easy to then
instead of what is more user intuitive (sorry, but poemfoo/poem and {{prose
start}}foo{{prose end}} don't makes sense to newcomers (#c6).

As you can see on [3] and [4], the formatting isn't the same currently adopted
in poem/ tag, so the current consensus to set poem/ as an alias for a new
tag name isn't viable.

[1] - https://wikitech.wikimedia.org/wiki/Server_admin_log/Archive_7#June_23

[2] -
https://wikitech.wikimedia.org/wiki/Server_admin_log/Archive_10#February_7

[3] - https://en.wikisource.org/wiki/Template:Prose

[4] - https://fr.wikisource.org/w/index.php?title=MediaWiki:Common.css (classe
prose : PERIMÉE, utiliser text )

[[:m:User:555]]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Bug 52061 depends on bug 6810, which changed state.

Bug 6810 Summary: create prose tag
https://bugzilla.wikimedia.org/show_bug.cgi?id=6810

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #39 from This, that and the other at.li...@live.com.au ---
(In reply to comment #38)
 In the time that poem/ tag arised on Wikisources, we have also asked for a
 prose/ tag (See bug 6810).

That is an entirely separate issue. The presence or absence of a prose tag is
not going to affect the resolution of this bug.

 As you can see on [3] and [4], the formatting isn't the same currently
 adopted
 in poem/ tag, so the current consensus to set poem/ as an alias for a new
 tag name isn't viable.

I don't understand your point here. What has this got to do with the poem
tag?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

This, that and the other at.li...@live.com.au changed:

   What|Removed |Added

 Depends on|6810|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #40 from 555 lugu...@gmail.com ---
The poem/ tag usage on texts that does not contains poems, only the need to
parse line breaks in a different behaviour, isn't the feature itself provided
by the extension, only a very interesting side effect.

It looks to me like in very old MediaWiki versions without file undeletion
support: media deletion at that time resulted in less disk space being used.
But that aren't the feature, only a side effect.

IMHO before merging Extension:Poem into core it firstly needs to addresses all
expected behaviours in their original expected feature, ie to provide quickly
and in easy ways alternatives to format text portions based in a given form of
language.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #41 from This, that and the other at.li...@live.com.au ---
(In reply to comment #40)
 The poem/ tag usage on texts that does not contains poems, only the need to
 parse line breaks in a different behaviour, isn't the feature itself provided
 by the extension, only a very interesting side effect.

Please read the preceding comments in this bug report. The reason why this tag
is going to be made available under the name lines is to emphasise that is
not only used for poems, but for other texts that require the preservation of
line breaks. This is not merely a side effect, but the key feature of this
tag.

 IMHO before merging Extension:Poem into core it firstly needs to addresses
 all
 expected behaviours in their original expected feature,

A merge of an extension into core, means taking the extension's existing
functionality, and placing it in MediaWiki core. It does not mean we add extra
features at the same time.

The Poem extension only provides poem-related (line break preservation)
functionality, so that is all that core is getting in this merge. This is not
the place to discuss other original expected features.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #36 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #31)
 1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
 publicize the new lines name before it gets committed.  We almost
 inadvertently introduced a conflict with verbatim, I'd like some greater
 certainty that the new lines name proposal has been seen by a larger number
 of editors/extension authors.  A mailing list thread might be a good way to
 kick off this discussion.

Will a post to wikitech-l suffice? Or is more needed in your opinion? I can
probably handle the communication portion of this, just please be explicit with
what you would consider sufficient.

 2) In the comments on the patch, '' was brought up as the last remaining
 way that the current lines implementation differs from 'indent-pre'
 handling.

Okay, I figured out what you mean here. At [[testwiki:Bug 52061#Indent-Pre
(Preceding space)]] a , the wikitext equivalent of a horizontal rule
(hr), is not current expanded when there's a leading space.

In my opinion, this behavior (preceding space + unexpanded horizontal rule) is
a separate issue that should be filed as a separate bug report (if one doesn't
exist already) and is not a blocker to merging Gerrit change 106861. If you
feel differently, can you please elaborate? (Also, can you please search for a
relevant bug report and/or file one?)

 3) I'd also like to review the code coverage issues a little more, to ensure
 that we're sharing code (and CSS rules) to the maximum extent possible.  This
 is to ensure that point #2 continues to hold in the future, and we don't
 accidentally introduce subtle incompatibilities by changing only one side of
 a code path.

Sure, code review is ongoing at Gerrit change 106861. If you have additional
suggestions for technical changes, feel free to leave them on Gerrit. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #37 from This, that and the other at.li...@live.com.au ---
(In reply to comment #31)
 1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
 publicize the new lines name before it gets committed.  
 A mailing list thread might be a good way to
 kick off this discussion.

I'll post one.

 2) In the comments on the patch, '' was brought up as the last remaining
 way that the current lines implementation differs from 'indent-pre'
 handling.
  I'd like to resolve this discrepancy: I really really *really* don't want to
 complicate the parser more with Yet Another Slightly Different Way to handle
 preformatted content.

Let me expand a bit here: poem is designed for the treatment of poetry. I
don't know what indent-pre was designed for, but one assumes it was intended
for general-purpose, preformatted text, such as command line outputs and
plain-text tables. The two use-cases are somewhat different.

I went through and found the following differences. There are probably many
others.

* For some reason, indent-pre doesn't handle . Presumably this is so
  preformatted tables, etc (e.g. those copied out of the MySQL monitor)
  still appear correctly. This consideration is not relevant for poem and
  so  is parsed inside these tags. Indeed,  within poem is quite
  common at Wikisource.

* Indents using : are ignored within indent-pre (presumably because they
  don't make a whole lot of sense in a preformatted context). In poem,
  indents are handled specially (using a fixed-width span to give 1em
  indentation per : character), and line-initial spaces are transformed
  to nbsp;, to cope with the special formatting of some poetry.

* Wikitext {| |} tables are available within poem, whereas indent-pre is
  aborted as soon as a table is found.

* Indent-pre formatting is aborted whenever a block-level tag is
  encountered on the line. Block-level formatting is, however, available
  inside poem (although this is only useful for stuff like table, since
  the appearance of tags like p is affected quite badly by the pre
  environment).

* Indent-pre is not available inside blockquote, for unclear reasons.
  poem works fine inside blockquote, just as anywhere else.

* poem allows the application of a custom class/ID/style. The use of a
  tag also allows extra attributes to be used - I have a patch in the works
  that adds line numbering support to poem, which makes use of several
  additional tag attributes (see bug 13644).

I don't think it is correct to speak of resolving these discrepancies. As you
can see, most of them seem to exist for a reason, and most involve
idiosyncrasies in the existing indent-pre behaviour, any changes to which would
disrupt existing wikitext.

(Note, when I talk about poem above, I'm talking about the new implementation
in Gerrit. The old extension sometimes does things differently.)

 3) I'd also like to review the code coverage issues a little more, to ensure
 that we're sharing code (and CSS rules) to the maximum extent possible.

I think this is up to you, Scott, and others in the know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #35 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com ---
Instead of finding similarities between poem and indent-pre, which is moot
since the indentation already breaks all markup that depends on being on the
first column of the line, we may look at similarities between poem and normal
wikitext.

It's practically the same. The only difference is that poem treats newlines as
br/, while normal text simply ignore newlines or convert them into paragraphs
when there's a combination of newlines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #31 from C. Scott Ananian canan...@wikimedia.org ---
I think I just saved this patch from a premature +2.

I'd like to summarize what still needs to be done here:

1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
publicize the new lines name before it gets committed.  We almost
inadvertently introduced a conflict with verbatim, I'd like some greater
certainty that the new lines name proposal has been seen by a larger number
of editors/extension authors.  A mailing list thread might be a good way to
kick off this discussion.

2) In the comments on the patch, '' was brought up as the last remaining
way that the current lines implementation differs from 'indent-pre' handling.
 I'd like to resolve this discrepancy: I really really *really* don't want to
complicate the parser more with Yet Another Slightly Different Way to handle
preformatted content.

3) I'd also like to review the code coverage issues a little more, to ensure
that we're sharing code (and CSS rules) to the maximum extent possible.  This
is to ensure that point #2 continues to hold in the future, and we don't
accidentally introduce subtle incompatibilities by changing only one side of a
code path.

Does anyone else have any remaining issues they'd like to see resolved before
this is merged?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #32 from C. Scott Ananian canan...@wikimedia.org ---
I added a few more test cases to [[testwiki:bug 52061]] -- leading colons are
also parsed differently inside poem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #33 from C. Scott Ananian canan...@wikimedia.org ---
From chat:

(07:32:52 PM) subbu: i just checked the updated wiki page .. and  hr and
colon-indents seem different in poem vs. indent-pre .. probably all wikitext
elements that occur in SOL position but are strict about not having any leading
ws.
(07:33:16 PM) cscott-free: how many of those are there?
(07:33:36 PM) subbu: i suppose poem just calls regular parse on embedded
content and then wraps it in wrapper with the right css classes
(07:33:43 PM) subbu: tables are fine with leading space.
(07:34:05 PM) subbu: headings, lists, hr dont work if there is leading WS,
iirc.
(07:34:41 PM) subbu: so, we were wrong .. poem is not indent-pre with classes
then.
(07:35:10 PM) cscott-free: but should it be?  i don't like the idea of adding a
bunch of new special cases to the parser.
(07:35:48 PM) subbu: cscott, it cannot be without breaking poem behavior OR
breaking existing pages that have leading space before :*;#=- chars
(07:35:59 PM) cscott-free: if we can at least parameterize it, such that
indent-pre has SOL markers turned off, and poem has SOL markers turned on,
that would make me happier.
(07:36:14 PM) cscott-free: rather than poem just being gratuitously different
in random ways.
(07:36:24 PM) subbu: ya, you are talking of refactoring code in the parser.
(07:36:30 PM) subbu: and reusing it.
(07:36:56 PM) cscott-free: subbu: i'm certainly talking about reusing more
parser code, rather than implementing poem as a brand new crazy thing.
(07:37:25 PM) cscott-free: i'm tired of having weird corner cases everywhere.
(07:37:50 PM) cscott-free: there should be some principled way we can describe
how indent-pre and poem are similar.
(07:37:57 PM) subbu: maybe spend some time, how poem/lines would fit in
parsoid land and that can inform the discussion of how the core code can be
restructured .. but refactoring/restructure that seems like a lot of work as
well.
(07:38:33 PM) cscott-free: in a nutshell that's why i don't want poem merged
too quickly.  i'd like to understand better how it all fits in.
(07:38:53 PM) cscott-free: and probably to do some dumpGrepping to figure out
how much we can change indent-pre and/or poem without breaking too much
stuff.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #34 from This, that and the other at.li...@live.com.au ---
(In reply to comment #31)
 I'd like to resolve this discrepancy: I really really *really* don't want to
 complicate the parser more with Yet Another Slightly Different Way to handle
 preformatted content.

There's nothing really new here :) We're just sending a pre tag to the
parser, after all. The change to the parser itself is minuscule, and arguably
it is a fix for a long-standing bug that was never exposed until now.

(In reply to comment #33)
 (07:34:41 PM) subbu: so, we were wrong .. poem is not indent-pre with
 classes then.

I'm glad you're aware of this! As I said in Gerrit, the similarities are purely
coincidental.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #27 from Michael M. listenle...@gmail.com ---
(In reply to comment #22)
 (In reply to comment #16)
  verbatim is a misleading name since it still parses wikitext in its
  content.
  It is only verbatim for text-content. 
 
 I do see what you mean here. The problem is, we have so far been unable to
 come
 up with a better name! poem is inappropriate as too specific/narrow.
 

What about lines? The tag just just preserves the lines in its content, and
it seems generic enough for what is used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #28 from This, that and the other at.li...@live.com.au ---
I like lines, the name puts the focus on the individual lines of the
content, which is also what the tag is doing. Nice lateral thinking, Michael :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #29 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com ---
lines sounds good, or preservelines

That said, maybe it would be more user friendly to use a mediawiki.org page to
discuss the tag name, so ideas can be better exposed and have more opinions
(remember one have to explicitly register an account here to post a comment).

About poem itself, I don't know why is a different name really needed. What
are other use cases for this? I've just only used it for poem and lyrics (which
is basically the same).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #30 from C. Scott Ananian canan...@wikimedia.org ---
Regarding my use of indent-pre above -- I'm looking at this mostly from the
perspective of parser maintenance.  As [[testwiki:bug 52061]] demonstrates, the
desired behavior of poem/lines is the same as the existing behavior of
'indent-pre', although the implementation in the original patch was very
different.  I would like to try to avoid adding a bunch of new hair (and crazy
interactions) with the new feature, and instead try to reuse the existing
indent-pre handling code so that all the corner cases were consistent.

In fact, assuming this gets merged, it might be cleaner in the future to
document the indent pre behavior as an implicit lines surrounding the
indented region.  This would reduce confusion because indent pre and pre
are actually quite different in their handling of embedded wikitext, etc.

I like the name lines, btw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

ssas...@wikimedia.org changed:

   What|Removed |Added

 CC||ssas...@wikimedia.org

--- Comment #16 from ssas...@wikimedia.org ---
verbatim is a misleading name since it still parses wikitext in its content.
It is only verbatim for text-content. 

From what I can tell, looking at output, this is indent-pre - indent +
CSS-class. Given that indent-pre provides all the formatting functionality, I
presume the missing ability of adding CSS-classes onto indent-pre is the
primary reason for this new tag? Is there another way of achieving this without
adding a new tag?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #17 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #16)
 From what I can tell, looking at output, this is indent-pre - indent +
 CSS-class. Given that indent-pre provides all the formatting functionality, I
 presume the missing ability of adding CSS-classes onto indent-pre is the
 primary reason for this new tag? Is there another way of achieving this
 without adding a new tag?

I don't know what you mean by indent-pre.

I created a test page at [[testwiki:bug 52061]] to demonstrate the poem tag's
functionality.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #19 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #17)
 I don't know what you mean by indent-pre.

Subbu clarified that this means the preceding space trick. I updated
[[testwiki:bug 52061]].

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:

   What|Removed |Added

 CC||martinezn...@gmail.com

--- Comment #18 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com ---
Please, don't use verbatim!!. It's already been in use by a Wikia extension
[1]



[1] http://community.wikia.com/wiki/Help:Verbatim_tags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

C. Scott Ananian canan...@wikimedia.org changed:

   What|Removed |Added

 CC||canan...@wikimedia.org

--- Comment #20 from C. Scott Ananian canan...@wikimedia.org ---
I further updated [[testwiki:bug 52061]] to show the difference between poem
and pre class=poem.  IMO the poem tag should be rendered as pre
class=poem and it has exactly the behavior of indent-pre (with an extra HTML
class and without the necessity to write the leading indentation).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #21 from ssas...@wikimedia.org ---
I agree reg. output being pre class='poem' .. /pre

However, maybe make it possible for the editor to provide a css-class rather
than hardcode class=poem into the tag?

For standard poem content,
pre-text
... 
/pre-text

And for other uses,
pre-text class=fancy-css
...
/pre-text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #22 from This, that and the other at.li...@live.com.au ---
(In reply to comment #16)
 verbatim is a misleading name since it still parses wikitext in its
 content.
 It is only verbatim for text-content. 

I do see what you mean here. The problem is, we have so far been unable to come
up with a better name! poem is inappropriate as too specific/narrow.

 Is there another way of achieving this
 without adding a new tag?

The poem tag is already in wide use. I don't see the problem with adding a
tag for this functionality.

(In reply to comment #20)
 IMO the poem tag should be rendered as pre
 class=poem and it has exactly the behavior of indent-pre (with an extra
 HTML
 class and without the necessity to write the leading indentation).

A few questions about this statement:

* The gray box/monospaced font of pre/indent-pre would have to be removed for
  poem blocks.
* What are the existing differences between poem and indent-pre?
* pre does not render identically to indent-pre, so could you explain how
  rendering poems using pre class=poem would help?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #23 from ssas...@wikimedia.org ---
(In reply to comment #22)

 (In reply to comment #20)
  IMO the poem tag should be rendered as pre
  class=poem and it has exactly the behavior of indent-pre (with an extra
  HTML
  class and without the necessity to write the leading indentation).
 
 A few questions about this statement:
 
 * The gray box/monospaced font of pre/indent-pre would have to be removed
 for
   poem blocks.
 * What are the existing differences between poem and indent-pre?
 * pre does not render identically to indent-pre, so could you explain how
   rendering poems using pre class=poem would help?

We weren't very clear about what we were discussing there. 

What Scott meant is that the patch should generate pre class=poem .. /pre
for the HTML of the verbatim../verbatim (or pre-text or whatever tag name
is picked) instead of generating div class=poem../div. It is cleaner and
the ouput is semantically closer to the intention of the verbatim tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #24 from This, that and the other at.li...@live.com.au ---
What you are saying makes sense. Presumably the CSS for .poem would have to
neutralise the monospace/gray formatting normally applied to pre tags.

My main question is, if we output a pre tag from the tag hook, will wikitext
inside that tag still get parsed, as it should be?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #25 from ssas...@wikimedia.org ---
That is right reg. CSS.

Since this is going to be merged into core/php-parser, presumably, you control
this behavior and where in the parser pipeline the outer wrapping pre tag is
generated? I haven't looked at the parser changes to answer that or how easy
this is since I haven't really hacked the php parser. Maybe Scott can answer
that more readily. 

At least with Parsoid, that is what we will consider outputting for this new
tag unless VE folks find a div tag simpler than a marked up pre tag (seems
unlikely).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #26 from This, that and the other at.li...@live.com.au ---
(In reply to comment #25)
 Since this is going to be merged into core/php-parser, presumably, you
 control
 this behavior and where in the parser pipeline the outer wrapping pre tag
 is
 generated? I haven't looked at the parser changes to answer that or how easy
 this is since I haven't really hacked the php parser. Maybe Scott can answer
 that more readily. 

I think I've got this part sorted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Michael M. listenle...@gmail.com changed:

   What|Removed |Added

 CC||listenle...@gmail.com

--- Comment #15 from Michael M. listenle...@gmail.com ---
(In reply to comment #10)
 Regarding the tag name, is poem ever actually used for things besides
 poems?

I looked at some examples in de.wikipedia. Apart from poems and poem-like texts
(prayers etc.) there are things like inscriptions and dialogs, which use
poem. And of course, as it is a wiki, some stupid things like quotes even
without any line break in them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #12 from This, that and the other at.li...@live.com.au ---
I'm wondering if people would prefer verbatim as the name of this tag?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #13 from Jackmcbarn jackmcbarn+w...@gmail.com ---
I'd also prefer verbatim as the name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 Whiteboard||migrate Poem extension bugs
   ||to core if/when this merged

--- Comment #14 from MZMcBride b...@mzmcbride.com ---
Sure, let's go with verbatim.

Siebrand also noted on Gerrit change 106861 that if/when this gets merged,
we'll need to migrate the Poem extension bugs to core.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 Whiteboard|migrate Poem extension bugs |migrate Poem extension bugs
   |to core if/when this merged |to core post-resolution

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 had a related patch set uploaded by TTO:
Merge Poem extension into core

https://gerrit.wikimedia.org/r/106861

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #9 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #8)
 I am thinking something like verbatim, asis (as is), nocollapse,
 pretext/pre-text (as in pre but for text, not code), keepbreaks
 [...]

Okay, I'll paint this bikeshed. I like verbatim or pretext. How about one of
those?

 2. The attribute compact seems to actually make the display less compact.
 See the testcase at [[mw:Extension:Poem]]. I think we need a new name/alias 
 for
 this too. However, I have no idea what it is actually meant to be used for...

I'm not sure compact is needed... do people use it? If so, are there examples
of it in the wild?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2014-01-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #10 from Ryan Kaldari rkald...@wikimedia.org ---
The compact feature has always seemed quite buggy (or at least bizarrely
unintuitive) and I wonder if we would really hurt much by killing it
altogether.

Regarding the tag name, is poem ever actually used for things besides poems?
I usually use pre for other cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

This, that and the other at.li...@live.com.au changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||at.li...@live.com.au
   Assignee|wikibugs-l@lists.wikimedia. |at.li...@live.com.au
   |org |

--- Comment #8 from This, that and the other at.li...@live.com.au ---
OK, I'm taking a look at this. The merge looks easy enough, but I need advice.

Poem has two major nomenclature issues:

1. The tag should have another name besides poem. In comment 6 nobreak was
suggested, but Poem does the reverse - it preserves line breaks. I am thinking
something like verbatim, asis (as is), nocollapse, pretext/pre-text
(as in pre but for text, not code), keepbreaks . ?? Any better
ideas?

2. The attribute compact seems to actually make the display less compact. See
the testcase at [[mw:Extension:Poem]]. I think we need a new name/alias for
this too. However, I have no idea what it is actually meant to be used for...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Keywords|easy|
   Priority|Unprioritized   |Normal
Version|unspecified |1.22-git
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Jack Phoenix j...@countervandalism.net changed:

   What|Removed |Added

 CC||j...@countervandalism.net

--- Comment #4 from Jack Phoenix j...@countervandalism.net ---
Poem was merged into core back in 2008, but subsequently reverted; see
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43520.
I must say, however, that I totally agree with the original report and Poem
(along with some obvious stuff like CheckUser, RenameUser, etc.) should be in
core; maybe it should've been there from day one, even.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Chad H. innocentkil...@gmail.com changed:

   What|Removed |Added

 CC|innocentkil...@gmail.com|

--- Comment #5 from Chad H. innocentkil...@gmail.com ---
If you merge it to core, please call it something other than poem. Other than
that I couldn't care less :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #6 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #5)
 If you merge it to core, please call it something other than poem. Other
 than that I couldn't care less :D

I think we must keep the name poem for backward-compatibility, but it
should definitely have a saner alias (nobreak or something).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #7 from Alex Monk kren...@gmail.com ---
(In reply to comment #6)
 (In reply to comment #5)
  If you merge it to core, please call it something other than poem. Other
  than that I couldn't care less :D
 
 I think we must keep the name poem for backward-compatibility, but it
 should definitely have a saner alias (nobreak or something).

The main name of the feature should be something else, poem can be an alias
for backwards-compatibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

   Keywords||easy
 CC||rkald...@wikimedia.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 Blocks||26751

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

Ryan Kaldari rkald...@wikimedia.org changed:

   What|Removed |Added

 Blocks||26751

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #2 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #1)
 Anytime an extension is created or deprecated it's a logistical pain in the
 ass.

Can you elaborate on this? It seems pretty easy to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52061] Merge Poem extension into MediaWiki core

2013-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #3 from Ryan Kaldari rkald...@wikimedia.org ---
Steps to deprecate an extension (apart from actual code changes):

* Turn off extension for testwiki in InitialiseSettings.php and make sure
nothing breaks (1 deployment cycle)
* Turn off extension for all wikis in InitialiseSettings.php and make sure
nothing breaks (1 deployment cycle)
* Remove extension from CommonSettings.php, wmf-config/extension-list, and
make-wmf-branch/default.conf (1 deployment cycle)
* Move/deprecate MediaWiki documentation
* Get component removed from Bugzilla, migrate any existing bugs
* Have project removed from Gerrit (not immediately of course)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l