Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi, I have pushed a minor correction to the metal-prototype-branch of jdk-sandbox (http://hg.openjdk.java.net/jdk/sandbox ) Now, we can build and launch J2DDemo, J2DBenchmark and SwingSet2 with Metal pipeline. Of course, rendering

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

I don't know, since I am assuming you are using the same credentials that you have been using to successfully push to jdk/client. We should contact ops to see if there is a problem on that end. I'd like to make sure you can push here, else I'd offer to try it myself for you. -phil. On 7/3/19

[OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hello, Here is a small update for metal-prototype-branch of hg.openjdk.java.net/jdk/sandbox  . The fix adds support of Xcode 10 for build environment. Please, have a look. http://cr.openjdk.java.net/~avu/JDK-8220154/webrev.02/

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Ajit, > Thanks for suggesting how to run basic perf test. > I did run it with and without Metal. The test run with Metal takes ~2X > time to run as compared with OpenGL. > What is your observation? Yes, in some cases we have similar performance drop at the moment

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey, FYI. We are also trying to merge the latest webrev shared into Open sandbox we have under https://bugs.openjdk.java.net/browse/JDK-8225160 . It is in initial phase of merge, we will be updating the JBS bug with more details as we

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey, Thanks for suggesting how to run basic perf test. I did run it with and without Metal. The test run with Metal takes ~2X time to run as compared with OpenGL. What is your observation? Although, the java side code changes are good, I see an issue with native Metal

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey,Thanks for the clarifications.Build failures we are getting are mainly because of tighter compiler restrictions, I have attached error log for the same.Basically we have 2 log errors and one conditional error.Yes in the latest build there is refactoring of LWComponentPeer.java but I have

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Jay, >> I can see that now you have added the MTLTexturePool.m file. It only >> partially solves the build failures. >> Jay & myself tried building it separately and we do still see the build >> failures. It’s strange. There wasn’t any copy/paste errors. The only reason that I can imagine

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey, We are trying to test basic calls of Graphics2D as mentioned in https://docs.oracle.com/javase/tutorial/2d/TOC.html I see that Graphics2D.drawImage() with BufferedImage as input works. Also I tried other operations like

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Thanks Alexey. I can see that now you have added the MTLTexturePool.m file. It only partially solves the build failures. Jay & myself tried building it separately and we do still see the build failures. Some statements need bracketing & some copy-paste errors need correction. We could fix

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

FYI, I’ve rebased our work on top of the latest state of http://hg.openjdk.java.net/jdk/jdk (http://cr.openjdk.java.net/~avu/JDK-8220154/webrev.01 ) Best Regards, Alexey > On 8 May 2019, at 16:19,

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Thanks for catching it, Ajit! Looks like it was a problem with webrev script applied to multiple git commits. I’ve updated the webrev. Also, we didn’t rebase yet on the latest state of http://hg.openjdk.java.net/jdk/jdk (this work is in progress). I’ll let

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey, I tried building this patch with latest http://hg.openjdk.java.net/jdk/jdk/ 1. Some basic copy paste errors are resulting in build failures 2. MTLTexturePool.m file is missing from the patch Can you please check & update? Regards, Ajit > On 30-Apr-2019, at 2:52 PM,

[OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hello, Here is an update on our effort to use Metal framework for java2d rendering. We’ve added image rendering support and some support for LinearGradient. Also, the code has been refactored. Please have a look: http://cr.openjdk.java.net/~avu/JDK-8220154/webrev.01