Re: [chromium-dev] Generate extensions _locale directories from grd files?

2010-01-12 Thread Aaron Boodman
Nobody has considered it before. An easier workaround would be to just expose a custom API to yourself that sends the dictionary into your extension. - a On Tue, Jan 12, 2010 at 1:43 PM, Erik Arvidsson a...@chromium.org wrote: I'm currently working on the new bookmark manager which is being

Re: [chromium-dev] Generate extensions _locale directories from grd files?

2010-01-12 Thread Aaron Boodman
No. On Tue, Jan 12, 2010 at 2:40 PM, Darin Fisher da...@chromium.org wrote: A side question:  Does the bookmark manager as extension imply an extension process even when the bookmarks window is not visible?  (It would be nice to avoid that process otherwise.) -Darin On Tue, Jan 12, 2010 at

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07 Thread Aaron Boodman
On Thu, Jan 7, 2010 at 1:28 PM, Peter Kasting pkast...@google.com wrote: If you have ever used any of the EmptyXXX() functions, or ever will, please read on. These functions (in string_util.h and gurl.h) are meant for a single, specific use case: const std::string MyClass::foo() const {   

Re: [chromium-dev] Running multiple Google Chrome channels side-by-side (for testing)

2009-12-18 Thread Aaron Boodman
On Fri, Dec 18, 2009 at 12:07 PM, Mark Mentovai m...@chromium.org wrote: Finnur Thorarinsson wrote: You can use the channel changer, as PhistucK points out, to switch and then use the About box to update, but you can only move forward in time (stable - beta - dev). I'm pretty sure the

[chromium-dev] [extensions] Merge docs changes to beta

2009-12-16 Thread Aaron Boodman
I've just merged all the docs and samples changes since we branched (except those related to unmerged features) to 249, so that Nick can flip the switch and make code.google.com reflect beta. Please remember if you're making changes after this point to docs or samples (or reviewing changes) to

Re: [chromium-dev] [extensions] bug gardening, stable version

2009-12-16 Thread Aaron Boodman
On Wed, Dec 16, 2009 at 3:40 AM, Evan Martin e...@chromium.org wrote: On Mon, Dec 14, 2009 at 6:13 PM, Aaron Boodman a...@chromium.org wrote: I've gone through and gardened the bugs per our goals for stable: Win, linux: http://bit.ly/5s4lrp Mac: http://bit.ly/8hHpdO Surely I'm missing some

[chromium-dev] [extensions] Please leave bugs open until they've been merged to beta (where necessary)

2009-12-16 Thread Aaron Boodman
That's all, thanks. - a -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] [extensions] Please leave bugs open until they've been merged to beta (where necessary)

2009-12-16 Thread Aaron Boodman
On Wed, Dec 16, 2009 at 1:07 PM, Evan Stade est...@chromium.org wrote: a) what labels will a bug that's been deemed merge-worthy have? I dunno if there is an existing convention for this, but I was thinking we just leave the bug open. Basically everything on mstone-4 releaseblock-stable needs to

[chromium-dev] Re: Exposing Chrome Extensions APIs to DOM UI.

2009-12-14 Thread Aaron Boodman
Seems like a bad idea. Extensions and DOMUI are basically two competing systems for doing the same thing, it would get confusing combining them. I would rather either: a) add new (possibly experimental) APIs for the issues you've run into. b) manually plumb the extension APIs you need through

[chromium-dev] Re: Exposing Chrome Extensions APIs to DOM UI.

2009-12-14 Thread Aaron Boodman
On Mon, Dec 14, 2009 at 5:29 PM, Erik Arvidsson a...@chromium.org wrote: On Mon, Dec 14, 2009 at 16:48, Aaron Boodman a...@chromium.org wrote: Seems like a bad idea. Extensions and DOMUI are basically two competing systems for doing the same thing, it would get confusing combining them. I

[chromium-dev] [extensions] bug gardening, stable version

2009-12-14 Thread Aaron Boodman
I've gone through and gardened the bugs per our goals for stable: Win, linux: http://bit.ly/5s4lrp Mac: http://bit.ly/8hHpdO Surely I'm missing some, but this should be a start. - a -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

Re: [chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-12-12 Thread Aaron Boodman
again. I've been able to show notifications from our extension, with a friendly name in the from label. What I'm not able to do is communicate with the background page. Is this implemented or not yet? Thanks On Tue, Nov 10, 2009 at 11:51 PM, Aaron Boodman a...@chromium.org wrote: On Tue

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Aaron Boodman
On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman a...@chromium.org wrote: Andy sent me a CL for review about an extension crashing (http://crbug.com/29584). Turns out the cause was a failure to load a Windows .dll on the Mac. We have had threads on this before. The consensus was that it was

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Aaron Boodman
On Thu, Dec 10, 2009 at 4:27 PM, Avi Drissman a...@google.com wrote: Can we have the syntax say platform x loads x.dll, platform y loads y.so, etc? Yes that is the idea. If a dll required by a platform fails to load, we need to alert the user that their extension is busted. The prospect of

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Aaron Boodman
It is good that we can avoid the crash. We do need to get some kind of syntax in the manifest. - a On Thu, Dec 10, 2009 at 4:18 PM, Avi Drissman a...@google.com wrote: The crash is fixed. But the fact that we're now expecting random dll loads to fail prevents us from giving good UI to users,

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Aaron Boodman
Yes, extensions that include NPAPI are a very small minority. Last time I checked there were something like 5. It is a way out for people who already have binary code that they would like to reuse, or who need to talk to the platform. I don't see what the big deal is about a few extensions only

[chromium-dev] Extensions gallery open for uploads

2009-11-23 Thread Aaron Boodman
-to-finish.html Looking forward to seeing what you've built! -- Aaron Boodman, on behalf of the Google Chrome Extensions team -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] Some people still making new toolstrip-based extensions

2009-11-19 Thread Aaron Boodman
We're going to have to explain again when we actually remove toolstrips, because some people won't have seen the first announcement (understandably): http://www.guyvider.com/2009/11/i-love-chrome-extensions.html - a -- Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] [extensions] s/Area-/Feature-/g

2009-11-16 Thread Aaron Boodman
Since we no longer have the cc list on Area-Extensions, I've relented and added the Feature-Extensions label to all our existing bugs. Please update your bookmarks and try to remember to use Feature-Extensions now, not Area-Extensions. - a -- Chromium Developers mailing list:

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

2009-11-13 Thread Aaron Boodman
My name is Aaron Boodman and I support the motion to give extensions extra space. On Fri, Nov 13, 2009 at 12:01 PM, Antony Sargent asarg...@google.com wrote: [+chromium-dev and dumi] I'm not sure what our overall plan is with respect to quotas for html5 databases, and whether we've discussed

Re: [chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-12 Thread Aaron Boodman
Aaaarrrgh On Thu, Nov 12, 2009 at 12:48 PM, Aaron Boodman a...@google.com wrote: On Thu, Nov 12, 2009 at 12:13 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 12, 2009 at 11:45 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: On Thu, Nov 12, 2009 at 20:26, John Abd-El-Malek j

Re: [chromium-dev] [linux] page action extensions crashy on 4.0.237.0

2009-11-10 Thread Aaron Boodman
You can disable the extensions easily by going to wrench extensions, and clicking the Disable link next to each item. - a On Mon, Nov 9, 2009 at 6:20 PM, Tony Chang t...@chromium.org wrote: If you don't run Chrome on Linux or you don't have any extensions installed, you can ignore this

Re: [chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-10 Thread Aaron Boodman
I did some quick spelunking with this feature this evening. It doesn't look like the integration with extensions is quite working yet. For one, when showing an HTML notification for a chrome-extension:// URL, it looks like the notification window ends up in a different process. This prevents

[chromium-dev] A plan for i18n

2009-11-10 Thread Aaron Boodman
We need to have basic i18n for extensions for the stable release, but our constraints are: a) Time is tight b) We should not slow down Chrome startup (eg by loading message catalogs early in startup) c) We should not do something that is incompatible with our eventual i18n vision Here is a

Re: [chromium-dev] A plan for i18n

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 12:21 PM, Thomas Van Lenten thoma...@google.com wrote: Off list since I haven't really looked at extensions, so some of this might be obvious... Not a dumb question at all, so replying on-list :) On Tue, Nov 10, 2009 at 3:17 PM, Aaron Boodman a...@chromium.org wrote

[chromium-dev] Re: [chromium-extensions] A plan for i18n

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 2:31 PM, Erik Kay erik...@google.com wrote: To be clear what's (intentionally) omitted from this proposal: - localized resource fetching (transparently turning /foo/bar.gif into /_locales/jp/foo/bar.gif) - auto string substitution (l18n templating) I think what you've

[chromium-dev] Re: [chromium-extensions] A plan for i18n

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 3:21 PM, Nebojša Ćirić c...@google.com wrote: One minor thing you left out was getURL providing a way to generate a localized URL (ideally without stats).  If we don't provide devs a way to construct URLs manually, then they won't have a good migration path for

[chromium-dev] Re: [chromium-extensions] A plan for i18n

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 3:24 PM, Nebojša Ćirić c...@google.com wrote: Implementation notes: In order to avoid slowing down Chrome startup, I think we need to store the manifest in the preferences already localized. So basically, somewhere during extension installation, we need to localize the

[chromium-dev] Re: [chromium-extensions] A plan for i18n

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 3:31 PM, Aaron Boodman a...@chromium.org wrote: On Tue, Nov 10, 2009 at 3:24 PM, Nebojša Ćirić c...@google.com wrote: Implementation notes: In order to avoid slowing down Chrome startup, I think we need to store the manifest in the preferences already localized. So

Re: [chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-10 Thread Aaron Boodman
On Tue, Nov 10, 2009 at 8:19 PM, Marcos Aruj marcos.a...@gmail.com wrote: Hey Aaron, thanks for your answer. Does this mean that extension and communication will be able to communicate between them without using Shared workers? Yes, also, all the extension APIs, like chrome.tabs,

[chromium-dev] Re: How to log exceptions/console messages from shared worker context?

2009-11-08 Thread Aaron Boodman
It would be cool if the devtools window had some kind of UI where you could see all running top-level contexts. Like tabs that had: + extensions - foo extension - background page - worker - tab 1 - tab 2 - content script a + bar extensions + worker 1 + worker 2 + tab 1 +

[chromium-dev] Re: Next dev release

2009-11-05 Thread Aaron Boodman
On Thu, Nov 5, 2009 at 10:18 AM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, Just wanted to know when will the next dev release be? Hi Marcos, We usually try to do dev channel releases once a week, but it varies depending on the state of the tree. Releases (even dev channel ones) take

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread Aaron Boodman
Creating a bug with a small sample attached would be great. On Thu, Nov 5, 2009 at 3:11 PM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, We've been testing the Notifications API and have shown them successfully on a regular page. We are trying to use it from within an extension, but

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-04 Thread Aaron Boodman
On Wed, Nov 4, 2009 at 12:12 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: On Wed, Nov 4, 2009 at 08:56, Aaron Boodman a...@chromium.org wrote: Why don't you pass an Extension instance? It's in a test. Mocking an Extension is not trivial as well. :( Or maybe... I didn't read all

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-04 Thread Aaron Boodman
On Wed, Nov 4, 2009 at 8:17 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Oh, indeed. Thanks, after looking at other tests it was easy. It was a bit annoying that I had to use #ifdefs for FilePath though. You may be able to just specify an empty FilePath() ? I'm not sure. Give it a try.

[chromium-dev] Re: Extensions performance data

2009-11-04 Thread Aaron Boodman
On Tue, Oct 27, 2009 at 8:26 AM, Antony Sargent asarg...@google.com wrote: Page Cycler Tests Since the page cycler tests take a long time to run, we've only added one extensions case to 2 of the individual data sets: Moz (relatively simple pages, less javascript) and MoreJS (more complicated

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Aaron Boodman
On Tue, Nov 3, 2009 at 9:18 AM, Evan Martin e...@chromium.org wrote: Generally it should Just Work.  If it doesn't, I'd like to hear about it. http://code.google.com/p/chromium/wiki/UsingGit#Renames_and_Copies FWIW, it never used to work at all for me, but it recently started working. Did

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Aaron Boodman
IMO, I wouldn't mind draconian reverts in the interest of keeping the tree open and allowing the sheriffs some semblance of productivity. OTOH, git makes it really easy for me to un-revert and try again, so maybe I'm biased there. - a On Tue, Nov 3, 2009 at 3:03 PM, Eric Seidel

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-03 Thread Aaron Boodman
Why don't you pass an Extension instance? It seems like you are violating the contract of that notification by not doing so, and even if you solve this problem, other similar problems would be likely to happen again in the future. - a On Tue, Nov 3, 2009 at 11:49 PM, Paweł Hajdan Jr.

[chromium-dev] Re: readability extension (experience writeup)

2009-10-31 Thread Aaron Boodman
On Sat, Oct 31, 2009 at 4:29 PM, Evan Martin e...@chromium.org wrote: I've updated this to the browser actions API. Thanks for trying again.  - The docs are behind the code (had to read the code once or twice to figure out what was going wrong). Were you using trunk or dev? The docs on

[chromium-dev] Re: A tale of two (or more) syncing extensions, and a proposal

2009-10-28 Thread Aaron Boodman
On Tue, Oct 27, 2009 at 8:55 PM, Tim Steele t...@chromium.org wrote: I can take a stab at more formal heuristics for bookmarks, at least.  We will have a better idea of actual limiting parameters for bookmarks (as in how many operations in a certain time frame is reasonable) once the

[chromium-dev] Re: A tale of two (or more) syncing extensions, and a proposal

2009-10-28 Thread Aaron Boodman
On Wed, Oct 28, 2009 at 10:42 AM, Nick Carter n...@chromium.org wrote: On Wed, Oct 28, 2009 at 8:46 AM, Scott Violet s...@chromium.org wrote: I'm confused by the diagram. In step 5, why does F' get added to the model. Are you saying the 'extension cloud' service always creates a new

[chromium-dev] Re: A tale of two (or more) syncing extensions, and a proposal

2009-10-28 Thread Aaron Boodman
On Wed, Oct 28, 2009 at 11:39 AM, Tim Steele t...@chromium.org wrote: The update{foo} update{blech} case is most likely a different kind of failure, though, and I was thinking we could limit that with a generic cap on just the number of updates in a period of time. From the data we have seen

[chromium-dev] Re: Extensions performance data

2009-10-27 Thread Aaron Boodman
Thanks for doing this. It seems like we should shoot for getting the cost of browser/page actions down to zero, and the cost of content scripts to zero above similar script running in page. I will create bugs for these two (plus another bug just to create startup tests for browser actions). -

[chromium-dev] Re: Code Yellow: Dev Channel Release On-Hold This Week

2009-10-27 Thread Aaron Boodman
On Tue, Oct 27, 2009 at 4:04 PM, Anthony LaForge lafo...@google.com wrote: Moving forward, the TPMs are going to be more closely monitoring the P0 and ReleaseBlock-Dev (which we will treat effectively synonymously).  Please help us to ensure labels on bugs are accurate. This part in

[chromium-dev] Re: A tale of two (or more) syncing extensions, and a proposal

2009-10-21 Thread Aaron Boodman
Have not read all of it yet, but am in favor in general of having some sort of quota for extension api calls to protect from meltdown. We have a very convenient chokepoint to implement this in our system, so it would just be a matter of a more detailed design of the heuristics to use for each

[chromium-dev] Re: Reminder: File bugs for behavior changes on different platforms!

2009-10-20 Thread Aaron Boodman
. Kind Regards, Anthony Laforge Technical Program Manager Mountain View, CA On Tue, Oct 20, 2009 at 11:30 AM, Nico Weber tha...@chromium.org wrote: In the blockee, enter the blockers in the Blocked by line at the bottom. On Tue, Oct 20, 2009 at 11:21 AM, Aaron Boodman a...@chromium.org wrote

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-20 Thread Aaron Boodman
On Tue, Oct 20, 2009 at 6:35 PM, Alex Russell slightly...@google.com wrote: The first was to perhaps use AppCache manifests to declare this sort of metadata. You might have some sort of header in the manifest that describes the page as persistently bless-able (much like Ben's description),

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-19 Thread Aaron Boodman
Hello, sorry for not replying sooner. The reason I think nobody responded is that this proposal is not technically part of the extensions system, but would be available to all web pages (including extensions). I think that the wider mailing list chromium-dev may contain people who know what the

[chromium-dev] [extensions] Bug gardening

2009-10-19 Thread Aaron Boodman
As promised in meatspace: http://code.google.com/p/chromium/issues/list?q=Area:extensions+releaseblock:betasort=pri We're now getting to the point where we're running out of major feature work (hooray!), so what should be P1/P2/P3 is squishier. Please feel free to push back and make changes

[chromium-dev] Re: [chromium-extensions] HTML5 spellcheck attribute

2009-10-15 Thread Aaron Boodman
This is not really an extensions question. I think you want chromium-...@. - a On Thu, Oct 15, 2009 at 9:10 AM, Mixe twitter...@googlemail.com wrote: Chrome does not support HTML5 spellcheck attribute? Then why spellchecking is enabled by default? How we can disable (using JS) spellchecking

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

2009-10-13 Thread Aaron Boodman
On Tue, Oct 13, 2009 at 10:31 AM, Dimitri Glazkov dglaz...@chromium.org wrote: * [ your idea goes here ] I'm probably going to get things thrown at me, but ... I don't think the idea of a webkit sheriff really works. By definition the webkit sheriff is pulling in code that they don't know how

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

2009-10-13 Thread Aaron Boodman
On Tue, Oct 13, 2009 at 1:36 PM, Aaron Boodman a...@chromium.org wrote: I'm probably going to get things thrown at me, but ... Balls, I just checked with Dimitri and we already do my proposal. Ignore. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list

[chromium-dev] Friendly reminder: don't let changes rot

2009-10-08 Thread Aaron Boodman
Lots of the engineers on Chromium aim to turn around code reviews in hours. Some (like me) have even committed to making it more important than their own work. It makes me sad when I find code reviews that have been waiting for lgtm from me for weeks. If someone doesn't reply to your review or

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Aaron Boodman
On Thu, Oct 8, 2009 at 10:45 AM, Scott Violet s...@chromium.org wrote: Perhaps I'm too old school here, but I'll ask anyway. Why use IRC for what is meant as a ping to one person? If you want to let the reviewer know immediately, isn't an IM a better approach. That way you keep the noise on

[chromium-dev] Re: UI across multiple platforms

2009-10-07 Thread Aaron Boodman
FWIW, on extensions, what we have been finding works is to file separate bugs for each platform's UI implementation. It is just too much code to track with one bug. You end up with these mega bugs that never close. We label each bug OS-whatever the case may be - a On Wed, Oct 7, 2009 at 10:01

[chromium-dev] [extensions] first cut at beta bug list

2009-10-05 Thread Aaron Boodman
As promised in today's extensions meeting, I've taken a first pass to identify extensions beta bugs. As a sort of new novelty, I've also attempted to use the Priority and Size labels, so that we can know what we should do first, and how much it's going to hurt. Please see:

[chromium-dev] Re: UTF8 and Skia

2009-10-04 Thread Aaron Boodman
On Sat, Oct 3, 2009 at 11:25 PM, Adam Langley a...@chromium.org wrote: On Sat, Oct 3, 2009 at 6:29 PM, Aaron Boodman a...@chromium.org wrote: I double-checked that the font I'm using actually contains these characters (by rendering them using HTML). When rendering via HTML a browser will use

[chromium-dev] UTF8 and Skia

2009-10-03 Thread Aaron Boodman
I'm trying to use SkCanvas::drawText() with mulitbyte UTF-8 characters, but they always come out rendered as a square box placeholder glyph. I've walked into the code and I can see that Skia is indeed parsing the UTF-8 correctly, and it comes up with the correct code point. And in SkGlyphCache,

[chromium-dev] Re: When disabling a test, please assign to whoever wrote it

2009-09-22 Thread Aaron Boodman
Seriously. In a project as big as Chrome, tests are *critical* and a disabled test can hurt a team within just a few days. This has happened to me a few times and it is terrifying to find out a test that you think was proving you are working had actually been disabled. Disabling bad tests is

[chromium-dev] Re: Shipping features behind a run-time flag can sometimes still be dangerous

2009-09-21 Thread Aaron Boodman
It is really useful to have early code compiling and running as much as possible on all platforms right from the beginning. This catches a lot of issues early in the development cycle and prevents scary monolithic integration phases. Could we also fix this problem by doing something in the

[chromium-dev] Re: JSNES: A NES emulator that runs well in Chrome

2009-09-17 Thread Aaron Boodman
I was stoked to play SMB III, but without music it isn't the same :-/. - a On Thu, Sep 17, 2009 at 10:14 AM, Peter Kasting pkast...@google.com wrote: http://benfirshman.com/projects/jsnes/ I highly recommend you use Google Chrome to play JSNES. ... it just about runs on Firefox 3.5 or Safari

[chromium-dev] Re: JSNES: A NES emulator that runs well in Chrome

2009-09-17 Thread Aaron Boodman
On Thu, Sep 17, 2009 at 11:59 AM, Evan Martin e...@chromium.org wrote: - new insano Windows machine: 60fps, feels just right I am happy that I could contribute insano (though I believe the correct spelling is insane-o) to the Chromium lexicon. - a

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-04 Thread Aaron Boodman
On Fri, Sep 4, 2009 at 10:23 AM, Evan Martine...@chromium.org wrote: We actually already content sniff plugin files on Linux, so that we don't print a loading error when attempting to load a wrong bit-ness plugin.  (Printing a loading error breaks layout tests.)  Thankfully, ELF has this

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-03 Thread Aaron Boodman
On Thu, Sep 3, 2009 at 9:08 PM, Adam Barthaba...@chromium.org wrote: On Thu, Sep 3, 2009 at 7:51 PM, Matt Perrympcompl...@chromium.org wrote: public: false, Does that mean the default is now true?  It's probably a good idea to make the default value false here. The default is currently

[chromium-dev] Re: PSA std::cout / std:cerr in tests

2009-09-01 Thread Aaron Boodman
Actually, I found two: thumbnail_store_unittest.cc:134: std::cout Max diff btwn original and encoded image (b,g,r,a) = (v8_unit_test.cc:91: std::cout message \n; - a On Tue, Sep 1, 2009 at 10:49 AM, Aaron Boodman a...@chromium.org wrote: Yeah, no problem. Do you have the test in question

[chromium-dev] Re: PSA std::cout / std:cerr in tests

2009-09-01 Thread Aaron Boodman
:44 AM, Aaron Boodman a...@google.com wrote: On Tue, Sep 1, 2009 at 10:43 AM, Aaron Boodman a...@google.com wrote: Sorry. I tried LOG(INFO) and LOG(WARNING) and neither worked. I then jumped to just using std::cout. - a On Tue, Sep 1, 2009 at 10:40 AM, Marc-Antoine Ruel mar

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Aaron Boodman
On Thu, Aug 27, 2009 at 12:06 AM, Ben Goodger (Google)b...@chromium.org wrote: I actually don't like having a mix of HTML/native UIs in the product. When we switched to the NTP from the old Destinations page we made the decision to have the content of tabs feel webby and the content of

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-26 Thread Aaron Boodman
Argh. Forgot attachment. On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote: I'm playing with different ideas for the extension install dialog, and would like to do something like the attacked mock. I can see that there is no support for this in Label presently and I'm

[chromium-dev] Formatting substrings in a views::Label

2009-08-26 Thread Aaron Boodman
I'm playing with different ideas for the extension install dialog, and would like to do something like the attacked mock. I can see that there is no support for this in Label presently and I'm told by Dean that the APIs for doing this are different across platforms. Is it worth adding an

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-26 Thread Aaron Boodman
wrote: Yes, I think we can add something so each channel has a persistent URL. I'll discuss with Aaron offline. On Sat, Aug 8, 2009 at 00:17, Darin Fisher da...@chromium.org wrote: On Fri, Aug 7, 2009 at 11:59 PM, Aaron Boodman a...@chromium.org wrote: Ok, sorry I got defensive. Short answer

[chromium-dev] How to keep aware of bug changes for a particular label

2009-08-17 Thread Aaron Boodman
I would like to be cc'd on every bug that has the label: Area-Extensions. Is this possible to automate? How do other subteams keep aware of bugs changes? - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives,

[chromium-dev] Re: How to keep aware of bug changes for a particular label

2009-08-17 Thread Aaron Boodman
. For example, I'm on CC for every FlakyTest bug, and Darin helped me do that. On Mon, Aug 17, 2009 at 11:25, Aaron Boodman a...@chromium.org wrote: I would like to be cc'd on every bug that has the label: Area-Extensions. Is this possible to automate? How do other subteams keep aware of bugs changes

[chromium-dev] Re: How to keep aware of bug changes for a particular label

2009-08-17 Thread Aaron Boodman
Whee! Thanks. On Mon, Aug 17, 2009 at 11:38 AM, Darin Fisherda...@chromium.org wrote: Done On Mon, Aug 17, 2009 at 11:36 AM, Aaron Boodman a...@chromium.org wrote: Darin, can you make this list of people automatically cc'd for Area-Extensions? aa asargent nickbaum erikkay mpcomplete

[chromium-dev] Re: Can't edit others' codereviews?

2009-08-16 Thread Aaron Boodman
On Sun, Aug 16, 2009 at 2:47 PM, Peter Kastingpkast...@google.com wrote: I really need the ability to edit others' issues, including closing them.  I don't really care up or down on the close button issue, but please restore my ability to edit and close others' changes. Yeah, I liked the

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-11 Thread Aaron Boodman
7, 2009 at 11:59 PM, Aaron Boodman a...@chromium.org wrote: Ok, sorry I got defensive. Short answer is we don't know if it can handle the load. I will add a bug to myself to investigate. Oh, I didn't think you were overly defensive... Do you have any opinion on adding the tags? I guess

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 8:50 AM, Avi Drissmana...@google.com wrote: Right now there's no real control over themes. Once they're installed, they're permanently installed; there's no easy way to remove them We should completely drop the concept of theme installation. We can do this by changing

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 9:24 AM, Steve Vandebogartvand...@google.com wrote: Undoubtedly, there will be hundreds of themes, finding the same one you were using last week before you decided to try a different one will be a daunting task.  From a usability perspective, it seems to me that

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 10:05 AM, Peter Kastingpkast...@google.com wrote: [Edit: right as I was going to send this, I see you seem to be thinking along similar lines.] You're right that a dropdown with the names of every theme the user has ever used is both unwieldy and unhelpful.  How about

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 11:09 AM, Avi Drissmana...@google.com wrote: On Mon, Aug 10, 2009 at 1:31 PM, Aaron Boodman a...@chromium.org wrote: Incidentally, two other asks: * When installing a theme, give the user a way to switch back to the previous theme (e.g. an infobar).  We currently

[chromium-dev] Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-09 Thread Aaron Boodman
Currently the mac port has a dropdown in the preferences that allows you to switch between themes that happen to be installed. None of the other ports have this, and I think it should be removed from mac. All it allows you to do is switch between themes you have previously installed. How is that

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-08 Thread Aaron Boodman
the additional load this will generate? -Darin On Fri, Aug 7, 2009 at 3:23 PM, Aaron Boodman a...@chromium.org wrote: Hi all, I was wondering if the release managers could add a tag in Subversion for each of the stable, beta, and dev release channels. I want a ViewVC URL that I can give

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-08 Thread Aaron Boodman
, 2009 at 11:45 PM, Darin Fisherda...@chromium.org wrote: I totally agree.  Reducing the cost of maintaining docs is very nice indeed ;-) -Darin On Fri, Aug 7, 2009 at 11:36 PM, Aaron Boodman a...@chromium.org wrote: We can put a cache in front of it if needed. Actually I'd like to put

[chromium-dev] Subversion tags for stable/beta/dev?

2009-08-07 Thread Aaron Boodman
Hi all, I was wondering if the release managers could add a tag in Subversion for each of the stable, beta, and dev release channels. I want a ViewVC URL that I can give people that will always refer to the version of the code that is on stable (or whatever) at that moment. The reason I want to

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Aaron Boodman
You can find the location of your profile directory on this page: http://dev.chromium.org/user-experience/user-data-directory - a On Thu, Aug 6, 2009 at 2:16 PM, Evan Stadeest...@chromium.org wrote: oh sorry. Not using linux. rm -rf means to delete. So go find your profile directory and

[chromium-dev] Re: [chromium-extensions] Re: Extension API Proposal: Performance Tracing

2009-08-06 Thread Aaron Boodman
[moving to chromium-dev, as it seems better for this discussion] Kelly, Sorry for not replying earlier. I'm a little bit underwater right now, as we're trying to get everything with extensions tied up so we can turn it on by default on dev. I'd like to take a step back and ponder why even do

[chromium-dev] Re: Call for highlights to the 196.0 release notes

2009-07-30 Thread Aaron Boodman
Extension changes: * Introduce moles! These are a new extra area that can pop up above toolstrips. 21621 * Theme install experience is now complete: 21626 * Themes now work with --load-extension (good for development): 21619 * You can now reload extensions from a button on chrome://extensions.

[chromium-dev] Re: Quota UI for LocalStorage (and others in the future)

2009-07-29 Thread Aaron Boodman
On Wed, Jul 29, 2009 at 11:28 AM, Drew Wilsonatwil...@chromium.org wrote: I've been starting to lean in this direction as well. The problem is that extensions are currently not cross-platform and would require separate implementations for each platform. Just to clarify, you really mean

[chromium-dev] Re: [extensions] Shankland: Thanks for giving my back pixels, browser makers

2009-07-28 Thread Aaron Boodman
Yes, but for v1 we will just have one home for them. We are trying to decide between the bookmark bar and the bottom bar now. They both have their plusses and minuses: - The bookmark bar is better for people who already use the bookmark bar, particularly if it isn't already full. - The bottom

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-28 Thread Aaron Boodman
+chromium-dev I think this is great. I suggest creating a wiki page with a design for this so that we can refer to it whenever we implement, and a bug that refers to the wiki page. Up until now, we've been putting our designs here: http://dev.chromium.org/developers/design-documents/extensions

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-28 Thread Aaron Boodman
On Tue, Jul 28, 2009 at 11:30 AM, Drew Wilsonatwil...@chromium.org wrote: SGTM. Note that we're essentially duplicating (assumedly intentionally so) the window.postMessage() APIs which require specifying a target domain and whose connect event has a source and origin attribute specifying the

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-28 Thread Aaron Boodman
On Tue, Jul 28, 2009 at 12:09 PM, James Robinsonjam...@google.com wrote: Thanks for the feedback.  I've created http://code.google.com/p/chromium/wiki/InterExtensionCommunication with the proposal and would appreciate if someone with an @chromium account could link to it Done. I also created

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-28 Thread Aaron Boodman
On Tue, Jul 28, 2009 at 12:20 PM, Aaron Boodmana...@chromium.org wrote: We'll always know what extension the onConnectExternal event will be fired at when the connectExternal() call is made, so at the very least we could promise that no onConnectExternal event will be fired at an extension

[chromium-dev] Re: Chromium Embedded build bot on FYI waterfall

2009-07-24 Thread Aaron Boodman
As a bystander, I just want to note how cool it is that we set this up for Marshall. Sometimes the infrastructure we wield on this project completely blows my mind. - a On Fri, Jul 24, 2009 at 1:11 PM, Marshall Greenblattmagreenbl...@gmail.com wrote: Hi All, A new build bot has been added to

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Aaron Boodman
The point about reverts is confusing RELEASE_NOTE is a good one, but I don't think it outweighs the pain of maintaining ChangeLog. On Wed, Jul 22, 2009 at 8:41 AM, Erik Kayerik...@chromium.org wrote: You can still have a single file/URL with this info for convenience.  Just auto-generate it

[chromium-dev] Re: No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Aaron Boodman
Nicolas, Are you going to be turning back on the extension support at any point? If not, just let us know so that we can remove the feature from the sample. Right now it looks broken. - a On Tue, Jul 21, 2009 at 8:27 AM, Nicolas Sylvainnsylv...@chromium.org wrote: Hi, Last week a lot of

[chromium-dev] Proposal for new changelist annotation: RELEASE_NOTE=....

2009-07-17 Thread Aaron Boodman
I propose we add a new tag to changelist descriptions: RELEASE_NOTE=description of something interesting that users would like to know happened in this build It would be up to the developer to decide whether something was worth going in the release notes. In the extension world, the reason I

[chromium-dev] Re: Proposal for new changelist annotation: RELEASE_NOTE=....

2009-07-17 Thread Aaron Boodman
On Fri, Jul 17, 2009 at 11:07 AM, Aaron Boodmana...@chromium.org wrote: Sorry, my idea was that the release manager would use these notes to create the actual release notes (with some editorializing along the way), and then I wouldn't have to do my side email. - a On Fri, Jul 17, 2009 at

[chromium-dev] Re: Proposal for new changelist annotation: RELEASE_NOTE=....

2009-07-17 Thread Aaron Boodman
On Fri, Jul 17, 2009 at 11:16 AM, Mark Larson (Google)m...@chromium.org wrote: I've been thinking of something along the same lines. I was also considering a ReleaseNotes file, like a ChangeLog but only to announce noteworthy changes. The advantages are that it can be edited post-commit and

[chromium-dev] Re: Proposal for new changelist annotation: RELEASE_NOTE=....

2009-07-17 Thread Aaron Boodman
On Fri, Jul 17, 2009 at 11:00 AM, Jeremy Orlowjor...@chromium.org wrote: Would this be optional?  I ask because the TEST one seems to have junk in it half the time. I think it'd be valuable, but most patches won't need it. It would definitely be optional, and it developers would be encouraged

  1   2   3   >