On Wed, Jul 22, 2009 at 1:22 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Jul 22, 2009 at 1:17 PM, Ojan Vafai o...@chromium.org wrote:
platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAntiAlias):
BUG=http://bugs.chromium.org/BUG_NUMBER_HERE
TEST=required
RELEASE_NOTES=optional
On Wed, Jul 22, 2009 at 1:28 PM, Jeremy Orlow jor...@chromium.org wrote:
On Wed, Jul 22, 2009 at 1:22 PM, Peter Kasting pkast...@google.comwrote:
On Wed, Jul 22, 2009 at 1:17 PM, Ojan Vafai o...@chromium.org
On Wed, Jul 22, 2009 at 2:52 PM, Darin Fisher da...@chromium.org wrote:
On Wed, Jul 22, 2009 at 2:02 PM, Peter Kasting pkast...@google.comwrote:
On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow jor...@chromium.orgwrote:
Here comes the bike shedding
Yes, Evan already concluded that was where
On Wed, Jul 22, 2009 at 5:59 PM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
One thing that would help us keep the tree more green is avoiding compile
failures. A compile failure is very bad, because without binaries the tests
can't run, and then we have to wait for all of them to run,
On Mon, Jul 20, 2009 at 8:22 PM, Jeremy Orlow jor...@chromium.org wrote:
In other words, make all workers appear the same to V8 (i.e. as a
WORKERCONTEXT) and then implement polymorphism in the implementations being
wrapped by V8.
On Mon, Jul 20, 2009 at 8:19 PM, Jeremy Orlow jor
polymorphism have custom getters/setters for every attribute that
check the type of the impl class and do the appropriate thing. But it seems
like the whole point of having the V8ClassIndex enum is to avoid this kind
of manual polymorphism.
-atw
On Mon, Jul 20, 2009 at 8:22 PM, Jeremy Orlow jor
On Tue, Jul 21, 2009 at 3:35 PM, Peter Kasting pkast...@chromium.orgwrote:
On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth aba...@chromium.org wrote:
Thanks to some recent work by Dimitri, Victor, and others, hacking on
WebKit is now easier than ever. If you work on WebKit and Chromium, I
On Tue, Jul 21, 2009 at 9:37 PM, Anthony LaForge lafo...@google.com wrote:
In order to make it easier for the community to see the changes are going
on inside Chromium I'd like to propose that we add one or more ChangeLog
files into our code base. The proposed usage would go something like
Sorry if this is a dumb question, but why woudn't you simply have a
WORKERCONTEXT and let virtual dispatch do its job for the rest? Shared
methods can be implemented on the base class and the rest can be purely
virtual with implementations in the sub classes.
J
On Mon, Jul 20, 2009 at 3:21 PM,
In other words, make all workers appear the same to V8 (i.e. as a
WORKERCONTEXT) and then implement polymorphism in the implementations being
wrapped by V8.
On Mon, Jul 20, 2009 at 8:19 PM, Jeremy Orlow jor...@chromium.org wrote:
Sorry if this is a dumb question, but why woudn't you simply have
On Sun, Jul 19, 2009 at 1:41 PM, Jeremy Orlow jor...@chromium.org wrote:
Take a look at src/webkit/api/public. WebKitClient has all the hooks back
into Chromium. src/chrome/renderer/renderer_webkitclient_impl.h implements
the WebKitClient interface.
I'm not exactly sure how you want to design
On Fri, Jul 17, 2009 at 10:37 AM, Mark Larson (Google) m...@chromium.orgwrote:
On Fri, Jul 17, 2009 at 09:35, Jon j...@chromium.org wrote:
Thank you for asking this. This privacy feature is a real pain for me.
Unfortunately, I can't turn it off by default for team members. I wish I
Would this be optional? I ask because the TEST one seems to have junk in
it half the time.
I think it'd be valuable, but most patches won't need it.
On Fri, Jul 17, 2009 at 10:48 AM, Aaron Boodman a...@chromium.org wrote:
I propose we add a new tag to changelist descriptions:
FYI, I'm now a WebKit committer. I know I'm going to regret this, but feel
free to ping me if you have reviewed WebKit patches that you need to get in.
Everyone else was really great about landing my patches, so now it's time
to pay it forward. :-)
If you want to see who else is a
Maybe those should be moved out of the source tree (into deps) so that they
can be excluded?
On Thu, Jul 16, 2009 at 9:23 AM, Victor Wang vict...@chromium.org wrote:
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
I think we should re-enable them ASAP unless there's some good reason why
you want to wait.
J
On Tue, Jul 14, 2009 at 6:32 AM, Mohamed Mansour m...@chromium.org wrote:
Lets wait a bit before re-enabling tests, but they seem to act happy,
unlike last night. If no one re-enables them, I can do
I think there's enough of us that it'd be cheaper to just buy him a keg
together. :-)
On Tue, Jul 14, 2009 at 1:06 PM, Michelangelo De Simone
micde...@gmail.comwrote:
2009/7/14 Dimitri Glazkov dglaz...@chromium.org:
This change should alleviate a lot of pain for WebKit gardeners and
On Tue, Jul 14, 2009 at 2:42 PM, Adam Langley a...@chromium.org wrote:
On Tue, Jul 14, 2009 at 2:40 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
That is pretty nuts. Is it calling fsync or something crazy? Since you
said strace, I'm assmuming linux. In that case, the buffer cache
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote:
On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote:
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote:
WebCore::String has the interesting property of differentiating between
an
On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote:
On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote:
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org
wrote:
On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org
All right. NullableString16 it is. :-)
And, in case it's not clear, this will only be for strings that have a valid
null state. The common case should still be using string16.
J
On Mon, Jul 13, 2009 at 10:23 AM, Scott Hess sh...@chromium.org wrote:
On Mon, Jul 13, 2009 at 10:10 AM, Jeremy
On Mon, Jul 13, 2009 at 12:54 PM, Darin Fisher da...@chromium.org wrote:
On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.orgwrote:
On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote:
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.orgwrote
created GYP as opposed to using
something else like cmake.
J
-- Forwarded message --
From: Brent Fulgham bfulg...@gmail.com
Date: Sun, Jul 12, 2009 at 9:28 AM
Subject: Re: [webkit-dev] Please welcome GYP to the our dysfunctional build
family
To: Jeremy Orlow jor...@chromium.org
Cc
On Fri, Jul 10, 2009 at 4:48 AM, Mohamed Mansour m...@chromium.org wrote:
An OWP seems an excellent thing. The thing is, there seems to be a
separation between internal Google developers and External developers. For
instance, we are not brought into the loop regarding some processes. I know
WebCore::String has the interesting property of differentiating between an
empty string and a null string. In string16, however, there is no such thing
as null.
The LocalStorage implementation I'm working on proxies data between the
rednerer processes and browser process. Some of this data is in
I clobbered the WebKit FYI builds. Looks like someone else beat me to the
main windows builds.
On Thu, Jul 9, 2009 at 1:35 AM, Adam Barth aba...@chromium.org wrote:
I can see the buildbot intermittenly now, and it looks like Windows
needs a clobber. Unfortunately, I don't see a way to do
On Wed, Jul 8, 2009 at 8:43 AM, nakro yoav.zilberb...@gmail.com wrote:
Ok, i am happy it catches your attention
sadly, i cannot submit patches for it as i wrote an external tool who
does it automatically for me
by patching the sln and vcproj/vsprops (i can pass the source code to
anyone if
Hm...I wonder how mondrian (an internal Google tool) does it...
Maybe the chromium-revi...@googlegroups.com could be changed to
chromium-reviews+the review number@googlegroups.com and that could be used
instead?
On Wed, Jul 8, 2009 at 5:44 PM, John Abd-El-Malek j...@chromium.org wrote:
Note:
On Wed, Jul 8, 2009 at 6:21 PM, Marshall Greenblatt
magreenbl...@gmail.comwrote:
On Wed, Jul 8, 2009 at 8:19 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Jul 8, 2009 at 5:12 PM, Marshall Greenblatt
magreenbl...@gmail.com wrote:
I imagine this could require complex controls like
On Wed, Jul 8, 2009 at 9:01 PM, Thiago Farina thiago.far...@gmail.comwrote:
I think it's good maintain the things simple, and I agree that all UI
changes needs to be approved before starting code. Because I didn't
know about that I started writting the patch without the approval. I
think
On Wed, Jul 8, 2009 at 9:05 PM, Jeremy Orlow jor...@chromium.org wrote:
On Wed, Jul 8, 2009 at 9:01 PM, Thiago Farina thiago.far...@gmail.comwrote:
I think it's good maintain the things simple, and I agree that all UI
changes needs to be approved before starting code. Because I didn't
know
Actually, there are a couple spots to edit:
http://codereview.chromium.org/155057 -- maybe more
Is it time to make this default yet? It speeds up the build considerably
and almost everyone uses it now. It does make things a bit less
deterministic, but you can always clobber build if something
FYI because some people might not be on webkit-dev.
BUT if this seems even remotely interesting to you, get on that list! (They
recently split it into webkit-dev and webkit-help, so signal to noise should
get better than it was before...in case that was a concern of yours.)
J
--
Yeah, I'll admit that trac is slow and that Darin's page solves most of my
needs.
And no, I
haven't tried git web yet. What's the URL? Is there anything major
blocking it from being made external?
J
On Thu, Jul 2, 2009 at 10:17 AM, Mohamed Mansour m...@chromium.org wrote:
Since I am
AppSpot is being flaky today. It's not letting us close the tree and code
reviews are only somewhat working.
Please watch the waterfall extra closely before you commit. Also, PLEASE
check this thread as well, in case there are any further instructions.
If I need to close the tree, I'll mention
Yup.
http://crbug.com is a nice shortcut to that page as well.
On Wed, Jul 1, 2009 at 1:50 AM, Non-Stick kevin.ra...@ntlworld.com wrote:
Chrome and Safari don't support the pluginspage attribute. The best way
to
get this small feature request on our radar is to file a bug.
Will do.
Who knows what needs to happen on the Chrome side for this?
Is it ok for me to create a p1 bug for this and then roll the deps anyway?
(The code compiles still.)
J
On Wed, Jul 1, 2009 at 11:57 AM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Will this let us solve
PM, Peter Kasting pkast...@chromium.org wrote:
On Wed, Jul 1, 2009 at 7:27 PM, Jeremy Orlow jor...@chromium.org wrote:
Is there any reason we use ViewVC rather than something like trac (for
example, trac.webkit.org)? I wouldn't exactly call Trac amazing, but
there are a few cool features
Also, is there any way to search?
On Wed, Jul 1, 2009 at 7:40 PM, Jeremy Orlow jor...@chromium.org wrote:
Can I do something like this with ViewVC?
http://trac.webkit.org/changeset?new=45...@trunkold=45...@trunk
http://trac.webkit.org/changeset?new=45...@trunkold=45...@trunkAlso
Sure we shouldn't expect design docs from people (or request them), but I
don't think we should discourage them.
I've taken a look at all the WebKit design docs that have floated around
(though I suppose most responses have been on this mailing list). I think
it's especially important for
Might be best if someone with a lot of GYP experience responded to this.
Someone brought up using GYP on the WebKit mailing list.
-- Forwarded message --
From: Adam Roben aro...@apple.com
Date: Mon, Jun 29, 2009 at 7:02 AM
Subject: Re: [webkit-dev] MSVS vcproj
To: Seo K
I only skimmed, but it looks well thought out.
One question though:
is this going to be functional for non-Chromium browsers? Given that
your design doc mentions v8 and hooks into Chromium's network
stack, but no mention of JavaScriptCore or WebKit's resource loading code,
I'm worried that the
For what it's worth, I was really impressed by the O3D documentation:
http://code.google.com/apis/o3d/docs/index.html
http://code.google.com/apis/o3d/docs/index.htmlNot sure how they did it,
but I believe it was all generated. Not sure if
that's close enough to what you had envisioned.
On Tue,
What your describing sounds exactly like a lightweight (i.e. only the
features you want) version of what's already out there. (At least now that
you've ditched the no file generation requirement.)
Unless you have some requirements that are really important to the success
of the
What your describing sounds exactly like a lightweight (i.e. only the
features you want) version of what's already out there. (At least now that
you've ditched the no file generation requirement.)
Unless you have some requirements that are really important to the success
of the
On Tue, Jun 23, 2009 at 5:14 PM, Aaron Boodman a...@chromium.org wrote:
On Tue, Jun 23, 2009 at 5:09 PM, Jeremy Orlowjor...@google.com wrote:
What your describing sounds exactly like a lightweight (i.e. only the
features you want) version of what's already out there. (At least now
that
FYI from the webkit mailing list.
We'll probably want to prepare a similar CL for our binding generating code
and whoever is doing the merges should look out for this change being
landed.
J
On Sun, Jun 21, 2009 at 10:46 PM, Darin Adler da...@apple.com wrote:
The IDL file format we use to
I'm not so sure [1]but we can ask.
J
[1] http://lists.macosforge.org/pipermail/webkit-dev/2009-May/007960.html
http://lists.macosforge.org/pipermail/webkit-dev/2009-May/007960.html1)
We weren't super enthusiastic about the master WebKit tree trying
to support two different JavaScript
I agree. I was thinking about looking into this (once LocalStorage is
working).
Besides the fact that we have more custom code than we should have, a good
portion of the .dll is just generated code. It seems like we should be able
to strike a better balance of doing things dynamically vs
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek j...@chromium.org wrote:
+1 this is affecting a lot of people.
On Thu, Jun 18, 2009 at 12:43 PM,
It might take a bit of getting used to, but git is a revision control tool
that allows you to create your own personal branches. Many Chromium
developers use it for their daily work. The way it interfaces with svn is a
bit clunky, but if you're not committing very often, it probably won't
matter
I believe that's what we're talking about here. (the other) Jeremy's been
talking about the OSX spellchecker. The one issue is that the default
checker doesn't handle all the languages Chrome supports, hence
If the need arises,wrapping hunspell as an Apple Spelling service and
provide it as a
It is used for other stuff. It shouldn't be too hard to search the code
base to find out specifically where.
On Tue, Jun 9, 2009 at 7:23 PM, Meryl Silverburgh
silverburgh.me...@gmail.com wrote:
Hi,
I see chromium uses sqlite3.
Does it use it for Google Gear only?
or it uses it for other
Does it make sense to try and fix/add dependencies in the gyp whenever we
run into problems like this? I don't know the details of why these
dependencies aren't catched already, but it seems like over time we could
stop hitting these problems?
On Fri, May 29, 2009 at 9:15 AM, Brett Wilson
On Wed, May 20, 2009 at 2:54 PM, Aaron Boodman a...@chromium.org wrote:
On Tue, May 19, 2009 at 11:35 AM, jack js2...@gmail.com wrote:
Sorry for this late response. I was piled up in the past days. I did
some additional trials. It's quite random and it is hard to get unique
results. But
I have no idea what I'm talking about, but hand wavingI just wanted to
comment that on Linux when firefox is updated while I'm running, things
start getting really weird and it generally becomes unusable pretty
quickly...no idea why, but I assume it has something to do with its
resources being
The JavaScript bindings are (mostly) generated from .idl files found in
chromium/src/third_party/WebKit/WebCore/*/*.idl
chromium/src/third_party/WebKit/WebCore/dom/Node.cpp has a bunch
of dispatch*Event methods.
I don't know if the sandbox will get in your way, but doing this entirely in
WebKit
for discussion.
2009/5/6 Adam Barth aba...@chromium.org
We should be careful about adding non-standard APIs to the Web
platform. If we want to make this available to every Web site, we
should first standardized the API through W3C.
Adam
2009/5/6 Jeremy Orlow jor...@google.com:
The JavaScript
Agreed. It's also worth pointing out that the context of this started out
as an API for the add-on/extension system and evolved into an API that might
be more broadly available.
On Wed, May 6, 2009 at 12:39 PM, Mike Beltzner beltz...@mozilla.com wrote:
On 6-May-09, at 3:30 PM, Jeremy Orlow
On Wed, May 6, 2009 at 1:10 PM, jack js2...@gmail.com wrote:
[It seems that I can only post in the group, instead of replying in
gmail, to have my reply posted here. So apologize if you already
received this before. ]
Thanks for all of your inputs. My previous example (gmail addon) might
On Fri, May 1, 2009 at 11:36 AM, cpu c...@chromium.org wrote:
Utility process is an amenable idea. We do something like that for
first-run import as well.
Key items, I can think of:
1- Utility process would not display UI (would it?)
2- We can allow a directory to be available for
I'm still kind of new here, so forgive me if this is a silly question, but
why do this with a define and not an template function?
On Fri, May 1, 2009 at 12:35 PM, Adam Langley a...@chromium.org wrote:
On POSIX systems, system calls can be interrupted by signals. In this case,
they'll return
On Fri, May 1, 2009 at 1:27 PM, Adam Langley a...@chromium.org wrote:
On Fri, May 1, 2009 at 12:53 PM, Jeremy Orlow jor...@google.com wrote:
I'm still kind of new here, so forgive me if this is a silly question,
but
why do this with a define and not an template function?
One could imagine
+1 to the blog entry
On Fri, May 1, 2009 at 2:44 PM, Evan Martin e...@chromium.org wrote:
Truly momentous. You should post the the Chromium blog about it (and
why it's meaningful).
Great work!
On Fri, May 1, 2009 at 2:38 PM, Dimitri Glazkov dglaz...@chromium.org
wrote:
Hello all,
The story is even simpler for localStorage. Everything is fairly self
contained and the only way it cares about the main thread is in asserts to
verify SQLite is not used on the main thread.
My guess is that the story for what's considered the main thread will change
for each API much like the
On Wed, Apr 29, 2009 at 7:43 AM, David Levin le...@google.com wrote:
On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting pkast...@chromium.orgwrote:
On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow jor...@chromium.orgwrote:
Darin was there on that lunch and was actually the one who first
Just wanted to let everyone know that we posted videos of 5 tech talks
related to Chromium. There's a blog post on the Chromium Blog (
http://blog.chromium.org/2009/04/chromium-tech-talks.html), but here are
some direct links:
Darin Fisher http://www.youtube.com/watch?v=A0Z0ybTCHKs talking about
Yes, yes, I know this is a horrible idea, but please hear me out :-)
Last week, a couple of us (Darin F, Michael N, Jeremy M, and I) had lunch at
Apple to talk to talk about sharing more code. HTML 5 brings with it a lot
of APIs that reach outside of the top level browsing context boundary
On Tue, Apr 28, 2009 at 5:27 PM, Michael Nordman micha...@google.comwrote:
In some sense we do have separate process in which to run sandboxed
'backend' code relevant to multiple renders if the need arises... the
worker process.
The way you stated this is a bit odd, but on the surface I
Nordman micha...@chromium.orgwrote:
On Tue, Apr 28, 2009 at 5:38 PM, Jeremy Orlow jor...@chromium.org wrote:
On Tue, Apr 28, 2009 at 5:27 PM, Michael Nordman micha...@google.com
wrote:
In some sense we do have separate process in which to run sandboxed
'backend' code relevant
On Tue, Apr 28, 2009 at 6:26 PM, Evan Martin e...@chromium.org wrote:
On Tue, Apr 28, 2009 at 5:59 PM, Aaron Boodman a...@chromium.org wrote:
Is the idea that someday the browser and renderer processes
might be separate binaries?
Though this shouldn't drive your decision, about 50% of our
Another option: On vista, you can also use mklink /D /J link target
dir to create a soft link from one directory to another. I create a link
for Debug and Release to a directory on another drive.
It seems to work fine for me.
On Mon, Apr 27, 2009 at 5:53 PM, Glen Murphy g...@chromium.org wrote:
On Tue, Apr 14, 2009 at 9:32 AM, Darin Fisher da...@chromium.org wrote:
Please ask Brett Wilson to review your DB schema and operations.
Brett, can you please take a look? The database part of it is towards the
end of the page.
a way to
copy it out. That may actually be required if we want to support
persisting
sessionStorage for the purposes of session restore. Hmm...
-darin
On Tue, Apr 7, 2009 at 9:12 PM, Jeremy Orlow jor...@chromium.org
wrote:
After several chromium-dev and whatwg email threads, I think
Everything without a comment has been incorporated into the doc.
On Tue, Apr 14, 2009 at 9:36 AM, Darin Fisher da...@chromium.org wrote:
LocalStorage
Luckily, each origin is completely isolated from the next, so we
essentially must implement a per-origin lock for localStorage. -- In
I've gotten very few comments. I assume no news is good news? :-)
On Tue, Apr 7, 2009 at 9:27 PM, Jeremy Orlow jor...@chromium.org wrote:
Actually, if you want to edit, try these links:
http://docs.google.com/a/chromium.org/Doc?id=dhs4g97m_0hjv3nqc7hl=en
http://docs.google.com
After several chromium-dev and whatwg email threads, I think the major
issues with the spec and how to implement localStorage have been hammered
out. I've written up my current thoughts in terms of a couple documents
(listed below).
This is my first major chunk of code in Chromium, so I've tried
*If you don't care where various bits of the localStorage implementation
live and you aren't scared about letting stuff out of the sandbox, you can
stop reading now.*
*
*
Background:
For those who don't know the spec by heart: SessionStorage can be thought
of as 'tab local' storage space for
From what I've seen, a large portion of the svg tests fail due to pretty
fundamental svg implementation issues. In addition, many of the tests fail
due to the same bug/root cause.
I think Dimitri is right that the best approach here is a smaller, more
focused effort whether or not fixing these
201 - 279 of 279 matches
Mail list logo
