[chromium-dev] Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-06 Thread Amanda Walker
Re-forwarding yet again... -- Forwarded message -- From: Amanda Walker [EMAIL PROTECTED] Date: Wed, Nov 5, 2008 at 10:22 PM Subject: Re: [chromium-dev] Re: OS X IPC Design doc To: chromium-dev@googlegroups.com On Wed, Nov 5, 2008 at 10:11 PM, Amanda Walker [EMAIL PROTECTED

[chromium-dev] Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-06 Thread Amanda Walker
And one more from last night that got dropped: -- Forwarded message -- From: Amanda Walker [EMAIL PROTECTED] Date: Wed, Nov 5, 2008 at 10:42 PM Subject: Re: [chromium-dev] Re: OS X IPC Design doc To: chromium-dev@googlegroups.com On Wed, Nov 5, 2008 at 10:32 PM, [EMAIL PROTECTED

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-07 Thread Amanda Walker
measurementa should help this discussion immensely. --Amanda On Fri, Nov 7, 2008 at 8:54 PM, Wan-Teh Chang [EMAIL PROTECTED] wrote: On Thu, Nov 6, 2008 at 2:05 PM, Amanda Walker [EMAIL PROTECTED] wrote: Linux and Darwin are only superficially similar, and the differences get larger the closer

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-13 Thread Amanda Walker
To my knowledge, we don't have specific speed requirements, so no, there's no simple test that could show whether or not a given mechanism is fast enough. However, as I noted yesterday, it should be fairly straightforward to extract some performance data from the windows build, which would at

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-13 Thread Amanda Walker
On Thu, Nov 13, 2008 at 12:46 PM, Darin Fisher [EMAIL PROTECTED] wrote: Right on... We can definitely support custom implementations for each platform, and we should do that if it significantly lowers barriers and helps us get to a better product. I think it was reasonable to talk about

[chromium-dev] Re: converting Windows build to SCons

2008-11-14 Thread Amanda Walker
I don't know anything about scons internals, but how hard would it be to fix that? Have a scons server that sat around waiting for commands to build (or event watched a set of directories for changes and updated its dependency graph on the fly)? --Amanda On Fri, Nov 14, 2008 at 2:23 PM, Darin

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-17 Thread Amanda Walker
On Mon, Nov 17, 2008 at 12:25 AM, John Abd-El-Malek [EMAIL PROTECTED] wrote: I'm not trying to argue for one system or another, but I think things like sending 1MB or 7MB of data quickly, or up to 256MB, aren't actually needed by the existing code. That's my suspicion as well, but the code is

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-17 Thread Amanda Walker
On Mon, Nov 17, 2008 at 8:59 AM, Amanda Walker [EMAIL PROTECTED] wrote: I'll sync up my windows build today and start collecting some stats on both message sizes and latency that we can use as a concrete reference point. I should say we here--Jeremy may already be a step ahead of me here

[chromium-dev] Re: Quick and dirty chrome embedding test

2008-11-17 Thread Amanda Walker
On Mon, Nov 17, 2008 at 1:48 PM, Marshall Greenblatt [EMAIL PROTECTED] wrote: It's clear from core developer comments, I think, that providing an ActiveX control is not a priority for the core chromium or Google development teams. I've gotten the strong impression that if someone doesn't take

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Amanda Walker
On Mon, Nov 17, 2008 at 11:37 PM, Brett Wilson [EMAIL PROTECTED] wrote: Native_theme is a little more tricky since there is some desire to eventually unify theme drawing with the rest of WebKit. If we did that, it would probably be undesirable from WebKit's perspective to have this file in

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Amanda Walker
On Tue, Nov 18, 2008 at 1:54 PM, Brett Wilson [EMAIL PROTECTED] wrote: No matter what we do each platform should have its own font and form control rendering. I don't think unifying these has ever been on the table. When I talk about unifying I mean the overall architecture. Each platform

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Amanda Walker
On Tue, Nov 18, 2008 at 2:05 PM, Brett Wilson [EMAIL PROTECTED] wrote: This is not platform-specific on any other architecture, and it doesn't need to be. The difference is that font and form control rendering have to be native for us to look correct. This is not the case for images or any

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Amanda Walker
On Tue, Nov 18, 2008 at 3:16 PM, Brett Wilson [EMAIL PROTECTED] wrote: That's what I was saying may or may not be worth it, and what the decision really comes down to. OK. The change that I'm currently finishing up is, in essence, a more generalized form of the SkBitmap/CGImage converter

[chromium-dev] Re: chrome browser control for linux/osx

2008-11-24 Thread Amanda Walker
Putting together a document is great. While you are working on it, you should take a look at the WebKit documentation as a reference point if you're not already; while the WebKit embedding method for Windows isn't as rich as NSWebView in Cocoa, reading up on both will give you a good idea of the

[chromium-dev] Re: chrome browser control for linux/osx

2008-11-25 Thread Amanda Walker
On Mon, Nov 24, 2008 at 12:04 PM, Marshall Greenblatt [EMAIL PROTECTED] wrote: The framework that I envision for embedded clients will be very simple and focused, with access to only a subset of the functionality provided by chromium's WebKit layer (basically mirroring the functionality that

[chromium-dev] Re: chrome browser control for linux/osx

2008-11-26 Thread Amanda Walker
Nobody's in a position to object, though I know a bunch of people are approaching the problem from different angles. Perhaps we'll end up with a bake-off :-). More seriously, coding up an example implementation, even just as a proof of concept, is a great way to validate a design (take a look

[chromium-dev] Re: Windows layout tests

2008-11-29 Thread Amanda Walker
On Sat, Nov 29, 2008 at 4:32 PM, Mark Larson (Google) [EMAIL PROTECTED] wrote: I also don't want to throw up artificial barriers between platforms. We're just about at parity across all platforms on layout tests. It's time to start treating all the platforms as equally important (well maybe

[chromium-dev] Re: The review tool

2008-12-04 Thread Amanda Walker
On Thu, Dec 4, 2008 at 9:47 PM, Benjamin [EMAIL PROTECTED] wrote: Clearly you didn't even bother reading my e-mail (I know it was really long and all) This was entirely unnecessary and inflammatory. Not really. Sigh. If his comment was insulting, so was yours. But frankly, they both

[chromium-dev] Re: UI proposal: Open link in new foreground tab

2008-12-09 Thread Amanda Walker
Or go by the old maxim every preference is the remnant of an unresolved design question :-). On Tue, Dec 9, 2008 at 7:20 PM, Ben Goodger (Google) [EMAIL PROTECTED]wrote: On Tue, Dec 9, 2008 at 4:14 PM, Glen Murphy [EMAIL PROTECTED] wrote: It would be nice if for every preference we added, we

[chromium-dev] Re: Bookmark Added! GUI redesign ideas

2008-12-10 Thread Amanda Walker
On Wed, Dec 10, 2008 at 10:53 AM, Simon B. [EMAIL PROTECTED] wrote: @Mike, I beleive it's common on web sites to have a button for primary action, and links or smaller and less colourful ones for secondary buttons. Indeed--this is not a web site, it's a local application, where links, where

[chromium-dev] Re: bookmark menu

2008-12-16 Thread Amanda Walker
On Mon, Dec 15, 2008 at 8:41 PM, Bizzeh killallthehum...@gmail.com wrote: this views do intersect with my own, however i do not feel that i was fairly treated. i feel as if i was treated as the kid that nobody wants around at school because everybody is fine as they are. Darren, where are

[chromium-dev] Re: porting views to linux/posix

2008-12-16 Thread Amanda Walker
On Tue, Dec 16, 2008 at 12:10 PM, Scott Violet s...@chromium.org wrote: I believe the original thinking was that we would have view specific implementations per platform and the code would change to go through a factory for creating the leaf node views instead of using constructors.

[chromium-dev] Re: Extensions and profiles

2008-12-17 Thread Amanda Walker
On Wed, Dec 17, 2008 at 5:43 PM, Aaron Boodman a...@chromium.org wrote: Doing per-user extension installation w/ per-profile disabledness override and configuration is an interesting idea. Seems simpler in some ways, and perhaps better than purely per-profile. I like it--that would cover all

[chromium-dev] Re: System Services (interapplication communication on Mac OS X): processor services in Chrome

2008-12-23 Thread Amanda Walker
On Tue, Dec 23, 2008 at 2:52 AM, Graham Perrin grahamper...@gmail.com wrote: Yes, but the things are not related to processors services. Let's shift attention to the thread on provider services :) Perhaps if you'd describe what you're actually interested in doing, we could give better answers.

[chromium-dev] Re: Complex scripting is not used

2008-12-27 Thread Amanda Walker
I'm not aware of a Chromium port to the iPhone. The last time I looked at it, MyFox just uses Apple's existing version of WebKit, not the Chromium version. --Amanda On Sat, Dec 27, 2008 at 3:42 PM, Developer sherifomran2...@gmail.com wrote: I downloaded the Myfox version of Chromium for

[chromium-dev] Re: V8Bindings_prebuild slowness

2009-01-04 Thread Amanda Walker
On Sun, Jan 4, 2009 at 4:45 PM, Brett Wilson bre...@chromium.org wrote: Well, but you'd still have the slowness of spawing perl hundreds of times. I'm not sure that would speed up the build at all (though it would improve the dependency management). Perhaps we've outgrown perl :-). I haven't

[chromium-dev] Re: V8Bindings_prebuild slowness

2009-01-04 Thread Amanda Walker
On Sun, Jan 4, 2009 at 5:40 PM, Dean McNamee de...@chromium.org wrote: The perl code is the upstream webkit's IDL compiler (but heavily modified for v8). It reads in the IDL files and generates the .h / .cpp files that are the actual binding code. It would be nice to rewrite this, but it

[chromium-dev] Re: dtrace and chromium?

2009-01-12 Thread Amanda Walker
I expect dtrace to be downright crucial once we get to performance measurement and improvement, especially in an execution environment that involves communication among multiple processes. Apple ships both dtrace and a nice graphical frontend to it called Instruments as a part of the Xcode

[chromium-dev] Re: If you're feeling bored

2009-01-13 Thread Amanda Walker
They also contribute to launch time. Generally speaking, the less code we have to execute during startup, the better it is for the user experience. On Tue, Jan 13, 2009 at 11:22 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: (If you're wondering why, see

[chromium-dev] Re: Rebaselinig a layout test

2009-01-13 Thread Amanda Walker
Generally speaking, on a Mac, only text fields are keyboard focusable. If we have to pick a single behavior without a pref, that should be it. Ideally, we should pick up the system-level accessibility prefs and/or an application-level pref. Unless a user has turned it on, hitting tab and not

[chromium-dev] Re: Rebaselinig a layout test

2009-01-13 Thread Amanda Walker
conversation: - Both Safari and Firefox on mac default to not tabbing through all elements. This is consistent with the rest of the OS. - Both have a pref for the users who do want that behavior (sorry, no numbers for how many change it). On Tue, Jan 13, 2009 at 5:53 PM, Amanda Walker awal

[chromium-dev] Re: Making sense of startup

2009-01-15 Thread Amanda Walker
On Thu, Jan 15, 2009 at 11:55 AM, Jim Roskind j...@chromium.org wrote: IMO, the big grouping distinction for startup code is a) code that needs to be performed while single threaded; vs b) code that can run while multi-threaded. Agreed--but often (a) is used as a proxy for an ordering

[chromium-dev] Re: Making sense of startup

2009-01-15 Thread Amanda Walker
That's true. In the example I gave (Mac driver loading), each module has a property list that lists its dependencies (and version requirements, etc.). That's not quite as simple to do inside a single application, of course, but having code do the ordering still seems like a win to me. Consider

[chromium-dev] Re: Making sense of startup

2009-01-15 Thread Amanda Walker
On Thu, Jan 15, 2009 at 4:37 PM, Brett Wilson bre...@chromium.org wrote: On Thu, Jan 15, 2009 at 1:19 PM, Amanda Walker ama...@chromium.org wrote: That's true. In the example I gave (Mac driver loading), each module has a property list that lists its dependencies (and version requirements, etc

[chromium-dev] Re: OSX 10.4 and PPC support?

2009-01-15 Thread Amanda Walker
On Thu, Jan 15, 2009 at 5:59 PM, AJS ajs15...@gmail.com wrote: So, are there any plans for supporting OSX 10.4 in the future? Our initial focus is on 10.5, so 10.4 support will probably depend on someone taking it on closer to (or after) it's feature complete. We don't have any active plans

[chromium-dev] Re: Thoughts on the default plugin

2009-01-20 Thread Amanda Walker
On Tue, Jan 20, 2009 at 1:48 PM, John Abd-El-Malek j...@chromium.org wrote: It seems that the only reason this code is needed is to get the function pointers for the internal plugin. Perhaps the PluginVersionInfo InternalPluginInfo stuff could be taken out of the platform independent code.

[chromium-dev] Re: Building problem on Mac OS X

2009-01-20 Thread Amanda Walker
On Tue, Jan 20, 2009 at 4:04 PM, Yuki ynaga...@gmail.com wrote: I deleted all local source code.But I still have same problem. How is the build failing? If Xcode is giving an error message, can you copy it into reply? Thanks, --Amanda --~--~-~--~~~---~--~~

[chromium-dev] Re: linux: tabs on top

2009-01-28 Thread Amanda Walker
On Wed, Jan 28, 2009 at 4:38 PM, Mike Pinkerton pinker...@chromium.org wrote: Sorry, this couldn't be further from what we're actually doing right now. We're inserting a view into the window's view hierarchy as a sibling to the contentView, which works surprisingly well. We may run into

[chromium-dev] Re: Claimings

2009-02-09 Thread Amanda Walker
I have a SimpleFontDataMac unfork in flight, plus windowless plugins (mostly Mac, but some overlap with Linux, especially header files) --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

[chromium-dev] Re: Passing around NativeViews between processes.

2009-02-13 Thread Amanda Walker
On Fri, Feb 13, 2009 at 1:34 AM, Dean McNamee de...@chromium.org wrote: I believe the situation is similar on the Mac. I'm not sure the current design of passing HWNDs between processes conceptually extends beyond win32. The situation on the Mac is similar. There's an internal window server

[chromium-dev] Re: Passing around NativeViews between processes.

2009-02-13 Thread Amanda Walker
On Fri, Feb 13, 2009 at 9:27 AM, Darin Fisher da...@chromium.org wrote: I thought on the mac, we were just going to support windowless mode. This discussion of passing HWNDs or XwindowIDs only pertains to windowed mode plugins. Is there a windowed mode for mac that we need to worry about?

[chromium-dev] Re: Passing around NativeViews between processes.

2009-02-13 Thread Amanda Walker
On Fri, Feb 13, 2009 at 10:14 AM, Dean McNamee de...@chromium.org wrote: You must mean canvas3d, I don't think that's a big deal yet as it's still just a Mozilla prototype. It would be nice to try to make things like that possible in our design though, anything with opengl is probably going

[chromium-dev] Re: What is the app\theme\chromium\chromium.icns file used for?

2009-02-17 Thread Amanda Walker
It is the Chromium application icon for the Mac. On Tue, Feb 17, 2009 at 10:36 PM, Daniel dpc...@hotmail.com wrote: Does anyone know what is the app\theme\chromium\chromium.icns file is used for? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: how keyboard input works

2009-02-19 Thread Amanda Walker
IMEs on the Mac even further decouple keystrokes from input characters, and we're going to need explicit support for them (since they will probably have to live in the browser process in order to put up windows, etc.). There will probably be a level at which we'll have to write some glue to feed

[chromium-dev] Re: [chromium-checkins] r10972 - in trunk/src: chrome/browser/renderer_host chrome/common net/base net/http net/url_request webkit/glue

2009-03-05 Thread Amanda Walker
On Thu, Mar 5, 2009 at 12:38 PM, Alpha (Hin-Chung) Lam hc...@google.com wrote: everytime I do a checkin I do a sync and send it to the try server, which really takes me a lot of time, but still try server is showing me green light to check in, am I suppose to not trust the try server and rely

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Amanda Walker
Because we don't see the mouse click for the main menu bar the same way we do for a context menu. Normally, we just get called back after a menu item has been selected. It's possible to update state while the menu is down, but that brings in the possibility of flashing/etc. as the menu changes

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 10:45 AM, Thomas Van Lenten thoma...@chromium.org wrote: What happens when we want to paste into an html edit area? Well, at least last time I looked at editable areas, they weren't handled via NSStrings, so I don't think we'd run into this problem there. Do we need to

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
Do we know it's obj-c collision? Or is it C++ types that are typedefed differently for us, but conveniently named-mangled the same so they link? --Amanda On Wed, Mar 11, 2009 at 10:49 AM, Mark Mentovai mmento...@google.com wrote: Avi Drissman wrote: 4. Figure out why system WebKit doesn't

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 10:55 AM, Mark Mentovai mmento...@google.com wrote: Binding C++ shouldn't be nearly as painful on the Mac: stuff is bound into a two-level namespace at link time. Ah, excellent point.  The smart money's on Obj-C which binds at runtime every time, but in today's

[chromium-dev] Re: Thoughts on copy/paste

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 2:07 PM, Brett Wilson bre...@chromium.org wrote: Do you mean when you click on the menu, blocking the browser until the renderer responds with whether the menus can be enabled? I would be opposed to that. So are we, but that's what WebKit currently assumes. That's why

[chromium-dev] Re: Status Bubble GTK?

2009-03-13 Thread Amanda Walker
On Fri, Mar 13, 2009 at 8:17 AM, Dean McNamee de...@chromium.org wrote: I wonder if the situation is at all similar on Mac. The Mac is pretty flexible in this regard--we can create arbitrarily shaped windows that are grouped/stacked with existing windows however we want (or put another way,

[chromium-dev] Re: New waterfall Developer View.

2009-03-16 Thread Amanda Walker
Nicolas, I like this a *lot*--it makes it much easier to see which build or test failures resulted from a particular commit. Very nice job! --Amanda On Sun, Mar 15, 2009 at 9:54 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hello!   A lot of people told me that they did not like the

[chromium-dev] Re: Rendering issues in chromium with theme applied

2009-03-22 Thread Amanda Walker
On Sat, Mar 21, 2009 at 6:54 PM, Robert Dailey rcdai...@gmail.com wrote: This issue is really quite serious for me as I am unable to use chromium on certain websites. I have hacked my uxtheme.dll on Windows XP so that I may apply third party visual themes to windows. Chromium does not yet

[chromium-dev] Re: Rendering issues in chromium with theme applied

2009-03-22 Thread Amanda Walker
with the code changes. On Sun, Mar 22, 2009 at 1:57 PM, Amanda Walker ama...@chromium.org wrote: On Sat, Mar 21, 2009 at 6:54 PM, Robert Dailey rcdai...@gmail.com wrote: This issue is really quite serious for me as I am unable to use chromium on certain websites. I have hacked my uxtheme.dll on Windows XP

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab.  This is the standard way of doing it on Windows, but I don't know how Mac/Linux apps enforce single-instance semantics.  

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
On Tue, Mar 24, 2009 at 1:06 PM, John Abd-El-Malek j...@chromium.org wrote: A lot of the code that touches databases/files in the user-data-dir assume they're the only ones accessing them.  If multiple instances use the data, there could be corruption. Makes sense. But multiple instances

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
, 2009 at 1:06 PM, Thomas Van Lenten thoma...@chromium.org wrote: On Tue, Mar 24, 2009 at 1:00 PM, Amanda Walker ama...@chromium.org wrote: 2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Amanda Walker
On Mon, Apr 13, 2009 at 12:13 PM, Darin Fisher da...@chromium.org wrote: The Mac implementation is wrong.  On a single core machine, the renderer could starve the UI thread of the browser, preventing any pixels from ever being updated on the screen. That seems wrong--the OS-prompted draw

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-26 Thread Amanda Walker
On Thu, Apr 23, 2009 at 4:35 PM, Nikita Ofitserov himi...@gmail.com wrote: Currently there are different implementations of ProcessSingleton and ChromeBrowserProcessId() on Windows, Linux and Mac. Most of them are quite hacky, so there should be a better way. I think current IPC system with

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-27 Thread Amanda Walker
pinker...@chromium.org wrote: On Sun, Apr 26, 2009 at 5:50 PM, Amanda Walker ama...@chromium.org wrote: Application startup is one of the areas where we count every millisecond, and try to touch the disk as little as possible.  I don't think it's safe to assume that the cost of creating

[chromium-dev] Re: Changes to FilePath?

2009-04-28 Thread Amanda Walker
On Tue, Apr 28, 2009 at 4:39 PM, Greg Spencer gspen...@google.com wrote: 1) I'd like to add some explicit routines for converting to/from UTF8 and UTF16.  While it's nice (and important) that FilePath uses the platform's native string, we've found that many third party libraries have made

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
The Mac needs something morally equivalent to #2 (with plugins as the current forcing function--there's no cross-process window handle we can use, so we need to track them ourselves anyway). I also strongly agree that the browser needs to be able to validate which window(s) a renderer can ask

[chromium-dev] Re: Plugin painting and deadlock

2009-05-04 Thread Amanda Walker
The only thing I can thing of that involves a client-server-client-server-client world tour in X is selection handling, but that's asynchronous. Querying window properties only looks at server state (also true for the Mac's window server--there's no such thing as a synchronous call from the

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
is, which sounds similar to gtk_native_view_id_manager... Adam On Mon, May 4, 2009 at 5:55 AM, Amanda Walker ama...@chromium.org wrote: The Mac needs something morally equivalent to #2 (with plugins as the current forcing function--there's no cross-process window handle we can use, so we need

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
Hmm. Would it be even cleaner for nothing but the plugin host process to care about the NativeViewId, since it's what has to provide it to the plugin via NPAPI? For everything else, either we're windowless and just shipping bitmaps around (no need for a window reference at all except to keep

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
. -Darin On Mon, May 4, 2009 at 1:37 PM, Amanda Walker ama...@chromium.org wrote: Hmm.  Would it be even cleaner for nothing but the plugin host process to care about the NativeViewId, since it's what has to provide it to the plugin via NPAPI?  For everything else, either we're windowless

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Amanda Walker
to duplicate it. --Amanda On Tue, May 5, 2009 at 12:27 PM, Никита Офицеров himi...@gmail.com wrote: I'm sorry for the late response, I've been quite busy last week. 2009/4/27 Amanda Walker ama...@chromium.org: Hacky is fairly subjective: are there particular things about the existing

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Amanda Walker
I'd be worried about flashing/jankiness using a real sheet, but a child window pinned to the top edge of the tab with the right transitions might work nicely. There's also some stuff Jeremy was doing in Gears that involved doing interesting things with login prompts that may (or may not) be

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
That would be pretty clean--or perhaps wrap it in a PlatformCanvas instead of a bare PlatformGraphicsContext? I haven't looked at the media code yet, so I'm not familiar with what it's actually trying to do. --Amanda On Tue, May 5, 2009 at 10:08 PM, Brett Wilson bre...@chromium.org wrote: On

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
Ah, I see. Hmm, going in that direction (from a GraphicsContext back up to the PlatformCanvas that wraps it) is an interesting question (the rest of our rendering code goes in the other direction). And as Brett can attest, this isn't the first time that PLATFORM(CG) has caused a headache--we

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-06 Thread Amanda Walker
2009/5/6 Andrew Scherkus scher...@chromium.org: We'll ping WebKit to find out the reasoning behind passing in a GraphicsContext.  Probably for performance reasons and reducing extra blits/copies, but still worth investigating. Probably that and preserving any active transforms, as Brett

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-06 Thread Amanda Walker
Hmm. Rather than an idle event, how about a general way to notify on machine state changes? idle / busy, ac / battery, willsleep / didwake, etc. all seem to have the same usage pattern. Apps could then key off of the notification to start/stop workers or timers for idle processing, etc.

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Amanda Walker
That's cleaner than I expected, and the behavior looks right. Nice job! I vote for continuing with this approach. --Amanda On Thu, May 7, 2009 at 12:17 AM, Avi Drissman a...@google.com wrote: OK, so attached is my proof of concept. The code is pretty clear, though if you have questions,

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-08 Thread Amanda Walker
Yeah. And I have to say, the tab-modal file sheet is very, very cool. It would be a shame to lose that capability. --Amanda On Fri, May 8, 2009 at 3:58 PM, Avi Drissman a...@google.com wrote: The problem with that approach is that you can't cleanly close a sheet in the general case. If

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Amanda Walker
On Tue, May 12, 2009 at 10:16 AM, Nicolas Sylvain nsylv...@chromium.org wrote: It's why we have checkin notification emails. http://groups.google.com/group/chromium-checkins?pli=1 I also like the RSS feeds, especially on a mobile device: http://groups.google.com/group/chromium-checkins/feeds

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Amanda Walker
Perhaps what we need is a companion to FilePath. For example: FilePath: much as it is now, lightweight, alternative to string manipulation. FileReference: heavierweight, can talk to the file system and have carnal knowledge of platform specifics for things like resolving / canonicalizing

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Amanda Walker
On Wed, May 13, 2009 at 7:07 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote: Perhaps what we need is a companion to FilePath.  For example: FilePath: much as it is now, lightweight, alternative to string manipulation

[chromium-dev] Re: Drawing code on Mac

2009-05-16 Thread Amanda Walker
, Amanda Walker awal...@google.com wrote: Hmm.  Marc, your change looks OK to me at first glance--how does it fail? --Amanda On Wed, May 13, 2009 at 12:10 PM, Avi Drissman a...@google.com wrote: I'm view meister, not render meister. Amanda is IIRC backing store/canvas meister. Avi

[chromium-dev] Re: Drawing code on Mac

2009-05-16 Thread Amanda Walker
the host to only paint a set of sub-rectangle from that bitmap. Do I explain it clearly enough? Thanks BYE MAD On Wed, May 13, 2009 at 1:16 PM, Amanda Walker awal...@google.com wrote: Hmm.  Marc, your change looks OK to me at first glance--how does it fail? --Amanda On Wed, May 13, 2009

[chromium-dev] Re: Drawing code on Mac

2009-05-20 Thread Amanda Walker
On Wed, May 20, 2009 at 9:22 AM, Marc-Andre Decoste m...@google.com wrote: I don't think I can do the save/restore trick in PlatformDeviceMac::LoadClippingRegionToCGContext(), because this a static method with no context... But I noticed that it is only called at one place, within

[chromium-dev] Re: [linux] green flashes in page content

2009-05-20 Thread Amanda Walker
The mac build does something like this: the background color of all the windows is actually magenta, which makes it very obvious when something's not getting painted or the process isn't responding to events. --Amanda 2009/5/20 Linus Upson li...@google.com: I think it would be great if I

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-22 Thread Amanda Walker
I'm pretty happy with it. It would be nice to polish things like the missing shadow, but that shouldn't stop us from landing it or adding it to GTM. --Amanda On Fri, May 22, 2009 at 10:16 AM, Avi Drissman a...@google.com wrote: On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai m...@chromium.org

[chromium-dev] Re: Mac History Menu Implementation

2009-05-22 Thread Amanda Walker
On Fri, May 22, 2009 at 7:22 PM, Robert Sesek rse...@gmail.com wrote: I think that Firefox's implemntation makes the most sense from a usability perspective. Those long menus in Safari are next to worthless if you have a decent-sized browsing history and really just clutter things up.

[chromium-dev] Re: Mac History Menu Implementation

2009-05-22 Thread Amanda Walker
On Sat, May 23, 2009 at 12:22 AM, Mark Larson (Google) m...@chromium.org wrote: Just so it's clear to me... why do we need a History menu? There's a link to history from the wrench menu/Ctrl+H and also from the New Tab page. The back button provides at least 12 entries from the back 

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Amanda Walker
On Tue, May 26, 2009 at 11:31 PM, Brett Wilson bre...@chromium.org wrote: Don't bother doing an assertion when the next line will crash anyway: DCHECK(foo); foo-DoSomething(); will normally crash pretty obviously dereferencing a NULL pointer (even though it will be inside DoSomething).

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Amanda Walker
On Wed, May 27, 2009 at 3:20 PM, Darin Fisher da...@chromium.org wrote: I think if we require everyone to handle every failed DCHECK, then what we will really do is compel people to write fewer DCHECKs, which means that we will lose some of the documentation benefits. That seems undesirable

[chromium-dev] Re: Where is the integration point betwee chromium and V8

2009-05-29 Thread Amanda Walker
Xcode can have problems properly setting breakpoints in subprojects. There are two ways to work around this: - Uncheck the Load *symbols lazily option in Xcode's debugging preferences.* - Open up the gdb console window and set breakpoints from the gdb command line --Amanda 2009/5/29 Lucius Fox

[chromium-dev] Re: Is there any way to profile chromium on MacOS?

2009-06-02 Thread Amanda Walker
TestShell does not use a separate renderer process. --Amanda On Tue, Jun 2, 2009 at 12:25 PM, Lucius Fox lucius.fo...@gmail.com wrote: I can build and debug TestShell project. But can you please tell me how to attach appropriate renderer with Shark? What is an appropriate renderer? On Mon,

[chromium-dev] Re: confused with chrome's version control

2009-06-02 Thread Amanda Walker
There is only one form of version control, which is the Subversion repository. For convenience, we provide a few alternatives to checking out a source tree from subversion and building it: tarballs: a tarball is a tar format archive of a complete source tree that has been checked out from the

[chromium-dev] Re: Does anyone have objections to adding a GetSwitchValues() accessor to CommandLine?

2009-06-02 Thread Amanda Walker
Would an iterator method on CommandLine serve the same purpose? It seems like that could work without having to make a copy... --Amanda On Wed, Jun 3, 2009 at 12:06 AM, Book'em Dano daniel.c...@gmail.com wrote: Does anyone have objections to including such a function? It would just return a

[chromium-dev] Re: RE : chrome's testing

2009-06-07 Thread Amanda Walker
Anyone ccould set one up for their own use, or even public use if they wanted to--the ones Google has set up are just a convenience provided to committers that may not have a machine of each platform available. --Amanda 2009/6/7 PhistucK phist...@gmail.com A Try Bot is a machine that gets sent

[chromium-dev] Re: RE : chrome's testing

2009-06-08 Thread Amanda Walker
It does not depend on scope. By default, every change that is uploaded by a committer for code review gets built on all three platforms by Google's try servers. --Amanda 2009/6/7 PhistucK phist...@gmail.com I forgot about the cross platform compiling stuff. I do not think every change is

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Amanda Walker
This is a great overview! Thanks for writing this up. I wonder if it's worth giving some more guidance about when to use #ifdef vs. say splitting out a couple of methods into a platform-specific file. For example: if you find yourself wrapping the entire body of a function in platform #ifdefs,

[chromium-dev] Re: How does chromium use SkCanvas

2009-06-28 Thread Amanda Walker
The Mac OS X port uses CoreGraphics to render page contents rather than Skia (it shares most of the rendering code with Apple's mac port, though Skia is used elsewhere in Mac Chrome for a variety of purposes). If you are trying to learn more about Skia, I would suggest trying the Linux version

[chromium-dev] Re: How does chromium use SkCanvas

2009-06-29 Thread Amanda Walker
Sorry for the typos--I'm still working on my first coffee of the day :-). On Mon, Jun 29, 2009 at 7:47 AM, Amanda Walkerama...@chromium.org wrote: There are no active plans at the moment, but it could be done if a strong reason to arose. to - to do so code charing with Apple. charing -

[chromium-dev] Re: 3.0.190.4 Dev Release Release Notes

2009-06-29 Thread Amanda Walker
3.0.190 is the current developer channel build. Its release notes are at http://dev.chromium.org/getting-involved/dev-channel/release-notes as usual. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives,

[chromium-dev] Re: Theme re-encoding

2009-07-10 Thread Amanda Walker
On Fri, Jul 10, 2009 at 3:54 PM, Avi Drissmana...@google.com wrote: Two things. First, this doesn't happen on Windows. Second, how do you get an image shifted one pixel to the right? On the Mac, ImageDecoder::Decode uses the webkit decoders which on the Mac return a CGImage, and then

[chromium-dev] Re: middle click on home

2009-07-13 Thread Amanda Walker
On Fri, Jun 26, 2009 at 8:22 PM, Peter Kastingpkast...@google.com wrote: Given that there are a large number of ways to open the home page in a new foreground tab (e.g. ctrl-t + click, shift-middle click, etc.), there are a very large number of other places in the UI where middle-click opens a

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
On Tue, Jul 14, 2009 at 3:40 AM, Adam Barthaba...@chromium.org wrote: Wow, there are even more on Mac: Expected to fail, but passed (39) If some of those are plugin related, it's because I didn't remember last night that the --enable-plugins flag I checked in didn't affect test shell, so many

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
On Tue, Jul 14, 2009 at 3:38 AM, Adam Barthaba...@chromium.org wrote: Expected to crash, but passed (9):  LayoutTests/fast/dom/offset-parent-positioned-and-inline.html  LayoutTests/fast/events/message-channel-gc-2.html  LayoutTests/fast/events/message-channel-gc-4.html  

  1   2   >