I'm trying to wrap my head around a design decision in x509_certificate.
The class provides two factory functions that keep a cache of certs. If a
cert is requested, and it's already in the cache, the cached version is
used.
But we also provide a destructor, which removes the cert from the
I was discussing this with Amanda last time I was in MTV, and the problem
with aio_* is that you can't use it asynchronously for opens and closes,
only for reads and writes. If we want to do async opens/closes in the API,
we have to do something else for them, and by that point there's no reason
I thought that was the original plan, waiting until traffic died down. I'm
good with it.
Avi
On Thu, Nov 6, 2008 at 5:33 PM, Evan Martin [EMAIL PROTECTED] wrote:
#chromium has almost no traffic and easily 90% of the traffic it does
have are developer questions.
I propose we kill off
I've experienced CFPlugins, and I've never figured out why they use a
COM-like system there. It adds a ton of complexity for no real benefit.
I can't speak for other platforms, but using COM on the Mac is not needed
when you have ObjC and its introspection capabilities. I don't see why a
The net_unittests started being flaky due to hitting a check in
message_pump_libevent:
[ RUN ] URLRequestTest.Post307RedirectPost
/b/pylibs/zope/__init__.py:19: UserWarning: Module zope was already
imported from /b/pylibs/zope/__init__.pyc, but
I'm looking at InternalPluginInfo in plugin_lib.h. Its first component is a
PluginVersionInfo, which is basically the Win32 version of the NPAPI data.
Right now my plugin info parsing code pulls info from either a plist (via
CFBundle) or resources, and neither is easy to reuse to parse a set of
be modified to return both the WebPluginInfo
the three function pointers (if it's an internal plugin). What do you
think?
On Tue, Jan 20, 2009 at 9:33 AM, Avi Drissman a...@google.com wrote:
I'm looking at InternalPluginInfo in plugin_lib.h. Its first component is
a PluginVersionInfo, which
capability once the chromium
extension framework is in place.
On Tue, Jan 20, 2009 at 2:29 PM, Avi Drissman a...@chromium.org wrote:
I'm trying to figure out a way to get away from PluginVersionInfo as it's
very Win32-centric.
BTW, what's the scenario that you have in mind that dynamic
I have the TabContents.nib, and the Mac tab_contents_controller.
Avi
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
brettw—
I'm trying to track down the meaning of GetPluginNativeView. Looking at the
code, it seems like the GTK people aren't sure either, so I've looped them
in (that's you, agl).
In RenderWidgetHostViewWin, the RenderWidgetHostViewWin object itself is the
view, and GetPluginNativeView seems to
http://www.corp.google.com/~avi/randompics/st.png
Avi
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
For those of you who aren't at Google, let me try again...
http://homepage.mac.com/avidrissman/extimgs/st.png
Avi
2009/2/12 Avi Drissman a...@google.com
http://www.corp.google.com/~avi/randompics/st.pnghttp://www.corp.google.com/%7Eavi/randompics/st.png
Avi
This isn't in a build. It's out for review and I'm hoping to land it Monday.
Avi
On Sat, Feb 14, 2009 at 5:55 PM, pete.stmarie pete.stma...@gmail.comwrote:
Which build is this?
Thanks,
--pete
On Feb 12, 5:42 pm, Avi Drissman a...@google.com wrote:
For those of you who aren't at Google
Today I checked in a ton of coordinate fixes to the views on the Mac to get
them to update and scroll properly. I noticed some problems with typing in
text fields and Evan pointed me to
http://groups.google.com/group/chromium-dev/browse_thread/thread/166010864dfdc637
Since the keyboard input
On Wed, Nov 12, 2008 at 7:28 PM, Darin Fisher da...@chromium.org wrote:
The intent was for WebKeyboardEvent to mirror PlatformKeyboardEvent such
that conversion between the two was a simple as copying fields directly.
The issue with this approach is that PlatformKeyboardEvent is not a simple
On Wed, Feb 18, 2009 at 11:22 AM, Darin Fisher da...@chromium.org wrote:
Notice that except for a bool, the rest are not part of the structure when
PLATFORM(CHROMIUM) is defined, so for us PlatformKeyboardEvent is platform
independent.
Yes, I just found PlatformKeyboardEventChromium.cpp.
On Wed, Feb 18, 2009 at 11:43 AM, Darin Fisher da...@chromium.org wrote:
We can extend WebKeyboardEvent if we need to, but what additional
information do you need?
Don't worry, I've got it now.
Avi
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
Grr. ViewMsg_HandleInputEvent is a real problem.
Today we bulk-copy raw bytes into the stream (see
RenderWidgetHost::ForwardInputEvent), and that's really not going to work.
What's the preferred approach? Do we create a factory on WebInputEvent so
that we can deserialize at the other end of the
On Thu, Feb 19, 2009 at 2:35 PM, Darin Fisher da...@chromium.org wrote:
std::vectorunsigned short text;
std::vectorunsigned short unmodified_text;
std::vectorunsigned short key_identifier;
Their equivalents, yes.
Is it really the case that those are unbounded in length? Or, is there
Some research (where I found
http://wilshipley.com/blog/2005_08_01_archive.html ) indicates that events
are basically one character. I think I'll cap it at, say, four, and
LOG(ERROR) if we get more than that.
Sound good?
Avi
On Thu, Feb 19, 2009 at 2:37 PM, Avi Drissman a...@google.com wrote
?
On Thu, Feb 19, 2009 at 2:46 PM, Avi Drissman a...@google.com wrote:
Some research (where I found
http://wilshipley.com/blog/2005_08_01_archive.html ) indicates that
events
are basically one character. I think I'll cap it at, say, four, and
LOG(ERROR) if we get more than that.
Sound good
If you never use the keyboard in Chromium, you can skip this email.
I'm going to land http://codereview.chromium.org/27056 which fixes most of
the glaring problems with keyboard support on the Mac by unifying and
streamlining key events for everyone. If things don't work for you, it's
probably my
This finally successfully landed in r10918 and r10919. Please let me know if
something comes up from this.
Avi
On Wed, Feb 25, 2009 at 2:15 PM, Avi Drissman a...@google.com wrote:
If you never use the keyboard in Chromium, you can skip this email.
I'm going to land http
The definition of what the accesskey modifier is the result of
EventHandler::accessKeyModifiers(). On Windows it's
althttp://trac.webkit.org/browser/trunk/WebCore/page/win/EventHandlerWin.cpp,
and on Chromium it's also
And when I build WebKit and run it in Safari, only ctrl+alt work. Weird. I'm
doing testing now to see what this fixes.
Avi
On Thu, Mar 5, 2009 at 4:38 PM, Avi Drissman a...@google.com wrote:
That value gets set in WebKit's WebFrame.mm:
if ([[NSApp
Working through crbug.com/8384 (copy/paste), I've had a chance to look at
Chromium's current copy/paste system.
For those unfamiliar, the copy/paste menu items are always enabled, and send
a message to TabContents. WebContents implements those methods by forwarding
them to RenderViewHost, which
, Evan Martin e...@chromium.org wrote:
On Mon, Mar 9, 2009 at 11:43 AM, Adam Barth aba...@chromium.org wrote:
On Mon, Mar 9, 2009 at 9:53 AM, Avi Drissman a...@google.com wrote:
For those unfamiliar, the copy/paste menu items are always enabled, and
send
a message to TabContents.
Do you
to get this state might not be that bad for the page menu.
Adam
On Mon, Mar 9, 2009 at 1:14 PM, Avi Drissman a...@google.com wrote:
Oh, that's curious. Where does the context menu come from? And how does
it
know?
Avi
On Mon, Mar 9, 2009 at 2:04 PM, Adam Barth aba...@google.com wrote
the mouse click -
display menu need to be synchronous? (In a way similar to how the
right-click - context menu is async now.)
Adam
On Mon, Mar 9, 2009 at 2:39 PM, Avi Drissman a...@google.com wrote:
An async menu might be an option for WinChromium but it isn't an option
for
the Mac
Now that the Clipboard change is in, I was about to land a quick, small
patch to turn on copy/paste, when I ran into an interesting problem. If you
copy something from the webpage you're viewing, and try to paste it into the
URL box, we die. In digging, I found out what's going on.
When we copy,
Walker awal...@google.com wrote:
For the URL field, I think that (1) is the best solution until we
replace it with a real omnibox, at which point things could get
complicated (since it'll need attributes for color etc. at the very
least).
--Amanda
On Wed, Mar 11, 2009 at 10:29 AM, Avi
Let's be precise here. The problem is when an NSAttributedString is
initialized with HTML. It's not a general NSAttributedString problem.
Avi
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email
differently for us, but conveniently named-mangled the same
so they link?
--Amanda
On Wed, Mar 11, 2009 at 10:49 AM, Mark Mentovai mmento...@google.com
wrote:
Avi Drissman wrote:
4. Figure out why system WebKit doesn't get along with our WebCore. I'm
not
sure where to start.
Obj-C
On Wed, Mar 11, 2009 at 10:55 AM, Mark Mentovai mmento...@google.comwrote:
Avi, do you think you can figure out if -[NSHTMLReader
_loadUsingWebKit] is at or near objc_msgSend, and who it's trying to
send to?
I sent a clip; here's the whole thing:
#0 0x901e8162 in WTF::HashTableint, int,
the price. But it might be a harder sell to
upstream.
Avi
On Wed, Mar 11, 2009 at 1:21 PM, Brett Wilson bre...@chromium.org wrote:
On Tue, Mar 10, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
I actually don't know. It seems like just simple state gathering but it
might be more
On Wed, Mar 11, 2009 at 2:07 PM, Brett Wilson bre...@chromium.org wrote:
Do you mean when you click on the menu, blocking the browser until the
renderer responds with whether the menus can be enabled? I would be
opposed to that.
Right, that would be bad for us. But for most users of WebCore,
I'm not trying to turn this into a huge deal. I've already filed a
bughttp://crbug.com/8662and am likely to move on for now. But for me
it's just another issue that
users are going to complain about that I'm going to need to fix someday.
Avi
/who bets the first complaint will be from a Mac user
OK, so there's this nifty SendWithTimeout on SyncChannel. Awesome. And
RenderViewHost just has to call it, just like it calls Send() today for
other calls.
This is where things are falling apart for me.
For Send(), RenderViewHost calls (via RWH) its Send(), which calls
RenderProcessHost's
window, and drop the pop out of the
main window behavior, or to special-case it when you move the mouse
over it but pop it back in if you start dragging the window. In any
case, what I have done (a popup window that appears topmost) is not
what I think we want.
On Thu, Mar 12, 2009 at 1:57 PM, Avi
Right. So the idea is a child window, borderless, with custom drawing.
Shouldn't be too hard, and I'm envisioning some use of Core Animation to do
things like the fading...
Avi
On Fri, Mar 13, 2009 at 9:17 AM, Amanda Walker ama...@chromium.org wrote:
On Fri, Mar 13, 2009 at 8:17 AM, Dean
Uh. Wow.
Wow.
+5 for awesome.
Avi
On Sun, Mar 15, 2009 at 9:54 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Hello!
A lot of people told me that they did not like the waterfall, mainly
because it's hard
to find out where and when a change is tested, and what the result is. (It
We've been seeing calls to ResourceMessageFilter::OnGet(Root)WindowRect for
NULL windows. agl put in a fix for GTK with
http://codereview.chromium.org/42356 and I'm seeing the same problem on the
Mac.
1. Why isn't Windows seeing this? What happens when you pass a null HWND
into ::GetAncestor and
a breakpoint in
OnGetRootWindowRect please and see if clicking on a link in an
email in gmail passes a HWND of null at all?
Thank you,
--Craig
On Thu, Mar 19, 2009 at 7:33 PM, Avi Drissman a...@google.com wrote:
We've been seeing calls to ResourceMessageFilter::OnGet(Root)WindowRect
http://codereview.chromium.org/47002
http://crbug.com/9060
Avi
On Fri, Mar 20, 2009 at 10:58 AM, Avi Drissman a...@google.com wrote:
I don't disagree with the statement you shouldn't let the renderer crash
the browser but I'm trying to understand if a null window ref is an
expected value
The term activatable, as seen in RenderWidgetHostViewWin, etc, is not
clearly defined. The only explanation I've found is:
Autocomplete popup windows for example cannot be activated.
Can someone provide a meaning? Does that mean that it can never become the
focus for keystrokes? I get a vague
Ah. Thanks.
Avi
On Fri, Mar 20, 2009 at 5:07 PM, Peter Kasting pkast...@google.com wrote:
On Fri, Mar 20, 2009 at 2:03 PM, Avi Drissman a...@google.com wrote:
The term activatable, as seen in RenderWidgetHostViewWin, etc, is not
clearly defined.
Windows has two concepts relating to focus
On Sun, Mar 22, 2009 at 5:10 PM, Adam Langley a...@chromium.org wrote:
struct s a = {0}; will initialise all members of the structure to zero.
Correct. The C++ Standard, §12.6.1 (Explicit initialization) paragraph 2
says:
When an aggregate (whether class or array) contains members of class
In re to http://codereview.chromium.org/48103/show:
I like where you went, but this leaves me in a tough spot. I was
implementing them in http://codereview.chromium.org/45040/show and now I'm a
bit stuck.
RWHV lives inside a view, and self-destructs when it's removed from the
view. Its lifetime
Oh! CreateNewWidgetInternal is virtual! That's... useful.
Avi
On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman a...@chromium.org wrote:
In re to http://codereview.chromium.org/48103/show:
I like where you went, but this leaves me in a tough spot. I was
implementing them in http
On Wed, Mar 25, 2009 at 2:02 PM, Avi Drissman a...@chromium.org wrote:
Oh! CreateNewWidgetInternal is virtual! That's... useful.
Avi
On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman a...@chromium.org wrote:
In re to http://codereview.chromium.org/48103/show:
I like where you went
Last week I complained about svn being slow on Windows, and Peter K (IIRC)
suggested that I keep my drive defragged. I did so, and things are now
zippy. Thanks!
If you use Windows, I'd highly recommend setting up a task to keep your
drive clean. Follow the instructions at
http://dev.chromium.org/developers/design-documents/ui-localizationdescribes
the process of adding a resource. It goes something like this:
1. Add the key to a .grd file
2. ???
3. Translations show up in .xtb files
I need to split an existing key, though (one that is actually two strings in
the
will just fall back to the English
translation in generated_resources.grd. The magic ids won't match anymore
since you changed the English string so everything will just default to the
English text.
On Tue, Apr 7, 2009 at 10:27 AM, Avi Drissman a...@chromium.org wrote:
I don't need
I'm still a little lost in this discussion. I'm repeatedly reading the code
and the patch, and I'll get back to you when I fully understand it. But what
I wanted to say is that there is a significant difference in the paint
pipeline as it currently exists on the Mac compared to Win/Lin.
On Win,
On Mon, Apr 13, 2009 at 12:13 PM, Darin Fisher da...@chromium.org wrote:
You need to change the Mac implementation to flush to the screen when
DidPaintRect is not called withing drawRect / GetBackingStore.
I'll put it on my list of things to do. (First is fixing a bug that is
causing drawing
Erik—
I don't understand why in http://codereview.chromium.org/17243 you defined
Extension() to have a leading dot. It's easier to add a dot than take one
off, and I don't understand why you insist on the equivalence you describe.
How is ensuring that you could append the string values of the
On Mon, Apr 27, 2009 at 11:21 AM, Evan Martin e...@chromium.org wrote:
That leaves process_util for Linux and Mac, which uses fuser (or
something similar) and that is a hack. However, it's only used for ui
tests, I believe -- it's not needed in normal usage.
The Mac uses ps -xw, but the
Having signed up for the login dialog, I'm seeing that it's a pretty
interesting subject. If you try out a page with HTTP auth, you'll see that
you get what looks like a dialog for the username and password. But if you
click around, you find that you can switch tabs, and that the dialog is
.
A Mac-style sheet would be consistent with other tab-related UI like
the find bar.
On Tue, May 5, 2009 at 2:40 PM, Avi Drissman a...@google.com wrote:
Having signed up for the login dialog, I'm seeing that it's a pretty
interesting subject. If you try out a page with HTTP auth, you'll see
. There's also some stuff Jeremy was
doing in Gears that involved doing interesting things with login
prompts that may (or may not) be relevant. It would certainly be nice
to keep things tab-modal, even though Cocoa doesn't really grok that
idea.
--Amanda
On Tue, May 5, 2009 at 5:40 PM, Avi
, and the behavior looks right. Nice
job! I vote for continuing with this approach.
--Amanda
On Thu, May 7, 2009 at 12:17 AM, Avi Drissman a...@google.com wrote:
OK, so attached is my proof of concept. The code is pretty clear, though
if
you have questions, please let me know.
+maf: Your
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
multisheet
disables x and - (there is no +, but I assume it'd be disabled too).
It shouldn't disable - and +.
I don't think I have control over that. I don't think that Cocoa's support
for child windows putting up sheets
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
Hit login, then play with Exposé. The show me my desktop function
leaves the sheet hanging; the show me my app's windows and show me
all windows functions send the sheet offscreen.
These are all fixed by the system in
, but icky where you own the code is preferable
to icky where you're having to reverse-engineer someone else's code.
-scott
On Fri, May 8, 2009 at 11:20 AM, Avi Drissman a...@google.com wrote:
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
Hit login, then play with Exposé
Thanks.
So I fiddled with the hiding sheets part, and now leave the sheet in place
but make it fully transparent. That helps a lot with some expose issues (and
all the ones still left are fixed in SL). That leaves the fact that the
shouldterminate delegate call is broken and that event handling
On Wed, May 13, 2009 at 2:27 PM, Avi Drissman a...@google.com wrote:
OK, so this was r15790. The code already exists to set the focus to the
location bar if it already had it, though.
Avi
On Wed, May 13, 2009 at 2:24 PM, Avi Drissman a...@google.com wrote:
I'm implementing save
OK, so this was
r15790http://src.chromium.org/viewvc/chrome?view=revrevision=15790.
The code already exists to set the focus to the location bar if it already
had it, though.
Avi
On Wed, May 13, 2009 at 2:24 PM, Avi Drissman a...@google.com wrote:
I'm implementing save/restore focus when
set a clip rect (on the canvas) to the invalidation
sub-rect.
- And then we call WebWidget::Paint() with the canvas and the
sub-rect.
Anything smells fishy in there?
BYE
MAD
On Thu, May 14, 2009 at 3:14 PM, Avi Drissman a...@chromium.org wrote:
We haven't
On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai m...@chromium.org wrote:
Avi and I found that the Exposé funkiness, present on his Leopard
machine and my Leopard laptop last week, is all of the sudden gone on
my Leopard laptop this week. The difference? 10.5.7, most likely.
Experimenting on
A visitor to IRC pointed me today to http://crbug.com/11319 , where
renderers are marked as not responding. He pointed out that this is not
just a cosmetic issue, since things like spindump run which kills
performance on non-quad core machines (that we all have).
I thought about just pumping
:54 AM, Avi Drissman a...@google.com wrote:
A visitor to IRC pointed me today to http://crbug.com/11319 , where
renderers are marked as not responding. He pointed out that this is
not
just a cosmetic issue, since things like spindump run which kills
performance on non-quad core machines
There is one message for forwarding any type of input event. Trace backwards
and forwards from RenderWidgetHost::ForwardInputEvent().
Avi
On Tue, Jun 2, 2009 at 3:48 PM, meryl silverburgh.me...@gmail.com wrote:
Hi,
I am reading the messaging between renderer and browser:
Very interesting writeup. Some thoughts:
You don't touch on how Safari on the Mac handles this case. It seems to
overlap with some of the work that Jeremy was doing based on his discoveries
in WebKit's WebHTMLView.mm. Where does its _interceptEditingKeyEvent get
called?
Synthesizing CHAR events
http://crbug.com/14609 ...
In the renderer we need to run Cocoa on a non-main thread. To pump
windowserver events we need to pump on the main thread. And when we do so
timers and notifications fire, screwing us over. I think the timers and
notifications were not fired before, right?
In the short
Core Graphics is a level lower than Cocoa, and as the main way to draw on
the Mac would be OK to use. I don't know what we use Cocoa for. I think
widget rendering but I could be wrong.
Avi
On Fri, Jun 19, 2009 at 10:58 AM, Evan Martin e...@chromium.org wrote:
On Fri, Jun 19, 2009 at 6:44 AM,
We re-encode the pngs in themes. Somewhere in the the process we break them;
we're encoding them off by one pixel, so that we have a vertical line on the
left, one pixel wide, that's transparent. It isn't obvious on Windows (but
it is there; look for it!) but it's glaringly obvious on the Mac. I'm
I'm building an extension with a jpg source. If it gets the column then it's
an encoder issue, else decoder issue. I'll let you know as soon as I find
out.
Avi
On Fri, Jul 10, 2009 at 12:18 PM, Glen Murphy g...@chromium.org wrote:
This may be a PNGEncoder/Decoder bounce issue, and I don't
Even with a jpg source we get column 0 invisible, so it's a PNG encoder
issue. In addition, in an imaged editor it looks like the image is shifted
over one pixel, not that the first column was overwritten.
Avi
On Fri, Jul 10, 2009 at 12:21 PM, Avi Drissman a...@google.com wrote:
I'm building
::CGImageToSkBitmap carefully. It does the
conversion by drawing the image into the bitmap...
Avi
On Fri, Jul 10, 2009 at 3:38 PM, Avi Drissman a...@google.com wrote:
Even with a jpg source we get column 0 invisible, so it's a PNG encoder
issue. In addition, in an imaged editor it looks like the image
Nailed: http://codereview.chromium.org/149473
Avi
On Fri, Jul 10, 2009 at 4:15 PM, Amanda Walker ama...@chromium.org wrote:
On Fri, Jul 10, 2009 at 3:54 PM, Avi Drissmana...@google.com wrote:
Two things. First, this doesn't happen on Windows. Second, how do you get
an
image shifted one
PNG is lossless, so we should be good there.
Avi
On Fri, Jul 10, 2009 at 4:30 PM, Aaron Boodman a...@chromium.org wrote:
On this same subject -- do we do any lossy compression in our png
encoding? I think we should *not*. Developers will be peeved if their
carefully compressed images come
I'm playing around fixing the rough edges of the Mac theme implementation
and I'm hitting areas where it doesn't seem to be implemented for any
platform.
First, you said that you were going to make it so that when you install one
theme it uninstalls all others. Is that coming soon?
I ask because
On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
First, you said that you were going to make it so that when you install
one theme it uninstalls all others. Is that coming soon?
I don't know
...@google.com wrote:
On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
First, you said that you were going to make it so that when you install
one theme it uninstalls all others. Is that coming soon?
I
http://code.google.com/p/chromium/issues/detail?id=17015 was the layout
failures from a merge, and I got assigned them because I'd checked in a
small Mac-only change. Turns out that many of them are due to the failure to
red-dotted-underline misspelled words and slight differences in the
selection
On Wed, Jul 29, 2009 at 11:52 AM, Mike Pinkerton pinker...@chromium.orgwrote:
Don't we farm out a separate process for favicon decoding? And for
theme image decoding as well?
There are two things done by the utility process. Unpacking of themes (not
just images but the unzipping of the
for more detail.
Avi
On Wed, Jul 29, 2009 at 12:00 PM, Avi Drissman a...@chromium.org wrote:
On Wed, Jul 29, 2009 at 11:52 AM, Mike Pinkerton
pinker...@chromium.orgwrote:
Don't we farm out a separate process for favicon decoding? And for
theme image decoding as well?
There are two
On Mon, Aug 10, 2009 at 7:46 AM, Mohamed Mansour m...@chromium.org wrote:
I have been told that once you installed a new theme, the old theme will
not be archived (stored on the system), so switching themes would be harder
when the CL comes in.
That isn't the case today; that may be the case
On Wed, Aug 12, 2009 at 9:41 AM, Meok meok...@gmail.com wrote:
I guess it shouldn't be
too hard then to pass that info onto the gallery page and keep
everything online.
I think that would be a bad idea even if it weren't too hard. What theme I'm
using is no one's business.
When I was
I've heard people proclaim the principle of being able to copy a profile
across systems as being a deciding factor for certain changes (e.g. the
history epoch change). However, it doesn't seem to be universally held or
obeyed, and I'm not sure to the extent to which it can be obeyed. So some
Then password management would also fall under the category of can't be
made portable and that's fine.
It's just that I've heard profile platform independence tossed around as
being a guiding principle and I was surprised that some people treated it as
so.
Avi
/who wonders how it fits into
On Wed, Aug 26, 2009 at 2:31 PM, Ben Goodger (Google) b...@chromium.orgwrote:
Note that even upgrading Windows OS from XP to Vista involves changing
paths:
c:\Documents and Settings - c:\Users
Do we ever write paths such as this?
Yes.
From my Preferences file on Windows:
id:
Grabowski j...@chromium.org wrote:
Use --gdb with test shell.
jrg
On Mon, Aug 31, 2009 at 2:38 PM, Avi Drissman a...@google.com wrote:
Quite a few of those issues are now moot...
Anyway, I'm trying to debug TestShell. I'm starting it with
--testshell-startup-dialog, and attaching, but GDB
, Avi Drissman a...@google.com wrote:
Aha! Thanks.
Does anyone remember poking at scrollbars? I'm only hitting scrollbar code
on the TestShell destructor, when we're loading about:blank to clear out
WebCore. I'm getting some metric calculation calls but no painting...
Still investigating
Actively tracing through DumpRenderTree in WebCore. Getting layout info and
pixels that show I'm in the right file, and the png has scrollbars. But I
can't get gdb to break on ScrollbarThemeMac::paint and putting everything
from Debugger() to asm(int3) as the first statement in it isn't catching.
And on behalf of many of the other Mac folks, I have to thank Mark for
tearing into the problem and doing a lot of detective and coding work to
make it happen. He's incredible, and that's why we keep him working on
infrastructure work rather than actual Chromium coding; we don't want to
embarrass
OK, here's a more interesting backtrace (bp on -[NSScroller
setKnobProportion:]:
#00x960957e1 in -[NSScroller setKnobProportion:]
#10x95fb0de3 in -[NSScrollView reflectScrolledClipView:]
#20x009a4aef in -[WebDynamicScrollBarsView(WebInternal)
reflectScrolledClipView:] at
Is that metrics for the layout rectangles or the pixels?
Avi
On Tue, Sep 8, 2009 at 2:57 PM, Evan Martin e...@chromium.org wrote:
On Tue, Sep 8, 2009 at 11:51 AM, Mark Mentovaim...@chromium.org wrote:
Avi Drissman wrote:
Screw #2: The actual scrollbar is drawn just a wee bit shorter. Cocoa
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep down that ends up in sseCGSFill8by1, which looks like it
sometimes scribbles off the end of some buffer. I have no idea what we could
be doing wrong
, 2009 at 12:27 PM, Avi Drissman a...@google.com wrote:
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep down that ends up in sseCGSFill8by1, which looks like
it
sometimes scribbles off
1 - 100 of 133 matches
Mail list logo
