Re: OpenGL and rendering to texture

2008-09-07 Thread Brett Wilson
3D rendering has come up. It is very challenging because or our architecture and the sandbox. The renderer can't have a HWND on the screen, for example, and OpenGL can't share rendering contexts between processes (on or off screen). (I heard the next version of DirectX might, but I'm not sure.)

[chromium-dev] Re: Embedded Browser Control Synopsis

2008-09-20 Thread Brett Wilson
On Sep 20, 2:22 pm, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi M-A, On Sat, Sep 20, 2008 at 1:50 PM, Marc-Antoine Ruel [EMAIL PROTECTED]wrote: Ok fine, I can't give you any guidance if your changes would be accepted, sorry. That seems interesting though and I'd be interested in

[chromium-dev] Re: Build problems on build 149.30

2008-10-31 Thread Brett Wilson
On Oct 31, 6:53 am, Lucila Sanjurjo [EMAIL PROTECTED] wrote: Thanks, I think maybe this version fails to compile. Last week I have synced to the last version of the code. This version seems to have an issue when pressing TAB key, it throws an access violation. void

[chromium-dev] Moving PlatformCanvas to webkit/

2008-11-17 Thread Brett Wilson
I've made changes to remove almost all of the base dependencies in the graphics layer. With a few exceptions, the only parts left are the uses of platform_canvas*, platform_device*, native_theme, and image_operations. There are tricky because they are extensively used in both webkit/port and

[chromium-dev] Re: Quick and dirty chrome embedding test

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 6:50 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi All, Is it safe to create (via Browser::Create*()) and/or access Browser object instances from multiple threads? In other words, I need to choose one of the following options: No, the entire UI of Chrome is

[chromium-dev] Re: Quick and dirty chrome embedding test

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 7:14 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi Brett, On Tue, Nov 18, 2008 at 9:56 AM, Brett Wilson [EMAIL PROTECTED] wrote: On Tue, Nov 18, 2008 at 6:50 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi All, Is it safe to create (via Browser

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Brett Wilson
I just broke the build again with more NativeImagePtr problems. Right now, this is making me feel much less like tolerating significant differences between our Mac Windows ports. Brett --~--~-~--~~~---~--~~ You received this message because you are subscribed to

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 10:44 AM, Amanda Walker [EMAIL PROTECTED] wrote: NativeImagePtr is a WebKit type, and is designed to be the platform's native representation. We're all still fighting hidden assumptions about what PLATFORM(XXX) flags mean. Skia and CG are graphics APIs, but webkit

[chromium-dev] Re: Moving PlatformCanvas to webkit/

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 11:02 AM, Amanda Walker [EMAIL PROTECTED] wrote: On Tue, Nov 18, 2008 at 1:54 PM, Brett Wilson [EMAIL PROTECTED] wrote: No matter what we do each platform should have its own font and form control rendering. I don't think unifying these has ever been on the table

[chromium-dev] Re: Quick and dirty chrome embedding test

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 11:19 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi Brett, On Tue, Nov 18, 2008 at 11:12 AM, Brett Wilson [EMAIL PROTECTED] wrote: On Tue, Nov 18, 2008 at 7:14 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi Brett, On Tue, Nov 18, 2008 at 9:56 AM

[chromium-dev] Re: Quick and dirty chrome embedding test

2008-11-18 Thread Brett Wilson
On Tue, Nov 18, 2008 at 11:59 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Hi Brett, On Tue, Nov 18, 2008 at 2:27 PM, Brett Wilson [EMAIL PROTECTED] wrote: On Tue, Nov 18, 2008 at 11:19 AM, Marshall Greenblatt [EMAIL PROTECTED] wrote: Thanks for your input, I think I understand now

[chromium-dev] Re: Public interest email

2008-12-02 Thread Brett Wilson
On Tue, Dec 2, 2008 at 6:07 PM, Ben Goodger (Google) [EMAIL PROTECTED] wrote: On a slightly related note, the Powerpuff Girls squeakbat has a leak and has deflated. Does anyone @Google have a bicycle repair kit? If so let me know and we will figure out how to repair it. I swear I don't know

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Brett Wilson
On Mon, Dec 8, 2008 at 7:50 PM, Peter Kasting [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 6:41 PM, Andrew Scherkus [EMAIL PROTECTED] wrote: Darin touched upon this, who said to document that std::string should refer to UTF-8 strings. How about: - CreateStringValue creates a

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Brett Wilson
On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus [EMAIL PROTECTED] wrote: Somewhat in line with the Google style guide, the overloaded CreateStringValue/GetString do accomplish the same thing (variant string type), just with different encodings. I did some partial implementations of #3 and as

[chromium-dev] Re: Bookmark Added! GUI redesign ideas

2008-12-09 Thread Brett Wilson
Hi Simon, Thanks for the thoughtful mocks. I like the overall feel of the more horizontal versions better for some reason. However, I also like having the Remove link in the upper right. I think of it somewhat like a close box for the bookmark, and I expect its placement to be in the same

[chromium-dev] Skia merge landing today

2008-12-12 Thread Brett Wilson
I'm planning on landing the Skia merge today. I have the trybots happy, but there will likely be fallout because we haven't gotten a new Skia drop for about 6 months. The main problem is that the antialiasing algorithm changed slightly (for the better, it seems) so image diffs need to be updated.

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Brett Wilson
On Mon, Dec 15, 2008 at 12:14 PM, Aaron Boodman a...@chromium.org wrote: It would be better if we could consult Google for spelling recommendations. It seems like I frequently misspell a word, get the red squiggly, get no recommendations from Chromium, then go to Google and it gets it exactly

[chromium-dev] Re: Default line ending CR LF, CR, or LF???

2008-12-29 Thread Brett Wilson
On Mon, Dec 29, 2008 at 8:01 PM, Daniel dpc...@hotmail.com wrote: What should be used for the default line endings? DOS (CR LF), MAC (CR) or UNIX (LF) style? I notice that most files seem to use UNIX (LF), but I want to make sure that this is the expected line endings format. You're right,

[chromium-dev] V8Bindings_prebuild slowness

2009-01-04 Thread Brett Wilson
I have been doing some build profiling over the weekend. When I run IncrediBuild, computing dependencies takes about 30 seconds. Then one CPU starts performing custom build step which is V8Bindings_prebuild. In parallel, most dependencies like ICU compile in the next minute. Then it hangs for 3

[chromium-dev] Re: V8Bindings_prebuild slowness

2009-01-04 Thread Brett Wilson
On Sun, Jan 4, 2009 at 11:28 AM, Mike Belshe mbel...@google.com wrote: It's been this way for a while; the good news is that it should only happen on initial build; subsequent builds don't regenerate the bindings. The problem is that I (and it seems like many other people) have learned that

[chromium-dev] Re: webkit/port is moving into third_party/WebKit/WebCore

2009-01-05 Thread Brett Wilson
On Mon, Jan 5, 2009 at 8:30 AM, Mike Pinkerton pinker...@chromium.org wrote: Awesome! Now that so much of our code is in the webkit tree, is there a (public) wiki page describing the steps necessary to make changes to anything within third_party/WebKit/WebCore? i.e, does everything have to

[chromium-dev] Re: Proposal: enforcing unit testing in gcl

2009-01-05 Thread Brett Wilson
I think this sounds like an excellent start. We can tweak it if we notice things not working properly. Brett On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote: We don't have very good unit test coverage (in the broad sense, including ui_tests, test_shell_tests, etc.) for our

[chromium-dev] Has your computer melted?

2009-01-05 Thread Brett Wilson
I just checked in a change to use /MP for all compiles, which is a secret undocumented flag that does parallel compiles within each project. Please let me know of your computer melts or becomes unusable during a compile. It should more efficiently use all of your CPUs when doing regular Visual

[chromium-dev] Re: Has your computer melted?

2009-01-06 Thread Brett Wilson
On Jan 5, 4:32 pm, Brett Wilson bre...@chromium.org wrote: I just checked in a change to use /MP for all compiles, which is a secret undocumented flag that does parallel compiles within each project. Please let me know of your computer melts or becomes unusable during a compile. It should

[chromium-dev] Re: Windows SDK Configuration Tool failure workaround

2009-01-08 Thread Brett Wilson
Thanks Yury, I added this to the build instructions page. Brett On Thu, Jan 8, 2009 at 8:33 AM, Yury Semikhatsky yury.semikhat...@gmail.com wrote: If Windows SDK Configuration Tool fails with message Windows SDK Version Selection Tool has encountered a problem and needs to close. We are

[chromium-dev] Re: how to hide navigate bar

2009-01-12 Thread Brett Wilson
On Mon, Jan 12, 2009 at 9:41 PM, if-ifone hello...@gmail.com wrote: it is known that popup browser with maxsize and no navigate bar can use script like below window.open('test.html','blank','fullscreen=1,toolbar=no,menubar=no,scrollbars=no,resizable=yes,location=no,status=no'); how ever

[chromium-dev] Re: fixing CommandLine

2009-01-14 Thread Brett Wilson
On Wed, Jan 14, 2009 at 6:22 PM, Evan Martin e...@chromium.org wrote: Our CommandLine class is very confusing -- it is not a class for working with command lines, but in fact a stealth singleton that wraps the command line used to start the process. Further, since it came from Windows, it

[chromium-dev] 2-day merges and the cleanup schedule

2009-01-15 Thread Brett Wilson
I'm currently doing a 2-day merge rotation.As part of this, various layout tests are regressing or getting added that I'm inserting into the tests_fixable list. But, like every other layout test fixer, after my merges are done, I'll finally go back to my old work and not think about it any more.

[chromium-dev] Re: 2-day merges and the cleanup schedule

2009-01-15 Thread Brett Wilson
On Thu, Jan 15, 2009 at 1:20 PM, Pam Greene p...@chromium.org wrote: When fixing layout tests only means re-baselining, that's easy. But sometimes they break (or new ones fail) for deeper reasons, and the person doing the merge may not be the right one to make the fix (or may not be able to

[chromium-dev] Re: Making sense of startup

2009-01-15 Thread Brett Wilson
On Thu, Jan 15, 2009 at 1:19 PM, Amanda Walker ama...@chromium.org wrote: That's true. In the example I gave (Mac driver loading), each module has a property list that lists its dependencies (and version requirements, etc.). That's not quite as simple to do inside a single application, of

[chromium-dev] Re: Layout test and font stroking issue - help wanted

2009-01-16 Thread Brett Wilson
On Fri, Jan 16, 2009 at 9:32 AM, Sverrir Á. Berg sver...@google.com wrote: I'm running these tests: http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking-decorations.html http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking.html It seems that our font

[chromium-dev] Responsibility reviewing patches with multiple reviewers

2009-01-27 Thread Brett Wilson
There are a lot of patches lately with a lot of reviewers on them, especially related to porting since a lot of people might need to be in the loop for some changes. The problem is that there's no clear responsibility given in these reviews. If I'm the sole reviewer on a change, I know I have to

[chromium-dev] Re: build problem (chromium.r9040.tar.gz)

2009-02-03 Thread Brett Wilson
On Tue, Feb 3, 2009 at 9:05 PM, t...@chromium.org wrote: What evan means is that after downloading the tar ball, you need to run gclient sync to get all the platform specific dependencies. We recently started generating the source tar ball on a regular basis and it doesn't include all the

[chromium-dev] Re: hash_maps, hash functions and gcc

2009-02-04 Thread Brett Wilson
2009/2/4 Paweł Hajdan Jr. phajdan...@chromium.org: I recently tried to port chrome/browser/safe_browsing/protocol_manager.cc to Linux, but there's one problem. ProtocolManager uses hash_map of URLFetcher*-s, and GCC needs a hash function for it. I see many ways we can deal with that, and I

[chromium-dev] Re: [linux] stracing chrome binaries

2009-02-04 Thread Brett Wilson
On Wed, Feb 4, 2009 at 2:58 PM, Adam Langley a...@chromium.org wrote: If you've ever tried running strace on our binaries, you've probably noticed the Ubuntu version messes up a lot because it cannot decode the 32-bit structures correctly. For example: [pid 21205] ... recvmsg resumed

[chromium-dev] Re: How many GDI handles are reasonable?

2009-02-05 Thread Brett Wilson
On Thu, Feb 5, 2009 at 9:29 PM, Ian Fette i...@chromium.org wrote: Once again, my laptop is refusing to stand by and Windows is throwing up warning dialogs about Insufficient system resources exist to complete the API. Currently Chrome is sucking down a healthy 1043 gdi handles according to

[chromium-dev] Re: Is there a scroll bar?

2009-02-17 Thread Brett Wilson
On Tue, Feb 17, 2009 at 3:43 PM, Marc-Andre Decoste m...@google.com wrote: Salut, I'm looking for a way to know, at the BrowserView (or even at the RenderWidgetHostViewWin) level, if there is one, and only one scroll bar visible. I thought I could ask Windows with ::GetScrollBarInfo, but

[chromium-dev] Re: checked in file third_party/libxml/win32/include/xmlversion.h [Attn: Daniel Veillard]

2009-02-26 Thread Brett Wilson
On Thu, Feb 26, 2009 at 7:59 PM, eager_learner vijay.sankar.ra...@gmail.com wrote: Hello I am trying to integrate test a third party library available in source into the Visual Studio 2008 Pro environment. The problem seems to be that the  third_party/libxml/win32/include/xmlversion.h file

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Brett Wilson
On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote: On the Mac, code like this: namespace { class MyTest : public testing::Test { }; }  // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: ‘MyTest_ATest_Test’ has a field

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Brett Wilson
On Tue, Mar 3, 2009 at 4:49 PM, William Chan (陈智昌) willc...@chromium.org wrote: My old team never really used FRIEND_TEST. We found it ugly that our production code depended on test code. We typically used friended Peer classes defined in the unittest file, but not in the anonymous

[chromium-dev] Re: Thoughts on copy/paste

2009-03-11 Thread Brett Wilson
On Tue, Mar 10, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote: I actually don't know. It seems like just simple state gathering but it might be more. The big concern is that it fits our model but no one else's. Everyone else is OK with the UI asking the renderer questions directly, and

[chromium-dev] Re: Thoughts on copy/paste

2009-03-11 Thread Brett Wilson
On Wed, Mar 11, 2009 at 10:01 AM, Avi Drissman a...@google.com wrote: Most platforms (meaning not Chrome) have the ability, when the user pulls down a menu, to adjust the states of the menu items within. For them, when the user selects the Edit menu, they're OK calling into WebCore and asking

[chromium-dev] Re: Thoughts on copy/paste

2009-03-11 Thread Brett Wilson
On Wed, Mar 11, 2009 at 10:11 AM, Amanda Walker ama...@chromium.org wrote: On Wed, Mar 11, 2009 at 2:07 PM, Brett Wilson bre...@chromium.org wrote: Do you mean when you click on the menu, blocking the browser until the renderer responds with whether the menus can be enabled? I would

[chromium-dev] Re: Doing some research with views and GTK.

2009-03-15 Thread Brett Wilson
On Sun, Mar 15, 2009 at 7:37 AM, Dean McNamee de...@chromium.org wrote: I had a discussion about Views with Scott.  I think I am on the side of the fence that porting views it not a good idea.  One of the things that came up is remote X, would it be possible to ever have good remote X

[chromium-dev] Re: Doing some research with views and GTK.

2009-03-15 Thread Brett Wilson
On Sun, Mar 15, 2009 at 10:09 AM, Adam Langley a...@chromium.org wrote: On Sun, Mar 15, 2009 at 8:55 AM, Dean McNamee de...@chromium.org wrote: UI elements like buttons are different, my understanding is that (at least in theory) it should be possible for all of those images of the different

[chromium-dev] Re: rev 11763 removes frame pointer from ResourceRequest

2009-03-16 Thread Brett Wilson
On Mon, Mar 16, 2009 at 4:25 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: My needs in this case are related to the Chromium Embedded Framework (CEF). The code currently works as follows: 1. Retrieve our custom WebViewDelegate instance pointer via the WebFrame pointer passed to

[chromium-dev] Re: Omnibox q around Mac+Chromium best-practices.

2009-03-19 Thread Brett Wilson
I would do the thin Objective C mode, partially since all Chrome developers know C++. I could debug that code or make changes to it if I was doing something that affected it, but I would have a much harder time with Objective-C. Brett On Thu, Mar 19, 2009 at 4:00 PM, Scott Hess

[chromium-dev] Re: Including Droid font in Chrome?

2009-03-25 Thread Brett Wilson
On Wed, Mar 25, 2009 at 10:16 AM, Alex Russell slightly...@google.com wrote: MSFT did a new set of fonts to take specific advantage of ClearType: http://www.microsoft.com/typography/ClearTypeFonts.mspx The Core Fonts are still available and installed by default on all windows versions that

[chromium-dev] Re: ScrollBar Implementation

2009-03-25 Thread Brett Wilson
As Peter said, the ScrollBar object is not responsible for drawing scroll bars on pages, which is what the bug is about. Brett On Wed, Mar 25, 2009 at 1:15 PM, Mohamed Mansour m0.interact...@gmail.com wrote: There is no context menu for the ScrollBar. -m0 On Wed, Mar 25, 2009 at 3:55

[chromium-dev] Re: Should all automatable browser APIs have per-object unique IDs?

2009-03-26 Thread Brett Wilson
On Thu, Mar 26, 2009 at 9:41 AM, Aaron Boodman a...@chromium.org wrote: I'm starting to dig into implementing the tab and window API as a first example of all the other browser-automation type APIs we eventually want to implement for extensions. One of my early assumptions was that the APIs

[chromium-dev] Re: Should all automatable browser APIs have per-object unique IDs?

2009-03-26 Thread Brett Wilson
On Thu, Mar 26, 2009 at 10:09 AM, Aaron Boodman a...@chromium.org wrote: On Thu, Mar 26, 2009 at 9:52 AM, Brett Wilson bre...@chromium.org wrote: What would IDs refer to in history? I've only barely looked into the history data model, but I was hoping it would be a persistent ID for each

[chromium-dev] Re: Should all automatable browser APIs have per-object unique IDs?

2009-03-26 Thread Brett Wilson
On Thu, Mar 26, 2009 at 11:37 AM, Aaron Boodman a...@chromium.org wrote: On Thu, Mar 26, 2009 at 11:22 AM, Brett Wilson bre...@chromium.org wrote: Those are exposed, but I wonder which cases an extension needs to refer to them. They are internal IDs generated by sqlite. If you clear your

[chromium-dev] Re: Sandbox Interception Design

2009-03-27 Thread Brett Wilson
On Fri, Mar 27, 2009 at 1:50 PM, Book'em Dano daniel.c...@gmail.com wrote: At the top of sandbox\src\interception.h, it refers the reader to: http://wiki/Main/ChromeSandboxInterceptionDesign. Does anyone know where this document can be found? The sandbox info on

[chromium-dev] Re: How to fix check deps failure?

2009-03-30 Thread Brett Wilson
On Mon, Mar 30, 2009 at 10:12 AM, Jian Li jia...@chromium.org wrote: I got another failure for checkdeps: ERROR in C:/b/slave/chromium-rel-builder/build/src\chrome\test\worker\test_webworker.cc Illegal include: webkit/tools/test_shell/test_webworker_helper.h     Because of -webkit from

[chromium-dev] Re: [Extensions] New API specs: bookmarks, history, downloads

2009-04-09 Thread Brett Wilson
On Wed, Apr 8, 2009 at 7:48 PM, Nick Baum nickb...@chromium.org wrote: Hi all, I fleshed out a few more APIs. I've put them in separate documents since the API pattern doc was getting a bit long. Below are some notes, feedback appreciated. In particular, I'd love feedback from Scott on

[chromium-dev] Re: [linux] GTK and multi-threading

2009-04-10 Thread Brett Wilson
On Fri, Apr 10, 2009 at 12:42 PM, Evan Stade est...@chromium.org wrote: a) wrap the clipboard calls in gtk_threads_{enter,leave}(). This makes the calls thread safe, but it does so by locking a process-wide mutex, which will block our UI thread's main loop. I personally think this is OK.

[chromium-dev] Re: question on profiles ChromeThread

2009-04-13 Thread Brett Wilson
On Mon, Apr 13, 2009 at 11:01 AM, Tim Steele t...@chromium.org wrote: I don't know of a reason we need more than 1 history thread, but I can't say for sure. HistoryService is responsible today for starting/stopping/destroying the history thread, so if we have multiple services then we need

[chromium-dev] WebContents is dead, long live TabContents!

2009-04-24 Thread Brett Wilson
I just moved the remaining methods from WebContents to TabContents. I kept the methods and data members the same, just merged the classes, so it should be easy to find what you're looking for (or to resolve conflicts if you have local changes to web_contents.cc). Hopefully this will make the

[chromium-dev] Re: DO NOT ADD DEPENDENCIES FROM CHROME/VIEWS on CHROME/COMMON

2009-04-24 Thread Brett Wilson
On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman a...@chromium.org wrote: Is it possible to enforce these rules with code rather than capital letters? I don't think I've made this particular error, but it's something I could see myself doing. From their names, chrome/common seems like a

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-27 Thread Brett Wilson
On Mon, Apr 27, 2009 at 8:05 AM, Mike Pinkerton pinker...@chromium.org wrote: On Sun, Apr 26, 2009 at 5:50 PM, Amanda Walker ama...@chromium.org wrote: Application startup is one of the areas where we count every millisecond, and try to touch the disk as little as possible.  I don't think

[chromium-dev] Re: unforking: 20% perf hit for international page cycler expected soon

2009-05-01 Thread Brett Wilson
On Sat, May 2, 2009 at 6:09 AM, Evan Martin e...@chromium.org wrote: The suggestions on that code review are good: we ought to measure how many fonts normal users see, and then pick the cache tuning parameter accordingly. Adam Barth is a good person to ask about how to do this, since he

[chromium-dev] Re: Why are pref keys wchar_t's?

2009-05-01 Thread Brett Wilson
2009/5/1 Mohamed Mansour m0.interact...@gmail.com: Why wouldn't we just use std::string ? Many places in the code uses std::string. DictionaryValue needs to be converted as well as many others. So what do we finally decide, go what Pink stated and use char* or use std::string. I believe the

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Brett Wilson
On Wed, May 6, 2009 at 8:40 AM, Andrew Scherkus scher...@chromium.org wrote: WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in a GraphicsContext: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-06 Thread Brett Wilson
2009/5/6 Andrew Scherkus scher...@chromium.org: On Tue, May 5, 2009 at 9:49 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: On Tue, May 5, 2009 at 9:38 PM, Amanda Walker ama...@chromium.org wrote: Ah, I see. Hmm, going in that direction (from a GraphicsContext back up to the

[chromium-dev] Re: Skia is moving

2009-05-12 Thread Brett Wilson
On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain nsylv...@chromium.org wrote: On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org wrote: I'm in the process of updating chromium to use tip-of-tree skia, and in the same CL, moving skia to a third_party directory, retrieved

[chromium-dev] Re: Skia is moving

2009-05-13 Thread Brett Wilson
On Wed, May 13, 2009 at 12:39 PM, Darin Fisher da...@chromium.org wrote: That is what I meant by pain It only applies to third party code that conforms to the google style guide, which says that all include paths must be relative to the root.  Come to think of it, I think this could cause

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Brett Wilson
On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote: Perhaps what we need is a companion to FilePath.  For example: FilePath: much as it is now, lightweight, alternative to string manipulation. FileReference: heavierweight, can talk to the file system and have carnal

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Brett Wilson
On Wed, May 13, 2009 at 4:34 PM, Amanda Walker ama...@chromium.org wrote: On Wed, May 13, 2009 at 7:07 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote: Perhaps what we need is a companion to FilePath.  For example

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Brett Wilson
On Wed, May 13, 2009 at 6:12 PM, Greg Spencer gspen...@google.com wrote: On Wed, May 13, 2009 at 4:07 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote: Perhaps what we need is a companion to FilePath.  For example

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Brett Wilson
On Wed, May 13, 2009 at 7:24 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 6:12 PM, Greg Spencer gspen...@google.com wrote: On Wed, May 13, 2009 at 4:07 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Brett Wilson
On Wed, May 27, 2009 at 11:56 AM, Amanda Walker ama...@chromium.org wrote: On Tue, May 26, 2009 at 11:31 PM, Brett Wilson bre...@chromium.org wrote: Don't bother doing an assertion when the next line will crash anyway:  DCHECK(foo);  foo-DoSomething(); will normally crash pretty obviously

[chromium-dev] Clobber if you get V8 linker errors in the next sync

2009-05-29 Thread Brett Wilson
When I landed the WebKIt integration this morning a bunch of the bots needed clobbering due to linker errors. The errors were missing V8 handles while linking generate_profile. I haven't seen any of the commonly-compiled projects fail because of this, so it's possible you don't have to clobber

[chromium-dev] Re: Question about chromium architecture

2009-06-02 Thread Brett Wilson
On Tue, Jun 2, 2009 at 4:57 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: I am reading this document http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code; about chromium source code: It said: renderer: Code for the subprocess in each tab. This embeds

[chromium-dev] Re: [extensions] Gleam API proposal

2009-06-03 Thread Brett Wilson
On Wed, Jun 3, 2009 at 1:00 PM, Aaron Boodman a...@chromium.org wrote: [I actually created this awhile ago, but never sent it 'round] It is really common for extensions to want to offer additional contextual options for content elements. For example Download this movie, edit this image,

[chromium-dev] Re: Question about BrowserRenderProcessHost::OnPageContents() method

2009-06-07 Thread Brett Wilson
On Sat, Jun 6, 2009 at 11:13 PM, meryl silverburgh.me...@gmail.com wrote: Hi, I add debug print status in  BrowserRenderProcessHost::OnPageContents () to print out the value of 'contents' void BrowserRenderProcessHost::OnPageContents(const GURL url,                                      

[chromium-dev] Mac painting problems

2009-06-14 Thread Brett Wilson
I was informed that I may have broken mac tab contents painting in 18363. I have to leave now, so if this is causing you problems you can back me out. If somebody wants to fix it instead, I'll make you chocolate chip cookies :) Brett --~--~-~--~~~---~--~~

[chromium-dev] Re: How Render process send Image IO request to Browser process

2009-06-16 Thread Brett Wilson
There are a surprising number of comic characters on here. I bet you know Meryl Silverburgh! Generally this type of thing is on the dev site like here: http://dev.chromium.org/developers/design-documents/multi-process-resource-loading Brett --~--~-~--~~~---~--~~

[chromium-dev] Conventions and patterns for multi-platform development

2009-06-19 Thread Brett Wilson
Our team has had somewhat of an ad-hoc approach to organizing code that's different across platforms. In many cases our approach has been quite good. In others, less so, and there have also been questions about what the preferred method for writing a certain component in a cross-platform way.

[chromium-dev] Re: Icelandic dictionary for Chrome

2009-06-19 Thread Brett Wilson
On Fri, Jun 19, 2009 at 1:15 PM, Sverrir Á. Bergsver...@chromium.org wrote: I'm hoping to be able to add Icelandic spelling check to Chrome  Before I invest a lot of time I have some quick questions/observations: I found an myspell/aspell dictionary for Open Office here: 

[chromium-dev] Re: About hunspell

2009-07-03 Thread Brett Wilson
On Fri, Jul 3, 2009 at 12:00 AM, Dmitry.Skibadmitry.sk...@gmail.com wrote: Recently I was playing with hunspell and got very displeased with its code (which claims to be cpp, but in fact 'classified' c). I even started to think about rewriting it in, you know, correct cpp. Then I realized

[chromium-dev] Re: Watchlist matching any part of a path

2009-07-07 Thread Brett Wilson
On Tue, Jul 7, 2009 at 6:20 PM, Andrew Scherkusscher...@google.com wrote: According to the watchlist file, brettw is watching base from /src kylep sent me a code review that only modifies touches files in /src/media/base, however brettw got added to the cc list. Is this intended behavior for

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an empty string and a null string. In string16, however, there is no such thing as null. The LocalStorage implementation I'm working on proxies data

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote

[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!

2009-07-21 Thread Brett Wilson
On Tue, Jul 21, 2009 at 8:42 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Can we have a trybot with that configuration, which would just compile the code? I think it would really save people's time. I never

[chromium-dev] Re: [linux] Using system libraries for Chromium

2009-07-22 Thread Brett Wilson
On Wed, Jul 22, 2009 at 2:58 PM, Adam Langleya...@chromium.org wrote: On Wed, Jul 22, 2009 at 9:50 PM, Darin Fisherda...@google.com wrote: Personally, I much prefer the #include png.h approach.  Is it a problem to wait for the GYP change that makes this possible? Well, I could make it

[chromium-dev] Re: WebContents class in chromium?

2009-07-25 Thread Brett Wilson
On Sat, Jul 25, 2009 at 4:27 PM, n179911n179...@gmail.com wrote: Hi, For http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code, it said For web content, this specialization is WebContents in chrome/browser/web_contents.cc. There are also a few other types for

[chromium-dev] How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Brett Wilson
I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-02 Thread Brett Wilson
On Sat, Aug 1, 2009 at 4:34 PM, Dan Kegeld...@kegel.com wrote: I suppose you could try running the hunspell test suite itself under valgrind.  Their README tells how to do it, but when I tried, I couldn't get it to work.  (Wonder if that means they haven't run it, either?) Hi Dan, Purify

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-08-03 Thread Brett Wilson
On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhalkuch...@chromium.org wrote: I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? One problem with this is that it doesn't fix the case where people respond to the review mail via

[chromium-dev] Re: Do we have any existing code for reading/writing INI files?

2009-08-10 Thread Brett Wilson
On Mon, Aug 10, 2009 at 3:28 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Just wondering if there's any code kicking around somewhere in the codebase for reading/writing INI files? No, we don't deal with ini files at all to my knowledge. We use JSON for that type of thing. What do you need it

[chromium-dev] Re: Mac History Menu

2009-08-12 Thread Brett Wilson
On Wed, Aug 12, 2009 at 11:15 AM, Robert Sesekrse...@gmail.com wrote: Two things about the Mac history menu that I'd like people to weigh in on: 1. The Show All History command should have a keyboard shortcut. We can't use the logical Cmd+H because it's bound by the system. Stuart suggested

[chromium-dev] Re: Mac History Menu

2009-08-12 Thread Brett Wilson
On Wed, Aug 12, 2009 at 12:18 PM, Avi Drissmana...@chromium.org wrote: Brett— Are we talking about the history page, or history items? The history page gets its own tab, sure. But when someone picks an item from the history menu, where does it go? I think current foreground tab is right,

[chromium-dev] Re: RenderView page ID

2009-08-17 Thread Brett Wilson
On Mon, Aug 17, 2009 at 2:59 PM, Evan Stadeest...@chromium.org wrote: I believe Brett meant to say chrome/renderer/render_{view,widget}.{h,cc} They're both correct, depending on whether you want the browser or the renderer. Brett --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: browser/sync is moving in

2009-08-18 Thread Brett Wilson
On Mon, Aug 17, 2009 at 11:19 PM, estelectronix...@gmail.com wrote: Thanks for the explaination, Nick Carter. I understand now, Chrome is a Google product while Chromium is a open- source project. Any thing else differs between Google Chrome and Chromium? I found dictionaries missing from

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-19 Thread Brett Wilson
On Wed, Aug 19, 2009 at 1:23 PM, Darin Fisherda...@chromium.org wrote: On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin e...@chromium.org wrote: Rad that you're doing this! I think that we shouldn't have any linux-specific directories except for one or two cases where it's *really*

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-19 Thread Brett Wilson
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote: I kinda feel like this is one of those things you can try hard to premeditate, but in the end you'll just have to deal with it being ugly for a while and hope it eventually converges to something better. The changes in

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-19 Thread Brett Wilson
On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote: On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote: I kinda feel like this is one of those things you can try hard to premeditate, but in the end you'll just have to deal with it being ugly for a while

[chromium-dev] Re: private VM field on the about:memory page

2009-08-24 Thread Brett Wilson
On Mon, Aug 24, 2009 at 6:18 AM, Anand Mistryakmis...@gmail.com wrote: I'm looking at the about:memory page and am wondering how useful is the private VM field?  Would it be just as good to have a total VM instead?  The reason I ask is because private VM doesn't map easily to Linux where

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-24 Thread Brett Wilson
On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks. But the picture in the document shows there is only 1 ResourceDispatcherHost and there are 2 Renderer Processes: http://dev.chromium.org/developers/design-documents/multi-process-architecture And the

[chromium-dev] Linux/Mac time epoch change

2009-08-25 Thread Brett Wilson
I just checked in r24417 which changes the 0 for times on Mac Linux (used to mean 1970) to match Windows (1601). This means that the profiles can be copied between systems without getting the dates all wrong, and should also fix some bugs related to cookie expiration (

  1   2   >