[GitHub] [calcite] danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291459410 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291450264 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291450264 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

danny0405 commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291450264 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java

[GitHub] [calcite] zabetak commented on issue #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet

zabetak commented on issue #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet URL: https://github.com/apache/calcite/pull/1257#issuecomment-499694703 Good work @wenhuitang, just a few minor things that may be worth considering!

[calcite] branch master updated: [CALCITE-3116] Upgrade to Avatica 1.15

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 614b435 [CALCITE-3116] Upgrade to Avatica

[GitHub] [calcite] zabetak merged pull request #1259: [CALCITE-3116] Upgrade to Avatica 1.15

zabetak merged pull request #1259: [CALCITE-3116] Upgrade to Avatica 1.15 URL: https://github.com/apache/calcite/pull/1259 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] zabetak commented on a change in pull request #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet

zabetak commented on a change in pull request #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet URL: https://github.com/apache/calcite/pull/1257#discussion_r291398786 ## File path:

[GitHub] [calcite] MGelbana commented on issue #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on issue #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#issuecomment-499622777 Obviously this is not a bug. I closed the Jira issue and will consider opening a new one to fix the returned column

[GitHub] [calcite] MGelbana closed pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana closed pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r291322552 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r290965310 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r291316986 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] julianhyde commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

julianhyde commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r291313144 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r291311863 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type URL: https://github.com/apache/calcite/pull/1250#discussion_r291311863 ## File path: babel/src/main/codegen/config.fmpp ## @@ -833,6 +835,7 @@ data: {

[GitHub] [calcite] siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-499591769 Build is passing. @zabetak , @laurentgo , please take a look when you have some time.

[GitHub] [calcite] hbtoo opened a new pull request #1260: fix VolcanoRuleCall match parent child ordinal check

hbtoo opened a new pull request #1260: fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260 This PR fixes the bug described in https://issues.apache.org/jira/browse/CALCITE-3118, where VolcanoRuleCall match parent child ordinal is not

[GitHub] [calcite] zhztheplayer commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

zhztheplayer commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#issuecomment-499569622 Let's continue the discussion in JIRA - https://issues.apache.org/jira/browse/CALCITE-3073 (since it becomes a

[GitHub] [calcite] zhztheplayer commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

zhztheplayer commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#issuecomment-499566650 @XuMingmin - Thanks for the comments. Just out of curiosity (If I get your point correctly), how does the

[GitHub] [calcite] zhztheplayer commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

zhztheplayer commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#issuecomment-499560202 Thanks @walterddr and @michaelmior, I think it's good to go. A minor suggestion - as parser might go into conflict

[GitHub] [calcite] wangzzu commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#issuecomment-499540698 @XuMingmin I understand what you're saying, but I'm not sure is a good idea. Just add a special reserved

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291224924 ## File path: kafka/src/test/java/org/apache/calcite/adapter/kafka/KafkaMockConsumer.java

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291222356 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291221196 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] asereda-gs commented on issue #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and From_Base64 to SqlFunctions

asereda-gs commented on issue #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and From_Base64 to SqlFunctions URL: https://github.com/apache/calcite/pull/800#issuecomment-499524343 @wenhuitang I will check over week-end

[GitHub] [calcite] danny0405 commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

danny0405 commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291212894 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] asereda-gs commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

asereda-gs commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#issuecomment-499519443 @XuMingmin I will check this PR over the week-end

[GitHub] [calcite] XuMingmin commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

XuMingmin commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#issuecomment-499517717 @wangzzu thanks to prepare it quickly, the implementation is a bit different from my thought. FYI my idea,

[GitHub] [calcite] zabetak opened a new pull request #1259: [CALCITE-3116] Upgrade to Avatica 1.15

zabetak opened a new pull request #1259: [CALCITE-3116] Upgrade to Avatica 1.15 URL: https://github.com/apache/calcite/pull/1259 Remove bug for CALCITE-2776 which was fixed in Avatica 1.15. Remove bug for CALCITE-2993 which is fixed in Calcite but forgotten.

[GitHub] [calcite] DonnyZone opened a new pull request #1258: [CALCITE-3088] Multi-groupsets query failed due to data type preservation check

DonnyZone opened a new pull request #1258: [CALCITE-3088] Multi-groupsets query failed due to data type preservation check URL: https://github.com/apache/calcite/pull/1258 The issue is described in [CALCITE-3088](https://issues.apache.org/jira/browse/CALCITE-3088). This kind of query

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291164768 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291169304 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

zhztheplayer commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291171091 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291148469 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

danny0405 commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291146540 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] wenhuitang opened a new pull request #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet

wenhuitang opened a new pull request #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet URL: https://github.com/apache/calcite/pull/1257 https://issues.apache.org/jira/browse/CALCITE-3115

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291071051 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/JoinType.java ## @@ -0,0 +1,89 @@

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291074003 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ## @@ -167,19

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291071652 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ## @@ -152,7 +153,7

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291071051 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/JoinType.java ## @@ -0,0 +1,89 @@

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291069724 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291069724 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291063415 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291063188 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291062424 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

wangzzu commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291062424 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291051071 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ## @@ -152,7 +153,7

[GitHub] [calcite] zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291056322 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/JoinType.java ## @@ -0,0 +1,89 @@ +/*

[GitHub] [calcite] zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291052205 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ## @@ -167,19

[GitHub] [calcite] zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

zabetak commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291058383 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291053231 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291054743 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

danny0405 commented on a change in pull request #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter URL: https://github.com/apache/calcite/pull/1253#discussion_r291054279 ## File path: kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java