Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512341308 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +117,70 @@ public void testGeneralUseSimulation()

[PR] Update Kubernetes doc for Helm Chart (druid)

2024-03-05 Thread via GitHub
asdf2014 opened a new pull request, #16045: URL: https://github.com/apache/druid/pull/16045 ### Description This patch enhances the Kubernetes doc for Druid Helm Chart with related commands. This PR has: - [x] been self-reviewed. - [x] using the

[PR] Calcite tests remove expected exception (druid)

2024-03-05 Thread via GitHub
kgyrtkirk opened a new pull request, #16046: URL: https://github.com/apache/druid/pull/16046 * update testcases using `expectedException` to utilize `assertThrows` instead * remove `BaseCalciteQueryTest#expectedException` * fixes `cannotVectorize` so it doesn't anymore stops further

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512311579 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -215,34 +229,73 @@ public void cacheInitialized() // No need to

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512330473 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -125,15 +190,40 @@ private DiscoveryDruidNode

[PR] Throw 404 Exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
gargvishesh opened a new pull request, #16047: URL: https://github.com/apache/druid/pull/16047 The previously used `Google API Client` library for Google Cloud Storage returned a 404 HTTPResponseException for `delete` when the object to be deleted was not found, and was propagated as-is by

Re: [PR] Fix segment/unavailable/count metric when replicaCount=0 for load rules (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #16020: URL: https://github.com/apache/druid/pull/16020#discussion_r1512532737 ## server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java: ## @@ -242,7 +242,7 @@ public Object2IntMap

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512567784 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -215,34 +229,73 @@ public void cacheInitialized() // No need to wait

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512566965 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -59,38 +59,46 @@ public class BaseNodeRoleWatcher private final

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512567541 ## server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java: ## @@ -235,6 +235,28 @@ public void nodeViewInitialized() }

Re: [PR] Throw 404 Exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1512616578 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -144,12 +147,19 @@ public GoogleStorageObjectMetadata

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512581388 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ## @@ -37,11 +38,19 @@ public class

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512581388 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ## @@ -37,11 +38,19 @@ public class

Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-05 Thread via GitHub
clintropolis commented on code in PR #15939: URL: https://github.com/apache/druid/pull/15939#discussion_r1512464432 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -15336,4 +15336,36 @@ public void testFilterParseLongNullable()

Re: [PR] docs: update package and regenerate package-lock (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on PR #16038: URL: https://github.com/apache/druid/pull/16038#issuecomment-1978313227 Oops. @clintropolis - I missed your comment. Anyway, I changed the commit description before merging. -- This is an automated message from the Apache Git Service. To respond

(druid) branch master updated (00f80417d01 -> bb882727c03)

2024-03-05 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 00f80417d01 docs: update package and regenerate package-lock (#16038) add bb882727c03 Fix Windowing/scanAndSort

Re: [PR] Fix Windowing/scanAndSort query issues on top of Joins. (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 merged PR #15996: URL: https://github.com/apache/druid/pull/15996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix segment/unavailable/count metric when replicaCount=0 for load rules (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #16020: URL: https://github.com/apache/druid/pull/16020#discussion_r1512532737 ## server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java: ## @@ -242,7 +242,7 @@ public Object2IntMap

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512566055 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -209,13 +221,59 @@ private void removeNode(DiscoveryDruidNode druidNode)

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512566389 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -59,38 +59,46 @@ public class BaseNodeRoleWatcher private final

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512572545 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -125,15 +190,40 @@ private DiscoveryDruidNode

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512535444 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -651,6 +654,15 @@ private TaskStatus

Re: [PR] Throw 404 Exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
abhishekrb19 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1512601476 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -144,12 +147,19 @@ public GoogleStorageObjectMetadata

Re: [PR] Throw 404 Exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
abhishekrb19 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1512582069 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -131,7 +134,7 @@ public GoogleStorageObjectMetadata

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512581388 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ## @@ -37,11 +38,19 @@ public class

Re: [PR] Fix segment/unavailable/count metric when replicaCount=0 for load rules (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #16020: URL: https://github.com/apache/druid/pull/16020#discussion_r1512568367 ## server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java: ## @@ -242,7 +242,7 @@ public Object2IntMap getDatasourceToUnavailableSegmentCount()

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512568132 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -215,34 +229,73 @@ public void cacheInitialized() // No need to wait

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512570219 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +117,70 @@ public void testGeneralUseSimulation()

Re: [PR] Throw 404 Exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1512577444 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -144,12 +147,19 @@ public

Re: [PR] docs: update package and regenerate package-lock (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 merged PR #16038: URL: https://github.com/apache/druid/pull/16038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: docs: update package and regenerate package-lock (#16038)

2024-03-05 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 00f80417d01 docs: update package and

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512655681 ## processing/src/main/java/org/apache/druid/frame/allocation/HeapMemoryAllocator.java: ## @@ -53,7 +53,7 @@ public static HeapMemoryAllocator unlimited() @Override

Re: [I] Add Druid SQL support to JetBrains DataGrip (druid)

2024-03-05 Thread via GitHub
sergei3000 commented on issue #7405: URL: https://github.com/apache/druid/issues/7405#issuecomment-1978610067 +1 for this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1512950131 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -144,12 +147,19 @@ public GoogleStorageObjectMetadata

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #16031: URL: https://github.com/apache/druid/pull/16031#discussion_r1512988258 ## docs/release-info/release-notes.md: ## @@ -57,6 +57,12 @@ For tips about how to write a good release note, see [Release notes](https://git This section contains

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512991162 ## indexing-service/src/main/java/org/apache/druid/indexing/common/ParallelCompactionTaskReportData.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512991813 ## processing/src/main/java/org/apache/druid/frame/allocation/HeapMemoryAllocator.java: ## @@ -53,7 +53,7 @@ public static HeapMemoryAllocator unlimited()

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #16031: URL: https://github.com/apache/druid/pull/16031#discussion_r1512991550 ## docs/release-info/upgrade-notes.md: ## @@ -30,6 +30,10 @@ For the full release notes for a specific version, see the [releases page](https ### Upgrade notes

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1513019985 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ## @@ -37,11 +38,19 @@ public class

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-05 Thread via GitHub
adarshsanjeev commented on code in PR #16031: URL: https://github.com/apache/druid/pull/16031#discussion_r1513047191 ## docs/querying/sql-translation.md: ## @@ -71,7 +71,7 @@ EXPLAIN PLAN statements return: - a `RESOURCES` column that describes the resources used in the query

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on PR #15726: URL: https://github.com/apache/druid/pull/15726#issuecomment-1979070967 LGTM assuming CI failures are because of lack of code coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1513060060 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -142,15 +142,12 @@ public

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512928070 ## processing/src/main/java/org/apache/druid/frame/allocation/AppendableMemory.java: ## @@ -136,7 +136,7 @@ public boolean reserveAdditional(final int bytes)

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512993866 ## processing/src/main/java/org/apache/druid/query/scan/ScanResultValueFramesIterable.java: ## @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-05 Thread via GitHub
cryptoe commented on code in PR #16031: URL: https://github.com/apache/druid/pull/16031#discussion_r1512992585 ## docs/release-info/release-notes.md: ## @@ -57,6 +57,35 @@ For tips about how to write a good release note, see [Release notes](https://git This section contains

Re: [PR] Enable partition stats on streaming task completion report (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15930: URL: https://github.com/apache/druid/pull/15930#discussion_r1512999440 ## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ## @@ -101,6 +106,13 @@ public long

Re: [PR] Enable partition stats on streaming task completion report (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #15930: URL: https://github.com/apache/druid/pull/15930#discussion_r1512999440 ## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ## @@ -101,6 +106,13 @@ public long

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
kfaraz commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513015091 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -226,7 +226,8 @@ public IndexTask( IndexIngestionSpec

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
kfaraz commented on PR #16042: URL: https://github.com/apache/druid/pull/16042#issuecomment-1979025051 Thanks for the quick fix, @adithyachakilam . I have left a few comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-05 Thread via GitHub
adarshsanjeev commented on code in PR #16031: URL: https://github.com/apache/druid/pull/16031#discussion_r1513087732 ## docs/release-info/release-notes.md: ## @@ -57,6 +57,12 @@ For tips about how to write a good release note, see [Release notes](https://git This section

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-05 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1513179091 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -142,15 +142,12 @@ public GoogleStorageObjectMetadata

Re: [PR] netty 4.1.107 (druid)

2024-03-05 Thread via GitHub
sullis commented on PR #16027: URL: https://github.com/apache/druid/pull/16027#issuecomment-1979239695 > Can you please update the licenses.yaml file. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512827260 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -190,41 +196,39 @@ private DiscoveryDruidNode

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512887840 ## processing/src/main/java/org/apache/druid/query/scan/ScanResultValueFramesIterable.java: ## @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512785886 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +117,70 @@ public void testGeneralUseSimulation()

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512779921 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -264,8 +267,15 @@ private void cacheInitializedTimedOut()

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-05 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1512826619 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -264,8 +267,15 @@ private void cacheInitializedTimedOut()

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512849219 ## indexing-service/src/main/java/org/apache/druid/indexing/common/ParallelCompactionTaskReportData.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-05 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1512859727 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GeneratedPartitionsReport.java: ## @@ -37,11 +38,19 @@ public class

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-05 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1512901464 ## processing/src/main/java/org/apache/druid/frame/segment/FrameCursorUtils.java: ## @@ -79,60 +79,71 @@ public static Filter buildFilter(@Nullable Filter filter,

Re: [PR] remove aws-sdk from ranger-extension (druid)

2024-03-05 Thread via GitHub
janjwerner-confluent commented on PR #16011: URL: https://github.com/apache/druid/pull/16011#issuecomment-1979288898 > why does the description says "azure-sdk"? brain freeze I guess, fixed it :) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513282969 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -580,9 +586,11 @@ public TaskStatus runTask(final TaskToolbox

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513282969 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -580,9 +586,11 @@ public TaskStatus runTask(final TaskToolbox

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513281957 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -580,9 +586,11 @@ public TaskStatus runTask(final TaskToolbox

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
adithyachakilam commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513293231 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -580,9 +586,11 @@ public TaskStatus runTask(final TaskToolbox

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on PR #16042: URL: https://github.com/apache/druid/pull/16042#issuecomment-1979372591 is this actually the behavior we want? it seems to contradict the behavior of other situations where we run a task inside another task where we expect the parent task to write its

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on PR #16042: URL: https://github.com/apache/druid/pull/16042#issuecomment-1979380105 > is this actually the behavior we want? it seems to contradict the behavior of other situations where we run a task inside another task where we expect the parent task to write its

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
adithyachakilam commented on PR #16042: URL: https://github.com/apache/druid/pull/16042#issuecomment-1979416049 @georgew5656, That actually makes sense, fixed it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-05 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16042: URL: https://github.com/apache/druid/pull/16042#discussion_r1513352917 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -1261,7 +1252,16

[PR] updated description of rowsPerPage in export operations (druid)

2024-03-05 Thread via GitHub
sergioferragut opened a new pull request, #16048: URL: https://github.com/apache/druid/pull/16048 ### Description Fixes docs on export and how to use `rowsPerPage` context parameter. This PR has: - [ x ] been

Re: [PR] Explicitly bind ServiceStatusMonitor (druid)

2024-03-05 Thread via GitHub
arunramani commented on code in PR #16025: URL: https://github.com/apache/druid/pull/16025#discussion_r1513373313 ## server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java: ## @@ -210,4 +210,11 @@ public OshiSysMonitor getOshiSysMonitor(DataSourceTaskIdHolder

Re: [PR] Task Labeling for Improved Monitoring and Analysis (druid)

2024-03-05 Thread via GitHub
suneet-s commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1513363337 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java: ## @@ -134,6 +134,23 @@ default int getPriority() */ String getType(); +

Re: [PR] Task Labeling for Improved Monitoring and Analysis (druid)

2024-03-05 Thread via GitHub
suneet-s commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1513363337 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java: ## @@ -134,6 +134,23 @@ default int getPriority() */ String getType(); +

Re: [PR] Fix possibly thread unsafe constants (druid)

2024-03-05 Thread via GitHub
kgyrtkirk closed pull request #15743: Fix possibly thread unsafe constants URL: https://github.com/apache/druid/pull/15743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix possibly thread unsafe constants (druid)

2024-03-05 Thread via GitHub
kgyrtkirk commented on PR #15743: URL: https://github.com/apache/druid/pull/15743#issuecomment-1979674915 closing as #15694 was merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Task Labeling for Improved Monitoring and Analysis (druid)

2024-03-05 Thread via GitHub
suneet-s commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1513363337 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java: ## @@ -134,6 +134,23 @@ default int getPriority() */ String getType(); +

Re: [PR] Ingestion series of notebooks - Batch Ingestion (druid)

2024-03-05 Thread via GitHub
sergioferragut closed pull request #14635: Ingestion series of notebooks - Batch Ingestion URL: https://github.com/apache/druid/pull/14635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Adding null check to earliest and latest aggs (druid)

2024-03-05 Thread via GitHub
somu-imply commented on PR #15972: URL: https://github.com/apache/druid/pull/15972#issuecomment-1979624142 I have added a testcase with nulls to replicate the issue. Before the change the added test case would throw a NPE, which is now avoided -- This is an automated message from the

Re: [PR] Fix segment/unavailable/count metric when replicaCount=0 for load rules (druid)

2024-03-05 Thread via GitHub
georgew5656 commented on code in PR #16020: URL: https://github.com/apache/druid/pull/16020#discussion_r1513497839 ## server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java: ## @@ -242,7 +242,7 @@ public Object2IntMap

Re: [PR] Task Labeling for Improved Monitoring and Analysis (druid)

2024-03-05 Thread via GitHub
arunramani commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1513549881 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java: ## @@ -134,6 +134,23 @@ default int getPriority() */ String getType(); +

Re: [PR] Improve javadoc for ReadableFieldPointer. (druid)

2024-03-05 Thread via GitHub
gianm merged PR #16043: URL: https://github.com/apache/druid/pull/16043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improve javadoc for ReadableFieldPointer. (druid)

2024-03-05 Thread via GitHub
gianm commented on PR #16043: URL: https://github.com/apache/druid/pull/16043#issuecomment-1979521534 The docs failure is being fixed in #16040. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(druid) branch master updated: Improve javadoc for ReadableFieldPointer. (#16043)

2024-03-05 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new e13ed7b8787 Improve javadoc for

Re: [PR] Move retries into DataSegmentPusher implementations. (druid)

2024-03-05 Thread via GitHub
gianm commented on PR #15938: URL: https://github.com/apache/druid/pull/15938#issuecomment-1979522239 > I guess its complaining about 5GB, which i hear it would prefer as `5 GB` Oops, fixed in #16040. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-05 Thread via GitHub
somu-imply commented on code in PR #15939: URL: https://github.com/apache/druid/pull/15939#discussion_r1513418431 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -15336,4 +15336,36 @@ public void testFilterParseLongNullable()

Re: [PR] Only use ExprEval in ConstantExpr if its known that it will be safe (druid)

2024-03-05 Thread via GitHub
clintropolis merged PR #15694: URL: https://github.com/apache/druid/pull/15694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (e13ed7b8787 -> 27d7c30c38c)

2024-03-05 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from e13ed7b8787 Improve javadoc for ReadableFieldPointer. (#16043) add 27d7c30c38c Only use ExprEval in ConstantExpr

Re: [PR] Only use ExprEval in ConstantExpr if its known that it will be safe (druid)

2024-03-05 Thread via GitHub
soumyava commented on PR #15694: URL: https://github.com/apache/druid/pull/15694#issuecomment-1979615589 The doc failure is unrelated, we can merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] updated description of rowsPerPage in export operations (druid)

2024-03-05 Thread via GitHub
techdocsmith commented on code in PR #16048: URL: https://github.com/apache/druid/pull/16048#discussion_r1513609057 ## docs/multi-stage-query/reference.md: ## @@ -106,7 +106,8 @@ Keep the following in mind when using EXTERN to export rows: - You can export to Amazon S3 or

(druid) branch master updated: updated description of rowsPerPage in export operations (#16048)

2024-03-05 Thread techdocsmith
This is an automated email from the ASF dual-hosted git repository. techdocsmith pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new d38703281c6 updated description of

Re: [PR] updated description of rowsPerPage in export operations (druid)

2024-03-05 Thread via GitHub
techdocsmith merged PR #16048: URL: https://github.com/apache/druid/pull/16048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Batch Indexing short circuits (druid)

2024-03-05 Thread via GitHub
github-actions[bot] commented on PR #11913: URL: https://github.com/apache/druid/pull/11913#issuecomment-1979851875 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Batch Indexing short circuits (druid)

2024-03-05 Thread via GitHub
github-actions[bot] closed pull request #11913: Batch Indexing short circuits URL: https://github.com/apache/druid/pull/11913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Ingest metrics: messageGap to show earliest and latest messages (druid)

2024-03-05 Thread via GitHub
github-actions[bot] commented on issue #13771: URL: https://github.com/apache/druid/issues/13771#issuecomment-1979851917 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Ingest metrics: messageGap to show earliest and latest messages (druid)

2024-03-05 Thread via GitHub
github-actions[bot] closed issue #13771: Ingest metrics: messageGap to show earliest and latest messages URL: https://github.com/apache/druid/issues/13771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] SQL query with an empty string as group by fails: "Cannot add expression of different type to set" (druid)

2024-03-05 Thread via GitHub
github-actions[bot] closed issue #13775: SQL query with an empty string as group by fails: "Cannot add expression of different type to set" URL: https://github.com/apache/druid/issues/13775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] SQL query with an empty string as group by fails: "Cannot add expression of different type to set" (druid)

2024-03-05 Thread via GitHub
github-actions[bot] commented on issue #13775: URL: https://github.com/apache/druid/issues/13775#issuecomment-1979851951 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] lateMessageRejectionPeriod/earlyMessageRejectionPeriod these two parameters explain the intuitive feeling is the opposite. (druid)

2024-03-05 Thread via GitHub
github-actions[bot] commented on issue #13792: URL: https://github.com/apache/druid/issues/13792#issuecomment-1979851975 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] lateMessageRejectionPeriod/earlyMessageRejectionPeriod these two parameters explain the intuitive feeling is the opposite. (druid)

2024-03-05 Thread via GitHub
github-actions[bot] closed issue #13792: lateMessageRejectionPeriod/earlyMessageRejectionPeriod these two parameters explain the intuitive feeling is the opposite. URL: https://github.com/apache/druid/issues/13792 -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Flaky IT] org.apache.druid.tests.security.ITTLSTest runs into OutOfMemoryError sometimes (druid)

2024-03-05 Thread via GitHub
github-actions[bot] closed issue #13807: [Flaky IT] org.apache.druid.tests.security.ITTLSTest runs into OutOfMemoryError sometimes URL: https://github.com/apache/druid/issues/13807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   >