[incubator-druid] branch 0.12.3 updated: [Backport] Fix NPE for taskGroupId when rolling update (#6168) (#6188)

2018-08-17 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new bf1d5d7 [Backport] Fix NPE for

[GitHub] jon-wei closed pull request #6188: [Backport] Fix NPE for taskGroupId when rolling update (#6168)

2018-08-17 Thread GitBox
jon-wei closed pull request #6188: [Backport] Fix NPE for taskGroupId when rolling update (#6168) URL: https://github.com/apache/incubator-druid/pull/6188 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jon-wei closed pull request #6187: [Backport] Fix three bugs with segment publishing. (#6155)

2018-08-17 Thread GitBox
jon-wei closed pull request #6187: [Backport] Fix three bugs with segment publishing. (#6155) URL: https://github.com/apache/incubator-druid/pull/6187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-druid] branch 0.12.3 updated: [Backport] Fix three bugs with segment publishing. (#6155) (#6187)

2018-08-17 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new 8b1c8e4 [Backport] Fix three bugs

[GitHub] jon-wei commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155)

2018-08-17 Thread GitBox
jon-wei commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155) URL: https://github.com/apache/incubator-druid/pull/6187#issuecomment-414017677 @fjy The backport was incomplete, I fixed it now

[GitHub] fjy commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155)

2018-08-17 Thread GitBox
fjy commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155) URL: https://github.com/apache/incubator-druid/pull/6187#issuecomment-414015356 The build seems to be failing This is an automated

[GitHub] jon-wei opened a new pull request #6187: [Backport] Fix three bugs with segment publishing. (#6155)

2018-08-17 Thread GitBox
jon-wei opened a new pull request #6187: [Backport] Fix three bugs with segment publishing. (#6155) URL: https://github.com/apache/incubator-druid/pull/6187 Backport of #6155 to 0.12.3 This is an automated message from the

[GitHub] gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-17 Thread GitBox
gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124#issuecomment-414004689 I think this may be fixed by #6155, but would like to double-check that there are no lingering issues due to the fact

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040955 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040576 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040341 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211040256 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211039685 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211035759 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211034435 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211034327 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211027082 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211025182 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211024468 ## File path:

[GitHub] clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
clintropolis commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211023640 ## File path:

[GitHub] jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-17 Thread GitBox
jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211010791 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ +

[GitHub] jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-17 Thread GitBox
jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211010205 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ +

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210986882 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210993150 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210987247 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210988503 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210992795 ## File path:

[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210988655 ## File path:

[GitHub] gianm commented on issue #6163: java.lang.NullPointerException: taskGroupId when middlemanager rolling update to 0.12.2

2018-08-17 Thread GitBox
gianm commented on issue #6163: java.lang.NullPointerException: taskGroupId when middlemanager rolling update to 0.12.2 URL: https://github.com/apache/incubator-druid/issues/6163#issuecomment-413943708 @pdeva I think no, however, the issue should clear up after your rolling update is

[incubator-druid] branch master updated: Fix NPE for taskGroupId when rolling update (#6168)

2018-08-17 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 2bfe1b6 Fix NPE for taskGroupId when

[GitHub] fjy closed pull request #6168: Fix NPE for taskGroupId when rolling update

2018-08-17 Thread GitBox
fjy closed pull request #6168: Fix NPE for taskGroupId when rolling update URL: https://github.com/apache/incubator-druid/pull/6168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] fjy commented on issue #6168: Fix NPE for taskGroupId when rolling update

2018-08-17 Thread GitBox
fjy commented on issue #6168: Fix NPE for taskGroupId when rolling update URL: https://github.com/apache/incubator-druid/pull/6168#issuecomment-413931586  This is an automated message from the Apache Git Service. To respond

[GitHub] fjy closed issue #6163: java.lang.NullPointerException: taskGroupId when middlemanager rolling update to 0.12.2

2018-08-17 Thread GitBox
fjy closed issue #6163: java.lang.NullPointerException: taskGroupId when middlemanager rolling update to 0.12.2 URL: https://github.com/apache/incubator-druid/issues/6163 This is an automated message from the Apache Git

[incubator-druid] branch master updated: trigger clean dir when unzip fails with IOException (#6178)

2018-08-17 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 78fc5b2 trigger clean dir when unzip

[GitHub] fjy closed pull request #6178: trigger clean dir when unzip fails with IOException

2018-08-17 Thread GitBox
fjy closed pull request #6178: trigger clean dir when unzip fails with IOException URL: https://github.com/apache/incubator-druid/pull/6178 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mkuthan commented on issue #6172: nodes should allow draining

2018-08-17 Thread GitBox
mkuthan commented on issue #6172: nodes should allow draining URL: https://github.com/apache/incubator-druid/issues/6172#issuecomment-413928961 In our config load balancer check /druid/broker/v1/loadstatus endpoint. No downtime during rolling update/restart of brokers.

[GitHub] mkuthan edited a comment on issue #6172: nodes should allow draining

2018-08-17 Thread GitBox
mkuthan edited a comment on issue #6172: nodes should allow draining URL: https://github.com/apache/incubator-druid/issues/6172#issuecomment-413928961 In our config load balancer checks /druid/broker/v1/loadstatus endpoint. No downtime during rolling update/restart of brokers.

[GitHub] gianm closed pull request #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
gianm closed pull request #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-druid] branch master updated: 'shutdownAllTasks' API for a dataSource (#6185)

2018-08-17 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b0cf8d0 'shutdownAllTasks' API for a

[GitHub] gianm closed issue #6115: Druid should have a 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
gianm closed issue #6115: Druid should have a 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/issues/6115 This is an automated message from the Apache Git Service. To respond to the

[GitHub] gianm commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#discussion_r210971130 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java ##

[GitHub] gianm commented on issue #6133: Coordinator `asOverlord` broken on master.

2018-08-17 Thread GitBox
gianm commented on issue #6133: Coordinator `asOverlord` broken on master. URL: https://github.com/apache/incubator-druid/issues/6133#issuecomment-413926401 It's used whenever the leader coordinator needs to talk to the leader indexer. Probably better to replace that line with: ```

[GitHub] KenjiTakahashi commented on issue #6133: Coordinator `asOverlord` broken on master.

2018-08-17 Thread GitBox
KenjiTakahashi commented on issue #6133: Coordinator `asOverlord` broken on master. URL: https://github.com/apache/incubator-druid/issues/6133#issuecomment-413923900 I've bisected and this is caused by line

[GitHub] gianm closed pull request #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

2018-08-17 Thread GitBox
gianm closed pull request #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies URL: https://github.com/apache/incubator-druid/pull/6173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[incubator-druid] branch master updated: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies (#6173)

2018-08-17 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 1c8032f Composite request logger

[GitHub] gianm commented on a change in pull request #6076: Mutual TLS support

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#discussion_r210964758 ## File path: docs/content/operations/tls-support.md ## @@ -31,6 +31,16 @@ values for the below mentioned configs among

[GitHub] gianm commented on a change in pull request #6076: Mutual TLS support

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#discussion_r210964888 ## File path: docs/content/operations/tls-support.md ## @@ -31,6 +31,16 @@ values for the below mentioned configs among

[GitHub] gianm closed pull request #6182: Change hybrid cache default types in docs to caffeine

2018-08-17 Thread GitBox
gianm closed pull request #6182: Change hybrid cache default types in docs to caffeine URL: https://github.com/apache/incubator-druid/pull/6182 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-druid] branch master updated: Change hybrid cache default types in docs to caffeine (#6182)

2018-08-17 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 0c3bb47 Change hybrid cache default

[incubator-druid] branch master updated: Serde test for JdbcExtractionNamespace. (#6186)

2018-08-17 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 4d2ff0f Serde test for

[GitHub] gianm closed pull request #6186: Serde test for JdbcExtractionNamespace.

2018-08-17 Thread GitBox
gianm closed pull request #6186: Serde test for JdbcExtractionNamespace. URL: https://github.com/apache/incubator-druid/pull/6186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] gianm commented on a change in pull request #6186: Serde test for JdbcExtractionNamespace.

2018-08-17 Thread GitBox
gianm commented on a change in pull request #6186: Serde test for JdbcExtractionNamespace. URL: https://github.com/apache/incubator-druid/pull/6186#discussion_r210954250 ## File path: common/src/main/java/io/druid/metadata/MetadataStorageConnectorConfig.java ## @@ -59,6

[GitHub] nishantmonu51 commented on issue #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
nishantmonu51 commented on issue #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#issuecomment-413907836 have restarted the failing travis. This is an automated message

[GitHub] QiuMM commented on issue #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
QiuMM commented on issue #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#issuecomment-413886758 @gianm Can you help restart the failed travis [job#](https://travis-ci.org/apache/incubator-druid/jobs/417090154). Thanks.

[GitHub] asdf2014 commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
asdf2014 commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#discussion_r210836013 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java

[GitHub] QiuMM commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
QiuMM commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#discussion_r210820106 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java ##

[GitHub] asdf2014 commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource

2018-08-17 Thread GitBox
asdf2014 commented on a change in pull request #6185: 'shutdownAllTasks' API for a dataSource URL: https://github.com/apache/incubator-druid/pull/6185#discussion_r210817443 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java