[GitHub] [incubator-pinot] snleee commented on issue #4574: Support simpler streams

2019-09-04 Thread GitBox
snleee commented on issue #4574: Support simpler streams URL: https://github.com/apache/incubator-pinot/issues/4574#issuecomment-528205396 @lsabi 1. One per table 2. Which version of Kafka are you using? By default, it will build using Kafka `0.9.x`. If you want to run against Kafka

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-524000641 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4535?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r321040330 ## File path: pinot-common/src/thrift/request.thrift ## @@ -155,6 +155,7 @@ struct BrokerRequest { 16:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624737 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#issuecomment-528089180 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4577?src=pr=h1) Report > Merging

[incubator-pinot] branch cleanup updated (c9a26fb -> 084edf3)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c9a26fb Adding umask add 084edf3 Fixing error No new revisions were added by this update.

[incubator-pinot] branch fixing_raw_bytes_comparison updated (bc76af5 -> 235a51f)

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from bc76af5 Adding more tests add 235a51f Adding bytes support for ValueMatcher

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#issuecomment-528089180 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4577?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#issuecomment-528089180 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4577?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on issue #4584: Change license link from LinkedIn Pinot to Apache Pinot

2019-09-04 Thread GitBox
codecov-io commented on issue #4584: Change license link from LinkedIn Pinot to Apache Pinot URL: https://github.com/apache/incubator-pinot/pull/4584#issuecomment-528111964 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4584?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r320995148 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r320996156 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4585: Presence vector

2019-09-04 Thread GitBox
codecov-io commented on issue #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-528121925 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4585?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4586: Adding Predicate supports for Bytes Column without dictionary

2019-09-04 Thread GitBox
fx19880617 opened a new pull request #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586 Support predicate for equal/not equ/in/not in/ range This is

[incubator-pinot] 02/02: Adding more tests

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit bc76af5b63312984a67bee2e856843290d536b4e Author: Xiang Fu AuthorDate: Wed Sep 4 15:34:47

[incubator-pinot] 01/02: Support predicates on raw bytes column without dictionary

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit e8c4e08190f39aa461db2ff92229447eed36fcb0 Author: Xiang Fu AuthorDate: Wed Sep 4 14:42:52

[incubator-pinot] branch fixing_raw_bytes_comparison updated (81438f1 -> bc76af5)

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 81438f1 Adding more tests discard fbfaa98 Support predicates on raw bytes column

[incubator-pinot] 01/01: Refactoring realtime segment data manager

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch realtimetest in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 04bdd56125c920c44092001284874e2d04e18191 Author: Jennifer Dai AuthorDate: Wed Sep 4 15:01:34 2019

[incubator-pinot] branch realtimetest created (now 04bdd56)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch realtimetest in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 04bdd56 Refactoring realtime segment data manager This branch includes the following new

[incubator-pinot] branch fixing_raw_bytes_comparison updated: Adding more tests

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/fixing_raw_bytes_comparison by this push:

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4584: Change license link from LinkedIn Pinot to Apache Pinot

2019-09-04 Thread GitBox
Jackie-Jiang merged pull request #4584: Change license link from LinkedIn Pinot to Apache Pinot URL: https://github.com/apache/incubator-pinot/pull/4584 This is an automated message from the Apache Git Service. To respond

[incubator-pinot] branch master updated (a1c5af7 -> 05609e4)

2019-09-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from a1c5af7 [TE] Return the anomaly details to render snapshot (#4576) add 05609e4 Use Apache Pinot

[GitHub] [incubator-pinot] icefury71 commented on issue #4230: NULL value support for all data types

2019-09-04 Thread GitBox
icefury71 commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-528105916 Opened PR: https://github.com/apache/incubator-pinot/pull/4585 This

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r320995822 ## File path:

[GitHub] [incubator-pinot] icefury71 opened a new pull request #4585: Presence vector

2019-09-04 Thread GitBox
icefury71 opened a new pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585 This PR adds support for a presence vector inside a mutable and immutable segment. This will enable the query layer to ignore null values in the corresponding columns.

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r321001381 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4583: Support default value for Byte column

2019-09-04 Thread GitBox
kishoreg commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320993755 ## File path: pinot-core/src/test/resources/data/newColumnsSchema3.json ## @@ -16,6 +16,11 @@ {

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r321001516 ## File path:

[incubator-pinot] branch cleanup updated (e9b0ea0 -> 2436154)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e9b0ea0 Addressing comments add 2436154 Addressing comments No new revisions were added by

[incubator-pinot] branch cleanup updated (a8ab052 -> e9b0ea0)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a8ab052 Fixing test discard aff5441 Adding preprocess test add 7c7b6cc Support transform

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4583: Support default value for Byte column

2019-09-04 Thread GitBox
jackjlli commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320992567 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@

[incubator-pinot] 01/01: Support predicates on raw bytes column without dictionary

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit fbfaa98a0e90ea47c7fcd375931716686894cfec Author: Xiang Fu AuthorDate: Wed Sep 4 14:42:52

[incubator-pinot] branch fixing_raw_bytes_comparison created (now fbfaa98)

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at fbfaa98 Support predicates on raw bytes column without dictionary This branch

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4583: Support default value for Byte column

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320988011 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4583: Support default value for Byte column

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320987926 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ##

[GitHub] [incubator-pinot] haibow opened a new pull request #4584: Change license link from LinkedIn Pinot to Apache Pinot

2019-09-04 Thread GitBox
haibow opened a new pull request #4584: Change license link from LinkedIn Pinot to Apache Pinot URL: https://github.com/apache/incubator-pinot/pull/4584 Proposing to change the license link old: https://img.shields.io/github/license/linkedin/pinot.svg new:

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4583: Support default value for Byte column

2019-09-04 Thread GitBox
jackjlli opened a new pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583 This PR supports default value for Byte column. Unit tests added. This is an

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#issuecomment-528089180 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4577?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jenniferdai opened a new pull request #4582: Allow creation of HttpClient with a proxy

2019-09-04 Thread GitBox
jenniferdai opened a new pull request #4582: Allow creation of HttpClient with a proxy URL: https://github.com/apache/incubator-pinot/pull/4582 * Provides an option to create an HttpClient with a proxy This is an automated

[incubator-pinot] branch proxy created (now ddb8c5f)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch proxy in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at ddb8c5f Adding a constructor to create the HttpClient with a proxy This branch includes the following

[incubator-pinot] branch byte-default-value updated: Support default value for Byte column

2019-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch byte-default-value in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/byte-default-value by this push: new 714e785

[incubator-pinot] 01/01: Adding a constructor to create the HttpClient with a proxy

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch proxy in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit ddb8c5f48ef872631fcd8a4813e8190966ff07f9 Author: Jennifer Dai AuthorDate: Wed Sep 4 14:15:28 2019 -0700

[GitHub] [incubator-pinot] codecov-io commented on issue #4577: Adding integration test for Hadoop pre-process job

2019-09-04 Thread GitBox
codecov-io commented on issue #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#issuecomment-528089180 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4577?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] lsabi commented on issue #4574: Support simpler streams

2019-09-04 Thread GitBox
lsabi commented on issue #4574: Support simpler streams URL: https://github.com/apache/incubator-pinot/issues/4574#issuecomment-528074977 1. Overall only one? Or you mean one per table? 2. That part of the docs was confusing me. Do I have or do I have not to compile Pinot myself with

[incubator-pinot] branch cleanup updated (0766be3 -> a8ab052)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 0766be3 Fixing test add a8ab052 Fixing test This update added new revisions after undoing

[incubator-pinot] branch cleanup updated (aff5441 -> 0766be3)

2019-09-04 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from aff5441 Adding preprocess test add 0766be3 Fixing test No new revisions were added by this

[incubator-pinot] branch k8s-quickstart updated (c39fe6c -> cdee3c3)

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c39fe6c Adding example for kubernetes deployment on GKE add cdee3c3 Adding example for

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4581: Adding example for kubernetes deployment on GKE

2019-09-04 Thread GitBox
fx19880617 opened a new pull request #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] 01/01: Adding example for kubernetes deployment on GKE

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit c39fe6caf88405557d3e360ba82d915849afd7e1 Author: Xiang Fu AuthorDate: Wed Sep 4 12:54:15 2019 -0700

[incubator-pinot] branch k8s-quickstart created (now c39fe6c)

2019-09-04 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at c39fe6c Adding example for kubernetes deployment on GKE This branch includes the following new

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4578: Refactor TransformBlockDataFetcher so that DISTINCT and reuse it

2019-09-04 Thread GitBox
mayankshriv commented on a change in pull request #4578: Refactor TransformBlockDataFetcher so that DISTINCT and reuse it URL: https://github.com/apache/incubator-pinot/pull/4578#discussion_r320903302 ## File path:

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4580: [TE] frontend - harleyjj/auth - handle expired token and 401 errors p…

2019-09-04 Thread GitBox
harleyjj opened a new pull request #4580: [TE] frontend - harleyjj/auth - handle expired token and 401 errors p… URL: https://github.com/apache/incubator-pinot/pull/4580 …lus redirect after login This is an automated message

[incubator-pinot] 01/01: Support default value for byte column

2019-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch byte-default-value in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b29475136423dd0888bb411fdb359fc0d9b936d9 Author: jackjlli AuthorDate: Wed Sep 4 10:47:24 2019 -0700

[incubator-pinot] branch byte-default-value created (now b294751)

2019-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch byte-default-value in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b294751 Support default value for byte column This branch includes the following new commits:

[GitHub] [incubator-pinot] akshayrai merged pull request #4576: [TE] [Composite-Alert] Return the anomaly details to render snapshot

2019-09-04 Thread GitBox
akshayrai merged pull request #4576: [TE] [Composite-Alert] Return the anomaly details to render snapshot URL: https://github.com/apache/incubator-pinot/pull/4576 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated (f3aa4db -> a1c5af7)

2019-09-04 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f3aa4db Retrieve routing table by exact table name instead of by prefix (#3037) add a1c5af7

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-524000641 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4535?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4578: Refactor TransformBlockDataFetcher so that DISTINCT and reuse it

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4578: Refactor TransformBlockDataFetcher so that DISTINCT and reuse it URL: https://github.com/apache/incubator-pinot/pull/4578#discussion_r320660587 ## File path:

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia edited a comment on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-527817225 > Please add a unit test for DistinctTable > > Bonus points if you can also cover BrokerReduceService via unit tests

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on issue #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#issuecomment-527817225 > Please add a unit test for DistinctTable > > Bonus points if you can also cover BrokerReduceService via unit tests Tests added

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320654817 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320654817 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320625033 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624689 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624678 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -213,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624987 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320625006 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624923 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624737 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624968 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624737 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624937 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624649 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -174,13

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624542 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -425,8

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624562 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -277,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624501 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624356 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -76,7

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624517 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624572 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -277,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624478 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624460 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -63,7

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624609 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -93,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624592 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -277,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624005 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624038 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624053 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624117 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624070 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621516 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621452 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621811 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621626 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621684 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621730 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621464 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621768 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621489 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621606 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621645 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-04 Thread GitBox
siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621590 ## File path:

  1   2   >