tjiuming opened a new pull request, #19287:
URL: https://github.com/apache/pulsar/pull/19287
### Motivation
Cherry-pick https://github.com/apache/pulsar/pull/19157 into branch-2.9
### Documentation
- [ ] `doc`
- [ ] `doc-required`
- [x]
tisonkun commented on PR #19281:
URL: https://github.com/apache/pulsar/pull/19281#issuecomment-1396829372
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari commented on issue #16427:
URL: https://github.com/apache/pulsar/issues/16427#issuecomment-1396819001
related to
https://github.com/apache/pulsar/issues/13620#issuecomment-1396815606
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lhotari commented on issue #16444:
URL: https://github.com/apache/pulsar/issues/16444#issuecomment-1396818841
related to
https://github.com/apache/pulsar/issues/13620#issuecomment-1396815606
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lhotari commented on issue #13620:
URL: https://github.com/apache/pulsar/issues/13620#issuecomment-1396815606
Recent failure
https://github.com/apache/pulsar/actions/runs/3957519115/jobs/6778165658#step:11:1013
```
Error: Tests run: 45, Failures: 1, Errors: 0, Skipped: 20, Time
Jason918 commented on PR #19285:
URL: https://github.com/apache/pulsar/pull/19285#issuecomment-1396814564
Does this have any affect? The value is set every time in
`OpReadEntry#create`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lhotari commented on issue #19286:
URL: https://github.com/apache/pulsar/issues/19286#issuecomment-1396811602
This flaky test is an example of eventual consistent behavior of Pulsar
metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lhotari commented on issue #19286:
URL: https://github.com/apache/pulsar/issues/19286#issuecomment-1396809693
@tjiuming would you like to take a look at this flaky test? It looks like
the test was added in PR #18218
--
This is an automated message from the Apache Git Service.
To respond
lhotari opened a new issue, #19286:
URL: https://github.com/apache/pulsar/issues/19286
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Example failure
lhotari commented on PR #19264:
URL: https://github.com/apache/pulsar/pull/19264#issuecomment-1396773364
@yaalsn This is a PR which will significantly improve the reliability of
Codecov metrics. It solves the coverage reporting for dependent projects, but
also moves uploading of coverage
poorbarcode commented on code in PR #19275:
URL: https://github.com/apache/pulsar/pull/19275#discussion_r1081086298
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##
@@ -690,11 +690,11 @@ private void recoveredCursor(PositionImpl
truong-hua commented on issue #15838:
URL: https://github.com/apache/pulsar/issues/15838#issuecomment-1396753550
@tisonkun can this one be consider as to provide zookeeper metadata scheme
structure doc and other like etcd. So the user can try themself to migrate it.
I can not do it without
poorbarcode commented on PR #19275:
URL: https://github.com/apache/pulsar/pull/19275#issuecomment-1396752247
Hi @HQebupt
>I believe the expected behavior is following : can only consume the
messages {5:0~5:10}, so managedLedger.entriesAddedCounter is 5 10 now. the
backlog in
HQebupt commented on code in PR #19275:
URL: https://github.com/apache/pulsar/pull/19275#discussion_r1081068509
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##
@@ -690,11 +690,11 @@ private void recoveredCursor(PositionImpl
poorbarcode commented on PR #19275:
URL: https://github.com/apache/pulsar/pull/19275#issuecomment-1396748584
@codelipenghui
> Now the solution is to avoid the race condition of
cursor.initializeCursorPosition and internalTrimLedgers, right?
Yes, Already fixed
--
This is an
Hongten commented on issue #7653:
URL: https://github.com/apache/pulsar/issues/7653#issuecomment-1396742917
> @walterEri It seems that the bookie is using an OLD volume that contains
OLD data. You need to format the disk if you re-use an OLD volume for a new
bookie.
Hi @sijie ,
Hongten commented on issue #3121:
URL: https://github.com/apache/pulsar/issues/3121#issuecomment-1396737773
I have encountered the same issue in pulsar-2.10.1.
I have 12 bookie pods in k8s, and I want to add 1 bookie pod, but then an
error happened.
The error message as below
HQebupt commented on PR #19275:
URL: https://github.com/apache/pulsar/pull/19275#issuecomment-1396727013
> consume all messages
> - can only consume the messages {5:0~5:10}, so
managedLedger.entriesAddedCounter is 5 now
> the backlog in response of topics stats is 50 - 5 = 45, but
codelipenghui merged PR #19094:
URL: https://github.com/apache/pulsar/pull/19094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codelipenghui commented on PR #19157:
URL: https://github.com/apache/pulsar/pull/19157#issuecomment-1396667540
@tjiuming Could you please help create a PR to cherry-pick the fix to
branch-2.11, branch-2.10 and branch-2.9?
--
This is an automated message from the Apache Git Service.
To
codelipenghui commented on PR #17676:
URL: https://github.com/apache/pulsar/pull/17676#issuecomment-1396663515
@nodece Could you please help cherry-pick the release into branch-2.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
poorbarcode commented on code in PR #19256:
URL: https://github.com/apache/pulsar/pull/19256#discussion_r1080982888
##
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java:
##
@@ -192,18 +191,15 @@ private void closePingFuture() {
asafm commented on code in PR #19208:
URL: https://github.com/apache/pulsar/pull/19208#discussion_r1080972166
##
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java:
##
@@ -45,19 +62,50 @@ public static MetadataStoreExtended
blankensteiner merged PR #133:
URL: https://github.com/apache/pulsar-dotpulsar/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaozhangmin opened a new pull request, #19285:
URL: https://github.com/apache/pulsar/pull/19285
### Motivation
OpReadEntry has been reseted, but count was not reseted.
BewareMyPower commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396625182
> I think only need the client to provide the updateServiceUrl method.
This idea also looks good to me.
--
This is an automated message from the Apache Git
BewareMyPower merged PR #157:
URL: https://github.com/apache/pulsar-client-cpp/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lhotari commented on PR #19264:
URL: https://github.com/apache/pulsar/pull/19264#issuecomment-1396595123
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
BewareMyPower commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1080924394
##
lib/HandlerBase.h:
##
@@ -113,13 +113,14 @@ class HandlerBase {
enum State
{
-NotStarted,
-Pending,
-Ready,
-
shibd commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396581433
> In short, a natural design is to save the `ServiceUrlProvider` in `Client`
and call `getServiceUrl()` method (in C++ it's just a function invocation) each
time we need a service
BewareMyPower commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1080910162
##
lib/HandlerBase.h:
##
@@ -113,13 +113,14 @@ class HandlerBase {
enum State
{
-NotStarted,
-Pending,
-Ready,
-
eolivelli opened a new pull request, #19284:
URL: https://github.com/apache/pulsar/pull/19284
### Motivation
When the broker is shutting down AbstractBatchedMetadataStore completes
exceptionally the pending operations with a generic IllegalStateException. All
the code that is
BewareMyPower commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1080906832
##
include/pulsar/ClientConfiguration.h:
##
@@ -64,25 +64,25 @@ class PULSAR_PUBLIC ClientConfiguration {
*
* @param timeout the timeout
BewareMyPower commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396560323
In short, a natural design is to save the `ServiceUrlProvider` in `Client`
and call `getServiceUrl()` method (in C++ it's just a function invocation) each
time we need a
BewareMyPower commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396556883
I have sent an email:
https://lists.apache.org/thread/cojz6qxpc7v0j8vy0w476ttt0f89zr3z
--
This is an automated message from the Apache Git Service.
To respond to the
shibd commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396555980
If you feel redundant to expose this method, I can remove it. What do you
think? /cc @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to
BewareMyPower merged PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shibd commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396552263
> If we want to implement AutoClusterFailover and ControlledClusterFailover
in future, we actually don't need to implement a function that returns the
service URL. Instead, we
eolivelli commented on issue #16249:
URL: https://github.com/apache/pulsar/issues/16249#issuecomment-1396546157
I think that it makes sense to retry some (most) of the admin operations.
We do retries while producing messages why can't we do them in the admin API
?
--
This is
michaeljmarshall commented on PR #19280:
URL: https://github.com/apache/pulsar/pull/19280#issuecomment-1396538310
This work will end up as multiple PRs and I think I've found a way to avoid
confusing breaking changes. The first PR that was initially covered in this PR
is here:
Hongten commented on issue #12628:
URL: https://github.com/apache/pulsar/issues/12628#issuecomment-1396532277
I encountered the same issue. I resolved the issue by renaming the `source`
name.
```
docker run -it -p 6650:6650 -p 8080:8080 --mount
michaeljmarshall opened a new pull request, #19283:
URL: https://github.com/apache/pulsar/pull/19283
PIP 97: https://github.com/apache/pulsar/issues/12105
### Motivation
While working on PIP 97, I noticed that we do not have a clear contract for
the `AuthenticationState`
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080873280
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
michaeljmarshall opened a new pull request, #19282:
URL: https://github.com/apache/pulsar/pull/19282
### Motivation
We use the result of `TokenAuthenticationState#getAuthDataSource` to pass to
the `AuthorizationProvider`. For custom implementations, it is important that
this
BewareMyPower merged PR #176:
URL: https://github.com/apache/pulsar-client-cpp/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sekikn commented on PR #19281:
URL: https://github.com/apache/pulsar/pull/19281#issuecomment-1396502041
Originally I tried to upgrade Alluxio to 2.9.0, which is the latest version
at this writing, but [Alluxio's metrics refers to the `sun.management` package
since that
BewareMyPower commented on PR #170:
URL:
https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1396500856
> The initialize and close methods are redundant.
I reviewed the `ServiceUrlProvider` in Java client again. **I have thought
`getServiceUrl()` is called each time
michaeljmarshall merged PR #19278:
URL: https://github.com/apache/pulsar/pull/19278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sekikn opened a new pull request, #19281:
URL: https://github.com/apache/pulsar/pull/19281
### Motivation
Currently, the Alluxio sink depends on Alluxio 2.7.3, which was released
around a year ago.
### Modifications
This PR upgrades Alluxio to 2.8.1 so that we can
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080840353
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080839635
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080838475
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
michaeljmarshall commented on code in PR #17831:
URL: https://github.com/apache/pulsar/pull/17831#discussion_r1080836860
##
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##
@@ -523,18 +529,63 @@ remoteAddress, protocolVersionToAdvertise,
michaeljmarshall commented on code in PR #17831:
URL: https://github.com/apache/pulsar/pull/17831#discussion_r1080836860
##
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##
@@ -523,18 +529,63 @@ remoteAddress, protocolVersionToAdvertise,
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1073882511
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080827497
##
include/pulsar/Client.h:
##
@@ -66,6 +67,31 @@ class PULSAR_PUBLIC Client {
*/
Client(const std::string& serviceUrl, const
michaeljmarshall merged PR #19197:
URL: https://github.com/apache/pulsar/pull/19197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080826113
##
include/pulsar/Client.h:
##
@@ -66,6 +67,31 @@ class PULSAR_PUBLIC Client {
*/
Client(const std::string& serviceUrl, const
michaeljmarshall commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1080825354
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##
@@ -160,6 +163,20 @@ public String
nodece commented on PR #19278:
URL: https://github.com/apache/pulsar/pull/19278#issuecomment-1396442310
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shibd commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080780926
##
lib/ClientImpl.cc:
##
@@ -497,6 +497,20 @@ void ClientImpl::getPartitionsForTopicAsync(const
std::string& topic, GetPartiti
nodece commented on code in PR #19197:
URL: https://github.com/apache/pulsar/pull/19197#discussion_r1080780426
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##
@@ -160,6 +163,20 @@ public String
nodece commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080775696
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
String
nodece commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080774793
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
String
nodece commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1080769754
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
String
shibd commented on PR #139:
URL:
https://github.com/apache/pulsar-client-cpp/pull/139#issuecomment-1396387216
> I have left the last comments. This PR overall LGTM. Please avoid
committing such a huge patch next time. If a PR had many code changes, it would
be very hard to review all of
Technoboy- commented on issue #19267:
URL: https://github.com/apache/pulsar/issues/19267#issuecomment-1396378853
Could you provide the dump file of the issued broker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
shibd commented on code in PR #157:
URL: https://github.com/apache/pulsar-client-cpp/pull/157#discussion_r1080761256
##
lib/HTTPLookupService.cc:
##
@@ -409,4 +430,72 @@ void
HTTPLookupService::handleLookupHTTPRequest(LookupPromise promise, const std
}
}
+void
shibd commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080757958
##
include/pulsar/Client.h:
##
@@ -66,6 +67,31 @@ class PULSAR_PUBLIC Client {
*/
Client(const std::string& serviceUrl, const ClientConfiguration&
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080755872
##
lib/ServiceNameResolver.h:
##
@@ -29,29 +29,33 @@ namespace pulsar {
class ServiceNameResolver {
public:
ServiceNameResolver(const
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080753416
##
lib/ClientImpl.cc:
##
@@ -497,6 +497,20 @@ void ClientImpl::getPartitionsForTopicAsync(const
std::string& topic, GetPartiti
lightistor commented on issue #13965:
URL: https://github.com/apache/pulsar/issues/13965#issuecomment-1396365880
We are facing this issue that yields a constantly increasing backlog with
millions of messages. Is there a fix for it or a guidance to implement our
consumers? We end-up with 2
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080751592
##
lib/ClientImpl.cc:
##
@@ -497,6 +497,20 @@ void ClientImpl::getPartitionsForTopicAsync(const
std::string& topic, GetPartiti
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080749572
##
lib/ServiceNameResolver.h:
##
@@ -29,29 +29,33 @@ namespace pulsar {
class ServiceNameResolver {
Review Comment:
Add a `#include ` to this file
BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080746462
##
include/pulsar/Client.h:
##
@@ -66,6 +67,31 @@ class PULSAR_PUBLIC Client {
*/
Client(const std::string& serviceUrl, const
315157973 commented on PR #19094:
URL: https://github.com/apache/pulsar/pull/19094#issuecomment-1396350234
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #18390:
URL: https://github.com/apache/pulsar/pull/18390#issuecomment-1396346561
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on PR #18886:
URL: https://github.com/apache/pulsar/pull/18886#issuecomment-1396346055
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on issue #18950:
URL: https://github.com/apache/pulsar/issues/18950#issuecomment-1396345955
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #18957:
URL: https://github.com/apache/pulsar/issues/18957#issuecomment-1396345925
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #18963:
URL: https://github.com/apache/pulsar/issues/18963#issuecomment-1396345865
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #18978:
URL: https://github.com/apache/pulsar/pull/18978#issuecomment-1396345824
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Demogorgon314 commented on PR #18777:
URL: https://github.com/apache/pulsar/pull/18777#issuecomment-1396342667
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shibd commented on code in PR #157:
URL: https://github.com/apache/pulsar-client-cpp/pull/157#discussion_r1080735293
##
tests/ClientTest.cc:
##
@@ -305,6 +305,7 @@ TEST(ClientTest, testCloseClient) {
auto t0 = std::chrono::steady_clock::now();
while
michaeljmarshall commented on PR #19280:
URL: https://github.com/apache/pulsar/pull/19280#issuecomment-1396224344
After thinking about this more, I think we should probably take a different
direction. I'll follow up with another PR.
--
This is an automated message from the Apache Git
michaeljmarshall closed pull request #19280: [improve][broker]
AuthenticationState authenticate data once
URL: https://github.com/apache/pulsar/pull/19280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
codecov-commenter commented on PR #19278:
URL: https://github.com/apache/pulsar/pull/19278#issuecomment-1396211146
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
michaeljmarshall opened a new pull request, #19280:
URL: https://github.com/apache/pulsar/pull/19280
PIP 97: https://github.com/apache/pulsar/issues/12105
### Motivation
In order to implement PIP 97, it is essential that we remove all blocking
calls to
pgier opened a new pull request, #19279:
URL: https://github.com/apache/pulsar/pull/19279
### Motivation
Some of the code in the pulsar-perf command line tools seems to be
unnecessarily repetitive.
### Modifications
This removes some code duplication in the
frankjkelly commented on issue #16249:
URL: https://github.com/apache/pulsar/issues/16249#issuecomment-1396150858
@martijngonlag Sorry I took so long to get back to you.
The problem then becomes our code is littered with the following since some
of the exceptions are not retryable
michaeljmarshall opened a new pull request, #19278:
URL: https://github.com/apache/pulsar/pull/19278
### Motivation
The `AuthenticationDataSource` variable was added to the `ProxyConnection`
class in https://github.com/apache/pulsar/pull/1200. It is no longer needed.
###
michaeljmarshall commented on code in PR #19270:
URL: https://github.com/apache/pulsar/pull/19270#discussion_r1073983457
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java:
##
@@ -435,6 +435,55 @@ public void
andrasbeni commented on PR #19208:
URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1387544316
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
poorbarcode opened a new pull request, #19275:
URL: https://github.com/apache/pulsar/pull/19275
### Motivation
When `trim ledgers` and `create new cursor` are executed concurrently, it
will cause the `readPosition` of the cursor to point to a deleted ledger.
| time | `trim
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1073892338
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1073882511
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
github-actions[bot] commented on PR #19274:
URL: https://github.com/apache/pulsar/pull/19274#issuecomment-1387481501
@poorbarcode Please add the following content to your PR description and
select a checkbox:
```
- [ ] `doc`
- [ ] `doc-required`
- [ ] `doc-not-needed`
- [
poorbarcode opened a new pull request, #19274:
URL: https://github.com/apache/pulsar/pull/19274
### Issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nlu90 commented on issue #19123:
URL: https://github.com/apache/pulsar/issues/19123#issuecomment-1387478830
+1 for option b.
One note is that there's a switch to enable the access of PulsarAdmin. We
should still keep the switch for SouceContext and SinkContext.
--
This is an
michaeljmarshall commented on code in PR #18130:
URL: https://github.com/apache/pulsar/pull/18130#discussion_r1073869123
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -707,73 +709,96 @@ private void completeConnect(int clientProtoVersion,
501 - 600 of 133596 matches
Mail list logo
