On 9/12/2020 7:25 PM, Jaikiran Pai wrote:
>> On Sat, 12 Sep 2020 17:38:34 GMT, Lance Andersen wrote:
>>
>>>> Can I please get a review and a sponsor for this patch which fixes the
>>>> issue reported in
>>>> https://bugs.openjdk.java.net/browse/JDK-82
On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Hi Naoto,
The change looks fine. I might have created a CSR just to track the doc change.
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/159
On Fri, 11 Sep 2020 14:17:45 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in
On Fri, 11 Sep 2020 22:20:48 GMT, Stuart Marks wrote:
> A simple typo fix.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/137
On Wed, 9 Sep 2020 22:56:14 GMT, Joe Wang wrote:
> Revert changes made by JDK-8249643, removing the implNote.
Based on the spec review and follow-on discussions, this change makes sense
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/100
On Tue, 8 Sep 2020 23:00:21 GMT, Stuart Marks wrote:
>> Add some generics and wrap in `{@code}` to protect angle brackets.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright years.
Marked as reviewed by
On Tue, 8 Sep 2020 22:32:47 GMT, Stuart Marks wrote:
> Add some generics and wrap in `{@code}` to protect angle brackets.
Looks good
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/87
On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added java.io.Serial to java.rmi.activation.ActivationID
On Tue, 8 Sep 2020 18:55:40 GMT, Roger Riggs wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added @java.io.Serial annotation to serializable methods
On Mon, 7 Sep 2020 18:57:11 GMT, Sean Coffey wrote:
>> Continuation of RFR thread from
>> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>>
>> CSR has been approved.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the
On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote:
> Continuation of RFR thread from
> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>
> CSR has been approved.
I think this looks good over all Sean. In your SymLinkTest, I probably would
have the test delete
dated fix for all subtasks of the JDK-8252536
> <https://bugs.openjdk.java.net/browse/JDK-8252536>.
> There is no change in the indentation as part of this webrev.
>
> Regards,
> Vipin
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781
Hi Joe
Looks fine to me
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
> On Sep 1, 2020, at 5:12 PM, Joe Wang wrote:
>
> Please review a fix to report CCE when keys
rFormat.getAvailableLocales();
> * double myNumber = -1234.56;
> * NumberFormat form;
> ---
>
> It is simply to take those HTML tags out of {@code} snippet.
>
> Naoto
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
rds,
>>>>> Sean.
>>>>>
>>>>> On 26/08/2020 23:15, Weijun Wang wrote:
>>>>>> Are you going to update the warning text or create a new one?
>>>>>>
>>>>>> Thanks,
>>>>>> Max
>>>&g
-8252265
> Webrev: https://cr.openjdk.java.net/~vsharma/8252265/
>
> It came up in the below discussion, starting this cleanup with
> java.util.logging package.
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068172.html
>
> Regards,
> Vipin
Best
Lance
---
;
>>> JBS issue: https://bugs.openjdk.java.net/browse/JDK-8251182
>>> Webrev: http://cr.openjdk.java.net/~aefimov/8251182/00/index.html
>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8252310
>>>
>>> With Best Regards,
>>> Aleksei
>>
>
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
s://bugs.openjdk.java.net/browse/JDK-8251182
> Webrev: http://cr.openjdk.java.net/~aefimov/8251182/00/index.html
> CSR: https://bugs.openjdk.java.net/browse/JDK-8252310
>
> With Best Regards,
> Aleksei
Best
Lance
--
Lance Andersen| Principal Member of Technical
> On 8/21/20 12:49 PM, naoto.s...@oracle.com wrote:
>> +1
>>
>> Naoto
>>
>> On 8/21/20 12:24 PM, Lance Andersen wrote:
>>> Hi Joe,
>>>
>>> This looks OK.
>>>
>>>
>>>
>>>> On Aug 21, 2020, at 2:23 P
51561
> CSR: https://bugs.openjdk.java.net/browse/JDK-8251995
>
> webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_01/
>
> Thanks,
> Joe
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1
njdk.java.net/browse/JDK-8252129
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8251203
>
> Thanks, Roger
>
>
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
://cr.openjdk.java.net/~lancea/8252128/webrev.00/
Mach5 jdk-tier1, jdk-tier2, jdk-tier3 are clean (as expected)
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander
xception} the driver is about to throw to the
> application.
> 53 */
> 54 @SuppressWarnings("serial") // Not statically typed as
> Serializable
> 55 private PreparedStatement statement;
>
>
> -Joe
>
> On 8/14/2020 3:37 AM
Hi all,
Please review the fix to address javadoc warnings in java.sql and
java.sql.rowsets
The webrev can be found at:
http://cr.openjdk.java.net/~lancea/8251208/webrev.00/
And the CSR at: https://bugs.openjdk.java.net/browse/JDK-8251834
Best
Lance
--
Lance Andersen
is improved to avoid doclint
> warnings.
>
> best regards,
>
> -- daniel
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Hi Naoto
Thank you for catching that
Will add them before I push the change
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Aug 6, 2020, a
rev.00/
The CSR, which has been approved, can be found at:
https://bugs.openjdk.java.net/browse/JDK-8251206
<https://bugs.openjdk.java.net/browse/JDK-8251206>
Best
Lance
------
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 N
s DefaultHandler
> implements EntityResolver, DTDHandler, ContentHandler, ErrorHandler
> {
> -
> +/**
> + * Constructs a {@code DefaultHandler}.
> + */
> +public DefaultHandler() {}
>
> /////
mail-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
mplements RowSetMetaData, Serializable {
> +/**
> + * Constructs a {@code RowSetMetaDataImpl} object.
> + */
> +public RowSetMetaDataImpl() {}
>
> /**
> * The number of columns in the RowSet object that created
>
Best
Lance
--
Lance Anders
oaderSpi() {}
> +
> +/**
> * Provides the implementation for
> * {@link RMIClassLoader#loadClass(URL,String)},
> * {@link RMIClassLoader#loadClass(String,String)}, and
>
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Jul 23, 2020, at 6:04 PM, Joe Darcy wrote:
>
> Hello,
>
> Martin, how would you prefe
.net/
> [2] https://github.com/cloudflare/zlib
> [3] https://chromium.googlesource.com/chromium/src/third_party/zlib/
> [4] https://github.com/simonis/zlib-bench/blob/master/Results-ojdk.md
> [5] https://github.com/simonis/zlib-bench/blob/master/Results.md
> [6] https://github.com/simon
cle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Hi Roger,
I will plan to push tomorrow morning pending any last minute reviews
Best
Lance
> On Jul 21, 2020, at 9:57 AM, Roger Riggs wrote:
>
> Hi Rafaello, Lance,
>
> That looks good to me.
>
> Thanks, Roger
>
> On 7/19/20 2:31 PM, Lance Andersen wrote:
>
>
> +# jdk_foreign
> +
> +java/foreign/TestMismatch.java 8249684 macosx-all
> +
> +
> +
> # jdk_lang
>
> java/lang/StringCoding/CheckEncodings.sh 7008363 generic-all
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
k.test.lib.RandomFactory
> @@ -144,6 +144,10 @@
> testDecoderKeepsAbstinence(Base64.getDecoder());
> testDecoderKeepsAbstinence(Base64.getUrlDecoder());
> testDecoderKeepsAbstinence(Base64.getMimeDecoder());
> +
> +// tests patch addressing JDK-8222187
> +// https://bugs.openjdk.java.net/browse/JDK-8222187
> +testJDK_8222187();
> }
>
> private static void test(Base64.Encoder enc, Base64.Decoder dec,
> @@ -607,4 +611,26 @@
> }
> }
> }
> +
> +private static void testJDK_8222187() throws Throwable {
> +byte[] orig = "12345678".getBytes("US-ASCII");
> +byte[] encoded = Base64.getEncoder().encode(orig);
> +// decode using different buffer sizes, up to a longer one than
> needed
> +for (int bufferSize = 1; bufferSize <= encoded.length + 1;
> bufferSize++) {
> +try (
> +InputStream in = Base64.getDecoder().wrap(
> +new ByteArrayInputStream(encoded));
> +ByteArrayOutputStream baos = new ByteArrayOutputStream();
> +) {
> +byte[] buffer = new byte[bufferSize];
> +int read;
> +while ((read = in.read(buffer, 0, bufferSize)) >= 0) {
> +baos.write(buffer, 0, read);
> +}
> +// compare result, output info if lengths do not match
> +byte[] decoded = baos.toByteArray();
> +checkEqual(decoded, orig, "Base64 stream decoding failed!");
> +}
> +}
> +}
> }
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
g: " +
aDriver.driver.getClass().getName());
}
}
——
Best,
Lance
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-
Key(name);
> +if(String.class.isInstance(name))
> +return map.containsKey(Name.of((String)name));
> +else
> +return map.containsKey(name);
> }
>
> /**
>
> Thanks & Regards
> Vipin Menon
>
<http://oracle.com/us/d
if (len == 1) {
>>>>> -nextout = 8;// 2 bytes left in bits
>>>>> -break;
>>>>> -}
>>>>> -b[off++] = (byte)(bits >> 8);
>>>>> -if (len == 2) {
>>>>> -nextout = 0;// 1 byte left in bits
>>>>> -break;
>>>>> -}
>>>>> -b[off++] = (byte)bits;
>>>>> -len -= 3;
>>>>> -bits = 0;
>>>>> -} else {
>>>>> -nextin -= 6;
>>>>> +}
>>>>> +if (rpos == 8) {
>>>>> +b[pos++] = (byte) bits;
>>>>> +rpos = 0;
>>>>> +if (pos == limit) {
>>>>> +return limit - off;
>>>>> }
>>>>> }
>>>>> -return off - oldOff;
>>>>> + 8222187
>>>>> +bits = 0;
>>>>> +wpos = 24;
>>>>> +for (;;) {
>>>>> +// Here, pos != limit
>>>>> +int i = is.read();
>>>>> +if (i < 0) {
>>>>> +return eos(b, off, pos, limit);
>>>>> +}
>>>>> +int v = base64[i];
>>>>> +if (v < 0) {
>>>>> +/*
>>>>> +i not in alphabet, thus
>>>>> +v = -2: i is '=', the padding
>>>>> +v = -1: i is something else, e.g., CR or LF
>>>>> + */
>>>>> +if (v == -1) {
>>>>> +if (isMIME) {
>>>>> +continue;
>>>>> +}
>>>>> +throw new IOException("Illegal base64 byte 0x" +
>>>>> +Integer.toHexString(i));
>>>>> +}
>>>>> +return padding(b, off, pos, limit);
>>>>> +}
>>>>> +bits |= (v << (wpos -= 6));
>>>>> +if (wpos != 0) {
>>>>> +continue;
>>>>> +}
>>>>> +if (limit - pos >= 3) {
>>>>> +// frequently taken fast path, no need to track rpos
>>>>> +b[pos++] = (byte) (bits >> 16);
>>>>> +b[pos++] = (byte) (bits >> 8);
>>>>> +b[pos++] = (byte) bits;
>>>>> +bits = 0;
>>>>> +wpos = 24;
>>>>> +if (pos == limit) {
>>>>> +return limit - off;
>>>>> +}
>>>>> +continue;
>>>>> +}
>>>>> +/*
>>>>> +Here, buffer b has either 1 or 2 free places, that is,
>>>>> +limit - pos = 1 or limit - pos = 2.
>>>>> +
>>>>> +As above, this could be coded as a loop. But since the
>>>>> +shift lengths are explicit multiples of 8, better code
>>>>> can be
>>>>> +probably generated.
>>>>> + */
>>>>> +b[pos++] = (byte) (bits >> 16);
>>>>> +if (pos == limit) {
>>>>> +rpos = 16;
>>>>> +return limit - off;
>>>>> +}
>>>>> +b[pos++] = (byte) (bits >> 8);
>>>>> +// Here, pos = limit, no need for an if.
>>>>> +rpos = 8;
>>>>> +return limit - off;
>>>>> +}
>>>>> }
>>>>>
>>>>> @Override
>>>>> diff --git a/test/jdk/java/util/Base64/TestBase64.java
>>>>> b/test/jdk/java/util/Base64/TestBase64.java
>>>>> --- a/test/jdk/java/util/Base64/TestBase64.java
>>>>> +++ b/test/jdk/java/util/Base64/TestBase64.java
>>>>> @@ -144,6 +144,10 @@
>>>>> testDecoderKeepsAbstinence(Base64.getDecoder());
>>>>> testDecoderKeepsAbstinence(Base64.getUrlDecoder());
>>>>> testDecoderKeepsAbstinence(Base64.getMimeDecoder());
>>>>> +
>>>>> +// tests patch addressing JDK-8222187
>>>>> +// https://bugs.openjdk.java.net/browse/JDK-8222187
>>>>> +testJDK_8222187();
>>>>> }
>>>>>
>>>>> private static void test(Base64.Encoder enc, Base64.Decoder dec,
>>>>> @@ -607,4 +611,26 @@
>>>>> }
>>>>> }
>>>>> }
>>>>> +
>>>>> +private static void testJDK_8222187() throws Throwable {
>>>>> +byte[] orig = "12345678".getBytes("US-ASCII");
>>>>> +byte[] encoded = Base64.getEncoder().encode(orig);
>>>>> +// decode using different buffer sizes
>>>>> +for (int bufferSize = 1; bufferSize <= encoded.length + 1;
>>>>> bufferSize++) {
>>>>> +try (
>>>>> +InputStream in = Base64.getDecoder().wrap(
>>>>> +new ByteArrayInputStream(encoded));
>>>>> +ByteArrayOutputStream baos = new
>>>>> ByteArrayOutputStream();
>>>>> +) {
>>>>> +byte[] buffer = new byte[bufferSize];
>>>>> +int read;
>>>>> +while ((read = in.read(buffer, 0, bufferSize)) >= 0) {
>>>>> +baos.write(buffer, 0, read);
>>>>> +}
>>>>> +// compare result, output info if lengths do not match
>>>>> +byte[] decoded = baos.toByteArray();
>>>>> +checkEqual(decoded, orig, "Base64 stream decoding
>>>>> failed!");
>>>>> +}
>>>>> +}
>>>>> +}
>>>>> }
>>>>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
me other means, or even
>> that the warning is because they are using unsigned values.
>>
>> It might be better to tweak the second part to make it a bit clearer, up to
>> you but something like "These attributes are ignored when signing and are
>> not protected by the signature".
>>
>> -Alan
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
L/JarHandlerPkgPrefix/JarHandlerPkgPrefix.java
>
> thank you,
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/
/oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Dri
+1
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
> On Jun 23, 2020, at 5:44 PM, naoto.s...@oracle.com wrote:
>
> Hi,
>
>
v/>
> regards,
> Sean.
>
> On 12/06/2020 17:05, Lance Andersen wrote:
>> Hi Sean,
>>
>> I think your changes look fine so all good FMPOV.
>>
>> Best
>> Lance
>>
>>> On Jun 12, 2020, at 6:21 AM, Seán Coffey >> <mailto:sean.
.net/browse/JDK-8247782
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Anderse
email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
security-dev/2020-January/021141.html
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>La
racle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
gt;> Webrev: http://cr.openjdk.java.net/~redestad/8246129/open.00/
>>
>> Testing: tier1-2
>>
>> Thanks!
>>
>> /Claes
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http
mail-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
/oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
xisting efforts. Thus, I don't have a fix, yet.
>
> I'll be using the example provided in the bug report as a basic test.
>
> I'll show up here once the fix is ready.
>
>
> Greetings
> Raffaello
>
>
>
> On 2020-06-08 22:34, Lance Andersen wrote:
>>
324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineer
ig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
re around
>>>> the whole second, e.g., expected == 18:14:22.99 and test ==
>>>> 18:14:23.01. To fix this, check the difference of those objects and
>>>> ensure it is less than a second.
>>>>
>>>> Similar test cases exist in
racle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1
/product/9780596528126.do Is it a newer print of the
>> same edition? It does looks like it.
>> I would use the original patch as is.
>> -Pavel
>>> On 30 May 2020, at 19:13, naoto.s...@oracle.com wrote:
>>>
>>> Just noticed that the release year of the 3rd ed.
* @see java.lang.String#split(String, int)
ljanders-mac:open ljanders$
Best
Lance
> On May 30, 2020, at 2:30 PM, Lance Andersen wrote:
>
> Thank you Naoto, I am building now with both changes and will send a final
> diff out later along with the bug number!
>
>
he next line.
>
> Naoto
>
> On 5/30/20 4:02 AM, Lance Andersen wrote:
>> I can sponsor this for you
>> Best
>> Lance
>> --
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
&g
I can sponsor this for you
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On May 29, 2020, at 10:25 PM, Hong Shao Yang wrote:
>
> H
gt;> David
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
242281/webrev.00/
>
> Regards,
> Conor
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-e
us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Hi Connor,
You will want to add the label noreg-doc to the issue before you push for fix
Best
Lance
> On May 29, 2020, at 6:25 AM, Lance Andersen wrote:
>
> looks fine Connor
>
>> On May 29, 2020, at 5:37 AM, Conor Cleary wrote:
>>
>> Hi,
>>
>
p://openjdk.java.net/jeps/385
>> Thanks,
>> s'marks
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
nger needed.
>
> best regards,
>
> -- daniel
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email
/browse/JDK-8245068
>
> JEP:
>
>http://openjdk.java.net/jeps/385
>
> Thanks,
>
> s'marks
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-1
-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
t;> Please review a fix for the compilation warnings. Thanks Roger for the
>>>> detailed instructions! If you could verify the fix with the
>>>> work-in-progress processor, that would be great too. Regular build and
>>>> test passed.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8244342
>>>> http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
>>>>
>>>> Thanks,
>>>> Joe
>>>
>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
about to how to proceed with this, if at all or would
>> someone sponsor this patch?
>> Regards,Philipp
>>
>> [1]
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-December/064149.html
>>
> <20200517-splashscreenimageunicodetestwithoutunicode
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
> -- daniel
>>>>
>>>> On 15/05/2020 13:35, Pavel Rappo wrote:
>>>>> Hello,
>>>>>
>>>>> Please review this trivial change for
>>>>> https://bugs.openjdk.java.net/browse/JDK-8245111:
>>>>>
>&g
262144
> avgt3 ≈ 0 counts
> ZipFileGetInputStream.readAllBytes 1048576
> avgt3 2989.236 ± 8.808 us/op
> ZipFileGetInputStream.readAllBytes:·gc.alloc.rate.norm1048576
> avgt3 824.184 ± 0.002B/o
/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
24.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
ations.
>>>
>>> getManifestFromJarWithNoManifest exercise JUZFA.getMetaInfEntryNames in
>>> the baseline, and now calls JUZFA.getManifestName. Result is a 1.25x
>>> speed-up and 30% reduction in allocations. While unrealistic (most JARs
>>> have a META-I
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Apr 28, 2020, at 8:53 PM, Mandy Chung wrote:
>
> diff --git a/src/java.base/share/classes/
gt;>
>>> open.01:
>>> Benchmark (size) Mode CntScore Error
>>> Units
>>> ZipFileGetEntry.getEntryHit 512 avgt 15 84.450 ± 5.474
>>> ns/op
>>> ZipFileGetEntry.getEntryHit 1024 avgt 15 85.224 ± 3.776
>>> ns/op
>>> ZipFileGetEntry.getEntryHitUncached 512 avgt 15 140.448 ± 4.667
>>> ns/op
>>> ZipFileGetEntry.getEntryHitUncached 1024 avgt 15 145.046 ± 7.363
>>>
>>> [2] I stopped short of taking the cleanup a step further by decoding to
>>> String even in initCEN, which sadly isn't performance neutral:
>>>
>>> http://cr.openjdk.java.net/~redestad/8243469/open.01.init_decode/
>>>
>>> Something for the future to consider, maybe.
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
njdk.java.net/browse/JDK-8243469
>
> Testing: tier1-2
>
> Thanks!
>
> /Claes
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<htt
browse/JDK-8243010
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Hi Volker
> On Apr 22, 2020, at 4:08 PM, Volker Simonis wrote:
>
> On Tue, Apr 21, 2020 at 5:23 PM Lance Andersen
> wrote:
>>
>> Hi Volker,
>>
>> I think overall this looks OK. I went through the older SCCS histories to
>> see if I could figure
es.
>> Testing: tier1+2
>> Thanks!
>> /Claes
>> [1] https://twitter.com/retronym/status/1252134723431747584?s=20
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
gt; big Java source file from "src.zip" but I'm not sure if "src.zip" is
> always available in the jdk images which are used to run the
> microbenchmarks. Do you think the test it is fine this way or do you
> have a better idea? I saw that "ZipFind" uses "micr
ibrary is a bit of a black box usually approached from the angle of
> existing tests.
> And unfortunately, there is a lower bar for documentation and API development.
> Perhaps an item to be looked at as part of the new developer guide project.
>
> Thanks, Roger
>
>
>
>
a.net/~rriggs/webrev-hexprinter-8243010/
>
> [3] Issue:
> https://bugs.openjdk.java.net/browse/JDK-8243010
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324
up).
>
> Thanks!
>
> /Claes
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>L
Looks good thank you Claes
> On Apr 16, 2020, at 11:27 AM, Claes Redestad
> wrote:
>
> Lance,
>
> On 2020-04-16 16:33, Lance Andersen wrote:
>> I think this looks good. I few minor comments/suggestions:
>> * JavaUtilZipFileAccess.java:Please update th
us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
https://bugs.openjdk.java.net/browse/JDK-8145260
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-
-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
allers should make no assumptions about the identity of the returned
> instances.
> * Factories are free to create new instances or reuse existing ones.
> Therefore,
>
>
>
>
> On 4/8/20 2:33 PM, Lance Andersen wrote:
>> Hi Stuart,
>> This looks good
>>>
us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.
p://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
s or reuse existing ones.
> Therefore,
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-s
le.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Te
tp://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
a.net/browse/JDK-8225319
>
> [3] Deprecate rmic for removal
> https://bugs.openjdk.java.net/browse/JDK-8217412
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-s
isitor(ClassVisitor cv, ObjectStreamField[]
> spf) {
>
>
> -Chris.
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
comment prior to the declaration, resulting in an invalid XML document.
>>>>> The patch focuses on fixing this issue, but it does not cover other
>>>>> issues the StAXResult impl may have (e.g. JDK-8241711).
>>>>>
>>>>> JBS: https://bugs.o
501 - 600 of 1866 matches
Mail list logo
