Changeset: 809e8db0c142
Author:chegar
Date: 2011-07-29 10:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/809e8db0c142
6978200: ServerSocket.toString include port=0 in the returned String
Summary: Removal of port=0 from ServerSocket.toString method
Reviewed-by: alanb,
Hi,
This test creates temporary directories in the scratch area with spaces
in their names. It fails on Cygwin because jtreg cannot cleanup after
it. Easiest to just have the test cleanup (minimally) after itself.
Webrev:
http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Subject: Code Review 7073295: TEST_BUG:
test/java/lang/instrument/ManifestTest.sh causing havoc (win)
Date: Tue, 09 Aug 2011 14:05:08 +0100
From: Chris Hegarty chris.hega...@oracle.com
Hi Dan, Alan,
This is a trivial change to use /dev/null instead of NUL for Windows
test with Cygwin.
http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/
Thanks,
-Chris.
Changeset: 26fe74aa48ef
Author:chegar
Date: 2011-08-09 16:39 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26fe74aa48ef
7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win)
Reviewed-by: mchung
! test/java/lang/instrument/ManifestTest.sh
that cannot be deleted. This causes the remaining
tests to also fail.
Thanks for the review,
-Chris.
On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote:
On 8/9/11 8:52 AM, Chris Hegarty wrote:
Hi Dan, Alan,
This is a trivial change to use /dev/null instead of NUL for Windows
test with Cygwin.
http
Changeset: cf203f293b4e
Author:chegar
Date: 2011-08-09 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf203f293b4e
7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in
Cygwin
Reviewed-by: alanb, dcubed
! test/com/sun/jdi/ShellScaffold.sh
hundred
failures then we should be good ;-)
-Chris.
- jjh
On 8/9/2011 8:56 AM, Chris Hegarty wrote:
Sorry Dan, I'll put a more complete description in the bug report.
This issue, from what I can tell only happens with very recent Cygwin
versions. I'm running 1.7.9. When running the com/sun
On 08/ 9/11 05:11 PM, Daniel D. Daugherty wrote:
On 8/9/11 8:29 AM, Chris Hegarty wrote:
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Subject: Code Review 7073295: TEST_BUG:
test/java/lang/instrument/ManifestTest.sh causing havoc
Changeset: af15e902cf08
Author:chegar
Date: 2011-08-10 12:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08
7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail
with NPE
Reviewed-by: alanb
!
Changeset: 46b53f80ab0a
Author:chegar
Date: 2011-08-19 10:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46b53f80ab0a
7025938: Add bitmap mime type to content-types.properties
Reviewed-by: chegar, alanb, michaelm
Contributed-by: lvj...@linux.vnet.ibm.com
!
Changeset: 5c1f90dd0405
Author:chegar
Date: 2011-08-22 14:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c1f90dd0405
7023713: HttpCookie.domainMatches(hostname.local, hostname) should return
true
Reviewed-by: chegar
Contributed-by: zho...@linux.vnet.ibm.com
!
Changeset: c9e78769c0da
Author:chegar
Date: 2011-08-25 16:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da
7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on
SUSE Linux 10
Reviewed-by: alanb, chegar
Contributed-by:
Changeset: fcb33500b325
Author:chegar
Date: 2011-09-01 13:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcb33500b325
7041800: URI.equals may incorrectly return true with escaped octets
Reviewed-by: alanb, michaelm
! src/share/classes/java/net/URI.java
!
Changeset: 5b8f8397379f
Author:chegar
Date: 2011-09-03 07:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b8f8397379f
7084032: test/java/net/Inet6Address/B6558853.java fails on Windows XP/2003 if
IPv6
Reviewed-by: chegar
Contributed-by: kurchi.subhra.ha...@oracle.com
!
Sean,
The changes look good, though I haven't gone through the test in much
detail!
One question that is not directly related to your changes, but may be
applicable.
Shouldn't the close on FileChannel also check the value of the use count
before closing the native fd? For example:
Changeset: 75d763111eec
Author:chegar
Date: 2011-09-16 12:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75d763111eec
7090158: Networking Libraries don't build with javac -Werror
Summary: Minor changes to networking java files to remove warnings
Reviewed-by: chegar,
I see that CR 7015589 was integrated into JDK8 b04.
-Chris.
On 09/22/11 09:40 AM, Jing Lv wrote:
Hi Alan,
I see the status of 7015589 has changed to fix delivered, so is this
fix in the repository(java8?) already?
On 2011/8/9 19:43, Alan Bateman wrote:
A few months back there was a bug
This change is coming from Doug Lea's CVS and I've already review it.
It seems that in the re-work that was done for Java 7 we dropped this
corner case.
STPE.delayedExecute will add the task to the work queue and invoke
prestartCoreThread. But prestartCoreThread checks for the worker count
Changeset: 8dab38c07b6b
Author:dl
Date: 2011-09-23 14:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8dab38c07b6b
7091003: ScheduledExecutorService never executes Runnable with corePoolSize of
zero
Reviewed-by: dholmes, chegar
!
Changeset: 8876d1dec4d7
Author:chegar
Date: 2011-09-26 15:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8876d1dec4d7
7094141: test/sun/misc/JarIndex/metaInfFilenames/Basic.java no longer compiles
Reviewed-by: alanb
! test/sun/misc/JarIndex/metaInfFilenames/Basic.java
Changeset: 7f1aca641910
Author:chegar
Date: 2011-09-26 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f1aca641910
7084030: DatagramSocket.getLocalAddress inconsistent on XP/2003 when IPv6
enabled and socket is connected
Summary: Use family of connected IP address to
Trivially, should the main thread in the test be waiting on the three
other threads to complete before exiting?
I think jtreg will try to cleanup once the main thread completes. The
main thread should keep an array of the threads it creates and invoke
join() on each of them before returning
Changeset: 74f5fef1d961
Author:chegar
Date: 2011-10-04 13:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74f5fef1d961
6953455: CookieStore.add() cannot handle null URI parameter, contrary to the API
Reviewed-by: chegar, mduigou
Contributed-by:
Changeset: 24741fe639a8
Author:chegar
Date: 2011-10-04 16:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24741fe639a8
7095949: java/net/URLConnection/RedirectLimit.java and Redirect307Test fail
intermittently
Reviewed-by: alanb
!
we can get more stable test runs.
-Chris.
On 04/10/2011 17:04, David Holmes wrote:
Thanks Chris and Alan.
On 4/10/2011 11:24 PM, Alan Bateman wrote:
Chris Hegarty wrote:
Trivially, should the main thread in the test be waiting on the three
other threads to complete before exiting?
I think
/11 7:07 AM, Chris Hegarty wrote:
Alan, David,
I noticed CR 7027061 was closed as 'not a defect'. Should I file a new
CR to have the jtreg test fixed (join on all created threads)? The test
will still exercise what it is supposed to, and the
ConcurrentModificationException issue can be investigated
will look into this. Reopened the original CR.
Naoto
On 10/5/11 9:58 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Naoto, David
I filed CR 7098100: java/util/Locale/Bug6989440.java fails
intermittently.
If you're ok with it please review the patch (below) and I can push it
to the tl repo
Changeset: ff5e57dc1fb3
Author:chegar
Date: 2011-10-06 12:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5e57dc1fb3
7090499: missing rawtypes warnings in anonymous inner class
Summary: Fix anonymous inner classes with raw types currently being built in
the jdk with
I filed CR 7098394 against this.
Solaris 10 x64 build fails since the integration of CR 7092679.
../../../src/solaris/native/java/util/TimeZone_md.c, line 128:
prototype mismatch: 2 args passed, 3 expected
../../../src/solaris/native/java/util/TimeZone_md.c, line 128:
warning: improper
populated. We need to use a temporary
for the new ArrayList and only assign to availableJRELocales after it is
populated.
In addition, as you mentioned, availableJRELocales needs to be volatile
for this DCL pattern to be correct.
Thanks,
David
On 6/10/2011 9:02 PM, Chris Hegarty wrote:
I see
Since the integration of the fix for CR 7094141, it has come to light
that the test should be using the supported compiler interface,
com.sun.tools.javac.Main. CR 7094141 was a little rushed so that the
failing test would not prevent TL integration into the MASTER repo.
There should be less
Changeset: 1e89a13d9d8f
Author:chegar
Date: 2011-10-10 10:38 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e89a13d9d8f
7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work
correctly with System.gc()
Reviewed-by: michaelm
!
before it gets populated. We need to use a
temporary
for the new ArrayList and only assign to availableJRELocales after
it is
populated.
In addition, as you mentioned, availableJRELocales needs to be
volatile
for this DCL pattern to be correct.
Thanks,
David
On 6/10/2011 9:02 PM, Chris Hegarty
to availableJRELocales after
it is
populated.
In addition, as you mentioned, availableJRELocales needs to be
volatile
for this DCL pattern to be correct.
Thanks,
David
On 6/10/2011 9:02 PM, Chris Hegarty wrote:
I see several exceptions, similar to the following (numbers vary):
Exception in thread
Changeset: 2a36b8741363
Author:chegar
Date: 2011-10-10 15:29 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a36b8741363
7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use
supported compiler interface
Reviewed-by: mcimadamore
!
On 10/10/2011 15:52, Alan Bateman wrote:
Chris Hegarty wrote:
Naoto,
Forgot to add, you can probably just push the changes for the test
along with your source changes. I modified it a little since last
review. Reproduces one in about every ten times on one of our Dual
core Linux x64 boxes
Changeset: 5bfe2de1157b
Author:chegar
Date: 2011-10-11 12:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfe2de1157b
7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in
fix for 7098719
Reviewed-by: coffeys
!
bugs?
David
On 11/10/2011 1:44 AM, Chris Hegarty wrote:
On 10/10/2011 15:52, Alan Bateman wrote:
Chris Hegarty wrote:
Naoto,
Forgot to add, you can probably just push the changes for the test
along with your source changes. I modified it a little since last
review. Reproduces one in about every
I think I seen in a previous mail that you didn't have access to Solaris
machines? I'll grab your patch, apply to a latest jdk8 TL repo and do
some sanity builds on Solaris if you like?
-Chris.
On 10/13/11 01:43 PM, Alan Bateman wrote:
Neil Richards wrote:
:
Will there need to be two bug
solaris_x64_5.10-product
linux_i586_2.6-product
-Chris.
On 10/13/11 03:05 PM, Neil Richards wrote:
On Thu, 2011-10-13 at 14:03 +0100, Chris Hegarty wrote:
I think I seen in a previous mail that you didn't have access to Solaris
machines? I'll grab your patch, apply to a latest jdk8 TL repo and do
some
Changeset: 634cd6f050ba
Author:chegar
Date: 2011-10-20 09:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/634cd6f050ba
7102704: test/java/net/DatagramSocket/ChangingAddress.java failing
Reviewed-by: chegar
Contributed-by: kurchi.subhra.ha...@oracle.com
-
It appears that the only function of librmi is to export the VM function
JVM_LatestUserDefinedLoader. It seems really silly to have a whole
native library to perform such a trivial operation.
JVM_LatestUserDefinedLoader is also used in java.io.ObjectInputStream.
It would make more sense to
Thanks Mike,
It was actually Alan that caught this. Crazy that someone ( at some time
) even thought this was a good idea!
-Chris.
On 24/10/2011 15:41, Mike Duigou wrote:
Looks good. Nice catch.
Mike
On Oct 24 2011, at 07:20 , Chris Hegarty wrote:
It appears that the only function
Changeset: 3f391e649ccb
Author:chegar
Date: 2011-10-24 20:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f391e649ccb
7104209: Cleanup and remove librmi (native library)
Reviewed-by: mduigou, alanb
! make/java/java/mapfile-vers
! make/sun/rmi/rmi/Makefile
-
Changeset: b375523d6037
Author:chegar
Date: 2011-10-24 21:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b375523d6037
7103549: Remove dependencies on libjava and libjvm from security libraries
Reviewed-by: vinnie, ohair, alanb, dholmes
!
D'oh! Sorry my fault.
The changes look good, and thanks for taking care of this.
-Chris.
On 10/25/11 09:08 AM, Alan Bateman wrote:
It turns out there's a problem with these changes as it didn't remove
the code to load the rmi library (we missed it in the code review too).
The result is that
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build with
Maurizio's patch and all went well. I can also still do a clean build (
but I build
On 10/25/11 12:26 PM, David Holmes wrote:
On 25/10/2011 8:48 PM, Chris Hegarty wrote:
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build
On 10/25/11 12:26 PM, David Holmes wrote:
On 25/10/2011 8:48 PM, Chris Hegarty wrote:
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build
On 10/25/11 12:51 PM, David Holmes wrote:
On 25/10/2011 9:39 PM, Chris Hegarty wrote:
On 10/25/11 12:26 PM, David Holmes wrote:
I suspect this is another case of a partial build causing files to be
compiled with different settings. I'll try another clean build.
Yeap, kinda but officially
To close the loop on this one. I filed CR
7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util
And posted a request for review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-October/007995.html
-Chris.
On 10/25/11 12:56 PM, Chris Hegarty wrote:
On 10/25/11
The changes to remove warnings from the NIO code (7068616) missed
java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not
spotted at the time as the compiler was not generating raw type warnings
for anonymous inner classes. It does now, see CR 7090499.
This is not an issue when
, Chris Hegarty wrote:
The changes to remove warnings from the NIO code (7068616) missed
java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not
spotted at the time as the compiler was not generating raw type
warnings for anonymous inner classes. It does now, see CR 7090499.
Looks fine
On 11/ 7/11 10:45 PM, David Holmes wrote:
On 8/11/2011 6:50 AM, Brian Goetz wrote:
Wait/notify may be better than sleeping, but semaphore/latch/barrier
are much better than wait/notify. Much.
Don't be hasty. This test is using Thread.stop - which as we all know is
a Very Bad Thing. You want
According to the specification for BlockingQueue.drainTo(Collection c,
int maxElements), this method should return the number of elements
transferred. However the implementation of this method for
LinkedBlockingQueue and LinkedBlockingDeque when given a negative number
returns the given
9 2011, at 06:55 , Chris Hegarty wrote:
According to the specification for BlockingQueue.drainTo(Collection c, int maxElements),
this method should return the number of elements transferred. However the
implementation of this method for LinkedBlockingQueue and LinkedBlockingDeque when given
On 10/11/2011 05:34, David Holmes wrote:
On 10/11/2011 3:03 AM, Chris Hegarty wrote:
On 09/11/2011 16:44, Mike Duigou wrote:
The change looks good.
The creation of node instances could use diamond. ie.
Yes, this was my initial reaction too.
Since Doug's CVS is also built with JDK6 I guess
Changeset: d6a5da5f6ba0
Author:dl
Date: 2011-11-10 12:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6a5da5f6ba0
7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns
'maxElements' if its value is negative
Reviewed-by: chegar, mduigou, dholmes
!
Changeset: 68fc55d12ae6
Author:chegar
Date: 2011-11-14 10:06 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68fc55d12ae6
7107020: java.net.PlainSocketImpl.socketSetOption() calls itself
Reviewed-by: alanb, chegar
Contributed-by: kurchi.subhra.ha...@oracle.com
!
On 11/21/11 08:10 PM, Rob McKenna wrote:
webrev : http://cr.openjdk.java.net/~robm/7095949/webrev.00/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7095949
Looks fine to me.
Thanks for porting this to 7u-dev. These intermittent failures are a
real pain!
-Chris.
-Rob
This change does look good.
Not directly related to your changes Neil, and I know we swallow
InterruptedException in many tests, but does it make sense to set
keepRunning = false if the GcInducingThread is interrupted?
jtreg will use Thread.interrupt when trying to cleanup after the test
On 11/22/11 06:56 PM, Alan Bateman wrote:
On 22/11/2011 17:22, Neil Richards wrote:
:
Can you tell me, when jtreg decides to fire an interrupt at a test, has
it already concluded that the test has failed (or, at least, not
passed) ?
With othervm (the default) then each test is run in its own
Looks good to me. Thanks for taking it.
-Chris.
On 11/22/11 07:47 PM, Gary Adams wrote:
Here's another test that had an assumption that the threads
would terminate within a 10 second window. On a busy or
slow machine this limit may not be sufficient. Since the jtreg
harness uses 120 second
Changeset: 7eb0debca9b3
Author:chegar
Date: 2011-11-23 12:30 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7eb0debca9b3
6776144: java/lang/ThreadGroup/NullThreadName.java fails with Thread group is
not destroyed ,fastdebug LINUX
Reviewed-by: chegar, dholmes
Contributed-by:
On 11/23/11 01:29 PM, Neil Richards wrote:
On Tue, 2011-11-22 at 19:09 +, Chris Hegarty wrote:
On 11/22/11 06:56 PM, Alan Bateman wrote:
On 22/11/2011 17:22, Neil Richards wrote:
:
Can you tell me, when jtreg decides to fire an interrupt at a test, has
it already concluded
Changeset: e5ecbf555679
Author:chegar
Date: 2011-11-25 13:46 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ecbf555679
7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor
Reviewed-by: chegar, alanb
Contributed-by: sa...@taobao.com
!
On 11/29/11 06:19 PM, Lance Andersen - Oracle wrote:
Looks good to me
Me too.
Just one minor opportunity for use of in ObjectInputStream
Class?[] classObjs = new Class*?*[interfaces.length];
---
Class?[] classObjs = new Class[interfaces.length];
-Chris.
Best
Lance
On Nov 29, 2011, at
On 11/29/11 06:12 PM, Lance Andersen - Oracle wrote:
looks ok to me...
+1
-Chris.
On Nov 29, 2011, at 11:19 AM, Alan Bateman wrote:
On 28/11/2011 08:36, Jing Lv wrote:
Hello Alan,
I am fine with the fix on the webrev, suppose it would be applied later?
I don't remember (as it's
I started to look at the reason why we suppressed unchecked warning for
sun.misc.Service in a few places, and this lead me into some other
sun.misc classes. Here's a change that fixes a few warnings in this area.
http://cr.openjdk.java.net/~chegar/7116722/webrev.00/webrev/
-Chris.
On 01/12/2011 10:20, Alan Bateman wrote:
On 30/11/2011 22:34, chris hegarty wrote:
Thanks for all the feedback.
changes:
- use diamond in JarIndex (style issue)
- sun.misc.Service - java.util.ServiceLoader
in InetAddress and HttpServerProvider
- ExtensionDependency: suppress unchecked
This is a follow up to an issue that came up during discussion of
another fix. Essentially, ScriptEngineManager should use
j.u.ServiceLoader rather than sun.misc.Service.
http://cr.openjdk.java.net/~chegar/7116957/webrev.00/webrev/
-Chris.
P.S. and fix up imports in HttpServerProvider
This is a follow up to an issue that came up during discussion of
another fix. Essentially, JDK classes should use j.u.ServiceLoader
rather than sun.misc.Service.
http://cr.openjdk.java.net/~chegar/7116946/webrev.00/webrev/
And a few warning cleanups, given the date that's in it ;-) Since
On 01/12/2011 16:27, Sebastian Sickelmann wrote:
Thanks for the good feedback.
I splitted my change to the trivial part and will start discussion of
FilePermission change on core-libs-dev after the cleanup event.
I created a new webrev with the suggested changes here[2]
[2]
Changeset: f615db07991e
Author:chegar
Date: 2011-12-02 11:39 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f615db07991e
7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service
providers
Reviewed-by: prr
!
On 02/12/2011 13:49, Lance Andersen - Oracle wrote:
Looks good to me
Thumbs up from me too.
-Chris.
Best
Lance
On Dec 2, 2011, at 8:42 AM, Alan Bateman wrote:
I'm down on the sign-up sheet for warnings in a couple of arcane areas. The
following webrev fixes the warnings in
Cleanup compiler warnings in the java.util.concurrent.atomic package.
This is a sync up with the raw type warning fixes in Doug's CVS, along
with some minor style cleanup.
With this change there are still 2 outstanding unchecked casts in
AtomicReferenceArray and AtomicReferenceFieldUpdater.
, Chris Hegarty wrote:
Cleanup compiler warnings in the java.util.concurrent.atomic package.
This is a sync up with the raw type warning fixes in Doug's CVS, along
with some minor style cleanup.
With this change there are still 2 outstanding unchecked casts in
AtomicReferenceArray
On 12/ 2/11 04:22 PM, Doug Lea wrote:
We just went through these and others, and believe that everything
is now warning free.
Thanks Doug, Wow you guys are quick!
I pulled in these specific changes (atomic) and updated the webrev:
know, just trying to make
life a little easier in the future ;-)
Thanks for the review,
-Chris.
David
On 3/12/2011 3:18 AM, Chris Hegarty wrote:
On 12/ 2/11 04:22 PM, Doug Lea wrote:
We just went through these and others, and believe that everything
is now warning free.
Thanks Doug
Cleanup warnings in the j.u.c. package.
This is a sync up with the warning fixes in Doug's CVS. There are also a
few style cleanups, import fixes, trivial local variable renaming,
typos, etc. But nothing too surprising!
http://cr.openjdk.java.net/~chegar/7118066/webrev.00/webrev/
-Chris.
Changeset: f352dd3cdff8
Author:dl
Date: 2011-12-05 13:58 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f352dd3cdff8
7117360: Warnings in java.util.concurrent.atomic package
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java
!
comments on while-loop to for-loop conversions as for LTQ
Same answer ;-)
Thanks,
-Chris.
On 6/12/2011 1:36 AM, Chris Hegarty wrote:
Cleanup warnings in the j.u.c. package.
This is a sync up with the warning fixes in Doug's CVS. There are also a
few style cleanups, import fixes, trivial
Thanks David and Doug,
So we should be ready to integrate this change, right? NO, not yet!
There is a failing regression test, java.util.Collections.EmptyIterator.
This test does a reference comparison ( '==' ) on the iterator returned
from an empty SynchronousQueue and the iterator returned
the
private implementation of SynchronousQueue.
-Chris.
Mike
On Dec 8 2011, at 03:33 , Chris Hegarty wrote:
On 08/12/2011 05:13, David Holmes wrote:
I also think the SynchronousQueue has no business being used in this
test. Though I confess I'm unclear what this test
Changeset: 33ac7a057b9c
Author:chegar
Date: 2011-12-16 16:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33ac7a057b9c
7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly
cookies
Reviewed-by: michaelm
! src/share/classes/java/net/HttpCookie.java
On 23/12/2011 21:55, David Holmes wrote:
Hi Brandon,
This looks okay to me.
Thumbs up from me too.
-Chris.
Just to clarify for other readers, the change to CopyOnWriteArrayList
doesn't use Objects.requireNonNull because this code has to sync up with
Doug Lea's jsr166 repository which
Changeset: 5aeefe0e5d8c
Author:chegar
Date: 2012-01-01 09:24 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aeefe0e5d8c
7125055: ContentHandler.getContent API changed in error
Reviewed-by: alanb
! src/share/classes/java/net/ContentHandler.java
!
Vote: yes
-Chris.
I created CR 7128584: Typo in sun.misc.VM's private directMemory field
comment, for this issue, and will push Kris' change with Remi and
myself as reviewer and listing Kris as the contributor.
Thanks,
-Chris.
On 01/10/12 08:22 AM, Rémi Forax wrote:
I think it's better if it has it's own bug
Changeset: d72de8b3fe36
Author:chegar
Date: 2012-01-10 10:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72de8b3fe36
7123415: Some cases of network interface indexes being read incorrectly
Reviewed-by: chegar
Contributed-by: brandon.passan...@oracle.com
!
Changeset: bba276a6aa0d
Author:chegar
Date: 2012-01-10 12:48 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba276a6aa0d
7128584: Typo in sun.misc.VM's private directMemory field comment
Reviewed-by: forax, chegar
Contributed-by: Krystal Mok sa...@taobao.com
!
Changeset: 31a1fc60a895
Author:chegar
Date: 2012-01-11 10:52 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a1fc60a895
7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map
Reviewed-by: michaelm
!
test/java/lang/annotation/loaderLeak/Main.java -
java/lang/annotation/loaderLeak/Main.java
,otherwise fine.
Thanks for adding these, I've been running into them also.
-Chris.
On 16/01/2012 16:12, Alan Bateman wrote:
It's time to sync up test/ProblemList.txt again as it's currently not
Changeset: e8a143213c65
Author:chegar
Date: 2012-01-16 18:05 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a143213c65
7129083: CookieManager does not store cookies if url is read before setting
cookie manager
Reviewed-by: michaelm
!
Alan,
I'd like to use this CR to backport some similar changes to 7u4. I guess
this is a request for review of the following, for 7u-dev:
--- a/test/ProblemList.txt Mon Jan 16 18:05:29 2012 +
+++ b/test/ProblemList.txt Tue Jan 17 12:09:17 2012 +
@@ -195,6 +195,9 @@
OK, lets backport 7130398 as is to 7u4. And I'll look at 6671616.
-Chris.
On 01/17/12 12:23 PM, Alan Bateman wrote:
On 17/01/2012 12:05, Chris Hegarty wrote:
Alan,
I'd like to use this CR to backport some similar changes to 7u4. I
guess this is a request for review of the following, for 7u
On Solaris, this test looks in /dev/dsk for block special devices.
Unfortunately, /dev/dsk is empty within a zone. Also unfortunately, on a
non-zone Solaris machine, /dev/dsk is filled with symlinks to the actual
device nodes.
On Linux, this test looks at /dev/ide0 and /dev/scd0 which are
Changeset: 40d699d7f6a1
Author:chegar
Date: 2012-01-17 14:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d699d7f6a1
6671616: TEST_BUG: java/io/File/BlockIsDirectory.java fails when /dev/dsk empty
(sol)
Reviewed-by: alanb
! test/ProblemList.txt
-
This issue was raised on the jdk7u-dev mailing list [1].
The change is to update the FutureTask implementation to what is in
Doug's CVS. The old implementation using AbstractQueuedSynchronizer is
replaced with a control state field that is updated by CAS to track
completion, along with a
801 - 900 of 2067 matches
Mail list logo
