[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @michaelandrepearce Seems there is some problem with the Git due to which this build failed. Could you please check and let me know. ---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165331496 --- Diff:

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1834#discussion_r16533 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -841,7

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @michaelandrepearce I will warn the PM squad :+1: ---

[GitHub] activemq-artemis issue #1822: Allow existing empty tables

2018-02-01 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1822 @nlippke Agree with @michaelandrepearce: could you please create a JIRA for it and include it into the commit? > Is there a way to ask jenkins for a new build? This build error

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330750 --- Diff:

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

2018-02-01 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1829 @cshannon Perfect, thanks :+1: ---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165352116 --- Diff:

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @RaiSaurabh Please rebase it and force push it to re-trigger a Jenkins build and hopefully it will pass ---

[GitHub] activemq-artemis pull request #1835: ARTEMIS-1651 Allow custom etc and data ...

2018-02-01 Thread dejanb
GitHub user dejanb opened a pull request: https://github.com/apache/activemq-artemis/pull/1835 ARTEMIS-1651 Allow custom etc and data directories to be used You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejanb/activemq-artemis

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

2018-02-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1834 Couple of things... - All changes should be squashed into a single commit - The commit message should follow the pattern described in the [Hacking

[GitHub] activemq-artemis pull request #1836: ARTEMIS-1652 XmlDataImporter forgets de...

2018-02-01 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1836 ARTEMIS-1652 XmlDataImporter forgets delete tmp files When using the tool to import more than one large messages from xml exported file, this utility class will create some tmp

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @gtully yes there is a use case for the client part here in our org, thus why. I'd rather do this fully, than partial. @mtaylor or anyone with access, can someone look

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @franz1981 I think there’s a general Jenkins PR build issue. If you have direct ping ability or nudge directly Martyn or Clebert or someone on PM ? ---

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

2018-02-01 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r16574 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@ protected

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

2018-02-01 Thread cshannon
Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1829#discussion_r165333289 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -571,6 +571,8 @@ public

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce to make the feature work is trivial in queueimpl; to make it dynamic is a lot of code. I would have been shooting for an address setting and pulling that value in

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330940 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165331112 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java

Re: Alter/change queue depth using Java/JMX

2018-02-01 Thread Justin Bertram
This is a community mailing list for developers of the Apache ActiveMQ project. Red Hat JBoss AMQ is what we call a "downstream" commercial product. If you need help with it you should contact Red Hat for support. This community only supports the "upstream" project. Justin On Thu, Feb 1, 2018

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330188 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java ---

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165348688 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce Hey Michael. I think this was a temp failure. There is an Artemis PR job running now that doesn't show the git clone problem. The CI is shared and there are a bunch

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1829#discussion_r165317614 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -571,6 +571,8 @@ public

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330595 --- Diff:

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

2018-02-01 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/1829 @franz1981 - I updated the PR, is this ok to merge now? ---

Re: RedHat JBoss-AMQ-Alter/configure Queue Depth

2018-02-01 Thread Justin Bertram
This is a community mailing list for developers of the Apache ActiveMQ project. Red Hat JBoss AMQ is what we call a "downstream" commercial product. If you need help with it you should contact Red Hat for support. This community only supports the "upstream" project. Justin On Thu, Feb 1, 2018

[GitHub] activemq-artemis issue #1775: ARTEMIS-1587 Add setting to control the queue ...

2018-02-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1775 @stanlyDoge, yes, I think so. ---

[RESULT][VOTE] Apache ActiveMQ 5.15.3

2018-02-01 Thread Christopher Shannon
Results of the Apache ActiveMQ 5.15.3 vote: Vote passes with 4 +1 binding votes. The following votes were received: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Gary Tully +1 Clebert Suconic Non-Binding +1 Francois Papon I'll start pushing out the release bundles and update the Wiki.

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

2018-02-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1834 Could you update the SSL documentation in docs/user-manual/en/configuring-transports.md to include the new "sslProvider" parameter including a short explanation of why the JDK provider

Re: [DISCUSS] Rework NMS.AMQP

2018-02-01 Thread cmorgan
I have updated the README.md file in the fork, see https://github.com/cjwmorgan-sol-sys/nms-amqp, for the project to show the features supported by the amqp provider. Let me know if there are any questions. I have also been working on adding SSL/TLS configuration with client certificate

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

2018-02-01 Thread stanlyDoge
Github user stanlyDoge closed the pull request at: https://github.com/apache/activemq-artemis/pull/1775 ---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread dejanb
Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/1835 @jbertram yeah, I need to recheck all tests. Thanks! ---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1835 PR build failures look legitimate to me. I reproduced them locally. ---

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

2018-02-01 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 Done, let's wait for result :) Is there any else way how to kick off build? ---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread dejanb
Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/1835 @jbertram Thanks. I forgot to update the test. Can you give a test now? ---

Re: Hawtio service destroyed on slave after master server restart

2018-02-01 Thread ravirake
Hi Mike, I have attached both master and slave logs. master.master slave.slave Thanks, Ravi -- Sent from:

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1835 I checked out your branch, and I still see the failures. Does everything in org.apache.activemq.cli.test.ArtemisTest pass for you? ---

[GitHub] activemq-artemis pull request #1837: ARTEMIS-1603 fixed browsing tables unde...

2018-02-01 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1837 ARTEMIS-1603 fixed browsing tables under JMX tab I hope it is not spaghetti code. First exp with angular. You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

2018-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1829 ---

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

2018-02-01 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/1829 @franz1981 - can you do the PR merge? ---

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 LGTM, i think the PR build issue is resolved, if you could just do a comment change and force push or something, to trigger another build, just to get the green PR before

Re: [DISCUSS] Rework NMS.AMQP

2018-02-01 Thread Timothy Bish
On 02/01/2018 03:08 PM, cmorgan wrote: I have updated the README.md file in the fork, see https://github.com/cjwmorgan-sol-sys/nms-amqp, for the project to show the features supported by the amqp provider. Let me know if there are any questions. I have also been working on adding SSL/TLS

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 Thanks, @michaelandrepearce @franz1981 for the review. I have implemented the changes. ---

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

2018-02-01 Thread rpahli
Github user rpahli commented on the issue: https://github.com/apache/activemq-artemis/pull/1834 Ok I'll add the new parameter to the documentation. We need the openssl provider to use some special combinations of ciphersuites and elliptic curves. see

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

2018-02-01 Thread rpahli
Github user rpahli commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1833#discussion_r165291242 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -416,6 +404,13 @@

Re: Alter/change queue depth using Java/JMX

2018-02-01 Thread jmahajan165
Hi Justin, Thanks for the reply. Mine query was regarding the RedHat JBoss-AMQ. Please find the below link for that https://www.redhat.com/en/resources/enterprise-messaging-applications-networking-jboss-amq-datasheet Q1-How we can alter/change the queue depth using any JavaAPI/JMX? -- Sent

RedHat JBoss-AMQ-Alter/configure Queue Depth

2018-02-01 Thread jmahajan165
Hi, Looking forward for the example to alter the queue depth of RedHat JBOSS-MQ for the version 7.0 https://www.redhat.com/en/resources/enterprise-messaging-applications-networking-jboss-amq-datasheet -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #1833: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread rpahli
Github user rpahli closed the pull request at: https://github.com/apache/activemq-artemis/pull/1833 ---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread rpahli
GitHub user rpahli opened a pull request: https://github.com/apache/activemq-artemis/pull/1834 ARTEMIS-1649 - enable openssl provider for Netty We want to use the native Openssl Provider for netty to use the native openssl. Added the supprt to switch between JDK and OpenSSL

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

2018-02-01 Thread rpahli
Github user rpahli commented on the issue: https://github.com/apache/activemq-artemis/pull/1834 I closed the PR #1833 unintentionally ---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282547 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java --- @@ -38,6 +38,10 @@ public

[GitHub] activemq-artemis issue #1822: Allow existing empty tables

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1822 Can there be a JIRA and the commit include the JIRA number please. ---

[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1824 @grandinj looks fine to me also, could you just do a forced push on your PR to make the PR build kick off again, seems the PR build didn't complete. Also whilst at it, could

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285067 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -416,6

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

2018-02-01 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @michaelandrepearce Good point. Pushing changes & test in few minutes. ---

[GitHub] activemq-artemis issue #1833: enable openssl provider for Netty

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1833 @rpahli good start, have left some comments. Also could you raise a JIRA and update the commit message with the JIRA (see other PR's if you need a sample) ---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165287490 --- Diff:

[GitHub] activemq-artemis issue #1827: Improve paged message acknowledge

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1827 Could a JIRA ticket exist for this, and the commit message be updated to include the JIRA. Thanks. ---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282202 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

2018-02-01 Thread rpahli
GitHub user rpahli opened a pull request: https://github.com/apache/activemq-artemis/pull/1833 enable openssl provider for Netty We want to use the native Openssl Provider for netty to use the native openssl. Added the supprt to switch between JDK and OpenSSL Provider. You

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-02-01 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165284853 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java --- @@ -38,6 +38,10 @@ public static

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1833#discussion_r165284845 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -388,23

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285729 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -16,6

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-01 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165302018 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java ---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1834#discussion_r165304543 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -416,6

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1834#discussion_r165305348 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -530,48

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-01 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @michaelandrepearce updated the code as per your comments. ---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

2018-02-01 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1834#discussion_r165308928 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -530,48 +539,34 @@

[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings

2018-02-01 Thread grandinj
Github user grandinj commented on the issue: https://github.com/apache/activemq-artemis/pull/1824 hmm, I've updated the commit title, and I've done a forced update (after doing a merge and realising I was on the wrong track), but it doesn't look like that triggered a build? ---