[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[RaiSaurabh]

Github user RaiSaurabh commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
Thanks, @michaelandrepearce @franz1981 for the review. I have implemented 
the changes.


---

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

[rpahli]

Github user rpahli commented on the issue:

https://github.com/apache/activemq-artemis/pull/1834
  
Ok I'll add the new parameter to the documentation.
We need the openssl provider to use some special combinations of 
ciphersuites and elliptic curves.

see https://en.wikipedia.org/wiki/Comparison_of_TLS_implementations

Should I add these link to the documentation too?


---

Re: [DISCUSS] Rework NMS.AMQP

[Timothy Bish]

On 02/01/2018 03:08 PM, cmorgan wrote:

I have updated the README.md file in the fork, see
https://github.com/cjwmorgan-sol-sys/nms-amqp, for the project to show the
features supported by the amqp provider. Let me know if there are any
questions.

I have also been working on adding SSL/TLS configuration with client
certificate authentication (as well as improving/adding transport
configuration). I plan to make the amqp provider configure transport/SSL
properties in similar way to ActiveMQ and Stomp providers, using the URI
Query parameters. I think it would be a good to match the property names
with ActiveMQ and Stomp property names as they seem to be similar to each
other as well. Unless there is good reason not to.

I noticed the ActiveMQ and Stomp have provider URI configuration pages, as
well as build notes. Where and how are those created? I would think I will
need to update those for the amqp provider pages, perhaps make a Jira Task?
Although I can update the project README.md in the meantime if that's not
good place to edit yet.
The NMS project website is generated from the pages that are maintained 
in the Confluence Wiki.  Since the project is being worked on outside 
Apache for now it isn't yet time to add documentation for the project to 
the NMS site.



Chris Morgan



-
Chris Morgan
--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html



--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

Re: [DISCUSS] Rework NMS.AMQP

[cmorgan]

I have updated the README.md file in the fork, see
https://github.com/cjwmorgan-sol-sys/nms-amqp, for the project to show the
features supported by the amqp provider. Let me know if there are any
questions.

I have also been working on adding SSL/TLS configuration with client
certificate authentication (as well as improving/adding transport
configuration). I plan to make the amqp provider configure transport/SSL
properties in similar way to ActiveMQ and Stomp providers, using the URI
Query parameters. I think it would be a good to match the property names
with ActiveMQ and Stomp property names as they seem to be similar to each
other as well. Unless there is good reason not to.

I noticed the ActiveMQ and Stomp have provider URI configuration pages, as
well as build notes. Where and how are those created? I would think I will
need to update those for the amqp provider pages, perhaps make a Jira Task?
Although I can update the project README.md in the meantime if that's not
good place to edit yet.

Chris Morgan



-
Chris Morgan
--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1834
  
Could you update the SSL documentation in 
docs/user-manual/en/configuring-transports.md to include the new "sslProvider" 
parameter including a short explanation of why the JDK provider might be useful 
vs. the OpenSSL provider and vice-versa?  It's not clear from your commit what 
the functional benefit of this change actually is.


---

Re: Hawtio service destroyed on slave after master server restart

[ravirake]

Hi Mike,

I have attached both master and slave logs.

master.master
  
slave.slave   


Thanks,
Ravi



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

[dejanb]

Github user dejanb commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
@jbertram yeah, I need to recheck all tests. Thanks!


---

[RESULT][VOTE] Apache ActiveMQ 5.15.3

[Christopher Shannon]

Results of the Apache ActiveMQ 5.15.3 vote:

Vote passes with 4 +1 binding votes.

The following votes were received:

Binding:
+1 Timothy Bish
+1 Christopher Shannon
+1 Gary Tully
+1 Clebert Suconic

Non-Binding
+1 Francois Papon


I'll start pushing out the release bundles and update the Wiki.

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
I checked out your branch, and I still see the failures.  Does everything 
in org.apache.activemq.cli.test.ArtemisTest pass for you?


---

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1828
  
Done, let's wait for result :) Is there any else way how to kick off build?


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

[dejanb]

Github user dejanb commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
@jbertram Thanks. I forgot to update the test. Can you give a test now?


---

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1828
  
LGTM, i think the PR build issue is resolved, if you could just do a 
comment change and force push or something, to trigger another build, just to 
get the green PR before merging.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[stanlyDoge]

Github user stanlyDoge closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1775


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
PR build failures look legitimate to me.  I reproduced them locally.


---

[GitHub] activemq-artemis issue #1775: ARTEMIS-1587 Add setting to control the queue ...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1775
  
@stanlyDoge, yes, I think so.


---

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1829


---

[GitHub] activemq-artemis pull request #1837: ARTEMIS-1603 fixed browsing tables unde...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1837

ARTEMIS-1603 fixed browsing tables under JMX tab

I hope it is not spaghetti code. First exp with angular.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1603

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1837


commit 03e932d04915ddbb2874d3021c00912ddfff9043
Author: Stanislav Knot 
Date:   2018-02-01T15:18:11Z

ARTEMIS-1603 fixed browsing tables under JMX tab




---

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

[cshannon]

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/1829
  
@franz1981 - can you do the PR merge?


---

Re: RedHat JBoss-AMQ-Alter/configure Queue Depth

[Justin Bertram]

This is a community mailing list for developers of the Apache ActiveMQ
project.  Red Hat JBoss AMQ is what we call a "downstream" commercial
product.  If you need help with it you should contact Red Hat for support.
This community only supports the "upstream" project.


Justin

On Thu, Feb 1, 2018 at 3:15 AM, jmahajan165  wrote:

> Hi,
>
> Looking forward for the example to alter  the queue depth of RedHat
> JBOSS-MQ
> for the version 7.0
>
> https://www.redhat.com/en/resources/enterprise-messaging-applications-
> networking-jboss-amq-datasheet
>
>
>
>
> --
> Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-
> f2368404.html
>

Re: Alter/change queue depth using Java/JMX

[Justin Bertram]

This is a community mailing list for developers of the Apache ActiveMQ
project.  Red Hat JBoss AMQ is what we call a "downstream" commercial
product.  If you need help with it you should contact Red Hat for support.
This community only supports the "upstream" project.


Justin

On Thu, Feb 1, 2018 at 3:13 AM, jmahajan165  wrote:

> Hi Justin,
>
> Thanks for the reply.
>
> Mine query was regarding the RedHat JBoss-AMQ.
>
> Please find the below link for that
>
> https://www.redhat.com/en/resources/enterprise-messaging-applications-
> networking-jboss-amq-datasheet
>
> Q1-How we can alter/change the queue depth using any JavaAPI/JMX?
>
>
>
> --
> Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-
> f2368404.html
>

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1834
  
Couple of things...

- All changes should be squashed into a single commit
- The commit message should follow the pattern described in the [Hacking 
Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).


---

[GitHub] activemq-artemis pull request #1836: ARTEMIS-1652 XmlDataImporter forgets de...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/1836

ARTEMIS-1652 XmlDataImporter forgets delete tmp files

When using the tool to import more than one large messages
from xml exported file, this utility class will create some
tmp files, each for one large message. However it only delete
one of the tmp files. All the rest of tmp files won't get
cleaned up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis 
fxmlExporter_tmpfile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1836


commit 54a70efd04c0694a2f94186777c8fd0c2b509901
Author: Howard Gao 
Date:   2018-02-01T14:36:57Z

ARTEMIS-1652 XmlDataImporter forgets delete tmp files

When using the tool to import more than one large messages
from xml exported file, this utility class will create some
tmp files, each for one large message. However it only delete
one of the tmp files. All the rest of tmp files won't get
cleaned up.




---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce Hey Michael.  I think this was a temp failure.  There 
is an Artemis PR job running now that doesn't show the git clone problem.  The 
CI is shared and there are a bunch of jobs queued so we might have to wait a 
while to run again.


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165352116
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
 ---
@@ -0,0 +1,572 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Set;
+import java.util.Map.Entry;
+import java.util.zip.Deflater;
+import java.util.zip.DeflaterOutputStream;
+import java.util.zip.Inflater;
+import java.util.zip.InflaterInputStream;
+import java.util.zip.InflaterOutputStream;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.FilterConstants;
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.message.impl.CoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.reader.MessageUtil;
+import org.apache.activemq.artemis.utils.DataConstants;
+import org.apache.activemq.artemis.utils.collections.TypedProperties;
+import org.apache.activemq.command.CommandTypes;
+import org.apache.activemq.util.ByteArrayInputStream;
+import org.apache.activemq.util.ByteSequence;
+import org.apache.activemq.util.ByteSequenceData;
+import org.apache.activemq.util.MarshallingSupport;
+import org.fusesource.hawtbuf.UTF8Buffer;
+
+public class OpenWireCoreConverter {
+   public static final SimpleString JMS_GROUPSEQ = new 
SimpleString("JMSXGroupSequence");
+   public static final SimpleString JMS_XGROUPSEQ = new 
SimpleString("JMSXGroupSeq");
+   public static final SimpleString JMS_GROUPID = new 
SimpleString("JMSXGroupID");
+   private static final SimpleString AMQP_REPLYTOGROUPID = new 
SimpleString("JMS_AMQP_ReplyToGroupID");
+   public static final SimpleString JMS_CONTENT_TYPE = new 
SimpleString("JMS_AMQP_ContentType");
+   private static final SimpleString AMQP_CONTETTYPE = new 
SimpleString("JMS_AMQP_CONTENT_TYPE");
+
+   public static ICoreMessage toCore(final OpenWireMessage 
openwireMessage, final CoreMessageObjectPools coreMessageObjectPools)
+ throws Exception {
+  CoreMessage coreMessage = new CoreMessage(-1, 
openwireMessage.getMessageSize(), coreMessageObjectPools);
+  final SimpleString type = 
openwireMessage.getSimpleStringProperty(new SimpleString("JMSType"));
--- End diff --

Or make constant :)


---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@michaelandrepearce I will warn the PM squad :+1: 


---

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1829
  
@cshannon Perfect, thanks :+1: 


---

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1827#discussion_r165348688
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
 ---
@@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, 
MessageReference ref, long tim
@Override
public void afterCommit(final Transaction tx) {
   for (MessageReference ref : refsToAck) {
- synchronized (ref.getQueue()) {
--- End diff --

Makes sense. I think best way of getting confidence is a really good test 
case to prove it 


---

[GitHub] activemq-artemis issue #1829: ARTEMIS-1647 - Add plugin support for binding ...

[cshannon]

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/1829
  
@franz1981 - I updated the PR, is this ok to merge now?


---

[GitHub] activemq-artemis pull request #1835: ARTEMIS-1651 Allow custom etc and data ...

[dejanb]

GitHub user dejanb opened a pull request:

https://github.com/apache/activemq-artemis/pull/1835

ARTEMIS-1651 Allow custom etc and data directories to be used



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dejanb/activemq-artemis cli

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1835


commit 2aa0996b4f83fab3e1d922016df9570a22b63c75
Author: Dejan Bosanac 
Date:   2018-01-24T10:50:22Z

ARTEMIS-1632 Upgrade JBoss logging to 3.3.1.Final

commit 51ae5f54f85f72f5cfb2c0099c2fff37c18b2d84
Author: Dejan Bosanac 
Date:   2018-01-26T14:26:47Z

ARTEMIS-1651 Allow custom etc and data directories to be used

initial support for custom etc location

fixing windows distribution




---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1834#discussion_r16533
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -841,7 +864,7 @@ private HttpUpgradeHandler(ChannelPipeline pipeline, 
HttpClientCodec httpClientC
* HTTP upgrade response will be decode by Netty as 2 objects:
* - 1 HttpObject corresponding to the 101 SWITCHING PROTOCOL headers
* - 1 EMPTY_LAST_CONTENT
-   *
+   * 
--- End diff --

Un-needed change, please remove.


---

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

[shoukunhuai]

Github user shoukunhuai commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1827#discussion_r16574
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
 ---
@@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, 
MessageReference ref, long tim
@Override
public void afterCommit(final Transaction tx) {
   for (MessageReference ref : refsToAck) {
- synchronized (ref.getQueue()) {
--- End diff --

I do this because in QueueImpl::postAcknowledge, the only thing that 
changed queue's state is decrement queue's delivering count, which i believe is 
thread safe.

While QueueImpl:postRollback is different, it will not return messages if 
purge on no consumers and there is no consumer at that time, since add/remove 
consumer will lock the queue. So we must lock the queue when do post rollback.

If no body is 100% sure about this, i will revert this change, since other 
change has improved a lot.


---

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

[cshannon]

Github user cshannon commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1829#discussion_r165333289
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
@@ -571,6 +571,8 @@ public AddressInfo getAddressInfo(SimpleString 
addressName) {
// even though failover is complete
@Override
public synchronized void addBinding(final Binding binding) throws 
Exception {
+  server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> 
plugin.beforeAddBinding(binding) : null);
--- End diff --

I can change it everywhere the plugins are called.  There are some hot 
paths where the plugins are called such as during message routing so if that 
change will improve performance then that is fine.


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165331496
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
 ---
@@ -0,0 +1,572 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Set;
+import java.util.Map.Entry;
+import java.util.zip.Deflater;
+import java.util.zip.DeflaterOutputStream;
+import java.util.zip.Inflater;
+import java.util.zip.InflaterInputStream;
+import java.util.zip.InflaterOutputStream;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.FilterConstants;
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.message.impl.CoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.reader.MessageUtil;
+import org.apache.activemq.artemis.utils.DataConstants;
+import org.apache.activemq.artemis.utils.collections.TypedProperties;
+import org.apache.activemq.command.CommandTypes;
+import org.apache.activemq.util.ByteArrayInputStream;
+import org.apache.activemq.util.ByteSequence;
+import org.apache.activemq.util.ByteSequenceData;
+import org.apache.activemq.util.MarshallingSupport;
+import org.fusesource.hawtbuf.UTF8Buffer;
+
+public class OpenWireCoreConverter {
+   public static final SimpleString JMS_GROUPSEQ = new 
SimpleString("JMSXGroupSequence");
+   public static final SimpleString JMS_XGROUPSEQ = new 
SimpleString("JMSXGroupSeq");
+   public static final SimpleString JMS_GROUPID = new 
SimpleString("JMSXGroupID");
+   private static final SimpleString AMQP_REPLYTOGROUPID = new 
SimpleString("JMS_AMQP_ReplyToGroupID");
+   public static final SimpleString JMS_CONTENT_TYPE = new 
SimpleString("JMS_AMQP_ContentType");
+   private static final SimpleString AMQP_CONTETTYPE = new 
SimpleString("JMS_AMQP_CONTENT_TYPE");
+
+   public static ICoreMessage toCore(final OpenWireMessage 
openwireMessage, final CoreMessageObjectPools coreMessageObjectPools)
+ throws Exception {
+  CoreMessage coreMessage = new CoreMessage(-1, 
openwireMessage.getMessageSize(), coreMessageObjectPools);
+  final SimpleString type = 
openwireMessage.getSimpleStringProperty(new SimpleString("JMSType"));
+  if (type != null) {
+ 
coreMessage.putStringProperty(SimpleString.toSimpleString("JMSType"), type);
--- End diff --

Or just make it a constant.


---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@franz1981 I think there’s a general Jenkins PR build issue. If you have 
direct ping ability or nudge directly Martyn or Clebert or someone on PM ?


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165331112
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
 ---
@@ -0,0 +1,572 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Set;
+import java.util.Map.Entry;
+import java.util.zip.Deflater;
+import java.util.zip.DeflaterOutputStream;
+import java.util.zip.Inflater;
+import java.util.zip.InflaterInputStream;
+import java.util.zip.InflaterOutputStream;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.FilterConstants;
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.message.impl.CoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.reader.MessageUtil;
+import org.apache.activemq.artemis.utils.DataConstants;
+import org.apache.activemq.artemis.utils.collections.TypedProperties;
+import org.apache.activemq.command.CommandTypes;
+import org.apache.activemq.util.ByteArrayInputStream;
+import org.apache.activemq.util.ByteSequence;
+import org.apache.activemq.util.ByteSequenceData;
+import org.apache.activemq.util.MarshallingSupport;
+import org.fusesource.hawtbuf.UTF8Buffer;
+
+public class OpenWireCoreConverter {
+   public static final SimpleString JMS_GROUPSEQ = new 
SimpleString("JMSXGroupSequence");
+   public static final SimpleString JMS_XGROUPSEQ = new 
SimpleString("JMSXGroupSeq");
+   public static final SimpleString JMS_GROUPID = new 
SimpleString("JMSXGroupID");
+   private static final SimpleString AMQP_REPLYTOGROUPID = new 
SimpleString("JMS_AMQP_ReplyToGroupID");
+   public static final SimpleString JMS_CONTENT_TYPE = new 
SimpleString("JMS_AMQP_ContentType");
+   private static final SimpleString AMQP_CONTETTYPE = new 
SimpleString("JMS_AMQP_CONTENT_TYPE");
+
+   public static ICoreMessage toCore(final OpenWireMessage 
openwireMessage, final CoreMessageObjectPools coreMessageObjectPools)
+ throws Exception {
+  CoreMessage coreMessage = new CoreMessage(-1, 
openwireMessage.getMessageSize(), coreMessageObjectPools);
+  final SimpleString type = 
openwireMessage.getSimpleStringProperty(new SimpleString("JMSType"));
+  if (type != null) {
+ 
coreMessage.putStringProperty(SimpleString.toSimpleString("JMSType"), type);
--- End diff --

Cache `SimpleString.toSimpleString("JMSType")` to avoid allocations


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330940
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
 ---
@@ -0,0 +1,572 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Set;
+import java.util.Map.Entry;
+import java.util.zip.Deflater;
+import java.util.zip.DeflaterOutputStream;
+import java.util.zip.Inflater;
+import java.util.zip.InflaterInputStream;
+import java.util.zip.InflaterOutputStream;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.FilterConstants;
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.message.impl.CoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.reader.MessageUtil;
+import org.apache.activemq.artemis.utils.DataConstants;
+import org.apache.activemq.artemis.utils.collections.TypedProperties;
+import org.apache.activemq.command.CommandTypes;
+import org.apache.activemq.util.ByteArrayInputStream;
+import org.apache.activemq.util.ByteSequence;
+import org.apache.activemq.util.ByteSequenceData;
+import org.apache.activemq.util.MarshallingSupport;
+import org.fusesource.hawtbuf.UTF8Buffer;
+
+public class OpenWireCoreConverter {
+   public static final SimpleString JMS_GROUPSEQ = new 
SimpleString("JMSXGroupSequence");
+   public static final SimpleString JMS_XGROUPSEQ = new 
SimpleString("JMSXGroupSeq");
+   public static final SimpleString JMS_GROUPID = new 
SimpleString("JMSXGroupID");
+   private static final SimpleString AMQP_REPLYTOGROUPID = new 
SimpleString("JMS_AMQP_ReplyToGroupID");
+   public static final SimpleString JMS_CONTENT_TYPE = new 
SimpleString("JMS_AMQP_ContentType");
+   private static final SimpleString AMQP_CONTETTYPE = new 
SimpleString("JMS_AMQP_CONTENT_TYPE");
+
+   public static ICoreMessage toCore(final OpenWireMessage 
openwireMessage, final CoreMessageObjectPools coreMessageObjectPools)
+ throws Exception {
+  CoreMessage coreMessage = new CoreMessage(-1, 
openwireMessage.getMessageSize(), coreMessageObjectPools);
+  final SimpleString type = 
openwireMessage.getSimpleStringProperty(new SimpleString("JMSType"));
--- End diff --

cache the `new SimpleString("JMSType")` to avoid allocating it each tim


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330750
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManagerFactory.java
 ---
@@ -46,6 +48,11 @@ public ProtocolManager createProtocolManager(final 
ActiveMQServer server,
   return BeanSupport.setData(new OpenWireProtocolManager(this, 
server), parameters);
}
 
+   @Override
+   public Persister[] getPersister() {
+  return new Persister[]{OpenWireMessagePersister.getInstance()};
--- End diff --

Cache it if possible instead of allocating it each time


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330595
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessagePersister.java
 ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.persistence.Persister;
+import org.apache.activemq.artemis.utils.DataConstants;
+
+public class OpenWireMessagePersister implements Persister {
--- End diff --

The same comments of `OpenWireConverter`


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165330188
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.spi.core.protocol.MessageConverter;
+
+public class OpenWireConverter implements 
MessageConverter {
--- End diff --

Please make it final or use an enum class with just a single enumerated 
instance to have a real singleton:
```
public enum OpenWireConverter implements MessageConverter{
   Instance;
   ...
}
```



---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@RaiSaurabh Please rebase it and force push it to re-trigger a Jenkins 
build and hopefully it will pass


---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[RaiSaurabh]

Github user RaiSaurabh commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@michaelandrepearce Seems there is some problem with the Git due to which 
this build failed. Could you please check and let me know.


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@gtully yes there is a use case for the client part here in our org, thus 
why. I'd rather do this fully, than partial. 

@mtaylor or anyone with access, can someone look at the build system, ive 
tried 10 times, and keep getting build fails with the below which seems infra 
related.

ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/activemq-artemis.git




---

[GitHub] activemq-artemis issue #1822: Allow existing empty tables

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1822
  
@nlippke Agree with @michaelandrepearce: could you please create a JIRA for 
it and include it into the commit? 

> Is there a way to ask jenkins for a new build? This build error doesn't 
look change related and other PR builds break at the very same point.

You could try to rebase against the latest one and force a push: it will 
trigger a new build on Jenkins for sure :+1: 



---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[gtully]

Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce to make the feature work is trivial in queueimpl; to 
make it dynamic is a lot of code.
I would have been shooting for an address setting and pulling that value in 
queueImpl on creation. An all or nothing approach.
But what you have is very comprehensive :-) I just wonder if there really 
is a need to have the consumer create an lvq or exclusive queue. If there is, 
then this nails it.
For an existing openwire client the value can come from a consumer info or 
from a destination parameter but mostly it is the effect that is needed, not 
the fact that it is dynamic, ie: Because it effects every consumer having a 
single consumer control it is a bit imbalanced and not typical I think.



---

[GitHub] activemq-artemis pull request #1829: ARTEMIS-1647 - Add plugin support for b...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1829#discussion_r165317614
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
@@ -571,6 +571,8 @@ public AddressInfo getAddressInfo(SimpleString 
addressName) {
// even though failover is complete
@Override
public synchronized void addBinding(final Binding binding) throws 
Exception {
+  server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> 
plugin.beforeAddBinding(binding) : null);
--- End diff --

Due to the `default` uses on `callBrokerPlugins` and other wierd reasons 
dependent by how the JIT works with compilations/inlining/interface 
optimization would be better at least to turn it into:
```
if(server.hasBrokerPlugins()){
 
}
```
I've noticed it is used on most "cold path" of the broker so it is fine to 
left as it is in this place too: it doesn't seem a hot path. My suggestion is 
just for wider puporses :+1: 


---

[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings

[grandinj]

Github user grandinj commented on the issue:

https://github.com/apache/activemq-artemis/pull/1824
  
hmm, I've updated the commit title, 
and I've done a forced update (after doing a merge and realising I was on 
the wrong track), but it doesn't look like that triggered a build?


---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1834#discussion_r165308928
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -530,48 +539,34 @@ public synchronized void start() {
if 
(System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME) != null) {
   realTrustStorePassword = 
System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME);
}
-   context = SSLSupport.createContext(realKeyStoreProvider, 
realKeyStorePath, realKeyStorePassword, realTrustStoreProvider, 
realTrustStorePath, realTrustStorePassword, trustAll, crlPath);
+
 }
  } catch (Exception e) {
 close();
 IllegalStateException ise = new IllegalStateException("Unable 
to create NettyConnector for " + host + ":" + port);
 ise.initCause(e);
 throw ise;
  }
-  } else {
- context = null; // Unused
   }
 
-  if (context != null && useServlet) {
- // TODO: Fix me
- //bootstrap.setOption("sslContext", context);
-  }
+  //if (context != null && useServlet) {
--- End diff --

If isn't needed anymore please remove it 


---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

[RaiSaurabh]

Github user RaiSaurabh commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@michaelandrepearce updated the code as per your comments.


---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1834#discussion_r165305348
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -530,48 +539,34 @@ public synchronized void start() {
if 
(System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME) != null) {
   realTrustStorePassword = 
System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME);
}
-   context = SSLSupport.createContext(realKeyStoreProvider, 
realKeyStorePath, realKeyStorePassword, realTrustStoreProvider, 
realTrustStorePath, realTrustStorePassword, trustAll, crlPath);
+
 }
  } catch (Exception e) {
 close();
 IllegalStateException ise = new IllegalStateException("Unable 
to create NettyConnector for " + host + ":" + port);
 ise.initCause(e);
 throw ise;
  }
-  } else {
- context = null; // Unused
   }
 
-  if (context != null && useServlet) {
- // TODO: Fix me
- //bootstrap.setOption("sslContext", context);
-  }
+  //if (context != null && useServlet) {
+  // TODO: Fix me
+  //bootstrap.setOption("sslContext", context);
+  //}
 
   bootstrap.handler(new ChannelInitializer() {
--- End diff --

this probably could be made a lamda.


---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1834#discussion_r165304543
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -416,6 +421,13 @@ private String getHttpUpgradeInfo() {
   return ", activemqServerName=" + serverName + ", 
httpUpgradeEndpoint=" + acceptor;
}
 
+   private String realKeyStorePath;
--- End diff --

copying comment from old PR, please can we keep these method scope.


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[RaiSaurabh]

Github user RaiSaurabh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165302018
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.spi.core.protocol.MessageConverter;
+
+public class OpenWireConverter implements 
MessageConverter {
+
+   private static final OpenWireConverter theInstance = new 
OpenWireConverter();
+   private OpenWireConverter() {
+   }
+
+   public static OpenWireConverter getInstance() {
+  return theInstance;
+   }
+
+   @Override
+   public OpenwireMessage fromCore(ICoreMessage coreMessage) throws 
Exception {
--- End diff --

Ok, @michaelandrepearce I will refractor that. Since this was named like 
this previously I thought not to change it. As after what you suggested this 
was bugging me too.


---

[GitHub] activemq-artemis issue #1834: ARTEMIS-1649 - enable openssl provider for Net...

[rpahli]

Github user rpahli commented on the issue:

https://github.com/apache/activemq-artemis/pull/1834
  
I closed the PR #1833 unintentionally


---

[GitHub] activemq-artemis pull request #1834: ARTEMIS-1649 - enable openssl provider ...

[rpahli]

GitHub user rpahli opened a pull request:

https://github.com/apache/activemq-artemis/pull/1834

ARTEMIS-1649 - enable openssl provider for Netty

We want to use the native Openssl Provider for netty to use the native 
openssl.
Added the supprt to switch between JDK and OpenSSL Provider.

see #1833

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kiwigrid/activemq-artemis 
enable-openssl-provider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit bb0bea377fb89e5b44bbe03818e2c78602448fc0
Author: rico.pahlisch 
Date:   2018-02-01T09:35:01Z

code formating




---

[GitHub] activemq-artemis pull request #1833: ARTEMIS-1649 - enable openssl provider ...

[rpahli]

Github user rpahli closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1833


---

RedHat JBoss-AMQ-Alter/configure Queue Depth

[jmahajan165]

Hi,

Looking forward for the example to alter  the queue depth of RedHat JBOSS-MQ
for the version 7.0

https://www.redhat.com/en/resources/enterprise-messaging-applications-networking-jboss-amq-datasheet




--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

Re: Alter/change queue depth using Java/JMX

[jmahajan165]

Hi Justin,

Thanks for the reply.

Mine query was regarding the RedHat JBoss-AMQ.

Please find the below link for that

https://www.redhat.com/en/resources/enterprise-messaging-applications-networking-jboss-amq-datasheet

Q1-How we can alter/change the queue depth using any JavaAPI/JMX?



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[rpahli]

Github user rpahli commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165291242
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -416,6 +404,13 @@ private String getHttpUpgradeInfo() {
   return ", activemqServerName=" + serverName + ", 
httpUpgradeEndpoint=" + acceptor;
}
 
+   private String realKeyStorePath;
--- End diff --

If I move the variables into the method then I have to add some new copy 
variables because they have to be final or effective final. Is it ok?


---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1793#discussion_r165287490
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire;
+
+import org.apache.activemq.artemis.api.core.ICoreMessage;
+import 
org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;
+import org.apache.activemq.artemis.spi.core.protocol.MessageConverter;
+
+public class OpenWireConverter implements 
MessageConverter {
+
+   private static final OpenWireConverter theInstance = new 
OpenWireConverter();
+   private OpenWireConverter() {
+   }
+
+   public static OpenWireConverter getInstance() {
+  return theInstance;
+   }
+
+   @Override
+   public OpenwireMessage fromCore(ICoreMessage coreMessage) throws 
Exception {
--- End diff --

seems one is left, i think the class was there before unused, would you 
mind? OpenwireMessage -> OpenWireMessage


---

[GitHub] activemq-artemis issue #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1833
  
@rpahli good start, have left some comments. Also could you raise a JIRA 
and update the commit message with the JIRA (see other PR's if you need a 
sample)


---

[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1828
  
@michaelandrepearce Good point. Pushing changes & test in few minutes.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285729
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -16,6 +16,11 @@
  */
 package org.apache.activemq.artemis.core.remoting.impl.netty;
 
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+import javax.net.ssl.SSLParameters;
+import javax.security.auth.Subject;
+import javax.security.auth.login.LoginContext;
--- End diff --

Un-needed change, please revert.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285067
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -416,6 +404,13 @@ private String getHttpUpgradeInfo() {
   return ", activemqServerName=" + serverName + ", 
httpUpgradeEndpoint=" + acceptor;
}
 
+   private String realKeyStorePath;
--- End diff --

These should remain within method scope.


---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

[shoukunhuai]

Github user shoukunhuai commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1827#discussion_r165284853
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
 ---
@@ -38,6 +38,10 @@ public static MessageReference createReference(Message 
encode, final Queue queue
 
Message getMessage();
 
+   default long getMessageID() {
--- End diff --

Thanks, will change it later


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165284845
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -388,23 +392,7 @@ public NettyConnector(final Map 
configuration,
 
@Override
public String toString() {
-  return "NettyConnector [host=" + host +
- ", port=" +
- port +
- ", httpEnabled=" +
- httpEnabled +
- ", httpUpgradeEnabled=" +
- httpUpgradeEnabled +
- ", useServlet=" +
- useServlet +
- ", servletPath=" +
- servletPath +
- ", sslEnabled=" +
- sslEnabled +
- ", useNio=" +
- true +
- getHttpUpgradeInfo() +
- "]";
+  return "NettyConnector [host=" + host + ", port=" + port + ", 
httpEnabled=" + httpEnabled + ", httpUpgradeEnabled=" + httpUpgradeEnabled + ", 
useServlet=" + useServlet + ", servletPath=" + servletPath + ", sslEnabled=" + 
sslEnabled + ", useNio=" + true + getHttpUpgradeInfo() + "]";
--- End diff --

can you undo the formatting change please.


---

[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1824
  
@grandinj looks fine to me also, could you just do a forced push on your PR 
to make the PR build kick off again, seems the PR build didn't complete. Also 
whilst at it, could you either create a JIRA and put a JIRA number in the 
commit title, or add NO-JIRA to it, im fine with either as this is more about 
just code formatting.


---

[GitHub] activemq-artemis issue #1822: Allow existing empty tables

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1822
  
Can there be a JIRA and the commit include the JIRA number please.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[rpahli]

GitHub user rpahli opened a pull request:

https://github.com/apache/activemq-artemis/pull/1833

enable openssl provider for Netty

We want to use the native Openssl Provider for netty to use the native 
openssl. 
Added the supprt to switch between JDK and OpenSSL Provider.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kiwigrid/activemq-artemis 
enable-openssl-provider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1833


commit 6891c160b16ac314d6e92cafcd3f825311156bc7
Author: rico.pahlisch 
Date:   2018-02-01T08:15:34Z

enable openssl provider for native support




---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282547
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
 ---
@@ -38,6 +38,10 @@ public static MessageReference createReference(Message 
encode, final Queue queue
 
Message getMessage();
 
+   default long getMessageID() {
--- End diff --

-1 on hot path default methods on hot path aren't so good, suggest either 
leaving the code as was in ServerConsumerImpl with the 
getMessage().getMessageId or simply not make it default, and update other 
impl's within the code base.

nudge @franz1981 


---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282202
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
 ---
@@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, 
MessageReference ref, long tim
@Override
public void afterCommit(final Transaction tx) {
   for (MessageReference ref : refsToAck) {
- synchronized (ref.getQueue()) {
--- End diff --

if this is removed should the same syn block on the queue in rollback be 
removed, im not 100% if this is safe though or not, is there a concurrent test 
case at all around this if not, could one be easily added?


---

[GitHub] activemq-artemis issue #1827: Improve paged message acknowledge

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1827
  
Could a JIRA ticket exist for this, and the commit message be updated to 
include the JIRA. Thanks.


---