Re: Review Request 73791: ATLAS-4523 - Build failure on Atlas docs

2022-01-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73791/#review223944 --- Ship it! Ship It! - Ashutosh Mestry On Jan. 7, 2022, 12:20

Re: Review Request 73725: ATLAS-4493 : Upgrade netty to 4.1.68+

2021-11-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73725/#review223767 --- Ship it! Ship It! - Ashutosh Mestry On Nov. 23, 2021, 9:24

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73671/#review223686 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 28, 2021, 9:32

Re: Review Request 73670: ATLAS-4351 Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73670/#review223685 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 28, 2021, 9:14

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73671/#review223684 --- Fix it, then Ship it! Fix it, then Ship it!

Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and PreCommit tests are also failing

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73669/#review223683 ---

Re: Review Request 73132: ATLAS-4079 : Atlas-Upgrade jackson to 2.11.0+

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73132/#review223681 --- Ship it! Ship It! - Ashutosh Mestry On Jan. 12, 2021, 9:39

Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and PreCommit tests are also failing

2021-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73669/#review223679 ---

Re: Review Request 73639: ATLAS-4446 : Atlas - Upgrade elasticsearch to 7.14.0

2021-10-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73639/#review223653 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 21, 2021, 2:50

Re: Review Request 73641: Repair Composite indexes

2021-10-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73641/#review223593 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 8, 2021, 1:38

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-10-06 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73595/#review223578 --- Fix it, then Ship it! Ship It!

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-10-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73595/#review223575 --- intg/pom.xml Lines 149 (patched)

Re: Review Request 73628: ATLAS-4444: Atlas - Upgrade commons-io to 2.11.0

2021-10-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73628/#review223573 ---

Re: Review Request 73628: ATLAS-4444: Atlas - Upgrade commons-io to 2.11.0

2021-10-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73628/#review223572 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 5, 2021, 4:02

Re: Review Request 73286: Initial commit

2021-10-05 Thread Ashutosh Mestry via Review Board
> On Oct. 4, 2021, 3:42 p.m., Ashutosh Mestry wrote: > > Can you please rebase this against latest master? > > Aileen Toleikis wrote: > Hi Ashutosh! > We rebased our code to the latest master! > And we also added schema evolution to the code, therefore there are more > new

Re: Review Request 73286: Initial commit

2021-10-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73286/#review223560 --- Can you please rebase this against latest master? - Ashutosh

Re: Review Request 73586: ATLAS-4424: Enhance the Import hive utility to create export zip files and run bulk import

2021-10-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73586/#review223551 ---

Re: Review Request 73585: ATLAS-4425: Migration import should be able to import multiple zip files present in a particular path

2021-09-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73585/#review223550 --- User specifies:

Re: Review Request 73585: ATLAS-4425: Migration import should be able to import multiple zip files present in a particular path

2021-09-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73585/#review223548 --- I have tested this and it works quite well.

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-09-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73595/#review223547 --- Why would you not include messageInfo in the message itself? That

Review Request 73606: AtlasPatchManager: Avoid Race Condition in HA Mode

2021-09-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73606/ --- Review request for atlas, Jayendra Parab, Mandar Ambawane, Nikhil Bonte, Nixon

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73599/ --- (Updated Sept. 22, 2021, 8:35 p.m.) Review request for atlas, Nikhil Bonte,

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-22 Thread Ashutosh Mestry via Review Board
> On Sept. 21, 2021, 7:02 p.m., Sailaja Polavarapu wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > > Line 359 (original), 374 (patched) > > > > > > I think it will be

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73599/ --- (Updated Sept. 22, 2021, 5:42 p.m.) Review request for atlas, Nikhil Bonte,

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-22 Thread Ashutosh Mestry via Review Board
> On Sept. 22, 2021, 4:58 p.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > > Line 311 (original), 325 (patched) > > > > > > would

Re: Review Request 73589: Indexing Monitor and Recovery

2021-09-21 Thread Ashutosh Mestry via Review Board
> On Sept. 21, 2021, 7:35 p.m., Sarath Subramanian wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > > Lines 215 (patched) > > > > > > in that case -

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-09-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73595/#review223510 ---

Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73599/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Re: Review Request 73589: Indexing Monitor and Recovery

2021-09-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73589/ --- (Updated Sept. 21, 2021, 3:40 p.m.) Review request for atlas, Nikhil Bonte,

Re: Review Request 73593: ATLAS-4431: Random NPE when retrieving tasks

2021-09-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73593/#review223503 --- Ship it! Ship It! - Ashutosh Mestry On Sept. 20, 2021, 8:57

Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting

2021-09-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73584/#review223491 --- Ship it! Ship It! - Ashutosh Mestry On Sept. 15, 2021, 4:03

Re: Review Request 73580: ATLAS-4369: import-hive.sh does not write logs to /var/log/atlas/import-hive.log file, instead write into ${atlas.log.file} under the directory "${atlas.log.dir}"

2021-09-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73580/#review223483 --- Ship it! Ship It! - Ashutosh Mestry On Sept. 13, 2021, 5:13

Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

2021-09-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73528/#review223463 --- Ship it! Ship It!

Re: Review Request 73536: ATLAS-4379 :- Atlas Filter changes for user inactivity on Atlas UI

2021-08-31 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73536/#review223431 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 31, 2021, 12:49

Re: Review Request 73536: ATLAS-4379 :- Atlas Filter changes for user inactivity on Atlas UI

2021-08-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73536/#review223428 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 30, 2021, 7:35

Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

2021-08-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73528/#review223422 ---

Re: Review Request 73552: ATLAS-4406: Ignore configs:- A hive table DDL entity is created for ignored hive tables

2021-08-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73552/#review223421 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 27, 2021, 3:54

Re: Review Request 73549: ATLAS-4403: Improve find entity by unique attributes logic - when multiple unique attributes exist for entity type

2021-08-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73549/#review223419 --- Please add unit test with appropriate test data. - Ashutosh

Re: Review Request 73552: ATLAS-4406: Ignore configs:- A hive table DDL entity is created for ignored hive tables

2021-08-26 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73552/#review223411 --- Can you please add to description: * ignore patter you used for

Re: Review Request 73548: ATLAS-4402: Upgrade junit to 4.13.1

2021-08-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73548/#review223397 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 25, 2021, 7:02

Re: Review Request 73494: ATLAS-4376 : AtlasClientV2 getRelationshipDefByName does not work

2021-08-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73494/#review223378 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 4, 2021, 11:38

Re: Review Request 73534: ATLAS-4385: Update version in branch-2.0 to 2.3.0-SNAPSHOT

2021-08-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73534/#review223377 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 21, 2021, 12:12

Re: Review Request 73532: ATLAS-4383 Update Atlas website for 2.2.0 release (Part 2)

2021-08-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73532/#review223365 --- Ship it! It would be good if you could format this

Re: Review Request 73530: ATLAS-4394: Build error due to wrong version of atllass-buildtools at pom.xml (Part 2)

2021-08-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73530/#review223364 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 19, 2021, 8:27

Re: Review Request 73529: ATLAS-4383: Update Atlas website for 2.2.0 release

2021-08-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73529/#review223357 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 18, 2021, 10:36

Re: Review Request 73529: ATLAS-4383: Update Atlas website for 2.2.0 release

2021-08-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73529/#review223355 --- docs/src/documents/Downloads/Downloads.md Lines 76 (patched)

Re: Review Request 73524: ATLAS-4394: Build error due to wrong version of atllass-buildtools at pom.xml

2021-08-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73524/#review223349 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 17, 2021, 11:54

Re: Review Request 73503: ATLAS-4386 : Relationship search: Sorting does not work when passed relationship label

2021-08-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73503/#review223325 ---

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73502/#review223307 ---

Re: Review Request 73478: ATLAS-4368: Upgrade elasticsearch version to 6.8.15

2021-07-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73478/#review223284 --- Ship it! Ship It! - Ashutosh Mestry On July 27, 2021, 8:45

Re: Review Request 73492: ATLAS-4372: Upgrade nimbus-jose-jwt to 9.8.1

2021-07-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73492/#review223278 --- Ship it! Ship It! - Ashutosh Mestry On July 27, 2021, 9:01

Re: Review Request 73430: ATLAS-4340: Set Solr wait-searcher property to false by default to make Solr commits async

2021-07-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73430/#review223275 --- Ship it! Ship It! - Ashutosh Mestry On July 27, 2021, 6:32

Re: Review Request 73430: ATLAS-4340: Set Solr wait-searcher property to false by default to make Solr commits async

2021-07-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73430/#review223274 --- distro/src/bin/atlas_start.py Line 113 (original), 113 (patched)

Re: Review Request 73475: ATLAS-4367: UI: Single quote in can't is being removed. Hence renaming the message to cannot

2021-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73475/#review223262 --- Ship it! Ship It! - Ashutosh Mestry On July 23, 2021, 3:51

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

2021-07-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73423/#review223211 --- Ship it! Ship It! - Ashutosh Mestry On June 30, 2021, 11:07

Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response

2021-07-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/#review223202 --- Ship it! For completeness, can you please add HTTP header

Re: Review Request 73439: ATLAS-4347 : DSL Search : Caching Mechanism for translated dsl queries

2021-07-06 Thread Ashutosh Mestry via Review Board
> On July 7, 2021, 4:49 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java > > Lines 169 (patched) > > > > > > only the query syntax should be

Re: Review Request 73439: ATLAS-4347 : DSL Search : Caching Mechanism for translated dsl queries

2021-07-06 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73439/#review223197 --- Ship it! Ship It! - Ashutosh Mestry On July 6, 2021, noon,

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

2021-06-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73423/#review223196 ---

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

2021-06-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73423/#review223184 ---

Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like operator and regex expression does not work

2021-06-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73431/#review223181 --- Ship it! Ship It! - Ashutosh Mestry On June 22, 2021, 5:21

Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like operator and regex expression does not work

2021-06-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73431/#review223180 ---

Re: Review Request 73430: ATLAS-4340: Set Solr wait-searcher property to false by default to make Solr commits async

2021-06-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73430/#review223178 --- intg/src/main/java/org/apache/atlas/ApplicationProperties.java

Re: Review Request 73394: ATLAS-4317 : Upgrade curator jar version to 4.3.0

2021-06-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73394/#review223166 --- Ship it! Ship It! - Ashutosh Mestry On June 1, 2021, 4:06

Re: Review Request 73416: ATLAS-4336 Restrict attributes of type to be created starting with double underscore

2021-06-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73416/#review223156 --- Ship it! Ship It! - Ashutosh Mestry On June 15, 2021, 8:57

Re: Review Request 73416: ATLAS-4336 Restrict attributes of type to be created starting with double underscore

2021-06-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73416/#review223143 ---

Re: Review Request 73370: ATLAS-4300 : DSL Search : Support search by classification and its attribute

2021-06-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73370/#review223142 --- Ship it! Ship It! - Ashutosh Mestry On June 14, 2021, 2:21

Re: Review Request 73370: ATLAS-4300 : DSL Search : Support search by classification and its attribute

2021-06-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73370/#review223140 --- Can you please few lines that describe the syntax to

Re: Review Request 73370: ATLAS-4300 : DSL Search : Support search by classification and its attribute

2021-06-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73370/#review223139 ---

Re: Review Request 73416: ATLAS-4336 Restrict attributes of type to be created starting with double underscore

2021-06-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73416/#review223138 ---

Re: Review Request 73412: ATLAS-4332 : DSL Query : query with like operator and "/" in search text throws 500

2021-06-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73412/#review223130 --- Ship it! Ship It! - Ashutosh Mestry On June 10, 2021, 11:32

Re: Review Request 73412: ATLAS-4332 : DSL Query : query with like operator and "/" in search text throws 500

2021-06-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73412/#review223129 ---

Re: Review Request 73412: ATLAS-4332 : DSL Query : query with like operator and "/" in search text throws 500

2021-06-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73412/#review223125 --- Can you please add unit test in GremlinQueryComposerTest.

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73404/ --- (Updated June 8, 2021, 11:07 p.m.) Review request for atlas, Mandar Ambawane,

Re: Review Request 73409: ATLAS-4330: Add Kafka topics lag information on metrics and log

2021-06-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73409/#review223122 --- Can you please add log output? - Ashutosh Mestry On June 7,

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-06 Thread Ashutosh Mestry via Review Board
> On June 4, 2021, 10:46 p.m., Radhika Kundam wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java > > Line 200 (original), 194 (patched) > > > > > > This will keep

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73404/ --- (Updated June 4, 2021, 8:43 p.m.) Review request for atlas, Mandar Ambawane,

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

2021-06-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73405/ --- (Updated June 4, 2021, 4:48 a.m.) Review request for atlas, Nikhil Bonte,

Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

2021-06-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73405/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73404/ --- Review request for atlas and Radhika Kundam. Bugs: ATLAS-4324

Re: Review Request 73402: ATLAS-4301 Handle Test Case Failure on Pre-commit environment

2021-06-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73402/#review223095 --- Ship it! Can you please add details of end-to-end testing done

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73317/#review223094 --- Ship it! Ship It! - Ashutosh Mestry On June 1, 2021, 6:59

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73317/#review223088 --- Thanks for the patch. The model looks good. Can you please attach

Re: Review Request 73394: ATLAS-4317 : Upgrade curator jar version to 4.3.0

2021-06-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73394/#review223082 --- Ship it! Can you please add PC build details. - Ashutosh

Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73388/#review223066 --- Does 'timeout' of 0 indicate that no timeout is specified? -

Re: Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73376/#review223044 ---

Re: Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73376/#review223043 --- webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java

Review Request 73375: Handle Spool Directory Creation by Different Users

2021-05-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73375/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Re: Review Request 73372: [Glossary Bulk Import] Rename template file name from "template" to "template_glossary" to maintain parity with Business Metadata Bulk Import

2021-05-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73372/#review223037 --- webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 20, 2021, 10:18 p.m.) Review request for atlas, Radhika Kundam

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-19 Thread Ashutosh Mestry via Review Board
> On May 18, 2021, 6:05 a.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/notification/EntityCorrelationManager.java > > Lines 93 (patched) > > > > > > this checks for the first entry that is

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 20, 2021, 4 a.m.) Review request for atlas, Radhika Kundam and

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-17 Thread Ashutosh Mestry via Review Board
> On May 18, 2021, 4:34 a.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/notification/EntityCorrelationManager.java > > Lines 76 (patched) > > > > > > we don't need to reverse iterate the

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 18, 2021, 5:39 a.m.) Review request for atlas, Radhika Kundam and

Re: Review Request 73356: Improve Tag Propagation in Entities Involved in Several Lineages

2021-05-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73356/ --- (Updated May 14, 2021, 4:48 p.m.) Review request for atlas, Jayendra Parab,

Review Request 73356: Improve Tag Propagation in Entities Involved in Several Lineages

2021-05-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73356/ --- Review request for atlas, Jayendra Parab, Nikhil Bonte, and Sarath Subramanian.

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 11, 2021, 5:22 a.m.) Review request for atlas, Radhika Kundam and

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73317/#review222968 --- addons/models/1000-Hadoop/1110-flink_model.json Lines 46

Re: Review Request 73341: ATLAS-4278 - Deferred Actions : Deleting a tag after disassociating it from a table which propagated fails

2021-05-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73341/#review222967 --- Can you please update the jira/review with the error you saw in

Re: Review Request 73341: ATLAS-4278 - Deferred Actions : Deleting a tag after disassociating it from a table which propagated fails

2021-05-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73341/#review222966 --- Ship it! Ship It! - Ashutosh Mestry On May 9, 2021, 1:09

  1   2   3   4   >