[jira] [Resolved] (ATLAS-3729) Add audit operation as a parameter to v2/entity/{guid}/audit

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3729. --- Resolution: Duplicate > Add audit operation as a parameter to v2/entity/{guid}/au

[jira] [Updated] (ATLAS-3727) Add get result details REST for admin audit record

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3727: -- Description: Right now purge admin audit result stores purged entities guids. We need

[jira] [Updated] (ATLAS-3727) Add get result details REST for admin audit record

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3727: -- Fix Version/s: 2.1.0 > Add get result details REST for admin audit rec

[jira] [Updated] (ATLAS-3727) Add get result details REST for admin audit record

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3727: -- Affects Version/s: 2.0.0 > Add get result details REST for admin audit rec

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72351/#review220360 --- Ship it! Ship It! - Sarath Subramanian On April 13, 2020, 5

Re: Review Request 72372: ATLAS-3695 [Business Metadata] Special characters are being allowed in Attribute Name

2020-04-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72372/#review220359 --- Ship it! Ship It! - Sarath Subramanian On April 16, 2020

[jira] [Updated] (ATLAS-3734) AtlasPatchRegistry changes to get all patch information from graph query instead index queryUpdate AtlasPatchRegistry to use graph query instead index query for retrievin

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3734: -- Summary: AtlasPatchRegistry changes to get all patch information from graph query

[jira] [Updated] (ATLAS-3734) Update AtlasPatchRegistry to use graph query instead index query for retrieving all patch information

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3734: -- Summary: Update AtlasPatchRegistry to use graph query instead index query

[jira] [Updated] (ATLAS-3734) AtlasPatchRegistry changes to get all patch information from graph query instead index query

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3734: -- Component/s: atlas-core > AtlasPatchRegistry changes to get all patch informat

Re: Review Request 72375: ATLAS-3733: upgraded JanusGraph version to 0.5.1, and Tinkerpop to 3.4.6

2020-04-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72375/#review220358 --- Ship it! Ship It! - Sarath Subramanian On April 17, 2020

Re: Review Request 72374: ATLAS-3734:AtlasPatchRegistry changes to get all patch information from graph query instead index query

2020-04-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72374/#review220355 --- Ship it! Ship It! - Sarath Subramanian On April 17, 2020, 2

Re: Review Request 72375: ATLAS-3733: upgraded JanusGraph version to 0.5.1, and Tinkerpop to 3.4.6

2020-04-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72375/#review220342 --- Ship it! Ship It! - Sarath Subramanian On April 16, 2020, 5

Re: Review Request 72367: ATLAS-3709: fix to address skipped index initialization in earlier commit

2020-04-15 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72367/#review220321 --- Ship it! Ship It! - Sarath Subramanian On April 15, 2020

[jira] [Updated] (ATLAS-3730) In case Hard delete or Purge of an Entity we should make the entity status as purged instead of deleted at classification

2020-04-14 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3730: -- Component/s: atlas-core > In case Hard delete or Purge of an Entity we should m

[jira] [Updated] (ATLAS-3730) In case Hard delete or Purge of an Entity we should make the entity status as purged instead of deleted at classification

2020-04-14 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3730: -- Fix Version/s: 2.1.0 > In case Hard delete or Purge of an Entity we should m

[jira] [Updated] (ATLAS-3730) In case Hard delete or Purge of an Entity we should make the entity status as purged instead of deleted at classification

2020-04-14 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3730: -- Affects Version/s: 2.0.0 > In case Hard delete or Purge of an Entity we should m

Re: Review Request 72358: ATLAS-3730: In case Hard delete and Purge of an Entity we should make the entity status as purged instead of deleted

2020-04-13 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72358/#review220302 --- Ship it! Ship It! - Sarath Subramanian On April 13, 2020, 5

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-12 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/#review220294 --- Ship it! Ship It! - Sarath Subramanian On April 12, 2020, 1

[jira] [Updated] (ATLAS-3707) Atlas Purge entity is generating both purge and delete audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3707: -- Affects Version/s: 2.0.0 > Atlas Purge entity is generating both purge and del

[jira] [Updated] (ATLAS-3707) Atlas Purge entity is generating both purge and delete audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3707: -- Component/s: atlas-core > Atlas Purge entity is generating both purge and del

[jira] [Updated] (ATLAS-3707) Atlas Purge entity is generating both purge and delete audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3707: -- Fix Version/s: 2.1.0 > Atlas Purge entity is generating both purge and delete au

Re: Review Request 72284: ATLAS-3707: Atlas Purge entity is generating both purge and delete audit

2020-04-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72284/#review220285 --- Ship it! Ship It! - Sarath Subramanian On March 30, 2020

[jira] [Resolved] (ATLAS-3679) Bulk import Business Metadata attribute assignment to entities

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3679. --- Resolution: Fixed > Bulk import Business Metadata attribute assignment to entit

[jira] [Updated] (ATLAS-3679) Bulk import Business Metadata attribute assignment to entities

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3679: -- Description: Implementation for 2 REST end points first for template download

[jira] [Updated] (ATLAS-3679) Bulk import Business Metadata attribute assignment to entities

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3679: -- Affects Version/s: 2.0.0 > Bulk import Business Metadata attribute assignm

[jira] [Updated] (ATLAS-3679) Bulk import Business Metadata attribute assignment to entities

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3679: -- Fix Version/s: 2.1.0 > Bulk import Business Metadata attribute assignment to entit

[jira] [Updated] (ATLAS-3679) Bulk import Business Metadata attribute assignment to entities

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3679: -- Component/s: atlas-core > Bulk import Business Metadata attribute assignm

[jira] [Resolved] (ATLAS-3709) [Business Metadata] Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3709. --- Resolution: Fixed > [Business Metadata] Issues with quick search/suggesti

[jira] [Updated] (ATLAS-3709) [Business Metadata] Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3709: -- Fix Version/s: 2.1.0 > [Business Metadata] Issues with quick search/suggesti

[jira] [Updated] (ATLAS-3709) [Business Metadata] Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3709: -- Affects Version/s: (was: 3.0.0) (was: 2.1.0

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/#review220283 --- Ship it! Ship It! - Sarath Subramanian On April 10, 2020, 2

[jira] [Updated] (ATLAS-3726) Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3726: -- Affects Version/s: 2.0.0 > Add result count to Atlas Admin Audit and enable filt

[jira] [Updated] (ATLAS-3726) Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3726: -- Component/s: atlas-core > Add result count to Atlas Admin Audit and enable filt

[jira] [Resolved] (ATLAS-3726) Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3726. --- Resolution: Fixed > Add result count to Atlas Admin Audit and enable filt

[jira] [Updated] (ATLAS-3726) Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3726: -- Fix Version/s: 2.1.0 > Add result count to Atlas Admin Audit and enable filt

Re: Review Request 72338: ATLAS-3726: Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72338/#review220271 --- Ship it! Ship It! - Sarath Subramanian On April 9, 2020, 11

Re: Review Request 72338: ATLAS-3726: Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-08 Thread Sarath Subramanian
) <https://reviews.apache.org/r/72338/#comment308603> change 'isIndexable' to true to enable search on result count - Sarath Subramanian On April 8, 2020, 11:19 a.m., Sidharth Mishra wrote: > > --- > This is an automati

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-08 Thread Sarath Subramanian
ionListenerV2.java Lines 323 (patched) <https://reviews.apache.org/r/72270/#comment308586> nit: add comments inside these methods - "// do nothing -> notification not sent out for business metadata attribute addition/updation/removal from entities" - Sarath S

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-08 Thread Sarath Subramanian
<https://reviews.apache.org/r/72317/#comment308580> code duplicated. Try to use 'changedTypeDefs' to include 'changedBusinessMetadataDefs' - Sarath Subramanian On April 6, 2020, 11:20 p.m., Mandar Ambawane wrote: > > --- > Thi

[jira] [Commented] (ATLAS-3722) ZipFileMigrationImporter: Allow AtlasPatchService to Run Before Migration Starts

2020-04-07 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077531#comment-17077531 ] Sarath Subramanian commented on ATLAS-3722: --- +1 thanks for the patch [~amestry

Re: Review Request 72318: ATLAS-3718: Update Hive hook to create ADLS-Gen2 entities for ABFS path references

2020-04-06 Thread Sarath Subramanian
://reviews.apache.org/r/72318/diff/2/ Changes: https://reviews.apache.org/r/72318/diff/1-2/ Testing --- Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1785/console Thanks, Sarath Subramanian

[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-06 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076495#comment-17076495 ] Sarath Subramanian commented on ATLAS-3702: --- +1 for the patch. Thanks [~amestry] > Ent

Review Request 72318: ATLAS-3708: Update Hive hook to create ADLS-Gen2 entities for ABFS path references

2020-04-03 Thread Sarath Subramanian
/r/72318/diff/1/ Testing --- Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1785/console Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3718) Update Hive hook to create ADLS-Gen2 entities for ABFS path references

2020-04-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3718: -- Attachment: external-table-lineage.png adles-gen2-account-entity.png

[jira] [Created] (ATLAS-3718) Update Hive hook to create ADLS-Gen2 entities for ABFS path references

2020-04-03 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3718: - Summary: Update Hive hook to create ADLS-Gen2 entities for ABFS path references Key: ATLAS-3718 URL: https://issues.apache.org/jira/browse/ATLAS-3718

Re: Review Request 72311: ATLAS-3716: updated entity-def to support displayTextAttribute option

2020-04-03 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72311/#review220209 --- Ship it! Ship It! - Sarath Subramanian On April 2, 2020, 5

Re: Review Request 72311: ATLAS-3716: updated entity-def to support displayTextAttribute option

2020-04-03 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72311/#review220208 --- Ship it! Ship It! - Sarath Subramanian On April 2, 2020, 5

Re: Review Request 72311: ATLAS-3716: updated entity-def to support displayTextAttribute option

2020-04-03 Thread Sarath Subramanian
value? - Sarath Subramanian On April 2, 2020, 5:30 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

2020-03-31 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72288/#review220157 --- Ship it! Ship It! - Sarath Subramanian On March 31, 2020, 1

[jira] [Commented] (ATLAS-3708) displayName field AtlasAttributeDef is not persisted

2020-03-30 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071441#comment-17071441 ] Sarath Subramanian commented on ATLAS-3708: --- Thanks for the patch [~madhan]. +1 > displayN

Re: Review Request 72265: ATLAS-3684: Atlas glossary get is taking more time when number of terms increase

2020-03-30 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72265/#review220129 --- Ship it! Ship It! - Sarath Subramanian On March 30, 2020

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Sarath Subramanian
empty map | Empty| Null| => Will set to empty map | Not Null | Null| => Will set to empty map |---| Please review. - Sarath Subramanian On March 30, 2020, 2:45 p.

Re: Review Request 72268: ATLAS-3688: updated dependencies to remove unnecessary references

2020-03-25 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72268/#review220080 --- Ship it! Ship It! - Sarath Subramanian On March 25, 2020

[jira] [Commented] (ATLAS-3666) file-based authentication improvement

2020-03-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066147#comment-17066147 ] Sarath Subramanian commented on ATLAS-3666: --- Thanks for the patch [~madhan]. +1 for [^ATLAS

[jira] [Commented] (ATLAS-3669) UI: Import Glossary Terms CSV into a Glossary

2020-03-23 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065328#comment-17065328 ] Sarath Subramanian commented on ATLAS-3669: --- +1. Thanks [~kevalbhatt] > UI: Import Gloss

[jira] [Commented] (ATLAS-3423) Import Glossary Terms CSV into a Glossary

2020-03-23 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065327#comment-17065327 ] Sarath Subramanian commented on ATLAS-3423: --- Thanks for the patch [~mayank_nj]. +1 for the Test

[jira] [Assigned] (ATLAS-3680) Regression : _ALL_ENTITY_TYPES with any system attribute filter throws 500 exception

2020-03-23 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian reassigned ATLAS-3680: - Assignee: Pinal (was: Madhan Neethiraj) > Regression : _ALL_ENTITY_TY

[jira] [Resolved] (ATLAS-3675) Enable quick search and suggestions for business metadata attributes

2020-03-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3675. --- Resolution: Fixed > Enable quick search and suggestions for business metad

Re: Review Request 72259: ATLAS-3675 Enable quick search and suggestions for business metadata attributes

2020-03-22 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72259/#review220055 --- Ship it! Ship It! - Sarath Subramanian On March 21, 2020, 1

[jira] [Updated] (ATLAS-3423) Import Glossary Terms CSV into a Glossary

2020-03-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3423: -- Component/s: atlas-core > Import Glossary Terms CSV into a Gloss

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-21 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71482/#review220053 --- Ship it! Ship It! - Sarath Subramanian On March 20, 2020, 7

[jira] [Commented] (ATLAS-1866) Documentation for PAM type authentication and better logging for PAM auth.

2020-03-12 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058141#comment-17058141 ] Sarath Subramanian commented on ATLAS-1866: --- +1 > Documentation for PAM type authenticat

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

2020-03-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72223/#review219902 --- Ship it! Ship It! - Sarath Subramanian On March 11, 2020, 1

Re: Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

2020-03-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72224/#review219903 --- Ship it! Ship It! - Sarath Subramanian On March 11, 2020

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

2020-03-11 Thread Sarath Subramanian
(patched) <https://reviews.apache.org/r/72223/#comment308140> propagation turned ON by default? if account contains lot of container. account -> countainers and parent -> children - Sarath Subramanian On March 11, 2020, 1:23 a.m., Madhan Nee

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

2020-03-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72223/#review219897 --- Ship it! Ship It! - Sarath Subramanian On March 11, 2020, 1

Re: Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

2020-03-11 Thread Sarath Subramanian
/model/instance/AtlasClassification.java Lines 107 (patched) <https://reviews.apache.org/r/72224/#comment308138> can we reuse isPropagate() ? if its serialization issue consider changing all references of isPropagate() to getPropagate() - Sarath Subramanian On March 11, 2020, 12:

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/#review219859 --- Ship it! Ship It! - Sarath Subramanian On March 5, 2020, 9

[jira] [Resolved] (ATLAS-3656) UI: Rename type Namespace to BusinessMetadata

2020-03-09 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3656. --- Resolution: Fixed > UI: Rename type Namespace to BusinessMetad

[jira] [Commented] (ATLAS-3656) UI: Rename type Namespace to BusinessMetadata

2020-03-09 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055368#comment-17055368 ] Sarath Subramanian commented on ATLAS-3656: --- Thanks for the patch [~kevalbhatt]. +1 >

Re: Review Request 72214: ATLAS-3659: updated Hive hook to use aws_s3 V2 types

2020-03-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72214/#review219842 --- Ship it! Ship It! - Sarath Subramanian On March 8, 2020, 9

Re: Review Request 72212: ATLAS-3658: updated JanusGraph version to 0.4.1 and Tinkerpop version to 3.4.4

2020-03-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72212/#review219840 --- Ship it! Ship It! - Sarath Subramanian On March 8, 2020, 9

Re: Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-06 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72197/#review219818 --- Ship it! Ship It! - Sarath Subramanian On March 5, 2020, 1

[jira] [Updated] (ATLAS-3618) Entities with no guid appears in search result

2020-03-05 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3618: -- Affects Version/s: 2.0.0 > Entities with no guid appears in search res

[jira] [Updated] (ATLAS-3618) Entities with no guid appears in search result

2020-03-05 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3618: -- Fix Version/s: 2.1.0 > Entities with no guid appears in search res

[jira] [Updated] (ATLAS-3618) Entities with no guid appears in search result

2020-03-05 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3618: -- Component/s: atlas-core > Entities with no guid appears in search res

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-05 Thread Sarath Subramanian
/IFullTextMapper.java Lines 34 (patched) <https://reviews.apache.org/r/71025/#comment307984> methods defined here looks more of like helper methods than interface methods. - Sarath Subramanian On March 4, 2020, 10:09 p.m., Ashutosh Mestry

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-05 Thread Sarath Subramanian
r refactoring to method: ImportStrategy importStrategy = initImportStrategy(importResult); - Sarath Subramanian On March 4, 2020, 10:09 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated

Re: Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-05 Thread Sarath Subramanian
/web/rest/EntityREST.java Line 860 (original), 860 (patched) <https://reviews.apache.org/r/72197/#comment307979> can we use 'extension' instead of 'extns' in REST path for clarity? e.g. "/guid/{guid}/extensions" - Sarath Subramanian On March 4, 2020, 9:10 p.m., Madhan

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-03 Thread Sarath Subramanian
/v2/EntityGraphMapper.java Lines 384 (patched) <https://reviews.apache.org/r/71025/#comment307948> can you avoid this null check? consider initializing 'entityChangeNotifier' to a no-op operation. - Sarath Subramanian On March 2, 2020, 9:13 p.m., Ashutosh Mestry

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219727 --- Ship it! Ship It! - Sarath Subramanian On March 2, 2020, 1

[jira] [Commented] (ATLAS-3621) update Hive took to not save query-string in 2 attributes - queryText and name

2020-02-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042348#comment-17042348 ] Sarath Subramanian commented on ATLAS-3621: --- +1 for the patch ATLAS-3621-master-2.patch. Thanks

Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification

2020-02-20 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72127/#review219623 --- Ship it! Ship It! - Sarath Subramanian On Feb. 20, 2020, 9

Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification

2020-02-20 Thread Sarath Subramanian
tlas/discovery/EntitySearchProcessor.java Lines 349 (patched) <https://reviews.apache.org/r/72127/#comment307825> nit: remove new line - Sarath Subramanian On Feb. 18, 2020, 3:57 a.m., Pinal Shah wrote: > > --- > This is

Re: Review Request 72069: ATLAS-3602: Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-02-03 Thread Sarath Subramanian
/EntityGraphMapper.java e427a59e7 Diff: https://reviews.apache.org/r/72069/diff/4/ Changes: https://reviews.apache.org/r/72069/diff/3-4/ Testing --- Manually validated and perf improvement seen during add/delete classifications Thanks, Sarath Subramanian

Re: Review Request 72069: ATLAS-3602: Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-02-03 Thread Sarath Subramanian
: https://reviews.apache.org/r/72069/diff/3/ Changes: https://reviews.apache.org/r/72069/diff/2-3/ Testing --- Manually validated and perf improvement seen during add/delete classifications Thanks, Sarath Subramanian

Re: Review Request 72069: ATLAS-3602: Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-02-03 Thread Sarath Subramanian
://reviews.apache.org/r/72069/diff/2/ Changes: https://reviews.apache.org/r/72069/diff/1-2/ Testing --- Manually validated and perf improvement seen during add/delete classifications Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3601) No LABEL_DELETE event is audited when last label is deleted

2020-02-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3601: -- Affects Version/s: 2.0.0 > No LABEL_DELETE event is audited when last la

[jira] [Updated] (ATLAS-3601) No LABEL_DELETE event is audited when last label is deleted

2020-02-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3601: -- Component/s: atlas-core > No LABEL_DELETE event is audited when last la

[jira] [Updated] (ATLAS-3601) No LABEL_DELETE event is audited when last label is deleted

2020-02-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3601: -- Fix Version/s: 2.1.0 > No LABEL_DELETE event is audited when last label is dele

Re: Review Request 72060: ATLAS-3601 No LABEL_DELETE event is audited when last label is deleted.

2020-02-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72060/#review219465 --- Ship it! Ship It! - Sarath Subramanian On Jan. 30, 2020, 4

Re: Review Request 72060: ATLAS-3601 No LABEL_DELETE event is audited when last label is deleted.

2020-02-02 Thread Sarath Subramanian
> On Jan. 30, 2020, 2:48 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java > > Line 161 (original), 161 (patched) > > <https://reviews.apache.org/r/72060/diff/1/?file=2210004#file2210004

Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance

2020-02-02 Thread Sarath Subramanian
: N1 - N2 ``` - Sarath Subramanian On Jan. 31, 2020, 4:40 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 72069: ATLAS-3602: Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-01-30 Thread Sarath Subramanian
/delete classifications Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3602) Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-01-30 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3602: -- Attachment: ATLAS-3602.001.patch > Provide option to Ignore relationship attrib

[jira] [Created] (ATLAS-3602) Provide option to Ignore relationship attribute mapping in getAndCacheEntity()

2020-01-30 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3602: - Summary: Provide option to Ignore relationship attribute mapping in getAndCacheEntity() Key: ATLAS-3602 URL: https://issues.apache.org/jira/browse/ATLAS-3602

Re: Review Request 72060: ATLAS-3601 No LABEL_DELETE event is audited when last label is deleted.

2020-01-30 Thread Sarath Subramanian
using the new key format? Please review. - Sarath Subramanian On Jan. 30, 2020, 4:10 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Commented] (ATLAS-3599) Beta UI: While Saving search , limit and offset are not set properly when using Beta UI.

2020-01-28 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025287#comment-17025287 ] Sarath Subramanian commented on ATLAS-3599: --- +1. Thanks [~kevalbhatt]! > Beta UI: While Sav

Re: Review Request 72050: ATLAS-3597 Incorrect error message when attempting to update Namespacedef

2020-01-27 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72050/#review219391 --- Ship it! Ship It! - Sarath Subramanian On Jan. 27, 2020, 4

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-22 Thread Sarath Subramanian
r/71791/#comment307517> "/audit" => "/audits" webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 577 (patched) <https://reviews.apache.org/r/71791/#comment307513>

<    1   2   3   4   5   6   7   8   9   10   >