Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-20 Thread Rui Wang
After I switched from Mac to Ubuntu, the dependency check starts to work :) -Rui On Mon, Dec 20, 2021 at 11:47 AM Rui Wang wrote: > I am Generate a report of vulnerabilities that occur among dependencies > when running `./gradlew :dependencyCheckUpdate`, I consistently hit > > Unable to

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-20 Thread Rui Wang
I am Generate a report of vulnerabilities that occur among dependencies when running `./gradlew :dependencyCheckUpdate`, I consistently hit Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/xxx.meta and seems the root cause is "unable to connect". Has anyone seen it in the

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-19 Thread Rui Wang
Hi community, Now the main branch is locked at [1]. I will work toward RC0. [1] https://github.com/apache/calcite/commit/7a7b37fc1f4bd2121643539b0fd8e9c4f0f8ed09 -Rui On Sun, Dec 19, 2021 at 1:19 AM Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > Hello everyone, > I have

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-19 Thread Alessandro Solimando
Hello everyone, I have merged https://github.com/apache/calcite/pull/2628 ( https://issues.apache.org/jira/browse/CALCITE-4917) into master. Best regards, Alessandro On Sat, 18 Dec 2021 at 21:21, Rui Wang wrote: > Thanks for more information Julian. Then there should not have known > blockers

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Rui Wang
Thanks for more information Julian. Then there should not have known blockers at this moment. Hi Alessandro, I will wait for another 24 hours before blocking the main branch. It should be enough time so please feel free to merge PR once there is no objection. -Rui On Sat, Dec 18, 2021 at 11:45

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Alessandro Solimando
Hi everyone, I'd like to merge https://github.com/apache/calcite/pull/2628 ( https://issues.apache.org/jira/browse/CALCITE-4917) which is ready if there are no objections. Since it's just adding an extra test it's not urgent at all, so if it causes any troubles it can be postponed after the

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Julian Hyde
Ah, I see Stamatis has Log4j covered: https://issues.apache.org/jira/browse/CALCITE-4950 . > On Dec 18, 2021, at 10:17 AM, Julian Hyde wrote: > > I think we should skip CALCITE-4907. There’s still discussion in its PR, >

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Julian Hyde
I think we should skip CALCITE-4907. There’s still discussion in its PR, https://github.com/apache/calcite/pull/2620 . I promise we’ll get it in soon after the release. In other news, there’s a new Log4j version, 2.17, addressing a new CVE[1].

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Vladimir Ozerov
Hi Xiong, Thank you very much. Vladimir. Сб, 18 дек. 2021 г. в 14:32, xiong duan : > Hi Vladimir, > > I have merged. > > Vladimir Ozerov 于2021年12月18日周六 16:58写道: > > > Hi Xiong, > > > > I've just resolved the conflicts. > > > > Regards, > > Vladimir. > > > > сб, 18 дек. 2021 г. в 10:48, xiong

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-18 Thread Vladimir Ozerov
Hi Xiong, I've just resolved the conflicts. Regards, Vladimir. сб, 18 дек. 2021 г. в 10:48, xiong duan : > Hi, Vladimir. > > The PR[https://github.com/apache/calcite/pull/2464] looks good. If you > have > free time Please resolve the conflicts. Then we can merge it. > > Vladimir Ozerov

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread xiong duan
Hi, Vladimir. The PR[https://github.com/apache/calcite/pull/2464] looks good. If you have free time Please resolve the conflicts. Then we can merge it. Vladimir Ozerov 于2021年12月18日周六 15:20写道: > Hi, > > Could you please also merge > https://github.com/apache/calcite/pull/2464 ? I guess it got

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Vladimir Ozerov
Hi, Could you please also merge https://github.com/apache/calcite/pull/2464 ? I guess it got stuck somehow, as all the comments are addressed. This issue forced us to create a copy of the AggregateUnionTransposeRule in our project. Regards, Vladimir Сб, 18 дек. 2021 г. в 09:51, Rui Wang : >

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Rui Wang
Thanks Julian! Now we will just decide whether to merge CALCITE-4907 or not, then I will lock the main branch and start the release process. -Rui On Fri, Dec 17, 2021 at 10:29 PM Julian Hyde wrote: > Rui, I have merged CALCITE-4946. > > > On Dec 17, 2021, at 10:21 PM, Rui Wang wrote: > > >

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Julian Hyde
Rui, I have merged CALCITE-4946. > On Dec 17, 2021, at 10:21 PM, Rui Wang wrote: > > Thanks Zhe. > > Hi Francesco, > > I left a comment in your PR. Can you take a look? > > -Rui > > On Fri, Dec 17, 2021 at 3:32 PM Zhe Hu wrote: > >> Hi, Rui. >> CALCITE-4860 will be fixed in next release,

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Rui Wang
Thanks Zhe. Hi Francesco, I left a comment in your PR. Can you take a look? -Rui On Fri, Dec 17, 2021 at 3:32 PM Zhe Hu wrote: > Hi, Rui. > CALCITE-4860 will be fixed in next release, you can pass it currently. > Thanks for your work! > > > Best, > ZheHu > > > > > > > On 12/18/2021

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Zhe Hu
Hi, Rui. CALCITE-4860 will be fixed in next release, you can pass it currently. Thanks for your work! Best, ZheHu On 12/18/2021 06:08,Francesco Gini wrote: https://issues.apache.org/jira/browse/CALCITE-4907 is in review. I believe I have addressed all the comments. Let me know if I missed

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Francesco Gini
https://issues.apache.org/jira/browse/CALCITE-4907 is in review. I believe I have addressed all the comments. Let me know if I missed anything. On Fri, 17 Dec 2021 at 22:42, Jacques Nadeau wrote: > I've merged CALCITE-4948 to mitigate the concerns around CALCITE-4898 and > maven repositories

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Jacques Nadeau
I've merged CALCITE-4948 to mitigate the concerns around CALCITE-4898 and maven repositories and category x licenses. On Fri, Dec 17, 2021 at 1:02 PM Rui Wang wrote: > For the list of 1.29 fix Jira, several Jira have been marked as resolved > since this Monday. I will do another pass today but

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Rui Wang
For the list of 1.29 fix Jira, several Jira have been marked as resolved since this Monday. I will do another pass today but probably not all those will make the 1.29.0 release. -Rui On Fri, Dec 17, 2021 at 11:57 AM Ruben Q L wrote: > Hello, > > FYI

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Ruben Q L
Hello, FYI https://issues.apache.org/jira/browse/CALCITE-4737 has been merged. Regards, Ruben On Fri, Dec 17, 2021 at 7:40 PM Julian Hyde wrote: > Rui, > > Even though https://issues.apache.org/jira/browse/CALCITE-4898 < > https://issues.apache.org/jira/browse/CALCITE-4898> is marked fixed,

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Julian Hyde
Rui, Even though https://issues.apache.org/jira/browse/CALCITE-4898 is marked fixed, there’s some fallout regarding maven repositories and category X. That needs to be sorted out before RC0. See [1]. I’m working on getting