Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-14 Thread Tutkowski, Mike
I'm not sure, Daan. I plan to keep an eye on this behavior for a while when creating new clouds. From: Daan Hoogland Sent: Thursday, April 14, 2016 2:12 AM To: dev Subject: Re: Strange XenServer SR behavior when deploying system

SHA bbe0fc

2016-04-14 Thread Tutkowski, Mike
Hi, I noticed an issue in Marvin the other day and I tracked it to this commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d The problem is that it assumes the "ispublic" parameter will be provided. If it is not, then an

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59812425 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801544 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801500 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801445 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801354 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59801226 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() {

Re: Feature proposal: Resource naming policies

2016-04-14 Thread ilya
Awesome and long awaited On 4/14/16 4:40 AM, Jeff Hair wrote: > Yesterday, we submitted this pull request: > https://github.com/apache/cloudstack/pull/1492 > > This originally grew out of making the VirtualMachineName class non-static > (original PR is mentioned in the above link). We're

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59800993 --- Diff: api/test/org/apache/cloudstack/acl/RuleTest.java --- @@ -0,0 +1,39 @@ +package org.apache.cloudstack.acl; + +import

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59800725 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59800553 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59800354 --- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59800096 --- Diff: api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java --- @@ -117,6 +123,12 @@ public long getEntityOwnerId() {

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59799743 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59797686 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/ListRolePermissionsCmd.java --- @@ -0,0 +1,104 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59795416 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59792529 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59791280 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59790778 --- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java --- @@ -19,146 +19,198 @@ package com.cloud.utils.testcase;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59788566 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/DeleteRolePermissionCmd.java --- @@ -0,0 +1,84 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59788517 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/DeleteRoleCmd.java --- @@ -0,0 +1,84 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59788370 --- Diff: api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java --- @@ -0,0 +1,104 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59787197 --- Diff: api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java --- @@ -196,5 +204,8 @@ private void validateParams() {

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59787000 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59786533 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59785020 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59777518 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59773313 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-210103368 I've created two commits to show: (1) test to prove denial of service behavior due to blocking main IO loop, (2) the fix (as mentioned earlier long term fix would

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59773107 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-210086309 I see your point in regards to the garbage collector; but, that class is a singleton, it is not going to be allocated and deallocated. About the

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210087782 No problem. :) I had forgotten that I had renamed that file at one point. So, when I saw that you had a file by that name, I was really confused how

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210085510 i will blow away my git repo and start from scratch and we will go from there. :) thx... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210084608 @swill I think I might know what happened. There used to be a ApiSolidFireServiceImpl.java, but I renamed it in 940d5b. It seems the file is

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-210081688 @rafaelweingartner The issue is not one of style but performance and availability. The garbage collector skips reachability evaluations of ``final static``

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210081474 @swill I just pushed a new commit to rename the SolidFire integration testing project (which you saw as failing). While that should not have

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210081172 np, imagined that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210078861 @DaanHoogland I apologize -- I missed the context. Yes, for an integration test, a counter would be perfectly acceptable, and likely, the best choice to ensure

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-210078579 @jburwell I agree with you that all static can be final. I disagree that loggers should be static, but that is a matter of taste. I understand the cache

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r59762357 --- Diff: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResourceTest.java --- @@ -88,6

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210072697 This might be a better link (as it includes the SHA): https://github.com/apache/cloudstack/tree/ee5370536ac3f87457d5f74adbbb8c6af88da449/plugins/api

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210072035 @swill This is pretty strange. The code that is failing to compile for you is actually not part of the codebase for ee53705:

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-210066343 @rafaelweingartner all statics should ``final`` unless there is explicit handling for their value changing due to thread safety issues. For loggers, they should

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210066399 @swill Weird, I've compiled ee53705 with the following command on two separate machines and I ran regression tests against that SHA for a few hours

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210056555 @jburwell we are talking about integration test code here! not about a production policy. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210055791 @DaanHoogland -1 to counters -- the require coordination across all nodes in the cluster. In multi-region configurations, they would require coordination across

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210052430 sorry for not answerring on github I could imagine a policy that keeps a static counter and name a resource bla- and then checks if the next

Re: [GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread Daan Hoogland
On Thu, Apr 14, 2016 at 4:14 PM, ProjectMoon wrote: > Github user ProjectMoon commented on the pull request: > > https://github.com/apache/cloudstack/pull/1492#issuecomment-209963503 > > @DaanHoogland Do you have any kind of integration tests in mind? > ​I could

Re: Feature proposal: Resource naming policies

2016-04-14 Thread Jeff Hair
With this feature, it is possible to change the names that get sent to the hypervisor, yes. In 4.2 we actually had to fix an issue with the security groups because they weren't parsing properly. That isn't in the commit yet. We will put it in. It would be useful to have a list of all the places

Re: Feature proposal: Resource naming policies

2016-04-14 Thread Koushik Das
Are these the names that are sent to HV? For e.g. VM name in the format i-xx-yy-VM. Currently there are functionalities that rely on the internal naming convention. All such functionalities needs to be handled appropriately. -Koushik From: Jeff Hair

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-14 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-210018309 @syed, I totally understand that you do not have much experience with Java development and that you were following the practices already put in place. The

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-04-14 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-210018290 @sverrirab how much effort would it be to port to Python? That seems far preferable for two reasons. First, as @eriweb rightly points out, it is a large

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-04-14 Thread eriweb
Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-210016535 Quite horribly that we need those modules for a simple perl script of 58 lines (including license header and empty lines). Not related to your PR though, but a good

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210012980 Looking closer at this code. It look like `primaryStoreDriver` could easily be `null` in this case, so that return statement could potentially cause a null pointer

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-14 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-210009483 This does not compile: ``` [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

RE: [discuss] CloudStack logging

2016-04-14 Thread Paul Angus
The file in a running installation you want is: /etc/cloudstack/management/ log4j-cloud.xml It is generally dynamic - you don't have to restart mgmt. server, it just takes a few seconds to kick in. If you're looking at the source code, various components use logging - SystemVMs, KVM agents,

RE: [discuss] CloudStack logging

2016-04-14 Thread Chaz PC
I am confused about the configuration file there two files one is named Log4j-cloud.xml The other is Log4j-cloud.xml.in What is the difference between these two files ? I hope someone can help me clear this confusion Original message From: Koushik Das

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-04-14 Thread sverrirab
GitHub user sverrirab opened a pull request: https://github.com/apache/cloudstack/pull/1495 Add perl-modules as install dependency for cloudstack-agent Required to run perl scripts that configure networking for VMs. You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59730927 --- Diff: api/src/org/apache/cloudstack/acl/RoleService.java --- @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundation (ASF) under one

Re: [discuss] CloudStack logging

2016-04-14 Thread Koushik Das
Based on the namespace log level can be set. It needs to be configured in the log4j. Check client/tomcatconf/log4j-cloud.xml.in in the source code and you will get an idea. -Koushik From: williamstev...@gmail.com on behalf of

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59730334 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59730081 --- Diff: api/src/org/apache/cloudstack/acl/RoleType.java --- @@ -16,18 +16,90 @@ // under the License. package org.apache.cloudstack.acl;

Re: [discuss] CloudStack logging

2016-04-14 Thread Patrick Dube
Really agree with this one. With a toolchain like ELK, it isn't as bad because you can filter out the things you don't want, but generally speaking, the log levels need to be reevaluated. I would also add that many log statements would benefit from additional context, but that is a whole different

Re: [discuss] CloudStack logging

2016-04-14 Thread Simon Weller
I'm all for this as well. Training our systems folks on how to work through the logs is a pain. Focusing in on the most important items is more useful and also makes it easier to automate log fetching and categorization. - Si From: Paul Angus

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209963503 @DaanHoogland Do you have any kind of integration tests in mind? --- If your project is set up for it, you can reply to this email and have your reply appear

RE: [discuss] CloudStack logging

2016-04-14 Thread Paul Angus
Grabbing a couple of examples - these should be debug - I can't 'do' anything with this information. INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-4119d5bc) Begin cleanup expired async-jobs INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-4119d5bc)

Re: [discuss] CloudStack logging

2016-04-14 Thread Wido den Hollander
> Op 14 april 2016 om 14:49 schreef Paul Angus : > > > Hi All > > I think that we can all agree that CloudStack logs are very difficult to read, > especially for operational staff. > > I believe that the primary reason for this is that a large amount of what > should

Re: [discuss] CloudStack logging

2016-04-14 Thread Will Stevens
Do you have to recompile in order to turn off the logging for a specific package or class? If yes, that is a show stopper for almost everyone... If it only requires a management server restart, that is more realistic. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue

Re: [discuss] CloudStack logging

2016-04-14 Thread Daan Hoogland
On Thu, Apr 14, 2016 at 3:41 PM, Will Stevens wrote: > Is there an easy way to do that Daan, or is it a tedious task you just have > to power through? > ​It is hard work, mostly tedious, sometimes hilarious and most definitely ​ ​devops!​ It certainly wouldn't classify

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59717381 --- Diff: engine/schema/src/com/cloud/naming/ConsoleProxyNamingPolicy.java --- @@ -0,0 +1,9 @@ +package com.cloud.naming; --- End diff --

Re: [discuss] CloudStack logging

2016-04-14 Thread Will Stevens
Is there an easy way to do that Daan, or is it a tedious task you just have to power through? I agree this initiative would be helpful. On Apr 14, 2016 9:04 AM, "Daan Hoogland" wrote: > I largely agree with just one sneer to the operators amongst us: the level > can be

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209945535 @ProjectMoon I will run through the code after I read the detailed design. one remark so far. This is a nice feature to have. please add integration tests for

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59717124 --- Diff: plugins/naming-policies/src/com/cloud/naming/DefaultConsoleProxyNamingPolicy.java --- @@ -0,0 +1,58 @@ +package com.cloud.naming;

Re: Feature proposal: Resource naming policies

2016-04-14 Thread Daan Hoogland
sounds usefull for companies that for instance want to enforce uuid in name or include some user string in it, same would be true for networks. look forward to your design. On Thu, Apr 14, 2016 at 1:40 PM, Jeff Hair wrote: > Yesterday, we submitted this pull request: >

Re: [discuss] CloudStack logging

2016-04-14 Thread Daan Hoogland
I largely agree with just one sneer to the operators amongst us: the level can be set on a per package and even class basis. So you can work through disabling anoying logging step by step. Makes sense to keep looking at the source in the meanwhile to make sure sensible diagnostics remains

[discuss] CloudStack logging

2016-04-14 Thread Paul Angus
Hi All I think that we can all agree that CloudStack logs are very difficult to read, especially for operational staff. I believe that the primary reason for this is that a large amount of what should be INFO level events are categorised as DEBUG. The logging therefore must be set at DEBUG

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-04-14 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-209922376 @koushik-das We are mostly working with 4.7 version, where other volume usage events get emitted correctly. We haven't investigated the behavior on master yet.

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-04-14 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-209922105 ### ACS CI BVT Run **Sumarry:** Build Number 175 Hypervisor xenserver NetworkType Advanced Passed=34 Failed=21 Skipped=2

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-04-14 Thread nnesic
Github user nnesic commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1491#discussion_r59707938 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account, long

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-04-14 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-209912550 @remibergsma, I've added description :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-209896417 - Tested against KVM, mgmt server - KVM links and clustered management server - NioTest modified to have multiple clients against a server instance with just

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-04-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-209893539 @nlivens Please add a description because this confuses me ;-) You guys go the non-oss way? :-( --- If your project is set up for it, you can reply to this

Feature proposal: Resource naming policies

2016-04-14 Thread Jeff Hair
Yesterday, we submitted this pull request: https://github.com/apache/cloudstack/pull/1492 This originally grew out of making the VirtualMachineName class non-static (original PR is mentioned in the above link). We're presenting this as a refactoring of the existing code to enable more

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209875708 > @ProjectMoon correct resource naming is critical to the proper operation of the management server. We have had a significant bugs and production issues

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209856388 thanks @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209856283 @ProjectMoon we'll need more information on why you're doing this, why we should have it, what is fixes and will it guarantee backward resource-name compatibility

[GitHub] cloudstack pull request: Master nuage

2016-04-14 Thread nlivens
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1494 Master nuage You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack master_nuage Alternatively you can review and apply these

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-04-14 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-209830019 @ProjectMoon On latest master during VM deployment no VOLUME.CREATE is getting generated for ROOT volume. Also during destroy there is no VOLUME.DELETE event.

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

2016-04-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-209822016 so it was a timeout: ``` [INFO] Apache CloudStack Plugin - Quota Service ... SUCCESS [ 44.634 s] [INFO] Apache CloudStack Framework -

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-14 Thread Daan Hoogland
Mike, did the iso copy process not complete as expected. Sound like they are a remanence of some task ending in an exception. Probably a silently ignored one ;| On Thu, Apr 14, 2016 at 2:49 AM, Tutkowski, Mike wrote: > Just an FYI, but when I kicked off my first VM in

[GitHub] cloudstack pull request: utils: Use non-blocking SSL handshake in ...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-209809491 @jburwell fixed all issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: utils: Use non-blocking SSL handshake in ...

2016-04-14 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1493#discussion_r59671416 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean isClient)