Re: [Proposal] - StorageHA

[Koushik Das]

Hi Jeromy,

Thanks for the proposal. It will good if you can create a FS in cwiki for the 
same. I saw your comment about force stopping VMs affected by primary storage 
outage. If this can be done without any issues then it can be leveraged to 
improve the current behavior of Cloudstack as well. Currently in case of 
primary storage outage all hosts attached to it are rebooted based on some 
timeout (for XS and KVM). Refer to the heartbeat scripts 
(scripts/vm/hypervisor/xenserver/xenheartbeat.sh and 
scripts/vm/hypervisor/kvm/kvmheartbeat.sh).

"3.  You need to be very sure of failures before shutting hosts down.  Also a 
host is likely to be connected to multiple storage pools, so you wouldn't want 
to shut down a host due to one pool becoming unavailable."

JG:  The script wouldn’t shut down any hosts at all.  Just force stop the 
affected VMs on that specific host and then start them on a host that is not 
having the issue with storage.

Thanks,
Koushik


On 15/03/17, 12:34 AM, "Rafael Weingärtner"  wrote:

Jeromy I already experienced a similar problem. A host had a problem of
connectivity with a storage, ACS did not know (I think it does check this
right now) and it was kind of odd. Because some VMs could not be started,
because of their last host id was the host with the connectivity problem.

I believe it would be a great thing to improve these checks and to treat
this type of problem in ACS.

My two cents:
Change the name of what you are proposing. It is not high availability per
se; it is more like a storage health check/heartbeat thing. It may give
people very high expectations (I am not trying to undermine the work that
is required). For instance, the first time I read your email, I thought
about real HA, with some sort of block replication and redundancy in the
storage system. That means, I was expecting if a whole storage goes down,
ACS would have to have a way of solving this problem without losing data
and without interrupting VMs. What you want to do is a little different, if
a host has some connectivity problem, we simply add it to the avoid list,
and then we migrate/move the VMs that were running there to a healthy host.

About the idea of being for KVM only; even though we might not be able to
run scripts on some hypervisors (Dom0 not being exposed), we could use
their API and check if the storage is responding. For instance, in XenServr
you could call “xe sr-scan uuid=” (or maybe other command
that uses storage), if there is any communication problem, it will report
an error. The same type of feature will probably be available on all other
hypervisors.

On Tue, Mar 14, 2017 at 1:46 PM, Jeromy Grimmett 
wrote:

> If all networking is lost, then obviously there is a bigger problem
> there.  The monitor is designed to do a true read/write test to the 
storage
> and report back a pass/fail.  Through this discussion, there was a ping
> suggestion, which I think we will include.
>
> The way this came about was that one of our hosts had a problem with a
> single primary storage, but all other hosts were 100% good across that
> storage and all others.  That troubled host was having problems with just
> the single storage device, but according to CloudStack, all was well and
> everything was good.  The way I am looking at this, is that what we are
> attempting to do is a much better and far more accurate test of storage
> availability compared to how Cloudstack currently does it based our
> experience.
>
> Make more sense?
>
> j
>
> Jeromy Grimmett
> P: 603.766.3625
> jer...@cloudbrix.com
> www.cloudbrix.com
>
>
> -Original Message-
> From: Simon Weller [mailto:swel...@ena.com]
> Sent: Tuesday, March 14, 2017 10:01 AM
> To: dev@cloudstack.apache.org
> Cc: Alex Bonilla 
> Subject: Re: [Proposal] - StorageHA
>
> So a few questions come to mind here.
>
>
> So if all networking is lost, how are you going to being able reliably
> fence the VM on the hosts?
>
> Are you assuming you still have out of band IPMI connectivity?
>
> If you're running bonded interfaces to different switches, what scenario
> would occur where the host loses network connectivity?
>
>
> - Si
>
> 
> From: Tutkowski, Mike 
> Sent: Tuesday, March 14, 2017 8:25 AM
> To: dev@cloudstack.apache.org
> Cc: Alex Bonilla
> Subject: Re: [Proposal] - StorageHA
>
> Thanks for your clarification. I see now. You were referring to a
> networking problem where one host could not see the storage (but the
> storage was still up and running).
>
> On 3/13/17, 10:31 

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

[yvsubhash]

Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
@ustcweizhou does it look good to you now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106089352
  
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long 
dataCenterId, Long podId, Long c
 // set up a new alert
 AlertVO newAlert = new AlertVO();
 newAlert.setType(alertType.getType());
-newAlert.setSubject(subject);
+//do not have a seperate column for content.
+//appending the message to the subject for now.
+newAlert.setSubject(subject+content);
--- End diff --

@rafaelweingartner 
I agree with you that it is a half measure, And so i commented "appending 
the message to the subject **for now**."  The idea was just to improve it 
little by little. We need not do every thing in this PR. We can work on it in a 
separate one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106088915
  
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
 
 public void pullAgentOutMaintenance(long hostId);
 
-boolean reconnect(long hostId);
+void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

@rafaelweingartner
When i said they will have to catch i meant, When a method declaration has 
one or more exceptions defined using throws clause then the method-call must 
handle all the defined exceptions. If he wants to handle it he will have to 
catch it, if he dose not want to handle he can bubble it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106088086
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java ---
@@ -100,17 +103,18 @@ public Long getInstanceId() {
 @Override
 public void execute() {
 try {
-Host result = _resourceService.reconnectHost(this);
-if (result != null) {
-HostResponse response = 
_responseGenerator.createHostResponse(result);
-response.setResponseName(getCommandName());
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
"Failed to reconnect host");
-}
-} catch (Exception ex) {
-s_logger.warn("Exception: ", ex);
-throw new 
ServerApiException(ApiErrorCode.RESOURCE_UNAVAILABLE_ERROR, ex.getMessage());
+Host result =_resourceService.reconnectHost(this);
--- End diff --

@rafaelweingartner 
reconnectHost now throws an exception instead of returning a null. So i 
have removed the null check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106088129
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -986,33 +986,28 @@ public Answer easySend(final Long hostId, final 
Command cmd) {
 }
 
 @Override
-public boolean reconnect(final long hostId) {
+public void reconnect(final long hostId) throws CloudRuntimeException, 
AgentUnavailableException{
--- End diff --

@rafaelweingartner 
The reconnect method is a method in the interface AgentManager.java, This 
interface is also implemented by ClusteredAgentManagerImpl.java in which 
propagateAgentEvent method throws a AgentUnavailableException.  So i had to add 
this to the interface and also to the implementing class method.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1923: CLOUDSTACK-9765: centos: packaging: fix missi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1923


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@rafaelweingartner stop start destroy etc all methods related to virtual 
router code have these parameters? Questions there is why are they not removed 
in the first place when they CallContext got introduced and removed at some 
places. That's why I would prefer to have different PR specifically for this. 
If something breaks then that can be easily tackled without the need of 
reverting some bug fix which may get lost later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[cloudsadhu]

Github user cloudsadhu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r106085688
  
--- Diff: test/integration/smoke/test_deploy_vm_root_resize.py ---
@@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self):
 # 2. root disk has new size per listVolumes
 # 3. Rejects non-supported hypervisor types
 """
-if(self.hypervisor.lower() == 'kvm'):
+full_clone_config = Configurations.list(self.apiclient,
+name="vmware.create.full.clone")[0].value
+if full_clone_config == 'false' and self.hypervisor.lower() == 
'vmware':
+self.skipTest("root disk resize is not supported "+
+"when vmware.create.full.clone is %s" % full_clone_config)
+
--- End diff --

thanks for  your comment.Sure will add  the logic  to 
test_deploy_vm_resize.py as well . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 468
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Retirement of midonet plugin

[Tutkowski, Mike]

Disable, then delete works for me, too.

On 3/14/17, 7:49 PM, "Simon Weller"  wrote:

I agree with Sergey and Will. Let's disable it first.

Simon Weller/615-312-6068

-Original Message-
From: Rafael Weingärtner [rafaelweingart...@gmail.com]
Received: Tuesday, 14 Mar 2017, 9:10PM
To: dev@cloudstack.apache.org [dev@cloudstack.apache.org]
Subject: [DISCUSS] Retirement of midonet plugin

Dear ACS fellows,
Recently there have been two threads asking and discussing the “midonet”
integration with Apache CloudStack (ACS) [1-2].

After quite some discussions, we noticed that despite having some people
willing to use it, the plugin has never been fully developed by its vendor
(Midokura). Further, nobody else has put the effort on fully testing and
finishing its implementation. It seems that the plugin was incorporated
into our code base without being fully finished. Moreover, I have asked
around at the Midonet community, and the java client they use has changed
quite a bit from the one we use.

It begs the question, if it does not work, why do we advertise such
integration? [3]. In my opinion, it would be great if we had such
integration; however, we as a community of individuals cannot bear the
burden with the cost of such task by ourselves.

It seems we have three options; (i) disable the build for the plugin and
let the code create its own mystic throughout time in ACS code base; (ii)
remove everything; or (iii) someone that may benefit from this plugin jumps
in and concludes the integration with Midonet using their new client.

There maybe other solutions that I am not seeing. So, @Devs yours thoughts
and comments are welcome ;)

[1]

http://cloudstack.markmail.org/thread/qyedle5jb2c34gsc#query:+page:1+mid:xn2zq2v3eim5vl2q+state:results
[2]

http://cloudstack.markmail.org/message/rewzk4v7dgzpsxkm?q=midonet+order:date-backward=1#query:midonet%20order%3Adate-backward+page:1+mid:i563khxlginf6smg+state:results
[3] http://docs.cloudstack.apache.org/en/latest/networking/midonet.html


--
Rafael Weingärtner

RE: [DISCUSS] Retirement of midonet plugin

[Simon Weller]

I agree with Sergey and Will. Let's disable it first.

Simon Weller/615-312-6068

-Original Message-
From: Rafael Weingärtner [rafaelweingart...@gmail.com]
Received: Tuesday, 14 Mar 2017, 9:10PM
To: dev@cloudstack.apache.org [dev@cloudstack.apache.org]
Subject: [DISCUSS] Retirement of midonet plugin

Dear ACS fellows,
Recently there have been two threads asking and discussing the “midonet”
integration with Apache CloudStack (ACS) [1-2].

After quite some discussions, we noticed that despite having some people
willing to use it, the plugin has never been fully developed by its vendor
(Midokura). Further, nobody else has put the effort on fully testing and
finishing its implementation. It seems that the plugin was incorporated
into our code base without being fully finished. Moreover, I have asked
around at the Midonet community, and the java client they use has changed
quite a bit from the one we use.

It begs the question, if it does not work, why do we advertise such
integration? [3]. In my opinion, it would be great if we had such
integration; however, we as a community of individuals cannot bear the
burden with the cost of such task by ourselves.

It seems we have three options; (i) disable the build for the plugin and
let the code create its own mystic throughout time in ACS code base; (ii)
remove everything; or (iii) someone that may benefit from this plugin jumps
in and concludes the integration with Midonet using their new client.

There maybe other solutions that I am not seeing. So, @Devs yours thoughts
and comments are welcome ;)

[1]
http://cloudstack.markmail.org/thread/qyedle5jb2c34gsc#query:+page:1+mid:xn2zq2v3eim5vl2q+state:results
[2]
http://cloudstack.markmail.org/message/rewzk4v7dgzpsxkm?q=midonet+order:date-backward=1#query:midonet%20order%3Adate-backward+page:1+mid:i563khxlginf6smg+state:results
[3] http://docs.cloudstack.apache.org/en/latest/networking/midonet.html


--
Rafael Weingärtner

Re: [DISCUSS] Retirement of midonet plugin

[Will Stevens]

I think we approach these with a disable, then delete approach. Disable for
one or two releases and if no one steps in to revive it in that period, we
delete it.

On Mar 14, 2017 9:10 PM, "Rafael Weingärtner" 
wrote:

Dear ACS fellows,
Recently there have been two threads asking and discussing the “midonet”
integration with Apache CloudStack (ACS) [1-2].

After quite some discussions, we noticed that despite having some people
willing to use it, the plugin has never been fully developed by its vendor
(Midokura). Further, nobody else has put the effort on fully testing and
finishing its implementation. It seems that the plugin was incorporated
into our code base without being fully finished. Moreover, I have asked
around at the Midonet community, and the java client they use has changed
quite a bit from the one we use.

It begs the question, if it does not work, why do we advertise such
integration? [3]. In my opinion, it would be great if we had such
integration; however, we as a community of individuals cannot bear the
burden with the cost of such task by ourselves.

It seems we have three options; (i) disable the build for the plugin and
let the code create its own mystic throughout time in ACS code base; (ii)
remove everything; or (iii) someone that may benefit from this plugin jumps
in and concludes the integration with Midonet using their new client.

There maybe other solutions that I am not seeing. So, @Devs yours thoughts
and comments are welcome ;)

[1]
http://cloudstack.markmail.org/thread/qyedle5jb2c34gsc#query:+page:1+mid:
xn2zq2v3eim5vl2q+state:results
[2]
http://cloudstack.markmail.org/message/rewzk4v7dgzpsxkm?
q=midonet+order:date-backward=1#query:midonet%20order%
3Adate-backward+page:1+mid:i563khxlginf6smg+state:results
[3] http://docs.cloudstack.apache.org/en/latest/networking/midonet.html


--
Rafael Weingärtner

Re: [DISCUSS] Retirement of midonet plugin

[Sergey Levitskiy]

I am for:
 (i) disable the build for the plugin for the next 2 major release followed by 
(ii)  remove everything in ACS 4.12 if no one express regrets by then

 

[DISCUSS] Retirement of midonet plugin

[Rafael Weingärtner]

Dear ACS fellows,
Recently there have been two threads asking and discussing the “midonet”
integration with Apache CloudStack (ACS) [1-2].

After quite some discussions, we noticed that despite having some people
willing to use it, the plugin has never been fully developed by its vendor
(Midokura). Further, nobody else has put the effort on fully testing and
finishing its implementation. It seems that the plugin was incorporated
into our code base without being fully finished. Moreover, I have asked
around at the Midonet community, and the java client they use has changed
quite a bit from the one we use.

It begs the question, if it does not work, why do we advertise such
integration? [3]. In my opinion, it would be great if we had such
integration; however, we as a community of individuals cannot bear the
burden with the cost of such task by ourselves.

It seems we have three options; (i) disable the build for the plugin and
let the code create its own mystic throughout time in ACS code base; (ii)
remove everything; or (iii) someone that may benefit from this plugin jumps
in and concludes the integration with Midonet using their new client.

There maybe other solutions that I am not seeing. So, @Devs yours thoughts
and comments are welcome ;)

[1]
http://cloudstack.markmail.org/thread/qyedle5jb2c34gsc#query:+page:1+mid:xn2zq2v3eim5vl2q+state:results
[2]
http://cloudstack.markmail.org/message/rewzk4v7dgzpsxkm?q=midonet+order:date-backward=1#query:midonet%20order%3Adate-backward+page:1+mid:i563khxlginf6smg+state:results
[3] http://docs.cloudstack.apache.org/en/latest/networking/midonet.html


-- 
Rafael Weingärtner

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 467
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=3
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_router_dns.py

 * test_router_dns_guestipquery Failed

* test_volumes.py

 * test_06_download_detached_volume Failed

* test_routers_network_ops.py

 * test_03_RVR_Network_check_router_state Failing since 2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1988
  
Trillian test result (tid-955)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30862 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1988-t955-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 324.14 | 
test_privategw_acl.py
test_01_create_iso | `Failure` | 1511.95 | test_iso.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 154.45 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 60.78 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 219.87 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 278.87 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 488.20 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 504.62 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1377.66 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 531.41 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 747.46 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1255.39 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.16 | test_volumes.py
test_08_resize_volume | Success | 156.26 | test_volumes.py
test_07_resize_fail | Success | 161.49 | test_volumes.py
test_06_download_detached_volume | Success | 156.17 | test_volumes.py
test_05_detach_volume | Success | 155.62 | test_volumes.py
test_04_delete_attached_volume | Success | 150.97 | test_volumes.py
test_03_download_attached_volume | Success | 155.99 | test_volumes.py
test_02_attach_volume | Success | 95.35 | test_volumes.py
test_01_create_volume | Success | 620.67 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.65 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 134.08 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.19 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.48 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.63 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.64 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.65 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.14 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.23 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 50.45 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.02 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.15 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 50.54 | test_templates.py
test_10_destroy_cpvm | Success | 161.26 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.40 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.48 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.33 | test_ssvm.py
test_06_stop_cpvm | Success | 136.60 | test_ssvm.py
test_05_stop_ssvm | Success | 133.48 | test_ssvm.py
test_04_cpvm_internals | Success | 1.12 | test_ssvm.py
test_03_ssvm_internals | Success | 16.51 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.93 | test_snapshots.py
test_04_change_offering_small | Success | 209.29 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.16 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.14 | 

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Ya, I am not sure where the problem is stemming from.  The fact that my 
code is not defensive around this problem is a problem.  That is for sure.  But 
given my understanding of the moving parts here, I feel like there is something 
else going on as well.  I will see if I can get an environment up and running 
tomorrow so I can do some more testing on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov what's the last commit in your code ?
could you check how many nics attached to the VR in database, select * from 
nics where instance_id= ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
it seems nicDevId is not set correctly in java code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: midonet-client and Guava dependency conflict

[Rafael Weingärtner]

This is why I suggested a discussion and then a vote. I know the idea of
removing a plugin may seem ignorant, but in my opinion, a code that does
not work, no one maintains, and we hear that never worked 100%, is not a
code worth to have in the code base.  My specific problem with this is that
it gives hope that may work in some situation, or that we may fix it one
day (without support); maybe I am just an old soul that have been so many
times frustrated with software that promised the moon and did not deliver
it.

Having said that, tonight I will start a discussion thread.
Hope to hear you all there.

On Tue, Mar 14, 2017 at 2:49 PM, Daan Hoogland 
wrote:

> I think removing the plugin build is friendly to the daring and won’t
> hinder the ignorant. Good call. However; less code always gets my vote as
> well. Conclusion I’m +/- 0 on this.
>
> On 14/03/17 19:43, "Rafael Weingärtner" 
> wrote:
>
> So, should we move to other thread to discuss and vote its removal or
> disable its plugin build?
>
> On Tue, Mar 14, 2017 at 10:49 AM, Daan Hoogland <
> daan.hoogl...@shapeblue.com
> > wrote:
>
> > Well, if Midokura is not willing to put in effort, ... Not sure what
> to
> > put on the dots.
> >
> > On 14/03/17 15:08, "Simon Weller"  wrote:
> >
> > We took a look at testing it in the lab back in early 2016  and
> > Midokura told us that it was a bad idea, probably wouldn't work and
> we
> > should just switch to openstack.
> >
> >
> > - Si
> >
> > 
> > From: Erik Weber 
> > Sent: Tuesday, March 14, 2017 3:28 AM
> > To: dev
> > Subject: Re: midonet-client and Guava dependency conflict
> >
> > On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
> >  wrote:
> > > I got a reply from Midonet community; they said that
> midonet-client
> > was
> > > incorporated by midonet-cluster (
> > > https://github.com/midonet/midonet/tree/staging/v5.4/
> midonet-cluster
> > ).
> > [https://avatars2.githubusercontent.com/u/9136532?v=3=400
> ] > github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster>
> >
> > midonet/midonet > tree/staging/v5.4/midonet-cluster>
> > github.com
> > midonet - MidoNet is an Open Source network virtualization
> system for
> > Openstack clouds
> >
> >
> >
> > >
> > >
> > > So, if anyone wants to invest energy on this, it might be a
> good
> > idea to
> > > upgrade the dependency. Moreover, I start to question the
> > compatibility of
> > > the current client we are using, with the mido-net server side
> that
> > might
> > > be deployed by users. Will this partial integration that we
> have
> > work?
> >
> >
> > Just as important to ask: "Has it ever worked?"
> > Do we know anyone who use, or have used, this integration?
> >
> > --
> > Erik
> >
> >
> >
> > daan.hoogl...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> Rafael Weingärtner
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
yes, agree with you @swill, it seems eth3 is duplicated eth2. The VR we're 
trying to bring up isn't supposed to have eth3 at all...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: midonet-client and Guava dependency conflict

[Daan Hoogland]

I think removing the plugin build is friendly to the daring and won’t hinder 
the ignorant. Good call. However; less code always gets my vote as well. 
Conclusion I’m +/- 0 on this.

On 14/03/17 19:43, "Rafael Weingärtner"  wrote:

So, should we move to other thread to discuss and vote its removal or
disable its plugin build?

On Tue, Mar 14, 2017 at 10:49 AM, Daan Hoogland  wrote:

> Well, if Midokura is not willing to put in effort, ... Not sure what to
> put on the dots.
>
> On 14/03/17 15:08, "Simon Weller"  wrote:
>
> We took a look at testing it in the lab back in early 2016  and
> Midokura told us that it was a bad idea, probably wouldn't work and we
> should just switch to openstack.
>
>
> - Si
>
> 
> From: Erik Weber 
> Sent: Tuesday, March 14, 2017 3:28 AM
> To: dev
> Subject: Re: midonet-client and Guava dependency conflict
>
> On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
>  wrote:
> > I got a reply from Midonet community; they said that midonet-client
> was
> > incorporated by midonet-cluster (
> > https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster
> ).
> [https://avatars2.githubusercontent.com/u/9136532?v=3=400] github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster>
>
> midonet/midonet tree/staging/v5.4/midonet-cluster>
> github.com
> midonet - MidoNet is an Open Source network virtualization system for
> Openstack clouds
>
>
>
> >
> >
> > So, if anyone wants to invest energy on this, it might be a good
> idea to
> > upgrade the dependency. Moreover, I start to question the
> compatibility of
> > the current client we are using, with the mido-net server side that
> might
> > be deployed by users. Will this partial integration that we have
> work?
>
>
> Just as important to ask: "Has it ever worked?"
> Do we know anyone who use, or have used, this integration?
>
> --
> Erik
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@anshul1886 what method that is called in multiple places are you talking 
about?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106002237
  
--- Diff: 
engine/schema/test/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImplTest.java
 ---
@@ -0,0 +1,151 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.storage.datastore.db;
+
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import 
org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDaoImpl.ValueType;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.storage.ScopeType;
+import com.cloud.storage.dao.StoragePoolHostDao;
+import com.cloud.storage.dao.StoragePoolTagsDao;
+
+import junit.framework.TestCase;
+
+@RunWith(PowerMockRunner.class)
+public class PrimaryDataStoreDaoImplTest extends TestCase {
+
+@Mock
+StoragePoolDetailsDao _detailsDao;
+@Mock
+StoragePoolHostDao _hostDao;
+@Mock
+StoragePoolTagsDao _tagsDao;
+
+@Spy
+@InjectMocks
+private static PrimaryDataStoreDaoImpl primaryDataStoreDao = new 
PrimaryDataStoreDaoImpl();
+
+@Mock
+static StoragePoolVO storagePoolVO;
--- End diff --

Thanks! I removed it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Cannot edit confluence wiki page

[Shanika Ediriweera]

Thank you.

Best Regards,

Shanika Ediriweera
Undergraduate
Dept. of Computer Science & Eng.
University of Moratuwa

On 14 March 2017 at 09:52, Rajani Karuturi  wrote:

> You(shanika) should have access to the edit the wiki now.
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On March 12, 2017 at 8:43 PM, Shanika Ediriweera
> (shanika...@cse.mrt.ac.lk) wrote:
>
> Thank you.
>
> Should I drop another mail saying I am interested in the above
> mentioned
> project
>
> Best Regards,
>
> Shanika Ediriweera
> Undergraduate
> Dept. of Computer Science & Eng.
> University of Moratuwa
>
> On 12 March 2017 at 13:41, sachin patil 
> wrote:
>
> Hello Shanika,
>
> Actually, the page was created so that gsoc students
> could add their names there. But that is not the case now as
> students
> don't have the rights required to update the page. I'll ask
> someone to
> remove/edit the page accordingly.
> regards,
> Sachin Patil
>
> On Sun, Mar 12, 2017 at 12:28 PM, Shanika Ediriweera <
> shanika...@cse.mrt.ac.lk> wrote:
>
> Hi,
>
> I am interested in CLOUDSTACK-9804
>  project
> for gsoc
> 2017.
>
> But I am unable to edit the page
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Googl
> e+Summer+of+Code+2017
> .
>
> Please could someone guide me how to edit the page and add my
> name in the
> "Candidates interested" column.
>
> Thank you.
>
> Best Regards,
>
> Shanika Ediriweera
> Undergraduate
> Dept. of Computer Science & Eng.
> University of Moratuwa
>

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
So...  Looking at this with a different perspective.  If there is a bug 
elsewhere which would cause an IP to be duplicated in the `dbag`, the old 
implementation would have cleaned up this bug and would have removed all the 
duplicates (including the real one) and then would have only added back the 
real one.  My implementation did not assume that I was having to clean up 
duplicates in the `dbag` variable and only focused on adding if it didn't exist 
or updating the existing entry if it did exist.  I will have to think about 
this more...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] - StorageHA

[Rafael Weingärtner]

Jeromy I already experienced a similar problem. A host had a problem of
connectivity with a storage, ACS did not know (I think it does check this
right now) and it was kind of odd. Because some VMs could not be started,
because of their last host id was the host with the connectivity problem.

I believe it would be a great thing to improve these checks and to treat
this type of problem in ACS.

My two cents:
Change the name of what you are proposing. It is not high availability per
se; it is more like a storage health check/heartbeat thing. It may give
people very high expectations (I am not trying to undermine the work that
is required). For instance, the first time I read your email, I thought
about real HA, with some sort of block replication and redundancy in the
storage system. That means, I was expecting if a whole storage goes down,
ACS would have to have a way of solving this problem without losing data
and without interrupting VMs. What you want to do is a little different, if
a host has some connectivity problem, we simply add it to the avoid list,
and then we migrate/move the VMs that were running there to a healthy host.

About the idea of being for KVM only; even though we might not be able to
run scripts on some hypervisors (Dom0 not being exposed), we could use
their API and check if the storage is responding. For instance, in XenServr
you could call “xe sr-scan uuid=” (or maybe other command
that uses storage), if there is any communication problem, it will report
an error. The same type of feature will probably be available on all other
hypervisors.

On Tue, Mar 14, 2017 at 1:46 PM, Jeromy Grimmett 
wrote:

> If all networking is lost, then obviously there is a bigger problem
> there.  The monitor is designed to do a true read/write test to the storage
> and report back a pass/fail.  Through this discussion, there was a ping
> suggestion, which I think we will include.
>
> The way this came about was that one of our hosts had a problem with a
> single primary storage, but all other hosts were 100% good across that
> storage and all others.  That troubled host was having problems with just
> the single storage device, but according to CloudStack, all was well and
> everything was good.  The way I am looking at this, is that what we are
> attempting to do is a much better and far more accurate test of storage
> availability compared to how Cloudstack currently does it based our
> experience.
>
> Make more sense?
>
> j
>
> Jeromy Grimmett
> P: 603.766.3625
> jer...@cloudbrix.com
> www.cloudbrix.com
>
>
> -Original Message-
> From: Simon Weller [mailto:swel...@ena.com]
> Sent: Tuesday, March 14, 2017 10:01 AM
> To: dev@cloudstack.apache.org
> Cc: Alex Bonilla 
> Subject: Re: [Proposal] - StorageHA
>
> So a few questions come to mind here.
>
>
> So if all networking is lost, how are you going to being able reliably
> fence the VM on the hosts?
>
> Are you assuming you still have out of band IPMI connectivity?
>
> If you're running bonded interfaces to different switches, what scenario
> would occur where the host loses network connectivity?
>
>
> - Si
>
> 
> From: Tutkowski, Mike 
> Sent: Tuesday, March 14, 2017 8:25 AM
> To: dev@cloudstack.apache.org
> Cc: Alex Bonilla
> Subject: Re: [Proposal] - StorageHA
>
> Thanks for your clarification. I see now. You were referring to a
> networking problem where one host could not see the storage (but the
> storage was still up and running).
>
> On 3/13/17, 10:31 PM, "Jeromy Grimmett"  wrote:
>
> I apologize for the delay on the response, let me clarify the points
> requested:
>
> Mike asked:
>
> "What I was curious about is if you plan to exclusively build your
> feature as a set of scripts and/or if you plan to update the CloudStack
> code base, as well."
>
> JG:  My idea was to do this separately as a plugin, then add it to the
> code base down the road.
>
> "Also, if a primary storage actually goes offline, I'm not clear on
> how starting an impacted VM on a different compute host would help. Could
> you clarify this for me?"
>
> JG:  The VM would be started on another host that still has access to
> the storage.  Individually a host can have problems and lose its
> connectivity to a primary storage device.  The solution we are working on
> would help to get the VM back and up running much faster than waiting for
> Cloudstack to make a decision to restart the VM on a different host.
>
> Paul asked:
>
> "  1.  We can't/don't run scripts on vSphere hosts (not sure about
> Hyper-V)"
>
> JG:  I should have been more clear, this is for KVM hosts.
>
> "2.  I know of one failure scenario (which happened) where MTU issues
> in intermediate switches meant that small amounts of data could pass, but
> anything that was passed as jumbo frames then failed. So it would be
> important to exercise 

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105998903
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

I think that `if` is needed to control the max query size. I agree with the 
example you provided, but let's say for example that lengthOfStIds is greater 
that batchSize. If we remove that `if`, we will load pools on lines 100-112 but 
with a query size greater that batchSize (defined in line 111)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
This `ips.json` file confuses the hell out of me.  From what I can tell 
both `eth2` and `eth3` both have the ip `10.1.35.83` twice for each (for a 
total of the IP being configured 4 times over two interfaces).

How was this IP configured?  

```
"eth2": [
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth2",
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"nic_dev_id": "2",
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": false
},
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth2",
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"nic_dev_id": "2",
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": false
}
],
"eth3": [
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth3",
"first_i_p": true,
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"new_nic": true,
"nic_dev_id": 3,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": true,
"vif_mac_address": "06:ee:46:00:00:03"
},
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth3",
"first_i_p": true,
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"new_nic": true,
"nic_dev_id": 3,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": true,
"vif_mac_address": "06:a4:80:00:00:03"
}
],
```

I will see if I can get to the bottom of this, but this is pretty 
confusing.  Do you have a sequence of events which produced this configuration? 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: midonet-client and Guava dependency conflict

[Rafael Weingärtner]

So, should we move to other thread to discuss and vote its removal or
disable its plugin build?

On Tue, Mar 14, 2017 at 10:49 AM, Daan Hoogland  wrote:

> Well, if Midokura is not willing to put in effort, ... Not sure what to
> put on the dots.
>
> On 14/03/17 15:08, "Simon Weller"  wrote:
>
> We took a look at testing it in the lab back in early 2016  and
> Midokura told us that it was a bad idea, probably wouldn't work and we
> should just switch to openstack.
>
>
> - Si
>
> 
> From: Erik Weber 
> Sent: Tuesday, March 14, 2017 3:28 AM
> To: dev
> Subject: Re: midonet-client and Guava dependency conflict
>
> On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
>  wrote:
> > I got a reply from Midonet community; they said that midonet-client
> was
> > incorporated by midonet-cluster (
> > https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster
> ).
> [https://avatars2.githubusercontent.com/u/9136532?v=3=400] github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster>
>
> midonet/midonet tree/staging/v5.4/midonet-cluster>
> github.com
> midonet - MidoNet is an Open Source network virtualization system for
> Openstack clouds
>
>
>
> >
> >
> > So, if anyone wants to invest energy on this, it might be a good
> idea to
> > upgrade the dependency. Moreover, I start to question the
> compatibility of
> > the current client we are using, with the mido-net server side that
> might
> > be deployed by users. Will this partial integration that we have
> work?
>
>
> Just as important to ask: "Has it ever worked?"
> Do we know anyone who use, or have used, this integration?
>
> --
> Erik
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105993059
  
--- Diff: 
engine/schema/test/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImplTest.java
 ---
@@ -0,0 +1,151 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.storage.datastore.db;
+
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import 
org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDaoImpl.ValueType;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.storage.ScopeType;
+import com.cloud.storage.dao.StoragePoolHostDao;
+import com.cloud.storage.dao.StoragePoolTagsDao;
+
+import junit.framework.TestCase;
+
+@RunWith(PowerMockRunner.class)
+public class PrimaryDataStoreDaoImplTest extends TestCase {
+
+@Mock
+StoragePoolDetailsDao _detailsDao;
+@Mock
+StoragePoolHostDao _hostDao;
+@Mock
+StoragePoolTagsDao _tagsDao;
+
+@Spy
+@InjectMocks
+private static PrimaryDataStoreDaoImpl primaryDataStoreDao = new 
PrimaryDataStoreDaoImpl();
+
+@Mock
+static StoragePoolVO storagePoolVO;
--- End diff --

Here you have other static variable in a test case that does not need to be 
static.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105992559
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

Correct me if I am wrong, but this `if` is not needed.
Let's assume the configuration:
```
batchSize=2000
current_index=0
lengthOfStIds=100
```

`curr_index + detailsBatchSize = 0 + 2000`, which is not less than the size 
of the array `(100)`. Therefore, the while is not executed. Then, the pools 
will be loaded at lines 100-112



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105992671
  
--- Diff: 
engine/schema/test/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.storage.dao;
+
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.storage.StoragePoolTagVO;
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import junit.framework.TestCase;
+
+@RunWith(PowerMockRunner.class)
+public class StoragePoolTagsDaoImplTest extends TestCase {
+
+@Mock
+ConfigurationDao _configDao;
+@Mock
+SearchBuilder StoragePoolIdsSearch;
+
+@Spy
+@InjectMocks
+private StoragePoolTagsDaoImpl _storagePoolTagsDaoImpl = new 
StoragePoolTagsDaoImpl();
+
+@Mock
+static StoragePoolTagVO storagePoolTag1;
--- End diff --

Not really, thinking about it there's no why to make them static, I removed 
static declaration from them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105990460
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+searchForStoragePoolIdsInternal(curr_index, 
detailsBatchSize, stIds, uvList);
+curr_index += detailsBatchSize;
+}
+}
+
+if (curr_index < stIds.length) {
+int batch_size = (stIds.length - curr_index);
+searchForStoragePoolIdsInternal(curr_index, batch_size, stIds, 
uvList);
+}
+
+return uvList;
+}
+
+/**
+ * Search storage pools
+ * @param currIndex current index
+ * @param batchSize batch size
+ * @param stIds storage tags array
+ * @param uvList
+ */
+protected void searchForStoragePoolIdsInternal(int currIndex, int 
batchSize, Long[] stIds, List uvList) {
+Long[] ids = new Long[batchSize];
+for (int k = 0, j = currIndex; j < currIndex + batchSize; j++, 
k++) {
+ids[k] = stIds[j];
+}
+SearchCriteria sc = 
StoragePoolIdsSearch.create();
+sc.setParameters("idIN", (Object[])ids);
+List vms = searchIncludingRemoved(sc, null, 
null, false);
+if (vms != null) {
+uvList.addAll(vms);
+}
+}
+
+/**
+ * Retrieve {@code detail.batch.query.size} configuration value. If 
not available, return the default value (2000)
+ * @return detail.batch.query.size configuration value
+ */
+protected int getDetailsBatchSize() {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+return batchCfg != null ? Integer.parseInt(batchCfg) : 2000;
--- End diff --

Done, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105989477
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+searchForStoragePoolIdsInternal(curr_index, 
detailsBatchSize, stIds, uvList);
+curr_index += detailsBatchSize;
+}
+}
+
+if (curr_index < stIds.length) {
+int batch_size = (stIds.length - curr_index);
+searchForStoragePoolIdsInternal(curr_index, batch_size, stIds, 
uvList);
+}
+
+return uvList;
+}
+
+/**
+ * Search storage pools
+ * @param currIndex current index
+ * @param batchSize batch size
+ * @param stIds storage tags array
+ * @param uvList
+ */
+protected void searchForStoragePoolIdsInternal(int currIndex, int 
batchSize, Long[] stIds, List uvList) {
--- End diff --

Excellent improvement, I copied almost exactly as you wrote it :) I also 
added some description on `uvList` parameter, which also renamed to `pools`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov I have a suspicion that the ip_association.json is a 
transient file which may be short lived. I am not sure because I have not seen 
it either, but it was the file being processed when you had your original 
error. 

I will review your ips.json and see what I can find. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@ustcweizhou no VPC


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill thanks, I found the ips.json, but I couldn't find the  
ip_association.json on the VR. I guess it's not processed yet. Can you advise 
how to force it to generate? Hope this helps. 
[ips.txt](https://github.com/apache/cloudstack/files/842199/ips.txt)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [Proposal] - StorageHA

[Jeromy Grimmett]

If all networking is lost, then obviously there is a bigger problem there.  The 
monitor is designed to do a true read/write test to the storage and report back 
a pass/fail.  Through this discussion, there was a ping suggestion, which I 
think we will include.  

The way this came about was that one of our hosts had a problem with a single 
primary storage, but all other hosts were 100% good across that storage and all 
others.  That troubled host was having problems with just the single storage 
device, but according to CloudStack, all was well and everything was good.  The 
way I am looking at this, is that what we are attempting to do is a much better 
and far more accurate test of storage availability compared to how Cloudstack 
currently does it based our experience.

Make more sense?

j

Jeromy Grimmett
P: 603.766.3625
jer...@cloudbrix.com
www.cloudbrix.com


-Original Message-
From: Simon Weller [mailto:swel...@ena.com] 
Sent: Tuesday, March 14, 2017 10:01 AM
To: dev@cloudstack.apache.org
Cc: Alex Bonilla 
Subject: Re: [Proposal] - StorageHA

So a few questions come to mind here.


So if all networking is lost, how are you going to being able reliably fence 
the VM on the hosts?

Are you assuming you still have out of band IPMI connectivity?

If you're running bonded interfaces to different switches, what scenario would 
occur where the host loses network connectivity?


- Si


From: Tutkowski, Mike 
Sent: Tuesday, March 14, 2017 8:25 AM
To: dev@cloudstack.apache.org
Cc: Alex Bonilla
Subject: Re: [Proposal] - StorageHA

Thanks for your clarification. I see now. You were referring to a networking 
problem where one host could not see the storage (but the storage was still up 
and running).

On 3/13/17, 10:31 PM, "Jeromy Grimmett"  wrote:

I apologize for the delay on the response, let me clarify the points 
requested:

Mike asked:

"What I was curious about is if you plan to exclusively build your feature 
as a set of scripts and/or if you plan to update the CloudStack code base, as 
well."

JG:  My idea was to do this separately as a plugin, then add it to the code 
base down the road.

"Also, if a primary storage actually goes offline, I'm not clear on how 
starting an impacted VM on a different compute host would help. Could you 
clarify this for me?"

JG:  The VM would be started on another host that still has access to the 
storage.  Individually a host can have problems and lose its connectivity to a 
primary storage device.  The solution we are working on would help to get the 
VM back and up running much faster than waiting for Cloudstack to make a 
decision to restart the VM on a different host.

Paul asked:

"  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)"

JG:  I should have been more clear, this is for KVM hosts.

"2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that."

JG:  I have faced this Jumbo Frame issue as well, perhaps we need to have 
an option that would indicate Jumbo Frames are being used to access that 
storage and the test result would reflect a failure to access using Jumbo 
Frames.

"3.  You need to be very sure of failures before shutting hosts down.  Also 
a host is likely to be connected to multiple storage pools, so you wouldn't 
want to shut down a host due to one pool becoming unavailable."

JG:  The script wouldn't shut down any hosts at all.  Just force stop the 
affected VMs on that specific host and then start them on a host that is not 
having the issue with storage.

"4.  Environments can have hundreds of storage pools, so watch out for 
spamming the logs with updates."

JG:  The polling/testing time increments are configurable, so I am hoping 
that can help with that.  The results are pretty small and should be relatively 
negligible.

"5.  The primary storage pools have a 'state' which should get updated and 
used by the deployment planners"

JG:  I have copied Alex on this email to make sure he sees this suggestion. 
 We will figure out how to incorporate that 'state' field.

"6.  Secondary storage pools don't have a 'state' - but it would be great 
if that were added in the DB and reflected in the UI."

JG:  For now, I think this might be a feature request that maybe we should 
submit through the normal Cloudstack request process.  Otherwise, we can 
definitely include that into our work when we start to add it into the code 
base.

To take this a step further, we are also working on a KVM host load 
balancer that will be used as a factor when moving the VMs.  We have a number 
of little projects we are working on.

Thank you all for reviewing the 

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@sureshanaparti I pulled the latest code and repeated the first test 
scenario, got the same failure: `Message: The setting of vmConfig is invalid 
for cluster CLD100.`. I attach the full [management server 
logs](https://github.com/apache/cloudstack/files/842198/startVR-HA-on.zip)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1760
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 466
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_03_RVR_Network_check_router_state Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105959436
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+searchForStoragePoolIdsInternal(curr_index, 
detailsBatchSize, stIds, uvList);
+curr_index += detailsBatchSize;
+}
+}
+
+if (curr_index < stIds.length) {
+int batch_size = (stIds.length - curr_index);
+searchForStoragePoolIdsInternal(curr_index, batch_size, stIds, 
uvList);
+}
+
+return uvList;
+}
+
+/**
+ * Search storage pools
+ * @param currIndex current index
+ * @param batchSize batch size
+ * @param stIds storage tags array
+ * @param uvList
+ */
+protected void searchForStoragePoolIdsInternal(int currIndex, int 
batchSize, Long[] stIds, List uvList) {
--- End diff --

What about improving this java doc here?
Something like:

>  Search for storage pools based on their IDs. The search is executed in 
batch, this means that we will load a batch of size #getDetailsBatchSize  
@link{StoragePoolTagVO} at each time. The loaded storage pools are added in the 
uvList parameter.

The links to classes, methods and parameters in the Java doc would have to 
be fixed (I wrote it without using the IDE and I did not know the proper markup)

What do you think about the "@param" notation? I normally prefer not to use 
them if the onyl thing I will write is the parameter name such as `@param 
uvList`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105959564
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+searchForStoragePoolIdsInternal(curr_index, 
detailsBatchSize, stIds, uvList);
+curr_index += detailsBatchSize;
+}
+}
+
+if (curr_index < stIds.length) {
+int batch_size = (stIds.length - curr_index);
+searchForStoragePoolIdsInternal(curr_index, batch_size, stIds, 
uvList);
+}
+
+return uvList;
+}
+
+/**
+ * Search storage pools
+ * @param currIndex current index
+ * @param batchSize batch size
+ * @param stIds storage tags array
+ * @param uvList
+ */
+protected void searchForStoragePoolIdsInternal(int currIndex, int 
batchSize, Long[] stIds, List uvList) {
+Long[] ids = new Long[batchSize];
+for (int k = 0, j = currIndex; j < currIndex + batchSize; j++, 
k++) {
+ids[k] = stIds[j];
+}
+SearchCriteria sc = 
StoragePoolIdsSearch.create();
+sc.setParameters("idIN", (Object[])ids);
+List vms = searchIncludingRemoved(sc, null, 
null, false);
+if (vms != null) {
+uvList.addAll(vms);
+}
+}
+
+/**
+ * Retrieve {@code detail.batch.query.size} configuration value. If 
not available, return the default value (2000)
+ * @return detail.batch.query.size configuration value
+ */
+protected int getDetailsBatchSize() {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+return batchCfg != null ? Integer.parseInt(batchCfg) : 2000;
--- End diff --

What about extracting the `2000` to a constant in the class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105959827
  
--- Diff: 
engine/schema/test/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.storage.dao;
+
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.storage.StoragePoolTagVO;
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import junit.framework.TestCase;
+
+@RunWith(PowerMockRunner.class)
+public class StoragePoolTagsDaoImplTest extends TestCase {
+
+@Mock
+ConfigurationDao _configDao;
+@Mock
+SearchBuilder StoragePoolIdsSearch;
+
+@Spy
+@InjectMocks
+private StoragePoolTagsDaoImpl _storagePoolTagsDaoImpl = new 
StoragePoolTagsDaoImpl();
+
+@Mock
+static StoragePoolTagVO storagePoolTag1;
--- End diff --

I am curious here, is there any reason to declare the variables here 
`static`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105952120
  
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long 
dataCenterId, Long podId, Long c
 // set up a new alert
 AlertVO newAlert = new AlertVO();
 newAlert.setType(alertType.getType());
-newAlert.setSubject(subject);
+//do not have a seperate column for content.
+//appending the message to the subject for now.
+newAlert.setSubject(subject+content);
--- End diff --

I understand that 999 characters may seem a lot, but the `content` may 
contain some long strings. for instance, in 
`com.cloud.network.router.VirtualNetworkApplianceManagerImpl.RvRStatusUpdateTask.checkDuplicateMaster(List)`,
 it is generated a `subject` and a `content` that together (depending on 
variable combinations used to create those strings) can go over 500 chars.

What concerns me the most are methods such as 
`org.apache.cloudstack.storage.image.BaseImageStoreDriverImpl.createVolumeAsyncCallback(AsyncCallbackDispatcher, 
CreateContext)`, where the `subject` and `content` would be 
the same, and they are created using an error message that may come from the 
most different places.

The use of `com.cloud.alert.AlertManagerImpl.sendAlert(AlertType, long, 
Long, String, String)` is quite broad and it would be a lot of work to check 
every single place it is used. For me, the code that you are adding at line 772 
seem like a half-measure that is bug prone. I would like to hear the feedback 
from others on this topic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov we are still trying to understand how the IP was found when 
looping through the `dbag` but it is not associated with the expected dev when 
we try to update the index which it was found on.  The only way I can see this 
could happen is if the dev requested it be configured on is different from the 
dev it is actually configured on.  I still have not figured out how that case 
exists.

@ustcweizhou has some good ideas on this front, but I don't think we have 
gotten to a point where we understand how this problem is happening.

@borisstoyanov is there a chance you can post the `ips.json` and 
`ip_association.json` files in your environment so we can start to understand 
what the config is that is causing this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
systemvm template is now updated to 4.10 
http://download.cloudstack.org/systemvm/4.10/ with pr #1982 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105942978
  
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
 
 public void pullAgentOutMaintenance(long hostId);
 
-boolean reconnect(long hostId);
+void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

@bvbharatk I got your intentions here. However, don’t you think we can 
work out the places where people are login runtime exceptions, instead of 
bubbling them up? I believe that instead of creating constraints in the code, 
we should spot when people are introducing these things, and educate them. For 
the code that is already doing the things you mentioned, well, we can work to 
fix them bit by bit. 

It feels a little unusual (at least for me) to declare runtime exceptions. 
At the end of the day, you may make it more visible, but just because you 
declare a runtime exception, it does not mean people will be forced to catch it 
(they will not be forced to catch it).

BTW: I never had a good expression to talk about the re-throw of 
exceptions. Thanks for the “bubble exception up”.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Contrail Plugin Emitting Extra Action Events?

[Jeff Hair]

Hi,

In my continuing quest to merge 4.9.2.0 into our fork, I'm noticing that
the Juniper Contrail plugin has an "EventUtils" class which looks for
methods with @ActionEvent on them and them emits over the event bus. This
does the same thing as the more-standard ActionEventUtils class. Is there a
reason for the Contrail plugin to have its own EventUtils class?

Jeff

Re: midonet-client and Guava dependency conflict

[Daan Hoogland]

Well, if Midokura is not willing to put in effort, ... Not sure what to put on 
the dots.

On 14/03/17 15:08, "Simon Weller"  wrote:

We took a look at testing it in the lab back in early 2016  and Midokura 
told us that it was a bad idea, probably wouldn't work and we should just 
switch to openstack.


- Si


From: Erik Weber 
Sent: Tuesday, March 14, 2017 3:28 AM
To: dev
Subject: Re: midonet-client and Guava dependency conflict

On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
 wrote:
> I got a reply from Midonet community; they said that midonet-client was
> incorporated by midonet-cluster (
> https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster).

[https://avatars2.githubusercontent.com/u/9136532?v=3=400]


midonet/midonet
github.com
midonet - MidoNet is an Open Source network virtualization system for 
Openstack clouds



>
>
> So, if anyone wants to invest energy on this, it might be a good idea to
> upgrade the dependency. Moreover, I start to question the compatibility of
> the current client we are using, with the mido-net server side that might
> be deployed by users. Will this partial integration that we have work?


Just as important to ask: "Has it ever worked?"
Do we know anyone who use, or have used, this integration?

--
Erik



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

Re: midonet-client and Guava dependency conflict

[Rafael Weingärtner]

Hmm, it seems that there are people who would like to use it in ACS.
However, by Simon`s email, the vendor does not seem to care much.

I am inclined to adopt one of Daan`s email previously:

If we have to lay a burdon of fixing before release on people that
> don't use it, I would say no. You use it, you maintain it. I am happy
> to charge money to whoever wants to not maintain what they use.
>


Having said this, what do you guys think about removing this plugin from
ACS? Then, we remove from our documentation the “MidoNet support”.
Nowadays, I think we may bring expectation for people that may want to use
it, and at the end of the day, ACS will not deliver it.

Despite some people showing interest, this plugin does not work unless
someone puts quite some effort into it.

On Tue, Mar 14, 2017 at 10:08 AM, Simon Weller  wrote:

> We took a look at testing it in the lab back in early 2016  and Midokura
> told us that it was a bad idea, probably wouldn't work and we should just
> switch to openstack.
>
>
> - Si
>
> 
> From: Erik Weber 
> Sent: Tuesday, March 14, 2017 3:28 AM
> To: dev
> Subject: Re: midonet-client and Guava dependency conflict
>
> On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
>  wrote:
> > I got a reply from Midonet community; they said that midonet-client was
> > incorporated by midonet-cluster (
> > https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster).
> [https://avatars2.githubusercontent.com/u/9136532?v=3=400] github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster>
>
> midonet/midonet tree/staging/v5.4/midonet-cluster>
> github.com
> midonet - MidoNet is an Open Source network virtualization system for
> Openstack clouds
>
>
>
> >
> >
> > So, if anyone wants to invest energy on this, it might be a good idea to
> > upgrade the dependency. Moreover, I start to question the compatibility
> of
> > the current client we are using, with the mido-net server side that might
> > be deployed by users. Will this partial integration that we have work?
>
>
> Just as important to ask: "Has it ever worked?"
> Do we know anyone who use, or have used, this integration?
>
> --
> Erik
>



-- 
Rafael Weingärtner

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[serg38]

Github user serg38 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r105932339
  
--- Diff: test/integration/smoke/test_deploy_vm_root_resize.py ---
@@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self):
 # 2. root disk has new size per listVolumes
 # 3. Rejects non-supported hypervisor types
 """
-if(self.hypervisor.lower() == 'kvm'):
+full_clone_config = Configurations.list(self.apiclient,
+name="vmware.create.full.clone")[0].value
+if full_clone_config == 'false' and self.hypervisor.lower() == 
'vmware':
+self.skipTest("root disk resize is not supported "+
+"when vmware.create.full.clone is %s" % full_clone_config)
+
--- End diff --

@priyankparihar @cloudsadhu test_rootvolume_resize.py test looks good. Can 
we add exactly the same logic of adding full clone config for smoke test 
test_deploy_vm_root_resize.py so that it is not skipped if a global setting is 
to use link clones?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@jayakarteek from what I understood so far, there will always be a mismatch.

For instance, the way it is implemented so far, if a VM uses a service 
offering that provides 1000 MHz; and if CPU cap is not used, it (the VM) can 
use up to the real CPU of the host. If real CPU on the host is 2000 MHz, then 
it would show 200% of usage. Unless we want this behavior, the use of 
CPUCounter seems a better approach to avoid having an inconsistent POJO in the 
code. You said it might not be ideal because the CPUCounter (per its 
documentation) does not seem to consider the amount of virtual CPU allocated in 
MHz while calculating usage, right?

I just started this discussion because of the POJO that has an attribute 
that sometimes is set using percentage values and some other as continuous 
values. My goal was to highlight this and maybe discuss some solution.

I was reading the documentation link you sent, what are the differences 
between “cpuentitlement” and “reservedCapacity”; I mean, I can read the 
description of the parameters 

>  cpuentitlement is computed based on an ideal scenario in which all 
virtual machines are completely busy and the load is perfectly balanced across 
all hosts

but the description for me seems different from what I can understand from 
"entitlement" when I read "CPU entitlement" I think of CPU power that the CPU 
is entitled and may not be using or getting for one or other reason. However, 
the description may sound like something else (this value being based on the 
load of hosts/clusters). 

 Would not one of these two configurations have the CPU in MHz allocated 
for the VM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov are you using vpc ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill we're using one IP range for the physical guest public network. I 
think we could set this up if required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
On the Jira ticket, Wei Zhou mentioned that this could potentially happen 
if you have two different public IP ranges.  So if you associate a public IP 
which is in a different range than the source nat, a new nic will be created.  
If you disassociate it, that nic will be removed.

I guess my question is.  Why is it not on the`dbag`variable then associated 
with that dev?  I think Wei is probably right in terms of context, but I am not 
sure how exactly to solve this yet.

@borisstoyanov can you confirm that you have two different public IP ranges 
in your setup?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: midonet-client and Guava dependency conflict

[Simon Weller]

We took a look at testing it in the lab back in early 2016  and Midokura told 
us that it was a bad idea, probably wouldn't work and we should just switch to 
openstack.


- Si


From: Erik Weber 
Sent: Tuesday, March 14, 2017 3:28 AM
To: dev
Subject: Re: midonet-client and Guava dependency conflict

On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
 wrote:
> I got a reply from Midonet community; they said that midonet-client was
> incorporated by midonet-cluster (
> https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster).
[https://avatars2.githubusercontent.com/u/9136532?v=3=400]

midonet/midonet
github.com
midonet - MidoNet is an Open Source network virtualization system for Openstack 
clouds



>
>
> So, if anyone wants to invest energy on this, it might be a good idea to
> upgrade the dependency. Moreover, I start to question the compatibility of
> the current client we are using, with the mido-net server side that might
> be deployed by users. Will this partial integration that we have work?


Just as important to ask: "Has it ever worked?"
Do we know anyone who use, or have used, this integration?

--
Erik

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
I have to admit, I am not sure how the IP was found when looping through 
the list initially, but then when trying to update the index for the IP that 
was found, it is not there.  The only way I can think of that would cause this 
is if the IP <-> dev mapping is broken somehow.  It found the matching IP, but 
apparently that IP is not on the dev defined by the `nic_dev_id` (which comes 
from either: `nic_dev_id = address['nic_dev_id']` (from the databag), which can 
then be overridden by `nic_dev_id = ip['nic_dev_id']` (from the passed in IP) ).

Yes, I think you are right that the `else` case does not work right now.  
This is because we are appending the IP to this dev, but we never removed it 
from the other dev it was apparently found in.  This logic is SUPPOSED to find 
the existing IP's index and then if found, update that index with the updated 
info.  

The old logic which just removed all "found" IPs and then re-added them, 
did not preserve the order, so the source nat IP could get reconfigured as a 
secondary IP on a nic instead of it being primary.  This reordering of the IPs 
on VR reboot caused the VPN to fail because the source nat IP was no longer the 
primary IP.  

So we know that removing all found IPs and then adding them does not work 
because it changes the order of the IPs causing the source nat IP to become a 
secondary IP on the nic.

The error described in CLOUDSTACK-9811 seems to be a situation where the IP 
is found on one nic, but then for some reason the dev which the IP is 
associated with is changed (I don't know why this would be happening), causing 
the index where the IP was found to not be valid because the IP is actually on 
a different dev.  

To know how to fix this correctly, we need to understand why/how an IP can 
be associated with one dev (index found) and then get changed to be associated 
with a different dev.

We need to find a way to preserve IP order while being able to update the 
IP configurations.

@remibergsma do you have any ideas on this?  Anyone else have ideas here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] - StorageHA

[Simon Weller]

So a few questions come to mind here.


So if all networking is lost, how are you going to being able reliably fence 
the VM on the hosts?

Are you assuming you still have out of band IPMI connectivity?

If you're running bonded interfaces to different switches, what scenario would 
occur where the host loses network connectivity?


- Si


From: Tutkowski, Mike 
Sent: Tuesday, March 14, 2017 8:25 AM
To: dev@cloudstack.apache.org
Cc: Alex Bonilla
Subject: Re: [Proposal] - StorageHA

Thanks for your clarification. I see now. You were referring to a networking 
problem where one host could not see the storage (but the storage was still up 
and running).

On 3/13/17, 10:31 PM, "Jeromy Grimmett"  wrote:

I apologize for the delay on the response, let me clarify the points 
requested:

Mike asked:

"What I was curious about is if you plan to exclusively build your feature 
as a set of scripts and/or if you plan to update the CloudStack code base, as 
well."

JG:  My idea was to do this separately as a plugin, then add it to the code 
base down the road.

"Also, if a primary storage actually goes offline, I'm not clear on how 
starting an impacted VM on a different compute host would help. Could you 
clarify this for me?"

JG:  The VM would be started on another host that still has access to the 
storage.  Individually a host can have problems and lose its connectivity to a 
primary storage device.  The solution we are working on would help to get the 
VM back and up running much faster than waiting for Cloudstack to make a 
decision to restart the VM on a different host.

Paul asked:

"  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)"

JG:  I should have been more clear, this is for KVM hosts.

"2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that."

JG:  I have faced this Jumbo Frame issue as well, perhaps we need to have 
an option that would indicate Jumbo Frames are being used to access that 
storage and the test result would reflect a failure to access using Jumbo 
Frames.

"3.  You need to be very sure of failures before shutting hosts down.  Also 
a host is likely to be connected to multiple storage pools, so you wouldn't 
want to shut down a host due to one pool becoming unavailable."

JG:  The script wouldn’t shut down any hosts at all.  Just force stop the 
affected VMs on that specific host and then start them on a host that is not 
having the issue with storage.

"4.  Environments can have hundreds of storage pools, so watch out for 
spamming the logs with updates."

JG:  The polling/testing time increments are configurable, so I am hoping 
that can help with that.  The results are pretty small and should be relatively 
negligible.

"5.  The primary storage pools have a 'state' which should get updated and 
used by the deployment planners"

JG:  I have copied Alex on this email to make sure he sees this suggestion. 
 We will figure out how to incorporate that 'state' field.

"6.  Secondary storage pools don't have a 'state' - but it would be great 
if that were added in the DB and reflected in the UI."

JG:  For now, I think this might be a feature request that maybe we should 
submit through the normal Cloudstack request process.  Otherwise, we can 
definitely include that into our work when we start to add it into the code 
base.

To take this a step further, we are also working on a KVM host load 
balancer that will be used as a factor when moving the VMs.  We have a number 
of little projects we are working on.

Thank you all for reviewing the information.  All suggestions are welcome.

Jeromy Grimmett
P: 603.766.3625
jer...@cloudbrix.com
www.cloudbrix.com


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: Saturday, March 11, 2017 2:43 AM
To: dev@cloudstack.apache.org
Subject: RE: [Proposal] - StorageHA

Hi Jeromy,

I love the idea, I'm not really a developer, so those guys will look at 
things a different way, but...

These would be by my initial comments:


  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)
  2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that.
  3.  You need to be very sure of failures before shutting hosts down.  
Also a host is likely to be connected to multiple storage pools, so you 
wouldn't want to shut down a host due to one pool becoming unavailable.
  4.  

Re: Reg : Edit Access

[Daan Hoogland]

Sharad Nandwani, please send a mail to dev-unsubscr...@cloudstack.apache.org

From the page https://cloudstack.apache.org/mailing-lists.html :

“To leave the dev mailing list email dev-unsubscr...@cloudstack.apache.org.”

On 14/03/17 14:51, "Sharad Nandwani"  wrote:

How can I unsubscribe from the List. Please remove me from the list as I am 
not associated with the product.


Thanks



From: Pavan Kumar Aravapalli 
Sent: Tuesday, March 14, 2017 7:15 PM
To: dev@cloudstack.apache.org
Subject: Reg : Edit Access

Hi,


   I am unable to edit/add pages for the cwiki link 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.9+Design+Documents. 
Can some one help me in doing the same.
4.9 Design Documents - Apache Software 
Foundation
cwiki.apache.org
Powered by a free Atlassian Confluence Open Source Project License granted 
to Apache Software Foundation. Evaluate Confluence today. Powered by Atlassian 
Confluence 5 ...




  Cwiki username: pavan4smile



Thanks & Regards
Pavan Kumar Aravapalli.




daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

Re: Reg : Edit Access

[Sharad Nandwani]

How can I unsubscribe from the List. Please remove me from the list as I am not 
associated with the product.


Thanks



From: Pavan Kumar Aravapalli 
Sent: Tuesday, March 14, 2017 7:15 PM
To: dev@cloudstack.apache.org
Subject: Reg : Edit Access

Hi,


   I am unable to edit/add pages for the cwiki link 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.9+Design+Documents. 
Can some one help me in doing the same.
4.9 Design Documents - Apache Software 
Foundation
cwiki.apache.org
Powered by a free Atlassian Confluence Open Source Project License granted to 
Apache Software Foundation. Evaluate Confluence today. Powered by Atlassian 
Confluence 5 ...




  Cwiki username: pavan4smile



Thanks & Regards
Pavan Kumar Aravapalli.

Reg : Edit Access

[Pavan Kumar Aravapalli]

Hi,


   I am unable to edit/add pages for the cwiki link 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.9+Design+Documents. 
Can some one help me in doing the same.

  Cwiki username: pavan4smile



Thanks & Regards
Pavan Kumar Aravapalli.

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill what I mean is , if you do not want to change the logic, do you need 
to change 'else:' to 'elif index == -1:' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@ustcweizhou the `else` case did not change from the original code: 
https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L49

@karuturi I have updated the PR title and I updated the commit message to 
include the jira ticket.

@borisstoyanov do we have a run of these tests just against master recently 
to review the difference in output?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] - StorageHA

[Tutkowski, Mike]

Thanks for your clarification. I see now. You were referring to a networking 
problem where one host could not see the storage (but the storage was still up 
and running).

On 3/13/17, 10:31 PM, "Jeromy Grimmett"  wrote:

I apologize for the delay on the response, let me clarify the points 
requested:

Mike asked:

"What I was curious about is if you plan to exclusively build your feature 
as a set of scripts and/or if you plan to update the CloudStack code base, as 
well."

JG:  My idea was to do this separately as a plugin, then add it to the code 
base down the road.

"Also, if a primary storage actually goes offline, I'm not clear on how 
starting an impacted VM on a different compute host would help. Could you 
clarify this for me?"

JG:  The VM would be started on another host that still has access to the 
storage.  Individually a host can have problems and lose its connectivity to a 
primary storage device.  The solution we are working on would help to get the 
VM back and up running much faster than waiting for Cloudstack to make a 
decision to restart the VM on a different host.

Paul asked:

"  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)"

JG:  I should have been more clear, this is for KVM hosts.
  
"2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that."

JG:  I have faced this Jumbo Frame issue as well, perhaps we need to have 
an option that would indicate Jumbo Frames are being used to access that 
storage and the test result would reflect a failure to access using Jumbo 
Frames. 

"3.  You need to be very sure of failures before shutting hosts down.  Also 
a host is likely to be connected to multiple storage pools, so you wouldn't 
want to shut down a host due to one pool becoming unavailable."

JG:  The script wouldn’t shut down any hosts at all.  Just force stop the 
affected VMs on that specific host and then start them on a host that is not 
having the issue with storage.

"4.  Environments can have hundreds of storage pools, so watch out for 
spamming the logs with updates."

JG:  The polling/testing time increments are configurable, so I am hoping 
that can help with that.  The results are pretty small and should be relatively 
negligible.

"5.  The primary storage pools have a 'state' which should get updated and 
used by the deployment planners"

JG:  I have copied Alex on this email to make sure he sees this suggestion. 
 We will figure out how to incorporate that 'state' field.

"6.  Secondary storage pools don't have a 'state' - but it would be great 
if that were added in the DB and reflected in the UI."

JG:  For now, I think this might be a feature request that maybe we should 
submit through the normal Cloudstack request process.  Otherwise, we can 
definitely include that into our work when we start to add it into the code 
base.

To take this a step further, we are also working on a KVM host load 
balancer that will be used as a factor when moving the VMs.  We have a number 
of little projects we are working on.

Thank you all for reviewing the information.  All suggestions are welcome.

Jeromy Grimmett
P: 603.766.3625
jer...@cloudbrix.com
www.cloudbrix.com


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com] 
Sent: Saturday, March 11, 2017 2:43 AM
To: dev@cloudstack.apache.org
Subject: RE: [Proposal] - StorageHA

Hi Jeromy,

I love the idea, I'm not really a developer, so those guys will look at 
things a different way, but...

These would be by my initial comments:


  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)
  2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that.
  3.  You need to be very sure of failures before shutting hosts down.  
Also a host is likely to be connected to multiple storage pools, so you 
wouldn't want to shut down a host due to one pool becoming unavailable.
  4.  Environments can have hundreds of storage pools, so watch out for 
spamming the logs with updates.
  5.  The primary storage pools have a 'state' which should get updated and 
used by the deployment planners
  6.  Secondary storage pools don't have a 'state' - but it would be great 
if that were added in the DB and reflected in the UI.



Kind regards,

Paul Angus


paul.an...@shapeblue.com
www.shapeblue.com

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1988
  
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1988
  
@blueorangutan test centos7 kvm-centos7 
component/application_clusters/test_application_cluster_life_cycle.py,component/application_clusters/test_application_cluster_provisioning.py,component/application_clusters/test_provisioning_and_deployment.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@karuturi @wido @rhtyd @swill @pdion891 @rafaelweingartner 
I see the system VMs pointed to are still those in the 4.6 directory on the 
download servers. Is that really intended? I thought we now have 4.9 (because 
of strongswan).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
So this PR will be useless as is!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
Effectively we are due for an updated systemvm for strongswan + jdk8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

[jayakarteek]

Github user jayakarteek commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@rafaelweingartner 
we can retrieve the CPU speed of the host but the utilisation will have 
mismatch.
create VM with  Medium Instance having 1000 Mhz , and VM is utilising 
200Mhz of CPU then utilisation is 20%.
But if we consider host CPU capacity with  2400Mhz  then utilisation in 
8.3%.

@nvazquez 

I checked CPUCounter API doc, even in this case values will have some 
missmatch.
as per the below document with the usage formula they are using.

https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/cpu_counters.html




 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert ...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/837
  
Code changes LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105888712
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId, 
final Event event) throws A
 }
 return true;
 } else if (event == Event.ShutdownRequested) {
-return reconnect(hostId);
+//should throw a exception here as well.instead of eating this 
up.
+   try {
+   reconnect(hostId);
+   } catch (CloudRuntimeException e) {
--- End diff --

@bvbharatk Thanks for the clarification.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[sarathkouk]

Github user sarathkouk commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
[results.txt](https://github.com/apache/cloudstack/files/841130/results.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[sarathkouk]

Github user sarathkouk commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Here is the test result,
Test for checking automatic tag removal on released Public IP ... === 
TestName: test_25_CLOUDSTACK_9606| Status : SUCCESS ===
ok

--
Ran 1 test in 350.389s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105881592
  
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
 
 public void pullAgentOutMaintenance(long hostId);
 
-boolean reconnect(long hostId);
+void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

@rafaelweingartner 
What you said is correct in general. But in case of our code we can see 
places where we catch runtime exceptions and fail without giving out the actual 
reason. If we think the reason is of no use to the user, we should simply 
bubble them up and handle them accordingly in the top most calling method.  If 
we think the reason is not of importance to the user, we can simply log it and 
then send appropriate error messages.

In the current code i wanted to force people to bubble up the runtime 
exceptions as well and then take a call at the top most calling method. This 
way if something fails we do not see multiple exception messages one for each 
level at which the failure occurred and with different error messages leading 
to confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105881440
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
@@ -512,7 +512,11 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 });
 HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
 
-_agentMgr.reconnect(host.getId());
+try {
+_agentMgr.reconnect(host.getId());
+} catch (Exception e ) {
--- End diff --

Using a more specific catch makes sense, I will take this up in a separate 
PR. This was supposed to be a small improvement to the existing code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105881425
  
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long 
dataCenterId, Long podId, Long c
 // set up a new alert
 AlertVO newAlert = new AlertVO();
 newAlert.setType(alertType.getType());
-newAlert.setSubject(subject);
+//do not have a seperate column for content.
+//appending the message to the subject for now.
+newAlert.setSubject(subject+content);
--- End diff --

@rafaelweingartner 
I think we can live with this for now and take it up in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[bvbharatk]

Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105881247
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId, 
final Event event) throws A
 }
 return true;
 } else if (event == Event.ShutdownRequested) {
-return reconnect(hostId);
+//should throw a exception here as well.instead of eating this 
up.
+   try {
+   reconnect(hostId);
+   } catch (CloudRuntimeException e) {
--- End diff --

@sureshanaparti 
I agree with you, I have also added a comment in the code indicating the 
same. We can work on it in a different pr. This is just a small improvement to 
the existing code. Fixing this will need lot of rework and cause code churn. So 
the intention was to do this later in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Re: :[VOTE] Apache Cloudstack 4.10.0.0

[Rajani Karuturi]

lets get to the blockers first.

~Rajani
http://cloudplatform.accelerite.com/

On Tue, Mar 14, 2017 at 11:39 AM, Haijiao <18602198...@163.com> wrote:

> Hi, Karuturi
>
>
> These PRs below seems ready to be merged too.
>
>
> #1883, CLOUDSTACK-9723: Enable unique mac address across the zones
> #1886, CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response
> #1901, CLOUDSTACK-9405: add details parameter in listDomains API to reduce
> the execution time
> #1903, CLOUDSTACK-9356: FIX Cannot add users in VPC VPN
> #1955, CLOUDSTACK-8239 Add VirtIO SCSI support for KVM hosts
> #1956, CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerImpl.java
> #1993, CLOUDSTACK-8931: Fail to deploy VM instance when
> use.system.public.ips=false
> #1970, CLOUDSTACK-9725 Failed to update VPC Network during N/w offering
> Upgrade which doesnt have ACL service Enabled.
> #1978, CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM
> nic Ip x.x.x.x is mapped to load balancing rule
> #1957, CLOUDSTACK-9748:VPN Users search functionality broken
>
>
>
>
>
>
> 在2017年03月14 00时54分, "Rajani Karuturi"写道:
>
> 1866 - failed BVT results(may not be related. But, needs to be
> checked. Also, jenkins and travis failed)
>
> 1967 - no test results
>
> rest merged.
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On March 4, 2017 at 8:13 PM, Haijiao (18602198...@163.com
>

[GitHub] cloudstack issue #1761: CLOUDSTACK-9592 Empty responses from site to site co...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1761
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 465
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
Hi @DaanHoogland Are you planning to change the url to 
download.cloudstack.org?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2005: CLOUDSTACK-9450: Network Offering for VPC based on D...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/2005
  
PEP8 & PyFlakes compliance of our marvin test code:

CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$

Validations:

Marvin test results:

=> nosetests --with-marvin --marvin-config=nuage.cfg 
nuagevsp/test_nuage_static_nat.py

Test Nuage VSP Public IP Range creation and deletion ... === TestName: 
test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === 
TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS 
===
ok
Test Nuage VSP Isolated networks with different combinations of ... === 
TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static ... === 
TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by ... === 
TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS 
===
ok
Test Nuage VSP Static NAT functionality for VPC network by ... === 
TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress ... === 
TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by ... === 
TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS 
===
ok
Test Nuage VSP Static NAT functionality with VM migration by ... === 
TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by ... === 
TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS 
===
ok

--
Ran 10 tests in 10713.290s

OK

[results.txt](https://github.com/apache/cloudstack/files/840912/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/840911/runinfo.txt)

=> nosetests --with-marvin --marvin-config=nuage.cfg 
nuagevsp/test_nuage_source_nat.py

Test Nuage VSP Isolated networks with different combinations of ... === 
TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source ... === 
TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test
Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test
Test Nuage VSP Source NAT functionality with different Egress ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test
Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test
Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test
Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: 
Configured Nuage VSP SDN platform infrastructure does not support underlay 
networking: skipping test

--
Ran 8 tests in 1490.621s

OK (SKIP=6)

[results.txt](https://github.com/apache/cloudstack/files/840914/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/840915/runinfo.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2005: CLOUDSTACK-9450: Network Offering for VPC bas...

[prashanthvarma]

GitHub user prashanthvarma opened a pull request:

https://github.com/apache/cloudstack/pull/2005

CLOUDSTACK-9450: Network Offering for VPC based on DB flag

Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net

Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9398

Design Document: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+Offering+for+VPC+based+on+DB+flag

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nuagenetworks/cloudstack 
feature/nw_offering_for_vpc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2005






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2004: CLOUDSTACK-9832: Restrict addition of public IP NIC ...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/2004
  
PEP8 & PyFlakes compliance of our marvin test code:

CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$

Validations:

Marvin test results:

=>  nosetests --with-marvin --marvin-config=nuage.cfg 
nuagevsp/test_nuage_vpc_network.py

Test basic VPC Network functionality with Nuage VSP SDN plugin ... === 
TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test basic VPC Network functionality with Nuage VSP SDN plugin on ... SKIP: 
There is only one Zone configured: skipping test

--
Ran 2 tests in 274.059s

OK (SKIP=1)

[results.txt](https://github.com/apache/cloudstack/files/840864/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/840863/runinfo.txt)

=> nosetests --with-marvin --marvin-config=nuage.cfg 
nuagevsp/test_nuage_vsp.py

Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === 
TestName: test_nuage_vsp | Status : SUCCESS ===
ok
Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: 
test_nuage_vsp_device | Status : SUCCESS ===
ok

--
Ran 2 tests in 511.178s

OK

[results.txt](https://github.com/apache/cloudstack/files/840866/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/840867/runinfo.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2004: CLOUDSTACK-9832: Restrict addition of public ...

[prashanthvarma]

GitHub user prashanthvarma opened a pull request:

https://github.com/apache/cloudstack/pull/2004

CLOUDSTACK-9832: Restrict addition of public IP NIC to the VPC VR when the 
VPC offering does not contain VpcVirtualRouter as a SourceNat provider

Detail:
When the VPC offering does not contain VpcVirtualRouter as a SourceNat 
provider,
then we will not add the interface in the public network to the VpcVR. 
Thus, conserving Public IPs.

Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nuagenetworks/cloudstack 
feature/vr_without_public_ip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2004.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2004


commit adf889df566d7c68fdba51bc0046b9a71c7c1b3c
Author: Frank Maximus 
Date:   2015-11-18T14:05:58Z

CLOUDSTACK-9832: Restrict addition of public IP NIC to the VPC VR when the 
VPC offering does not contain VpcVirtualRouter as a SourceNat provider

Detail:
When the VPC offering does not contain VpcVirtualRouter as a SourceNat 
provider,
then we will not add the interface in the public network to the VpcVR. 
Thus, conserving Public IPs.

Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@priyankparihar thank you for adding this test. Have you run it? Since this 
is not part of the smoketestd can you provide any results. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov and @syed Please take a look. Test case is added. If now 
everything looks ok then please provide your LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[bvbharatk]

Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@ustcweizhou 
We are saving the password in the user_vm_details explicitly. We are not 
checking if ssh key pair is set for this vm or not.

I agree that ideally we should sync the password between the master and 
backup, For any kind of sync to work we need to know if the password was read 
from one of the VRs and In cases when one of the Vr is Stopped we will have to 
clear the password from db when it is read from the other one. These type of 
changes add complexity to the simple task of setting a password. The next best 
thing is to make sure we save the same password in both the routers. This will 
fix will at least solve the problem of sending the correct password even if the 
master and backup change state before the VM starts. 

Yes like you pointed out this will lead to the problem that the user might 
receive the old password when he stop starts the VM, In this case the user will 
get a notification in the UI that his password will be changed.  So he at least 
knows what the password is and so he can log into the VM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: midonet-client and Guava dependency conflict

[Erik Weber]

On Mon, Mar 13, 2017 at 7:45 PM, Rafael Weingärtner
 wrote:
> I got a reply from Midonet community; they said that midonet-client was
> incorporated by midonet-cluster (
> https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster).
>
>
> So, if anyone wants to invest energy on this, it might be a good idea to
> upgrade the dependency. Moreover, I start to question the compatibility of
> the current client we are using, with the mido-net server side that might
> be deployed by users. Will this partial integration that we have work?


Just as important to ask: "Has it ever worked?"
Do we know anyone who use, or have used, this integration?

-- 
Erik

Re: midonet-client and Guava dependency conflict

[Daan Hoogland]

It has ended in we are stuck with a to old gson implementation and Wido build a 
call based on a newer one.

On 10/03/17 02:01, "Will Stevens"  wrote:

I will review. Thanks for digging that up. Haha. You know every issue now
because of your cleanup. :)

On Mar 9, 2017 7:51 PM, "Rafael Weingärtner" 
wrote:

> https://issues.apache.org/jira/browse/CLOUDSTACK-8677
>
> On Thu, Mar 9, 2017 at 6:48 PM, Will Stevens 
> wrote:
>
> > I don't remember that conversation, but I will try to track it down.
> Thx...
> >
> > On Mar 9, 2017 6:39 PM, "Rafael Weingärtner" <
> rafaelweingart...@gmail.com>
> > wrote:
> >
> > > I recall a thread discussing some call home functionalities a long 
time
> > > ago; so, we could get some information about ACS usage. Does anyone
> know
> > > how that thread ended?
> > >
> > > The use o ACS plugin could be something trackable by a call home
> feature.
> > >
> > > On Thu, Mar 9, 2017 at 5:55 PM, Will Stevens 
> > > wrote:
> > >
> > > > We have had similar conversations many times recently.  
Unfortunately
> > we
> > > > have no way to track IF people are using different plugins, so it
> makes
> > > it
> > > > really hard to know if people will expect it to be there if they
> > > upgrade...
> > > >
> > > > If anyone has ideas for how we can potentially find a way to track
> > that,
> > > we
> > > > should probably start a thread around that.
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > 
> > > >
> > > > On Thu, Mar 9, 2017 at 2:36 PM, Rafael Weingärtner <
> > > > rafaelweingart...@gmail.com> wrote:
> > > >
> > > > > Agree with you, but I think a nice talk with people using it to 
ask
> > for
> > > > > help might be a good idea.
> > > > >
> > > > > Sometimes they are not aware of these situations.
> > > > >
> > > > > On Thu, Mar 9, 2017 at 2:23 PM, Daan Hoogland <
> > daan.hoogl...@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > If we have to lay a burdon of fixing before release on people
> that
> > > > > > don't use it, i would say no. You use it, you maintain it. I am
> > happy
> > > > > > to charge money to whoever wants to not maintain what they use.
> > > > > >
> > > > > > On Thu, Mar 9, 2017 at 7:11 PM, Rafael Weingärtner
> > > > > >  wrote:
> > > > > > > Daan, before removing anything, I think we should check if
> there
> > > are
> > > > > > people
> > > > > > > using it, right?
> > > > > > >
> > > > > > > On Thu, Mar 9, 2017 at 11:08 AM, Daan Hoogland <
> > > > > daan.hoogl...@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > >> I was about to reply along those lines. As you brought it up,
> we
> > > are
> > > > > > >> now considering it. If the fix is easy I'd say let it stay
> till
> > > the
> > > > > > >> next problem but it is ot the first time mido bugs us.
> > > > > > >>
> > > > > > >> On Thu, Mar 9, 2017 at 5:07 PM, Simon Weller  >
> > > > wrote:
> > > > > > >> > So this brings up a good discussion point. As Jeff points
> out,
> > > the
> > > > > > >> Midonet plugin hasn't been actively supported for almost 5
> > years.
> > > At
> > > > > > what
> > > > > > >> point do we consider retiring unsupported plugins?
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > - Si
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > 
> > > > > > >> > From: Jeff Hair 
> > > > > > >> > Sent: Thursday, March 9, 2017 9:43 AM
> > > > > > >> > To: dev@cloudstack.apache.org
> > > > > > >> > Subject: Re: midonet-client and Guava dependency conflict
> > > > > > >> >
> > > > > > >> > After doing some more digging, I have confirmed the
> following:
> > > > > > >> >
> > > > > > >> >- The midonet plugin is using the Maven Shade plugin to
> > put a
> > > > > > bunch of
> > > > > > >> >dependencies into itself.
> > > > > > >> >- The plugin hosted in this repository was last updated
> in
> > > > 2013.
> > > > > > >> >- Most importantly: removing all the guava stuff out of
> the
> > > > > midonet
> > > > > > >> >plugin fixes this issue.
> > > > > > >> >
> > > > > > >> > I have not had any success in applying
> > > > > > >> > https://github.com/openwide-java/tomcat-classloader-ordered
> > to
> > > > get
> > > > > > >> Tomcat
> > > > > > >> > [https://avatars1.githubusercontent.com/u/1385131?v=3=400
> > > > > 

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
Looks good (did not test it)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit thanks for your work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
not tested it. but it seems the 'else' part also need to be changed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re:Re: :[VOTE] Apache Cloudstack 4.10.0.0

[Haijiao]

Hi, Karuturi


These PRs below seems ready to be merged too. 


#1883, CLOUDSTACK-9723: Enable unique mac address across the zones
#1886, CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response
#1901, CLOUDSTACK-9405: add details parameter in listDomains API to reduce the 
execution time
#1903, CLOUDSTACK-9356: FIX Cannot add users in VPC VPN
#1955, CLOUDSTACK-8239 Add VirtIO SCSI support for KVM hosts
#1956, CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerImpl.java
#1993, CLOUDSTACK-8931: Fail to deploy VM instance when 
use.system.public.ips=false
#1970, CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgrade 
which doesnt have ACL service Enabled.
#1978, CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic 
Ip x.x.x.x is mapped to load balancing rule
#1957, CLOUDSTACK-9748:VPN Users search functionality broken






在2017年03月14 00时54分, "Rajani Karuturi"写道:

1866 - failed BVT results(may not be related. But, needs to be
checked. Also, jenkins and travis failed)

1967 - no test results

rest merged.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 4, 2017 at 8:13 PM, Haijiao (18602198...@163.com

[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Trillian test result (tid-954)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33186 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2003-t954-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 45 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 197.06 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1226.73 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 367.39 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 308.87 | 
test_privategw_acl.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Failure` | 
41.60 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Failure` | 31.61 | 
test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Failure` | 93.45 
| test_network.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 154.57 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 60.82 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 245.94 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 275.74 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 501.27 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 541.72 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 742.74 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.17 | test_volumes.py
test_08_resize_volume | Success | 156.07 | test_volumes.py
test_07_resize_fail | Success | 161.42 | test_volumes.py
test_06_download_detached_volume | Success | 156.57 | test_volumes.py
test_05_detach_volume | Success | 155.55 | test_volumes.py
test_04_delete_attached_volume | Success | 151.12 | test_volumes.py
test_03_download_attached_volume | Success | 156.10 | test_volumes.py
test_02_attach_volume | Success | 89.55 | test_volumes.py
test_01_create_volume | Success | 710.80 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.66 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 159.69 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 256.90 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.48 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.59 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.63 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.63 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.12 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.24 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 50.38 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.11 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 20.24 | test_templates.py
test_10_destroy_cpvm | Success | 161.54 | test_ssvm.py
test_09_destroy_ssvm | Success | 138.36 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.44 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.44 | test_ssvm.py
test_06_stop_cpvm | Success | 132.03 | test_ssvm.py
test_05_stop_ssvm | Success | 163.51 | test_ssvm.py
test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
test_03_ssvm_internals | Success | 3.27 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.92 | test_snapshots.py
test_04_change_offering_small | Success | 234.25 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | 

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@nvazquez @rafaelweingartner @GabrielBrascher, That method is called from 
multiple places. There are many places where we can do these kind of changes. I 
would prefer to have those kind of changes in PR specific to that so that they 
are easy to track and test for that specific purpose. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---