Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r140055857
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1054,8 +1057,36 @@ public void setMax(Object max
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/805
+1
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/976
Sure!
Regards,
Salim
From: dprofeta <notificati...@github.com>
Sent: Friday, October 6, 2017 8:52:51 AM
To: apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/976#discussion_r143837353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -156,18 +160,39 @@ public ScanBatch
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/970#discussion_r143017778
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
---
@@ -84,14 +82,7 @@
private RecordReader
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/970#discussion_r143020963
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -184,25 +183,26 @@ public void
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Paul,
- I think you misunderstood the proposal
- Let me use an example
- select .. c1 like '%pattern1%' OR c1 like '%pattern2'..
- Assume c1 has 3 values [v1, v2, v3
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
- It was 50% for 1) and 50% for 2)
- Notice this breakdown depends on
o The number of Contains pattern for the same value (impacts 1))
o The pattern length (impacts both 1) and 2))
---
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1001
JIRA DRILL-5879: Like operator performance improvements
- Recently, custom code has been added to handle common search patterns
(Like operator)
- Contains, Starts With, and Ends
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Paul, again thanks for the detailed review:
- I was able to address most of the feedback except for one
- I agree that expressions that can operate directly on the encoded UTF-8
string
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1072
DRILL-5879: Improved SQL Pattern Contains Performance
**BACKGROUND**
- JIRA [DRILL-5879](https://issues.apache.org/jira/browse/DRILL-5879) goal
is to improve the "Contains&quo
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1015
Padma, DRILL-5889 is the wrong JIRA (sqlline loses RPC..); I think your
JIRA is 5899
Regards,
Salim
From: Padma Penumarthy
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/976
Looking at the stack trace:
- The code definitely is initializing a column of type REPEATABLE
- The Fast Reader didn't expect this scenario so it used a default
container (NullableVarBinary
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1060
DRILL-5846: Improve parquet performance for Flat Data Types
Performance improvements for the Parquet Scanner (Flat Data Types). The are
two flags to control this performance enhancement (disabled
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/976
+1
looks good!
---
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1001#discussion_r146952578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -17,37 +17,166 @@
*/
package
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1008
@parthchandra can you please review this change? thanks!
---
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1008
drill-5890: Fixed a file descriptor leak in Drill's test-suite
Problem Description
- The Drill test-suite uses two surefire processes to run tests
- This has the advantage of avoiding
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1001#discussion_r146708658
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -17,37 +17,166 @@
*/
package
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1001#discussion_r146705325
--- Diff:
exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java
---
@@ -73,6 +73,9 @@ public void eval() {
out.start
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158080071
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158072762
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158074965
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158080247
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158074289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158085723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158086368
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1237
@vrozov,
**What are we trying to solve / improve**
- Drill is currently not properly reporting memory held in Fragment's
receive queues
- This makes it hard to analyze OOM
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1237
That was not my intention as my current change aimed at describing the
system the way it is.
@parthchandra, any feedback?
---
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184728292
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184747702
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184727914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184730050
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184726839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184807153
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184572864
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184574405
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184573646
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184575686
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184574622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1237
@vrozov, your observation is valid, we need more JIRAs to fix the reporting
problem
**Current Fix**
- At this time, the UnorderedReceiver didn't account for any consumed memory
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1001#discussion_r145746250
--- Diff:
exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java
---
@@ -73,6 +73,9 @@ public void eval() {
out.start
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
Before I reply to the provided comments I want first to thank both Parth
and Paul for taking time to review this Pull Request.
@parthchandra Regarding the High Level Comments
- FS
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r160514755
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VLAbstractEntryReader.java
---
@@ -0,0 +1,215
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1087
Attempt to fix memory leak in Parquet
** Problem Description **
This is an extremely rare leak which I was able to emulate by putting a
sleep in the AsyncPageReader right after reading
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1087
@parthchandra can you please review this fix?
---
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161028252
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -471,8 +519,8 @@ public void close() throws Exception
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Created another pull request #1072to merge my changes with the one done
with Padma's.
---
Github user sachouche closed the pull request at:
https://github.com/apache/drill/pull/1001
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1087
Thank you Arina for catching this; I created the commit for QA before
vacation so that they could verify the fix. At that time, I didn't have an
Apache JIRA. I have now updated the comment
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160763490
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160753323
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160765882
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java
---
@@ -446,6 +446,61 @@ public void testSqlPatternComplex
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160755097
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160758370
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160764681
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160759375
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r160754694
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162121115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162119757
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162120115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162123690
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162124388
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162124359
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,286 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r162828788
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -68,96 +85,441 @@
private final UInt1Vector bits = new
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r162828863
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -68,96 +85,441 @@
private final UInt1Vector bits = new
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r162828312
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -51,6 +57,17 @@
public final class ${className} extends
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r162828174
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -51,6 +57,17 @@
public final class ${className} extends
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
@paul-rogers with regard to the design aspects that you brought up:
** Corrections about the proposed Design **
Your analysis somehow assumes the Vector is the one driving the loading
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161065237
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -148,6 +148,8 @@ message SerializedField {
optional int32 value_count = 4
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161045748
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -386,7 +391,7 @@ public void reAlloc() {
throw new
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161039122
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -874,6 +880,46 @@ public void setSafe(int index, BigDecimal value
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161036145
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161040070
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -309,7 +314,7 @@ public void setInitialCapacity(final int valueCount
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161032779
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -165,17 +181,133
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r161030963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -449,7 +451,7 @@ public void close() throws
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164532290
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -703,7 +703,18 @@ protected void _setLong(int index, long value
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164525752
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164509658
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r165698800
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -703,7 +703,18 @@ protected void _setLong(int index, long value
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1106
Thanks @paul-rogers for the information; I went through the PR and noticed
the following:
- BatchSchema invokes MaterializedField.isEquivalent()
- With my fix, both methods consider
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1106
Thank you Aman and Paul for reviewing this JIRA. I have created a new JIRA
[DRILL-6131](https://issues.apache.org/jira/browse/DRILL-6131) to track the new
SchemaComparator utility for sharing
Github user sachouche closed the pull request at:
https://github.com/apache/drill/pull/1106
---
GitHub user sachouche reopened a pull request:
https://github.com/apache/drill/pull/1106
DRILL-6129: Fixed query failure due to nested column data type change
Problem Description -
- The Drillbit was able to successfully send batches containing different
metadata (for nested
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1106
DRILL-6129: Fixed query failure due to nested column data type change
Problem Description -
- The Drillbit was able to successfully send batches containing different
metadata (for nested
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1011
+1
I have reviewed the code and overall looks good. My main feedback is that
the current implementation doesn't currently support secure clusters (at least
didn't see any logic associated
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1107#discussion_r166448594
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -77,7 +77,7 @@ private ExecConstants() {
public static final
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1107#discussion_r166450263
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -102,20 +105,78 @@
private final List
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r158084806
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -19,44 +19,283 @@
import
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1168#discussion_r174870229
--- Diff: exec/jdbc-all/pom.xml ---
@@ -473,6 +473,8 @@
org/yaml/**
hello/**
webapps
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
@sohami can you please review this pull request?
Thanks!
---
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1168
DRILL-6246: Reduced the size of the jdbc-all jar file
- The jdbc-all client jar has been growing in size from version to the next
(~20MB in version 1.10, ~27MB in version 1.12, and 34MB
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1168#discussion_r174889287
--- Diff: exec/jdbc-all/pom.xml ---
@@ -473,6 +473,8 @@
org/yaml/**
hello/**
webapps
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1170
@amansinha100 can you please review this pull request?
Thanks!
---
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1170
DRILL-6223: Fixed several Drillbit failures due to schema changes
Fixed several Issues due to Schema changes:
1) Changes in complex data types
Drill Query Failing when selecting all
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179296101
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java
---
@@ -0,0 +1,199 @@
+/**
--- End diff
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r179295602
--- Diff: exec/java-exec/pom.xml ---
@@ -836,6 +836,14 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
No I didn't.
Regards,
Salim
Regards,
Salim
-Original Message-
From: Kunal Khatua [notificati...@github.com]
Received: Tuesday, 10 Apr 2018, 14:01
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r183898352
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18 @@ public
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1237
DRILL-6348: Fixed code so that Unordered Receiver reports its memory â¦
Problem Description -
- The Unordered Receiver doesn't report any memory usage because the RPC
infrastructure
1 - 100 of 119 matches
Mail list logo
