Re: Broken javadocs

2016-02-01 Thread Kirk Lund
on develop into errors without increasing the restrictions even further? Thanks, Kirk On Thu, Jan 28, 2016 at 12:54 PM, Kirk Lund <kirk.l...@gmail.com> wrote: > Thanks Nitin! I'm going to go ahead and fix all of the warnings and > re-enable strict checking. > > If anyone else h

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
= 1.2 cglib.version = 3.1 classmate.version = 0.9.0 commons-collections.version = 3.2.1 - Kirk Lund On Jan. 30, 2016, 12:58 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
TransactionScoped is using some CDI annotations that the Geode build is unaware of. Maybe there's a way to exclude transitive dependencies from the javadocs or maybe we need to add a javadoc dependency on CDI? Thanks, Kirk On Fri, Jan 29, 2016 at 4:11 PM, Kirk Lund <kirk.l...@gmail.com>

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
r/42991/diff/ Testing --- build and manual inspection of generated javadocs Thanks, Kirk Lund

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
f/ Testing --- build and manual inspection of generated javadocs Thanks, Kirk Lund

Broken javadocs

2016-01-28 Thread Kirk Lund
The build reports lots of broken javadocs. After fixing them, is there a way (in gradle) to turn the warnings into errors that fail the build? I would hate to go to all the effort of fixing these warnings and then see people checkin more broken javadocs after that. Thanks, Kirk

Re: [GitHub] incubator-geode pull request: GEODE-852: refactor gemfire-pulse no...

2016-01-27 Thread Kirk Lund
I'll work on this PR. -Kirk On Wed, Jan 27, 2016 at 9:20 AM, jinmeiliao wrote: > GitHub user jinmeiliao opened a pull request: > > https://github.com/apache/incubator-geode/pull/80 > > GEODE-852: refactor gemfire-pulse not to generate a pulseverion.prope… > >

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Kirk Lund
+1 yes, let me know what I can do to help! On Tue, Jan 26, 2016 at 2:02 PM, Dan Smith wrote: > I checked in a minor fix to allow you to use a lambda expression in > VM.invoke calls with our dunit framework. For example: > > String result = vm1.invoke(() -> "Hello from

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-26 Thread Kirk Lund
+1 I would like to see this get merged to develop On Tue, Jan 26, 2016 at 4:02 PM, Dan Smith wrote: > All of the subtasks of GEODE-801 are done; I believe this code is ready to > be merged. > > It's been a week and there have been nothing but positive responses on this >

Review Request 42729: GEODE-851: Cleanup tests in management.internal.security package

2016-01-25 Thread Kirk Lund
/OperationCodesForDistributedSystemMXBeanTest.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationJUnit.java 0d680e6 Diff: https://reviews.apache.org/r/42729/diff/ Testing --- com.gemstone.gemfire.management.internal.security tests Thanks, Kirk Lund

Re: Review Request 42679: GEODE-832: Modifying the dunit framework to allow lambda expressions

2016-01-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42679/#review116142 --- Ship it! Ship It! - Kirk Lund On Jan. 23, 2016, 1:41 a.m

Re: Review Request 42729: GEODE-851: Cleanup tests in management.internal.security package

2016-01-25 Thread Kirk Lund
On Jan. 25, 2016, 7:55 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42729/ > --- > > (

Re: Review Request 42729: GEODE-851: Cleanup tests in management.internal.security package

2016-01-25 Thread Kirk Lund
/ResourceOperationJUnit.java 0d680e6 Diff: https://reviews.apache.org/r/42729/diff/ Testing --- com.gemstone.gemfire.management.internal.security tests Thanks, Kirk Lund

Review Request 42665: Move dunit to com.gemstone.gemfire.test.dunit

2016-01-22 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42665/ --- Review request for geode, Jens Deppe and Jinmei Liao. Bugs: GEODE-819

Review Request 42561: Move dunit.standalone pkg to com.gemstone.gemfire.test.dunit.standalone

2016-01-20 Thread Kirk Lund
17a39fa gemfire-core/src/test/java/dunit/tests/VMDUnitTest.java 27736dc Diff: https://reviews.apache.org/r/42561/diff/ Testing --- precheckin (all tests) Thanks, Kirk Lund

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Kirk Lund
+1 for extending the vote to 72 hours (is this possible or do we have to end this vote and start a new one?) On Wed, Jan 20, 2016 at 9:23 AM, Michael Stolz wrote: > What caused it to have such a short deadline? Did we do something to cause > it to be so short or is that the

ConcurrentStartTest and JSONAuthCodeTest

2016-01-11 Thread Kirk Lund
The tests ConcurrentStartTest and JSONAuthCodeTest are currently failing in the nightly build. They are filed as GEODE-765 and GEODE-766. Prior to last week, the build.gradle's filter for integrationTest was **JUnitTest.class. One of my checkins changed that to **Test.class, so now the build is

Commit message format

2016-01-08 Thread Kirk Lund
Reminder that we're supposed to be using formatting like the following for commit messages (if I'm wrong, please correct this)... GEODE-nn: Capitalized, 50 chars or less summary More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further

Re: Open pull requests

2016-01-08 Thread Kirk Lund
ot;Closes #XX" in the message or merging in > the PR without rebasing. > > -Dan > > On Fri, Jan 8, 2016 at 9:46 AM, John Blum <jb...@pivotal.io> wrote: > > > True, the graph definitely, but the commit messages, not so much. > > > > On Fri, Jan 8

Re: releaseType?

2016-01-08 Thread Kirk Lund
I prefer the Spring model on release numbering/labeling. Also since I'm one of the folks who has to work on both projects, I really want this to be consistent between Apache Geode (incubating) and Spring Data GemFire. -Kirk On Fri, Jan 8, 2016 at 10:58 AM, Swapnil Bawaskar

Re: enabling network partition detection by default

2016-01-08 Thread Kirk Lund
Having a second set of properties is just one more thing that a user has to read but will ultimately not look at or not know about. That's why changing the defaults would be valuable. Either the existing users (who have more experience) need to be made aware of the change in defaults or the new

Re: Open pull requests

2016-01-08 Thread Kirk Lund
correlation to the changelog or > JIRA tickets, etc)... > > Running a git log -v --graph also illustrates another problem (a non-linear > series of commits cause by not rebasing, which ought to be allowed on > "topic" branches). > > $0.02 > -John > > > On Fri, Jan

Re: Open pull requests

2016-01-08 Thread Kirk Lund
PR. If not done properly, then > you can manually close it without a commit. > > On Fri, Jan 8, 2016 at 9:16 AM, John Blum <jb...@pivotal.io> wrote: > > > You don't need to push commits to close PRs (at least not in GitHub; not > > sure how Apace works). &g

Open pull requests

2016-01-07 Thread Kirk Lund
We have 6 pull requests that have been open for quite a while. Is someone already working on each of these? What's the status on them? https://github.com/apache/incubator-geode/pulls Enabling direct reporting on Geode's website #66 opened 10 days ago by rvs GEODE-341/ GEODE-628: Refactor Java

Re: enabling network partition detection by default

2016-01-07 Thread Kirk Lund
This 1st geode release (and any alpha flavors of it) will not support rolling upgrade because of the new jgroups . So now would be a good time to change defaults such as this. -Kirk On Thu, Jan 7, 2016 at 2:12 PM, Swapnil Bawaskar wrote: > This will have to be phased

Re: Propose new committer - Jinmei Liao

2016-01-06 Thread Kirk Lund
Is there a FAQ somewhere that explains what all private@geode is for? I've wondered what its purpose is several times now. -Kirk On Wed, Jan 6, 2016 at 9:51 AM, Gregory Chase wrote: > Please make specific requests about individuals to > priv...@geode.incubator.apache.org -

Review Request 41992: Upgrade log4j2 from 2.1 to 2.5

2016-01-06 Thread Kirk Lund
: https://reviews.apache.org/r/41992/diff/ Testing --- LoggingUnitTestSuite, LoggingIntegrationTestSuite, Log4jUnitTestSuite, Log4jIntegrationTestSuite precheckin (currently in-progress) Thanks, Kirk Lund

Re: [GitHub] incubator-geode pull request: Enabling direct reporting on Geode's...

2016-01-04 Thread Kirk Lund
+1 On Mon, Jan 4, 2016 at 9:04 AM, Mark Bretl wrote: > +1 > > --Mark > > On Fri, Jan 1, 2016 at 5:49 AM, Anthony Baker wrote: > > > +1 > > > > > On Dec 30, 2015, at 9:10 PM, Roman Shaposhnik > > wrote: > > > > > > On Mon, Dec 28,

Re: Review Request 41750: Modify all tests to use JUnit Categories

2016-01-04 Thread Kirk Lund
ything interesting? > > --Jens > > On Mon, Jan 4, 2016 at 8:33 AM, Kirk Lund <kl...@pivotal.io <javascript:;>> > wrote: > > > Right now I'm stuck as git won't let me merge the changes to develop. I'm > > not sure what to do next and I'm not going to experiment as

Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh history file

2016-01-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41803/#review112591 --- Ship it! Ship It! - Kirk Lund On Dec. 30, 2015, 6:57 p.m

Re: Review Request 41750: Modify all tests to use JUnit Categories

2016-01-04 Thread Kirk Lund
, Bruce Schuchardt <bschucha...@pivotal.io> wrote: > Kirk, I'm in the process of migrading the gemfire-cq project to > open-source. Are you going to be checking this into the develop branch > soon? > > > Le 12/29/2015 3:41 PM, Kirk Lund a écrit : > >> >

Re: Review Request 41750: Modify all tests to use JUnit Categories

2015-12-29 Thread Kirk Lund
rationTest, distributedTest, check, assemble, rat Thanks, Kirk Lund

Re: Review Request 41750: Modify all tests to use JUnit Categories

2015-12-29 Thread Kirk Lund
https://reviews.apache.org/r/41750/#review112252 --- On Dec. 29, 2015, 6:42 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 41664: Increase ExpectedTimeout maximum duration to prevent false failures

2015-12-22 Thread Kirk Lund
/gemstone/gemfire/internal/process/PidFileJUnitTest.java 89f786a Diff: https://reviews.apache.org/r/41664/diff/ Testing --- PidFileJUnitTest Thanks, Kirk Lund

Re: Stats for GMS Health Monitor

2015-12-21 Thread Kirk Lund
+1 On Fri, Dec 18, 2015 at 3:46 PM, Jianxia Chen wrote: > Hi all, > > I am trying to implement the stats for Geode membership service health > monitor, which monitors the health of the members of the distributed system > by heartbeats. I will describe the stats that will be

Re: Review Request 41615: Capture lines read from status file in finally-block of FileControlProcessor

2015-12-21 Thread Kirk Lund
<https://reviews.apache.org/r/41615/#comment171757> This is on purpose. Changing from 100 ms sleep to 10 ms. - Kirk Lund On Dec. 22, 2015, 12:13 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 41481: GEODE-660: Fixing inconsistencies and reliance on randomness in TableBuilderJUnitTest

2015-12-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41481/#review111513 --- Ship it! Ship It! - Kirk Lund On Dec. 17, 2015, 12:26 a.m

Re: Review Request 41481: GEODE-660: Fixing inconsistencies and reliance on randomness in TableBuilderJUnitTest

2015-12-16 Thread Kirk Lund
for testability in the long run. - Kirk Lund On Dec. 17, 2015, 12:26 a.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41415: GEODE-678: lock reentry can timeout

2015-12-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41415/#review110590 --- Ship it! Ship It! - Kirk Lund On Dec. 15, 2015, 11:41 p.m

Review Request 41357: Update versions of Awaitility and System-Rules for tests

2015-12-14 Thread Kirk Lund
-versions.properties 8ea38c3 Diff: https://reviews.apache.org/r/41357/diff/ Testing --- Targeted testing of tests using Awaitility and System-Rules precheckin Thanks, Kirk Lund

Re: Build failed in Jenkins: Geode-nightly #307

2015-12-10 Thread Kirk Lund
will look at it and add a filter > for the macMini. > > --Mark > > On Thu, Dec 10, 2015 at 9:43 AM, Kirk Lund <kirk.l...@gmail.com> wrote: > > > Do we need to email bui...@apache.org to request that they remove this > > machine from the Jenkins rotation? > > &g

Re: Review Request 41044: Update process stream handling in tests that fork JVMs

2015-12-10 Thread Kirk Lund
Can the timeouts be consolidated at all? > > > > Can the defaults be shortened? If something is actually wrong, a > > timeout of 10 minutes is a long time to wait to find out. > > Kirk Lund wrote: > The current default is 5 minutes. This has been a gradually growing >

Re: Review Request 41044: Update process stream handling in tests that fork JVMs

2015-12-10 Thread Kirk Lund
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41044/#review109886 --- On Dec. 7, 2015, 5:25 p.m., Kirk Lund wrote: > >

Re: Review Request 41044: Update process stream handling in tests that fork JVMs

2015-12-10 Thread Kirk Lund
--- new tests and precheckin Thanks, Kirk Lund

Re: Build failed in Jenkins: Geode-nightly #307

2015-12-10 Thread Kirk Lund
Do we need to email bui...@apache.org to request that they remove this machine from the Jenkins rotation? -Kirk On Thu, Dec 10, 2015 at 9:21 AM, Dan Smith wrote: > Looks like this tried to run the nightly build on a mac mini with no git > installed? > > -Dan > > On Wed, Dec

Review Request 41044: Update process stream handling in tests that fork JVMs

2015-12-07 Thread Kirk Lund
gradle/dependency-versions.properties 3e6b6a5 Diff: https://reviews.apache.org/r/41044/diff/ Testing --- new tests and precheckin Thanks, Kirk Lund

Re: Review Request 40850: GMSJoinLease junit tests

2015-12-03 Thread Kirk Lund
(I also included the following in reviewboard) I recommend using Awaitility: https://github.com/jayway/awaitility I've already added it to Geode and written several tests using it. Most of my tests are unfortunately languishing on (long-term) feature branches, but it looks like others have used

Re: Review Request 40850: GMSJoinLease junit tests

2015-12-03 Thread Kirk Lund
to DistributedTestCase.WaitCriterion but Awaitility is much better and more versatile while being a commonly used standard library (it's even has some coverage in books on unit testing). -Kirk - Kirk Lund On Dec. 3, 2015, 6:50 p.m., Hitesh Khamesra wrote

Fwd: Build failed in Jenkins: Geode-nightly #298

2015-12-02 Thread Kirk Lund
Are we getting Gradle/JUnit/Report failures like this because the test results are too large? Would it be helpful to split out our nightly build into more than one job? -Kirk -- Forwarded message -- From: Apache Jenkins Server Date: Tue, Dec 1, 2015

Re: License headers on new source files

2015-11-25 Thread Kirk Lund
GEODE-18 was supposed to include adding RAT to our build. Not sure what happened but GEODE-608 is more specific. -Kirk On Wednesday, November 25, 2015, Nitin Lamba wrote: > +1 > > Maybe it is obvious but having RAT as part of pre-checkin step would be > desirable. > > -Nitin >

README.md specifies jdk1.7.75

2015-11-24 Thread Kirk Lund
The file README.md specifically mentions jdk1.7.75 under the "Geode in 5 minutes" section. Shouldn't we update that to 1.8? Also, do we really want this to specify a specific build #? If so, which build #? "Extract and build from source (note: currently Geode supports jdk1.7.75):" -Kirk

Re: testDefaults in BasicI18nJUnitTest

2015-11-05 Thread Kirk Lund
+1 for deleting it. Test looks worthless. I'd be in favor of completely replacing the internationalization code in Geode. -Kirk On Thu, Nov 5, 2015 at 11:43 AM, Dan Smith wrote: > I don't see much purpose behind that test either. I'd be in favor of > deleting it. > > -Dan

Re: Delete feature/GEODE-409?

2015-11-05 Thread Kirk Lund
+1 On Thu, Nov 5, 2015 at 12:19 PM, Sai Boorlagadda wrote: > +1 > > On Thu, Nov 5, 2015 at 12:17 PM, William Markito > wrote: > > > +1 > > > > On Thu, Nov 5, 2015 at 11:39 AM, Darrel Schneider > > > wrote: > > > > > +1 > >

regex in jira

2015-11-05 Thread Kirk Lund
Does anyone know if it's possible to use regex in jira queries/filters? -Kirk

Re: Review Request 39346: GEODE-405: sameAs needs to ignore ssl-* properties

2015-11-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39346/#review105093 --- Ship it! Ship It! - Kirk Lund On Oct. 15, 2015, 5:42 p.m

Re: Review Request 39362: GEODE-406: Adding --J parameter to validate offline-disk-store

2015-11-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39362/#review105092 --- Ship it! Ship It! - Kirk Lund On Oct. 15, 2015, 11:02 p.m

Re: Review Request 39925: GEODE-438: wait longer in test validation code

2015-11-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39925/#review105090 --- Ship it! Ship It! - Kirk Lund On Nov. 4, 2015, 12:49 a.m

Re: Review Request 39921: GEODE-296: change test to handle EntryDestroyedException

2015-11-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39921/#review105091 --- Ship it! Ship It! - Kirk Lund On Nov. 3, 2015, 10:56 p.m

Re: Review Request 39885: squash-a-thon week 2 fixes

2015-11-03 Thread Kirk Lund
gement/ClientHealthStatsDUnitTest.java (line 418) <https://reviews.apache.org/r/39885/#comment163297> Is this sleep needed? It's happening at the end of the test. - Kirk Lund On Nov. 3, 2015, 1:01 a.m., Darrel Sch

Re: Review Request 39879: Add gemfire-common and @Experimental annotation

2015-11-03 Thread Kirk Lund
the root of the module dependency > tree. > > When we refactor to break dependencies such that we *can* separate out an API > module (both for client and server) we definitely should. > > IMO > > > - Anthony > > On November 2nd, 2015, 9:57 p.m. UTC, Kirk Lund w

Geode Definition of Done (DOD)

2015-11-02 Thread Kirk Lund
I think we need to settle on a formal Definition of Done (DOD) for Apache Geode. Again, borrowing from Spring Data we could start with what they define and add to it: - Implemented according to specification in the ticket - Unit tested - Integration tested - Reference documentation

JIRA Resolved vs Closed

2015-11-02 Thread Kirk Lund
Is there a standard that ASF follows for when a JIRA ticket changes status to Resolved vs Closed? If not, then I'd like recommend that we follow the process that Spring uses: Ticket changes to Resolved when the fix/implementation is committed or merged (to develop in our case). It then moves to

Re: Geode Release 1.0.0

2015-11-02 Thread Kirk Lund
Nitin, The JIRA tickets for CI failures do not have a common parent JIRA, but here's a query to see what's still open: project = GEODE AND status in (Open, "In Progress", Reopened) AND labels = CI There are currently 57 open CI tickets. We are not officially continuing the Squashathon but

Review Request 39879: Add gemfire-common and @Experimental annotation

2015-11-02 Thread Kirk Lund
/build.gradle 1c17474 gemfire-rebalancer/build.gradle d87dd58 gemfire-web/build.gradle f0de25a settings.gradle 4b2da7b Diff: https://reviews.apache.org/r/39879/diff/ Testing --- clean build and unit testing of the new annotation Thanks, Kirk Lund

Re: Review Request 39877: GEODE-522: Fix eclipse classpath for generation of IDE project files

2015-11-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39877/#review104800 --- Ship it! Ship It! - Kirk Lund On Nov. 2, 2015, 9:38 p.m., Mark

Fwd: Apache Geode Clubhouse: Tuesday, November 3

2015-11-02 Thread Kirk Lund
Reminder: next Clubhouse is tomorrow (Tues) morning 9AM PST! Topic is: OQL Querying and Indexing in Geode Be seeing you, Kirk -- Forwarded message -- From: Marie Nedich Date: Fri, Oct 23, 2015 at 11:26 AM Subject: Apache Geode Clubhouse: Tuesday, November 3

Re: Review Request 39879: Add gemfire-common and @Experimental annotation

2015-11-02 Thread Kirk Lund
g/r/39879/#comment163050> I think this change was added to the diff by latest down-merge of develop HEAD to my branch. Let me know which is correct (testRuntime or provided). - Kirk Lund On Nov. 2, 2015, 9:57 p.m., Kirk Lund

Re: Geode Definition of Done (DOD)

2015-11-02 Thread Kirk Lund
2, 2015 at 12:44 PM, John Blum <jb...@pivotal.io> wrote: > > > >> +1 > >> > >> On Mon, Nov 2, 2015 at 12:36 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> > >> wrote: > >> > >>> +1 > >>> On 3 Nov 2015 7:14 am, &

Re: Geode Definition of Done (DOD)

2015-11-02 Thread Kirk Lund
at 1:33 PM, William Markito <wmark...@pivotal.io> > wrote: > > > > > > +1 > > > > > > Just one question, what is snapshot build deployed ? Is it the same as > > > snapshot build successfully completed ? > > > > > > On Mon, No

Re: Review Request 39585: Integrated Security DUnitTest

2015-10-27 Thread Kirk Lund
ity/TestAccessControl.java (line 3) <https://reviews.apache.org/r/39585/#comment162464> need to get rid of using hydra.Log gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAuthenticator.java (line 3) <https://reviews.apache.org/r/39585/#comment162465&g

Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

2015-10-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39664/#review104108 --- Ship it! Ship It! - Kirk Lund On Oct. 26, 2015, 11:04 p.m

Re: Review Request 39659: squash-a-thon week 1 fixes

2015-10-26 Thread Kirk Lund
pache.org/r/39659/#comment162281> indentation inside this block appears to be wrong gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java (line 188) <https://reviews.apache.org/r/39659/#comment162280> indentation inside thi

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

2015-10-22 Thread Kirk Lund
This is from the old Ant build (which Geode doesn't use): $build.sh run-management-tests -DuseHTTP=true What's the counterpart in the Geode gradle build? -Kirk On Thu, Oct 22, 2015 at 11:55 AM, John Blum wrote: > >

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

2015-10-22 Thread Kirk Lund
And I don't > > think there should be - if this is something that needs to be tested it > > should be running in every nightly build, not just when you pass a > special > > flag. > > > > -Dan > > > > On Thu, Oct 22, 2015 at 12:12 PM, Kirk Lund <kl...@pivotal.i

Geode Bug Squashathon Day Three (Wednesday)

2015-10-22 Thread Kirk Lund
On the third day of Geode Bug Squashathon (Wed) we had our 1st GREEN build of DistributedTests this week! We had 11 volunteers fixing 4 tickets (12 more remained in progress by end of day). The UnitTests and IntegrationTests remained green for us except for 1 failure in IntegrationTests. We had

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

2015-10-22 Thread Kirk Lund
at 1:53 PM, Anthony Baker <aba...@pivotal.io> wrote: > Can we apply the @Parameterized annotation here? Two code paths, one test > (as the old saying goes…) > > Anthony > > > On Oct 22, 2015, at 1:46 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > &

Geode Bug Squashathon Day Four

2015-10-22 Thread Kirk Lund
We just finished our 4th day of Geode Bug Squashathon (Thurs) and we've had another GREEN build of DistributedTests. We had 12 volunteers and committed fixes for another 4 tickets. The UnitTest and IntegrationTest suites remained green for us except for 2 failures in IntegrationTests which were

Geode Bug Squashathon Day One

2015-10-19 Thread Kirk Lund
We started off our week of Geode Bug Squashathon with 6 volunteers fixing 12 tickets (with 4 more in-progress). The UnitTests and IntegrationTests are predominantly green. We had a number of failures caused by git timeouts and we hit 2 intermittent failures in IntegrationTests for which we filed

Re: CI cleanup & squashaton

2015-10-19 Thread Kirk Lund
, Oct 16, 2015 at 4:25 PM, Anthony Baker <aba...@pivotal.io> wrote: > +1 > > > On Oct 16, 2015, at 3:33 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > > Here's a filter that shows all CI tickets for Geode that are Open, > > In-Progress or Reopened (excluding

Re: CI cleanup & squashaton

2015-10-16 Thread Kirk Lund
Here's a filter that shows all CI tickets for Geode that are Open, In-Progress or Reopened (excluding HDFS): project = GEODE AND status in (Open, "In Progress", Reopened) AND labels = CI AND labels != HDFS The HDFS tests are disabled and HDFS should probably be moved to a feature branch (ie,

Review Request 39290: Configure Log4J 2 on classpath instead of with system property

2015-10-13 Thread Kirk Lund
ne/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java 2e08500 Diff: https://reviews.apache.org/r/39290/diff/ Testing --- precheckin-all Thanks, Kirk Lund

Re: Review Request 39028: fix intermittent failures in TXExpiryJUnitTest

2015-10-06 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39028/#review101671 --- Ship it! Ship It! - Kirk Lund On Oct. 5, 2015, 11:18 p.m

Re: Review Request 38866: PR put messages no longer deserialize old values early

2015-10-06 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38866/#review101670 --- Ship it! Ship It! - Kirk Lund On Sept. 29, 2015, 10:47 p.m

Re: Review Request 39058: GEODE-385: fix test race

2015-10-06 Thread Kirk Lund
/TXExpiryJUnitTest.java (line 324) <https://reviews.apache.org/r/39058/#comment159130> I think I would move this if-else block inside the try { below - Kirk Lund On Oct. 6, 2015, 6:28 p.m., Darrel Schneider wrote: > > --- > This is a

Re: Review Request 39028: fix intermittent failures in TXExpiryJUnitTest

2015-10-06 Thread Kirk Lund
/TXExpiryJUnitTest.java (line 57) <https://reviews.apache.org/r/39028/#comment159126> I would keep this as an IntegrationTest - Kirk Lund On Oct. 5, 2015, 11:18 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e

ASF Jira Project Roles and Groups

2015-10-02 Thread Kirk Lund
If I pull up a Jira ticket such as: https://issues.apache.org/jira/browse/GEODE-189 I can add a comment or edit an existing comment and I notice there's an option for locking the comment so that it's only readable by a specified Project Role or Group. At present there is only one Project Role

Re: ASF Jira Project Roles and Groups

2015-10-02 Thread Kirk Lund
way over > time to make internal test results and data less internal :-) > > Anthony > > > > On Oct 2, 2015, at 7:15 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > > If I pull up a Jira ticket such as: > > > > https://issues.apache.org/jira/browse/GEODE

Re: ASF Jira Project Roles and Groups

2015-10-02 Thread Kirk Lund
anything in geode that can't be > picked up and worked on by any member of the community. Having bugs that > can only be worked on by employees of Pivotal is contrary to being an open > community. > > -Dan > > On Fri, Oct 2, 2015 at 10:54 AM, Kirk Lund <kl...@pivotal.io>

Re: Incubator PMC/Board report for Oct 2015 ([ppmc])

2015-10-02 Thread Kirk Lund
We previously discussed (and decided) on this this list to stay on monthly reporting even though we're officially quarterly. -Kirk On Fri, Oct 2, 2015 at 1:14 PM, Niall Pemberton wrote: > On Thu, Oct 1, 2015 at 4:59 PM, Anthony Baker wrote: > > >

Propose changing check to only depend on UnitTest

2015-10-01 Thread Kirk Lund
Proposal: 1) Remove IntegrationTest and DistributionTest from "check" target 2) Add a new target (name TBD) that executes IntegrationTest and DistributionTest Reasons: 1) new people who clone and then build wait forever and complain that build hung resulting in bad first impression by users

Re: Review Request 38939: GEODE-379: fix spelling of entry-time-to-live-expiration-action option

2015-10-01 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38939/#review101287 --- Ship it! Ship It! - Kirk Lund On Oct. 1, 2015, 9:43 p.m

JIRA tickets with label "CI"

2015-09-29 Thread Kirk Lund
I've seen a few JIRA tickets filed against tests that failed in a private build (of develop without any changes) get labeled with "CI" -- since the test didn't fail in CI, should we come up with a different label for apparently spurious failures to indicate unreliable tests that failed outside of

Re: Review Request 38737: GEODE-372: Change Findbugs reportLevel to 'low'

2015-09-28 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38737/#review100857 --- Ship it! Ship It! - Kirk Lund On Sept. 24, 2015, 10:32 p.m

Review Request 38410: Create new Experimental annotation in gemfire-common

2015-09-15 Thread Kirk Lund
-info.java PRE-CREATION gemfire-core/build.gradle 1c17474 gemfire-rebalancer/build.gradle d87dd58 gemfire-web/build.gradle b9629d3 settings.gradle 4b2da7b Diff: https://reviews.apache.org/r/38410/diff/ Testing --- ./gradlew clean build ./gradlew gemfire-common:test Thanks, Kirk

Re: Releasing Geode (was Re: September 2015 Report)

2015-09-14 Thread Kirk Lund
> was given the right JIRA permissions. > > > > Is there a way to check if the project is 'allowed' to use the Agile > > plugin? > > > > Thanks, > > Nitin > > > > > > From: Kirk Lund <kl...@pivotal.io>

Re: GEODE-327: Rename gemfire-junit to gemfire-common

2015-09-14 Thread Kirk Lund
e. Going back to the > original purpose, we need a home for @Experimental. We can put that in > gemfire-common and create a separate issue for gemfire-junit -> > gemfire-test and associated code movement. > > Anthony > > > On Sep 12, 2015, at 11:16 AM, Kirk Lund <

Re: Create Region API

2015-09-14 Thread Kirk Lund
All of those "null" args make my soul hurt! You could feed a "create region" command string into MemberMXBean.processCommand() on the Manager. So, I think you would need to: a) target that Manager with your Function and access its MemberMXBean directly or b) connect to the Manager via remotely

Review Request 38373: Improve debugging of process integration test classes to better diagnose GEODE-291

2015-09-14 Thread Kirk Lund
/ Testing --- test integrationTest distributedTest Thanks, Kirk Lund

Re: Review Request 38283: GEODE-320: Close the cache in DistributedTestCase tear down

2015-09-14 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38283/#review98889 --- Ship it! Ship It! - Kirk Lund On Sept. 11, 2015, 12:57 a.m

Re: GEODE-327: Rename gemfire-junit to gemfire-common

2015-09-12 Thread Kirk Lund
r things common to geode development not related to > unit testing. Like utilities classes. > >> > >> > >> > >> > >> Jacob Barrett > >> Manager > >> GemFire Advanced Customer Engineering (ACE) > >> Pivotal > >> > >&g

<    1   2   3   4   5   6   >