Re: guac_user_alloc() can fail but not checked?

2018-09-18 Thread Mike Jumper
On Tue, Sep 18, 2018 at 12:51 PM, Ou Changkun wrote: > Hi Mike, > > Thanks for your confirmation. I found some related case: > https://stackoverflow.com/questions/13245312/calloc-fails- > and-returns-null/13252245 > > > calloc fails even there is enough memory. > > Perhaps may also occur in some

Re: INFO REQUIRED : Display of Centos 7 RDP Machine in IE and EDGE

2018-09-17 Thread Mike Jumper
Assuming you mean you are using XRDP on these CentOS desktops, you will need to look into how and whether you can configure XRDP to resize the screen upon connecting. Windows should generally always do this. XRDP, assuming it does support it, may take some doing. I suggest consulting the XRDP

[GitHub] guacamole-server pull request #183: GUACAMOLE-620: Fix instruction loss when...

2018-09-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/183#discussion_r217132320 --- Diff: src/libguac/parser.c --- @@ -222,7 +222,11 @@ int guac_parser_read(guac_parser* parser, guac_socket* socket, int usec_timeout

[GitHub] guacamole-server pull request #183: GUACAMOLE-620: Fix instruction loss when...

2018-09-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/183#discussion_r216996138 --- Diff: src/libguac/parser.c --- @@ -222,7 +222,11 @@ int guac_parser_read(guac_parser* parser, guac_socket* socket, int usec_timeout

[GitHub] guacamole-client pull request #318: GUACAMOLE-622: Increase FailoverGuacamol...

2018-09-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/318 GUACAMOLE-622: Increase FailoverGuacamoleSocket instruction queue limit. Some protocols, in particular SSH and telnet, may send a decent amount of data before the connection status

[GitHub] guacamole-server pull request #187: GUACAMOLE-622: Withhold first SSH/telnet...

2018-09-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/187 GUACAMOLE-622: Withhold first SSH/telnet frame until connection is verified These changes add a new function, `guac_terminal_start()`, which must be called before the terminal

[GitHub] guacamole-server pull request #186: GUACAMOLE-623: Add support for attaching...

2018-09-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/186 GUACAMOLE-623: Add support for attaching to the terminals of containers in Kubernetes pods. As described in [GUACAMOLE-623](https://issues.apache.org/jira/browse/GUACAMOLE-623

[GitHub] guacamole-server pull request #184: Create dk_dk_qwerty.keymap

2018-09-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/184#discussion_r216799749 --- Diff: src/protocols/rdp/keymaps/dk_dk_qwerty.keymap --- @@ -0,0 +1,64 @@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] guacamole-server pull request #183: GUACAMOLE-620: Fix instruction loss when...

2018-09-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/183#discussion_r216510493 --- Diff: src/libguac/parser.c --- @@ -222,7 +222,11 @@ int guac_parser_read(guac_parser* parser, guac_socket* socket, int usec_timeout

[GitHub] guacamole-server pull request #183: GUACAMOLE-620: Fix instruction loss when...

2018-09-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/183#discussion_r216497198 --- Diff: src/libguac/parser.c --- @@ -222,7 +222,11 @@ int guac_parser_read(guac_parser* parser, guac_socket* socket, int usec_timeout

[GitHub] guacamole-client pull request #315: GUACAMOLE-220: Correct handling of permi...

2018-09-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/315 GUACAMOLE-220: Correct handling of permission-filtered directory search. This change uses the correct `ObjectPermissionSet` to filter the identifiers of objects listed via REST when

[GitHub] guacamole-client pull request #314: GUACAMOLE-220: Add missing definitions f...

2018-09-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/314 GUACAMOLE-220: Add missing definitions for CREATE_USER_GROUP system permission. The `CREATE_USER_GROUP` system permission was missing from both the `SystemPermission` class

[GitHub] guacamole-client pull request #313: GUACAMOLE-598: Show fatal error message ...

2018-09-07 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/313 GUACAMOLE-598: Show fatal error message only after a fatal error has occurred. As the fatal error message is selectively hidden using AngularJS, there is a moment before AngularJS

[GitHub] guacamole-client pull request #311: GUACAMOLE-611: Selectively fall through ...

2018-09-07 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/311#discussion_r216066708 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/AuthenticationProviderFacade.java --- @@ -97,18 +119,122 @@ public Object

[GitHub] guacamole-client pull request #312: GUACAMOLE-567: Add specific connection s...

2018-09-07 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/312 GUACAMOLE-567: Add specific connection stability test to tunnel implementations. This change corrects the behavior of the connection instability detection by adding tunnel-specific

[GitHub] guacamole-client pull request #311: GUACAMOLE-611: Selectively fall through ...

2018-09-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/311#discussion_r215519606 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/AuthenticationProviderFacade.java --- @@ -97,18 +119,122 @@ public Object

[GitHub] guacamole-client pull request #311: GUACAMOLE-611: Selectively fall through ...

2018-09-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/311#discussion_r215516620 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/AuthenticationProviderFacade.java --- @@ -48,6 +48,16

[GitHub] guacamole-server pull request #181: GUACAMOLE-614: fix infinite loop in guac...

2018-08-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/181#discussion_r212780321 --- Diff: src/common/iconv.c --- @@ -67,18 +67,31 @@ int guac_iconv(guac_iconv_read* reader, const char** input, int in_remaining

[GitHub] guacamole-server pull request #181: GUACAMOLE-614: fix infinite loop in guac...

2018-08-23 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/181#discussion_r212509893 --- Diff: src/common/iconv.c --- @@ -67,18 +67,27 @@ int guac_iconv(guac_iconv_read* reader, const char** input, int in_remaining

[GitHub] guacamole-server pull request #181: GUACAMOLE-614: fix infinite loop in guac...

2018-08-23 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/181#discussion_r212509092 --- Diff: src/common/iconv.c --- @@ -67,18 +67,27 @@ int guac_iconv(guac_iconv_read* reader, const char** input, int in_remaining

[GitHub] guacamole-server pull request #181: GUACAMOLE-614: fix infinite loop in guac...

2018-08-23 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/181#discussion_r212501403 --- Diff: src/common/iconv.c --- @@ -67,18 +67,27 @@ int guac_iconv(guac_iconv_read* reader, const char** input, int in_remaining

[GitHub] guacamole-server pull request #180: GUACAMOLE-610: Add support for changing ...

2018-08-18 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/180 GUACAMOLE-610: Add support for changing scrollback buffer size. These changes allow the scrollback buffer size for SSH and telnet to be changed through two mechanisms: 1

[GitHub] guacamole-server pull request #179: GUACAMOLE-608: Fix connection write thre...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/179#discussion_r209022494 --- Diff: src/guacd/connection.c --- @@ -70,7 +70,7 @@ static int __write_all(int fd, char* buffer, int length) { while (length >

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r209020994 --- Diff: guacamole/src/main/webapp/app/manage/templates/manageUserGroup.html --- @@ -0,0 +1,102 @@ + --- End diff -- Extra

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r209019439 --- Diff: guacamole/src/main/webapp/app/rest/types/UserGroup.js --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r209018438 --- Diff: guacamole/src/main/webapp/app/rest/services/membershipService.js --- @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r209014326 --- Diff: guacamole/src/main/webapp/app/manage/templates/manageUserGroup.html --- @@ -0,0 +1,102 @@ + --- End diff -- Nope

[GitHub] guacamole-server pull request #179: GUACAMOLE-608: Fix connection write thre...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/179#discussion_r209009840 --- Diff: src/guacd/connection.c --- @@ -70,7 +70,7 @@ static int __write_all(int fd, char* buffer, int length) { while (length >

[GitHub] guacamole-server pull request #179: GUACAMOLE-608: Fix connection write thre...

2018-08-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/179#discussion_r208997209 --- Diff: src/guacd/connection.c --- @@ -70,7 +70,7 @@ static int __write_all(int fd, char* buffer, int length) { while (length >

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r208810507 --- Diff: guacamole/src/main/webapp/app/settings/directives/guacSettingsUserGroups.js --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r208805738 --- Diff: guacamole/src/main/webapp/app/manage/directives/identifierSetEditor.js --- @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r208803736 --- Diff: guacamole/src/main/webapp/app/manage/directives/identifierSetEditor.js --- @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/309#discussion_r208801944 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageUserGroupController.js --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #309: GUACAMOLE-220: Add user interface for ma...

2018-08-08 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/309 GUACAMOLE-220: Add user interface for managing user groups and membership. This change: * Adds a new tab for managing user groups, similar to the existing user management tab

[GitHub] guacamole-client pull request #306: GUACAMOLE-220: Display readable connecti...

2018-07-21 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/306 GUACAMOLE-220: Display readable connections only by default within permission editor. In the interest of reducing clutter within the group editor (which has even more sections than

[GitHub] guacamole-server pull request #176: GUACAMOLE-573: Correct scrollback buffer...

2018-07-17 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/176 GUACAMOLE-573: Correct scrollback buffer bounds checks. The new bounds checks added for copying text from the scrollback buffer are incorrect for the case where the number of rows

[GitHub] guacamole-manual pull request #91: GUACAMOLE-540: Document configuration for...

2018-07-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/91#discussion_r203229316 --- Diff: src/chapters/reverse-proxy.xml --- @@ -45,6 +45,99 @@ you will be creating connections that have Cyrillic, Chinese

[GitHub] guacamole-manual pull request #91: GUACAMOLE-540: Document configuration for...

2018-07-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/91#discussion_r203229742 --- Diff: src/chapters/reverse-proxy.xml --- @@ -45,6 +45,99 @@ you will be creating connections that have Cyrillic, Chinese

[GitHub] guacamole-manual pull request #91: GUACAMOLE-540: Document configuration for...

2018-07-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/91#discussion_r202876382 --- Diff: src/chapters/reverse-proxy.xml --- @@ -45,6 +45,99 @@ you will be creating connections that have Cyrillic, Chinese

[GitHub] guacamole-manual pull request #89: GUACAMOLE-527: Document SSH host key chec...

2018-07-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/89#discussion_r203227122 --- Diff: src/chapters/configuring.xml --- @@ -2746,6 +2798,22 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a

[GitHub] guacamole-manual pull request #89: GUACAMOLE-527: Document SSH host key chec...

2018-07-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/89#discussion_r202861420 --- Diff: src/chapters/configuring.xml --- @@ -2704,6 +2726,31 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a SSH support

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-07-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r202860705 --- Diff: src/chapters/adhoc-connections.xml --- @@ -0,0 +1,118 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-manual pull request #83: GUACAMOLE-446: Documentation for new driv...

2018-07-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/83#discussion_r200564634 --- Diff: src/chapters/configuring.xml --- @@ -2059,6 +2059,18 @@ guaclog: INFO: All files interpreted successfully

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199947992 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h --- @@ -74,23 +74,43 @@ struct guac_rdpdr_device { int device_id

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199947659 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -200,10 +180,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin* rdpdr

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199946899 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h --- @@ -74,23 +74,43 @@ struct guac_rdpdr_device { int device_id

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199946212 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h --- @@ -35,7 +35,7 @@ * Registers a new printer device within the RDPDR plugin

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199945754 --- Diff: src/protocols/rdp/compat/winpr-stream.h --- @@ -60,6 +60,7 @@ #define Stream_Buffer stream_get_head

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199685199 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -122,20 +124,28 @@ static void guac_rdpdr_send_client_capability

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199683587 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -122,20 +124,28 @@ static void guac_rdpdr_send_client_capability

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199681225 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -122,20 +124,28 @@ static void guac_rdpdr_send_client_capability

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199681190 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -138,10 +138,10 @@ static void

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199628303 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -165,9 +165,6 @@ static void guac_rdpdr_device_printer_iorequest_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199625976 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -128,6 +114,12 @@ static void guac_rdpdr_device_fs_iorequest_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199620515 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -200,10 +182,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin* rdpdr

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199616415 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -128,6 +114,12 @@ static void guac_rdpdr_device_fs_iorequest_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199615305 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -128,6 +114,12 @@ static void guac_rdpdr_device_fs_iorequest_handler

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-07-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r199621521 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c --- @@ -122,20 +124,28 @@ static void guac_rdpdr_send_client_capability

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198258868 --- Diff: guacamole/src/main/webapp/translations/en.json --- @@ -364,6 +364,7 @@ "FIELD_HEADER_SECURITY": &quo

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198257222 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/ssh.json --- @@ -12,6 +12,10

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198253892 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json --- @@ -329,6 +329,10 @@ "

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197972780 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,43 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197882935 --- Diff: src/common-ssh/common-ssh/key.h --- @@ -166,5 +169,52 @@ void guac_common_ssh_key_free(guac_common_ssh_key* key); int

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197881188 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,40 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197882126 --- Diff: src/common-ssh/key.c --- @@ -245,3 +246,86 @@ int guac_common_ssh_key_sign(guac_common_ssh_key* key, const char* data

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197707629 --- Diff: src/common-ssh/key.c --- @@ -245,3 +246,84 @@ int guac_common_ssh_key_sign(guac_common_ssh_key* key, const char* data

[GitHub] guacamole-client pull request #304: GUACAMOLE-580: Check for null when retri...

2018-06-23 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/304#discussion_r197604999 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -283,7

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-19 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196569580 --- Diff: guacamole/src/main/webapp/translations/fr.json --- @@ -624,7 +624,9 @@ "FORMAT_STAR

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196296995 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -312,6 +305,12 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196296859 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,25 +259,16 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196266846 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196264500 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196257189 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196234222 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection

[GitHub] guacamole-server pull request #173: GUACAMOLE-574: Allow input for SSH/telne...

2018-06-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/173#discussion_r196231052 --- Diff: src/terminal/terminal/terminal.h --- @@ -568,17 +576,97 @@ int guac_terminal_printf(guac_terminal* terminal, const char* format

[GitHub] guacamole-server pull request #173: GUACAMOLE-574: Allow input for SSH/telne...

2018-06-17 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/173 GUACAMOLE-574: Allow input for SSH/telnet to come from "STDIN" pipe. This change adds support to SSH and telnet for reading user input from a pipe stream named &qu

[GitHub] guacamole-server pull request #172: GUACAMOLE-573: Allow selection of text w...

2018-06-17 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/172 GUACAMOLE-573: Allow selection of text while scrolling. This change adds the ability to select text while scrolling Guacamole's terminal emulator. The current selection is preserved

Re: AWS Guacamole Peering

2018-06-13 Thread Mike Jumper
On Wed, Jun 13, 2018, 05:31 Naef Halabi wrote: > Hey, > > We have production environment on a Multi-region on AWS and we start to > use Guacamole Bastion Host AWS AMI. > > When I deploy the instance in the *same VPC* the auto discover working fine > and the Guacamole > find and connect the

[GitHub] guacamole-client pull request #302: GUACAMOLE-470: Provide predefined values...

2018-06-12 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/302 GUACAMOLE-470: Provide predefined values for "color-scheme" parameter. This change defines option semantics for `TEXT` fields using the [`` element](https://developer.mozi

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r194894400 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection

Re: Managing the SFTP dropped files

2018-06-11 Thread Mike Jumper
On Mon, Jun 11, 2018 at 10:41 AM, Tezarin wrote: > Thanks Mike, my mistake,I meant to say t he RDP users so the solution you > mentioned (docker volume) is exactly what I need. Do you happen to have a > tutorial on using the EBS or docker volume with Guacamole and also how to > make it

Re: Managing the SFTP dropped files

2018-06-11 Thread Mike Jumper
On Mon, Jun 11, 2018 at 10:25 AM, Tezarin wrote: > Thanks, but what about the Windows users? The guacamole containers are on > a linux based host (guacd and guacamole containers and external mysql vm). > The users transfer their files to their windows VMs via Guacamole. What > about those

Re: Managing the SFTP dropped files

2018-06-11 Thread Mike Jumper
On Mon, Jun 11, 2018, 10:04 Tezarin wrote: > Hi, > I have Guacamole configured to run inside docker and have SFTP setup for > all my user connections (SSH and SFTP) and I would like to make sure the > files which users dragged and dropped into their sessions don't just stay > on the guacamole or

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-06-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r194235574 --- Diff: src/chapters/quickconnect.xml --- @@ -0,0 +1,90 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-06-09 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r194235515 --- Diff: src/chapters/quickconnect.xml --- @@ -0,0 +1,90 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194158582 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Credentials.java --- @@ -72,6 +72,29 @@ */ private

Re: Decoration and Connection Parameters

2018-06-07 Thread Mike Jumper
On Thu, Jun 7, 2018 at 5:10 PM, Nick Couchman wrote: > Okay, question here about using the decoration feature of the extensions > and accessing parameters. I'm trying to write an extension that does both > the status checks and Wake-on-LAN on the hosts in each of the connections. > The

[GitHub] guacamole-server pull request #170: GUACAMOLE-570: Bump version number to 1....

2018-06-05 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/170 GUACAMOLE-570: Bump version number to 1.0.0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole-server bump

[GitHub] guacamole-client pull request #297: GUACAMOLE-570: Bump version numbers to 1...

2018-06-05 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/297 GUACAMOLE-570: Bump version numbers to 1.0.0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole-client bump

Re: 1.0.0 Release?

2018-06-02 Thread Mike Jumper
On Sat, Jun 2, 2018 at 8:07 AM, Nick Couchman wrote: >> >> No objections, so we'll call this good. We have 75 issues tagged for >>> 1.0.0, with 12 remaining to be closed out before the release. A handful of >>> these are just waiting on documentation, most of them in code review, and >>> then a

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191631978 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionMapper.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191607055 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java --- @@ -0,0 +1,110 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191607919 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionWrapper.java --- @@ -1,203 +0,0 @@ -/* - * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191607392 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTServiceModule.java --- @@ -83,11 +83,9 @@ protected void configureServlets

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191607105 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java --- @@ -0,0 +1,110 @@ +/* + * Licensed

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 12:07 PM, Nick Couchman wrote: > On Tue, May 29, 2018 at 2:59 PM, Nick Couchman wrote: > > > > > >> > > >> Perhaps the mapper needs to be bound, just like the webapp's REST > >> services? > >> > >> https://stackoverflow.com/questions/11987097/how-do-i- > >>

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 11:59 AM, Nick Couchman wrote: > > > > > > > > > > Perhaps the mapper needs to be bound, just like the webapp's REST > services? > > > > https://stackoverflow.com/questions/11987097/how-do-i- > > use-a-jersey-exceptionmapper-with-google-guice > > > > > Yep, that seems to

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 11:02 AM, Nick Couchman wrote: > > > > IIRC, there are minimum JVM version requirements for Jersey 2.x that > >> > > historically prevented us from going that route, but if we're going to > >> require Java 7 across the board, this is doable. > >> > > > > Okay, I'll see

Re: Connection list auto refresh issue

2018-05-28 Thread Mike Jumper
On Mon, May 28, 2018 at 5:24 PM, Junyao Deng wrote: > Hi Developers, > > > We are currently using the guacamole for remote desktop access > control(with LDAP Authentication). However, the current code has a problem > that the connection list on the guacamole home page(user's home page) will >

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-28 Thread Mike Jumper
On Mon, May 28, 2018 at 12:00 PM, Nick Couchman wrote: > Hey, everyone, > I could use some help figuring out how to work this one out. GUACAMOLE-566 > deals with adding the RESTExceptionWrapper to loaded extensions such that > the extension-specific REST endpoints will deliver similar Guacamole

<    1   2   3   4   5   6   7   8   >