[jira] [Created] (HIVE-19602) Refactor inplace progress code in Hive-on-spark progress monitor to use InplaceUpdate

Bharathkrishna Guruvayoor Murali created HIVE-19602: --- Summary: Refactor inplace progress code in Hive-on-spark progress monitor to use InplaceUpdate Key: HIVE-19602 URL: https

[jira] [Created] (HIVE-19942) Hive Notification: All events for indexes should have table name

Bharathkrishna Guruvayoor Murali created HIVE-19942: --- Summary: Hive Notification: All events for indexes should have table name Key: HIVE-19942 URL: https://issues.apache.org/jira/browse/HIVE

[jira] [Created] (HIVE-19925) NPE in SparkTask#printConsoleMetrics

Bharathkrishna Guruvayoor Murali created HIVE-19925: --- Summary: NPE in SparkTask#printConsoleMetrics Key: HIVE-19925 URL: https://issues.apache.org/jira/browse/HIVE-19925 Project

[jira] [Created] (HIVE-19766) Show the number of rows inserted when execution engine is Spark

Bharathkrishna Guruvayoor Murali created HIVE-19766: --- Summary: Show the number of rows inserted when execution engine is Spark Key: HIVE-19766 URL: https://issues.apache.org/jira/browse/HIVE

[jira] [Created] (HIVE-18972) beeline command suggestion to kill job deprecated

Bharathkrishna Guruvayoor Murali created HIVE-18972: --- Summary: beeline command suggestion to kill job deprecated Key: HIVE-18972 URL: https://issues.apache.org/jira/browse/HIVE-18972

Re: Need edit permission to Hive Confluence page

o edit > <https://cwiki.apache.org/confluence/display/Hive/AboutThisWiki#AboutThisWiki-Howtogetpermissiontoedit> > > > (It's okay to use the dev@hive list instead of user@hive, just tell us > your username in this thread.) > > -- Lefty > > > On Thu, Apr 5, 2018 a

[jira] [Created] (HIVE-19133) HS2 WebUI phase-wise performance metrics not showing correctly

Bharathkrishna Guruvayoor Murali created HIVE-19133: --- Summary: HS2 WebUI phase-wise performance metrics not showing correctly Key: HIVE-19133 URL: https://issues.apache.org/jira/browse/HIVE

Need edit permission to Hive Confluence page

Hi, I need edit permission to Confluence page. Currently I need to make a doc update related to HIVE-16944. I would like to update SchemaTool wiki page to include the parameters driver and URL which are currently missing in the

[jira] [Created] (HIVE-18981) Hive beeline ignores throwable

Bharathkrishna Guruvayoor Murali created HIVE-18981: --- Summary: Hive beeline ignores throwable Key: HIVE-18981 URL: https://issues.apache.org/jira/browse/HIVE-18981 Project: Hive

[jira] [Created] (HIVE-20601) EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener

Bharathkrishna Guruvayoor Murali created HIVE-20601: --- Summary: EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener Key: HIVE-20601 URL: https://issues.apache.org/jira

[jira] [Created] (HIVE-20610) TestDbNotificationListener should not use /tmp directory

Bharathkrishna Guruvayoor Murali created HIVE-20610: --- Summary: TestDbNotificationListener should not use /tmp directory Key: HIVE-20610 URL: https://issues.apache.org/jira/browse/HIVE-20610

[jira] [Created] (HIVE-21027) Add a configuration to include entire thrift objects in HMS notifications

Bharathkrishna Guruvayoor Murali created HIVE-21027: --- Summary: Add a configuration to include entire thrift objects in HMS notifications Key: HIVE-21027 URL: https://issues.apache.org/jira

[jira] [Created] (HIVE-20993) Update committer list

Bharathkrishna Guruvayoor Murali created HIVE-20993: --- Summary: Update committer list Key: HIVE-20993 URL: https://issues.apache.org/jira/browse/HIVE-20993 Project: Hive

[jira] [Created] (HIVE-20545) Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

Bharathkrishna Guruvayoor Murali created HIVE-20545: --- Summary: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications Key: HIVE-20545 URL

[jira] [Created] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

Bharathkrishna Guruvayoor Murali created HIVE-21526: --- Summary: JSONDropDatabaseMessage needs to have the full database object. Key: HIVE-21526 URL: https://issues.apache.org/jira/browse/HIVE

[jira] [Created] (HIVE-21205) Tests for replace flag in insert event messages in Metastore notifications.

Bharathkrishna Guruvayoor Murali created HIVE-21205: --- Summary: Tests for replace flag in insert event messages in Metastore notifications. Key: HIVE-21205 URL: https://issues.apache.org/jira

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

> On May 11, 2018, 8:51 p.m., Bharathkrishna Guruvayoor Murali wrote: > > Should I handle String inputs like 2018-05-10 12:20:10 to retain the time > > part. > > I did not do this because the inputs can have several formats if it is > > String (whereas time

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

> On May 11, 2018, 8:51 p.m., Bharathkrishna Guruvayoor Murali wrote: > > Should I handle String inputs like 2018-05-10 12:20:10 to retain the time > > part. > > I did not do this because the inputs can have several formats if it is > > String (whereas time

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

s.apache.org/r/66290/diff/10/ Changes: https://reviews.apache.org/r/66290/diff/9-10/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202625 --- On May 7, 2018, 5:58 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

nks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

e/service/cli/thrift/ThriftCLIService.java c64c99120ad21ee98af81ec6659a2722e3e1d1c7 Diff: https://reviews.apache.org/r/66290/diff/7/ Changes: https://reviews.apache.org/r/66290/diff/6-7/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

e/service/cli/thrift/ThriftCLIService.java c64c99120ad21ee98af81ec6659a2722e3e1d1c7 Diff: https://reviews.apache.org/r/66290/diff/8/ Changes: https://reviews.apache.org/r/66290/diff/7-8/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

/diff/8-9/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

, visit: https://reviews.apache.org/r/67073/#review202907 ------- On May 10, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically gener

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

al to keep it thread-safe. - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202942 --- On May 10, 2018, 9:55

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

the output to be in. If the parser fails, I can fallback to the default format. What are your thoughts on this. - Bharathkrishna Guruvayoor Murali On May 10, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

ise. - I converted the while loop to do-while in HiveStatement#waitForOperationToComplete, because otherwise some cases the response is never initialized. - Bharathkrishna Guruvayoor Murali On May 7, 2018, 5:58 p.m., Bharathkrishna Guruvayoor Mu

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

/diff/5-6/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

. Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review203208 ------- On May 16, 2018, 5:48 p.m., Bharathkrishna Guruvayoor Murali wrote: > >

Review Request 67263: HIVE-19602

7afd8864075aa0d9708274eea8839c662324c732 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/67263/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67263: HIVE-19602

krishna Guruvayoor Murali On May 23, 2018, 5:32 a.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 67263: HIVE-19602

-- Notice the bit of extra space at the end. But other than that, it looks pretty much same. - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203891

Re: Review Request 67263: HIVE-19602

Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203891 --- On May 23, 2018, 5:32 a.m., Bharathkrishna Guruvayo

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

://reviews.apache.org/r/67073/diff/1-2/ Testing --- Added unit tests. Thanks, Bharathkrishna Guruvayoor Murali

Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

/ThriftCLIService.java 68fe8d8aa143fafbfc611253ce3a12065016a537 Diff: https://reviews.apache.org/r/67636/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

(patched) <https://reviews.apache.org/r/67636/#comment287785> Added this condition because in the do-while loop, when this executes after the results are printed, the results get overwritten by progress bar. So if operation is complete, no need to update. - Bharathkrishna Guruvayoor

Re: Review Request 67263: HIVE-19602

Diff: https://reviews.apache.org/r/67263/diff/5/ Changes: https://reviews.apache.org/r/67263/diff/4-5/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

/RenderStrategy.java Lines 43 (patched) <https://reviews.apache.org/r/67636/#comment287903> The methods getReport, isSameAsPreviousProgress, printStatus are copied from existing. - Bharathkrishna Guruvayoor Murali On June 18, 2018, 8:41 p.m., Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

eviews.apache.org/r/67636/#review205020 --- On June 18, 2018, 8:41 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 67263: HIVE-19602

; > > > is this still used? > > Bharathkrishna Guruvayoor Murali wrote: > Will remove this if we do not need to pass the headers , footers etc.. to > ProgressMonitor. > (ie. if the progress bar format shown in below comment is acceptable). > > Sahil Takiar wrote: >

Re: Review Request 67263: HIVE-19602

: https://reviews.apache.org/r/67263/diff/1-2/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67263: HIVE-19602

/67263/diff/4/ Changes: https://reviews.apache.org/r/67263/diff/3-4/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67263: HIVE-19602

--- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67263: HIVE-19602

> whats the point of this class? > > Bharathkrishna Guruvayoor Murali wrote: > I used this class to follow same pattern as in tez. I will add the logic > similar to RenderStrategy used in tez while adding beeline progress bar, so > this should be useful. > &g

Review Request 67415: HIVE-19525 : Spark task logs print PLAN PATH excessive number of times

/hadoop/hive/ql/exec/Utilities.java 406bea011da83aee55f385029a4df1af94400e4c Diff: https://reviews.apache.org/r/67415/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

nitor#updateFunction and SessionState.get().isHiveServerQuery() was getting NPE. - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67636/#review205203 ---------

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

://reviews.apache.org/r/67636/diff/2-3/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

68fe8d8aa143fafbfc611253ce3a12065016a537 Diff: https://reviews.apache.org/r/67636/diff/2/ Changes: https://reviews.apache.org/r/67636/diff/1-2/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67636: HIVE-19176 : Add HoS support to progress bar on Beeline client.

thkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67636/#review205020 --- On June 21, 2018, 3:50 p.m., Bharathkrishna Guruvayoor Mur

Re: Review Request 67815: HIVE-19733 : RemoteSparkJobStatus#getSparkStageProgress inefficient implementation

/ Changes: https://reviews.apache.org/r/67815/diff/2-3/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67815: HIVE-19733 : RemoteSparkJobStatus#getSparkStageProgress inefficient implementation

Diff: https://reviews.apache.org/r/67815/diff/2/ Changes: https://reviews.apache.org/r/67815/diff/1-2/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 67815: HIVE-19733 : RemoteSparkJobStatus#getSparkStageProgress inefficient implementation

/RemoteSparkJobStatus.java Line 194 (original), 197 (patched) <https://reviews.apache.org/r/67815/#comment288719> So should I make the exception messages generic to both the methods that can call getSparkJobInfo() ? - Bharathkrishna Guruvayoor Murali On July 5, 2018, 7:34 p.m., Bharathk

Review Request 67815: HIVE-19733 : RemoteSparkJobStatus#getSparkStageProgress inefficient implementation

/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

nks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review201637 ----------- On April 18, 2018, 11:53 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

ble to behave differently, when we have information about > > the number of rows, and when we do not know anything? The returned number > > will be 0 in this case, which might cause interesting behavior I guess :) > > Bharathkrishna Guruvayoor Murali wrote: > This is called o

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

0b3e4edb52d9de85b3cc25f269 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3706c72abc77ac8bd77947cc1c5d084ddf965e9f > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > c64c99120ad21ee98af81ec6659a2722e3e1d1c7 > > > Diff: https://reviews.apache.org/r/66290/diff/2/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

0b3e4edb52d9de85b3cc25f269 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3706c72abc77ac8bd77947cc1c5d084ddf965e9f > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > c64c99120ad21ee98af81ec6659a2722e3e1d1c7 > > > Diff: https://reviews.apache.org/r/66290/diff/2/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

aea2401737 > service/src/java/org/apache/hive/service/cli/CLIService.java > c9914ba9bf8653cbcbca7d6612e98a64058c0fcc > service/src/java/org/apache/hive/service/cli/OperationStatus.java > 52cc3ae4f26b990b3e4edb52d9de85b3cc25f269 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 3706c72abc77ac8bd77947cc1c5d084ddf965e9f > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > c64c99120ad21ee98af81ec6659a2722e3e1d1c7 > > > Diff: https://reviews.apache.org/r/66290/diff/1/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

nks, Bharathkrishna Guruvayoor Murali

Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

nks, Bharathkrishna Guruvayoor Murali

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

ble to behave differently, when we have information about > > the number of rows, and when we do not know anything? The returned number > > will be 0 in this case, which might cause interesting behavior I guess :) > > Bharathkrishna Guruvayoor Murali wrote: > This is called o

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

--- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

89702fab0cb77 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > cb5bd7ada2d5ad4f1f654cf80ddaf4504be5d035 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java > 20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 > > > Diff: https://reviews.apache.org/r/69107/diff/1/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 69107: HIVE-20512

able atomic as well? - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209935 --- On Oct. 20, 2018, 7:13 p.m.,

Re: Review Request 69107: HIVE-20512

/69107/diff/1-2/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

a Line 116 (original), 113 (patched) <https://reviews.apache.org/r/69107/#comment294629> Using shutDownNow instead of shutDown to cancel pending tasks - Bharathkrishna Guruvayoor Murali On Oct. 24, 2018, 8:55 p.m., Bharathkrishna Guruvayoor

Re: Review Request 69107: HIVE-20512

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209950 ------- On Oct. 24, 2018, 8:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > > -

Re: Review Request 69107: HIVE-20512

is why it is probably done in such a way to increment row count by 1 itself. - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review210230 ---------

Re: Review Request 69107: HIVE-20512

20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 Diff: https://reviews.apache.org/r/69107/diff/4/ Changes: https://reviews.apache.org/r/69107/diff/3-4/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

/SparkReduceRecordHandler.java 20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 Diff: https://reviews.apache.org/r/69107/diff/3/ Changes: https://reviews.apache.org/r/69107/diff/2-3/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Review Request 69107: HIVE-20512

20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 Diff: https://reviews.apache.org/r/69107/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 Diff: https://reviews.apache.org/r/69107/diff/6/ Changes: https://reviews.apache.org/r/69107/diff/5-6/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

, Bharathkrishna Guruvayoor Murali

Re: Review Request 69107: HIVE-20512

Guruvayoor Murali

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 82429e36a575918d92a9b22bedcd63788ec51c5f Diff: https://reviews.apache.org/r/68889/diff/4/ Changes: https://reviews.apache.org/r/68889/diff/3-4/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

: https://reviews.apache.org/r/68889/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68889/#review209131 --- On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > &g

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

--- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

/TestDbNotificationListener.java 82429e36a575918d92a9b22bedcd63788ec51c5f Diff: https://reviews.apache.org/r/68889/diff/3/ Changes: https://reviews.apache.org/r/68889/diff/2-3/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

o.tmpdir when it is being used somewhere (if at all that's possible). - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68889/#review209167 -----------

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java 30de1c4cfa1cf019186b10583a06da0bf5491634 Diff: https://reviews.apache.org/r/68827/diff/2/ Changes: https://reviews.apache.org/r/68827/diff/1-2/ Testing --- Thanks, Bharathkrishna Guruvayoor

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java > 30de1c4cfa1cf019186b10583a06da0bf5491634 > > > Diff: https://reviews.apache.org/r/68827/diff/2/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

nce, the predicates become an empty List. What can I do if needed to add a test for this. - Bharathkrishna ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209055 -

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

r method which accepts a list of predicates and make this one private? - Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209031 ------------

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

ly, visit: https://reviews.apache.org/r/68827/#review209055 --- On Sept. 28, 2018, 9:38 a.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically generated e

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

/JSONMessageFactory.java 2668b05320 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/68827/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

line918> > > > > You already have this check when you call this function. > > Bharathkrishna Guruvayoor Murali wrote: > I thought this could be used separately as a utility method, if the user > has just one predicate. Should I just keep the other method whic

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

://reviews.apache.org/r/68827/diff/5/ Changes: https://reviews.apache.org/r/68827/diff/4-5/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

va/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java > 30de1c4cfa1cf019186b10583a06da0bf5491634 > > > Diff: https://reviews.apache.org/r/68827/diff/4/ > > > Testing > --- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >

Re: Review Request 68828: HIVE-20601 : EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener

-------- On Sept. 24, 2018, 8:42 p.m., Bharathkrishna Guruvayoor Murali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68828/ > -

Review Request 68827: Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

/metastore/messaging/json/JSONMessageFactory.java 2668b05320 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/68827/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Review Request 68828: HIVE-20601 : EnvironmentContext null in ALTER_PARTITION event in DbNotificationListener

f52ff91a8f2e7710801dcadc4a83ce454992a66a Diff: https://reviews.apache.org/r/68828/diff/1/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

/ Changes: https://reviews.apache.org/r/68827/diff/2-3/ Testing --- Thanks, Bharathkrishna Guruvayoor Murali

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

/src/main/thrift/hive_metastore.thrift Lines 346 (patched) <https://reviews.apache.org/r/69664/#comment297546> nit : you can add the same comment added in the DB part. // creation time of catalog in seconds since epoch - Bharathkrishna Guruvayoor Murali On Jan. 9, 2019, 6:50 p.m.,

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

this mean that all the alters happen in one transaction? Will it prevent concurrent operations for the whole time a large number of partitions are altered? - Bharathkrishna Guruvayoor Murali On Nov. 30, 2018, 11:31 a.m., Laszlo Pinter wrote