Review Request 62915: HIVE-17534 : Add a config to turn off parquet vectorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62915/ --- Review request for hive, Matt McCline and Sergey Shelukhin. Repository:

Re: Review Request 62995: HIVE-17806 Create directory for metrics file if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62995/#review188416 ---

Re: Review Request 62995: HIVE-17806: Create directory for metrics file if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62995/#review188551 --- Ship it! Ship It! - Vihang Karajgaonkar On Oct. 18, 2017,

Re: Review Request 62995: HIVE-17806 Create directory for metrics file if it doesn't exist

> On Oct. 17, 2017, 11:21 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java > > Lines 119 (patched) > > > > > > I think it is better to

Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63711/#review191092 --- Thanks for the patch Ferdinand. Just one comment below, rest of

Re: Review Request 63806: HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63806/ --- (Updated Nov. 15, 2017, 10:50 p.m.) Review request for hive, Aihua Xu and Matt

Review Request 63806: HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: divide by zero

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63806/ --- Review request for hive, Aihua Xu and Matt McCline. Bugs: HIVE-16756

Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63711/#review191195 --- Ship it! Ship It! - Vihang Karajgaonkar On Nov. 15, 2017,

Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

> On Nov. 15, 2017, 8:44 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/results/clientpositive/llap/sysdb.q.out > > Lines 2236 (patched) > > > > > > not sure why this file is changing. Do you know? > > cheng xu

Re: Review Request 63806: HIVE-16756 : Vectorization: LongColModuloLongColumn throws java.lang.ArithmeticException: / by zero

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63806/ --- (Updated Nov. 16, 2017, 5:21 a.m.) Review request for hive, Aihua Xu and Matt

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63528/#review190193 ---

Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190457 --- Ship it! LGTM. Thanks for the changes!

Re: Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66979/#review202679 --- Overall looks good. Would be great if we could have a junit test

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/#review203055 --- Fix it, then Ship it! LGTM. Thanks for making this change.

Re: Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66979/#review202771 --- Fix it, then Ship it! LGTM. Thanks for the changes.

Review Request 67074: HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67074/ --- Review request for hive and Matt McCline. Bugs: HIVE-19493

Re: Review Request 67074: HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67074/ --- (Updated May 11, 2018, 12:05 a.m.) Review request for hive and Matt McCline.

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 14, 2018, 7:07 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2545 (patched) > > > > > > Why not LOG.error? > >

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/#review204697 --- Ship it! Ship It! - Vihang Karajgaonkar On June 6, 2018,

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review204700 ---

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/#review204139 --- Thanks for the tests. Can we add a one more test which repeats

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/#review204195 --- Ship it! Thanks for the changes. LGTM - Vihang Karajgaonkar

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/#review204262 ---

Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

> On May 2, 2018, 5:49 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb > > Lines 1071 (patched) > > > > > > Is it possible to write a test to make sure this

Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66890/#review202309 --- Ship it! - Vihang Karajgaonkar On May 1, 2018, 8:30 p.m.,

Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66890/#review202291 ---

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 52 (patched) > > > > > > Parameterized tests don't

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195158 --- Fix it, then Ship it! Overall looks good. Thanks for taking

Re: Review Request 65330: HIVE-18526 Backport HIVE-16886 to Hive 2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65330/#review196365 ---

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/#review195114 ---

Review Request 65132: HIVE-18422 : Vectorized input format should not be used when input format is excluded and row.serde is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65132/ --- Review request for hive and Matt McCline. Repository: hive-git Description

Review Request 65500: Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- Review request for hive, Aihua Xu, Gopal V, Matt McCline, and Sahil Takiar.

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196718 ---

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 12:49 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 12:17 a.m., Sahil Takiar wrote: > > ql/src/gen/vectorization/TestTemplates/TestClass.txt > > Lines 27 (patched) > > > > > > is this necessary? yes, this is needed since this template is used to

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 7:13 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 2:40 a.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModLongToLong.java > > Lines 46-48 (patched) > > > > > > is there a way to do this check just

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review197313 --- Fix it, then Ship it! Overall the patch looks good to me. Some

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 13, 2018, 12:50 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java > > Lines 253-254 (original), 255-256 (patched) > > > > > >

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 8, 2018, 3:51 a.m., Aihua Xu wrote: > > ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt > > Lines 131 (patched) > > > > > > Can we remove #ELSE from here and some other places

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review197464 --- Ship it! Thanks for the changes Ferdinand. Patch looks good to

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196867 ---

Re: Review Request 65500: Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 5, 2018, 8:54 p.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65746: HIVE-18768: Use Datanucleus to serialize notification updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65746/#review198134 --- Ship it! Patch LGTM - Vihang Karajgaonkar On Feb. 22, 2018,

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review205084 --- Fix it, then Ship it! Thanks a lot for the changes. Mostly

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67954/#review207090 --- Ship it! Ship It! - Vihang Karajgaonkar On Aug. 9, 2018,

Re: Review Request 68351: HIVE-20388: Move common classes out of metastore-server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68351/#review207286 --- I think the DelegationToken* classes should be in the server

Re: Review Request 68351: HIVE-20388: Move common classes out of metastore-server

> On Aug. 15, 2018, 1:12 a.m., Vihang Karajgaonkar wrote: > > I think the DelegationToken* classes should be in the server module. For > > the method in SecurityUtils to get the name of TokenStore classes, we can > > keep it in MetastoreServerUtils class since I don't think it will be needed

Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- Review request for hive, Alexander Kolbasov and Peter Vary. Bugs: HIVE-20306

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 23, 2018, 6:44 p.m.) Review request for hive, Alexander

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > > Lines 1646 (patched) > > > > > > does this allow for x.y.z? > > Does

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 23, 2018, 8:06 p.m.) Review request for hive, Alexander

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 852 (patched) > > > > > > Does

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 24, 2018, 6:15 p.m.) Review request for hive, Alexander

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 21, 2018, 6:50 p.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

> On Aug. 24, 2018, 11:19 p.m., Aihua Xu wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 376 (original), 416 (patched) > > > > > > Why

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 25, 2018, 12:23 a.m.) Review request for hive, Alexander

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

> On Aug. 27, 2018, 4:42 p.m., Aihua Xu wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java > > Line 200 (original), 200 (patched) > > > >

Re: Review Request 68395: HIVE-20306 : Implement projection spec for fetching only requested fields from partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68395/ --- (Updated Aug. 27, 2018, 10:33 p.m.) Review request for hive, Alexander

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67954/#review206230 ---

Re: Review Request 66068: [HIVE-16882] Improvements For Avro SerDe Package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66068/#review199185 --- Fix it, then Ship it! LGTM

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

> On March 29, 2018, 11:32 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParser.java > > Lines 79 (patched) > > > > > > Most of the code in this file is

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66185/#review200215 ---

Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66288/ --- Review request for hive and Alexander Kolbasov. Repository: hive-git

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review200405 --- Fix it, then Ship it! LGTM. Just one minor comment below.

Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66288/ --- (Updated March 26, 2018, 10:14 p.m.) Review request for hive and Alexander

Re: Review Request 66185: JDBC: Provide an option to simplify beeline usage by supporting default and named URL for beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66185/#review199770 --- I am a bit confused here. If the full url can be provided in the

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Oct. 16, 2018, 10:47 p.m.) Review request for hive, Andrew Sherman,

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > > > > > What is someone has

Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. Bugs:

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > >

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Oct. 19, 2018, 8:54 p.m.) Review request for hive, Andrew Sherman,

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Nov. 1, 2018, 8:48 p.m.) Review request for hive, Andrew Sherman,

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > >

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote: > > All looks good, just a few nits which I noticed Unfortunately, I cannot update this review board URL since its owned by Alexander. Latest patch on the JIRA has the suggested changes. Will see if I can update the diffs here somehow. >

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java > > Lines 38 (patched) > > > > >

Review Request 68969: HIVE-20307 : Add support for filterspec to the getPartitions with projection API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68969/ --- Review request for hive, Alexander Kolbasov and Andrew Sherman. Bugs:

Re: Review Request 68969: HIVE-20307 : Add support for filterspec to the getPartitions with projection API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68969/ --- (Updated Oct. 9, 2018, 9:23 p.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 5, 2019, 2:54 a.m.) Review request for hive, Karthik Manamcheri,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review212147 --- Fix it, then Ship it! Overall the patch looks good. I have

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 15, 2019, midnight) Review request for hive, Karthik Manamcheri,

Re: Review Request 69550: Add credential store env properties redaction in JobConf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/#review211199 --- common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211367 --- Fix it, then Ship it! Thanks for the changes. Couple of minor

Re: Review Request 69550: Add credential store env properties redaction in JobConf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/#review211205 --- Ship it! Ship It! - Vihang Karajgaonkar On Dec. 11, 2018,

Re: Review Request 69550: Add credential store env properties redaction in JobConf

> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > > Lines 217 (patched) > > > > > > Do we need to do redact for the Spark config as well? >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211343 ---

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Nov. 27, 2018, 10:55 p.m., Naveen Gangam wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > > Lines 162 (patched) > > > > > >

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Nov. 27, 2018, 7:18 a.m.) Review request for hive, Andrew Sherman,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211768 --- Thanks for the patch. Do we really need to introduce

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

> On Jan. 7, 2019, 8:28 p.m., Adam Holley wrote: > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java > > Lines 137 (patched) > > > > > > nit:

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 9, 2019, 1:01 a.m.) Review request for hive, Karthik Manamcheri,

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 7, 2019, 7:16 p.m.) Review request for hive, Karthik Manamcheri,

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > > > Karthik Manamcheri wrote: > 1. While we are at it, can we make sure that the "create time" exists for > everything else (if required)? Such as catalog, partitions.. > 2. Out of curiosity.. are there any tests to ensure

Re: Review Request 69664: HIVE-21077 : Database should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > > > Karthik Manamcheri wrote: > 1. While we are at it, can we make sure that the "create time" exists for > everything else (if required)? Such as catalog, partitions.. > 2. Out of curiosity.. are there any tests to ensure

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211843 --- Fix it, then Ship it!

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- (Updated Jan. 9, 2019, 6:50 p.m.) Review request for hive, Karthik Manamcheri,

Review Request 69664: HIVE-21077 : Database should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/ --- Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212345 --- Fix it, then Ship it! Some minor comments related to logs.