--On Thursday, November 13, 2003 11:01 AM -0800 Stas Bekman [EMAIL PROTECTED]
wrote:
Should we add an explicit explanation to AP_MODE_READBYTES: return at most
readbytes data. Can't return 0 with APR_BLOCK_READ. Can't return more than
readbytes data.
I'd say the first and last one are equivalent
--On Thursday, November 13, 2003 1:51 PM -0500 Jim Jagielski [EMAIL PROTECTED]
wrote:
I'm confused then... I had thought that there were API differences
(within httpd and apr) between the 2 trees in able to support
some of the new features.
I suspect that the biggest pain for a 2.0-2.2 migration
--On Sunday, November 16, 2003 4:04 PM -0500 Glenn
[EMAIL PROTECTED] wrote:
On Sun, Nov 16, 2003 at 03:46:26PM -0500, Jim Jagielski wrote:
Why 1.4? What will 1.4 have that 1.3 does not? Or do you mean
reopening 1.3 implies that it becomes 1.4?
Only semantics. .4 is even, so stable; .5 is
--On Sunday, November 16, 2003 5:20 PM -0400 Marc G. Fournier
[EMAIL PROTECTED] wrote:
On FreeBSD 4.X it is broken(and will be forever?). On FreeBSD 5.X, use KSE
threading (which may become the default in the future 5.2 release anyways?)
and it works great. man libmap.conf on a FreeBSD box for
--On Thursday, November 20, 2003 2:36 PM +0100 Henri Gomez [EMAIL PROTECTED]
wrote:
Did someone succeed to build 2.0.48 on MacOS X 10.3 (Jaguar) ?
...
ld: warning multiple definitions of symbol _regcomp
/Users/hgo/httpd-2.0.48/srclib/pcre/.libs/libpcre.al(pcreposix.lo)
definition of _regcomp in
--On Wednesday, November 26, 2003 15:51:23 -0500 Christopher Jastram
[EMAIL PROTECTED] wrote:
My boss found subversion+webdav, and wants it implemented for use with
Adobe FrameMaker. So, I need dav_lock (without it, framemaker can load
from dav, but cannot checkin or checkout).
FWIW, that
--On Thursday, November 27, 2003 11:27 PM -0500 [EMAIL PROTECTED] wrote:
That is a good idea, but there has to be a way to debug things in their
current state. Since this is the configuration that causes Apache to
No, there's not. It's a problem with Linux not httpd.
SEGFAULT, I would like to
Hi all,
I've tweaked cvs.apache.org's snapshot scripts to include branches. This
means that 2.0 snapshots (APACHE_2_0_BRANCH) will be generated alongside the
2.1 snapshots (HEAD).
http://cvs.apache.org/snapshots/httpd-2.0/
Enjoy! -- justin
--On Saturday, November 29, 2003 10:39 PM +0100 Astrid Keßler
[EMAIL PROTECTED] wrote:
Ehm, would you mind to do the same for the httpd-docs-2.0 snapshot?
Done. Should be available on the next snapshot (roughly every 6 hours).
Yell if it doesn't work. -- justin
--On Saturday, November 29, 2003 11:38 PM +0100 Günter Knauf [EMAIL PROTECTED]
wrote:
But since HEAD is 2.1 I would prefer you rename the HEAD snapshots
httpd-2.1_xxx and put them into http://cvs.apache.org/snapshots/httpd-2.1/
and the APACHE_2_0_BRANCH named as httpd-2.0_xxx in
--On Saturday, November 29, 2003 10:15 PM -0800 Blair Zajac
[EMAIL PROTECTED] wrote:
Won't doing something like this work on Linux?
...
There's a similar call to prctl(PR_SET_DUMPABLE, 1) in the http
2.0 tree.
From talking with Jeff at AC, it sounded like recent versions of the Linux
kernel
--On Tuesday, December 02, 2003 14:11:20 + [EMAIL PROTECTED] wrote:
jorton 2003/12/02 06:11:20
Modified:.Tag: APACHE_2_0_BRANCH CHANGES STATUS
modules/ssl Tag: APACHE_2_0_BRANCH ssl_engine_init.c
ssl_engine_log.c
Log:
Backport
--On Thursday, December 18, 2003 4:57 AM -0800 Dirk-Willem van Gulik
[EMAIL PROTECTED] wrote:
Does our 2.0 ./configure check (or know) in any way
the version (range/minumum) of APR it expects to be
in place ? Or are there fundamental reasons why this
is not possible ?
I don't believe anyone has
--On Tuesday, December 23, 2003 2:59 PM + [EMAIL PROTECTED] wrote:
+ PR 24469, broken reverse lookups with IPv4-mapped addrs on old OS X
+The autoconf check added between 2.0.47 and 2.0.48 isn't
+sufficient for catching the OS X problem, because building the
+IPv4 numeric
--On Saturday, December 27, 2003 7:51 AM -0500 Jeff Trawick
[EMAIL PROTECTED] wrote:
Happy holidays!!!
A good way to end the year by closing as many backports as possible. ;-)
@@ -209,7 +185,8 @@
modules/generators/mod_cgid.c r1.152, r1.161
server/mpm_common.c r1.111
--On Tuesday, December 30, 2003 3:41 PM + Ben Laurie [EMAIL PROTECTED]
wrote:
For review - or shall I just commit?
I'd say commit to HEAD (aka 2.1) right now. We can deal with merging back
into 2.0 once it has the 3 +1s (which imply it has been reviewed)... -- justin
--On Wednesday, January 28, 2004 1:15 AM +0100 André Malo [EMAIL PROTECTED]
wrote:
I've uploaded the module here: http://cvs.apache.org/~nd/mod_version.c.
The are some more detailed descriptions at the beginning of the file
after the license.
What do you think?
+1 (concept). -- justin
--On Wednesday, January 28, 2004 8:48 PM -0500 Geoffrey Young
[EMAIL PROTECTED] wrote:
does anyone have any objections to applying this in 2.1?
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22299
+1. -- justin
--On Friday, January 30, 2004 2:48 PM -0500 Geoffrey Young
[EMAIL PROTECTED] wrote:
hi all...
hopefully I followed protocol here correctly wrt 2.1, but someone please
feel free to set me straight if I didn't.
I also closed the PR.
That's fine. The only comment I have is that you should commit
--On Friday, February 6, 2004 9:48 PM + [EMAIL PROTECTED] wrote:
nd 2004/02/06 13:48:40
Modified:.LICENSE buildconf
Added: .NOTICE
Log:
begin relicensing httpd-2.1 to Apache License, Version 2.0
Revision ChangesPath
1.10 +12 -56
--On Friday, February 6, 2004 10:55 PM +0100 André Malo [EMAIL PROTECTED]
wrote:
Doh! I'll fix it :-)
Thanks, nd
Thank *you* for taking this on! ;-) -- justin
--On Sunday, February 8, 2004 5:27 PM + Joe Orton [EMAIL PROTECTED]
wrote:
This adds a finish_connection hook as discussed with Madhu, and uses it
in mod_ssl to ensure that the SSL close_notify alert is sent before the
connection is closed. Any comments?
Would an EOS sent to the output
--On Wednesday, February 18, 2004 9:55 PM +0100 Sander Striker
[EMAIL PROTECTED] wrote:
We need to take care of mod_mbox and mod_pop3 aswell.
Any takers? ;)
Personally, I think that if we ever 'officially' release those modules, we
can relicense them at that time. -- justin
--On Thursday, February 19, 2004 12:18 PM -0500 Geoffrey Young
[EMAIL PROTECTED] wrote:
yeah, that would certainly be a good idea. give the attached patches a
whirl and see if they work for you. feedback from justin or others that
are familiar appreciated :)
Looks fine here. ;-) Thanks! --
--On Friday, February 20, 2004 8:09 PM + Patrick Welche
[EMAIL PROTECTED] wrote:
Just an off-the-cuff remark: How does this tie in with say SASL
(old page at: http://asg.web.cmu.edu/sasl/) ?
(vision of mod_sasl, then plug in any old authentication method
into that)
SASL is more generic than
--On Tuesday, February 24, 2004 4:49 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
... brings up the question : do you still want the finish_connection hook OR
should the modules be content with the EOC bucket ?
I don't think we'd need a new hook. -- justin
--On Tuesday, February 24, 2004 5:26 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
Here's the new patch incorporating the feedback.
Comments inline.
One thing that I'd like feedback : The eoc bucket is inserted by the
ap_end_connection() function(in server/connection.c) - and deleted
--On Wednesday, February 25, 2004 1:20 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
Hooking the cleanups to the connection pool may be a little too late for
some modules (Example SSL shutdown/SSL Alert). For filters like SSL, the EOC
logic would probably be just fine - I can't think
--On Thursday, February 26, 2004 11:58 AM + Joe Orton [EMAIL PROTECTED]
wrote:
On Wed, Feb 25, 2004 at 05:12:33PM -0800, Mathihalli, Madhusudan wrote:
More feedback incorporated !
ap_flush_conn can just use a single brigade with two buckets, no extra
variables needed there, also needs
--On Thursday, February 26, 2004 10:17 AM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
ap_flush_conn can just use a single brigade with two buckets, no extra
variables needed there,
Hmmn.. will that not introduce a mem leak ?
I don't think so. Why do you think so? -- justin
--On Friday, February 27, 2004 6:01 AM -0500 Jeff Trawick
[EMAIL PROTECTED] wrote:
Is it reasonable to commit the piped logger stuff without the
Win32/BeOS/OS/2 support? I think yes, even though that will result in
crashing piped loggers not being restarted on those platforms until the
platform
--On Saturday, February 28, 2004 10:05 PM -0400 Marc G. Fournier
[EMAIL PROTECTED] wrote:
Someone mentioned to me once that there is an easy/consistent way to
trigger the thread bug where you have 2+ workers in operation ...
Can someone send me a how to on this?
Just issue two GET requests
--On Sunday, February 29, 2004 12:29 PM -0400 Marc G. Fournier
[EMAIL PROTECTED] wrote:
'k, how do you manage 'simultaneously? I tried using http_load with -rate
set to 10, and couldn't lock it up, and its supposed to start up 10
connections per sec, if I read the docs right ...
You probably
--On Sunday, February 29, 2004 4:06 PM -0400 Marc G. Fournier
[EMAIL PROTECTED] wrote:
k, if I'm understanding what you are saying, how do you test something
like that in a way that you can debug it? What I'm reading is that if I
sent two queries (GET / and, say, GET /subdir), there is a chance
--On Sunday, February 29, 2004 10:11 AM -0300 Esteban Pizzini
[EMAIL PROTECTED] wrote:
How can I get the value of httpd.conf -- Pidfile directive from a
module???
I've been looking in mod_info, but it implements a cycle reading all
directives (and there gets PidFile value to show).. is there
--On Monday, March 1, 2004 8:18 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
It'd be very helpful if Apache provided methods to query various in and out
stream processing events to make filters more efficient. The events I can
think at the moment are:
...
- end of HTTP input headers
I'm not sure
--On Monday, March 1, 2004 8:18 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
Answering my own question, the solution is to use conn-keepalives counter
which is incremented at the end of each request. By storing the previous
count and comparing with the current count one can tell when a new
--On Monday, March 1, 2004 9:55 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
I see that with a non-broken handler which sends the response body
unconditionally. The output I've posted in my original email is all that's
seen by an output connection filter.
Why is ap_finalize_request_protocol not
--On Monday, March 1, 2004 11:37 AM -0400 Marc G. Fournier [EMAIL PROTECTED]
wrote:
so I've effectively 'pounded' the server, followed by a telnet session to
the same server doing a 'GET /' and it returned right away:
See below, I think you only have one worker process running. You need
--On Tuesday, March 2, 2004 11:47 AM -0400 Marc G. Fournier
[EMAIL PROTECTED] wrote:
Note that *BSD is looking at a 4.10 RSN, and I'm trying to fight for
trying to get this fixed, if its possible, which is why I'm trying to come
up with some data to fight with ...
Is there anywhere that there is
--On Monday, March 1, 2004 11:57 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
AP_FTYPE_PROTOCOL. But what difference does it make as long as it sees the
HTTP headers?
Because AP_FTYPE_PROTOCOL is request-level when you are using HTTP.
But, you should not be changing HTTP headers in a filter.
--On Monday, March 1, 2004 11:20 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
I've stepped through with gdb, ap_finalize_request_protocol is called and
EOS is sent, but it gets lost and doesn't reach the connection output filter.
That'd mean that a filter isn't passing it on as it should be.
--On Monday, March 1, 2004 10:58 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote:
An EOS *is* generated for this.
It does in the request filter (in and out).
It does in the connection output filter.
It does *not* in the connection input filter.
Correct. Because the EOS is generated by the
--On Tuesday, March 2, 2004 8:55 PM +0100 Henri Gomez [EMAIL PROTECTED]
wrote:
What do you think of it ?
MIDDLE or FIRST but after mod_rewrite ?
All told, I think FIRST but after mod_rewrite (which is also a FIRST hook) is
okay. This would likely make mod_jk be the second hook to run.
--On Wednesday, March 3, 2004 10:16 AM +0100 jean-frederic clere
[EMAIL PROTECTED] wrote:
MIDDLE helps to fix 21546... But I do not see why ;-(
Oh, *now* I understand the context to Henri's question. Here's a suggestion.
And, no, I don't think changing the priority to MIDDLE (or LAST) will
--On Wednesday, March 3, 2004 7:26 AM -0500 Jeff Trawick
[EMAIL PROTECTED] wrote:
I can go either way on whether or not we attempt to raise the soft limit to
a *non-zero* hard limit when CoreDumpDirectory is specified.
Any other opinions?
Raising to the hard limit seems perfectly reasonable. --
--On Wednesday, March 3, 2004 3:04 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
+/* support for ssl_var_lookup() */
+APR_DECLARE_OPTIONAL_FN(char *, ssl_var_lookup,
+(apr_pool_t *, server_rec *,
+ conn_rec *, request_rec *,
+
--On Wednesday, March 3, 2004 4:24 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
I thought it'll be a little too much :) What if I don't compile with
mod_ssl - I'll have a whole bunch of declarations with no definitions
associated with it. Besides, mod_proxy.c follows the same logic.
--On Friday, March 5, 2004 12:20 AM -0600 William A. Rowe, Jr.
[EMAIL PROTECTED] wrote:
But I have a better proposal - let us simply move back the entire mod_ssl 2.1
back to 2.0. Only binary compat issues would need review. But too many
good things have happened on 2.1 to this specific
--On Wednesday, March 3, 2004 12:24 PM +0100 Henri Gomez [EMAIL PROTECTED]
wrote:
To resume you :
- remove translate
- move translate code to map_storage
Did I understand correctly ?
Yes, I think that'll work. -- justin
--On Sunday, March 7, 2004 4:50 PM -0400 Marc G. Fournier [EMAIL PROTECTED]
wrote:
Now, from the way that Justin explains it, its possible that the hits are
continous enough not to exhibit the problem?
Correct. As long as there is traffic on the server, it'll appear to function.
However, the
--On Friday, March 5, 2004 9:25 AM +0100 Sander Striker [EMAIL PROTECTED]
wrote:
It's been a while since last release. I'd like to volunteer for
the RM task for 2.0.49, starting the release cycle Monday.
Thoughts?
+1.
If Sander doesn't get around to it by say 3PM PST (~6 hours from now), I'll
--On Tuesday, March 9, 2004 2:13 AM +0100 Sander Striker [EMAIL PROTECTED]
wrote:
http://httpd.apache.org/dev/dist is where the tarballs of RC 1 reside.
Please test and provide feedback.
+1 for GA.
Passes httpd-test on Solaris with the following caveats/bugs in httpd-test:
- SSL tests were
--On Sunday, March 7, 2004 6:28 PM -0400 Marc G. Fournier [EMAIL PROTECTED]
wrote:
'k, then this is probably why I can't recreate it, since the
ads.postgresql.org stuff itself keeps the hits pretty continous ...
Yup. FWIW, I just tested against -STABLE as of Mar 11th (Brian just upgraded
--On Saturday, March 13, 2004 2:04 PM +0100 Sander Striker
[EMAIL PROTECTED] wrote:
I hereby would like to propose that we move the HTTP Server project
codebase to the Subversion repository at:
http://svn.apache.org/repos/asf/.
+1. -- justin
This morning, when we did a graceful to the httpd serving cvs.apache.org
(which runs HEAD not APACHE_2_0_BRANCH), it failed and gave us:
[Sun Mar 14 00:00:00 2004] [emerg] (2)No such file or directory: Couldn't
initialize cross-process lock in child
[Sun Mar 14 00:00:00 2004] [emerg] (2)No such
--On Sunday, March 14, 2004 11:18 PM -0600 William A. Rowe, Jr.
[EMAIL PROTECTED] wrote:
as the GNU, ASF, and SF projects all discovered, full backups by third
parties are invaluable. What is the equivalent to rsync, and is it as stable?
I think you mean cvsup not rsync. We're currently
--On Monday, March 15, 2004 10:52 AM + Ben Laurie [EMAIL PROTECTED]
wrote:
It is? How? Unless the committer signs (which ISTR was rejected as an option
when I suggested it, so I'm assuming that doesn't happen), then they must be
signed by the server - a successful attacker can therefore sign
--On Monday, March 15, 2004 4:47 AM -0800 Kean Johnston [EMAIL PROTECTED] wrote:
people have worked very hard to make it work, and its good. But at the same
time, one should be careful of falling into the when you have a new hammer
everything looks like a nail trap.
Subversion serves *exactly*
--On Monday, March 15, 2004 1:02 PM -0500 Joshua Slive [EMAIL PROTECTED] wrote:
Disadvantages of moving to subversion:
...
- Backups/integrity (fixable?)
Not to beat a dead horse, but I think that's an advantage with Subversion:
on-the-wire checksums, repository checksums, (incremental) backups,
--On Monday, March 15, 2004 1:29 PM -0600 C. Michael Pilato
[EMAIL PROTECTED] wrote:
Justin, what's being done about unversioned properties (since those
can change at any time)? Do you have post-revprop-change hook setup
to squirrel away those mods so that they could be restored should the
--On Tuesday, March 16, 2004 5:27 PM + Ben Laurie [EMAIL PROTECTED]
wrote:
I don't see how this defends against a malicious user that has owned the
server for long enough for his changes to have been rsynced to the secure
server?
Because it'd be read-only? That is, the changes won't be on
--On Tuesday, March 16, 2004 8:19 PM + Ben Laurie [EMAIL PROTECTED]
wrote:
c) You appear to be assuming daily snapshots maintained forever in your
story - if so, how do you deal with network problems and the like? How
can you tell a commit that didn't make it to the secure server because
of
--On Wednesday, March 17, 2004 9:47 AM +1000 Brian Havard
[EMAIL PROTECTED] wrote:
Also, being on a dialup link I currently rsync the cvs repository to a
local machine do all my checkout/update/diff/log etc operations from
there only commit across the link. Can I do that with subversion or
--On Thursday, March 18, 2004 9:30 PM -0800 Kyle Hamilton
[EMAIL PROTECTED] wrote:
is this for real?
No. -- justin
--On Monday, April 5, 2004 9:35 AM -0400 Geoffrey Young
[EMAIL PROTECTED] wrote:
releases control to the next provider in the chain. this all leaves digest
providers without a way to return 401 and stop the authentication chain.
basic providers, however, can use AUTH_DENIED to accomplish this.
--On Friday, April 9, 2004 10:09 PM +0100 Nick Kew [EMAIL PROTECTED] wrote:
If anyone finds the time to review this, please let me have your
feedback. If people find it useful then good!
Once it's had a bit more exposure, I'll have a look at the docs
and style guide, and turn it into a patch.
--On Wednesday, May 12, 2004 8:54 PM +0200 André Malo [EMAIL PROTECTED] wrote:
* Jim Jagielski [EMAIL PROTECTED] wrote:
I'd like to propose that the apache-1.3 tree be migrated over
to subversion.
I'm +1 on it.
+1. -- justin
--On Wednesday, June 2, 2004 12:12 PM +0100 Joe Orton [EMAIL PROTECTED]
wrote:
The approach I'm using is a new input filter which runs above (before)
the HTTP input filter, and waits for an EOS, then does the SSL
handshake. All the data must be read from the socket before starting
the
--On Monday, June 7, 2004 12:06 AM +0200 Sander Striker [EMAIL PROTECTED]
wrote:
FYI, Fitz did a conversion of apache-1.3, which is now located at
http://svn.apache.org/repos/test/httpd/. (in the test repository).
Looks good - +1.
We should probably import it as: /httpd/httpd-1.3 or
--On Monday, June 7, 2004 11:59 AM -0400 Jim Jagielski [EMAIL PROTECTED] wrote:
Is there a recommended client-side config setup?
Things like using ssh and authentication, etc...
You should use SSL instead of SSH, i.e. something like:
https://svn.apache.org/repos/asf/httpd/apache-1.3/trunk/
And,
--On Friday, July 30, 2004 3:13 PM -0400 Joe Schaefer
[EMAIL PROTECTED] wrote:
I thought such hooks were run on *every* request, not
just the ones which require a particular output filter?
If so, for performance reasons that's not a suitable
solution for folks writing output filters with
--On Friday, July 30, 2004 12:32 AM +0100 Nick Kew [EMAIL PROTECTED] wrote:
It generated an interesting discussion, including some interesting
alternative ideas, last night on IRC. Perhaps it can lead to a
general-purpose module for 2.0 and an architecture update for 2.2?
While at OSCON last week, Madhu and I had a chat about mod_cache - and how
Zeus is beating httpd 2.x all over the place because they cache and we still
don't by default and about how poor a job mod_cache is doing in the real
world. Madhu has a bunch of gprof numbers that he said he'll be posting
--On Sunday, August 1, 2004 8:24 AM +0100 Nick Kew [EMAIL PROTECTED] wrote:
I'm not sure what 'match' is in this context.
In the above case, it could be text/html or latin1.
ap_register_smart_filter(transcode, latin1, charset_filter, ctx,
flags); ap_register_smart_filter(process, text/html,
--On Friday, July 16, 2004 11:29 PM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Pier Fumagalli wrote:
I don't understand why mod_cache forcedly avoids caching URLs ending
with the / (slash) character.
Yah, when I went through mod_cache tonight, I tossed that same code, too. I
agree that it
--On Tuesday, July 13, 2004 11:21 AM -0500 William A. Rowe, Jr.
[EMAIL PROTECTED] wrote:
Body/content generation or transformation should not be contending with
these issues you raised above. It's not unreasonable to expect some
metadata to pass through or be transformed (such as a content
--On Tuesday, July 13, 2004 10:35 AM -0500 William A. Rowe, Jr.
[EMAIL PROTECTED] wrote:
The confusion results because mod_proxy isn't implemented as a content
handler, it's a protocol handler in its own right. Rather than insist on the
mod_http mod_proxy agreeing to streamline the response,
--On Sunday, August 1, 2004 10:54 AM +0100 Nick Kew [EMAIL PROTECTED] wrote:
(btw, if you think AP_FTYPE_RESOURCE should be AP_FTYPE_CONTENT_SET,
that's another weakness of the architecture. If we need to transcode
*before* a content filter, then we can't use CONTENT_SET.
Solution: this needs to
--On Sunday, August 1, 2004 11:26 AM +0200 Mladen Turk [EMAIL PROTECTED]
wrote:
-if ((rv = apr_socket_create(newsock, backend_addr-family,
+#if (APR_VERSION_MAJOR 0)
+if ((rv = apr_socket_create(
+#else
+if ((rv = apr_socket_create_ex(
+#endif
+
--On Tuesday, July 20, 2004 10:19 PM +0200 André Malo [EMAIL PROTECTED] wrote:
the old outdated NCSA config directives? We add and add and add code -- which
is not actually bad. But where's the man with the broom?
Sounds a like job for someone. How about nominating modules for removal in
2.1, or
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Okay. You asked for it. ;-) I wanted to let the patches sit overnight in my
head and then break
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/http/http_request.c (ap_internal_redirect): Call quick_handler when
we do an internal
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.h: Always use atomics.
* modules/experimental/mod_mem_cache.c:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
Index:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.c: Delay no-store check until saving.
(It's a corner case with
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.c: Reduce logging in mainline case.
Index:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c (load_headers): Only validate that the
header file
--On Sunday, August 1, 2004 8:12 PM +0200 Mads Toftum [EMAIL PROTECTED] wrote:
On Sun, Aug 01, 2004 at 03:18:47AM -0700, Justin Erenkrantz wrote:
My #1 vote is to throw mod_rewrite clear off the island. =) -- justin
Why is it so important to kill off mod_rewrite that this comes up from time
--On Sunday, August 1, 2004 8:25 PM +0200 Graham Leggett [EMAIL PROTECTED]
wrote:
And if something is broken, wrong, bad code, incomplete, then submit
some patches to fix the problem! This is why we have peer review, so that
different eyeballs get a perspective on possible flaws in the code.
No,
--On Sunday, August 1, 2004 11:17 PM +0200 Graham Leggett [EMAIL PROTECTED]
wrote:
The byte ranges aren't done for the benefit of the httpd itself, but rather
a potential multi tier backend supported by mod_proxy or mod_backhand.
Right now if you range request a big file, it will work - but not
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Some more work, analysis, and tests yielded apr_file_gets() and MD5 as two
more bottlenecks.
I've
--On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
-1, Need to check for EnableSendfile off.
No, core_output_filter does that check. Modules don't have that information
whether
--On Monday, August 2, 2004 11:44 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
These are debug messages so not sure why they are a problem.
+0
The logging code is expensive to call for every request like that as many
times as it does. IMHO, there's no benefit to such a verbose log. More
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Thanks for the review! I've committed all of the non-contentious ones (i.e.
sendfile and logging).
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Here's another patch that was hidden in my earlier one. I think 'read' and
'write' are awful terms
--On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
I should amend my vote a -.5. The patch should work as you've coded it but
opening a file for use with apr_sendfile causes the file to be opened for
overlapped i/o on Windows. I expect some of the codepaths will
--On Monday, August 2, 2004 8:46 AM -0400 Brian Akins [EMAIL PROTECTED]
wrote:
Another big speed-up may be to pre-make all of the directories. A simple
script could use CacheRoot, |CacheDirLength|, and |CacheDirLevels to create
them all. Just require that this script be ran before starting a
--On Monday, August 2, 2004 9:21 AM -0400 Brian Akins [EMAIL PROTECTED]
wrote:
In a low traffic site, yes. In a very high traffic site, with lots of
objects, the mkdir's kill you. After a while, most of the directories
will be created. However, bringing up a fresh server behind a very busy
--On Monday, August 2, 2004 10:55 AM -0700 Justin Erenkrantz
[EMAIL PROTECTED] wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Here's another
1 - 100 of 1873 matches
Mail list logo
