RE: cvs commit: httpd-2.0/support/win32 ApacheMonitor.c ApacheMonitor.h ApacheMonitor.rc wintty.c

2004-01-02 Thread Mladen Turk
-Original Message- From: André Malo [mailto:[EMAIL PROTECTED] Why? Unless the file changes in 2004, the copyright doesn't. And, in any case, the earliest date applies, so it gets us nowhere. It was done for LICENSE 1.0 and 1.1 all the time for some reason. But I don't

[PATCH] ApacheMoitor -- Enable XP visual style

2004-03-15 Thread Mladen Turk
Hi, As said in the subject... The attached file ApacheMonitor.exe.manifest needs to be copied in the /support/win32/ dir. Index: ApacheMonitor.rc === RCS file: /home/cvspublic/httpd-2.0/support/win32/ApacheMonitor.rc,v retrieving

RE: [PATCH] ApacheMoitor -- Enable XP visual style

2004-03-17 Thread Mladen Turk
Hi, -Original Message- From: Jeff Trawick Is this to correct a problem for all Windows platforms which manifests itself on Windows XP, or just something that people with Windows XP may wish to play with, or what? On pre-XP it behave like before, but on XP it has visual style

RE: Invitation to HTTPD commiters in tomcat-dev

2004-07-21 Thread Mladen Turk
Graham Leggett wrote: Thing is it's easier for end users to not have to mess around with third party builds if it can possibly be avoided, and it's the needs of the end users who are the most important, not the developers. It was the main reason why we tried to go beyond the concepts

RE: Invitation to HTTPD commiters in tomcat-dev

2004-07-21 Thread Mladen Turk
Graham Leggett wrote: I don't think that it is necessary for a mod_ajp to be included inside the mod_proxy, although they are sharing some common concepts. I think it's very necessary - sharing those common concepts ultimately makes for doing things in a consistent way. It

[PATCH] proxy lb support - step 1

2004-07-26 Thread Mladen Turk
Hi all, There has been some serious discussion for building load balancing support for mod_proxy. Here is the first in series of patches that will enable this. The patch adds lb support in scoreboard, so that statuses for each lb worker can be calculated for each child process. It uses optional

RE: cvs commit: httpd-2.0 STATUS

2004-07-29 Thread Mladen Turk
William A. Rowe, Jr. wrote: /* Scoreboard file, if there is one */ #ifndef DEFAULT_SCOREBOARD @@ -118,6 +119,7 @@ typedef struct { int server_limit; int thread_limit; +int lb_limit; ap_scoreboard_e sb_type;

RE: cvs commit: httpd-2.0 STATUS

2004-07-29 Thread Mladen Turk
André Malo wrote: William A. Rowe, Jr. wrote: This definitely breaks binary compatibility. Moving the lb_limit to the end of the struct will not break the binary compatibility. Correct? Not Correct. It *may* be the case. Depending on who allocates the stuff. Can you

RE: cvs commit: httpd-2.0 STATUS

2004-07-29 Thread Mladen Turk
William A. Rowe, Jr. wrote: Moving the lb_limit to the end of the struct will not break the binary compatibility. Correct? Yes, in the case of global_score, that would be safer. It seems that the additional lb_score 's element point was better placed. If you changed

RE: cvs commit: httpd-2.0 STATUS

2004-07-29 Thread Mladen Turk
William A. Rowe, Jr. wrote: Although we create the pointer-pointer logic in the children to avoid this, it's still possible that the code would break some modules. I can't envision a case where any of the scoreboard entries are allocated outside of our scoreboard.c code. OK, then.

[PATCH] scoreboard WAS RE: cvs commit: httpd-2.0 STATUS

2004-07-29 Thread Mladen Turk
Hi all, Since there was some concerns regarding binary compatibility, here is the patch that uses different approach. 1. Revert the patch with changes to scoreboard structures 2. Add an extra hook that is run during ap_reopen_scoreboard with detached param. We will use our own shm, opening by

[PATCH] mod_proxy -- enable using 2.1-HEAD on 2.0-HEAD

2004-08-01 Thread Mladen Turk
Oops... gone trough different email, so reposting. Hi, Not a very 'critical' patch, but enables building mod_proxy on 2.0-HEAD (if someone finds that usefull). Since 2.1 has some nice features (will have more hopefully) here is the patch that enables that. Index: proxy_util.c

RE: [PATCH] mod_proxy -- enable using 2.1-HEAD on 2.0-HEAD

2004-08-01 Thread Mladen Turk
Justin Erenkrantz wrote: -if ((rv = apr_socket_create(newsock, backend_addr-family, +#if (APR_VERSION_MAJOR 0) +if ((rv = apr_socket_create( +#else +if ((rv = apr_socket_create_ex( #endif +newsock, backend_addr-family,

RE: POST without Content-Length

2004-08-07 Thread Mladen Turk
Justin Erenkrantz wrote: We have a lot of proxy updates in 2.1, which are presumably getting test-driven over time. How would one go about proposing a wholesale backport? How about releasing 2.2 instead? ;-) How about backport :) JaeanFrederic, Henri and myself take a liberty

RE: POST without Content-Length

2004-08-07 Thread Mladen Turk
André Malo wrote: OTOH hiding something just to 'boost' a new version is not fair. I think, you've got something wrong. Perhaps :) As of the branch to 2.1, we've marked 2.0 stable and more or less freezed. That has nothing to do with being fair or not. The development just happens in

[proxy] New implementation ready for testing

2004-08-11 Thread Mladen Turk
Hi all, We've finished the initial development of extended mod_proxy. Since the development took place at jakata-tomcat-connectors, the source code can be found under ajp/proxy. Here is the list of major features added: 1. AJP13 protocol support 2. Connection pool for threaded servers 3. Added new

Re: [proxy] New implementation ready for testing

2004-08-11 Thread Mladen Turk
William A. Rowe, Jr. wrote: We've finished the initial development of extended mod_proxy. Since the development took place at jakata-tomcat-connectors, the source code can be found under ajp/proxy. I'm entirely +1 today for bringing it back into modules/proxy/ (it's a c-t-r branch.) How you did

Re: [proxy] New implementation ready for testing

2004-08-11 Thread Mladen Turk
Graham Leggett wrote: William A. Rowe, Jr. wrote: I'm actually very excited that we can offer in the 2.2 release - this really rocks. What you accomplished is very cool! I'm entirely +1 today for bringing it back into modules/proxy/ (it's a c-t-r branch.) How you did it makes this a

Re: [proxy] New implementation ready for testing

2004-08-11 Thread Mladen Turk
William A. Rowe, Jr. wrote: Never cross my mind that we'll need all those try-error-fix commits back on the httpd cvs tree. We actually like those - the next individual to say wow - this fix is easy! can go back over history and say grumf - they tried that in the first place :) Question...

[PATCH] use zlib-1.2.1 with mod_deflate on WIN32

2004-08-12 Thread Mladen Turk
Hi, Small patch that enables building against zlib-1.2.1 instead of ancient 1.1.4 version. Index: mod_deflate.dsp === RCS file: /home/cvspublic/httpd-2.0/modules/filters/mod_deflate.dsp,v retrieving revision 1.10 diff -u -r1.10

[PROPOSAL] small dynamic config module

2004-08-12 Thread Mladen Turk
Hi all, To be able to use the new proxy balancer to it's full potential we need some sort of dynamic configuration. The typical scenarios are: a) Mark a node(s) as 'disabled' for maintenance. b) Add an extra node(s) for additional load. c) Change the load factors. At first I was thinking to add

Re: [PATCH] use zlib-1.2.1 with mod_deflate on WIN32

2004-08-12 Thread Mladen Turk
Bill Stoddard wrote: Mladen Turk wrote: Hi, Small patch that enables building against zlib-1.2.1 instead of ancient 1.1.4 version. Are there any compelling reasons to move from 1.1.4 to 1.2.1? Just curious and no time to investigate for myself right at the moment. As stated on the official

Worker mpm for WIN32

2004-08-23 Thread Mladen Turk
Hi, I've changed the mpm_winnt to support multiple child processes. The main reason was to have the same behavior like on worker mpm. Since I don't have multiprocessor box, it would be nice if someone could test if there is any performance gain over the existing implementation (there is none on

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2004-08-24 Thread Mladen Turk
Justin Erenkrantz wrote: Modified:modules/proxy proxy_http.c Log: Use ap_str_tolower for lowercasing the scheme. That was the original intention (not apr_tolower). Can you please not mix formatting changes with code changes? Those spurious changes make it a lot tougher to review.

Re: Time for 2.0.51 and 2.1.0

2004-09-02 Thread Mladen Turk
William A. Rowe, Jr. wrote: Bad news for me and many others since without AJP support included in 2.0.x, users will still require to have mod_jk to link there HTTPD to Tomcats. Could we hope the dev team to relax the situation for mod_proxy/ajp in future 2.0.x release Admins understand why n.x -

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-08 Thread Mladen Turk
Jeff Trawick wrote: [Fri Sep 03 12:05:59 2004] [error] [client 127.0.0.1] File does not exist: proxy:http://127.0.0.1:10101/cgi-bin/printenv If nobody can/has reproduced the problem, I'll dig into it this weekend. I had time dig into it enough to get the feeling that it is something that the

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-08 Thread Mladen Turk
Jeff Trawick wrote: What is the config that you are using. Does you requests get passed with previous version of proxy. If they do, please post the config so we can find why is it breaking. This is a very basic proxy config: proxyrequests on proxyvia on allowconnect 8081 80 8080 OK. From that

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-08 Thread Mladen Turk
Graham Leggett wrote: proxyrequests on proxyvia on allowconnect 8081 80 8080 OK. From that config what would be remotes that we could connect to? Dynamically obtained from Via header or...? Seems to me that the balancer is totally unusable in such a configuration. Keep in mind proxyrequests on

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-08 Thread Mladen Turk
Jeff Trawick wrote: Can you explain some real world usage of such configuration. Configure your web browser to use Apache as an HTTP proxy. This is a forward proxy? Are you speaking about that? If do, then the current implementation might be bogus, cause frankly speaking didn't test that a lot,

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-08 Thread Mladen Turk
Graham Leggett wrote: Mladen Turk wrote: This is a forward proxy? Are you speaking about that? If do, then the current implementation might be bogus, cause frankly speaking didn't test that a lot, but was planning to do so. Or I've missed the subject again :). Proxyrequest on turns httpd

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-09 Thread Mladen Turk
Jeff Trawick wrote: On Fri, 3 Sep 2004 12:30:34 -0400, Jeff Trawick [EMAIL PROTECTED] wrote: 192.168.1.11 - - [03/Sep/2004:12:05:59 -0400] GET http://127.0.0.1:10101/cgi-bin/printenv HTTP/1.0 404 236 error log has: [Fri Sep 03 12:05:59 2004] [error] [client 127.0.0.1] File does not exist:

Re: HTTP proxy working for folks on 2.1-dev?

2004-09-09 Thread Mladen Turk
Jeff Trawick wrote: Just committed the needed changes to allow forward proxies. I saw... definitely gets farther now... This shows how far it gets when I configure mozilla to use Apache as HTTP proxy: [Thu Sep 09 06:53:17 2004] [crit] [Thu Sep 09 06:53:17 2004] file http_protocol.c, line 981,

Re: cvs commit: httpd-2.0/modules/proxy proxy_balancer.c proxy_util.c mod_proxy.h

2004-09-10 Thread Mladen Turk
William A. Rowe, Jr. wrote: You introduce a race between multiple listening threads attempting to initialize the scoreboard together. post_config or child_init should solve the problem, no? Yes, I see that (now that you've mentioned :)). I'll use the child_init to initialize all balancers.

Re: cvs commit: httpd-2.0/modules/proxy proxy_ajp.c

2004-09-14 Thread Mladen Turk
Joe Orton wrote: On Thu, Sep 09, 2004 at 07:56:31PM -, [EMAIL PROTECTED] wrote: mturk 2004/09/09 12:56:31 Modified:modules/proxy proxy_ajp.c Log: Add function protos so that -Wmissing-declarations doesn't complain. Adding separate declarations within a .c file (rater than a

Re: cvs commit: httpd-2.0/modules/proxy proxy_ajp.c

2004-09-14 Thread Mladen Turk
[EMAIL PROTECTED] wrote: jorton 2004/09/14 10:29:36 Modified:modules/proxy proxy_ajp.c Log: * modules/proxy/proxy_ajp.c (proxy_ajp_handler, proxy_ajp_canon): Drop ap_ prefix, declarations and make static. Could you then do the same for proxy_http? Both ap_proxy_http_canon and

Re: Proxy_balancer, max_attempts ...odd?

2004-09-17 Thread Mladen Turk
NormW wrote: Greetings All, Just looking at a CVS build of 2.1, and on accessing the BalancerManager page, the FailoverAttempts (on a NetWare platform) show as -2119156632. Strange... did you rebuild mod_proxy too? Regards, MT. smime.p7s Description: S/MIME Cryptographic Signature

[OT] Developer lists and Reply-To header

2004-09-23 Thread Mladen Turk
Hi, Is there any reason why apr, apr-util, httpd mailing lists have Reply-To header set to the sender and not to the list itself. I think almost all other lists has the 'Replay-To' header set to the list itself. I mean, I'm receiving the messages from the list and not from the particular poster,

Re: [OT] Developer lists and Reply-To header

2004-09-23 Thread Mladen Turk
Greg Marr wrote: Is there any reason why apr, apr-util, httpd mailing lists have Reply-To header set to the sender and not to the list itself. Search for reply-to considered harmful on Google and you'll find more information than you ever wanted to read about both sides of the issue. If you

Re: cvs commit: httpd-2.0/modules/proxy proxy_balancer.c

2004-09-26 Thread Mladen Turk
Joe Orton wrote: The SSL proxy tests in the test suite have broken again from one of these changes. I get core dumps like below. Any ideas? #0 0x0807fc07 in ap_proxy_acquire_connection ( proxy_function=0x8477540 \buG\b(pE\b\220\211;\b, conn=0x84575f6, worker=0x844c520, s=0x83b8990)

Re: cvs commit: httpd-2.0/modules/proxy proxy_balancer.c

2004-09-26 Thread Mladen Turk
Joe Orton wrote: On Sun, Sep 26, 2004 at 06:58:36AM -, [EMAIL PROTECTED] wrote: mturk 2004/09/25 23:58:36 Modified:modules/proxy proxy_balancer.c Log: Use the Christian von Roques's idea that makes the election mechanism much simpler. This also removes the need to count the

Re: cvs commit: httpd-2.0/modules/proxy mod_proxy.c proxy_balancer.c proxy_util.c mod_proxy.h

2004-09-28 Thread Mladen Turk
[EMAIL PROTECTED] wrote: mturk 2004/09/28 09:35:30 Modified:modules/proxy mod_proxy.c proxy_balancer.c proxy_util.c mod_proxy.h Revision ChangesPath 1.158 +1843 -1846httpd-2.0/modules/proxy/proxy_util.c 1.138 +614 -605

Re: load balancer and http(s) sticky sessions

2006-09-14 Thread Mladen Turk
Jim Jagielski wrote: There is a lot of confusion where the users think that simply adding the stickysession param to the http worker attribute *adds* the required sticky session info (cookie). I'm looking into adding functionality that actually does that and therefore avoiding this large and

Re: svn commit: r451580 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2006-10-02 Thread Mladen Turk
Jim Jagielski wrote: I'm not sure about this... is the patch complete or are other things being added at some point? For example: It was mostly copy/paste from mod_jk where it was not reported for a failure on any platform. Just make some code cleanup. Also, does this mean that the

Re: svn commit: r451582 - /httpd/httpd/trunk/modules/proxy/mod_proxy.h

2006-10-02 Thread Mladen Turk
Ruediger Pluem wrote: URL: http://svn.apache.org/viewvc?view=revrev=451582 Log: Move new struct member to the end of the struct, so we can keep the compatibility. Sorry for nitpicking, but I am still missing the minor bump. There was no 2.3 releases, so no need for version bump. Regards,

Re: svn commit: r451582 - /httpd/httpd/trunk/modules/proxy/mod_proxy.h

2006-10-02 Thread Mladen Turk
Paul Querna wrote: Mladen Turk wrote: Ruediger Pluem wrote: URL: http://svn.apache.org/viewvc?view=revrev=451582 Log: Move new struct member to the end of the struct, so we can keep the compatibility. Sorry for nitpicking, but I am still missing the minor bump. There was no 2.3 releases

Re: svn commit: r451582 - /httpd/httpd/trunk/modules/proxy/mod_proxy.h

2006-10-02 Thread Mladen Turk
Paul Querna wrote: Mladen Turk wrote: But the trunk is usually build as is with all custom modules. What's the point of it if we need to preserve backward compatibility. (For what version, SVN head from DD/MM/ or what). When the first version gets tagged from trunk, then we can have a MMN

Re: mod_proxy and balancer problems

2006-10-05 Thread Mladen Turk
Mathias Herberts wrote: Oops I forgot one thing the 'ajp.patch' does. It introduces a new parameter 'stickycasesession' which is just like 'stickysession' but is case insensitive. This is needed as the servlet spec says the session cookie must be named JSESSIONID but the URL rewriting scheme

Re: mod_proxy_ajp problem with multiple ports on same host

2006-10-08 Thread Mladen Turk
hv @ Fashion Content wrote: I have a setup that works when I proxy to the first AJP connector, but not when I try the second one (Get a forbidden message). If I change to http proxying it works just fine. Has anyone experienced this? Nope. It works just fine for multiple hosts on the same

Re: svn commit: r454114 - /httpd/httpd/trunk/docs/conf/httpd-win.conf

2006-10-09 Thread Mladen Turk
André Malo wrote: * [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Oct 8 02:58:21 2006 New Revision: 454114 URL: http://svn.apache.org/viewvc?view=revrev=454114 Log: Add compat module by default. More interesting would have been, why. What's the use of this? Because default

Re: svn commit: r454114 - /httpd/httpd/trunk/docs/conf/httpd-win.conf

2006-10-09 Thread Mladen Turk
André Malo wrote: * Mladen Turk wrote: André Malo wrote: * [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Oct 8 02:58:21 2006 New Revision: 454114 URL: http://svn.apache.org/viewvc?view=revrev=454114 Log: Add compat module by default. More interesting would have been, why. What's

Re: Issue with persistent http proxy backend connection

2006-10-12 Thread Mladen Turk
Ruediger Pluem wrote: But yes, in theory their remains a race here if the proxy reuses the connection faster then the backend needs time to close the socket after sending the response. Does the problem exists with the current trunk as well? The way how trunk detects the closed backend has

Re: svn commit: r464141 - in /httpd/httpd/trunk/srclib/pcre: dftables.c dftables.dsp

2006-10-15 Thread Mladen Turk
William A. Rowe, Jr. wrote: why not s#/wd:4996#/D _CRT_SECURE_NO_DEPRECATE# /wd with colon like (/wd:4966) gives: Command line error D8021 : invalid numeric argument '/wd:4996' cl when converted to VS2005. BTW according to the MSDN the proper format is /wd not /wd: Also the

Re: svn commit: r464141 - in /httpd/httpd/trunk/srclib/pcre: dftables.c dftables.dsp

2006-10-16 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: William A. Rowe, Jr. wrote: why not s#/wd:4996#/D _CRT_SECURE_NO_DEPRECATE# /wd with colon like (/wd:4966) gives: Command line error D8021 : invalid numeric argument '/wd:4996'cl when converted to VS2005. BTW according to the MSDN the proper

Re: [Fwd: Re: Apache 2.2.3 mod_proxy issue]

2006-10-29 Thread Mladen Turk
Ruediger Pluem wrote: I guess we should create a directive like DefineWorker (I do not really care about the exact name), that enables the administrator to define / create a worker. Then you can easily just use Proxy ajp://localhost:8009 ProxySet ... /Proxy It will define a 'known'

Re: [Fwd: Re: Apache 2.2.3 mod_proxy issue]

2006-10-30 Thread Mladen Turk
Ruediger Pluem wrote: Then you can easily just use Proxy ajp://localhost:8009 ProxySet ... /Proxy It will define a 'known' worker. There is no need for an additional directive. Yes, this idea came also up to me after sending the mail. It seems to be an acceptable solution for this

Re: Apache BUG: 36495 : ajp_proxy_connect_backend failure

2006-11-07 Thread Mladen Turk
Benjamin Cuthbert wrote: http://issues.apache.org/bugzilla/show_bug.cgi?id=36495 Does anyone know if this bug was fixed ? It is in the trunk, where there is alternative socket is_connected detection. Can you check the trunk, or at least copy the new is_socket_connected from tunk's

Re: Apache BUG: 36495 : ajp_proxy_connect_backend failure

2006-11-07 Thread Mladen Turk
Benjamin Cuthbert wrote: Can you show me where this trunk is ? URL ? svn export http://svn.apache.org/repos/asf/httpd/httpd/trunk httpd-head Anyhow: http://httpd.apache.org/dev/ Regards, Mladen.

Re: Time for 2.2.4?

2006-11-08 Thread Mladen Turk
Jim Jagielski wrote: Looking over CHANGES and STATUS, I think we should start thinking about a 2.2.4 release. Comments? I would like to propose the backport of proxy alternate is_socket_connected. This is IMHO very crucial for AJP to work. Without that the loadbalancer is unusable for most

Re: Time for 2.2.4?

2006-11-08 Thread Mladen Turk
Jim Jagielski wrote: I know that Bill is looking at a release of APR and that alternate method would, I think, be better implemented in APR than directly in httpd... Sure it can be done, but in that case it would require at least a minor version bump. I have a proto that uses

Re: Time for 2.2.4?

2006-11-08 Thread Mladen Turk
Jim Jagielski wrote: Mladen Turk wrote: Anyhow, mod_jk works on all the platforms with the exact code like a charm ;) With my non-devil's-advocate hat on, the code itself is pretty basic Steven's anyway... It might be, not sure, but as Ferengi Rule 31 states: Never make fun of a Ferengi's

Re: Time for 2.2.4?

2006-11-09 Thread Mladen Turk
Jim Jagielski wrote: I know that Bill is looking at a release of APR and that alternate method would, I think, be better implemented in APR than directly in httpd... Eww, no thanks. AFAIK the same results can be achieved using existing APR interfaces: a non-blocking apr_socket_recv()

Re: Are you shure about this?

2006-11-11 Thread Mladen Turk
Paul Querna wrote: To my surprise several people just expressed the opinion that LUA should be part of the apache core in the long run. Could you explain for what purposes you want to do this? Because its fun. Do you know where to find LUA developer resources? One thing I could never find

Re: JOB [CONTRACT] + Re: Windows + MP2 in a production environment

2006-11-21 Thread Mladen Turk
Issac Goldstand wrote: I don't think that the problem is mod_perl, as much as the winnt MPM in Apache2. The bottom line is that if anything goes wrong, you need the singleton child process to recycle itself, and very often in the case of mod_perl that can take a long time. There is

mod_proxy pending patches

2006-11-25 Thread Mladen Turk
Hi, There are some pending mod_proxy patches for 2.2.x. I would like to push some testing on the http://svn.apache.org/viewvc?view=revrevision=468941 (explicit flushing from recent Tomcats) and http://svn.apache.org/viewvc?view=revrevision=425454 (cping/cpong support) The patches are part of

Re: Headache, Win32 Service Name for Apache 2.2

2007-01-04 Thread Mladen Turk
William A. Rowe, Jr. wrote: The default service name is Apache2, both in the 2.0 and 2.2 WinNT MPMs. One of three things can happen here... please express your preference (if you have one) [ ] Change the MPM code to use Apache2.2 by default (and Apache2.4 in trunk) [X] Change the Installer

Re: Arranging mod_proxy_ajp

2007-03-15 Thread Mladen Turk
Jean-Frederic wrote: -if (status != APR_SUCCESS) { +if (! isok) { /* We had a failure: Close connection to backend */ conn-close++; This is what concerns me (not your code but the old conn-close++. Hope It wasn't me ;) Anyhow, AJP should keep the connection to

Re: Arranging mod_proxy_ajp

2007-03-15 Thread Mladen Turk
Rainer Jung wrote: Caution: this line exactly has been added as a patch for BZ 40310. I didn't follow this too closely, but it looked like a serious issue for the user. http://issues.apache.org/bugzilla/show_bug.cgi?id=40310 The user comments, that the fix might be relevant for mod_jk too,

Re: mod_proxy patches

2007-03-16 Thread Mladen Turk
Mathias Herberts wrote: The 'forceclose' patch will ensure that this situation will never happen as the Cmax connections will not be kept idle. It will have a slight performance penalty but that's better than a total inability to serve requests (which should only happen when T0 is really

Re: mod_proxy patches

2007-03-19 Thread Mladen Turk
Jim Jagielski wrote: On Mar 16, 2007, at 8:52 AM, Mathias Herberts wrote: I agree that reusing the backend connections can be a good thing, but there are times when this is just not a very good idea. I agree that there are times when having a single-shot connection is better than having a

Re: Arranging mod_proxy_ajp

2007-03-20 Thread Mladen Turk
Rainer Jung wrote: Mladen Turk wrote: Jean-Frederic wrote: -if (status != APR_SUCCESS) { +if (! isok) { /* We had a failure: Close connection to backend */ conn-close++; http://issues.apache.org/bugzilla/show_bug.cgi?id=40310 The user comments, that the fix

Re: 2.2.4 windows binary w/ssl?

2007-03-22 Thread Mladen Turk
Guenter Knauf wrote: Hi, Should we add a cert-creation .sh and .vbs script to support/ for this purpose (on any platform)? Sounds like a great idea to me! +1 from me. If you find my vbs useful then I will contribute it. I've spent a good time to find at least something working; Drop an eye

Re: 2.2.4 windows binary w/ssl?

2007-03-23 Thread Mladen Turk
Joe Orton wrote: Drop an eye on: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/examples/mkcerts?view=markup - auto-generating dummy certs which claim to be issued by or to the ASF doesn't seem like a good idea at all It is an example, so anyone is entitled to change it for its

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-03 Thread Mladen Turk
Georg von Zezschwitz wrote: As I (with Rüdigers help :-) ) found out, there is already a bug report to my problem: #41897 describes the problem that the case-sensitivity of the stickysession-Parameter does not comply to the Java Servlet Spec (Cookie: JSESSIONID, url based session

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-03 Thread Mladen Turk
Plüm wrote: IMHO adding config parameters is no blocker for a backport. I was under different perception. It is probably more easy to add balancer-stickyurl = jsessionid when balancer-sticky is JSESSIONID and NULL otherwise. Or in get_path_param() test for jsessionid when

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-03 Thread Mladen Turk
Jean-Frederic wrote: We could do that then by using existing directive and decide during configure time. For example: stickysession=JSESSIONID [C] stickysession=;jsessionid [P] Does that mean that stickysession=JSESSIONID will work as it does now? Yes. I don't think we need Case

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-04 Thread Mladen Turk
Plüm wrote: 1. You want to change sticky in struct proxy_balancer from const char *sticky to something like const char *sticky[MAX_ENTRIES] Yes, although MAX_ENTRIES would be 3 for now (cookie, path and env) Why is FOO stored in balancer-sticky-[2]? Is it because

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-04 Thread Mladen Turk
Plüm wrote: Yes, although MAX_ENTRIES would be 3 for now (cookie, path and env) But this means that we break the ABI here. If struct proxy_balancer is part of a public API (I am not sure about this) this would require a major bump and would prevent backporting. The other solution is to

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-04-04 Thread Mladen Turk
Plüm wrote: Plus does it make sense to split the sticky string everytime we search for a route? From my performance feeling this split should be done during configuration time. We can use the NUL separated double NUL terminated string. Then a part is start + strlen(start) Regards, Mladen.

Re: mod_proxy buffering small chunks

2007-04-12 Thread Mladen Turk
Jim Jagielski wrote: This is only fixed in trunk so far. See http://issues.apache.org/bugzilla/show_bug.cgi?id=41056 and http://svn.apache.org/viewvc?view=revrevision=480135 Hmmm. Looks like a backport candidate... I'll likely do some testing and propose if it works :) I have another

Re: mod_proxy buffering small chunks

2007-04-13 Thread Mladen Turk
Plüm wrote: +1 I will try to check it once you have proposed it and give it a quick vote. I have another one that fixes this issues for non-chunked content. I haven't tried yet, but IMHO it should already work for non-chunked content. Is this not the case? Not according to my tests. The

Re: mod_proxy buffering small chunks

2007-04-13 Thread Mladen Turk
Jim Jagielski wrote: Not according to my tests. The simple server push still buffers the data. Hmmm a followup commit has: URL: http://svn.apache.org/viewvc?view=revrev=504559 so that may be exactly the case... Huh, looks like it works now. Although I didn't test is with

Re: Bug 41897 / Session-Stickiness with mod_proxy_balancer

2007-05-07 Thread Mladen Turk
Ruediger Pluem wrote: On 04/06/2007 01:13 PM, Georg von Zezschwitz wrote: Jim Jagielski wrote: attached is the patch for trunk with documentation Co. Could anybody review it commit? Many thanks for sending the patch and my apologies that reviewing it took that long. Please find my

Re: Apache 2.2.4 under Win32 Longhorn

2007-05-07 Thread Mladen Turk
William A. Rowe, Jr. wrote: yacsha wrote: what? I think Mario's post below is quite clear. I am wondering, however, *where* he sees the error message he cites. A log? A popup command window? An ok box? Is there additional details (a window caption or other details?) Does it continue to

Re: Apache 2.2.4 under Win32 Longhorn

2007-05-07 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: Just tracking the Vista problems down. One problem is the installer. Every awk config rewrite fails so the installation ends up without config files. Didn't try with Administrator account directly, but with the member of the administrators group

Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS

2007-05-08 Thread Mladen Turk
William A. Rowe, Jr. wrote: Can't we do +else if (osvi.dwMajorVersion = 6) { +*dwVersion = OS_VERSION_VISTA; for now (or simply 'else') so that this isn't instantly broken by the next version, irrespective of any changes required? Sure we can. Since we are only

Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS

2007-05-08 Thread Mladen Turk
William A. Rowe, Jr. wrote: Can't we do +else if (osvi.dwMajorVersion = 6) { +*dwVersion = OS_VERSION_VISTA; for now (or simply 'else') so that this isn't instantly broken by the next version, irrespective of any changes required? Nevertheless, completely unrelated ...

Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS

2007-05-08 Thread Mladen Turk
William A. Rowe, Jr. wrote: You want to commit or should I? Knock yourself out :) Cheers, Mladen.

Re: ProxyPass globbing

2007-05-11 Thread Mladen Turk
Jim Jagielski wrote: 1. ProxyPass /foo/* balancer://bar should silently rewrite itself to ProxyPass /foo/ balancer://bar In other words, we already assume a prefix glob. But should we? In other words, there is no difference between /foo/ and /foo/*. If you

Re: httpd returns 500 when a route does not belong to the balancer.

2007-07-12 Thread Mladen Turk
jean-frederic clere wrote: Hi, I would like to fix a problem in mod_proxy_balancer when the configuration is something like: +++ Location /myapp ProxyPass balancer://mycluster/myapp stickysession=JESSSIONID|jsessionid nofailover=On /Location Location /titi ProxyPass

Re: httpd returns 500 when a route does not belong to the balancer.

2007-07-12 Thread Mladen Turk
jean-frederic clere wrote: Mladen Turk wrote: jean-frederic clere wrote: Hi, I would like to fix a problem in mod_proxy_balancer when the configuration is something like: +++ Location /myapp ProxyPass balancer://mycluster/myapp stickysession=JESSSIONID|jsessionid nofailover

Re: httpd returns 500 when a route does not belong to the balancer.

2007-07-12 Thread Mladen Turk
jean-frederic clere wrote: Hmm, nofailover=On is used for non-matched routes. The failover stuff is between the members of a balancer not between balancers. Not true. ? In find_route_worker(proxy_balancer *balancer...) nofailover == sticky_force snip runtime =

Re: httpd returns 500 when a route does not belong to the balancer.

2007-07-17 Thread Mladen Turk
Johnny Kewl wrote: Mladen... stupid question, but what is this stuff in the code @@ -470,15 +470,32 @@ http://www.network-theory.co.uk/articles/patchintro.html It doesn't exactly explain the format of the patch file, but it can be helpful :) Regards, Mladen

Re: svn commit: r556860 - /httpd/httpd/branches/2.2.x/STATUS

2007-07-17 Thread Mladen Turk
William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Tue Jul 17 02:23:30 2007 New Revision: 556860 URL: http://svn.apache.org/viewvc?view=revrev=556860 Log: Comment the backport concerns for ApacheMonitor --- httpd/httpd/branches/2.2.x/STATUS (original) +++

Re: svn commit: r557188 - /httpd/httpd/trunk/support/win32/ApacheMonitor.c

2007-07-18 Thread Mladen Turk
William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Wed Jul 18 01:02:21 2007 New Revision: 557188 URL: http://svn.apache.org/viewvc?view=revrev=557188 Log: Simplify OS detection. We are only interested in NT and WIN2K+ (so we can use services.msc) Can we assume that

Re: svn commit: r573555 - /httpd/httpd/trunk/include/scoreboard.h

2007-09-07 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: jim /* stuff which is lb specific */ -typedef struct proxy_worker_stat lb_score; +typedef struct lb_score lb_score; +struct lb_score { +/* TODO: sync this with proxy_worker_stat */ +unsigned char data[256]; +}; The original was 1024, and now you

Re: Win32 MPM patch

2007-10-15 Thread Mladen Turk
William A. Rowe, Jr. wrote: I had refactored your patch on trunk so that we no longer name the silly function wait_for_many_objects (since it obviously didn't do that properly, at least not with any consideration of fairness or parallel signals). Roy's concerns should be addressed. +1 It

Httpd 'Amsterdam' commits

2007-11-15 Thread Mladen Turk
Hi, Seems that there are lots of commits made recently to that branch (IIUC Apache 3) However I simply cannot recall there was any discussion except the one in the https://svn.apache.org/repos/asf/httpd/sandbox/amsterdam/ROADMAP So, a simple question, what are we doing? What are the goals and

Re: Httpd 'Amsterdam' commits

2007-11-16 Thread Mladen Turk
Justin Erenkrantz wrote: On Nov 15, 2007 12:10 PM, Mladen Turk [EMAIL PROTECTED] wrote: If the guys committing those stuff can share some light to the rest of us, perhaps we could participate as well. The path we're going down (for now) is making serf the core input/output filtering mechanism

Re: svn commit: r596786 - in /httpd/site/trunk/xdocs: contributors/index.xml images/rbowen.jpg

2007-11-20 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Added: httpd/site/trunk/xdocs/images/rbowen.jpg (with props) Very nice photo! I hope others will follow ;) Cheers, Mladen

Re: memory leak in 2.2.x balancer?

2007-11-28 Thread Mladen Turk
Jim Jagielski wrote: On Nov 28, 2007, at 3:39 AM, jean-frederic clere wrote: One of the question is should we go on using scoreboard to store the balancers and workers information or should we already add a layer to a provider that will provide all the features we need to handle the balancers

  1   2   3   4   5   >