IGNITE-4284 - ready for review

2017-02-22 Thread Nikita Amelchev
Hello. I fixed it. Please, review. https://issues.apache.org/jira/browse/IGNITE-4284 - Failed second client node join with continuous query and peer class loading enabled latest ci.tests: http://ci.ignite.apache.org/project.html?projectId=IgniteTests_IgniteTests=pull%2F1564%2Fhead -- Best

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-01-19 Thread Nikita Amelchev
asks that must be included in 2.0: > https://issues.apache.org/jira/browse/IGNITE-4547 < > https://issues.apache.org/jira/browse/IGNITE-4547> > > — > Denis > > > On Jan 15, 2017, at 9:02 PM, Nikita Amelchev <nsamelc...@gmail.com> > wrote: > > > > Th

IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-01-13 Thread Nikita Amelchev
Hello everyone. I'd like to take IGNITE-2894. Can you assign to me? Username: NSAmelchev -- Best wishes, Amelchev Nikita

IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

2017-01-06 Thread Nikita Amelchev
hello everyone. Is IGNITE-3904 still relevant? I'd like to take it. Can you add me to contributor list? Username: NSAmelchev Full Name: Amelchev Nikita -- Best wishes, Amelchev Nikita

Re: IGNITE-3904 - Add an option to serialize specific type(s) with OptimizedMarshaller when binary format is used

2017-01-10 Thread Nikita Amelchev
-marshaller# > handling-hash-code-generation-and-equals-execution < > https://apacheignite.readme.io/docs/binary-marshaller# > handling-hash-code-generation-and-equals-execution> > > > > — > > Denis > > > >> On Jan 6, 2017, at 8:01 AM, Nikita Amelchev <nsamelc

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-01-15 Thread Nikita Amelchev
ct setup in Intellij IDEAL > https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup > > Regards, > Denis > > > On Jan 13, 2017, at 1:37 AM, Nikita Amelchev <nsamelc...@gmail.com> > wrote: > > > > Hello everyone. > > > > I'd like to take

Re: IGNITE-4284 - ready for review

2017-03-28 Thread Nikita Amelchev
2] http://reviews.ignite.apache.org/ignite/review/IGNT-CR-140 > > -Dmitry. > > 22.03.2017 14:41, Nikita Amelchev пишет: > > Some about p2p class loading support. I thought that we can unmarshal on >> processNodeAddFinishedMessage when discovery data recieved. But for >&g

Re: IGNITE-4284 - ready for review

2017-03-22 Thread Nikita Amelchev
this failure > is wrong, we should either forbid such a node to start or support p2p class > loading for discovery (or suggest yet another solution). > > 2017-02-22 12:03 GMT+03:00 Nikita Amelchev <nsamelc...@gmail.com>: > > > Hello. I fixed it. > > > > Please,

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-04-18 Thread Nikita Amelchev
such classes also go through BinaryMarshaller > streams, they will be aware of binary configuration and will share the same > set of handles as well. This should take care of all the issues we have > here. > > -Val > > On Thu, Jan 19, 2017 at 7:26 AM, Nikita Amelchev <nsa

Tickets for work

2017-04-18 Thread Nikita Amelchev
Hello. Could you give me any ticket ? Preferably not time-consuming. -- Best wishes, Amelchev Nikita

Fix for enum marshalling

2017-07-21 Thread Nikita Amelchev
Hi, Igniters. I fixed issue 5087 - Enum comparison fails after marshal-unmarshal with BinaryMarshaller. The solution is check superclass on enum. I created new public method isEnum(Class cls) for resolve enum mode in binary class descriptor. Also I get class name through getDeclaringClass() for

IGNITE-5104 - ready for review.

2017-04-27 Thread Nikita Amelchev
Hello. I done it. Please, review. *https://issues.apache.org/jira/browse/IGNITE-5104 * - Refactor javadocs and annotations to single style PR: *https://github.com/apache/ignite/pull/1883/files *

IGNITE-4763 - ready for review.

2017-04-27 Thread Nikita Amelchev
Hello. I done it. Please, review. https://issues.apache.org/jira/browse/IGNITE-4763 - doSetRollbackOnly method to be implemented in SpringTransactionManager PR: https://github.com/apache/ignite/pull/1879/files latest ci.tests:

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-06-19 Thread Nikita Amelchev
t > everything that is included in Java serialization spec, including some > non-trivial stuff like PutField. I would check if it's possible to somehow > reuse the code that already exists in optimized marshaller as much as > possible. > > -Val > > On Tue, Apr 18, 2017 at 1:36

IGNITE-5087 Enum comparison fails after marshal-unmarshal with BinaryMarshaller

2017-05-30 Thread Nikita Amelchev
Hello. I done it. Please, review. https://issues.apache.org/jira/browse/IGNITE-5087 - Enum comparison fails after marshal-unmarshal with BinaryMarshaller PR: https://github.com/apache/ignite/pull/2015 ci test:

Re: [DISCUSS] Webinar for Ignite Persistent Store walk-through

2017-06-13 Thread Nikita Amelchev
+1 2017-06-13 15:31 GMT+03:00 vadopolski : > + 1 > > > > -- > View this message in context: http://apache-ignite- > developers.2346864.n4.nabble.com/DISCUSS-Webinar-for- > Ignite-Persistent-Store-walk-through-tp18677p18767.html > Sent from the Apache Ignite Developers

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-09-19 Thread Nikita Amelchev
l be able to >> work >> > with such objects without deserialization on the server. Hence, no >> classes >> > will be needed on the server side. Current implementation (see PR in the >> > ticket) defines separate format which require deserialization, I am not &

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-10-11 Thread Nikita Amelchev
://issues.apache.org/jira/browse/IGNITE-2894 2017-09-22 18:46 GMT+03:00 Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Nikita, > > I think it should be consistent with Binarylizable. > > -Val > > On Fri, Sep 22, 2017 at 7:12 AM Nikita Amelchev <nsamelc...@gma

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-09-07 Thread Nikita Amelchev
server side. Current implementation (see PR in the > > ticket) defines separate format which require deserialization, I am not > OK > > with it. > > > > Thoughts? > > > > On Wed, Aug 23, 2017 at 6:11 PM, Nikita Amelchev <nsamelc...@gmail.com> >

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-08-23 Thread Nikita Amelchev
ller should of course use > that and ignore Externalizable. > > -Val > > On Mon, Aug 21, 2017 at 9:29 AM, Nikita Amelchev <nsamelc...@gmail.com> > wrote: > > > Hello, Igniters. > > > > I am developing Externalizable interface support by BinaryMarsh

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

2017-08-21 Thread Nikita Amelchev
> > this is the main downside of current implementation. > > > > 3. I think this order is correct, but does it even make sense to > implement > > both Binarylizable and Externalizable? > > > > -Val > > > > On Mon, Jun 19, 2017 at 8:58 AM, Nikita Amel

Re: IGNITE-2779 BinaryMarshaller caches must be cleaned during client reconnect.

2017-09-01 Thread Nikita Amelchev
Hi, Igniters. I have done issue 2779 - BinaryMarshaller caches must be cleaned during client reconnect.[1] Could you, please, review? Solution: We stop server nodes and keep alive the client. Then we take a new instance of the cache and client node throws an exception in

IGNITE-6692 Select query on a client with unused field throws an exception.

2017-10-20 Thread Nikita Amelchev
Hello, Igniters. I found a bug when I execute next queries on the client: CREATE TABLE t1 (name VARCHAR(1), unused LONG, PRIMARY KEY(name)); INSERT INTO t1 (name) values ('A'); SELECT name FROM t1 ORDER BY name, unused; The latest query throws exception like "BinaryObjectException: Cannot find

Re: Transport compression (not store compression)

2017-11-22 Thread Nikita Amelchev
Hello, Igniters! I think it is a useful feature. I suggest to implement it to communication SPI like SSL encryption implemented. I have experience with this feature and I can try to develop it. 2017-11-22 12:01 GMT+03:00 Alexey Kukushkin : > Forwarding to DEV list:

Re: Transport compression (not store compression)

2017-11-23 Thread Nikita Amelchev
work. > > > But client nodes via very slow network. > > > > > > I implemeted GridClientZipOptimizedMarshaller and that solved my > issue. > > > But this marshaller works only with old > > > and org.apache.ignite.internal.client.GridClient and has a lot of > > > limitations. > > > But c

Re: Transport compression (not store compression)

2017-11-29 Thread Nikita Amelchev
implement this flag in "CompressEngine" with wrap and unwrap methods for compress and decompress to byte buffer. Compression settings should be placed in a configuration (Ignite configuration/discovery SPI and GridClientConfiguration). Any thoughts? 2017-11-28 10:39 GMT+03:00 Niki

Re: Transport compression (not store compression)

2017-11-27 Thread Nikita Amelchev
getting > down to the implementation. > > — > Denis > > > On Nov 23, 2017, at 4:38 AM, Nikita Amelchev <nsamelc...@gmail.com> > wrote: > > > > Hi Igniters! > > > > I’m working on the similar feature for my own project. > > I would like to sugge

Re: IGNITE-6666 BinaryObjectImpl.writeFieldByOrder method does not support TIME

2017-11-01 Thread Nikita Amelchev
. https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2878%2Fhead 2017-10-30 10:51 GMT+03:00 Vladimir Ozerov <voze...@gridgain.com>: > Hi Nikita, > > See my comments in the ticket. > > On Fri, Oct 20, 2017 at 11:54 AM, Nik

Re: IGNITE-6692 Select query on a client with unused field throws an exception.

2017-11-01 Thread Nikita Amelchev
Thanks for the comments. I have done check to the existing schema through the BinaryUtils.FLAG_HAS_SCHEMA flag [1]. Also, I have checked other places where we can try to read not initialized schema and found that BinaryObjectBuilderImpl.ensureReadCacheInit() method can do it. If we try to get

IGNITE-6679 Clean up some deprecated cache metrics

2017-11-02 Thread Nikita Amelchev
Hello, Igniters. I have removed deprecated metrics [1]. Please, review [2]. Tests look good [3]. 1. https://issues.apache.org/jira/browse/IGNITE-6679 2. https://reviews.ignite.apache.org/ignite/review/IGNT-CR-390 3.

Optimize GridIntList and GridByteArrayList serialization

2018-06-05 Thread Nikita Amelchev
Igniters, Recently was optimized GridLongList serialization. [1] I found that GridIntList and GridByteArrayList can be optimized as well. We can reduce message size by sending only valuable part of the array: public boolean writeTo(ByteBuffer buf, MessageWriter writer) { ...

IGNITE-6135 java.sql.Date is serialized using OptimizedMarshaller

2017-10-20 Thread Nikita Amelchev
Hello, Pavel, Igor, Igniters. I have implemented javax.sql.Date type for a binary protocol [1,2]. According to TC tests [3] we need to add support for sql.Date in CPP and ODBC modules. Other tests look good. Please, review. [1] https://issues.apache.org/jira/browse/IGNITE-6135 [2]

IGNITE-6666 BinaryObjectImpl.writeFieldByOrder method does not support TIME

2017-10-20 Thread Nikita Amelchev
Hello, Igniters! I found that the BinaryObjectImpl.writeFieldByOrder method does not support the TIME type [1]. I wrote test and fixed it [2]. TC tests look good [3]. Please, review. [1] https://issues.apache.org/jira/browse/IGNITE- [2] https://github.com/apache/ignite/pull/2878/files [3]

Re: IGNITE-6692 Select query on a client with unused field throws an exception.

2017-10-20 Thread Nikita Amelchev
I've attached reproducer to the issue [1]. 1. https://issues.apache.org/jira/browse/IGNITE-6692 2017-10-20 16:05 GMT+03:00 Vladimir Ozerov <voze...@gridgain.com>: > Hi Nikita, > > Appears to be a bug. Could you please file a ticket with reproducer? > > On Fri, Oct 20, 20

IGNITE-6692 Select query on a client with unused field throws an exception.

2017-10-27 Thread Nikita Amelchev
Hello, Igniters! I’ve fixed the issue where SQL query with unused fields throws an exception [1]. Description of the problem: We can build a binary object without fields in the binary object builder. If we don't add a field, SchemaId will be set to zero. When we try to read field value,

Re: Transport compression (not store compression)

2018-01-19 Thread Nikita Amelchev
et's confirm that communication works well with compression first > in terms of performance. > > On Thu, Nov 30, 2017 at 10:36 AM, Nikita Amelchev <nsamelc...@gmail.com> > wrote: > > > Hello, everybody. > > I propose the following design for network compression. >

Re: Transport compression (not store compression)

2018-02-01 Thread Nikita Amelchev
Thanks for your comments, 1. At first, I would define final design and then I will make it pluggable. 2. We cannot prioritize messages at this network communication level. If compression utilizes processor poorly then we can increase count of selectors (make more threads when compression

Re: Transport compression (not store compression)

2018-02-05 Thread Nikita Amelchev
Thanks for your comments, I will try to separate network compression for clients and servers. It makes sense to enable compression on servers if we have SSL turned on. I tested rebalancing time and compression+ssl is faster. SSL throughput is limited by 800 Mbits/sec per connection and if enable

Re: Transport compression (not store compression)

2018-02-14 Thread Nikita Amelchev
not be accepted by the community. 2018-02-05 13:02 GMT+03:00 Nikita Amelchev <nsamelc...@gmail.com>: > Thanks for your comments, > > I will try to separate network compression for clients and servers. > > It makes sense to enable compression on servers if we have SSL turned on. &

Re: Transport compression (not store compression)

2018-02-16 Thread Nikita Amelchev
. > > > > What if we do this as follows: > > 1) Define "IgniteConfiguration.compressionEnabled" flag > > 2) When two nodes communicate and at least one of them has this flag, > then > > all data sent between them is compressed. > > > > Makes sense?

Re: Service grid redesign

2018-08-14 Thread Nikita Amelchev
Hello, Igniters. I am working on task [1] that would replace serialized service's instance by service's class name and properties map in {ServiceConfiguration}. The task describes that we should use {String className} + {Map properties} instead {Service srvc}. I'd like to clarify the following

Re: Wrong off-heap size is reported for a node

2018-08-29 Thread Nikita Amelchev
Pavel, I think that point 1 is the correct way to calculate the committed size for a log. It is already calculated regardless of the metricsEnabled flag. In addition, I suggest more readable log format for data regions in issue comments [1]. [1] https://issues.apache.org/jira/browse/IGNITE-9305

Re: Upgrading Ignite to JCache 1.1

2018-07-17 Thread Nikita Amelchev
Hi, Igniters. I'm implementing new version TCK 1.1 and I found the problem [1] in the .NET module. In brief, .NET creates cache entry event based on values exist checking. TCK 1.1 says that getValue() not null for REMOVE/EXPIRED events if old value required and it breaks logic. I'm looking for

Re: Unreliable checks in tests for string presence in GridStringLogger contents

2018-10-26 Thread Nikita Amelchev
ase can be solved with custom listener, but I think it's good > > improvement, let's do it. > > > > чт, 25 окт. 2018 г. в 21:31, Andrey Kuznetsov : > > > > > Nikita, > > > > > > I like your suggestion. It looks more expressive for me than existi

Re: Unreliable checks in tests for string presence in GridStringLogger contents

2018-10-25 Thread Nikita Amelchev
Hi, Igniters. I suggest improving new listening test logger. I found usage case when needs wait for conditions for test duration optimization. For example, that messages A and B will be logged. For now, LogListener.check() doesn't return checking result as boolean. It throws the exception if

Re: [ANNOUNCE] Welcome Alexey Plehanov as a new committer

2018-11-17 Thread Nikita Amelchev
Congrats, Alexey, great work! сб, 17 нояб. 2018 г. в 12:27, Nikolay Izhikov : > > Congratulations, Alexey! > > сб, 17 нояб. 2018 г., 12:07 Dmitriy Pavlov dpav...@apache.org: > > > The Apache Ignite Project Management Committee (PMC) has invited Alexey > > Plehanov to become a new committer and are

Re: [VOTE] Apache Ignite 2.7.0 RC1

2018-11-30 Thread Nikita Amelchev
+1 Best wishes, Amelchev Nikita пт, 30 нояб. 2018 г., 13:43 Юрий jury.gerzhedow...@gmail.com: > +1 > > пт, 30 нояб. 2018 г. в 13:25, Anton Vinogradov : > > > +1 > > > > пт, 30 нояб. 2018 г. в 10:05, Seliverstov Igor : > > > > > +1 > > > > > > пт, 30 нояб. 2018 г., 9:59 Nikolay Izhikov

Re: [ANNOUNCE] Welcome Pavel Kovalenko as a new committer

2018-11-21 Thread Nikita Amelchev
Congratulations, Pavel! ср, 21 нояб. 2018 г. в 11:47, Vyacheslav Daradur : > > Congrats Pavel, I'm looking forward to future PME optimizations! > On Wed, Nov 21, 2018 at 11:44 AM Alexey Goncharuk > wrote: > > > > The Apache Ignite Project Management Committee (PMC) has invited Pavel > >

Re: TeamCity permissions

2018-09-14 Thread Nikita Amelchev
Hi, Igniters. I am working on MTCGA tasks and sometimes I need to cancel my builds. It would be great if you grant permissions to stop builds to me. My TC login: nsamelchev ср, 23 мая 2018 г. в 17:36, Vitaliy Osipov : > > Hi. > > Done. Check please. > > On 23 May 2018 at 17:28, Maxim Muzafarov

Re: TeamCity permissions

2018-09-14 Thread Nikita Amelchev
Could you please double-check? > > I appreciate if other TC admins can advise me how to assign this role > correctly. > > Sincerely, > Dmitriy Pavlov > > пт, 14 сент. 2018 г. в 17:12, Nikita Amelchev : > > > Hi, Igniters. > > > > I am working on MTCGA

Lightweight version of partitions map exchange

2019-03-28 Thread Nikita Amelchev
Hello, Igniters! I have implemented lightweight version of partitions map exchange for the case when the baseline node leaves topology. [1] If partitions are assigned according to the baseline topology and server node leaves there's no actual need to perform distributed PME. Every cluster will

Re: Lightweight version of partitions map exchange

2019-03-29 Thread Nikita Amelchev
nko wrote: > > > Hi Nikita, > > > > Thank you for your work. This is great improvement. I'll take look on it in > > next couple of days. Could you please run TC and provide MTCGA bot status > > about this change? > > > > чт, 28 мар. 2019 г. в 14:29, Nik

The client can handle events from the previous cluster after reconnect.

2019-03-20 Thread Nikita Amelchev
Hello, Igniters! I found a bug with handling events when the client reconnects. Discovery has a queue for events. It's processed by event thread. If we hold up event processing using a listener on the client side and restarts cluster - the client will reconnect. After it reconnects it will

Re: New Committer: Vyacheslav Daradur

2019-04-11 Thread Nikita Amelchev
Congratulations, Vyacheslav! чт, 11 апр. 2019 г. в 17:08, Nikolay Izhikov : > > Hooray! > Congrats, Vyacheslav! > > чт, 11 апр. 2019 г., 17:00 Dmitriy Pavlov : > > > Dear Ignite Developers, > > > > The Project Management Committee (PMC) for Apache Ignite has invited > > Vyacheslav Daradur to

Re: Lightweight version of partitions map exchange

2019-06-05 Thread Nikita Amelchev
on statuses via a light discovery > message. > > So, my plan here can be: > Phase 1. Lightweight PME on BLT node leave on a stable cluster (no > MOVING partitions); > Phase 2. Lightweight PME on BLT node finishes its rebalance procedure. > > Folks, Nikita, > WDYT?

Re: [VOTE] Complete Discontinuation of IGFS and Hadoop Accelerator

2019-06-20 Thread Nikita Amelchev
+1 чт, 20 июн. 2019 г. в 11:28, Anton Vinogradov : > > +1 (binding) > > On Thu, Jun 20, 2019 at 10:08 AM Dmitriy Pavlov wrote: > > > +1 > > > > чт, 20 июн. 2019 г. в 09:15, Nikolay Izhikov : > > > > > +1 > > > > > > чт, 20 июня 2019 г., 8:28 Павлухин Иван : > > > > > > > +1 > > > > > > > > чт,

Re: Lightweight version of partitions map exchange

2019-05-24 Thread Nikita Amelchev
1. https://issues.apache.org/jira/browse/IGNITE-9913 пт, 29 мар. 2019 г. в 15:00, Nikita Amelchev : > > Pavel, > I have provided MTCGA bot status in Jira issue comments. [1] > > Eduard, > Yes, for current implementation it will be distributed PME if > in-memory

Re: Lightweight version of partitions map exchange

2019-07-01 Thread Nikita Amelchev
org/jira/browse/IGNITE-9913 ср, 5 июн. 2019 г. в 12:15, Nikita Amelchev : > > Maksim, > > I agree with you that we should implement current issue and do not > allow lightweight PME if there are MOVING partitions in the cluster. > > But now I'm investigating issue about finalizi

Partition map exchange metrics

2019-07-16 Thread Nikita Amelchev
Hello, Igniters. I suggest to add some useful metrics about the partition map exchange (PME). For now, the duration of PME stages available only in log files and cannot be obtained using JMX or other external tools. [1] I made the list of local node metrics that help to understand the actual

Re: Wiki permissions

2019-08-28 Thread Nikita Amelchev
Dmitriy, thank you! ср, 28 авг. 2019 г. в 18:13, Dmitriy Pavlov : > > Hi Nikita, > > granted, please check. > > Sincerely, > Dmitriy Pavlov > > ср, 28 авг. 2019 г. в 17:44, Nikita Amelchev : > > > Hi, Igniters. > > > > I'm going to implement ab

Wiki permissions

2019-08-28 Thread Nikita Amelchev
Hi, Igniters. I'm going to implement ability to rotate master encryption key (TDE Phase 2). Could you grant me permissions to edit wiki about it? My wiki login is 'nsamelchev'. -- Best wishes, Amelchev Nikita

Re: New Сommitter: Maxim Muzafarov

2019-08-28 Thread Nikita Amelchev
My congratulations, Maxim! ср, 28 авг. 2019 г. в 18:11, Dmitriy Pavlov : > > Dear community, > > The Project Management Committee (PMC) for Apache Ignite has invited Maxim > Muzafarov to become a committer and we are pleased to announce that he has > accepted. > > PMC recognizes Maxim's efforts

TDE Master key rotation (Phase-2)

2019-09-18 Thread Nikita Amelchev
Hi, Igniters. I'm going to implement the ability to rotate the master encryption key (TDE Phase 2). [1] Master key rotation required in case of it compromising or at the end of crypto period(key validity period). I prepared the design. [2] In briefly, master keys will be identified by String

Re: TDE Master key rotation (Phase-2)

2019-09-18 Thread Nikita Amelchev
Start local master key rotation process during node recovery(for > the case when key changed while node was down). > > В Ср, 18/09/2019 в 16:09 +0300, Nikita Amelchev пишет: > > Hi, Igniters. > > > > I'm going to implement the ability to rotate the master encrypt

Re: Partition map exchange metrics

2019-07-23 Thread Nikita Amelchev
re blocked > > > and > > > > how much time it's taken. > > > > For instant view (like in JMX bean) a calculated value as you mentioned > > > > can be used. > > > > For metrics are exported to some backend (IEP-35) a counter can be > > u

Re: Partition map exchange metrics

2019-07-19 Thread Nikita Amelchev
be extracted from logs now and can be implemented > > > > later. > > > > > > > > On Tue, Jul 16, 2019 at 12:46 PM Nikolay Izhikov > > > > wrote: > > > > > > > > > +1. > > > > > > > > > > Nikit

Re: Partition map exchange metrics

2019-07-19 Thread Nikita Amelchev
erations instead of instant boolean indicator. > > пт, 19 июл. 2019 г. в 14:41, Nikita Amelchev : > > > Anton, Nikolay, > > > > Thanks for the support. > > > > For now, we have the getCurrentPmeDuration() metric that does not show > > influence on the cl

Re: Partition map exchange metrics

2019-07-19 Thread Nikita Amelchev
nceOperationsBlocked"? For what analysis it can be used and how? > > пт, 19 июл. 2019 г. в 17:48, Nikita Amelchev : >> >> Hi Pavel, >> >> This time already can be obtained from the getCurrentPmeDuration and >> new isOperationsBlockedByPme metrics. >&

Re: Re[2]: Partition map exchange metrics

2019-07-24 Thread Nikita Amelchev
periencing issues right now. Boolean metric "are we blocked right now" > >> is not needed as it's obviously can be inferred from "current PME block > >> time". > >> > >> Best Regards, > >> Ivan Rakov > >> > >> On 23

Re: Re[2]: Partition map exchange metrics

2019-07-24 Thread Nikita Amelchev
: > > Nikita > > What is the difference between those two metrics? > > ср, 24 июля 2019 г., 12:45 Nikita Amelchev : > > > Igniters, thanks for comments. > > > > From the discussion it can be seen that we need only two metrics for now: >

Re: Partition map exchange metrics

2019-07-25 Thread Nikita Amelchev
eliable as log messages may change > > > > Best Regards, > > Ivan Rakov > > > > On 24.07.2019 14:57, Maxim Muzafarov wrote: > > > Folks, > > > > > > +1 with Anton post. > > > > > > What if we just update current metric getCurrentP

Re: TDE Master key rotation (Phase-2)

2019-09-20 Thread Nikita Amelchev
пт, 20 сент. 2019 г. в 13:04, Nikolay Izhikov : > > Why do we need "defaultMasterKeyId" instead of *current* master key id that > can be obtained with `KeystoreEncryptionSpi#getMasterKeyName()`? > > В Пт, 20/09/2019 в 12:56 +0300, Nikita Amelchev пишет: > &g

Re: TDE Master key rotation (Phase-2)

2019-09-20 Thread Nikita Amelchev
ce. > > What do you think? > > > В Пт, 20/09/2019 в 13:39 +0300, Nikita Amelchev пишет: > > Nikolay, > > > > because I suggested the implementation where the encryption manager is > > responsible for storing the master key id. > > To implement this logic

Re: Check Code Style suite fails on master

2019-12-05 Thread Nikita Amelchev
Hello, Thank you. My bad. I have created issue to fix it. [1] [1] https://issues.apache.org/jira/browse/IGNITE-12420 чт, 5 дек. 2019 г. в 18:41, Вячеслав Коптилин : > > Hello Nikita, > > It seems that this commit breaks "Check Code Style" suite at TeamCity. > [ERROR] >

Re: Cache operations performance metrics

2019-12-16 Thread Nikita Amelchev
I think these metrics are useful. I have prepared PR [1] for commit and rollback histograms. [2] Nikolay, could you take a look, please? If you do not mind, I will try to add affinity-nodes cache metrics: >> * histograms that measure the time of processing `get`, `put`, `remove`, >> `commit`,

Re: Index rebuilding metrics

2019-10-22 Thread Nikita Amelchev
index > > rebuilding > > Are you talking about new system view? > Why do we need it? > > We already have INDEXES system view that show info about each index existing > on the Ignite node. > Can we add some columns to it to reflect state of index rebuild process? > >

Index rebuilding metrics

2019-10-22 Thread Nikita Amelchev
Hello, Igniters. I would like to implement index rebuilding metrics [1, 2]. I suggest adding a cache metric and system view that shows if there are any index rebuilding for this cache right now (boolean type) [3]. Also, I can add time metrics: - how long was index rebuilding (or current

Unclear to use methods in the DiscoverySpiCustomMessage interface

2019-10-24 Thread Nikita Amelchev
Hi, Igniters. The discovery custom message interface has two methods the use of which is not clear to developers: 1. The stopProcess() method. Currently, it works only if the zookeeper discovery configured. It doesn't work in TcpDiscoverySpi. I did not find any usages of this method except

Re: TDE Master key rotation (Phase-2)

2019-10-17 Thread Nikita Amelchev
uccessfully. > > > Meta storage will store master key id. > > We should add that key id from metastorage has a higher priority to key id > from IgniteConfiguration. > > > В Пт, 20/09/2019 в 14:06 +0300, Nikita Amelchev пишет: > > Nikolay, > > > > you are right in many

Re: Add user attributes to thin clients

2020-01-23 Thread Nikita Amelchev
; C++, > > > > > C#. > > > > > > The protocol must be language-agnostic. If we add some features > > > there, > > > > > > let's make sure they are usable from anywhere. > > > > > > > > > > > > O

Re: Internal classes are exposed in public API

2020-01-30 Thread Nikita Amelchev
Folks, I have some experience using the new metrics API. The new format is easy to use from the user point and approved by the community. It provides a single metric format and one entry point. I believe that they are able to replace existing ones. I don't see any issues with the new metrics. The

Re: [ANNOUNCE] New committer: Vyacheslav Koptilin

2020-02-18 Thread Nikita Amelchev
Congrats, Slava! ср, 19 февр. 2020 г. в 08:38, Ivan Pavlukhin : > > Hooray! > > Best regards, > Ivan Pavlukhin > > ср, 19 февр. 2020 г. в 00:28, Dmitriy Govorukhin > : > > > > My congratulations, Slava! > > > > On Tue, Feb 18, 2020 at 11:33 PM Andrey Kuznetsov wrote: > > > > > Congratulations,

Re: [REVIEW] IGNITE-12344 Remote listener of IgniteMessaging has to run with appropriate SecurityContext

2020-02-17 Thread Nikita Amelchev
Denis, I have pre-reviewed your changes, LGTM. Could some security maintainer take a look? вт, 11 февр. 2020 г. в 20:37, Denis Garus : > > Hi, Igniters! > > > I've prepared the PR[1] for the ticket[2], could somebody do a review? > > > Thanks. > > > >1.

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-02-14 Thread Nikita Amelchev
Hi, guys. I suggest mark as deprecated the IgniteMXBean#active(boolean) method. The Ignite#active(boolean), IgniteMXBean#active(), IgniteCluster#active(boolean) methods already deprecated and told to use the #state(ClusterState)} instead. Should the old IgniteMXBean#state(ClusterState) method

Re: Unclear to use methods in the DiscoverySpiCustomMessage interface

2020-01-16 Thread Nikita Amelchev
and resend to another node. I know only 2 mechanisms where this > > > functionality is needed: > > > binary metadata propagation and cluster-wide metrics collecting. From my > > > side of view, this is poor approach and we should avoid discovery messages > > >

Re: Add user attributes to thin clients

2020-01-22 Thread Nikita Amelchev
I think we should add this. It will provide an extra level of security. This approach is used in many products, for example in AWS (MFA). [1] [1] https://docs.aws.amazon.com/general/latest/gr/aws-sec-cred-types.html#multi-factor-authentication ср, 22 янв. 2020 г. в 18:13, Andrey Kuznetsov : > >

Re: TDE Master key rotation (Phase-2)

2019-12-24 Thread Nikita Amelchev
> > > > Can we include it into a 2.8 release scope? > > I think it is possible since the release scope freeze date has not > > happened yet. > > > > On Thu, 17 Oct 2019 at 17:36, Nikita Amelchev > > wrote: > > > > > > Hi, Ignit

Re: Apache Ignite 2.8.1 RELEASE [Time, Scope, Manager]

2020-03-12 Thread Nikita Amelchev
Hello, Igniters. I propose to cherry-pick this bug-fix ticket to the 2.8.1: IGNITE-12728 The cache#putAllAsync method does not collect statistics [1] [1] https://issues.apache.org/jira/browse/IGNITE-12728 чт, 12 мар. 2020 г. в 18:27, Maxim Muzafarov : > > Alexey, > > > Now it’s not clear why

Re: [DISCUSSION] Major changes in Ignite in 2020

2020-04-15 Thread Nikita Amelchev
Hello, Igniters. I am going to contribute a new feature - profiling tool and performance report. This is part of IEP-35. [1] The tool will be able to collect performance statistics and create a human-readable report. It will help to analyze workload and to tune configuration and applications.

Re: Unclear to use methods in the DiscoverySpiCustomMessage interface

2020-03-30 Thread Nikita Amelchev
/apache/ignite/pull/7268/files чт, 16 янв. 2020 г. в 16:40, Nikita Amelchev : > > Hi, Igniters. > > I have created the issue [1] and prepared PR [2] to remove the > stopProcess method from interfaces. > > I have removed the method from the internal interface > (DiscoveryC

Re: [DISCUSSION] `static final` code-style constant naming rules

2020-04-27 Thread Nikita Amelchev
Hi, Maxim > But what exactly is `constant` means?! I'd suggest applying this rule > to all class fields with `static final` modifiers without any clauses. > (check Java Naming convention [2] paragraph 3.3). I read this convention [1] and found clarifying exclusion (3.3.2): All static final

Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
Hi, Igniters. I'm working on cluster profiling and the tool for creating a performance report. [1] I have prepared PoC based on performance logging to a separate category of Ignite log. The report contains: - Cache operations and its distribution by types [2] - Transactions and histogram of

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
ol as well, judging by the > > provided link [1] ) > > > > I am not against the new tool, I just want to understand the motivation to > > not improve the existing sub-projects. > > > > [1] > > > > https://cwiki.apache.org/confluence/display/IGNI

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
> > I am not against the new tool, I just want to understand the motivation to > > not improve the existing sub-projects. > > > > [1] > > > > https://cwiki.apache.org/confluence/display/IGNITE/Cluster+performance+profiling+tool > > > > Thank

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
ssible, I'm for reuse. пт, 24 апр. 2020 г. в 18:59, Ilya Kasnacheev : > > Hello! > > I suggest that it's one of the places where it could be put instead of > adding a new tool. > > Regards, > -- > Ilya Kasnacheev > > > пт, 24 апр. 2020 г. в 18:56, Nikita Amelch

Re: Tool for performance statistics reports

2020-04-24 Thread Nikita Amelchev
/docs/ignite-web-console [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=112820392 пт, 24 апр. 2020 г. в 18:46, Nikita Amelchev : > > Maxim, > > > Can you provide more information about the binary logging format? > I started to investigate. It should be w

Re: [ANNOUNCE] New PMC member: Maxim Muzafarov

2020-05-07 Thread Nikita Amelchev
Maxim, congrats! чт, 7 мая 2020 г. в 14:55, Nikolay Izhikov : > > Congrats. > > > 7 мая 2020 г., в 14:54, Ivan Pavlukhin написал(а): > > > > Maxim, > > > > My congratulations! Well deserved! > > > > P.S. We should mention snapshots for persistent caches in the > > achievement list. Great job! >

Re: Data vanished from cluster after INACTIVE/ACTIVE switch

2020-03-24 Thread Nikita Amelchev
Hi, Igniters. Note that DeactivateCommand#confirmationPrompt will be ignored in case of auto confirmation. I agree that the force flag should be removed when the user data and datastructures will not be clearing on deactivation. For now, cmd, jmx and rest interfaces should be covered. вт, 24

Re: Migration of spring-data modules to ignite-extensions

2020-10-09 Thread Nikita Amelchev
Mikhail, +1 for migrate чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov : > > Igniters, > > I propose to migrate spring-data modules from ignite main repository to > ignite-extensions. > > > Are there any objections? > > > I've created ticket [1] and PR to both ignite [2] and ignite-extensions > [3]

Skip distributed metastorage entries that can not be unmarshalled

2020-08-21 Thread Nikita Amelchev
Hello, Igniters. I would add the feature that allows skipping the distributed metastorage entries that can not be unmarshalled [1]. These entries can be created by the product that built on Apache Ignite and incorporates additional features. It will be useful during migrating with keeping user

  1   2   3   >