Re: How to install the custom built impala

bfesupport.so. Same errors for statestore and catalogd. >> >> + true >> + export >> IMPALA_BIN=/opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.42/lib/impala/sbin-debug >> + >> IMPALA_BIN=/opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.42/lib/impala/sbin-d

Re: How to install the custom built impala

If you go through this process again with a build after that change >>> goes in, then you'll need to update that jar. >>> >>> You can build it by running mvn package in Impala/ext-data-source. >>> >>> On Mon, Sep 12, 2016 at 3:29 PM, Tim Armst

Re: How to install the custom built impala

I don't think this is documented anywhere. You would need to replace the impalad binary and libfesupport.so under sbin-retail or sbin-debug for the release or debug builds respectively. You also need to replace impala-frontend-*.jar and impala-data-source-api*.jar. You also need to make sure the

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 18: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/3993

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: Can you show the difference between the nightly run and this patch then if that's

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 17: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/3993

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3201: in-memory buffer pool implementation .. IMPALA-3201: in-memory buffer pool implementation This patch implements basic in-memory buffer management

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (5 comments) The new algorithm makes sense to me. We could probably get fancier

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4111: backend death tests should not produce minidumps .. IMPALA-4111: backend death tests should not produce minidumps Move the existing core dump

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4353 Change subject: IMPALA-4111: backend death tests should not produce minidumps .. IMPALA-4111: backend death tests should not produce

[Impala-ASF-CR] IMPALA-4098: Open()/Close() partition exprs once per fragment instance.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4098: Open()/Close() partition exprs once per fragment instance. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4340

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 16: I keep hitting IMPALA-4097, will wait until that fix goes in then retry

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: If we use a long (64-bits) do we even need to track which IDs are in use? I calculate that if we allocate

[Impala-ASF-CR] IMPALA-4098: Open()/Close() partition exprs once per fragment instance.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4098: Open()/Close() partition exprs once per fragment instance. .. Patch Set 1: Code-Review+1 (6 comments) This is a lot simpler. http

[Impala-ASF-CR] IMPALA-4097: Crash in kudu-scan-node-test

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4097: Crash in kudu-scan-node-test .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4337 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 2: Another reason I ask is that AFAIK we don't trim file paths for any other

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 2: How did you come across this? Did you start Impala from the command line

Re: Prepare to vote on release candidate 1

/cluster/cdh5/node-1/var/log/ > > hdfs-datanode.out) > > >>> is: > > >>> > > >>> That said, it appears that impalad built OK (with build-all.sh > > -notests) > > >>> > > >>> > > >>> some nits/

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4335/3/be/src/runtime

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 16: Code-Review+2 The added DCHECK caused a failure in another backend test where

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

-Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Ko

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/3993/13/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

: I35cc89e863efb4cc506657bfdaaaf633a10bbab6 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer:

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarm

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe

Re: Prepare to vote on release candidate 1

I'm in the process of testing this. One nit that I think we should fix: apache-impala-incubating-2.7.0-rc1.tar.gz unpacks to incubator-impala. I think we should stick with the normal convention of unpacking to a directory with the same name as the tarball (or maybe

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: We also need to fix some of the describe commands: [

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/3863/20/b

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: (27 comments) I think we can make a lot of small im

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare .. Patch Set 2: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4325

[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4325/1/tests/query_test

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. IMPALA-4008: don't bake in hash table and hash join pointers This fixes some of the cases where

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4326 Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. IMPALA-4008: don't bake in hash table and hash join

[Impala-ASF-CR] IMPALA-4087: TestFragmentLifecycle.test failure in prepare

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4325 Change subject: IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare .. IMPALA-4087: TestFragmentLifecycle.test_failure_in_prepare

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4188/3/be/src/util/runtime

[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4074: Configuration items duplicate in template of YARN .. Patch Set 1: Code-Review+2 Thanks, just wanted to understand! -- To view, visit http

[Impala-ASF-CR] Add FNV, Zobrist, and SIMD hash functions to the int hash benchmark.

Tim Armstrong has posted comments on this change. Change subject: Add FNV, Zobrist, and SIMD hash functions to the int hash benchmark. .. Patch Set 1: (3 comments) Thanks, this is really interesting. http

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4307 Change subject: IMPALA-3815: clean up cross-compiled comparator .. IMPALA-3815: clean up cross-compiled comparator This avoids

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 9: (13 comments) http://gerrit.cloudera.org:8080/#/c/3993/9/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 18: (29 comments) http://gerrit.cloudera.org:8080/#/c/3863/18/b

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstr

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4290 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4113 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4290

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4290/3/be/src/benchmarks/bswap

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

: Ia9dfcca718b2456488d0fb4407d3817c796bfad0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 2: Waiting for another round of review from Michael. -- To view, visit http

Re: Request for feedback: C++ Style Guide

be something like "Our .clang-format is the source of truth for how to deal with whitespace, except when clang-format's output greatly diverges from the existing code style or common sense. In that case, we should update the .clang-format file." On Fri, Sep 2, 2016 at 9:59 AM, Tim Armstron

Re: Request for feedback: C++ Style Guide

Yes, several things are completely wrong. E.g. we never use c-style casts. On Fri, Sep 2, 2016 at 9:38 AM, Jim Apple wrote: > I left a comment on the page - I'm not sure how much these reflect our > actual current practice. > > On Fri, Sep 2, 2016 at 9:36 AM, Lars Volker

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/4163/4/be/src/service/child

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. IMPALA-4037,IMPALA-4038: fix locking during query cancellation * Refactor the child query

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 3: Will wait until https://gerrit.cloudera.org/#/c/4205/6 goes in. -- To view, visit http

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. IMPALA-4058: benchmark byteswap on misaligned memory Extend the benchmark to measure performance when

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4290/1/be/src/benchmarks/bswap

[Impala-ASF-CR] IMPALA-4058: benchmark byteswap on misaligned memory

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4058: benchmark byteswap on misaligned memory .. IMPALA-4058: benchmark byteswap on misaligned memory Extend the benchmark to measure performance when

[Impala-ASF-CR] IMPALA-4054: Remove serial test workarounds for IMPALA-2479.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4054: Remove serial test workarounds for IMPALA-2479. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4291

[Impala-ASF-CR] IMPALA-3873: Add QueryStateAccessor

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3873: Add QueryStateAccessor .. Patch Set 2: Code-Review+1 (6 comments) Renewed +1, did another pass and noticed a few minor things. http

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 12: Hi Zoltan, this didn't get merged because you didn't have +2 and verified on the same

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. IMPALA-4006: dangerous rm -rf statements in scripts Quoted variable substitutions in rm -rf

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 6: Code-Review+1 Carry my own +1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4160

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: See https://gerrit.cloudera.org/#/c/4290/ for the benchmark -- To view, visit

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4205

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: Code-Review+1 (1 comment) I also extended the microbenchmark to test perf when

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: We don't support parquet decimals wider than 16 bytes so I don't think the AVX2

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 17: (16 comments) Focused on the fe part. I think we need t

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3993/8/be/src/bufferpool

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/util/bit-util

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (25 comments) http://gerrit.cloudera.org:8080/#/c/3993/8/be/src/bufferpool/buffer

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 12: PS11->12: ran the patch through clang-format and added a clang-format option for

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/3873/10/be/src/exec/partitioned-hash

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4188/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

-Change-Id: I21c1dda8f8a1d92172bf59fbc1070a6834e61913 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: Move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: I meant https://gerrit.cloudera.org/3873 sorry -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: Move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: This is a prerequisite for making some of the requested changes to https

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4188 Change subject: Move ExecOption profile helpers to RuntimeProfile .. Move ExecOption profile helpers to RuntimeProfile

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Tim Armstrong has abandoned this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4181 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Patch Set 2: Michael Ho pointed out that I was wrong in assuming that the RowDescriptors

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4066/11/be/src/runtime

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-scan-node-mt.cc File

Re: scoped_ptr -> unique_ptr?

I don't feel that strongly about it but, but I think scoped_ptr/unique_ptr is a useful distinction to document that the pointer isn't movable. I think it contains info both ways: if it's a unique_ptr it means we intend to (sometimes) transfer it, but if it's a scoped_ptr its lifetime is strictly

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Code-Review-2 Started GVO early. -2 to prevent accidental merge. -- To view, visit http

<    1   2   3   4   5   6   7   8   9   10   >