[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-19 Thread Jim Apple (Code Review)
://gerrit.cloudera.org:8080/3886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <j

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 2: Verified-1 This version adds NonAssignment and then shows how it behaves on simple-scheduler.cc

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: REVIEW-ONLY: the results of running clang-format .. REVIEW-ONLY: the results of running clang-format See https://gerrit.cloudera.org/#/c/3886 for the configuration

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 5: > i posted a comment on the preview of the reformatting results you > sent out, please address that

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: I will be able to look at this again in about 9 days. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes .. Abandoned This change is small enough that it should be re-sent on the new gerrit project Impala

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

2016-08-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 9: This is now getting reviewed on https://gerrit.cloudera.org/#/c/3942

Re: [DISCUSS] Branching for a release soon?

2016-08-19 Thread Jim Apple
gt; Sounds great to me! >> > >> > Todd >> > >> > On Aug 19, 2016 8:41 AM, "Jim Apple" <jbap...@cloudera.com> wrote: >> > >> >> I would like to volunteer to be the next release manager for an >> >> upcoming Apach

[DISCUSS] Branching for a release soon?

2016-08-19 Thread Jim Apple
I would like to volunteer to be the next release manager for an upcoming Apache Impala 2.7 (incubating) release. I plan to: 1. Get a vote done adding to our bylaws the procedure for creating a branch. (See thread from yesterday) 2. Create a release branch, possibly backdated a few commits from

Re: Failed to submit/update my patch

2016-08-19 Thread Jim Apple
a.org:29418/Impala (push) > origin https://github.com/cloudera/Impala.git (fetch) > origin https://github.com/cloudera/Impala.git (push) > > > -Original Message- > From: Jim Apple [mailto:jbap...@cloudera.com] > Sent: Friday, August 19, 2016 9:07 AM > To: Wang, Youwei A

Re: Contributions to Cloudera Impala

2016-08-19 Thread Jim Apple
> [Nishidha] We found two new source code URLs as one mentioned in Confluence > https://git-wip-us.apache.org/repos/asf/incubator-impala.git and another to > be https://github.com/apache/incubator-impala. > Commits wise both look same, though former one says "wip" in the URL. Please > suggest the

Re: Failed to submit/update my patch

2016-08-18 Thread Jim Apple
Though I do see commits that should not be there. Did someone cherry pick commits from Impala-ASF to Impala on public gerrit? We may have to forcibly roll those back. On Thu, Aug 18, 2016 at 6:07 PM, Jim Apple <jbap...@cloudera.com> wrote: > I don't see this using "git fetch ger

Re: Failed to submit/update my patch

2016-08-18 Thread Jim Apple
sh gerrit HEAD:refs/for/cdh5-trunk > Result: I got the exact same error as we discussed. > > I have also try to substitute the VMWare workstation using a Debian docker > image in the step 1. > And the remained steps are identical. The same error still happens. > > -Original Message

[DISCUSS] Bylaw change to make branch creation or deletion lazy consensus

2016-08-18 Thread Jim Apple
http://gerrit.cloudera.org:8080/4053 I am proposing we change the bylaws so that a branch can be created or deleted by lazy consensus of the PMC: "Lazy consensus requires no -1 votes ('silence gives assent')" Right now the bylaws do not say what kind of vote is required for a branch creation or

[Impala-ASF-CR](asf-site) Update bylaws: Lazy Consensus for branch creation and deletion.

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4053 Change subject: Update bylaws: Lazy Consensus for branch creation and deletion. .. Update bylaws: Lazy Consensus for branch creation

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/exec/hash-table.cc File be/src/exec

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: Code-Review-2 Verified-1 Just -everythinging so no accidental commit is made. -- To view, visit

Re: Code formatting with clang-format

2016-08-18 Thread Jim Apple
I was familiar way. > > > > On Tue, Aug 16, 2016 at 10:29 AM, Jim Apple <jbap...@cloudera.com> > wrote: > > > > > Oh, and I should note that this file, right now, only handles C++. > > > clang-format also works with Java, but that's future research. &g

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4046 Change subject: REVIEW-ONLY: the results of running clang-format .. REVIEW-ONLY: the results of running clang-format See https

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 4: > Shouldn't the ternary operator be affected by BreakBeforeTernaryOperators > though? Or is that som

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-18 Thread Jim Apple (Code Review)
, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Henry Robins

Re: New Impala committer: Jim Apple

2016-08-18 Thread Jim Apple
Thanks, everyone! On Wed, Aug 17, 2016 at 5:52 PM, Henry Robinson <he...@apache.org> wrote: > Hi all - > > On behalf of the Apache Impala (incubating) PMC, I'm very pleased to > announce that we've voted to invite Jim Apple as a committer to the > project, and he's accept

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 2: > It added an extra space before a comment: > -child_batch_->Reset(); // All rows from chi

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Add .clang-format for Impala's C++ style .. Add .clang-format for Impala's C++ style Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa --- A .clang-format 1 file

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-08-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 40: (1 comment) http://gerrit.cloudera.org:8080/#/c/3081/40/be/src/util/bit

Re: Failed to submit/update my patch

2016-08-18 Thread Jim Apple
and check > whether that will happen then. > > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Thursday, August 18, 2016 12:48 PM > To: Jim Apple <jbap...@cloudera.com> > Cc: dev@impala <dev@impala.incubator.apache.org> > Subject

Re: Failed to submit/update my patch

2016-08-17 Thread Jim Apple
+todd Very strange - I have never seen anything like that. Todd, have you seen anything like this before? On Wed, Aug 17, 2016 at 8:14 PM, Wang, Youwei A wrote: > Greetings, everyone. > Just two days ago, I could submit/update my patch using following command >

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-08-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 40: (1 comment) http://gerrit.cloudera.org:8080/#/c/3081/40/be/src/util/bit

Re: New (to me) linker failures

2016-08-17 Thread Jim Apple
David Knupp and Tim Armstrong saw this, too: https://issues.cloudera.org/browse/IMPALA-3979 On Thu, Aug 11, 2016 at 2:08 PM, Jim Apple <jbap...@cloudera.com> wrote: > It works if I don't pass the '-so' flag to buildall. > > On Thu, Aug 11, 2016 at 1:36 PM, Jim Apple <jbap...@c

[Impala-ASF-CR] IMPALA-3221: Copyright / license audit

2016-08-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) Nice work. This must have been labor-intensive. http://gerrit.cloudera.org:8080/#/c/3995/1

Re: Contributions to Cloudera Impala

2016-08-17 Thread Jim Apple
> I'm glad to tell you that we are able to build and test Impala on Ubuntu > linux ppc64le with the great support from the Cloudera Community. Excellent! > Our next action is to upstream all our changes to Cloudera Impala. Great! Cloudera has donated Impala to the Apache Software Foundation

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 2: PS2 changes single-function style to 'Inline' which reduces the diff clang-format produces when run over

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-16 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add .clang-format for Impala's C++ style .. Add .clang-format for Impala's C++ style Change-Id: I274c5993c7be344fc4b7729d21a13da993f9f3aa --- A .clang-format 1 file

Re: Code formatting with clang-format

2016-08-16 Thread Jim Apple
Oh, and I should note that this file, right now, only handles C++. clang-format also works with Java, but that's future research. On Tue, Aug 16, 2016 at 10:09 AM, Jim Apple <jbap...@cloudera.com> wrote: > I support incremental reformat, not bulk reformat. > > I think we shoul

Re: Code formatting with clang-format

2016-08-16 Thread Jim Apple
me, and I think it's much better to have >> > automated formatting than to hang on to the position of a : in a for() >> > statement :) But I asked Jim if he'd start a thread here to check if >> others >> > agree. >> > >> > On 15 August 2016 at 15:18

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-08-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 40: (1 comment) http://gerrit.cloudera.org:8080/#/c/3081/40/be/src/util/bit

Code formatting with clang-format

2016-08-15 Thread Jim Apple
I would like to have a clang-format config file in our directory to help new contributors understand how to format code and have a tool to do it for them. Through the time I've been sending patches I've been accumulating a .clang-format file that seems to minimize the style comments I get. You can

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 1: > I ran this over a few patches. Some small things I noticed: > > 1. The arg-breaking

[Impala-ASF-CR] Remove dead and untested code

2016-08-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove dead and untested code .. Patch Set 1: With and without shared objects? With clang and gcc for all of the modes? With and without the gold linker? This may

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-08-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 2: > As a reminder, the gerrit "Impala" project is now deprecate

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-08-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 10: > Youwei, any plans for this? Any news? -- To view, visit http://gerrit.cloudera.org:8080/3

[Impala-ASF-CR] Remove dead and untested code

2016-08-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove dead and untested code .. Patch Set 1: If this build under all of our different compilation modes, I'm happy with it. -- To view, visit http

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: > LIMIT + conjuncts Do you have a particular shape of query in mind? -- To v

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3936 T

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 7: > I think the ASF build will still set the IMPALA_LZO env varia

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 7: > For what it's worth, the LZO tests are all now running and pass

Re: New (to me) linker failures

2016-08-11 Thread Jim Apple
It works if I don't pass the '-so' flag to buildall. On Thu, Aug 11, 2016 at 1:36 PM, Jim Apple <jbap...@cloudera.com> wrote: > Oh, that reminds me: I also tried bin/bootstrap_toolchain.py > > On Thu, Aug 11, 2016 at 1:34 PM, Matthew Jacobs <m...@cloudera.com> wrote: &g

Re: New (to me) linker failures

2016-08-11 Thread Jim Apple
Oh, that reminds me: I also tried bin/bootstrap_toolchain.py On Thu, Aug 11, 2016 at 1:34 PM, Matthew Jacobs <m...@cloudera.com> wrote: > Thanks. I didn't see anything wrong there (assuming the toolchain > directories exist), so I'm not sure, sorry :/ > > On Thu, Aug 11, 20

Re: New (to me) linker failures

2016-08-11 Thread Jim Apple
> Just to be clear: did clear your cmake files _after_ resetting and > resourcing the environment variables? yes > > What's your LD_LIBRARY_PATH and IMPALA_TOOLCHAIN ? (Maybe just post > the output of env.) Attached. XDG_VTNR=7 IMPALA_CYRUS_SASL_VERSION=2.1.23 IMPALA_AVRO_VERSION=1.7.4-p4

Re: New (to me) linker failures

2016-08-11 Thread Jim Apple
Oh, and I'm on Ubuntu 14.04. I did not upgrade any software on my machine between when this did build and when it did not build. On Thu, Aug 11, 2016 at 1:12 PM, Jim Apple <jbap...@cloudera.com> wrote: > When linking impalad I get errors like > > be/build/debug/util/libUtil.so: e

New (to me) linker failures

2016-08-11 Thread Jim Apple
When linking impalad I get errors like be/build/debug/util/libUtil.so: error: undefined reference to 'BZ2_bzBuffToBuffCompress' This includes with versions of Impala that I have compiled as recently as a couple of hours ago. It is now affecting all recent git hashes. The full list of libraries

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 1: Presumably this also passed exhaustive tests? -- To view, visit http:/

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 2: Code-Review+1 Passed exhaustive tests. -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-3945: Forbid create text table with nonsensical delimiter combinations.

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3945: Forbid create text table with nonsensical delimiter combinations. .. Patch Set 3: I am still concerned that this maybe should wait until 3.0. See my

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3822/4/fe/src/main/java/com

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: > it doesn't return > eos to the DataStreamSender, which then keeps repe

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/3822/3/be/src/exec/partitioned

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. IMPALA-2581: LIMIT can be propagated down into some aggregations SELECT DISTINCT f FROM t LIMIT n

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 1: (1 comment) Have you run private-build-and-test in exhaustive exp

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/3822/1/be/src/exec/partitioned

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. IMPALA-2581: LIMIT can be propagated down into some aggregations SELECT DISTINCT f FROM t LIMIT n

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 1: > How much churn does this introduce if run over the current > codebase? 14% of lines in

[Impala-ASF-CR] IMPALA-3786: Remove "Cloudera" from impalad webpage title

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3885 Change subject: IMPALA-3786: Remove "Cloudera" from impalad webpage title .. IMPALA-3786: Remove "Cloudera" from i

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

2016-08-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3886 Change subject: Add .clang-format for Impala's C++ style .. Add .clang-format for Impala's C++ style Change-Id

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3822/1/be/src/exec/partitioned

Re: [DISCUSS] Criteria for becoming a committer

2016-08-08 Thread Jim Apple
IMO we don't want to restrict committership to this subset of > people. > > On Mon, Aug 8, 2016 at 10:49 AM, Jim Apple <jbap...@cloudera.com> wrote: > >> Does anyone have thoughts about how, exactly, to evaluate non-code >> contributions? >> >> Wha

Re: [DISCUSS] Criteria for becoming a committer

2016-08-08 Thread Jim Apple
lid history of >> docs contributions and ability to work with the review process. >> >> Outside of that, we could also look at history of contributing to project >> discussions and giving constructive feedback on JIRAs, code reviews, and >> other project decision-mak

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-08-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 2: PS2 is only rebasing (for LZO changes from Impala-LZO repo) -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-08-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 10: Youwei, any plans for this? -- To view, visit http://gerrit.cloudera.org:8080/3213 To unsubscribe

[Impala-ASF-CR] IMPALA-3924: Ubuntu16 support

2016-08-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3924: Ubuntu16 support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3800/3//COMMIT_MSG Commit Message: PS3, Line 11: I think in C

[Impala-ASF-CR] IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

2016-08-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. .. Patch Set 1: Code-Review+2 This was +2ed on https://gerrit.cloudera.org/#/c/3311/ -- To view

[Impala-CR](cdh5-trunk) IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

2016-08-05 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. .. Abandoned https://gerrit.cloudera.org/#/c/3824/ -- To view, visit http://gerrit.cloudera.org:8080/3311

Re: HBase errors prevent run-all-tests.sh

2016-08-05 Thread Jim Apple
I added the following lines to my /etc/security/limits.conf, then restarted: * hardnofile 1048576 * softnofile 1048576 That seems to have fixed the problem. On Fri, Aug 5, 2016 at 1:10 PM, Jim Apple <jbap...@cloudera.com> wrot

Re: HBase errors prevent run-all-tests.sh

2016-08-05 Thread Jim Apple
/MasterProcWALs/state-3172.log, block=BP-1490185442-127.0.0.1-1456935654337:blk_1073764629_23805): error creating ShortCircuitReplica. java.io.IOException: Illegal seek On Mon, Jul 25, 2016 at 6:31 AM, Jim Apple <jbap...@cloudera.com> wrote: > The NN and DNs have 600-800 f

[Impala-CR](cdh5-trunk) IMPALA-3843: Update warning for non-SSSE3 CPUs

2016-08-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs .. Patch Set 1: Also, as a reminder, the gerrit "Impala" project is now deprecated. To learn how to sw

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-08-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 1: Code-Review+1 Carry my +1 from https://gerrit.cloudera.org/#/c/3401/6 -- To view

[DISCUSS] Criteria for becoming a committer

2016-08-04 Thread Jim Apple
I'd like to make a wiki page on what the criteria are for becoming an official Impala committer. Before doing so, I thought we could talk about what should go in that page. I went to a talk by some experienced ASF people on other projects (Spark, Hadoop, etc.) who said: 1. Every committer should

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3782/2/tests/common

Re: Re: Re: IMPALA-2428 Support multiple-character string as the field delimiter

2016-08-04 Thread Jim Apple
.cn> wrote: > > Hello, Jim Apple. > > For now in my commit, field terminators can not be set to extended ASCIII > characters. > After using statement "create table text_thorn_ecirc_newline(col1 string, > col2 string, col3 int, col4 int) row format delimited fields ter

[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes

2016-08-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3335/2//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes

2016-08-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes .. Patch Set 2: > Hi, Jim. > If it's proper to add a new query test file into > {IM

[Impala-CR](cdh5-trunk) IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables

2016-08-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3266/2//COMMIT_MSG

Re: Podling Report Reminder - August 2016

2016-08-02 Thread Jim Apple
bcc: dev@ Hi John, This is the third reminder we have received to dev@. The report is uploaded and one of our mentors has already signed off. Is there some other thing that needs to be done? Thanks, Jim On Tue, Aug 2, 2016 at 5:07 PM, wrote: > Dear podling, > > This

[Impala-CR](cdh5-trunk) IMPALA-2328 Parquet scan should use min/max stats

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2328 Parquet scan should use min/max stats .. Patch Set 1: As a reminder, the gerrit "Impala" project is now deprecated. To learn now to switch,

[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes .. Patch Set 1: Please add tests. Also, as a reminder, the gerrit "Impala" proj

[Impala-CR](cdh5-trunk) IMPALA-3678: Impala FE SortNode analyzer conjuncts failure

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure .. Patch Set 1: As a reminder, the gerrit "Impala" project is now deprecated. To lear now

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 9: As a reminder, the gerrit "Impala" project is now deprecated. T

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 4: As a reminder, the gerrit "Impala" project is now deprecated. To lear now to sw

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-08-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 2: As a reminder, the gerrit "Impala" project is now deprecated. T

Re: Re: Re: IMPALA-2428 Support multiple-character string as the field delimiter

2016-08-02 Thread Jim Apple
Also, you asked > I'm wondering whether have you ever test these two cases. I do not know. Can you check and report back what you find? On Tue, Aug 2, 2016 at 3:49 PM, Jim Apple <jbap...@cloudera.com> wrote: >> What's more, in this patch, we can use only standard A

Re: Re: Re: IMPALA-2428 Support multiple-character string as the field delimiter

2016-08-02 Thread Jim Apple
> What's more, in this patch, we can use only standard ASCII characters(with > decimal value from 0 to 127) in ascii or octal format to set filed > terminator, but not extended ASCII characters(with decimal value from 128 to > 255) or standard ASCII characters in unicode, decimal or hexadecimal

Re: [Impala-CR](cdh5-trunk) IMPALA-2979: Fix scheduling on remote hosts

2016-08-02 Thread Jim Apple
Please do not commit to the "Impala" gerrit project any more. It is stale and it will remain stale. Use "Impala-ASF" for asf and use private jenkins for private github. Public github (corresponding to public gerrit project "Impala") should be stale at the moment. Please see our branching document

Re: [Impala-CR](cdh5-trunk) IMPALA-2979: Fix scheduling on remote hosts

2016-08-02 Thread Jim Apple
For outdated changes, please use the instructions here: http://www.google.com/url?q=http%3A%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-impala-dev%2F201607.mbox%2F%253CCAC-pSX2sHyqsoxGCCKrqmQbo-jjWdP6CMGoTU_1snuQVkDVg_w%40mail.gmail.com%253E=D=1=AFQjCNFyYa3BsqALZuEvxDzgAV5l4P_evQ "For

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

2016-07-31 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3822 Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. IMPALA-2581: LIMIT can be propagated down into some

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-07-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3782/2/tests/common

Re: Podling Report Reminder - August 2016

2016-07-30 Thread Jim Apple
The report is now available on https://wiki.apache.org/incubator/August2016 On Fri, Jul 29, 2016 at 6:31 PM, Jim Apple <jbap...@cloudera.com> wrote: > yes. > > On Fri, Jul 29, 2016 at 11:18 AM, Henry Robinson <he...@cloudera.com> wrote: >> Is the final version

Re: Podling Report Reminder - August 2016

2016-07-29 Thread Jim Apple
yes. On Fri, Jul 29, 2016 at 11:18 AM, Henry Robinson <he...@cloudera.com> wrote: > Is the final version the one you posted earlier in the thread? > > On 28 July 2016 at 10:02, Jim Apple <jbap...@cloudera.com> wrote: > >> I don't seem to have edit rights to that pag

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-07-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3782/2/tests/common

<    1   2   3   4   5   6   7   8   9   10   >