Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r212993235
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -92,6 +97,18 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213001520
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -238,6 +238,17 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212809165
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -392,29 +393,73 @@ public void
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/438
Another little detail I see that's different is the default locale.
ParseDateFieldUpdateProcessorFactory uses ROOT but ExtractDateUtils uses
ENGLISH. AFAIK, such a difference would appear
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212807806
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -992,6 +992,14 @@ public void testLenient
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212807780
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -992,6 +992,14 @@ public void testLenient
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212802626
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -94,13 +92,15 @@
private final
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212802141
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,59 +167,17 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212802993
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -230,6 +188,95 @@ public void processAdd
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212802686
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -230,6 +188,95 @@ public void processAdd
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212800845
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,13 @@
- -MM-dd'T'HH:mm
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212675378
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -405,4 +435,54 @@ protected void doClose
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212680119
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,59 +167,17 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212677139
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -405,4 +435,54 @@ protected void doClose
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r212679352
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -230,6 +188,95 @@ public void processAdd
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/438
Docs:
`solr/solr-ref-guide/src/uploading-data-with-solr-cell-using-apache-tika.adoc`
Alternatively, perhaps leave that part to me. Or take a 1st cut at it and
I edit from there, which
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212041807
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,11 @@
- -MM-dd'T'HH:mm
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212031794
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,11 @@
- -MM-dd'T'HH:mm
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211821295
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211821003
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211817633
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211817529
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211595662
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211595043
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -0,0 +1,346 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211594271
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -0,0 +1,346 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211594079
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -0,0 +1,346 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211315461
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211255381
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211258577
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211259141
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema-nest.xml ---
@@ -20,6 +20,9 @@
+
--- End diff
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211256948
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -264,7 +309,7 @@ private static Object
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211257783
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210600024
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210478700
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210322853
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -291,4 +302,15 @@ private static String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210322181
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210306003
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -227,27 +225,28 @@ private static String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210290075
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210287034
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210280357
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210273819
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210274031
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -224,9 +225,29 @@ private static String getPathByDocId
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210271399
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/435
I merged it in. Thanks again! Please close this PR. Oddly I can't do
except only by referencing it in a commit message, and I forgot.
If you're interested in more related stuff
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I'm glad you added the comments to the analysis regexps. I don't know why
there are two `.*` (dot-star) in the first regexp.
In JIRA I mentioned the "limit" needs to be re-i
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/435
(At the moment I'm just waiting to hear back from Yetus, the build bot, on
tests & precommit)
---
-
To unsubscribe, e-
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209458462
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -159,8 +170,9 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209442153
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -120,6 +121,16 @@ public
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209442225
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -159,8 +170,9 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209442197
--- Diff:
solr/core/src/test-files/solr/collection1/conf/solrconfig-parsing-update-processor-chains.xml
---
@@ -109,6 +109,21
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209442210
--- Diff:
solr/core/src/test-files/solr/collection1/conf/solrconfig-parsing-update-processor-chains.xml
---
@@ -109,6 +109,21
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209442336
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -896,13 +899,125 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209070327
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209069776
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -70,109 +73,59 @@ public DocTransformer create
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209066014
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -107,8 +107,8 @@ public void testDeeplyNestedURPGrandChild
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209071109
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml ---
@@ -567,7 +567,17
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209067568
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209070656
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -61,6 +57,13 @@
*/
public class
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209068211
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/416
This is pretty close; it has come far. I've applied the patch and started
to make some manipulations. I just have some questions, which I'll ask inline.
Please don't push new changes as it'd
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208928799
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208799313
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208719459
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -343,8 +444,31 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208716790
--- Diff:
solr/core/src/java/org/apache/solr/cloud/api/collections/TimeRoutedAlias.java
---
@@ -141,6 +145,9 @@ public TimeRoutedAlias(String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208717805
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -322,6 +325,104 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208720134
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -322,6 +325,104 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208718224
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -322,6 +325,104 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208446107
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,66 +173,121 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208449633
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -405,4 +449,58 @@ protected void doClose
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208448157
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,66 +173,121 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208445252
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,66 +173,121 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r208445857
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -167,66 +173,121 @@ private String
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/430
RE your last commit, why change `(String)null` to `(XML.Writeable)null`?
The latter exposes internal details/abstractions to a calling class that ought
not to care? (can simply change
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r208249177
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -232,23 +220,22 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r208248179
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -171,59 +162,56 @@ public void
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/430
This is looking really good Moshe; I'll commit later today after I do
precommit & tests
---
-
To unsubscribe, e-mail:
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208093042
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,82 +102,56 @@ public final static void writeXML(Writer out, String
tag
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208092604
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String
tag
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208090646
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207900654
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String
tag
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207899596
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207899864
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String
tag
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207884074
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -453,7 +454,12 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207880574
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -118,16 +122,16 @@ public final static void writeUnescapedXML(Writer
out
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207880020
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,8 +101,12 @@ public final static void writeXML(Writer out, String
tag
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/428
It's coming along great. Please add the following comment at the top of
our parsing method:
```
// see https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8177021
which is fixed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207741161
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -404,6 +404,7 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207741137
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java ---
@@ -114,17 +121,34 @@ private static void writeVal(Writer writer
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207740065
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -126,8 +126,8 @@ public final static void writeUnescapedXML(Writer out
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207741118
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java ---
@@ -114,17 +121,34 @@ private static void writeVal(Writer writer
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207725540
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -172,4 +181,34 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207724560
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -171,36 +162,36 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207724539
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -172,4 +181,34 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207697969
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -912,4 +904,18 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207700607
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -172,4 +181,34 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207699324
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -209,9 +200,8 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207645614
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -116,12 +118,12 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207624001
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -172,4 +179,21 @@ public void init
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207641129
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -50,10 +55,9 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207625264
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AddSchemaFieldsUpdateProcessorFactoryTest.java
---
@@ -63,8 +63,8 @@ public void
101 - 200 of 588 matches
Mail list logo
