[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-12-08 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969364#action_12969364 ] Yonik Seeley commented on LUCENE-2649: -- bq. looks good to me Cool - I'll work up a

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-12-06 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12968451#action_12968451 ] Yonik Seeley commented on LUCENE-2649: -- For the sort-missing-last type of

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-12-06 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12968458#action_12968458 ] Ryan McKinley commented on LUCENE-2649: --- looks good to me bq. we instantiate

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-11-15 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932242#action_12932242 ] Yonik Seeley commented on LUCENE-2649: -- Prompted by Robert's pointer to

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914960#action_12914960 ] Michael McCandless commented on LUCENE-2649: I think we have a synchronization

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914973#action_12914973 ] Yonik Seeley commented on LUCENE-2649: -- bq. It's just that perhaps we should upgrade

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914989#action_12914989 ] Michael McCandless commented on LUCENE-2649: {quote} We just need to watch the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915039#action_12915039 ] Ryan McKinley commented on LUCENE-2649: --- Thanks Mike, I'll take a look and fix the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915072#action_12915072 ] Yonik Seeley commented on LUCENE-2649: -- bq. if you pass a different parser for the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915074#action_12915074 ] Ryan McKinley commented on LUCENE-2649: --- bq. If that were true, it would have broken

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915080#action_12915080 ] Ryan McKinley commented on LUCENE-2649: --- Ok, that makes sense -- what I mean is that

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915084#action_12915084 ] Yonik Seeley commented on LUCENE-2649: -- bq. Ok, that makes sense - what I mean is

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-26 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915106#action_12915106 ] Uwe Schindler commented on LUCENE-2649: --- bq. What you can not do is as for a

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914398#action_12914398 ] Michael McCandless commented on LUCENE-2649: I like where this all is going!!

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-24 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914508#action_12914508 ] Uwe Schindler commented on LUCENE-2649: --- {quote} bq. Uwe, I think we need to keep

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-24 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914515#action_12914515 ] Yonik Seeley commented on LUCENE-2649: -- It feels like incremental improvement keeps

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914044#action_12914044 ] Yonik Seeley commented on LUCENE-2649: -- Now we're talking! Q: why aren't the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914082#action_12914082 ] Ryan McKinley commented on LUCENE-2649: --- bq. Q: why aren't the CachePopulator

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914089#action_12914089 ] Yonik Seeley commented on LUCENE-2649: -- Oh... I mis-matched the parens when I was

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914095#action_12914095 ] Ryan McKinley commented on LUCENE-2649: --- {quote} I think getCachePopulator() should

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914100#action_12914100 ] Yonik Seeley commented on LUCENE-2649: -- bq. In this proposal, you could set the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914109#action_12914109 ] Yonik Seeley commented on LUCENE-2649: -- It's all doable though I guess - even if

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914115#action_12914115 ] Ryan McKinley commented on LUCENE-2649: --- preface, I don't really know how FieldCache

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914123#action_12914123 ] Yonik Seeley commented on LUCENE-2649: -- bq. In solr, is there one FieldCache for all

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914136#action_12914136 ] Yonik Seeley commented on LUCENE-2649: -- Passing it in would also allow a way to get

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914163#action_12914163 ] Ryan McKinley commented on LUCENE-2649: --- Ok, as I look more, I think it may be worth

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914169#action_12914169 ] Yonik Seeley commented on LUCENE-2649: -- Hmmm, that would also seem to transform the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914178#action_12914178 ] Uwe Schindler commented on LUCENE-2649: --- bq. Anyone know what the deal is with

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914185#action_12914185 ] Uwe Schindler commented on LUCENE-2649: --- Yonik: I was expecting this answer... The

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914188#action_12914188 ] Michael McCandless commented on LUCENE-2649: bq. I see no relief for this

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914191#action_12914191 ] Yonik Seeley commented on LUCENE-2649: -- bq. If we like the more general cache, that

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-23 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914194#action_12914194 ] Uwe Schindler commented on LUCENE-2649: --- I just wanted to mention that, so the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913485#action_12913485 ] Michael McCandless commented on LUCENE-2649: bq. Also set the Lucene default

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913503#action_12913503 ] Robert Muir commented on LUCENE-2649: - bq. Also set the Lucene default to true, as I

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913646#action_12913646 ] Michael McCandless commented on LUCENE-2649: bq. I think this is a better

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913647#action_12913647 ] Michael McCandless commented on LUCENE-2649: bq. My motivation is for

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913659#action_12913659 ] Uwe Schindler commented on LUCENE-2649: --- I am also strongly +1 for the additional

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913672#action_12913672 ] Ryan McKinley commented on LUCENE-2649: --- bq. Hmm... I'd rather make an exception to

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913675#action_12913675 ] Uwe Schindler commented on LUCENE-2649: --- bq. Hmm... I'd rather make an exception to

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913677#action_12913677 ] Yonik Seeley commented on LUCENE-2649: -- Regardless of if there is a separate

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913679#action_12913679 ] Michael McCandless commented on LUCENE-2649: bq. Regardless of if there is a

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913680#action_12913680 ] Michael McCandless commented on LUCENE-2649: bq. So how about we add a

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913685#action_12913685 ] Michael McCandless commented on LUCENE-2649: bq. That is OK with me. Would be

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913688#action_12913688 ] Uwe Schindler commented on LUCENE-2649: --- We should also allow the parser to stop

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913703#action_12913703 ] Yonik Seeley commented on LUCENE-2649: -- bq. I all cases this is easily possible by

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913709#action_12913709 ] Uwe Schindler commented on LUCENE-2649: --- It's not more complicated its easier. The

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913710#action_12913710 ] Michael McCandless commented on LUCENE-2649: bq. What's the issue with just

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913712#action_12913712 ] Yonik Seeley commented on LUCENE-2649: -- bq. But we could probably still achieve these

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913734#action_12913734 ] Ryan McKinley commented on LUCENE-2649: --- bq. more performant too (and avoid more

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread J.J. Larrea (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913740#action_12913740 ] J.J. Larrea commented on LUCENE-2649: - I only just waded through this thread, so

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913742#action_12913742 ] Yonik Seeley commented on LUCENE-2649: -- bq. The only cost would be iterating the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread J.J. Larrea (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913795#action_12913795 ] J.J. Larrea commented on LUCENE-2649: - {quote} Actually, that's major - otherwise I

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-22 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913857#action_12913857 ] Ryan McKinley commented on LUCENE-2649: --- bq Is the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-21 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913347#action_12913347 ] Ryan McKinley commented on LUCENE-2649: --- Any thoughts on this? I think the best

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-21 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913353#action_12913353 ] Uwe Schindler commented on LUCENE-2649: --- Also set the Lucene default to true, as I

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-18 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12911128#action_12911128 ] Ryan McKinley commented on LUCENE-2649: --- I thought of an optimization that could

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-18 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12911157#action_12911157 ] Ryan McKinley commented on LUCENE-2649: --- Here is the code for ByteValues that: #

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910513#action_12910513 ] Michael McCandless commented on LUCENE-2649: Looks great! Should we make it

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910539#action_12910539 ] Simon Willnauer commented on LUCENE-2649: - bq. Should we make it optional, whether

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910554#action_12910554 ] Yonik Seeley commented on LUCENE-2649: -- bq. Should we make it optional, whether the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910568#action_12910568 ] Simon Willnauer commented on LUCENE-2649: - bp. Perhaps FieldCache.Parser was

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910576#action_12910576 ] Yonik Seeley commented on LUCENE-2649: -- bq. I guess we need to be able to manually

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910589#action_12910589 ] Simon Willnauer commented on LUCENE-2649: - bq. Also, if I have to list out all the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910591#action_12910591 ] Shai Erera commented on LUCENE-2649: One thing I've wanted to do for a long time, but

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910598#action_12910598 ] Yonik Seeley commented on LUCENE-2649: -- bq. Whatever you call it (using Factory is

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910599#action_12910599 ] Yonik Seeley commented on LUCENE-2649: -- bq. open up FieldCache to allow the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910618#action_12910618 ] Ryan McKinley commented on LUCENE-2649: --- This is a band-aid, but we could consider

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910625#action_12910625 ] Shai Erera commented on LUCENE-2649: bq. Are there any advantages to using payloads

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910628#action_12910628 ] Ryan McKinley commented on LUCENE-2649: --- Uwe: For DocTerms the approach is not

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910635#action_12910635 ] Yonik Seeley commented on LUCENE-2649: -- bq. public void setCacheValidBitsForFields(

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910640#action_12910640 ] Ryan McKinley commented on LUCENE-2649: --- oh right -- thats true. Is a global flag

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910653#action_12910653 ] Ryan McKinley commented on LUCENE-2649: --- FYI, I like the idea of revisiting the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910654#action_12910654 ] Uwe Schindler commented on LUCENE-2649: --- I am against the configuration option to

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910660#action_12910660 ] Mark Miller commented on LUCENE-2649: - bq. I was suggesting handling it the same way

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910663#action_12910663 ] Ryan McKinley commented on LUCENE-2649: --- I'm all for dropping the static flag and

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Marvin Humphrey (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910668#action_12910668 ] Marvin Humphrey commented on LUCENE-2649: - So: Please don't add any static

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910677#action_12910677 ] Michael McCandless commented on LUCENE-2649: I know it's only 3% (for ints...

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910699#action_12910699 ] Yonik Seeley commented on LUCENE-2649: -- bq. Let's try to find some baby-step (even if

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910700#action_12910700 ] Ryan McKinley commented on LUCENE-2649: --- Are people generally ok with the idea of

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910707#action_12910707 ] Uwe Schindler commented on LUCENE-2649: --- I am against that option! No static

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910711#action_12910711 ] Ryan McKinley commented on LUCENE-2649: --- I like the idea of optionally caching the

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910717#action_12910717 ] Yonik Seeley commented on LUCENE-2649: -- If ya care - don't pass a null parser!

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910728#action_12910728 ] Ryan McKinley commented on LUCENE-2649: --- bq. If ya care - don't pass a null parser!

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910736#action_12910736 ] Yonik Seeley commented on LUCENE-2649: -- bq. What if I care, but somethign else (that

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910746#action_12910746 ] Yonik Seeley commented on LUCENE-2649: -- bq. How would that work? We could start off

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910805#action_12910805 ] Uwe Schindler commented on LUCENE-2649: --- Supporting different parsers is not an

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-16 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910446#action_12910446 ] Ryan McKinley commented on LUCENE-2649: --- See some discussion here:

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-16 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910461#action_12910461 ] Uwe Schindler commented on LUCENE-2649: --- That looks exactly like I proposed it! The

[jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs

2010-09-16 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910464#action_12910464 ] Uwe Schindler commented on LUCENE-2649: --- When this is committed, we can improve also