[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-03 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161556711 @juherr I guess nobody is using buggy library 5.14.1 or 5.14.2. Since we did rely on separator "," the users were facing this issue and most prob

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-03 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-16178 @juherr What about to replace `","` with `", "` in surefire parameter value in TestNG provider. Do you think this would come over the

[GitHub] maven-surefire pull request: [SUREFIRE-1202] Allow rerunFailingTes...

2015-12-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/108#issuecomment-161337141 Try to build IT with your code with more realistic counts, but the fail-fast feature would not be coherent due to concurrency problem across forks. --- If your

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161430409 @juherr IIUC testng 5.14.1 - 5.14.3 are buggy and can be excluded from the test set. What exactly the bug is? You mean the ClassLoader issue? What did

[GitHub] maven-surefire pull request: [SUREFIRE-1202] Allow rerunFailingTes...

2015-12-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/108#issuecomment-161285312 @seanf Can you edd integration test? You can add new test method to an existing IT. --- If your project is set up for it, you can reply to this email

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160475738 @juherr Excellent! Do you need any help from my side? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160478603 Let me see tomorrow or on Tuesday. You did a lot today :+1: but It's time to sleep. Good progress. Thx. --- If your project is set up for it, you can

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160393834 Your IT has this POM https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/src/test/resources/testng-listener-reporter/pom.xml

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160397879 It's hard to debug the IT because @After cleaned up previous tests in `target`. Good inspiration is `Surefire1158RemoveInfoLinesIT` and method `unpack

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160416265 @juherr Please mention the configuration of reported in surefire documentation. I guess the returned value from `convertReporterConfig()` method should

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160430883 We can add system-dependency to the pom.xml of IT and add guice-2.0.jar on the same level with pom.xml of the IT in the file system. You can extract

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160335576 No worries. :-) I am glad that you continue with this issue. Btw I finished previous fix in surefire and I am trying to dig into this issue

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160173397 Alright I go it. You must use profile instead: `.addGoal( "-P testng6" )` and the profile `testng6` should have dependencies with

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160195132 @juherr Try to commit what you have and I will check it out. Overriding last commit is just fine. --- If your project is set up for it, you can reply

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160193148 6.9.9 works in my dummy project, then yes. Latest greatest. Feel free to override the last commit. On Fri, Nov 27, 2015 at 8:10 PM, Julien Herr

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-26 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159998029 You can override the TestNG version by `resetInitialGoals( version )` method and you can see the usage of the method in `CheckTestNgVersionsIT`. The version

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-25 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159816428 @juherr Can you add an integration test. I guess there is another API for reporter so that maybe we are missing one of them in our integration tests (testng 6.0

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-22 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-158758087 @juherr the build is successful, I will check the changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven pull request: String handling issues identified by PMD

2015-11-21 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/72#issuecomment-158668300 Nowadays execution time of array allocation is logarithmic function(array.length). One way or another since of Java 6 the the objects are allocated in the stack

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-20 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-158545841 @juherr I will run the build and i will check the code. Thx for the effort. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-10-13 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-147730852 @juherr Thx I will include it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145664550 This feature has limitations own limitations, see the page after successful release https://maven.apache.org/surefire/maven-surefire-plugin/examples/skip

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145510139 I will start the release maybe today or tomorrow. All depends on my spare time. On Mon, Oct 5, 2015 at 1:54 PM, Benjamin Winterberg < notific

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145497939 It will. On Mon, Oct 5, 2015 at 12:43 PM, Benjamin Winterberg < notificati...@github.com> wrote: > Will skipAfterFailureC

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145532182 Benjamin, do you expect slight changes, let me know. Can you please declare Failsafe Version 2.19-SNAPSHOT and run your tests. Let me know your impression

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145563402 Usually it works for me. I am not behind proxy and use default settings.xml. On Mon, Oct 5, 2015 at 4:38 PM, Benjamin Winterberg < notific

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145584123 If it still does not help try with this URL https://repository.apache.org/content/groups/snapshots On Mon, Oct 5, 2015 at 4:38 PM, Benjamin

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-10-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-145583437 Maybe this helps http://stackoverflow.com/questions/7713996/is-there-a-way-to-make-maven-download-snapshot-versions-automatically On Mon, Oct 5

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-143955811 @agudian I would like to include you into our discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-143954421 We can try with junit4 of course. On Tue, Sep 29, 2015 at 12:59 AM, lamyaa <notificati...@github.com> wrote: > @Tibor17 <https:

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-14404 @juherr Can you open issue in TestNG and discussion with @cbeust, add a link in surefire comment in our code describing why we have such branching. That's

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144006895 @juherr Regarding https://github.com/juherr/maven-surefire/commit/5ac824733ea4b8201e8acd5c1d6cead0301340ab why the parameters are not taking any effect

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144004816 @juherr LGTM. I would include this in 2.19. Should we postpone suite thread count in the future release? Do we need this change https://github.com/juherr

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144005702 @juherr Can you please add the configuration detail in this use case in the documentation [1] on the line 173 ? I guess all people would be thankful. [1

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144096998 @juherr I mean the configuration of plugin to be added in the documentation [1] on the line 173 ? [1] maven-surefire-plugin/src/site/apt/examples

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144211832 I made the required changes and going to push it to master. I have to postpone the release because I found that parameter [1] interrupted the build

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144214974 Thx for contributing. This PR was updated and merged with master. Feel free to close it. --- If your project is set up for it, you can reply to this email

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143760174 Is there the same principle with thread count for suites? I did not test suite thread count because I do not have IT. Can you try? On Mon, Sep 28

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143766756 Because we were always dependent on 5.7 and the users may still rely on it. It is question of one minute to crate Utility class in the module surefire-testng

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143790836 Alright create `TestNG510Configurator` and register it in `AbstractSurefireMojo` and increate the version in surefire-testng POM. --- If your project is set up

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143791336 The style with reflection is usually in junit provider, but you'r right, forget reflection in testng. --- If your project is set up for it, you can reply

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143758786 All you need to do is to call this method with Java Reflection. There is `surefire-testng-util` module. You should create reflection utility

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143793736 There is already version range [5.3,6.4] you should split which means to split in [5.3,5.10) and [5.10,6.4] update only `TestNGMapConfigurator`. Do

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143683397 Since 5.10? Hm, I was testing with 6.9.x and the number of threads was 10 instead of 30 configured in `dataproviderthreadCount`. Pending question - we

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143544670 @lamyaa I applied the local change and executed XmlReporterRunTimeIT. The balancer is really applied and Test1 was really executed within 600 millis

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143595094 @lamyaa Can I finish it unless you you are already in progress? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-143595965 This issue is not in the list of release Version 2.19. Would you have the spare time to complete till Tuesday afternoon CET? Can I start the release Vote

[GitHub] maven-surefire pull request: Get tests to run from external source...

2015-09-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/74#issuecomment-143642564 Hello guys, I have implemented new streamer of classes. The problem was with old streamer which was able to dispatch test class name to the forked JVM

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143606448 @lamyaa Pls close this pull-request. I have pushed the fix including your IT. Thx for the IT, it was very nice work. --- If your project is set up

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143505456 @juherr This is the IT, but the problem is in TestNG because the concurrency remains 10 even if dataproviderthreadcount=30. Meanwhile I reported issue

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/106 [SUREFIRE-1179] integration test for #105 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire s4 Alternatively you

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-24 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-142898887 @juherr That's pity. I will postpone the release in a week. Maybe I could help you to write the IT in multiple commits. --- If your project is set up

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-24 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-142905726 @juherr I have to wait for #98 anyway which is critical bug and the guys in Maven expect the fix. So we may take this commit as it is, that's fine, and prove

[GitHub] maven-surefire pull request: SUREFIRE-790 Added support for execut...

2015-09-24 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/2#issuecomment-142837160 Enabled by default would mean to introduce a new feature and new bugs and requirements in Jira. The reason why we want the users to implement the API

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-142740267 @juherr Please consider these integration tests as a hint. These are typical tests using `parallel` parameter. `CheckTestNgGroupThreadParallelIT

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-142747818 Hi @lamyaa What should we do with this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2015-09-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-142758232 @lamyaa Did you have time to run this test using the fix we talked about in `SUREFIRE-1144`? Is the execution time calculation broken

[GitHub] maven-surefire pull request: SUREFIRE-790 Added support for execut...

2015-09-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/2#issuecomment-142749714 @kpiwko @gastaldi @marcusholl What can we do about this old issue? My suggestion is to propose SPI in Surefire 3.x where hacking system

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-20 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141812040 Agreed, we can improve later on. Then the TestNG project should be informed that we continue using old configuration method. I have to ask you

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-19 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141693490 Well regarding deadline of 2.19 is as I said EO September, and 2.20 is unknown but I want to have it till the EO 2015. You know what would be great is to use

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-18 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141484326 LGTM but missing ITs. You can use the one in Jira and create new for testsuites. See how the ITs are written in surefire-integration-tests module. I guess

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-18 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141484970 If you have exps with overriding git commit, feel free to override it adding the ITs and we will have single commit or squash the commits. --- If your project

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-17 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-141173488 @lamyaa I will have a look into this test. On Thu, Sep 17, 2015 at 7:19 PM, lamyaa <notificati...@github.com> wrote: > @Tibor

[GitHub] maven-surefire pull request: [SUREFIRE-524] Forked Process not ter...

2015-09-15 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/104 [SUREFIRE-524] Forked Process not terminated if maven process aborted. Provide means to clean up. Fix for https://issues.apache.org/jira/browse/SUREFIRE-524 You can merge this pull

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-15 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140308340 Yes a new pull request would be great. I have made a lot of rework in surefire. Most probably this branch is not able to merge. On 9/14/15, lamyaa

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-13 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139858232 @lamyaa I think I found a solution which works on my side with non-parallel tests. Feel free to tell me what you think about my hypothesis. Can you

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-13 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139915061 IMHO all we need to do is to change the last parameter: `createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-06 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-138134180 @lamyaa Sorry for waiting so long time. I have finished issue 580. I will have a look on this since now. --- If your project is set up for it, you can

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-09-06 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-09-06 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/103#issuecomment-138125021 This PR has been merged with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-136962698 Pls import code style to your IDE. https://maven.apache.org/developers/conventions/code.html#IntelliJ_IDEA_4.5 For instance in IntelliJ IDEA you import

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-136964837 Why you have `rerunAtEnd( reporterFactory, result.getFailures() ); ` after `runNotifier.fireTestRunFinished( result );`? I am not sure if test report

[GitHub] maven-surefire pull request: [SUREFIRE-580] Allow "fail fast" or s...

2015-09-02 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/103 [SUREFIRE-580] Allow "fail fast" or stop running on first failure Solution for https://issues.apache.org/jira/browse/SUREFIRE-580 Refactoring and InputStream in forked jvm

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137228645 The junit47 provider runs all reruns in the after phase. If you use this provider, would it help the users? We should mention few differences between providers

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-25 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/99#issuecomment-134512694 This was merged with master. I am wondering why GitHub did not close this PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-25 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/99#issuecomment-134726299 @lamyaa Pls close this pr. Thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-24 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/99#issuecomment-134410478 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-surefire pull request: [SUREFIRE-1173] Fix redirected link o...

2015-08-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/101#issuecomment-133910961 The /components/ URL must not be visible to our users because it's an internal URL. The non-components page must be used. Notice: content is in fact

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-23 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/99#issuecomment-133976477 The build does not pass because the file `surefire-test-report.xsd` is missing the license. Feel free to use the license from whatever POM.xml as a XML

[GitHub] maven-surefire pull request: [SUREFIRE-1067] Nested causes conflat...

2015-07-02 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-20 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113717735 try-with-resources is cool. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire pull request: [SUREFIRE-1067] Nested causes conflat...

2015-06-05 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/97 [SUREFIRE-1067] Nested causes conflated with wrapper exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire s2

[GitHub] maven-shared pull request: [MSHARED-418] Verifier should not use h...

2015-06-05 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-shared/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-shared pull request: Verifier should not use hard coded CLI ...

2015-06-03 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-shared/pull/9 Verifier should not use hard coded CLI options without modifying them You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-shared

[GitHub] maven-surefire pull request: [SUREFIRE-1158] Remove console printl...

2015-05-31 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/95 [SUREFIRE-1158] Remove console println of TestNG configurator Some refactoring and implementation for this issue. These lines are printed with debug (mvn -X) or show-errors (mvn -e

[GitHub] maven-surefire pull request: [SUREFIRE-1153] Take includes into ac...

2015-05-28 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-surefire pull request: [SUREFIRE-1153] Take includes into ac...

2015-05-19 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/94 [SUREFIRE-1153] Take includes into account when using test/it.test property As discussed we Andreas we agreed on SUREFIRE-1153 acceptance where the includes/excludes list is ignored as soon

[GitHub] maven-surefire pull request: [SUREFIRE-1017] Failures do not show ...

2015-05-10 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/92 [SUREFIRE-1017] Failures do not show test-package since 2.13 https://issues.apache.org/jira/browse/SUREFIRE-1017 You can merge this pull request into a Git repository by running: $ git

[GitHub] maven-surefire pull request: [SUREFIRE] Refactoring

2015-05-06 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-surefire pull request: [SUREFIRE] Refactoring

2015-05-05 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/91 [SUREFIRE] Refactoring + Java 5 for-each instead of Iterator + optimized loops + optimized branching + optimized use of this pointer + using Java Generics instead

[GitHub] maven-surefire pull request: [SUREFIRE-1024] verify goal ignores...

2015-04-22 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-surefire pull request: [SUREFIRE-1024] verify goal ignores...

2015-04-04 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/87 [SUREFIRE-1024] verify goal ignores dependenciesToScan parameter when checking tests existence The problem of SUREFIRE-1024 was with failsafe plugin which however executed integration-test

[GitHub] maven-surefire pull request: [SUREFIRE] Run individual methods wit...

2015-01-26 Thread Tibor17
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/83 [SUREFIRE] Run individual methods with junit48 PR #75. Still in progress. Created TestListResolver with unit tests and IT. TODO: fix the build, renew IT tests which were

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
in ThreadLocal copy for certainly small thread pool. I didn't measure the time spent on flushing ByteBuffer with 256KB byte array, might be interesting too. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
with Java Threads - it's still the same Thread as it was before with more fancy join-functionality for us developers - nothing special - no direct selection of processor in Java code. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver

Re: Preview release: Plexus Archiver multithreaded Zip edition

2015-01-12 Thread tibor17
should have DMA access to that memory this way. - BR, tibor17 -- View this message in context: http://maven.40175.n5.nabble.com/Preview-release-Plexus-Archiver-multithreaded-Zip-edition-tp5822942p5823268.html Sent from the Maven Developers mailing list archive at Nabble.com

[GitHub] maven pull request: Improved visibility of collections and variabl...

2015-01-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/34#issuecomment-68697988 Hi Jason, the point of this patch is to force the devs to write `safe` code. Immediately as I have seen the code I recognized, same as Herve stated in my email

[GitHub] maven pull request: Improved visibility of collections and variabl...

2015-01-05 Thread Tibor17
Github user Tibor17 closed the pull request at: https://github.com/apache/maven/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: Improved visibility of collections and variabl...

2015-01-05 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/34#issuecomment-68702414 Jason, Don't worry about this patch, I'll close it - since I have private copy and the diff. I will wait for you patch, and then I'll go through the diff and I

[GitHub] maven pull request: Improved visibility of collections and variabl...

2015-01-02 Thread Tibor17
Github user Tibor17 commented on the pull request: https://github.com/apache/maven/pull/34#issuecomment-68554366 @hboutemy @jvanzyl Any objections to push this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

<    1   2   3   4   5   6   >