---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/#review48827
---
Bad patch!
Reviews applied: [23771]
Failed command: git apply
On July 24, 2014, 6:23 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 2055-2115
https://reviews.apache.org/r/22796/diff/7/?file=634637#file634637line2055
I'm a bit puzzled by this test, I don't think we need this test since
the framework cannot receive _any_ events
On July 24, 2014, 6:23 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 4293-4296
https://reviews.apache.org/r/22796/diff/7/?file=634636#file634636line4293
It looks like this NULL case is only possible for the rescind timeout,
since all synchronous calls to removeOffers
On July 22, 2014, 12:40 a.m., Ben Mahler wrote:
Operators will likely want a way to see which slaves are
activated/deactivated.
Perhaps we'll want to expose additional endpoints like:
Write (POST):
/slaves/deactivate (this review)
/slaves/activate (follow up?)
Read
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22754/
---
(Updated July 28, 2014, 4:48 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 28, 2014, 5:39 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 28, 2014, 5:40 p.m.)
Review request for mesos.
Bugs: MESOS-857
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/23#discussion_r15443932
--- Diff: src/master/flags.hpp ---
@@ -61,7 +61,8 @@ class Flags : public logging::Flags
add(Flags::work_dir,
work_dir,
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
---
(Updated July 28, 2014, 12:12 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/
---
Review request for mesos.
Bugs: MESOS-1635
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/
---
(Updated July 28, 2014, 7:46 p.m.)
Review request for mesos, Adam B and Ben
See https://builds.apache.org/job/mesos-reviewbot/1240/
--
[...truncated 3263 lines...]
copying src/mesos.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO
copying
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/
---
(Updated July 28, 2014, 12:58 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/
---
(Updated July 28, 2014, 12:59 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 28, 2014, 1 p.m.)
Review request for mesos, Benjamin Hindman and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 28, 2014, 1:01 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23911/
---
(Updated July 28, 2014, 1:22 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/
---
(Updated July 28, 2014, 1:24 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22796/
---
(Updated July 28, 2014, 8:28 p.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22796/
---
(Updated July 28, 2014, 8:34 p.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated July 28, 2014, 8:34 p.m.)
Review request for mesos, Ian Downes and
On July 24, 2014, 6:27 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 3451-3457
https://reviews.apache.org/r/22796/diff/7/?file=634636#file634636line3451
I forgot to mention the bug here in my comment!
With using an offerTimeout function, you can properly get the
On July 24, 2014, 6:27 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 3451-3457
https://reviews.apache.org/r/22796/diff/7/?file=634636#file634636line3451
I forgot to mention the bug here in my comment!
With using an offerTimeout function, you can properly get the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/#review48909
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21750/#review48908
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/#review48910
---
Ship it!
Great, looks like os::getenv is the only remaining LOG
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/#review48911
---
Sorry, one note I missed about cleaning up the existing error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/#review48738
---
src/slave/containerizer/docker.hpp
On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, lines 521-523
https://reviews.apache.org/r/23771/diff/2/?file=638779#file638779line521
Use a helper function to construct the docker container name.
Ignore this. This is for version2.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/#review48912
---
Ship it!
Looks good, just a few logging cleanups below.
On July 28, 2014, 9:23 p.m., Timothy Chen wrote:
src/master/master.cpp, line 1679
https://reviews.apache.org/r/21750/diff/3/?file=598185#file598185line1679
When offers are removed (which I think is the only path of how Offer
can no longer exist), the offer object is also being
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21750/#review48919
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/#review48918
---
Thanks for sending this Ken! There is one small bug that would be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/
---
(Updated July 28, 2014, 3:15 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/
---
(Updated July 28, 2014, 3:33 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/
---
(Updated July 28, 2014, 3:36 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/
---
(Updated July 28, 2014, 10:36 p.m.)
Review request for mesos, Adam B and Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 28, 2014, 3:38 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/
---
(Updated July 28, 2014, 3:53 p.m.)
Review request for mesos, Dominic Hamon and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/#review48925
---
support/timed_tests.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/#review48926
---
Ship it!
Looks good, just a few minor cleanups and we can get this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/#review48929
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/
---
(Updated July 28, 2014, 4:41 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 28, 2014, 4:44 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23955/
---
(Updated July 28, 2014, 11:59 p.m.)
Review request for mesos, Chi Zhang and
On July 25, 2014, 11:54 p.m., Ian Downes wrote:
src/tests/port_mapping_tests.cpp, line 125
https://reviews.apache.org/r/23955/diff/1/?file=642538#file642538line125
MNT_DETACH makes it a lazy unmount - how do you know the mount has
actually been unmounted by the time you attempt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23955/#review48943
---
Ship it!
Ship It!
- Chi Zhang
On July 28, 2014, 11:59 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48946
---
I think it is worth mentioning that we are doing this because
See https://builds.apache.org/job/mesos-reviewbot/1241/
On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.hpp, line 48
https://reviews.apache.org/r/23771/diff/2/?file=638778#file638778line48
I don't see the implementation of this function?
Sorry it was used but then removed later, forgot to delete the def.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48952
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/
---
(Updated July 29, 2014, 1:04 a.m.)
Review request for mesos, Benjamin Hindman,
On July 24, 2014, 6:27 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 3451-3457
https://reviews.apache.org/r/22796/diff/7/?file=634636#file634636line3451
I forgot to mention the bug here in my comment!
With using an offerTimeout function, you can properly get the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23698/#review48950
---
Looks great, Craig. Just a few style/naming/comment nits, and a
On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, lines 839-840
https://reviews.apache.org/r/23771/diff/3/?file=643413#file643413line839
Hum, this looks problematic to me. These two static variables will be
initialized even before 'main' is called, at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/#review48959
---
3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp
On July 29, 2014, 12:55 a.m., Ian Downes wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 2184-2186
https://reviews.apache.org/r/24020/diff/1/?file=643992#file643992line2184
Seems this function is poorly named if it can optionally also remove
filters on
Hello,
I have a follow-up question on launching Mesos framework.
I looked at Marathon and Aurora and still couldn’t find a way to register a
Framework so that the Scheduler component runs on a Slave node.
I’d like to implement a new framework which runs its Scheduler on a Slave node
like the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
---
(Updated July 29, 2014, 5:14 a.m.)
Review request for mesos, Chi Zhang and Ian
On July 29, 2014, 12:24 a.m., Chi Zhang wrote:
I think it is worth mentioning that we are doing this because _recover
solely relies on the information on vethX so we want that port ranges on
vethX are always more complete than those on eth0 or lo.
also don't we need to loosen some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
---
(Updated July 29, 2014, 5:44 a.m.)
Review request for mesos, Chi Zhang and Ian
61 matches
Mail list logo
