---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/#review56897
---
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/#review56900
---
Patch looks great!
Reviews applied: [26674]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/#review56901
---
Bad patch!
Reviews applied: [26071, 26796, 26071]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26800/#review56907
---
Patch looks great!
Reviews applied: [26715, 26799, 26800]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26798/#review56909
---
Patch looks great!
Reviews applied: [26798]
All tests passed.
-
On Oct. 13, 2014, 6:21 a.m., Jiang Yan Xu wrote:
LGTM. Let's see how ZOOKEEPER-2049 is going.
Patch got accepted and committed into zookeeper.
- Till
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/
---
(Updated Oct. 16, 2014, 10:13 a.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/
---
(Updated Oct. 16, 2014, 11:12 a.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 16, 2014, 11:14 a.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 16, 2014, 11:17 a.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56926
---
I might want a loader, so the user knows that something is going
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
---
(Updated Oct. 16, 2014, 12:57 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/#review56928
---
Ship it!
Not sure what you mean by side-effects of dlclose on OSX.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/#review56934
---
Patch looks great!
Reviews applied: [26674, 26789]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26798/
---
(Updated Oct. 16, 2014, 5:17 p.m.)
Review request for mesos and Vinod Kone.
On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote:
support/apply-review.sh, line 20
https://reviews.apache.org/r/26798/diff/1/?file=722887#file722887line20
Update usage?
Cody Maloney wrote:
I was explicitly leaving it out because process wise committers should
look at the diff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
---
(Updated Oct. 16, 2014, 5:38 p.m.)
Review request for mesos, Michael Lunøe and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/#review56948
---
Bad patch!
Reviews applied: [26797]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56949
---
Ship it!
Looks good to me :)
- Michael Lunøe
On Oct. 16, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26571/#review56957
---
Ship it!
Thanks Till!
- Jiang Yan Xu
On Oct. 16, 2014, 3:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26715/#review56959
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 16, 2014, 1:09 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26799/#review56960
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 16, 2014, 4:52 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26800/#review56961
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 16, 2014, 4:50 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/
---
Review request for mesos, Ben Mahler, Vinod Kone, and Bill Farner.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/#review56854
---
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56964
---
Ship it!
I doubt my shipit counts... but looks good to me. :)
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56963
---
src/log/recover.cpp
On Oct. 16, 2014, 2:23 p.m., Niklas Nielsen wrote:
src/master/flags.hpp, lines 313-315
https://reviews.apache.org/r/26674/diff/2/?file=722701#file722701line313
Thanks for clarifying! The order of the paragraphs seems a bit off
though: First the json file, then the caveat on file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/#review56966
---
src/tests/module_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/
---
(Updated Oct. 16, 2014, 6:39 p.m.)
Review request for mesos, Ben Mahler, Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/#review56968
---
Patch looks great!
Reviews applied: [26674, 26071, 26796]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
---
(Updated Oct. 16, 2014, 6:41 p.m.)
Review request for mesos, Michael Lunøe and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/
---
(Updated Oct. 16, 2014, 2:43 p.m.)
Review request for mesos, Benjamin Hindman
On Oct. 16, 2014, 12:59 p.m., Till Toenshoff wrote:
src/module/manager.cpp, lines 195-197
https://reviews.apache.org/r/26789/diff/2/?file=722734#file722734line195
This sounds very temporarily almost like a TODO.
Fixed the explanation.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/
---
(Updated Oct. 16, 2014, 2:43 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/#review56970
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 16, 2014, 11:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56971
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 16, 2014, 6:39 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56972
---
Ship it!
Thank!!
- Bill Farner
On Oct. 16, 2014, 6:39 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26817/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56973
---
src/log/recover.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/
---
(Updated Oct. 16, 2014, 7:11 p.m.)
Review request for mesos, Ben Mahler, Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56976
---
Ship it!
src/log/recover.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
(Updated Oct. 16, 2014, 3:19 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
(Updated Oct. 16, 2014, 3:20 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
---
(Updated Oct. 16, 2014, 3:22 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
---
(Updated Oct. 16, 2014, 3:23 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/
---
(Updated Oct. 16, 2014, 3:23 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:26 p.m.)
Review request for mesos and Vinod Kone.
On Oct. 7, 2014, 11:50 a.m., Vinod Kone wrote:
src/master/master.cpp, line 2264
https://reviews.apache.org/r/26382/diff/1/?file=714252#file714252line2264
invalid offers is a bit tricky. because there are several subcases here.
1) framework used the offer after the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26798/#review56980
---
Patch looks great!
Reviews applied: [26798]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review56979
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/#review56988
---
Ship it!
I'll fix the last nits.
src/module/manager.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/
---
(Updated Oct. 16, 2014, 4:15 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 1:20 p.m.)
Review request for mesos, Vinod Kone and
On Oct. 16, 2014, 12:43 p.m., Bill Farner wrote:
include/mesos/mesos.proto, line 664
https://reviews.apache.org/r/26382/diff/2/?file=723164#file723164line664
`required` unsafe to introduce without a default, right? IIUC it means
you can't read a message that doesn't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review56987
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26767/
---
(Updated Oct. 16, 2014, 8:53 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/
---
(Updated Oct. 16, 2014, 8:53 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56999
---
Patch looks great!
Reviews applied: [17431]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26825/
---
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1712 and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2179/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26827/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1881
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review57016
---
src/log/recover.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review57018
---
Patch looks great!
Reviews applied: [26815]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/
---
(Updated Oct. 16, 2014, 10:13 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26797/#review57021
---
Bad patch!
Reviews applied: [26674]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/#review57013
---
src/Makefile.am
https://reviews.apache.org/r/26071/#comment97452
] Master
20141016-223858-3193029443-47942-16220 (pietas.apache.org) started on
67.195.81.190:47942
I1016 22:38:58.464375 16248 master.cpp:358] Master only allowing authenticated
frameworks to register
I1016 22:38:58.464436 16246 recover.cpp:451] Replica is in STARTING status
I1016 22:38:58.464455
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review57023
---
Bad patch!
Reviews applied: [26817, 26382]
Failed command: git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review57022
---
What testing did you do?
Also, let's use another term than 'hooked'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/#review57025
---
Ship it!
LGTM
)
to leveldb took 306803ns
I1016 22:38:58.464303 16240 replica.cpp:320] Persisted replica status to
STARTING
I1016 22:38:58.464306 16248 master.cpp:312] Master
20141016-223858-3193029443-47942-16220 (pietas.apache.org) started on
67.195.81.190:47942
I1016 22:38:58.464375 16248 master.cpp:358] Master
request for
framework 'default' at
scheduler-0552db12-4b6e-4d3f-8231-b8555d10a558@67.195.81.187:53609
I1016 22:50:13.211166 28455 master.cpp:1321] Authorizing framework principal
'test-principal' to receive offers for role '*'
I1016 22:50:13.211333 28464 master.cpp:1426] Registering framework
20141016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26827/#review57026
---
Ship it!
Thanks! I'll get this committed shortly.
On Oct. 16, 2014, 9:58 p.m., Jay Buffington wrote:
src/log/recover.cpp, lines 298-302
https://reviews.apache.org/r/26815/diff/3/?file=723145#file723145line298
You missed --path:
mesos-log initialize --path=PATH
I've committed a fix.
- Jie
On Oct. 16, 2014, 10:54 p.m., Ben Mahler wrote:
Thanks! I'll get this committed shortly.
FYI I cleaned up the commit message to not reference reviewbot, since it's not
a concept in the source:
commit f6aa4b04d2e669e1e6cbcaf8fb708ab1cd6410eb
Author: Cody Maloney c...@mesosphere.io
Date:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/#review57029
---
Ship it!
Thanks Cody! I will let adam commit this.
- Ben Mahler
metadata (8
bytes) to leveldb took 306803ns
I1016 22:38:58.464303 16240 replica.cpp:320] Persisted replica status to
STARTING
I1016 22:38:58.464306 16248 master.cpp:312] Master
20141016-223858-3193029443-47942-16220 (pietas.apache.org) started on
67.195.81.190:47942
I1016 22:38:58.464375 16248
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26838/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26838/#review57038
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 16, 2014, 4:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26838/#review57040
---
Ship it!
Ship It!
- Ian Downes
On Oct. 16, 2014, 4:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26838/#review57041
---
src/tests/module_tests.cpp
On Oct. 16, 2014, 10:54 p.m., Ben Mahler wrote:
support/verify-reviews.py, lines 84-87
https://reviews.apache.org/r/26827/diff/1/?file=723390#file723390line84
We probably shouldn't still be saying Now apply this review and then
say skip it.
I'll adjust this for you
Yes - it turned out not to be enough. Will disable tests so we have more
time to fix this properly.
Niklas
On 16 October 2014 16:20, Vinod Kone vinodk...@gmail.com wrote:
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26843/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho:
On Oct. 16, 2014, 4:20 p.m., Vinod Kone wrote:
src/tests/module_tests.cpp, line 332
https://reviews.apache.org/r/26838/diff/1/?file=723475#file723475line332
What happens if this test fails and this line doesn't get executed?
Does it affect other tests? If yes, thats bad.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26843/#review57050
---
Ship it!
Ah, much nicer, thanks Jie!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26825/#review57056
---
Patch looks great!
Reviews applied: [26825]
All tests passed.
-
On Oct. 16, 2014, 11:40 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/fcntl.hpp, line 24
https://reviews.apache.org/r/26843/diff/1/?file=723488#file723488line24
Any TODO you can think of to avoid needing to deal with multiple calls
to fcntl?
Added a
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2455/changes
Changes:
[yujie.jay] Added an advisory message reminding the user to initialize the log.
[yujie.jay] Fixed a typo in the last commit.
[yujie.jay] Supported O_CLOEXEC
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26846/
---
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26699/
---
(Updated Oct. 17, 2014, 12:26 a.m.)
Review request for mesos, Adam B, Ben
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2181/changes
Changes:
[yujie.jay] Added an advisory message reminding the user to initialize the log.
[yujie.jay] Fixed a typo in the last commit.
[yujie.jay] Supported O_CLOEXEC for os::open on all platforms.
On Oct. 15, 2014, 4:03 a.m., Adam B wrote:
src/slave/slave.cpp, lines 938-948
https://reviews.apache.org/r/26699/diff/1/?file=720970#file720970line938
Couldn't the Slave and the SUM get out of sync here? Right now, the SUM
will flush its pending status updates as soon as a new
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26700/
---
(Updated Oct. 17, 2014, 12:30 a.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26702/
---
(Updated Oct. 17, 2014, 12:31 a.m.)
Review request for mesos, Adam B, Ben
1 - 100 of 120 matches
Mail list logo
