If you are not using mem_rss_bytes, mem_file_bytes and mem_anon_bytes
from /monitor/statistics.json prior to 0.23.0, you can stop reading.
Hi Community,
I would like to send out an update from MESOS-2014:
Targeted for 0.23.0:
mem_total_bytes will be introduced to replace mem_rss_bytes.
, visit:
https://reviews.apache.org/r/33329/#review80984
---
On April 20, 2015, 7:16 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
3622165af064a1f0a9d461af0e1d0d88a352d4a8
Diff: https://reviews.apache.org/r/33329/diff/
Testing
---
Thanks,
Chi Zhang
: https://reviews.apache.org/r/33329/diff/
Testing
---
Thanks,
Chi Zhang
://issues.apache.org/jira/browse/mesos-2573
Repository: mesos
Description
---
Simplified ROOT_CGROUPS_Listen test.
Diffs
-
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/32955/diff/
Testing
---
Thanks,
Chi Zhang
://issues.apache.org/jira/browse/mesos-2573
Repository: mesos
Description
---
Simplified MemUsage test.
Diffs
-
src/tests/isolator_tests.cpp 535e9afd942a2be507f69bf8bd9bb32f41a85a3a
Diff: https://reviews.apache.org/r/32956/diff/
Testing
---
Thanks,
Chi Zhang
/network/port_mapping.cpp
e691d463515084518c94cdec3fbdf37be4a72977
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32744/diff/
Testing
---
Thanks,
Chi Zhang
-
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/31012/diff/
Testing
---
Thanks,
Chi Zhang
11712d7f378d9426f160d53b0387c698a28a4207
src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
Diff: https://reviews.apache.org/r/32756/diff/
Testing
---
Thanks,
Chi Zhang
-
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/31012/diff/
Testing
---
Thanks,
Chi Zhang
a memory statistics test for page cache.
Diffs
-
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/32754/diff/
Testing
---
Thanks,
Chi Zhang
/diff/
Testing
---
Thanks,
Chi Zhang
/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
Diff: https://reviews.apache.org/r/32757/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31012/#review77678
---
On April 1, 2015, 11:09 p.m., Chi Zhang wrote
://reviews.apache.org/r/31012/diff/
Testing
---
Thanks,
Chi Zhang
11712d7f378d9426f160d53b0387c698a28a4207
src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
Diff: https://reviews.apache.org/r/32755/diff/
Testing
---
Thanks,
Chi Zhang
---
Fixed indentation in mesos.proto.
Diffs
-
include/mesos/mesos.proto 0cbee3b188c2f55f6da16d064e1ae9266832d35b
Diff: https://reviews.apache.org/r/32728/diff/
Testing
---
Thanks,
Chi Zhang
generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/
---
(Updated April 1, 2015, 3:45 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse
achieve some high-level consensus
before diving right into it?
- Chi Zhang
On April 1, 2015, 3:45 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660
e691d463515084518c94cdec3fbdf37be4a72977
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32744/diff/
Testing
---
Thanks,
Chi Zhang
/network/port_mapping.cpp
e691d463515084518c94cdec3fbdf37be4a72977
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32744/diff/
Testing
---
Thanks,
Chi Zhang
df3211a0c25d7a16f36814886d14f81caaef2b9c
Diff: https://reviews.apache.org/r/31914/diff/
Testing
---
Thanks,
Chi Zhang
/containerizer/isolators/cgroups/mem.cpp
a7a83ef9ad4726aa139a92fc7f5917ed687d33f5
Diff: https://reviews.apache.org/r/31915/diff/
Testing
---
Thanks,
Chi Zhang
-mail. To reply, visit:
https://reviews.apache.org/r/31915/#review76770
---
On April 1, 2015, 10:28 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit
/network/port_mapping.cpp
e691d463515084518c94cdec3fbdf37be4a72977
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32744/diff/
Testing
---
Thanks,
Chi Zhang
-guide/
- Chi Zhang
On March 31, 2015, 11:11 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32659
/32656/#comment127117
how about also extract this out to be a 'helperPath', like what you did for
launchHelper in the other patch?
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/32656/#comment127116
having no output here isn't expected; why delay reporting it?
- Chi Zhang
: https://reviews.apache.org/r/30546/diff/
Testing
---
Thanks,
Chi Zhang
you can save the timeout logic here.
It'd be great see this in the library code!
- Chi Zhang
On March 31, 2015, 3:33 a.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/32655/#comment127087
Could you make it a bit more explict to say this variable is
mesos-containerizer *path*?
is the indent off by 1? ;)
- Chi Zhang
On March 31, 2015, 5:35 a.m., Paul Brett wrote:
---
This is an automatically
/diff/
Testing
---
Thanks,
Chi Zhang
-mail. To reply, visit:
https://reviews.apache.org/r/30546/#review77820
---
On March 27, 2015, 3:24 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply
/diff/
Testing
---
Thanks,
Chi Zhang
---
On March 27, 2015, 3:24 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review77819
---
On March 27, 2015, 3:18 a.m., Chi Zhang wrote
/cgroups.cpp a533b319fc75abb0fc45b8f5f473f257912d21ac
Diff: https://reviews.apache.org/r/30545/diff/
Testing
---
Thanks,
Chi Zhang
75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/memory_test_helper.hpp PRE-CREATION
src/tests/memory_test_helper.cpp PRE-CREATION
src/tests/memory_test_helper_main.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31276/diff/
Testing
---
Thanks,
Chi Zhang
., Jie Yu wrote:
src/tests/memory_test_helper.cpp, line 160
https://reviews.apache.org/r/31276/diff/6/?file=904736#file904736line160
Move this down after validation is done.
Also, s/memory/buffer/
Chi Zhang wrote:
that won't change the function frame size though
://reviews.apache.org/r/31276/#review9
---
On March 24, 2015, 10:15 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276
://reviews.apache.org/r/32405/#comment125957
curious why the const is dropped?
- Chi Zhang
On March 23, 2015, 5:05 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
Is this by design that you don't want to do this section in the above for
loop (over all files from ls)?
Also I think you can achieve this without using _linkers explictly.
- Chi Zhang
On March 25, 2015, 6:43 p.m., Jie Yu wrote
/32466/#comment126124
What's the need for unsetting it here?
- Chi Zhang
On March 25, 2015, 12:04 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32466
75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/memory_test_helper.hpp PRE-CREATION
src/tests/memory_test_helper.cpp PRE-CREATION
src/tests/memory_test_helper_main.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31276/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review76978
---
On March 24, 2015, 10:15 p.m., Chi Zhang wrote
---
On March 25, 2015, 12:03 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/
---
(Updated March 25, 2015
://reviews.apache.org/r/31444/
---
(Updated March 17, 2015, 10:44 p.m.)
Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, Jie Yu,
and James Peach.
Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350
points under newRoot private)?
src/slave/containerizer/mesos/launch.cpp
https://reviews.apache.org/r/31444/#comment125230
why not here just do the
pivot_root . old
chroot .
like the man page recommends?
- Chi Zhang
On March 17, 2015, 10:44 p.m., Ian Downes wrote
On March 21, 2015, 12:21 a.m., Chi Zhang wrote:
src/slave/containerizer/mesos/launch.cpp, line 296
https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line296
From my testing, you only need to make-slave on the newRoot for the
pivot_root to work
/
Testing
---
Thanks,
Chi Zhang
/diff/
Testing
---
Thanks,
Chi Zhang
---
On March 18, 2015, 6:32 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/
---
(Updated March 18, 2015, 6:32
On March 11, 2015, 9:59 p.m., Jie Yu wrote:
src/tests/memory_test_helper.cpp, line 100
https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line100
You need a comment explaining why fsync is necessary here.
Chi Zhang wrote:
confirmed it's not needed. i likedly
understanding is they are not from gtest, so
personally i think we should only use expect and assert in tests which are
gtest utilities. But this is obviously not the case currently.
- Chi Zhang
On March 17, 2015, 6:56 p.m., Paul Brett wrote
:).
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review76118
---
On March 10, 2015, 7:26 p.m., Chi Zhang wrote
On March 4, 2015, 10:01 p.m., Chi Zhang wrote:
src/linux/routing/filter/action.hpp, line 87
https://reviews.apache.org/r/31503/diff/1-2/?file=879070#file879070line87
could be just parent and child directly.
Cong Wang wrote:
What is mesos preferred coding style here?
I think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review76118
---
On March 10, 2015, 7:26 p.m., Chi Zhang wrote
/31276/#review76118
---
On March 10, 2015, 7:26 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276
:43 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/
---
(Updated Feb. 28, 2015, 1:43 a.m.)
Review
:
https://reviews.apache.org/r/30546/#review74647
---
On Feb. 28, 2015, 1:43 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/diff/
Testing
---
Thanks,
Chi Zhang
/cgroups.cpp a533b319fc75abb0fc45b8f5f473f257912d21ac
Diff: https://reviews.apache.org/r/30545/diff/
Testing
---
Thanks,
Chi Zhang
://reviews.apache.org/r/31276/diff/
Testing
---
Thanks,
Chi Zhang
6299ca4ba01b65daa3d75c64150e2738e32b841e
Diff: https://reviews.apache.org/r/31915/diff/
Testing
---
Thanks,
Chi Zhang
/31914/diff/
Testing
---
Thanks,
Chi Zhang
(updated)
-
src/Makefile.am d299f07d865080676ca8a550cf6005c6ab32839f
src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3
src/tests/type_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31784/diff/
Testing
---
Thanks,
Chi Zhang
:
https://reviews.apache.org/r/31250/#review73835
---
On March 6, 2015, 6:36 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
(updated)
---
Thanks,
Chi Zhang
d299f07d865080676ca8a550cf6005c6ab32839f
src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3
src/tests/type_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31784/diff/
Testing
---
Thanks,
Chi Zhang
: https://reviews.apache.org/r/31250/diff/
Testing
---
added a new test. the test is end-to-end so that future replacement of the
actual logic won't require a change.
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review75026
---
On March 4, 2015, 1:47 a.m., Chi Zhang wrote
/r/31502/#comment122211
unfold IOW?
- Chi Zhang
On March 4, 2015, 7:58 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502
/internal.hpp
https://reviews.apache.org/r/31503/#comment122206
Do you need to undo the previous step if this is an error?
- Chi Zhang
On March 4, 2015, 8:06 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75251
---
no diffs :)
- Chi Zhang
On March 4, 2015, 8:16 p.m., Cong Wang
to set it to
NONE.
flowId_(None())
- Chi Zhang
On March 4, 2015, 8:16 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501
will be inserted to your set??
- Chi Zhang
On March 4, 2015, 8:18 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505
://reviews.apache.org/r/31250/diff/
Testing
---
added a new test. the test is end-to-end so that future replacement of the
actual logic won't require a change.
Thanks,
Chi Zhang
and tids.
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review74837
---
On March 3, 2015, 7:37 p.m., Chi Zhang wrote
offline.
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review74837
---
On March 4, 2015, 1:47 a.m., Chi Zhang wrote
: https://reviews.apache.org/r/31250/diff/
Testing
---
added a new test. the test is end-to-end so that future replacement of the
actual logic won't require a change.
Thanks,
Chi Zhang
document kernel
issues in port_mapping.cpp)
src/tests/routing_tests.cpp
https://reviews.apache.org/r/31503/#comment121602
kill this line
src/tests/routing_tests.cpp
https://reviews.apache.org/r/31503/#comment121604
kill this line.
- Chi Zhang
On Feb. 27, 2015, 9:39 p.m., Cong Wang
On March 2, 2015, 9:36 p.m., Chi Zhang wrote:
src/tests/routing_tests.cpp, line 446
https://reviews.apache.org/r/31503/diff/1/?file=879078#file879078line446
If you can have a way to programmatically determine the existence of
this condition, this test should be checked before
you use.
src/slave/containerizer/isolators/network/port_mapping.cpp
https://reviews.apache.org/r/31505/#comment121675
add a period at the end of the line.
- Chi Zhang
On March 2, 2015, 5:21 p.m., Cong Wang wrote
are these numbers available from kernel header files?
- Chi Zhang
On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502
/
Testing
---
Thanks,
Chi Zhang
On Feb. 26, 2015, 11:19 p.m., Chi Zhang wrote:
A lot of tricky manuevers; likely have grasped it fully :)
s/have/haven not/
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444
/dev/pts
followed by either
$ rm /dev/ptmx
$ ln -s pts/ptmx /dev/ptmx
$ chmod 666 /dev/pts/ptmx
or
$ mount -o bind /dev/pts/ptmx /dev/ptmx
- Chi Zhang
On Feb. 25, 2015, 10:48 p.m., Ian Downes wrote
/tests/setns_test_helper_main.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31378/diff/
Testing
---
Thanks,
Chi Zhang
75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/memory_test_helper.hpp PRE-CREATION
src/tests/memory_test_helper.cpp PRE-CREATION
src/tests/memory_test_helper_main.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31276/diff/
Testing
---
Thanks,
Chi Zhang
75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/memory_test_helper.hpp PRE-CREATION
src/tests/memory_test_helper.cpp PRE-CREATION
src/tests/memory_test_helper_main.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31276/diff/
Testing
---
Thanks,
Chi Zhang
the next container comes in. This makes sure after a clean
shutdown, the sytem will be clean.
Diffs
-
src/slave/containerizer/isolators/network/port_mapping.cpp
b860b17e59486cd6097183a4d3139fbd5c897b44
Diff: https://reviews.apache.org/r/30958/diff/
Testing
---
Thanks,
Chi Zhang
/31378/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73637
---
Ship it!
confirmed this should fix the errors.
- Chi Zhang
. 23, 2015, 8:06 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/
---
(Updated Feb. 23, 2015, 8:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review73587
---
On Feb. 23, 2015, 8:06 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail
/cgroups.cpp a533b319fc75abb0fc45b8f5f473f257912d21ac
Diff: https://reviews.apache.org/r/30545/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review73591
---
On Feb. 24, 2015, 12:45 a.m., Chi Zhang wrote
://reviews.apache.org/r/31250/diff/
Testing
---
added a new test. the test is end-to-end so that future replacement of the
actual logic won't require a change.
Thanks,
Chi Zhang
a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/
---
(Updated Feb. 24, 2015, 12:45 a.m.)
Review
/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d
Diff: https://reviews.apache.org/r/30545/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review73359
---
On Feb. 22, 2015, 5:13 a.m., Chi Zhang wrote
1 - 100 of 286 matches
Mail list logo
