dependabot[bot] opened a new pull request, #5:
URL: https://github.com/apache/mina-asyncweb/pull/5
Bumps [mina-core](https://github.com/apache/mina) from 2.0.4 to 2.0.22.
Commits
https://github.com/apache/mina/commit/97df92e57a15ea60282a5310df0eefa8527d2286;>97df92e
dependabot[bot] opened a new pull request, #32:
URL: https://github.com/apache/mina/pull/32
Bumps [libthrift](https://github.com/apache/thrift) from 0.9.0 to 0.14.0.
Release notes
Sourced from https://github.com/apache/thrift/releases;>libthrift's
releases.
Version 0.14.0
tomaswolf closed pull request #228: README.md: Add triple DES CBC to the list
of supported ciphers
URL: https://github.com/apache/mina-sshd/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tomaswolf closed pull request #229: README.md: Change implementation detail
lists to header items
URL: https://github.com/apache/mina-sshd/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tomaswolf commented on PR #229:
URL: https://github.com/apache/mina-sshd/pull/229#issuecomment-1166567696
Rebased and submitted as commit 20d4e1ce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tomaswolf commented on PR #228:
URL: https://github.com/apache/mina-sshd/pull/228#issuecomment-1166567440
Squash-merged as commit 818c8fc89.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
davido commented on PR #229:
URL: https://github.com/apache/mina-sshd/pull/229#issuecomment-1166476432
FYI, this is the request on Gerrit Code Review project to link to external
documentation: [1]
And this is for example how the `Ciphers` could be linked directly
externally
davido commented on code in PR #228:
URL: https://github.com/apache/mina-sshd/pull/228#discussion_r906786990
##
README.md:
##
@@ -59,7 +59,7 @@ based applications requiring SSH support.
* **Authentication methods**: hostbased, publickey, [OpenSSH host-based
davido opened a new pull request, #229:
URL: https://github.com/apache/mina-sshd/pull/229
Doing this would allow projects to include external links to the
implementation specific section in upstream documentation.
--
This is an automated message from the Apache Git Service.
To respond
tomaswolf commented on code in PR #228:
URL: https://github.com/apache/mina-sshd/pull/228#discussion_r906783182
##
README.md:
##
@@ -59,7 +59,7 @@ based applications requiring SSH support.
* **Authentication methods**: hostbased, publickey, [OpenSSH host-based
tomaswolf merged PR #227:
URL: https://github.com/apache/mina-sshd/pull/227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf commented on PR #227:
URL: https://github.com/apache/mina-sshd/pull/227#issuecomment-1156165890
All right. The MINA problems are resolved now. It looks as if this
shutdownOutputStream() stuff was never tested with MINA at all; when SSHD-902
was done, the core tests didn't even
tomaswolf commented on PR #227:
URL: https://github.com/apache/mina-sshd/pull/227#issuecomment-1153808927
Looks indeed like something is wrong with MINA now. It's in particular the
sftp tests when run with MINA.
--
This is an automated message from the Apache Git Service.
To respond to
tomaswolf commented on PR #227:
URL: https://github.com/apache/mina-sshd/pull/227#issuecomment-1153670945
Some tests appear to run much slower now. In particular the sshd-mina and
sshd-sftp tests. I didn't notice any such slowdown when building locally.
Perhaps a fluke of the GitHub CI?
tomaswolf commented on code in PR #227:
URL: https://github.com/apache/mina-sshd/pull/227#discussion_r895227586
##
sshd-core/pom.xml:
##
@@ -110,6 +110,24 @@
testcontainers
test
+
+io.grpc
+grpc-netty-shaded
+
lgoldstein commented on code in PR #227:
URL: https://github.com/apache/mina-sshd/pull/227#discussion_r895205770
##
sshd-core/pom.xml:
##
@@ -110,6 +110,24 @@
testcontainers
test
+
+io.grpc
+grpc-netty-shaded
+
tomaswolf opened a new pull request, #227:
URL: https://github.com/apache/mina-sshd/pull/227
Propagate an EOF on a tunnel for port forwarding to the socket by
shutting down its output; otherwise the client connected to that
socket may hang.
Fix the MINA transport back-end to not
dependabot[bot] closed pull request #219: Bump mina-core from 2.0.22 to 2.1.5
URL: https://github.com/apache/mina-sshd/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #219:
URL: https://github.com/apache/mina-sshd/pull/219#issuecomment-1153224658
Looks like org.apache.mina:mina-core is up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tomaswolf merged PR #225:
URL: https://github.com/apache/mina-sshd/pull/225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf merged PR #226:
URL: https://github.com/apache/mina-sshd/pull/226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf opened a new pull request, #226:
URL: https://github.com/apache/mina-sshd/pull/226
PortForwardingTest seems to hang occasionally when run in Github CI on
Windows. Since the build log doesn't even show which test it hangs at,
and build pod's file system isn't available anymore
tomaswolf merged PR #224:
URL: https://github.com/apache/mina-sshd/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf merged PR #213:
URL: https://github.com/apache/mina-sshd/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf commented on PR #213:
URL: https://github.com/apache/mina-sshd/pull/213#issuecomment-1139406292
> I think the main README.md (or the relevant sub-document) should also be
updated so as to list this new supported KEX as well.
Done. Added a mention of implemented
lgoldstein commented on PR #213:
URL: https://github.com/apache/mina-sshd/pull/213#issuecomment-1139283212
I think the main README.md (or the relevant sub-document) should also be
updated so as to list this new supported KEX as well.
--
This is an automated message from the Apache Git
tomaswolf commented on code in PR #213:
URL: https://github.com/apache/mina-sshd/pull/213#discussion_r883058111
##
sshd-common/src/main/java/org/apache/sshd/common/kex/extension/parser/HostBoundPubkeyAuthentication.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
lgoldstein commented on code in PR #213:
URL: https://github.com/apache/mina-sshd/pull/213#discussion_r882909068
##
sshd-common/src/main/java/org/apache/sshd/common/kex/extension/parser/HostBoundPubkeyAuthentication.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
dependabot[bot] closed pull request #3: Bump spring-core from 2.0.8 to 5.3.19
URL: https://github.com/apache/mina-asyncweb/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #3:
URL: https://github.com/apache/mina-asyncweb/pull/3#issuecomment-1136785659
Superseded by #4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #4:
URL: https://github.com/apache/mina-asyncweb/pull/4
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 2.0.8 to 5.2.22.RELEASE.
Release notes
Sourced from
dependabot[bot] closed pull request #220: Bump spring-core from 5.3.14 to 5.3.19
URL: https://github.com/apache/mina-sshd/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #220:
URL: https://github.com/apache/mina-sshd/pull/220#issuecomment-1136765166
Superseded by #225.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #225:
URL: https://github.com/apache/mina-sshd/pull/225
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.14 to 5.3.20.
Release notes
Sourced from
saingsocheat commented on PR #29:
URL: https://github.com/apache/mina/pull/29#issuecomment-1136131366
mina-core/src/main/java/org/apache/mina/core/service/IoServiceStatistics.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tomaswolf commented on PR #213:
URL: https://github.com/apache/mina-sshd/pull/213#issuecomment-1135731752
alpine 3.16 is out now, and it comes with OpenSSH 9.0p1. So it should be
possible to write an automated integration test for this now.
--
This is an automated message from the Apache
tomaswolf opened a new pull request, #224:
URL: https://github.com/apache/mina-sshd/pull/224
Handling of global requests with want-reply=true was synchronous. This
is fine if the call is made on a non-I/O thread, but to be able to use
global requests in I/O threads, an asynchronous
tomaswolf merged PR #223:
URL: https://github.com/apache/mina-sshd/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lgoldstein commented on PR #223:
URL: https://github.com/apache/mina-sshd/pull/223#issuecomment-1126982558
> I was not able to determine whether pending peer packets are flushed
before EOF is sent and the channel is closed.
>> They should be. On a graceful close, the channel first
tomaswolf commented on PR #223:
URL: https://github.com/apache/mina-sshd/pull/223#issuecomment-1126797276
BTW: apparently this also fixes SSHD-1256.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tomaswolf commented on PR #223:
URL: https://github.com/apache/mina-sshd/pull/223#issuecomment-1126787277
> I was not able to determine whether pending peer packets are flushed
before EOF is sent and the channel is closed.
They should be. On a graceful close, the channel first closes
lgoldstein commented on PR #223:
URL: https://github.com/apache/mina-sshd/pull/223#issuecomment-1126780490
Seems OK to me - I like your approach - much cleaner. I do have one concern
- I was not able to determine whether pending peer packets are flushed before
EOF is sent and the channel
tomaswolf opened a new pull request, #223:
URL: https://github.com/apache/mina-sshd/pull/223
TCP/IP port forwarding started reading on the local port before the SSH
tunnel was established, i.e., before SSH_MSG_CHANNEL_OPEN_CONFIRMATION
was received. It buffered data until then, and
lgoldstein closed pull request #218: [SSHD-1261] Fixed possible pending
unfinished pending write request if ChannelAsyncOutputStream closed prematurely
URL: https://github.com/apache/mina-sshd/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message,
lgoldstein commented on PR #218:
URL: https://github.com/apache/mina-sshd/pull/218#issuecomment-1126191201
Agreed - discarding it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vukzeka commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1125839242
> Looks fine to me. I'll download, undo Lyor's maven formatter change,
rebase, run the tests locally, and if successful squash-merge this later.
Thanks @tomaswolf
--
This is an
tomaswolf commented on PR #218:
URL: https://github.com/apache/mina-sshd/pull/218#issuecomment-1125757166
This is obsolete; should be fixed with the changes made in commit 1ab50fe2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tomaswolf merged PR #222:
URL: https://github.com/apache/mina-sshd/pull/222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lgoldstein commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1125229695
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lgoldstein commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1125204883
@tomaswolf
> please downgrade the formatter maven plug-in again. (Revert commit
https://github.com/apache/mina-sshd/commit/9f8aa3dbafe3934bad661d36a1d6bf20e80baada.)
It
vukzeka commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1124693963
> Looks good, some minor comments.
>
> I notice that the tests add the options already in the correct order. Now
that we do sort I'd suggest to change the tests to add them in a
vukzeka commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1124693099
> @vukzeka I just pushed a commit
[alex-sherwin@f5966b4](https://github.com/alex-sherwin/mina-sshd/commit/f5966b48e3ac2ab375269aae553c765cf62488cf)
>
> It shows how to use
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r871096735
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -267,4 +275,38 @@ public OpenSshCertificate sign(KeyPair caKeypair, String
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r871043739
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -267,4 +275,38 @@ public OpenSshCertificate sign(KeyPair caKeypair,
alex-sherwin commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1124459535
@vukzeka I just pushed a commit
https://github.com/alex-sherwin/mina-sshd/commit/f5966b48e3ac2ab375269aae553c765cf62488cf
It shows how to use testcontainers to build an image
vukzeka commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1124402694
> As I noted on https://issues.apache.org/jira/browse/SSHD-1266
>
> The original PR's for the OpenSSH certificate support brought in support
for Testcontainers based Docker unit
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870828179
##
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##
@@ -154,7 +150,12 @@ public void signCertificate() throws
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870774200
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870480760
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870397695
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870397695
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870197910
##
sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java:
##
@@ -348,29 +348,36 @@ public List
getCertificateOptions() {
/**
*
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870194796
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870194796
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870194796
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870072991
##
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##
@@ -154,7 +150,12 @@ public void signCertificate() throws
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870069420
##
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##
@@ -154,7 +150,12 @@ public void signCertificate() throws
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870067540
##
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##
@@ -154,7 +150,12 @@ public void signCertificate() throws
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870062043
##
sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java:
##
@@ -348,29 +348,36 @@ public List
getCertificateOptions() {
/**
*
vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870060409
##
sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java:
##
@@ -348,29 +348,36 @@ public List
getCertificateOptions() {
/**
*
alex-sherwin commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1122693618
As noted on https://issues.apache.org/jira/browse/SSHD-1266
The original PR's for the OpenSSH certificate support brought in support for
Testcontainers based Docker unit
tomaswolf commented on PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1122660236
@lgoldstein : please downgrade then formatter maven plug-in again. (Revert
commit 9f8aa3dba.) It doesn't run with Java 1.8.
--
This is an automated message from the Apache Git
tomaswolf commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r869384180
##
sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateBuilder.java:
##
@@ -104,7 +110,21 @@ public OpenSshCertificateBuilder
principals(Collection
lgoldstein commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r869427309
##
sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java:
##
@@ -348,29 +348,36 @@ public List
getCertificateOptions() {
/**
*
vukzeka opened a new pull request, #222:
URL: https://github.com/apache/mina-sshd/pull/222
- fixed bug with CertificateOption data encoding
- Improved CertificateOption docs
- Added critical option ordering and duplicate check
- updated tests to include critical options
--
This
vukzeka commented on PR #198:
URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-1120832432
@alex-sherwin @tomaswolf this is amazing feature, allowing applying best
practices for SSH auth but also more secure.
Though, I have noticed one issue and thought good to report.
tomaswolf merged PR #217:
URL: https://github.com/apache/mina-sshd/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf merged PR #221:
URL: https://github.com/apache/mina-sshd/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lgoldstein commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857860639
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelOutputStream.java:
##
@@ -171,43 +227,52 @@ public synchronized void write(byte[] buf, int s, int l)
jtnord opened a new pull request, #221:
URL: https://github.com/apache/mina-sshd/pull/221
tested on windows this reproduces the issue observed.
Not a particularly nice test but it works.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tomaswolf commented on PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1108173323
> I'll see if the Gerrit team can run their test suite with this.
https://bugs.chromium.org/p/gerrit/issues/detail?id=12758#c8
--
This is an automated message from the Apache
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857179062
##
sshd-core/src/main/java/org/apache/sshd/client/session/ClientUserAuthService.java:
##
@@ -124,7 +128,15 @@ public Map getProperties() {
@Override
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857179032
##
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/KeyExchangeMessageHandler.java:
##
@@ -0,0 +1,485 @@
+/*
+ * Licensed to the Apache Software
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178945
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelOutputStream.java:
##
@@ -171,43 +227,52 @@ public synchronized void write(byte[] buf, int s, int l)
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178648
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelOutputStream.java:
##
@@ -50,12 +64,15 @@ public class ChannelOutputStream extends OutputStream
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178603
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java:
##
@@ -282,4 +435,43 @@ public boolean
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178553
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelOutputStream.java:
##
@@ -42,6 +43,19 @@
* @author mailto:dev@mina.apache.org;>Apache MINA SSHD
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178527
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java:
##
@@ -282,4 +435,43 @@ public boolean
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178515
##
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java:
##
@@ -90,52 +93,174 @@ public byte getCommandType() {
return cmd;
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178494
##
sshd-core/src/main/java/org/apache/sshd/client/session/ClientUserAuthService.java:
##
@@ -70,6 +70,10 @@ public class ClientUserAuthService extends
tomaswolf commented on PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1107904736
There is no hurry. I'll see if the Gerrit team can run their test suite with
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
lgoldstein commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857153738
##
sshd-core/src/main/java/org/apache/sshd/client/session/ClientUserAuthService.java:
##
@@ -70,6 +70,10 @@ public class ClientUserAuthService extends
lgoldstein commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857153233
##
docs/kex.md:
##
@@ -0,0 +1,131 @@
+## SSH Key Exchange
+
+**Key Exchange** (or **KEX** for short) is a sub-protocol in the SSH protocol
+enabling the two parties
tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r856861589
##
docs/kex.md:
##
@@ -0,0 +1,131 @@
+## SSH Key Exchange
Review Comment:
It was your idea. :-)
--
This is an automated message from the Apache Git Service.
dependabot[bot] commented on PR #2:
URL: https://github.com/apache/mina-asyncweb/pull/2#issuecomment-1107147513
Superseded by #3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] closed pull request #2: Bump spring-core from 2.0.8 to 5.3.18
URL: https://github.com/apache/mina-asyncweb/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #3:
URL: https://github.com/apache/mina-asyncweb/pull/3
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 2.0.8 to 5.3.19.
Release notes
Sourced from
dependabot[bot] closed pull request #215: Bump spring-core from 5.3.14 to 5.3.18
URL: https://github.com/apache/mina-sshd/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #215:
URL: https://github.com/apache/mina-sshd/pull/215#issuecomment-1106879919
Superseded by #220.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #220:
URL: https://github.com/apache/mina-sshd/pull/220
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.14 to 5.3.19.
Release notes
Sourced from
401 - 500 of 1791 matches
Mail list logo
