alex-sherwin edited a comment on pull request #198:
URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-849946102
I believe the build failure is unrelated / transient... I observed the
[almost same, test PR] working here previously:
alex-sherwin commented on pull request #198:
URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-849946102
I believe the build failure is unrelated / transient...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alex-sherwin opened a new pull request #198:
URL: https://github.com/apache/mina-sshd/pull/198
This adds new OpenSshCertificateSigner & OpenSshCertificateSignRequest types
which are used to use a CA KeyPair to sign a OpenSshCertificateSignRequest,
resulting in an instance of
tomaswolf commented on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849853674
@alex-sherwin sorry about that. I had been thinking about Instant, too, but
in the end I decided to just remove these two methods since I didn't need them.
Converting to
alex-sherwin edited a comment on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849821398
I have a pending PR I was going to open tonight that touches some of this
too, and in mine I changed the `OpenSshCertificate` valid before/after
variables to
alex-sherwin commented on pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849821398
I have a pending PR I was going to open tonight that touches some of this
too, and in mine I changed the `OpenSshCertificate` valid before/after
variables to `Instant` as
alex-sherwin commented on pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#issuecomment-849758671
I updated this to only work based on the parsed `Host` entries so it cannot
impact anything else
--
This is an automated message from the Apache Git Service.
To respond
tomaswolf merged pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
tomaswolf opened a new pull request #197:
URL: https://github.com/apache/mina-sshd/pull/197
Fixes:
- Comparing certificate timestamps as unsigned longs
- Test certificates without expiration date
- Checking for correct certificate types (user/host) being used in correct
avnerw74 opened a new issue #1:
URL: https://github.com/apache/mina-ftpserver/issues/1
Hi,
I would like to know is there a way to limit the server only to listen for
TLS 1.2 and block older versions (TLS1.1, TLS1.0 or SSLv3).
Thanks,
Avner
--
This is an automated
tomaswolf commented on pull request #192:
URL: https://github.com/apache/mina-sshd/pull/192#issuecomment-842029042
This was merged as commit 9a724be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jvz commented on a change in pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#discussion_r633122293
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/kex/MontgomeryCurve.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software
tomaswolf closed pull request #192:
URL: https://github.com/apache/mina-sshd/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
tomaswolf edited a comment on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841858902
Good points. I suggest we do both in follow-up changes.
* Validation of the certificate type would also have to happen in the
server-side code (client
tomaswolf merged pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841716792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
FliegenKLATSCH commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841791524
Nice work, two comments from my side:
- If we have the `SIGNATURE_ALGORITHM_MAP` now, we should remove the
tomaswolf commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841738244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r633015923
##
File path:
sshd-common/src/main/java/org/apache/sshd/common/cipher/ChaCha20Cipher.java
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software
jvz commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r633006067
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841722942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841733479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
tomaswolf merged pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-842030945
The build failures are unrelated. There are unstable tests. Going to merge
this as is.
--
This is an automated message from the Apache Git Service.
To respond to the
tomaswolf commented on pull request #192:
URL: https://github.com/apache/mina-sshd/pull/192#issuecomment-842029042
This was merged as commit 9a724be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tomaswolf closed pull request #192:
URL: https://github.com/apache/mina-sshd/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841895961
That one hasn't failed for me locally, though I've seen the SFTP transfer
test randomly hang once in a while.
--
This is an automated message from the Apache Git Service.
To
tomaswolf commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841889632
LoadTest is unstable for me locally. Didn't dig deep; my suspicion is that
in that test the channel gets closed sometimes before all data has been written
back to the client.
tomaswolf edited a comment on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841858902
Good points. I suggest we do both in follow-up changes.
* Validation of the certificate type would also have to happen in the
server-side code (client
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841858902
Good points. I suggest we do both in follow-up changes.
* Validation of the certificate type would also to happen in the server-side
code (client certificate presented
jvz commented on a change in pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#discussion_r633122740
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/kex/MontgomeryCurve.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software
jvz commented on a change in pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#discussion_r633122293
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/kex/MontgomeryCurve.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841809759
@tomaswolf The rebase looks good to me, I'm happy with the PR as-is
However I'm also happy to make the changes suggested by @FliegenKLATSCH, or,
start a separate PR
FliegenKLATSCH commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841791524
Nice work, two comments from my side:
- If we have the `SIGNATURE_ALGORITHM_MAP` now, we should remove the
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841789777
Done. Take a look and if OK with you, I'd merge like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841739897
That's good with me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tomaswolf commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841738244
> I don't see why the CI build is failing. Works on my machine.
Neither do I. Maybe just an unstable test?
--
This is an automated message from the Apache Git
tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r633015923
##
File path:
sshd-common/src/main/java/org/apache/sshd/common/cipher/ChaCha20Cipher.java
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841737411
I don't see why the CI build is failing. Works on my machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841735774
> If possible could you make the commit w/ the main code changes by Alec and
mention me instead?
>
> He did stay up pretty late to sort out the final implementation :)
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841735704
Also, I tested this with Java 15 (openjdk version "15.0.2" 2021-01-19) which
was the latest JDK in Homebrew.
--
This is an automated message from the Apache Git Service.
To
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841733479
I've ported in the code I mentioned earlier. Based on files from my other
project (ISC licensed, but with my ICLA on file, this is dual-licensed here as
Apache 2.0):
*
jvz commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r633006067
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841722942
@tomaswolf If possible could you make the commit w/ the main code changes by
Alec and mention me instead?
He did stay up pretty late to sort out the final
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841716792
This looks great. Thanks a lot! The PR now contains a lot of commits that
leave intermediary stages in the repo and a lot of clean-up commits, and
merging in master in the
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841696961
Let me clarify the IP provenance then. I have two versions of ChaCha20 and
Poly1305 in my O(1) Cryptography library. There's a Java port that I wrote
based on DJB's papers about
alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632983368
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632983368
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632983368
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632982475
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632982475
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632982393
##
File path:
sshd-common/src/test/java/org/apache/sshd/util/test/ContainerTestCase.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632982244
##
File path:
sshd-common/src/test/java/org/apache/sshd/util/test/ContainerTestCase.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software
tomaswolf commented on pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#issuecomment-841691677
> When running the unit test suite that read my `~/.ssh/config` file
Completely unrelated: I noticed this, too, and I think this is a bug in the
test setups. They
tomaswolf commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632981358
##
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##
@@ -1087,6 +1087,7 @@ public static void
lgoldstein commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841605597
>> At least in the case of ChaCha, there is indeed an undeniably public
domain base in the OpenSSH sources[1] (original at [2]), and Matt is an Apache
member. So this should
alex-sherwin opened a new pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196
The `ssh_config` defines this a bit vaguely as:
```
If more than one pattern is provided, they should be separated by whitespace.
```
When running the unit test suite that read
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841459875
The Windows VM's do have docker, but it's windows-native docker (does anyone
really use that?):
tomaswolf commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841459222
> [...] cleared it with the relevant legal teams (which we should do to
**every** piece of code we import...)
At least in the case of ChaCha, there is indeed an
tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632749447
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
jvz commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632719666
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
lgoldstein commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-841373267
>> Don't know what the stance of the other maintainers is on having more
crypto code inside sshd.
I am not opposed to it, but I am reluctant to doing this - especially
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841215391
No, not really. A profile was just the first thing that I thought of. An
unsuspecting user who doesn't have docker on his machine should probably still
be able to run a maven
alex-sherwin commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841207925
Hi @tomaswolf, is there a particular way you would prefer this to be done?
I'm sure I can figure something out with maven profiles and the OS conditional
checks, but
tomaswolf commented on pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841167902
Looks like the windows VMs used in the test builds don't have docker? We
might have to make this test run conditionally on non-Windows only. Maybe with
a profile that we'd
tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632393865
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
jvz commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632238603
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632209646
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632209342
##
File path: sshd-core/pom.xml
##
@@ -105,8 +105,25 @@
ganymed-ssh2
test
+
+
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632208904
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632007282
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631967562
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631938991
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631938991
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631930497
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631929672
##
File path:
sshd-core/src/test/java/org/apache/sshd/client/opensshcerts/ClientOpenSSHCertificatesTest.java
##
@@ -0,0 +1,152 @@
+package
tomaswolf commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r631895469
##
File path: sshd-core/pom.xml
##
@@ -105,8 +105,25 @@
ganymed-ssh2
test
+
+org.testcontainers
maxTraydakalo opened a new pull request #195:
URL: https://github.com/apache/mina-sshd/pull/195
Wrong server key type algorithm choose (in case of use rsa-sha2-256 and
rsa-sha2-512 always identify like ssh-rsa) in case of usage DHFactories with
group exchange.
--
This is an automated
alex-sherwin opened a new pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194
Fully implements https://issues.apache.org/jira/browse/SSHD-1161
This PR covers using OpenSSH client certificate publickey authentication
from the MINA client code
It's unit tested
softwarecancer closed pull request #193:
URL: https://github.com/apache/mina-sshd/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
softwarecancer opened a new pull request #193:
URL: https://github.com/apache/mina-sshd/pull/193
Added functionality to compare OpenSSH certificate keys
Added signature algorithm function into KeyUtils to set the desired
signature algorithm for the negotiated chosen algorithm. Made use
alex-sherwin commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-837685993
@gnodet @tomaswolf I've opened a JIRA here
https://issues.apache.org/jira/browse/SSHD-1161 for this work
A colleague & myself should hopefully have a PR ready in the
jvz commented on pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#issuecomment-836754721
Same for this. I'll revisit to clean up sometime in the next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jvz commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-836750819
I'll need to revisit this PR. I've done a lot more cryptography work since
then, and I probably have some simplifications now.
--
This is an automated message from the Apache
gnodet edited a comment on pull request #60:
URL: https://github.com/apache/mina-sshd/pull/60#issuecomment-836735194
> I can't reproduce the problem, and I'm skeptical how it can happen. The
reason is that the `onChannelOpened` is called when the
`SSH_MSG_CHANNEL_OPEN_CONFIRMATION`
gnodet edited a comment on pull request #60:
URL: https://github.com/apache/mina-sshd/pull/60#issuecomment-836735194
> I can't reproduce the problem, and I'm skeptical how it can happen. The
reason is that the `onChannelOpened` is called when the
`SSH_MSG_CHANNEL_OPEN_CONFIRMATION`
gnodet commented on pull request #60:
URL: https://github.com/apache/mina-sshd/pull/60#issuecomment-836735194
> I can't reproduce the problem, and I'm skeptical how it can happen. The
reason is that the `onChannelOpened` is called when the
`SSH_MSG_CHANNEL_OPEN_CONFIRMATION` message is
gnodet commented on pull request #60:
URL: https://github.com/apache/mina-sshd/pull/60#issuecomment-836715575
I can't reproduce the problem, and I'm skeptical how it can happen. The
reason is that the `onChannelOpened` is called when the
`SSH_MSG_CHANNEL_OPEN_CONFIRMATION` message is
alex-sherwin commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836683227
@gnodet @tomaswolf
Sure, I didn't mean to start a whole thread here, was originally just
looking to solicit info on what may be missing from this PR's original
gnodet commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836580016
@alex-sherwin it could be a good idea to open a different issue as this PR
is actually closed.
--
This is an automated message from the Apache Git Service.
To respond to the
gnodet commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836578989
> This is definitely going in the right direction, but will need more work
before it could be incorporated into the main code.
>
> As for testing: I think testing against
tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r629230095
##
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##
@@ -70,6 +70,7 @@
*/
public static final List
tomaswolf commented on pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#issuecomment-836495509
A test would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gnodet commented on pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-836486686
@jvz What's the status of this PR ? We're planning a 2.7.0 release this
week, so wondering if I should merge this PR in.
--
This is an automated message from the Apache Git
gnodet commented on pull request #177:
URL: https://github.com/apache/mina-sshd/pull/177#issuecomment-836486282
@jvz What's the status of this PR ? We're planning a 2.7.0 release this
week, so wondering if I should merge this PR in.
--
This is an automated message from the Apache Git
gnodet opened a new pull request #192:
URL: https://github.com/apache/mina-sshd/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
gnodet merged pull request #189:
URL: https://github.com/apache/mina-sshd/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
tomaswolf commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836265703
This is definitely going in the right direction, but will need more work
before it could be incorporated into the main code.
As for testing: I think testing against a
alex-sherwin edited a comment on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836101298
I've cleaned up an implementation that works well for all currently
supported OpenSSH certificate formats on my fork (diff preview:
alex-sherwin commented on pull request #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836101298
I've cleaned up an implementation that works well for all currently
supported OpenSSH certificate formats on my fork (diff preview:
801 - 900 of 1791 matches
Mail list logo
